From patchwork Wed Jul 12 14:00:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 107518 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp852494qge; Wed, 12 Jul 2017 07:02:59 -0700 (PDT) X-Received: by 10.237.62.132 with SMTP id n4mr6417493qtf.0.1499868179329; Wed, 12 Jul 2017 07:02:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499868179; cv=none; d=google.com; s=arc-20160816; b=Vu6KL+89ciFCANhQgYOQC3SqnogSEo5vJgy8Sg0Yakx3DtLKhBF+Nv0uYoPFEO2kH9 W5celwLYBffG3LbRJN3Ic+qLZbh4FV3rEp9ckJbmFwCeTFgU+wkx1jobV42DX2LnGMjn WeH6yFmptwvytalCK5XMw3SXK2cWigDhRaB203LQioSiVWULM1Bj48viWrmhoCVYg31K PhSw/4f8hKUQ1lHnq4xi6iIOSQI96N+829TpOBAKpCRJ/iMZc8zPHMQ0iO0bHDbtsu/x GpvW1PyuqcCyDMBgLpZNu3tMKo8qDjzpK6PoxexUmicQZ64DV0Z1ot2DyHjN6tYfLkHJ hs/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=Jmbx45wuXtc5GFnSiwUo76TL5YOpqs0i/ufwdJmm8Pc=; b=vJd2tsOw2aQYPBTh7F7O+bKaJaZ01J6JheCEy8uPeDKWejnxTa8frrXikYRkaB+q7E EyQegdn+KYf2n+BHM6coH99e7LHPIALjEMQH39ZK3QuIElttp15z32gmbpgn3XITtBgM h8fxniqvb5P0tshQO0HX3doPgwRD4ML5ZLzPlUsSVC/aLV5XCGV70N84guOYB3lrSLIb 4xkw0Fn8NZkX8ZqCKMQncZxLH6zPn+XzMdYrYPz6luUt6/jzWAqvHL0/yl93+Vc7qGdR T74G1/5lLe934pD58E+DbRkzaWSgDcK/xJzfEnqQf7cDslFu7fUmppeVWMTZr//fjTyw dSbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 76si2474845qky.11.2017.07.12.07.02.59; Wed, 12 Jul 2017 07:02:59 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id E32FF644E5; Wed, 12 Jul 2017 14:02:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id DC5EB6088B; Wed, 12 Jul 2017 14:02:31 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 10241644D1; Wed, 12 Jul 2017 14:02:24 +0000 (UTC) Received: from forward2m.cmail.yandex.net (forward2m.cmail.yandex.net [5.255.216.20]) by lists.linaro.org (Postfix) with ESMTPS id 817C960637 for ; Wed, 12 Jul 2017 14:00:39 +0000 (UTC) Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [95.108.252.166]) by forward2m.cmail.yandex.net (Yandex) with ESMTP id 4D14A21633 for ; Wed, 12 Jul 2017 17:00:38 +0300 (MSK) Received: from smtp4p.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp4p.mail.yandex.net (Yandex) with ESMTP id F2EBB65012D7 for ; Wed, 12 Jul 2017 17:00:24 +0300 (MSK) Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id blQPLGFwg5-0MJuaHUE; Wed, 12 Jul 2017 17:00:22 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 12 Jul 2017 17:00:11 +0300 Message-Id: <1499868014-26323-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> References: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 74 Subject: [lng-odp] [PATCH API-NEXT v2 1/4] validation: crypto: fix unitialized variable error X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch: https://github.com/Linaro/odp/pull/74.patch ** Base sha: ee5be324411a7520528a367967c28fc529d3bc2e ** Merge commit sha: 5411462e6545fa2d6a286a40c2057db97714ee74 **/ test/common_plat/validation/api/crypto/odp_crypto_test_inp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c index d5549493..716bd952 100644 --- a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c @@ -303,7 +303,7 @@ static void alg_test(odp_crypto_op_t op, odp_crypto_capability_t capa; int rc; odp_crypto_ses_create_err_t status; - odp_bool_t ok; + odp_bool_t ok = false; odp_crypto_session_param_t ses_params; uint8_t *data_addr; odp_crypto_cipher_capability_t cipher_capa[MAX_ALG_CAPA]; From patchwork Wed Jul 12 14:00:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 107520 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp857050qge; Wed, 12 Jul 2017 07:06:11 -0700 (PDT) X-Received: by 10.200.47.176 with SMTP id l45mr6800801qta.153.1499868371711; Wed, 12 Jul 2017 07:06:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499868371; cv=none; d=google.com; s=arc-20160816; b=c22naMEYbJFf0xiCyWUFuKui1PD2BKjo3ERc03Ne2XT8y9ZYYMclJmqlP0WT2s8VLU 4DYObFOKlKmjIxsoWqdoLYOZ2XcNiir/Xrk6BE4alRaxPumdYcGQAdXkB8JCemFNzRWn lZdj8DodzbtjAjV8HuD+bZFaRTtqqZuWUVtVwzlzDUYnRI5mltYJzxSAtCXdMzdldndt qyXnAS4KTpwLpzdzaUlsl8AaY+kJ1P7eLFKvZ9kM28y52BUlLR4t8nPr3GlpzZKkwrll HlmCZQoWlZMav0nZV9Z6LpARB/cLFqIYD2GWvsXznMQAcZxoxTTQkDs7o1TV6LKQKH+W PNYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=j4IZFm0ExpzAwQBANUPnbu1GfC/A3OMt3vr9LOJSUGU=; b=w7Tys5UM/vWb1A2fLl6/zKjNkABf05EL06jRkRTJ87A3UM6kpis3p2RFrwncyPu75j 63oj/xmoGdYc1MrUTJrWa+R96NyQu8y4VxBd5rlOwmudeqIVQcJkjfmtHxc3XTluU56b 8owv4vu0c3gu4tZ0901nFBc+taY2kuiwjq2oVBy7gFdo74d1WM+X3Km3zhkhFS7iRs07 NrIs0k/XQ4RB6Rx/qSNpPycelJM1iSxh0XSTzGOiziJvFIJe+khxuy3+SSiHDIHBqpgA vHCVzJAcVHvd3Yre1CnlSM8l5abvmdJxBIQ6U316TSqEkjlwaXuTnrdijB7JxTsfok/O prMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 47si2391265qtw.101.2017.07.12.07.06.11; Wed, 12 Jul 2017 07:06:11 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 4BCF0644D4; Wed, 12 Jul 2017 14:06:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3CCED60A24; Wed, 12 Jul 2017 14:02:52 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0A501644D6; Wed, 12 Jul 2017 14:02:48 +0000 (UTC) Received: from forward2m.cmail.yandex.net (forward2m.cmail.yandex.net [5.255.216.20]) by lists.linaro.org (Postfix) with ESMTPS id C30BA644D6 for ; Wed, 12 Jul 2017 14:00:55 +0000 (UTC) Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [95.108.252.166]) by forward2m.cmail.yandex.net (Yandex) with ESMTP id C6DE9215CB for ; Wed, 12 Jul 2017 17:00:54 +0300 (MSK) Received: from smtp4p.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp4p.mail.yandex.net (Yandex) with ESMTP id 961D06501282 for ; Wed, 12 Jul 2017 17:00:28 +0300 (MSK) Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id blQPLGFwg5-0QJWGcMc; Wed, 12 Jul 2017 17:00:26 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 12 Jul 2017 17:00:12 +0300 Message-Id: <1499868014-26323-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> References: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 74 Subject: [lng-odp] [PATCH API-NEXT v2 2/4] doc: move PREDEFINED to common place X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov It is easy to update PREDEFINED definitions in one Doxyfile, while forgetting about the others, as happened e.g. with ODP_DEPRECATE(x) definition. Move PREDEFINED definitions into Doxyfile_common, so that it is included by the rest of Doxyfiles. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch: https://github.com/Linaro/odp/pull/74.patch ** Base sha: ee5be324411a7520528a367967c28fc529d3bc2e ** Merge commit sha: 5411462e6545fa2d6a286a40c2057db97714ee74 **/ doc/Doxyfile_common | 12 ++++++++++++ doc/application-api-guide/Doxyfile | 2 -- doc/driver-api-guide/Doxyfile | 8 -------- doc/helper-guide/Doxyfile | 8 -------- doc/platform-api-guide/Doxyfile | 9 --------- 5 files changed, 12 insertions(+), 27 deletions(-) diff --git a/doc/Doxyfile_common b/doc/Doxyfile_common index 59558535..0471dcf3 100644 --- a/doc/Doxyfile_common +++ b/doc/Doxyfile_common @@ -30,3 +30,15 @@ MACRO_EXPANSION = YES EXPAND_ONLY_PREDEF = YES INTERNAL_DOCS = YES DOT_IMAGE_FORMAT = svg +PREDEFINED = __GNUC__ \ + __attribute__(x)= \ + ODP_ALIGNED(x)= \ + ODPDRV_ALIGNED(x)= \ + __BIG_ENDIAN_BITFIELD \ + __LITTLE_ENDIAN_BITFIELD \ + __x86_64__ \ + ODP_PACKED \ + ODPDRV_PACKED \ + ODP_DEPRECATE(x)=x \ + "ODP_HANDLE_T(type)=odp_handle_t type" \ + "ODPDRV_HANDLE_T(type)=odpdrv_handle_t type" diff --git a/doc/application-api-guide/Doxyfile b/doc/application-api-guide/Doxyfile index 9cb183c1..2709f6fd 100644 --- a/doc/application-api-guide/Doxyfile +++ b/doc/application-api-guide/Doxyfile @@ -7,6 +7,4 @@ INPUT = $(SRCDIR)/doc/application-api-guide \ $(SRCDIR)/include EXCLUDE_PATTERNS = drv* odp_drv.h EXAMPLE_PATH = $(SRCDIR)/example $(SRCDIR) -PREDEFINED = __GNUC__ \ - "ODP_HANDLE_T(type)=odp_handle_t type" WARNINGS = NO diff --git a/doc/driver-api-guide/Doxyfile b/doc/driver-api-guide/Doxyfile index b5f7260e..28794ef0 100644 --- a/doc/driver-api-guide/Doxyfile +++ b/doc/driver-api-guide/Doxyfile @@ -7,11 +7,3 @@ INPUT = $(SRCDIR)/doc/driver-api-guide \ $(SRCDIR)/include/odp/drv \ $(SRCDIR)/platform/$(WITH_PLATFORM)/include/odp/drv \ $(SRCDIR)/include/odp_drv.h -PREDEFINED = __GNUC__ \ - __attribute__(x)= \ - ODPDRV_ALIGNED(x)= \ - __BIG_ENDIAN_BITFIELD \ - __LITTLE_ENDIAN_BITFIELD \ - __x86_64__ \ - ODPDRV_PACKED \ - "ODPDRV_HANDLE_T(type)=odpdrv_handle_t type" diff --git a/doc/helper-guide/Doxyfile b/doc/helper-guide/Doxyfile index bcc24539..bb9bd8e6 100644 --- a/doc/helper-guide/Doxyfile +++ b/doc/helper-guide/Doxyfile @@ -33,13 +33,5 @@ LAYOUT_FILE = $(SRCDIR)/doc/doxygenlayout.xml ENABLE_PREPROCESSING = YES MACRO_EXPANSION = YES EXPAND_ONLY_PREDEF = YES -PREDEFINED = __GNUC__ \ - __attribute__(x)= \ - ODP_ALIGNED(x)= \ - __BIG_ENDIAN_BITFIELD \ - __LITTLE_ENDIAN_BITFIELD \ - __x86_64__ \ - ODP_PACKED \ - "ODP_HANDLE_T(type)=odp_handle_t type" INTERNAL_DOCS = YES DOT_IMAGE_FORMAT = svg diff --git a/doc/platform-api-guide/Doxyfile b/doc/platform-api-guide/Doxyfile index 1f2d49a4..d716b4a3 100644 --- a/doc/platform-api-guide/Doxyfile +++ b/doc/platform-api-guide/Doxyfile @@ -10,12 +10,3 @@ INPUT = $(SRCDIR)/doc/application-api-guide \ $(SRCDIR)/platform/$(WITH_PLATFORM)/include/odp/api \ $(SRCDIR)/platform/$(WITH_PLATFORM)/arch/$(WITH_ARCH) EXAMPLE_PATH = $(SRCDIR)/example $(SRCDIR)/platform $(SRCDIR) -PREDEFINED = __GNUC__ \ - __attribute__(x)= \ - ODP_ALIGNED(x)= \ - __BIG_ENDIAN_BITFIELD \ - __LITTLE_ENDIAN_BITFIELD \ - __x86_64__ \ - ODP_PACKED \ - ODP_DEPRECATE(x)=x \ - "ODP_HANDLE_T(type)=odp_handle_t type" From patchwork Wed Jul 12 14:00:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 107519 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp854614qge; Wed, 12 Jul 2017 07:04:26 -0700 (PDT) X-Received: by 10.200.62.9 with SMTP id z9mr6038666qtf.161.1499868266137; Wed, 12 Jul 2017 07:04:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499868266; cv=none; d=google.com; s=arc-20160816; b=kK9SKPQCSqucV8ZEZoUDRyLWEbAoYRzPeqvwcZWmvQZlLBN/xuyInMnEtZWDYjWhZo rjo2iFMW4NB0We5/ouMJ0cG5aqrH+suC1YehD2LsWskF4taAn+7jdftOa9X/kKU2zJ9c AhdZOJqFWAuTo1xaAes+nFQJC2GbvdCMfo5Dz2FGhCPBELsYpchLKJSI/7req1CnRWQd D6pjKUk50M3+goN1nEadfazIjN724OxiOGql5tAPD/2pskUYZzwQpvQNZWVPC9tL3wmJ ZsJbvJeMbM3lzXoTMJPSxe2vrCq+ExzhDTnqcaSs9wpR0bQhBWqi4d04j2dCIlrmNm6e QkSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=g29MTehXttw6y8ZrOqHNbyP5Yqs6AN3F5egO4t/XCIA=; b=RksHiFzj0sEOY+gShNAmiPRaLkBza5XxvDgsfmhxg3KHzwUnH4cqXg9DMn9QhVt8W+ p82/NktPgD3QmuDLT97cQFJBdhPI5QNuJcNE4Yi1kGI8Obew1EoIB7WesWe6sEBet0Dc U81g+rUHB7yrHE5Ukkk7VYUMYdawlOp9whNUcHesqbkYaw+crWKqtVcWoC51cP3ipK/3 I7brXgHfKTBvIRZDhzx3geVpGDtLyvQP4OoYcyuLWdQqoXY7QTccBVuFhUy1z2qTxZFa WV2sow3LGvdqX18YlxWNhbr+9/OaRD7cTRZdTs39S1JyrxeMnuaK9aryKVo42MEdXJU1 iJ6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id t54si2277925qtb.387.2017.07.12.07.04.25; Wed, 12 Jul 2017 07:04:26 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id C42EC60809; Wed, 12 Jul 2017 14:04:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 8B36F60A4A; Wed, 12 Jul 2017 14:02:43 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id CBFC1644D7; Wed, 12 Jul 2017 14:02:34 +0000 (UTC) Received: from forward5o.cmail.yandex.net (forward5o.cmail.yandex.net [37.9.109.249]) by lists.linaro.org (Postfix) with ESMTPS id C9D5F60A4A for ; Wed, 12 Jul 2017 14:00:46 +0000 (UTC) Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [95.108.252.166]) by forward5o.cmail.yandex.net (Yandex) with ESMTP id 8912E214FF for ; Wed, 12 Jul 2017 17:00:45 +0300 (MSK) Received: from smtp4p.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp4p.mail.yandex.net (Yandex) with ESMTP id E588D65012CB for ; Wed, 12 Jul 2017 17:00:31 +0300 (MSK) Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id blQPLGFwg5-0UJaHalO; Wed, 12 Jul 2017 17:00:30 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 12 Jul 2017 17:00:13 +0300 Message-Id: <1499868014-26323-4-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> References: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 74 Subject: [lng-odp] [PATCH API-NEXT v2 3/4] api: crypto: replace redundant packet_ prefixes from definitions X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch: https://github.com/Linaro/odp/pull/74.patch ** Base sha: ee5be324411a7520528a367967c28fc529d3bc2e ** Merge commit sha: 5411462e6545fa2d6a286a40c2057db97714ee74 **/ example/ipsec/odp_ipsec.c | 16 ++++----- example/ipsec/odp_ipsec_cache.c | 4 +-- include/odp/api/spec/crypto.h | 18 +++++----- platform/linux-generic/odp_crypto.c | 38 +++++++++++----------- test/common_plat/performance/odp_crypto.c | 14 ++++---- .../validation/api/crypto/odp_crypto_test_inp.c | 18 +++++----- 6 files changed, 54 insertions(+), 54 deletions(-) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index 5df8f154..52a5fdcd 100644 --- a/example/ipsec/odp_ipsec.c +++ b/example/ipsec/odp_ipsec.c @@ -698,12 +698,12 @@ pkt_disposition_e do_ipsec_in_classify(odp_packet_t *pkt, *skip = FALSE; ctx->state = PKT_STATE_IPSEC_IN_FINISH; if (entry->async) { - if (odp_crypto_packet_op_enq(pkt, &out_pkt, ¶ms, 1)) + if (odp_crypto_op_enq(pkt, &out_pkt, ¶ms, 1)) abort(); return PKT_POSTED; } - if (odp_crypto_packet_op(pkt, &out_pkt, ¶ms, 1)) + if (odp_crypto_op(pkt, &out_pkt, ¶ms, 1)) abort(); *pkt = out_pkt; @@ -727,7 +727,7 @@ pkt_disposition_e do_ipsec_in_finish(odp_packet_t pkt, int hdr_len = ctx->ipsec.hdr_len; int trl_len = 0; - odp_crypto_packet_result(&result, pkt); + odp_crypto_result(&result, pkt); /* Check crypto result */ if (!result.ok) { @@ -1001,14 +1001,14 @@ pkt_disposition_e do_ipsec_out_seq(odp_packet_t *pkt, /* Issue crypto request */ if (entry->async) { - if (odp_crypto_packet_op_enq(pkt, &out_pkt, - &ctx->ipsec.params, 1)) + if (odp_crypto_op_enq(pkt, &out_pkt, + &ctx->ipsec.params, 1)) abort(); return PKT_POSTED; } - if (odp_crypto_packet_op(pkt, &out_pkt, - &ctx->ipsec.params, 1)) + if (odp_crypto_op(pkt, &out_pkt, + &ctx->ipsec.params, 1)) abort(); *pkt = out_pkt; @@ -1030,7 +1030,7 @@ pkt_disposition_e do_ipsec_out_finish(odp_packet_t pkt, odph_ipv4hdr_t *ip; odp_crypto_packet_result_t result; - odp_crypto_packet_result(&result, pkt); + odp_crypto_result(&result, pkt); /* Check crypto result */ if (!result.ok) { diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c index 18a98a29..2a1416b0 100644 --- a/example/ipsec/odp_ipsec_cache.c +++ b/example/ipsec/odp_ipsec_cache.c @@ -66,12 +66,12 @@ int create_ipsec_cache_entry(sa_db_entry_t *cipher_sa, params.op = (in) ? ODP_CRYPTO_OP_DECODE : ODP_CRYPTO_OP_ENCODE; params.auth_cipher_text = TRUE; if (CRYPTO_API_SYNC == api_mode) { - params.packet_op_mode = ODP_CRYPTO_SYNC; + params.op_mode = ODP_CRYPTO_SYNC; params.compl_queue = ODP_QUEUE_INVALID; params.output_pool = ODP_POOL_INVALID; entry->async = FALSE; } else { - params.packet_op_mode = ODP_CRYPTO_ASYNC; + params.op_mode = ODP_CRYPTO_ASYNC; params.compl_queue = completionq; params.output_pool = out_pool; entry->async = TRUE; diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h index 013507f9..3e47f3ef 100644 --- a/include/odp/api/spec/crypto.h +++ b/include/odp/api/spec/crypto.h @@ -278,7 +278,7 @@ typedef struct odp_crypto_session_param_t { odp_crypto_op_mode_t ODP_DEPRECATE(pref_mode); /** Operation mode when using packet interface: sync or async */ - odp_crypto_op_mode_t packet_op_mode; + odp_crypto_op_mode_t op_mode; /** Cipher algorithm * @@ -315,7 +315,7 @@ typedef struct odp_crypto_session_param_t { /** Async mode completion event queue * - * The completion queue is used to return odp_crypto_packet_op_enq() + * The completion queue is used to return odp_crypto_op_enq() * results to the application. */ odp_queue_t compl_queue; @@ -544,10 +544,10 @@ typedef struct odp_crypto_capability_t { uint32_t max_sessions; /** Supported packet operation in SYNC mode */ - odp_support_t packet_sync_mode; + odp_support_t sync_mode; /** Supported packet operation in ASYNC mode */ - odp_support_t packet_async_mode; + odp_support_t async_mode; /** Supported cipher algorithms */ odp_crypto_cipher_algos_t ciphers; @@ -785,7 +785,7 @@ void odp_crypto_session_param_init(odp_crypto_session_param_t *param); * * Get packet handle to an crypto processed packet event. Event subtype must be * ODP_EVENT_PACKET_CRYPTO. Crypto operation results can be examined with - * odp_crypto_packet_result(). + * odp_crypto_result(). * * Note: any invalid parameters will cause undefined behavior and may cause * the application to abort or crash. @@ -822,8 +822,8 @@ odp_event_t odp_crypto_packet_to_event(odp_packet_t pkt); * @retval 0 On success * @retval <0 On failure */ -int odp_crypto_packet_result(odp_crypto_packet_result_t *result, - odp_packet_t packet); +int odp_crypto_result(odp_crypto_packet_result_t *result, + odp_packet_t packet); /** * Crypto packet operation @@ -841,7 +841,7 @@ int odp_crypto_packet_result(odp_crypto_packet_result_t *result, * @return Number of input packets consumed (0 ... num_pkt) * @retval <0 on failure */ -int odp_crypto_packet_op(const odp_packet_t pkt_in[], +int odp_crypto_op(const odp_packet_t pkt_in[], odp_packet_t pkt_out[], const odp_crypto_packet_op_param_t param[], int num_pkt); @@ -863,7 +863,7 @@ int odp_crypto_packet_op(const odp_packet_t pkt_in[], * @return Number of input packets consumed (0 ... num_pkt) * @retval <0 on failure */ -int odp_crypto_packet_op_enq(const odp_packet_t pkt_in[], +int odp_crypto_op_enq(const odp_packet_t pkt_in[], const odp_packet_t pkt_out[], const odp_crypto_packet_op_param_t param[], int num_pkt); diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 792c2eca..80ff6f59 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -866,11 +866,11 @@ odp_crypto_operation(odp_crypto_op_param_t *param, packet_param.cipher_range = param->cipher_range; packet_param.auth_range = param->auth_range; - rc = odp_crypto_packet_op(¶m->pkt, &out_pkt, &packet_param, 1); + rc = odp_crypto_op(¶m->pkt, &out_pkt, &packet_param, 1); if (rc < 0) return rc; - rc = odp_crypto_packet_result(&packet_result, out_pkt); + rc = odp_crypto_result(&packet_result, out_pkt); if (rc < 0) return rc; @@ -1101,8 +1101,8 @@ odp_crypto_packet_result_t *get_op_result_from_packet(odp_packet_t pkt) return &hdr->crypto_op_result; } -int odp_crypto_packet_result(odp_crypto_packet_result_t *result, - odp_packet_t packet) +int odp_crypto_result(odp_crypto_packet_result_t *result, + odp_packet_t packet) { odp_crypto_packet_result_t *op_result; @@ -1117,9 +1117,9 @@ int odp_crypto_packet_result(odp_crypto_packet_result_t *result, } static -int odp_crypto_op(odp_packet_t pkt_in, - odp_packet_t *pkt_out, - const odp_crypto_packet_op_param_t *param) +int odp_crypto_int(odp_packet_t pkt_in, + odp_packet_t *pkt_out, + const odp_crypto_packet_op_param_t *param) { odp_crypto_alg_err_t rc_cipher = ODP_CRYPTO_ALG_ERR_NONE; odp_crypto_alg_err_t rc_auth = ODP_CRYPTO_ALG_ERR_NONE; @@ -1197,19 +1197,19 @@ int odp_crypto_op(odp_packet_t pkt_in, return -1; } -int odp_crypto_packet_op(const odp_packet_t pkt_in[], - odp_packet_t pkt_out[], - const odp_crypto_packet_op_param_t param[], - int num_pkt) +int odp_crypto_op(const odp_packet_t pkt_in[], + odp_packet_t pkt_out[], + const odp_crypto_packet_op_param_t param[], + int num_pkt) { int i, rc; odp_crypto_generic_session_t *session; session = (odp_crypto_generic_session_t *)(intptr_t)param->session; - ODP_ASSERT(ODP_CRYPTO_SYNC == session->p.packet_op_mode); + ODP_ASSERT(ODP_CRYPTO_SYNC == session->p.op_mode); for (i = 0; i < num_pkt; i++) { - rc = odp_crypto_op(pkt_in[i], &pkt_out[i], ¶m[i]); + rc = odp_crypto_int(pkt_in[i], &pkt_out[i], ¶m[i]); if (rc < 0) break; } @@ -1217,10 +1217,10 @@ int odp_crypto_packet_op(const odp_packet_t pkt_in[], return i; } -int odp_crypto_packet_op_enq(const odp_packet_t pkt_in[], - const odp_packet_t pkt_out[], - const odp_crypto_packet_op_param_t param[], - int num_pkt) +int odp_crypto_op_enq(const odp_packet_t pkt_in[], + const odp_packet_t pkt_out[], + const odp_crypto_packet_op_param_t param[], + int num_pkt) { odp_packet_t pkt; odp_event_t event; @@ -1228,12 +1228,12 @@ int odp_crypto_packet_op_enq(const odp_packet_t pkt_in[], int i, rc; session = (odp_crypto_generic_session_t *)(intptr_t)param->session; - ODP_ASSERT(ODP_CRYPTO_ASYNC == session->p.packet_op_mode); + ODP_ASSERT(ODP_CRYPTO_ASYNC == session->p.op_mode); ODP_ASSERT(ODP_QUEUE_INVALID != session->p.compl_queue); for (i = 0; i < num_pkt; i++) { pkt = pkt_out[i]; - rc = odp_crypto_op(pkt_in[i], &pkt, ¶m[i]); + rc = odp_crypto_int(pkt_in[i], &pkt, ¶m[i]); if (rc < 0) break; diff --git a/test/common_plat/performance/odp_crypto.c b/test/common_plat/performance/odp_crypto.c index a129ec98..27d4fd30 100644 --- a/test/common_plat/performance/odp_crypto.c +++ b/test/common_plat/performance/odp_crypto.c @@ -443,10 +443,10 @@ create_session_from_config(odp_crypto_session_t *session, return -1; } params.compl_queue = out_queue; - params.packet_op_mode = ODP_CRYPTO_ASYNC; + params.op_mode = ODP_CRYPTO_ASYNC; } else { params.compl_queue = ODP_QUEUE_INVALID; - params.packet_op_mode = ODP_CRYPTO_SYNC; + params.op_mode = ODP_CRYPTO_SYNC; } if (odp_crypto_session_create(¶ms, session, &ses_create_rc)) { @@ -554,8 +554,8 @@ run_measure_one(crypto_args_t *cargs, } if (cargs->schedule || cargs->poll) { - rc = odp_crypto_packet_op_enq(&pkt, &out_pkt, - ¶ms, 1); + rc = odp_crypto_op_enq(&pkt, &out_pkt, + ¶ms, 1); if (rc <= 0) { app_err("failed odp_crypto_packet_op_enq: rc = %d\n", rc); @@ -563,8 +563,8 @@ run_measure_one(crypto_args_t *cargs, } packets_sent += rc; } else { - rc = odp_crypto_packet_op(&pkt, &out_pkt, - ¶ms, 1); + rc = odp_crypto_op(&pkt, &out_pkt, + ¶ms, 1); if (rc <= 0) { app_err("failed odp_crypto_packet_op: rc = %d\n", rc); @@ -603,7 +603,7 @@ run_measure_one(crypto_args_t *cargs, while (ev != ODP_EVENT_INVALID) { out_pkt = odp_crypto_packet_from_event(ev); - odp_crypto_packet_result(&result, out_pkt); + odp_crypto_result(&result, out_pkt); if (cargs->debug_packets) { mem = odp_packet_data(out_pkt); diff --git a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c index 716bd952..ac59744f 100644 --- a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c @@ -15,7 +15,7 @@ struct suite_context_s { odp_bool_t packet; - odp_crypto_op_mode_t packet_op_mode; + odp_crypto_op_mode_t op_mode; odp_pool_t pool; odp_queue_t queue; }; @@ -165,7 +165,7 @@ static int alg_packet_op(odp_packet_t pkt, op_params.hash_result_offset = plaintext_len; - rc = odp_crypto_packet_op(&pkt, &out_pkt, &op_params, 1); + rc = odp_crypto_op(&pkt, &out_pkt, &op_params, 1); if (rc < 0) { CU_FAIL("Failed odp_crypto_packet_op()"); return rc; @@ -180,7 +180,7 @@ static int alg_packet_op(odp_packet_t pkt, odp_event_types(odp_packet_to_event(pkt), &subtype)); CU_ASSERT(ODP_EVENT_PACKET_CRYPTO == subtype); - rc = odp_crypto_packet_result(&result, pkt); + rc = odp_crypto_result(&result, pkt); if (rc < 0) { CU_FAIL("Failed odp_crypto_packet_result()"); return rc; @@ -233,7 +233,7 @@ static int alg_packet_op_enq(odp_packet_t pkt, op_params.hash_result_offset = plaintext_len; - rc = odp_crypto_packet_op_enq(&pkt, &pkt, &op_params, 1); + rc = odp_crypto_op_enq(&pkt, &pkt, &op_params, 1); if (rc < 0) { CU_FAIL("Failed odp_crypto_op_enq()"); return rc; @@ -260,7 +260,7 @@ static int alg_packet_op_enq(odp_packet_t pkt, odp_event_types(odp_packet_to_event(pkt), &subtype)); CU_ASSERT(ODP_EVENT_PACKET_CRYPTO == subtype); - rc = odp_crypto_packet_result(&result, pkt); + rc = odp_crypto_result(&result, pkt); if (rc < 0) { CU_FAIL("Failed odp_crypto_packet_result()"); return rc; @@ -402,7 +402,7 @@ static void alg_test(odp_crypto_op_t op, odp_crypto_session_param_init(&ses_params); ses_params.op = op; ses_params.auth_cipher_text = false; - ses_params.packet_op_mode = suite_context.packet_op_mode; + ses_params.op_mode = suite_context.op_mode; ses_params.cipher_alg = cipher_alg; ses_params.auth_alg = auth_alg; ses_params.compl_queue = suite_context.queue; @@ -433,7 +433,7 @@ static void alg_test(odp_crypto_op_t op, rc = alg_op(pkt, &ok, session, op_iv_ptr, cipher_range, auth_range, aad, aad_len, plaintext_len); - else if (ODP_CRYPTO_ASYNC == suite_context.packet_op_mode) + else if (ODP_CRYPTO_ASYNC == suite_context.op_mode) rc = alg_packet_op_enq(pkt, &ok, session, op_iv_ptr, cipher_range, auth_range, aad, aad_len, plaintext_len); @@ -1684,7 +1684,7 @@ int crypto_suite_sync_init(void) int crypto_suite_packet_sync_init(void) { suite_context.packet = true; - suite_context.packet_op_mode = ODP_CRYPTO_SYNC; + suite_context.op_mode = ODP_CRYPTO_SYNC; suite_context.pool = odp_pool_lookup("packet_pool"); if (suite_context.pool == ODP_POOL_INVALID) @@ -1697,7 +1697,7 @@ int crypto_suite_packet_sync_init(void) int crypto_suite_packet_async_init(void) { suite_context.packet = true; - suite_context.packet_op_mode = ODP_CRYPTO_ASYNC; + suite_context.op_mode = ODP_CRYPTO_ASYNC; suite_context.pool = odp_pool_lookup("packet_pool"); if (suite_context.pool == ODP_POOL_INVALID) From patchwork Wed Jul 12 14:00:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 107521 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp858105qge; Wed, 12 Jul 2017 07:06:57 -0700 (PDT) X-Received: by 10.237.51.167 with SMTP id v36mr6441155qtd.72.1499868417781; Wed, 12 Jul 2017 07:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499868417; cv=none; d=google.com; s=arc-20160816; b=0gKsgVGeX/d+GV63Yu66hGxeI0t+4Gw/UremTUUeXLn4LX6locDMjDuW4eYBm8S/4o 0CPJDWpDuwQbydKEEkxJwpJvY1nhjwzsSJuZmqIL861zu7hetM9+5cTGmL8Pd8DzAQqr +UL4xXdyDM4fDvnLtujym8WZ3C8mUWYpefMZqG+0FTxh0Hs/1MylAS8Uwny3FttYHxus Rfgt6gdp5Xv4+mrOFuE1ivdxk40S1yDt90ZWhbqpVacAtqK4L1ZCPBMw08AVMQF22AV5 xugtunq36Xu7aQfclms+dEHTZv3cDH11iQozbHMVc3rnT06wuiJ/cpQzzAxjCtel0Wdi 0G+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=f4tu5w6eJHCXLXcNOeQBGhKEaADKuLgr3hLC4aBd5uA=; b=xWjI2Y+k1AGj7qjfge7kepksxBeS7e05jb7cVHg9VdzC3tKAnaFZPXrSUc3f5yDcEv jILcc+JzefV/ruehaLCvL4etz1mZeIfisTQT44lASn+srg4zZDwoMPjG29euglWyO8WE wXwl+me3JEvuR5rsP8B0u70VfHrbvz+2Uq4Dhw0CYCeGOYfE0FBqDHehluC7bfNwWUx9 r/lqlptzi4f8RUCXCTs0o8ABI+wv1oO2UavSxRXpVgHSdSI4o+t6f5UbtvVAi4Yn6BGH 2qvs5S2M8bbIE+hcodw/5bgr4/WgxcrzvuQVS2XrX5aPvKNfZHItAkCK4cHNg4Y1xp+F 84DA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id t38si2414507qta.166.2017.07.12.07.06.57; Wed, 12 Jul 2017 07:06:57 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 781466091E; Wed, 12 Jul 2017 14:06:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 8AB0F644E2; Wed, 12 Jul 2017 14:02:57 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 86F7660C4E; Wed, 12 Jul 2017 14:02:50 +0000 (UTC) Received: from forward3h.cmail.yandex.net (forward3h.cmail.yandex.net [87.250.230.18]) by lists.linaro.org (Postfix) with ESMTPS id 085AF606B5 for ; Wed, 12 Jul 2017 14:01:06 +0000 (UTC) Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [95.108.252.166]) by forward3h.cmail.yandex.net (Yandex) with ESMTP id 917A2214FD for ; Wed, 12 Jul 2017 17:01:04 +0300 (MSK) Received: from smtp4p.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp4p.mail.yandex.net (Yandex) with ESMTP id DB0D665012F1 for ; Wed, 12 Jul 2017 17:00:35 +0300 (MSK) Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id blQPLGFwg5-0YJuPCwD; Wed, 12 Jul 2017 17:00:34 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 12 Jul 2017 17:00:14 +0300 Message-Id: <1499868014-26323-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> References: <1499868014-26323-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 74 Subject: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov It was decided that it would be benefitable to live with both API types at this point, as odp_crypto_compl_t was available for some time. So undeprecate odp_crypto_compl_t and related functionality. Validation tests also provide necessary tests for pref_mode and for completion event. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 74 (lumag:crypto-packet) ** https://github.com/Linaro/odp/pull/74 ** Patch: https://github.com/Linaro/odp/pull/74.patch ** Base sha: ee5be324411a7520528a367967c28fc529d3bc2e ** Merge commit sha: 5411462e6545fa2d6a286a40c2057db97714ee74 **/ include/odp/api/spec/crypto.h | 38 +++++++------------- include/odp/arch/default/api/abi/crypto.h | 4 +-- include/odp/arch/default/api/abi/event.h | 4 +-- .../include/odp/api/plat/crypto_types.h | 3 +- .../include/odp/api/plat/event_types.h | 3 +- platform/linux-generic/odp_crypto.c | 4 --- platform/linux-generic/odp_event.c | 2 -- test/common_plat/performance/odp_crypto.c | 1 + test/common_plat/validation/api/crypto/crypto.c | 2 ++ .../validation/api/crypto/odp_crypto_test_inp.c | 41 +++++++++++++++++++++- .../validation/api/crypto/odp_crypto_test_inp.h | 2 ++ 11 files changed, 61 insertions(+), 43 deletions(-) diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h index 3e47f3ef..6736214b 100644 --- a/include/odp/api/spec/crypto.h +++ b/include/odp/api/spec/crypto.h @@ -271,11 +271,8 @@ typedef struct odp_crypto_session_param_t { */ odp_bool_t auth_cipher_text; - /** Preferred sync vs. async - * - * @deprecated no-op now, odp_crypto_operation() will always process - * data in non-posted mode */ - odp_crypto_op_mode_t ODP_DEPRECATE(pref_mode); + /** Preferred sync vs. async for odp_crypto_operation() */ + odp_crypto_op_mode_t pref_mode; /** Operation mode when using packet interface: sync or async */ odp_crypto_op_mode_t op_mode; @@ -340,11 +337,8 @@ typedef struct odp_crypto_op_param_t { /** Session handle from creation */ odp_crypto_session_t session; - /** User context - * - * @deprecated No need to pass context around sync calls - * */ - void *ODP_DEPRECATE(ctx); + /** User context */ + void *ctx; /** Input packet * @@ -504,11 +498,8 @@ typedef struct odp_crypto_op_result { /** Request completed successfully */ odp_bool_t ok; - /** User context from request - * - * @deprecated No need to pass context around sync calls - * */ - void *ODP_DEPRECATE(ctx); + /** User context from request */ + void *ctx; /** Output packet */ odp_packet_t pkt; @@ -692,8 +683,7 @@ int odp_crypto_session_destroy(odp_crypto_session_t session); * * @return crypto completion handle */ -ODP_DEPRECATE(odp_crypto_compl_t) ODP_DEPRECATE(odp_crypto_compl_from_event)( - odp_event_t ev); +odp_crypto_compl_t odp_crypto_compl_from_event(odp_event_t ev); /** * Convert crypto completion handle to event handle @@ -702,16 +692,14 @@ ODP_DEPRECATE(odp_crypto_compl_t) ODP_DEPRECATE(odp_crypto_compl_from_event)( * * @return Event handle */ -odp_event_t ODP_DEPRECATE(odp_crypto_compl_to_event)( - ODP_DEPRECATE(odp_crypto_compl_t) completion_event); +odp_event_t odp_crypto_compl_to_event(odp_crypto_compl_t completion_event); /** * Release crypto completion event * * @param completion_event Completion event we are done accessing */ -void ODP_DEPRECATE(odp_crypto_compl_free)( - ODP_DEPRECATE(odp_crypto_compl_t) completion_event); +void odp_crypto_compl_free(odp_crypto_compl_t completion_event); /** * Crypto per packet operation @@ -739,9 +727,8 @@ int odp_crypto_operation(odp_crypto_op_param_t *param, * @param completion_event Event containing operation results * @param result Pointer to result structure */ -void ODP_DEPRECATE(odp_crypto_compl_result)( - ODP_DEPRECATE(odp_crypto_compl_t) completion_event, - odp_crypto_op_result_t *result); +void odp_crypto_compl_result(odp_crypto_compl_t completion_event, + odp_crypto_op_result_t *result); /** * Get printable value for an odp_crypto_session_t @@ -767,8 +754,7 @@ uint64_t odp_crypto_session_to_u64(odp_crypto_session_t hdl); * to enable applications to generate a printable value that represents * an odp_crypto_compl_t handle. */ -uint64_t ODP_DEPRECATE(odp_crypto_compl_to_u64)( - ODP_DEPRECATE(odp_crypto_compl_t) hdl); +uint64_t odp_crypto_compl_to_u64(odp_crypto_compl_t hdl); /** * Initialize crypto session parameters diff --git a/include/odp/arch/default/api/abi/crypto.h b/include/odp/arch/default/api/abi/crypto.h index 2d02eee6..f0793a19 100644 --- a/include/odp/arch/default/api/abi/crypto.h +++ b/include/odp/arch/default/api/abi/crypto.h @@ -11,8 +11,6 @@ extern "C" { #endif -#include - #include /** @internal Dummy type for strong typing */ @@ -25,7 +23,7 @@ typedef struct { char dummy; /**< @internal Dummy */ } _odp_abi_crypto_compl_t; #define ODP_CRYPTO_SESSION_INVALID (0xffffffffffffffffULL) typedef uint64_t odp_crypto_session_t; -typedef _odp_abi_crypto_compl_t *ODP_DEPRECATE(odp_crypto_compl_t); +typedef _odp_abi_crypto_compl_t *odp_crypto_compl_t; /** * @} diff --git a/include/odp/arch/default/api/abi/event.h b/include/odp/arch/default/api/abi/event.h index 871d2cf9..f86d8e27 100644 --- a/include/odp/arch/default/api/abi/event.h +++ b/include/odp/arch/default/api/abi/event.h @@ -11,8 +11,6 @@ extern "C" { #endif -#include - #include /** @internal Dummy type for strong typing */ @@ -30,7 +28,7 @@ typedef enum odp_event_type_t { ODP_EVENT_BUFFER = 1, ODP_EVENT_PACKET = 2, ODP_EVENT_TIMEOUT = 3, - ODP_DEPRECATE(ODP_EVENT_CRYPTO_COMPL) = 4, + ODP_EVENT_CRYPTO_COMPL = 4, ODP_EVENT_IPSEC_STATUS = 5 } odp_event_type_t; diff --git a/platform/linux-generic/include/odp/api/plat/crypto_types.h b/platform/linux-generic/include/odp/api/plat/crypto_types.h index 23e1cc42..2cc747eb 100644 --- a/platform/linux-generic/include/odp/api/plat/crypto_types.h +++ b/platform/linux-generic/include/odp/api/plat/crypto_types.h @@ -22,7 +22,6 @@ extern "C" { #if ODP_ABI_COMPAT == 1 #include #else -#include /** @ingroup odp_crypto * @{ @@ -31,7 +30,7 @@ extern "C" { #define ODP_CRYPTO_SESSION_INVALID (0xffffffffffffffffULL) typedef uint64_t odp_crypto_session_t; -typedef ODP_HANDLE_T(ODP_DEPRECATE(odp_crypto_compl_t)); +typedef ODP_HANDLE_T(odp_crypto_compl_t); /** * @} diff --git a/platform/linux-generic/include/odp/api/plat/event_types.h b/platform/linux-generic/include/odp/api/plat/event_types.h index 58ce0a8b..4d0efff1 100644 --- a/platform/linux-generic/include/odp/api/plat/event_types.h +++ b/platform/linux-generic/include/odp/api/plat/event_types.h @@ -23,7 +23,6 @@ extern "C" { #include #else -#include #include #include @@ -39,7 +38,7 @@ typedef enum odp_event_type_t { ODP_EVENT_BUFFER = 1, ODP_EVENT_PACKET = 2, ODP_EVENT_TIMEOUT = 3, - ODP_DEPRECATE(ODP_EVENT_CRYPTO_COMPL) = 4, + ODP_EVENT_CRYPTO_COMPL = 4, ODP_EVENT_IPSEC_STATUS = 5 } odp_event_type_t; diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 80ff6f59..ca51bdf0 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -881,9 +881,7 @@ odp_crypto_operation(odp_crypto_op_param_t *param, ODP_EVENT_PACKET_BASIC); /* Fill in result */ -#if ODP_DEPRECATED_API local_result.ctx = param->ctx; -#endif local_result.pkt = out_pkt; local_result.cipher_status = packet_result.cipher_status; local_result.auth_status = packet_result.auth_status; @@ -1030,7 +1028,6 @@ int32_t odp_random_test_data(uint8_t *buf, uint32_t len, uint64_t *seed) return len; } -#if ODP_DEPRECATED_API odp_crypto_compl_t odp_crypto_compl_from_event(odp_event_t ev) { /* This check not mandated by the API specification */ @@ -1067,7 +1064,6 @@ uint64_t odp_crypto_compl_to_u64(odp_crypto_compl_t hdl) { return _odp_pri(hdl); } -#endif void odp_crypto_session_param_init(odp_crypto_session_param_t *param) { diff --git a/platform/linux-generic/odp_event.c b/platform/linux-generic/odp_event.c index 56cc90b0..23b410d8 100644 --- a/platform/linux-generic/odp_event.c +++ b/platform/linux-generic/odp_event.c @@ -46,11 +46,9 @@ void odp_event_free(odp_event_t event) case ODP_EVENT_TIMEOUT: odp_timeout_free(odp_timeout_from_event(event)); break; -#if ODP_DEPRECATED_API case ODP_EVENT_CRYPTO_COMPL: odp_crypto_compl_free(odp_crypto_compl_from_event(event)); break; -#endif default: ODP_ABORT("Invalid event type: %d\n", odp_event_type(event)); } diff --git a/test/common_plat/performance/odp_crypto.c b/test/common_plat/performance/odp_crypto.c index 27d4fd30..7a25ffdc 100644 --- a/test/common_plat/performance/odp_crypto.c +++ b/test/common_plat/performance/odp_crypto.c @@ -427,6 +427,7 @@ create_session_from_config(odp_crypto_session_t *session, odp_crypto_session_param_init(¶ms); memcpy(¶ms, &config->session, sizeof(odp_crypto_session_param_t)); params.op = ODP_CRYPTO_OP_ENCODE; + params.pref_mode = ODP_CRYPTO_SYNC; /* Lookup the packet pool */ pkt_pool = odp_pool_lookup("packet_pool"); diff --git a/test/common_plat/validation/api/crypto/crypto.c b/test/common_plat/validation/api/crypto/crypto.c index 8a6c20ec..04ca527d 100644 --- a/test/common_plat/validation/api/crypto/crypto.c +++ b/test/common_plat/validation/api/crypto/crypto.c @@ -15,6 +15,8 @@ odp_suiteinfo_t crypto_suites[] = { {ODP_CRYPTO_SYNC_INP, crypto_suite_sync_init, crypto_suite_term, crypto_suite}, + {ODP_CRYPTO_ASYNC_INP, crypto_suite_async_init, + crypto_suite_term, crypto_suite}, {ODP_CRYPTO_PACKET_SYNC_INP, crypto_suite_packet_sync_init, crypto_suite_term, crypto_suite}, {ODP_CRYPTO_PACKET_ASYNC_INP, crypto_suite_packet_async_init, diff --git a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c index ac59744f..953fef02 100644 --- a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.c @@ -16,6 +16,7 @@ struct suite_context_s { odp_bool_t packet; odp_crypto_op_mode_t op_mode; + odp_crypto_op_mode_t pref_mode; odp_pool_t pool; odp_queue_t queue; }; @@ -81,6 +82,7 @@ static int alg_op(odp_packet_t pkt, op_params.session = session; op_params.pkt = pkt; op_params.out_pkt = pkt; + op_params.ctx = (void *)0xdeadbeef; if (cipher_range) { op_params.cipher_range = *cipher_range; @@ -109,8 +111,30 @@ static int alg_op(odp_packet_t pkt, return rc; } - CU_ASSERT(posted == 0); + if (posted) { + odp_event_t event; + odp_crypto_compl_t compl_event; + + /* Poll completion queue for results */ + do { + event = odp_queue_deq(suite_context.queue); + } while (event == ODP_EVENT_INVALID); + + CU_ASSERT(ODP_EVENT_CRYPTO_COMPL == odp_event_type(event)); + CU_ASSERT(ODP_EVENT_NO_SUBTYPE == odp_event_subtype(event)); + CU_ASSERT(ODP_EVENT_CRYPTO_COMPL == + odp_event_types(event, &subtype)); + CU_ASSERT(ODP_EVENT_NO_SUBTYPE == subtype); + + compl_event = odp_crypto_compl_from_event(event); + CU_ASSERT(odp_crypto_compl_to_u64(compl_event) == + odp_crypto_compl_to_u64(odp_crypto_compl_from_event(event))); + odp_crypto_compl_result(compl_event, &result); + odp_crypto_compl_free(compl_event); + } + CU_ASSERT(result.pkt == pkt); + CU_ASSERT(result.ctx == (void *)0xdeadbeef); CU_ASSERT(ODP_EVENT_PACKET == odp_event_type(odp_packet_to_event(result.pkt))); CU_ASSERT(ODP_EVENT_PACKET_BASIC == @@ -403,6 +427,7 @@ static void alg_test(odp_crypto_op_t op, ses_params.op = op; ses_params.auth_cipher_text = false; ses_params.op_mode = suite_context.op_mode; + ses_params.pref_mode = suite_context.pref_mode; ses_params.cipher_alg = cipher_alg; ses_params.auth_alg = auth_alg; ses_params.compl_queue = suite_context.queue; @@ -1678,6 +1703,20 @@ int crypto_suite_sync_init(void) return -1; suite_context.queue = ODP_QUEUE_INVALID; + suite_context.pref_mode = ODP_CRYPTO_SYNC; + return 0; +} + +int crypto_suite_async_init(void) +{ + suite_context.pool = odp_pool_lookup("packet_pool"); + if (suite_context.pool == ODP_POOL_INVALID) + return -1; + suite_context.queue = odp_queue_lookup("crypto-out"); + if (suite_context.queue == ODP_QUEUE_INVALID) + return -1; + + suite_context.pref_mode = ODP_CRYPTO_ASYNC; return 0; } diff --git a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.h b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.h index 2bc77a94..c50b8493 100644 --- a/test/common_plat/validation/api/crypto/odp_crypto_test_inp.h +++ b/test/common_plat/validation/api/crypto/odp_crypto_test_inp.h @@ -10,6 +10,7 @@ /* Suite names */ #define ODP_CRYPTO_SYNC_INP "odp_crypto_sync_inp" +#define ODP_CRYPTO_ASYNC_INP "odp_crypto_async_inp" #define ODP_CRYPTO_PACKET_SYNC_INP "odp_crypto_packet_sync_inp" #define ODP_CRYPTO_PACKET_ASYNC_INP "odp_crypto_packet_async_inp" @@ -17,6 +18,7 @@ extern odp_testinfo_t crypto_suite[]; int crypto_suite_sync_init(void); +int crypto_suite_async_init(void); int crypto_suite_packet_sync_init(void); int crypto_suite_packet_async_init(void); int crypto_suite_term(void);