From patchwork Wed Jul 26 15:13:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108776 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp942590obm; Wed, 26 Jul 2017 08:15:10 -0700 (PDT) X-Received: by 10.98.18.131 with SMTP id 3mr1137400pfs.19.1501082110374; Wed, 26 Jul 2017 08:15:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501082110; cv=none; d=google.com; s=arc-20160816; b=RTqcntYQjbRXUhtcfMkgy6vGj1iQ6OS9P5sX9YqVAVSk1lFP1ezrSbRnrRW2xslMPr 3jTuDVziLZn+Kk6banHMXS16ncCE9dA2jIccFPu1O4Gk/jqFMKytGbrZvfjreny22sRt j3GSS/h2WeC+I2P7+YBky5qdah1+kdY9I3Li+sgxr37xwG1pbs8M+LgvcyXus5DpWpHF gs31kiqTdeNLcEY3iI1R0ieOYfKFVedsu59soipNOIXWo8bgEBvZb1mbriG4r3zsXni1 Q/AT9K5YSIvQDOmfNqm74ZOCHlas0Z8zWCFSdel6qW/5OL0eTiXg53ZTgOgHJLijhOjx pvXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Hc5KjniOFCBbIyNDRYRJ+lIRzXFz3E9EjJY4RKdsZrE=; b=OPIKlGfZutkEADl/DOz+sNpXDVZleakCsAAarjoZwZmLK3Z08cUfM95sfc9Vl3eSja 0nREEqhjgGoAehmtFaFIVpQ477EmHsZbCmikyU8guGedVB7zatB6LA8wAFyzID3gdUkW GKvKAxOvhG60IRsnfqpEKSctWAdfreNF0Sixb3LIO3QLFRL3TXTjvCOYhHhegmGTGSNg suUe2bm1GO6/yqVInlUYL1qgdBoCmhYWI2+e8boRMLz/MRj6663Nr6POEypAIGgOHPad YNiKp4A3oT8URw5Fx6dbkr2DId+K6ewkTJXuRlikngmV91dXfU2UnH+HUGP4MCZMnRjR idIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si2610725pgn.17.2017.07.26.08.15.09; Wed, 26 Jul 2017 08:15:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbdGZPPH (ORCPT + 26 others); Wed, 26 Jul 2017 11:15:07 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:57434 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbdGZPPF (ORCPT ); Wed, 26 Jul 2017 11:15:05 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0LxO7W-1dd1fJ2C3W-01716N; Wed, 26 Jul 2017 17:14:47 +0200 From: Arnd Bergmann To: netdev@vger.kernel.org, Kishon Vijay Abraham I , "David S . Miller" , Andrew Lunn , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Raviteja Garimella , Arnd Bergmann , Raju Lakkaraju Subject: [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS Date: Wed, 26 Jul 2017 17:13:59 +0200 Message-Id: <20170726151442.3913622-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:wobBg8he1BAYNmI4UHVzDpLbXk/AybhIVxUo3FV1WC/JOc1XD9Q bflk97nQCY5oL97VN2iQtONdVpYP8gVzZTavIi31Q47jbr9/ZHeuj7f/njsP0pF/6TPxg0W Dce+P49Uq7F7Nb7apZN7SUIIpQv8nB+Rs/eJPlHIa42eqpWf10d7QAAr0mr6yF2EBMIAd3k IKgo6yR3GgGzwKNQLsldA== X-UI-Out-Filterresults: notjunk:1; V01:K0:SphYc2oBRl0=:BJhRoMfop920h24yumcCmG 1W3yqXDBiBGoMchaWepsrAuUadqx8k1d9VSIuF3sosceJ6lSyxtpKjA2JGX+FfqNeGmMfQAwR SQOwogz70cStDHrsdZFoCNpOMbF1o1zscqd3YmfNv6rKG7MkdrKwC7vxffWafZ7Nu7EB6Fjc+ ZEy0lN98Xmps2n70zLG64komkowDh58jmYKewEUAfsMSznx9nSCuoa73a7/giKokbXoe+Dell 86gqt6YL0ssk+J8iLldlS7Ss28rWB+r9uqTVCHTuYlGIFyVWPqWoJQXGLp6Ppj8Dht/jYPwK/ gYwoFsL9xfxCRxu/GYI6kmS+0cHiBWxx5bwVtriXYwflT37jkI65DgUozgDBx3Qu60/mo38xE C3CajHn01QvztCfjf81ylsgReMXSymSl0051EhdcjfZIFsCIGticPE5TAskeZHVxO7ODJTDbo B3ZWqEnUaU7vSptZpChA2YImvrqKbUj4bmjvAUAshO3ou4vdO/zLqGsiaZlmT8LZhYGFEKbP9 VKURn7k8RIa2t0F0bhEnTbe7CHUaxksKEwswtOZeTUZ17cwwdv2oKz/DLg3xISeum96hjoipd +2nnmocPyjfCGbJFSBR2h6swH70pR2BdRt1KdvzICdA1pgX6SOTVYdmHd00M3hQUW6GNq4OEf lwr3uamWm95TXfrSyY/Jk5Jq55yWUqIQFFxMtYHSmoGEqZIkfOKq+jvNQZ+xhSmrzhn7fu2CO Myk+tkxFrfehTItlwvVeGPXaATz5p2QOFqcUDA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I still see build errors in randconfig builds and have had this patch for a while to locally work around it: drivers/built-in.o: In function `xgene_mdio_probe': mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_register' mux-core.c:(.text+0x352168): undefined reference to `mdiobus_free' mux-core.c:(.text+0x3521c0): undefined reference to `mdiobus_alloc_size' The idea is that CONFIG_MDIO_BUS now reflects whether the mdio_bus code is built-in or a module, and other drivers that use the core code can simply depend on that, instead of having a complex dependency line. Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs") Signed-off-by: Arnd Bergmann Reviewed-by: Florian Fainelli --- Submitted this version on June 22 2017 originally as RFC, resending for inclusion this time. Who should pick up the two patches? I guess they could go either through netdev or the generic-phy tree, but they should stay together as a series. --- drivers/net/phy/Kconfig | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) -- 2.9.0 diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 2dda72004a7d..928fd892f167 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -7,7 +7,16 @@ menuconfig MDIO_DEVICE help MDIO devices and driver infrastructure code. -if MDIO_DEVICE +config MDIO_BUS + tristate + default m if PHYLIB=m + default MDIO_DEVICE + help + This internal symbol is used for link time dependencies and it + reflects whether the mdio_bus/mdio_device code is built as a + loadable module or built-in. + +if MDIO_BUS config MDIO_BCM_IPROC tristate "Broadcom iProc MDIO bus controller" @@ -28,7 +37,6 @@ config MDIO_BCM_UNIMAC config MDIO_BITBANG tristate "Bitbanged MDIO buses" - depends on !(MDIO_DEVICE=y && PHYLIB=m) help This module implements the MDIO bus protocol in software, for use by low level drivers that export the ability to @@ -127,7 +135,6 @@ config MDIO_THUNDER tristate "ThunderX SOCs MDIO buses" depends on 64BIT depends on PCI - depends on !(MDIO_DEVICE=y && PHYLIB=m) select MDIO_CAVIUM help This driver supports the MDIO interfaces found on Cavium From patchwork Wed Jul 26 15:14:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108777 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp943368obm; Wed, 26 Jul 2017 08:15:50 -0700 (PDT) X-Received: by 10.99.238.83 with SMTP id n19mr1239211pgk.268.1501082150404; Wed, 26 Jul 2017 08:15:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501082150; cv=none; d=google.com; s=arc-20160816; b=AsJ0izkjTdOnsKEpJ41mHATLOZ/pxwQUH7w3DTEvTvSc5QqcmGjni4dqcNl6t+5I5I /zP0rquLJhXkBaXNYXnqHRYiKpYnAZcXzSGqs0ixKtP1ES16WIEjBJoTESsAkPuL0NvN jBhj4U2+L/OfBIlcJFAYUcMCxuM0L294CbnXv3dDOy/6c+AfChC7zkcf0KDT+00SxMVX 53Qup/d5/u8ltZM2DH/bkKcX36jJhKBsVZDv451wCvJTEoNAven5Zqbu1Dobz+/3DFWn w7RBj42tB0SM/HW+rkihvoYz7VChH1P/ERPYpFGfT5Nix0VPgPoqcSqr2bYNrs8sXa8+ h+Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=B2CCRLrR+o3RneM5NWNqduFiJZY1q3IABHK2lc+McqM=; b=AEzIm+xXmo7sr7tAVkrQRa5wK/HGl6u0PPxtA4Cx8T5JOjNgn6xKeqTPaz4F0VCy3S UcRzqRVAagnBPBRljoE5UJevot59bPdy0td9njeiOKOwuQRErq6PYQxr000zAfzdgBRM 6zy5ph5nyI4BE4UCwafsiQB1NXo81J7VNKjiAHkrhd2nhY6mNw5XIoXT5vhP4ez8tvgs q0LryWWFUOgk/G+Mcrx/jR2OdKLaI3x3gMrpsz52Bal9gvczn3fcOtV8PBk2XK6vWKDW KjIAStk2rfU7LL2wrbeqjvrsUDlI/qMf9CM2zRXF+dodgRiEKUbxeklE/ESamOhDsLmC ILXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si2610725pgn.17.2017.07.26.08.15.49; Wed, 26 Jul 2017 08:15:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbdGZPPs (ORCPT + 26 others); Wed, 26 Jul 2017 11:15:48 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59155 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbdGZPPq (ORCPT ); Wed, 26 Jul 2017 11:15:46 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lj2f0-1e8uN82wVq-00dC4Z; Wed, 26 Jul 2017 17:15:32 +0200 From: Arnd Bergmann To: netdev@vger.kernel.org, Kishon Vijay Abraham I , "David S . Miller" Cc: Andrew Lunn , Florian Fainelli , linux-kernel@vger.kernel.org, Raviteja Garimella , Arnd Bergmann , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Date: Wed, 26 Jul 2017 17:14:00 +0200 Message-Id: <20170726151442.3913622-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170726151442.3913622-1-arnd@arndb.de> References: <20170726151442.3913622-1-arnd@arndb.de> X-Provags-ID: V03:K0:AF0HanJqhPmxgtU1q0wbwVcfw7x95ZNRHR3DUrVcix8bxLxTazF j0F2I6pY9lDOS3QOkJkGrxP5V0OFS8NDSfSziyj7Zn3EqBU7/Rvo9Tu06PMchiqWUqbYWfl lieBxy3qEVGaKPsBFwmvTYVbzKAPMpj0AsT5DBiMfFlyxs8HL9EyQ0I1spKD1bBAjNark3+ Qs68DMWKTUawB6sf4k6kw== X-UI-Out-Filterresults: notjunk:1; V01:K0:dK3T983+Cfk=:OmUctFzS37bW3Q74rlj8+c i+2qvbdq23+Esd2kOL4BOC97EkYyhatfPK6soZp/7GhanMlrnor4xbbJNmbr3ZR2vgmhcSAab tgIdFd3fFZ3EFdc17JBZcO5eJhIWXtTZvDECXn+O9fCcYhNKiAT2g651ZtwrqPWe6srnJA8Tx hvMWsa7EHGmIPTMu+ofV1ogQyalriLG9exWVq0MFUbthDF0c5wqFajufIVNxd/KKQhX5umoep PzaZnQE6HCDRcXxm/FLRUMWEWyRWjfIB2ybKV7LI/UDV5BUd8Xqq5wQWWK+9FB0DXjdT57Z1j fA05hQLh0LYJ2NRmJHJ1QgllE1DbFhsTP9OSYh3JT6Ln8emnCxBtJ9RWhKDHmgcWLftuxMtwp 4KgfG7UYt0b/l0rBdVBE2xmSiFkdNPyUFeTEuV1A/dsiumjSz8oFUn9Sh8J6uIYxvSpD08kl6 a+eYb3yx/ritA+SvjgiN6LpLbnXgv34DBtZKIwsic+2JVj7ZiERIhDWA3cPvjuZ8jqxdBTuaw HDLKoo4M6+guf8lKWL80JJ21geWzkpABNLLJgJq2pqg4ClWv1qmPDvMv3jcqDJhQ54xbW4Qnu w/IXf6RLoOj00Hx+ZU7UH2r8IhbigGsPkOeWQAYCJK6ijwEntl8g4nFCH8VfQrZ1hHGJWQHWQ 4VqEV0UzAeQTx2nzSU7IjpNzVbN24Uihn7eQSlMBQqdZt0ZsQPBouiHl8KPufof6l09XMy1Xi SKArjLXLcv187hGpeEh85nQ51Z4yWREPN7Aseg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver attempts to 'select MDIO_DEVICE', but the code is actually a loadable module when PHYLIB=m: drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write': phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit': phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init': phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register' phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister' Using 'depends on MDIO_BUS' instead will avoid the link error. Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") Signed-off-by: Arnd Bergmann Reviewed-by: Florian Fainelli --- drivers/phy/broadcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig index 37371b89b14f..64fc59c3ae6d 100644 --- a/drivers/phy/broadcom/Kconfig +++ b/drivers/phy/broadcom/Kconfig @@ -30,8 +30,8 @@ config PHY_BCM_NS_USB3 tristate "Broadcom Northstar USB 3.0 PHY Driver" depends on ARCH_BCM_IPROC || COMPILE_TEST depends on HAS_IOMEM && OF + depends on MDIO_BUS select GENERIC_PHY - select MDIO_DEVICE help Enable this to support Broadcom USB 3.0 PHY connected to the USB controller on Northstar family.