From patchwork Thu Aug 10 12:13:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 109800 Delivered-To: patch@linaro.org Received: by 10.182.109.195 with SMTP id hu3csp2277079obb; Thu, 10 Aug 2017 05:13:52 -0700 (PDT) X-Received: by 10.84.192.131 with SMTP id c3mr11655284pld.9.1502367232892; Thu, 10 Aug 2017 05:13:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502367232; cv=none; d=google.com; s=arc-20160816; b=BczU+Ny7Xgm9AaeD5tjlPBK5gUmoMYFiET2gV/rGm3+jfUQ76oFBt9IVDrRvOADIBb W++SQzVDXql2vUhBB/bsdqaGbvTIV5QK45vmDzip9l4NVWJW31ezUjqRGCSvFF/fia9R bYyhXsPOUxXjRn6LBFpiCzwhweiQiHirbpHeqALEMoFIjnKzqEsqJSboWZeaB3gyXCnO aymvmy+L+YZ5zgcM8h1OednO+Etj1MrChn+qaIWNap3fvOmqd4VFN3bNuTZdhN2PTfwl R1FhGt3VbHarYVN1Iq4bxDV7oklM6vYj/ej//RGN7FXfK1/EQrUPdWqSFhXk1Ri3i1gc c8XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Mg3q+wIxRW6Y0wOdxtd30Ha+lxraRRxQ76lzVTh4wZI=; b=QSuu75elxK2AOyp0EwN2JXKQarwTBifpjOi8+jl89tNZO+XuhYMhAez8Lste7Sa8Va cP5ukyy0ZE25aa5tNYLtuYhDiitw6Zvlh78lnbo6V4InyIS8ufSk+R3NhFAavQ/2yNV4 hdCeCxeO7d/uAkhx9powikvyoLPwLW2jzD19ET9d9jz0Y/s8IkdMXIqcBgyCE0p0zU1y rR+lEEq0AXqbjx37ACv2o5xiifMHSF8ugVEfBZuow/YDrE3mwNuWyxZWN0ihivqr1X2A iXDRXIAPtQJ6Ym+FCWkJDegR8mVD+gsCszwFp3NKKwzJ8K7hMRsDnaTmjm0D74opiDWN +vPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l36si4414295plg.976.2017.08.10.05.13.52; Thu, 10 Aug 2017 05:13:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbdHJMNu (ORCPT + 25 others); Thu, 10 Aug 2017 08:13:50 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:59578 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbdHJMNr (ORCPT ); Thu, 10 Aug 2017 08:13:47 -0400 Received: from wuerfel.lan ([95.208.155.18]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MaKMq-1dv6Gu3XFw-00JuF8; Thu, 10 Aug 2017 14:13:37 +0200 From: Arnd Bergmann To: Andy Gross , David Brown , Mark Brown Cc: Arnd Bergmann , Varadarajan Narayanan , Matthew McClintock , Sudeep Holla , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] spi: qup: hide warning for uninitialized variable Date: Thu, 10 Aug 2017 14:13:26 +0200 Message-Id: <20170810121335.2581513-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:o2kygsbujxDeFXRd1i5MiP9OVoVLvuqdSDBF3BoE1/eqZdpzkMQ ObDHUmKbDYOFIb/Fw3lCG9tqkzIrZ8HEfpbkX4b4lMSOtSUE0KNjWbh+fcrq16zQi3VnjvG EdxLaGVHa3Dxh2zRokVEjpGlck7LERtVBWTYLpzaIIRMdpxgcpkyX5sVLM3wwFxB4tjFQj3 xFhu0cUr4CRqyW8AjLy8Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:kTlxpnB9eRs=:UquE5Drf7Impb7FSc9KrCQ ahL4LfLHX89YfPyiJyEvouGfJjamQpW5912a51eaHyqPXOMU4KRIzn1rdiMTiCj18+rlruMTU lMZhJF+EJp1gDTn5cpOm3CKM3FiEekyz2fHzTiWMsI3KId6jIm1iwQG1HRJr61n1wDFCaQJKo ps1VRtTJRzJYOjmwfDW1k9hn149/y5jZ5GcNK6b0yRqFgUs3ick+UhSrVeFxmb0UUuLM9Wt7F iX61Nda73UxF4LWDTSLm/VectqwaYcM/rQP0lMATXLRWB22Mv7cC30h327LpvZBmCiUcU4x4w 2TCJMRjlRf9+vhfmtR3Rwo6qB1wmTWgIAwFHhIfOgDa2xFoUFNowot6xsh0zWVRaSPpSBBV3M L7wNQiSJaKo6JELjaA/mjrOKZG5xu75yRpDQq5PQ43tikpxy3ocMsPSmelKYmAxRtWuxhRFYm GAXFLmM7sorgG2j2i5SRdKUODp538I4vf5zBWJ02oUqe1XAb2XE9waE1NaAzdvacM6lH5xbS/ ejWPnWFWwFGvsElD2gIgGx4xz6p3a6PqhVl8PT7DC0adyop5hY1AWeNBeZBx7XQsbJk7CsHJ5 DQMFu9fuSKA4YJK1N2O0e26QJUlGH1YxSwa+9NEX/aaBOc+dCBdzmgvE2SysaLNp+9EfzYA5J m8Quc0hGmdABPeB+fJN6c3zb5UsHE+oicL9+twifyXcMfgksDkMo5dBCglYxt23XZ54WLTHj4 0wP3DvjxPBL5RTDOPiW6IbCvj4SUt3o0Gq6ovQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The added conditionals in this function apparently confused gcc to the point that it no longer sees the code is safe and instead shows a false-positive warning: drivers/spi/spi-qup.c: In function 'spi_qup_transfer_one': drivers/spi/spi-qup.c:507:28: error: 'tx_nents' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/spi/spi-qup.c:464:17: note: 'tx_nents' was declared here drivers/spi/spi-qup.c:505:28: error: 'rx_nents' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/spi/spi-qup.c:464:7: note: 'rx_nents' was declared here This moves the initialization to a place that makes it obvious to the compiler. Fixes: 5884e17ef3cb ("spi: qup: allow multiple DMA transactions per spi xfer") Signed-off-by: Arnd Bergmann --- drivers/spi/spi-qup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.9.0 diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 1364516e87c2..e9ecd67cd817 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -427,8 +427,6 @@ static u32 spi_qup_sgl_get_nents_len(struct scatterlist *sgl, u32 max, struct scatterlist *sg; u32 total = 0; - *nents = 0; - for (sg = sgl; sg; sg = sg_next(sg)) { unsigned int len = sg_dma_len(sg); @@ -461,7 +459,7 @@ static int spi_qup_do_dma(struct spi_device *spi, struct spi_transfer *xfer, tx_sgl = xfer->tx_sg.sgl; do { - u32 rx_nents, tx_nents; + u32 rx_nents = 0, tx_nents = 0; if (rx_sgl) qup->n_words = spi_qup_sgl_get_nents_len(rx_sgl,