From patchwork Sat Aug 19 21:40:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 110463 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp2528762qge; Sat, 19 Aug 2017 14:41:15 -0700 (PDT) X-Received: by 10.200.38.212 with SMTP id 20mr17953768qtp.112.1503178875485; Sat, 19 Aug 2017 14:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503178875; cv=none; d=google.com; s=arc-20160816; b=0kxDFyY1W+vHkZD/DcmTz2myUztG8MVNzwOUkRnoV8qNgXYnrC1nRsdzVaGRloT9wm 9/EHckq2JciAl4NT2IoBVZutJwfHk/6i91OisY/8GXwSDOHmRYPrM6SnqmBsM+L7snYI FS2sDv6Y9WdZv2FbJD4cct7ssYn6yF35JVSMKfjuKIX3w5Jyv4T0hbsWXeUHw3VimgNB jr2aFc25jYXZ6PJoutUMb9F63DrS/tWL+JcJkFs0WlZiqzgLE9/Nuecko+NqmZcO1XO7 fKwYVC8FpJCc4t3z/lsvy3dVlCPV85r65mFVge5svLVuxnGvFgAQ7F67FenKXfjJzA9+ lPzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=Gceo575WI+St4thpyUhuA2+zA0s1j8PrafQh3G3ffuM=; b=IrHgDFZLyNObspaAeTju0guWvLNmZV2zEF+6SX6mAP44tm9gpIwS57780+Lrs6okLb lcNfZGnj8i048l3iie+avk17dQ4Te8xU92pzbUOo/koveWZ7DH7QYZ1/zrbtlaNwv/z5 wkmH6sRCh0ja+v2uYLTP1Ezd9eBFscOj0ylYsC3C645d+yb2ajLRXepACeKenosn6h2d KvakYCR/SwKrdmIwRHceho0fPtiucdbiZqZZKqDthBdiXzOAq1cd3x8v4tDjTRZJZh7r 4/gmxOemlQqlg0EJjLwTxt+qOjAUIOsG0Rt+vPU0jtwGb6io4VtZqb/umBnxQRmrb00D s9YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Ajszst3U; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id k65si8194613qkd.252.2017.08.19.14.41.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 14:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Ajszst3U; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:38160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBUX-0000FW-Cw for patch@linaro.org; Sat, 19 Aug 2017 17:41:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBUD-0000DV-AJ for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djBUB-0007Gb-DM for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:53 -0400 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:37961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djBUB-0007FT-6L for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:51 -0400 Received: by mail-pg0-x243.google.com with SMTP id 123so18973679pga.5 for ; Sat, 19 Aug 2017 14:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gceo575WI+St4thpyUhuA2+zA0s1j8PrafQh3G3ffuM=; b=Ajszst3U90YW0K0Y1cE85SqOjOjjtv7SQDQ4IgVjN4XQCM1AsnqoiKink7s0mEOZMG SOJt8z/kFUvNj1JE2Vrs5czFt8IeLZOOKwYatPwAHUVwqLpAmalT49JAfYaHag/t3s1a ejllSEQ8cKPZfC3ZMNIQQAdZVHPjy8OHzHXL+fo8L9+gn73DeHHW84kQ/+jnLJSZDP3s URIKaEhOcl3O0CNLNU6Hv0+BTSffa8Q634bDRxI22WqPP3kMBbhzZkRmY+0ybVFL0OX3 mdX0T3BpenFRqrR8mK4/vwmEV5eXBUykZr2qzMbqGd0i+6QWwVZcnYhzEiLAd7vd86I4 TeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Gceo575WI+St4thpyUhuA2+zA0s1j8PrafQh3G3ffuM=; b=U0LLjI3MC2dkWxEmQGfVJ1lRBfrBHSq2Kvaxdc0NgLly9nzlfEhZKX7Ji8gIXBI326 dqA7BIr67GvpvEFsg8EiUTobGVVy6CaTeqMG93BsQKinOuuLTp7RAlIrdP5pzVdmnHbm h8IkW7tVf8bSTPXQCAqLuE80DUjgVpjRyBTtBlP5u4m58uJPySEdaTTx7e6pYZhCooiF sVHc712HeFA4TXecA/j6Ezrxj/si4UgmkxWPndSscGRhQs6pbDHbqhEbL213Tv1ymidD 4QMzu/z/uXVO2NzdYKiHtDX/EhCsdBF5WT85QOcNMU+wQf5UPTcacyd6snm9ZSRJcEFZ 68nQ== X-Gm-Message-State: AHYfb5jlWfJkTmX4mWw9q7PESWwEkkqnYR+MMxf5+DKJbPKRaPjaQPh4 w5Ype0O0an+zgQ== X-Received: by 10.84.231.140 with SMTP id g12mr14497038plk.256.1503178850176; Sat, 19 Aug 2017 14:40:50 -0700 (PDT) Received: from serve.minyard.net ([47.184.154.34]) by smtp.gmail.com with ESMTPSA id d86sm17531478pfk.43.2017.08.19.14.40.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Aug 2017 14:40:49 -0700 (PDT) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id EC44195F; Sat, 19 Aug 2017 16:40:44 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 3E3B1300013; Sat, 19 Aug 2017 16:40:42 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Sat, 19 Aug 2017 16:40:38 -0500 Message-Id: <1503178840-21512-2-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503178840-21512-1-git-send-email-minyard@acm.org> References: <1503178840-21512-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 Subject: [Qemu-devel] [PATCH 1/3] ipmi: Fix SEL get/set time commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , =?utf-8?q?C=C3=A9dric_Le_Goater?= , David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard The minimum message size was wrong for both commands, for getting the time it's zero and for setting the time it's 4. And the data was being pulled from the wrong place in the set time message, it should be the first four bytes. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_sim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 277c28c..1c732aa 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -1571,7 +1571,7 @@ static void set_sel_time(IPMIBmcSim *ibs, uint32_t val; struct ipmi_time now; - val = cmd[2] | (cmd[3] << 8) | (cmd[4] << 16) | (cmd[5] << 24); + val = cmd[0] | (cmd[1] << 8) | (cmd[2] << 16) | (cmd[3] << 24); ipmi_gettime(&now); ibs->sel.time_offset = now.tv_sec - ((long) val); } @@ -1802,8 +1802,8 @@ static const IPMICmdHandler storage_cmds[] = { [IPMI_CMD_GET_SEL_ENTRY] = { get_sel_entry, 8 }, [IPMI_CMD_ADD_SEL_ENTRY] = { add_sel_entry, 18 }, [IPMI_CMD_CLEAR_SEL] = { clear_sel, 8 }, - [IPMI_CMD_GET_SEL_TIME] = { get_sel_time, 6 }, - [IPMI_CMD_SET_SEL_TIME] = { set_sel_time }, + [IPMI_CMD_GET_SEL_TIME] = { get_sel_time }, + [IPMI_CMD_SET_SEL_TIME] = { set_sel_time, 4 }, }; static const IPMINetfn storage_netfn = { From patchwork Sat Aug 19 21:40:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 110464 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp2529708qge; Sat, 19 Aug 2017 14:42:49 -0700 (PDT) X-Received: by 10.55.26.100 with SMTP id a97mr16699194qka.257.1503178969028; Sat, 19 Aug 2017 14:42:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503178969; cv=none; d=google.com; s=arc-20160816; b=rNN9u5ZxDPqRuWXGbwCRK7teYXDPVua79L2fuld+2dbXXZJIUORx+x8bVJR1wXcR0S Pk0BBUEmNb+aDpBSHKlMBCRE4/pM29xeSKFbuHveS96kqfCz1mXpjR6osAqayybxbH/H 60kI4HexKG9jsUC2Xe+avXe83z+NVradunsBpoQ2+SJwkTUCFsu085VBRHhF9SyxIH/F gmkaL9LbyP21gj/VxIL34dZHglcvdQDx5ZdT8cGvrohTCKvSbGP2Kp10vb0V/S8rv5df 5TABSGbrkXwsOrFWBoo2WGfM4wVrs47xch5rTB0scniOKE53OhlSYwY2zEs3u8cGwPbE Vp6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=Kt85tNs/v/YRp8+R3YmTS4DAlihquaA5HFUEzSSY11w=; b=r1h+8DDDIicVuiF3p39QFQBZbAAkchVagmsWOpVJ5lTGbyIADhfUR1uWWvIm6gvSYi lWzxs6+KbG+ab0PzKQenxkXAdPAJbsDNRx7+8LHdfSCEWW8IQXMct3bdcIfkKuo+IleJ FhDy4Ta8lrqUzeuJkjIh9fbFe8fQcvRTH+JFlH7zDGIS8lrx+ijYqc7hrc3roT73zeGp e1OHhh2wGq/hJ/v8tBrsTthY4GS7enLSMIcVtYc2Emcbe8/PmShXijP1+j+0kiMOERZM XbQHyM/RmD84Vm73u7WJjjV1aHZXPsXhOfMoun0admuKktZ5vcOmEEblysz3siVGVU0l Khhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qBblVHiZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v22si6361087qtj.532.2017.08.19.14.42.48 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 14:42:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qBblVHiZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:38182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBW2-0001Hw-VD for patch@linaro.org; Sat, 19 Aug 2017 17:42:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBUD-0000DY-BF for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djBUA-0007Fl-VE for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:53 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:36217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djBUA-00078d-P7 for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:50 -0400 Received: by mail-pf0-x244.google.com with SMTP id t83so3486688pfj.3 for ; Sat, 19 Aug 2017 14:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Kt85tNs/v/YRp8+R3YmTS4DAlihquaA5HFUEzSSY11w=; b=qBblVHiZY07u15DilQ1jQkzEmi71WO3sI6AIekVWszWhJIrPrKLmAkwLzgfF9kLYnF Gc6RVMrb4s+MmxFzSvg4AwN9c9ejl8E4jpKnCn4qPycgs8gnbALZL57jUM58LrUlbABC wEA/86CdMThY6ZlygDY2IPgN96xS+SApdh+EgAL6n92htKAPWwVZgTVn5p3jrbUujfCv e6z2o/U5kpQmxYrYnbJc7H7+G035Mm86FY77ZVqCaD2uXRTg6STgN1nprE9awf2TvdGP TmvRdaCYWI6r64DRdNj+lRe7pHvUwfV5xaPq4kBf7I842j7ovQFeziAyWx99eH5w/4I9 u14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Kt85tNs/v/YRp8+R3YmTS4DAlihquaA5HFUEzSSY11w=; b=uQsr6IQoWnlvLEAhfknzWkJcDWzIiyM9YSTzoj3klm4v7v0cbqJiYp7jElmy1JAdxO 3WHKTF7dcAC+yySUUoAo5gsHq2jV/J8LJCbK5G6dC6zUeuhRtMpunYGWR6oprbR9skqK l5pI0FmfhaPFx+zhR/WhV0HKEOOWELD5JI15K54OOpeB7bFWrQMdwjoAByDCxfZcuefD d/hsQOCIMm4q3H6Rqb7LoQVflTyCv6Z/uwQNy5HK2q3+0aBsI8XBL1JGrdv47YdrYH3P D0jZGOn2IAEzzg/nLfSBhgPO9YhZvJfg2WkxP3+v1AMm31b1Kl6YRep9hxXlSuiG51vv 2W+g== X-Gm-Message-State: AHYfb5ipexIstJwQ5hrQlw7Sx4c13DrmVmF2Gra+6nG4Tv7nsF4H39Fg Y0okChZRt+S7RQ== X-Received: by 10.99.49.20 with SMTP id x20mr12444886pgx.102.1503178848258; Sat, 19 Aug 2017 14:40:48 -0700 (PDT) Received: from serve.minyard.net ([47.184.154.34]) by smtp.gmail.com with ESMTPSA id h8sm17105881pfe.81.2017.08.19.14.40.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Aug 2017 14:40:46 -0700 (PDT) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id DEE4093F; Sat, 19 Aug 2017 16:40:44 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 56E5930009D; Sat, 19 Aug 2017 16:40:43 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Sat, 19 Aug 2017 16:40:39 -0500 Message-Id: <1503178840-21512-3-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503178840-21512-1-git-send-email-minyard@acm.org> References: <1503178840-21512-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH 2/3] ipmi: Don't set the timestamp on add events that don't have it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , =?utf-8?q?C=C3=A9dric_Le_Goater?= , David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard According to the spec, event types from 0x0e to 0xff do not have a timestamp. So don't set it when adding those types. This required putting the timestamp in a temporary buffer, since it's still required to set the last addition time. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_sim.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.7.4 Reviewed-by: Cédric Le Goater diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 1c732aa..0f191e8 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -443,16 +443,20 @@ static void sel_inc_reservation(IPMISel *sel) /* Returns 1 if the SEL is full and can't hold the event. */ static int sel_add_event(IPMIBmcSim *ibs, uint8_t *event) { + uint8_t ts[4]; + event[0] = 0xff; event[1] = 0xff; - set_timestamp(ibs, event + 3); + set_timestamp(ibs, ts); + if (event[2] < 0xe0) /* Don't set timestamps for these, per the spec. */ + memcpy(event + 3, ts, 4); if (ibs->sel.next_free == MAX_SEL_SIZE) { ibs->sel.overflow = 1; return 1; } event[0] = ibs->sel.next_free & 0xff; event[1] = (ibs->sel.next_free >> 8) & 0xff; - memcpy(ibs->sel.last_addition, event + 3, 4); + memcpy(ibs->sel.last_addition, ts, 4); memcpy(ibs->sel.sel[ibs->sel.next_free], event, 16); ibs->sel.next_free++; sel_inc_reservation(&ibs->sel); From patchwork Sat Aug 19 21:40:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 110465 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp2530224qge; Sat, 19 Aug 2017 14:43:41 -0700 (PDT) X-Received: by 10.237.59.80 with SMTP id q16mr14215323qte.334.1503179021904; Sat, 19 Aug 2017 14:43:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503179021; cv=none; d=google.com; s=arc-20160816; b=T3mLewpDJzvCH/8h0/PQkbie1+36aj0kmCaWgZT/qn4okq0dTMr5jpnykucQDsEkAy LTBxAIO2b7DlzcWpMj/IUdPbkNx3XMU6eIFTc9oGNzHRGEHo05ICAGIN9MgB0K7VEvgt comE/8G9Xffrotro4BcIDkQdh1n6WBiPnQIoqqoHxKp0Hm0dR9nSSIfz36v/3fMveB3J GlD5CmAsPS+JGLgMdJDN+z98CrPBwpvh0Z3mSIMuD52WPvflgkK7g5zGHPonPIXBCjtQ YiCblChOX0mry/XmaEBrs+i53cnOm7ypnMSxSHrpaVLI3VRHyohXUMBfaBAsaVfIEZh7 eRsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=3XRpYwfC5vuIr0t/BVn21+uhaxomAHENyVwRN9um43c=; b=rmioNl0m2cKSbGmxOOLCo662dwstR0i+MwRT8i6GNcPZ2fQN5OfK2ewOEtbjF8N3QR ErW4c0xZZPMz2dTu523uWt/9pMli9Y1Ac/OMgHlA3RCsL3YAg3zdhM+l3EaNaWAGloIc b65/qF5nVGVVAoQZoSCTvszlKsdwTnhg0obA0XaHOUvAcR+oV/D7jLZ63znw0G11orIb okY4JKVo747LnjQSMe9QTCv1bvbZVl/L1du5EYjoWynVy2pSV5NSTGSA1wMWgZ0tQy74 zINWnnKlVoLvztwsAyVhSbL2WOrWNuFmd3agneODEvvCwM3Vc9PWUaGV/kg76yc9Y6Fj 8w2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ne7SBitz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id p71si2972698qkp.550.2017.08.19.14.43.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 14:43:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ne7SBitz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:38207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBWt-0002DY-Ss for patch@linaro.org; Sat, 19 Aug 2017 17:43:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBUD-0000DW-B3 for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djBUA-0007Ei-Ex for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:53 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:33903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djBUA-0007BJ-6g for qemu-devel@nongnu.org; Sat, 19 Aug 2017 17:40:50 -0400 Received: by mail-pg0-x242.google.com with SMTP id i12so3691134pgr.1 for ; Sat, 19 Aug 2017 14:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=3XRpYwfC5vuIr0t/BVn21+uhaxomAHENyVwRN9um43c=; b=ne7SBitzqyMxZl7ImYPs2Ye1r8zWN938aqGGuLNl3ZwjN6WstVePq/6pSKWOeqme6Y ujBZpu71tVb6e96wMLMW8tAdFaxNZZtXc5iUyikBdYo6bGfS7a+4ODok/24ZBhqPEhkL wMSEgxDf4Z24jQ4j2VRUgDegRV4uObyuCnFE0aHiEawT6dn5gzICJdz+RmbB0cd4xL5Z hKuH1fiBrKIU5WnRVGFKUqUvaPeDQMM5zfNopPNMHxfG7Bgmvox06JM6dZNFqymzdAYS 8PflHY6SB7IJoWt3gnP/wIsBkKISPvpLL24N6bUbf+IfI4a1duWJIMlRuyi/iaerArn9 d8Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=3XRpYwfC5vuIr0t/BVn21+uhaxomAHENyVwRN9um43c=; b=nmmMgvu/WqWEcMkvIhkzZDYeUogO9fVumtcwTqLLuxFjsn2jyPNQw5dBU/7mjbHKVt Nm/k1OwVgbFPi4kozSu+Fv1OYKxJUZJFOTxW2Y/Fv7nnxsRexuiJ4TB4eob16tjeAOzY 4XpJwGgt+z69lNFxGCquiSMve9D//Hc04GxJh2jS1HT0k9K0caSSj2s0BxEUxTeKUGcm g78LbKuCgs/5kLkzb2Ci3traXTV5Oey/Dfkgo2mtZg/M3qafnqQxOXvrO/9mJoT7J+A/ 8gfQMLOVZdj2GUU/7T0W7MhdaBsVJA/b+giykB1ZaJt5Fshh8cv10qI1a2gdLX1zuPO7 oXYA== X-Gm-Message-State: AHYfb5gszK34WF1ns64MUXwmt00rEhQ8RMwmNBRS/b9L1ZglArL0Qjih HR+xDrtvak1A1A== X-Received: by 10.99.157.204 with SMTP id i195mr10588547pgd.101.1503178849104; Sat, 19 Aug 2017 14:40:49 -0700 (PDT) Received: from serve.minyard.net ([47.184.154.34]) by smtp.gmail.com with ESMTPSA id h8sm17105879pfe.81.2017.08.19.14.40.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Aug 2017 14:40:46 -0700 (PDT) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id BEE3E2E5; Sat, 19 Aug 2017 16:40:44 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 4A851300080; Sat, 19 Aug 2017 16:40:43 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Sat, 19 Aug 2017 16:40:40 -0500 Message-Id: <1503178840-21512-4-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503178840-21512-1-git-send-email-minyard@acm.org> References: <1503178840-21512-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH 3/3] ipmi: Add the platform event message command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , =?utf-8?q?C=C3=A9dric_Le_Goater?= , David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard This lets an event be added to the SEL as if a sensor had generated it. The OpenIPMI driver uses it for storing panic event information. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_sim.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 0f191e8..09b15a8 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -38,6 +38,7 @@ #define IPMI_NETFN_SENSOR_EVENT 0x04 +#define IPMI_CMD_PLATFORM_EVENT_MSG 0x02 #define IPMI_CMD_SET_SENSOR_EVT_ENABLE 0x28 #define IPMI_CMD_GET_SENSOR_EVT_ENABLE 0x29 #define IPMI_CMD_REARM_SENSOR_EVTS 0x2a @@ -1580,6 +1581,27 @@ static void set_sel_time(IPMIBmcSim *ibs, ibs->sel.time_offset = now.tv_sec - ((long) val); } +static void platform_event_msg(IPMIBmcSim *ibs, + uint8_t *cmd, unsigned int cmd_len, + RspBuffer *rsp) +{ + uint8_t event[16]; + + event[2] = 2; /* System event record */ + event[7] = cmd[0]; /* Generator ID */ + event[8] = 0; + event[9] = cmd[1]; /* EvMRev */ + event[10] = cmd[2]; /* Sensor type */ + event[11] = cmd[3]; /* Sensor number */ + event[12] = cmd[4]; /* Event dir / Event type */ + event[13] = cmd[5]; /* Event data 1 */ + event[14] = cmd[6]; /* Event data 2 */ + event[15] = cmd[7]; /* Event data 3 */ + + if (sel_add_event(ibs, event)) + rsp_buffer_set_error(rsp, IPMI_CC_OUT_OF_SPACE); +} + static void set_sensor_evt_enable(IPMIBmcSim *ibs, uint8_t *cmd, unsigned int cmd_len, RspBuffer *rsp) @@ -1756,6 +1778,7 @@ static const IPMINetfn chassis_netfn = { }; static const IPMICmdHandler sensor_event_cmds[] = { + [IPMI_CMD_PLATFORM_EVENT_MSG] = { platform_event_msg, 8 }, [IPMI_CMD_SET_SENSOR_EVT_ENABLE] = { set_sensor_evt_enable, 4 }, [IPMI_CMD_GET_SENSOR_EVT_ENABLE] = { get_sensor_evt_enable, 3 }, [IPMI_CMD_REARM_SENSOR_EVTS] = { rearm_sensor_evts, 4 },