From patchwork Thu Jun 25 15:35:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: B K Karthik X-Patchwork-Id: 209303 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83BBEC433DF for ; Thu, 25 Jun 2020 15:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F953207D8 for ; Thu, 25 Jun 2020 15:35:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pesu-pes-edu.20150623.gappssmtp.com header.i=@pesu-pes-edu.20150623.gappssmtp.com header.b="1YlTo2+H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405828AbgFYPf1 (ORCPT ); Thu, 25 Jun 2020 11:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405746AbgFYPf0 (ORCPT ); Thu, 25 Jun 2020 11:35:26 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9666C08C5DB for ; Thu, 25 Jun 2020 08:35:26 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id u185so1150611pfu.1 for ; Thu, 25 Jun 2020 08:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pesu-pes-edu.20150623.gappssmtp.com; s=20150623; h=from:date:to:subject:message-id:mime-version:content-disposition :user-agent; bh=x5rltbZgoac+dXb+DOgX5rzO4ebpNO9QKIAaqizWabE=; b=1YlTo2+HW3hy9QDNoY9ia6mxIaKs0Lmc62+aANLbGds86ssI1gK73TAkjnObtlBJ59 s8tgqw+IHZmO4qHNdku31gfctjoCG5Gay5R6e6iJBbVX2prZ4X3MkQ6ikPMCmFN7XUoy x9qVWk2zDe3W1xy3riTJGueSp06DeMbd1gO9BSdpWMz4bVFwpOIZDqnWqK4JL0q+GzdZ KRhVDKUnjRhRr1ylDZkZa4Z4gWB91Hs1nJHHBLX0yseO1KI6Y6lqRo8NV+d8D263DsMT EfJF8tjhRDmqoTP6ruWR0N2/Skk18+JZ2M/0HoqI3Hxf4eS8k40ZrADS7BacuDQg2uiz rc8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-disposition:user-agent; bh=x5rltbZgoac+dXb+DOgX5rzO4ebpNO9QKIAaqizWabE=; b=JXaCG3XztO2L1SSvL/tysU53Kcn+EOv9dUPydwEK2pCvLem2zXgbU2mHdbRpg/xmlF +L6nQxmLcghJmA0FYRXoKeiwPQ/i7AqE/gnq4E9O2QEeEIWxzun6fzPU7SOlSDsZJ9G2 kbfmL0ENjMpd2LTFfG1rxRNjT69b0L4u4ICNS00YXpS7OG5mtEr3FZ8s0nKDBse6almc /8nuM4JRZleKfBG02kBZARkc6/ZECBynCZvxJTW3PdiUaTD0WKDKkJ0qljRheWZBCKK8 IfTxt07L3u7OYln36KwS+MiZDtaYZ2hZ/OBlDjZJs/Mh1IzWv3O7qlLQG6OrOwV4l/5S zB6w== X-Gm-Message-State: AOAM532CFn3BkQxMXR/ziXbUMIIWNzopfK8jQt4jd4J1csQ4nXzxFeO4 XQqr1vl8A8/Ecd3MBhbAHKs0gA== X-Google-Smtp-Source: ABdhPJz92oCQkSLzT6L0cPk15+CVAR5bLEmDnDtyxkVfGo3rWkJazMXpdCnSRpNO27I/0plMLIwTew== X-Received: by 2002:aa7:84cc:: with SMTP id x12mr33886230pfn.235.1593099325951; Thu, 25 Jun 2020 08:35:25 -0700 (PDT) Received: from localhost ([2406:7400:73:51e4:908:f18a:1156:5c38]) by smtp.gmail.com with ESMTPSA id o1sm8649025pjp.37.2020.06.25.08.35.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 08:35:24 -0700 (PDT) From: B K Karthik X-Google-Original-From: B K Karthik Date: Thu, 25 Jun 2020 11:35:17 -0400 To: Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Laurent Pinchart , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] staging: media: soc_camera: Adding parentheses to macro defination at line 241, Clearing alignment issues at lines 410 and 1270, fixing return values at EPOLLERR Message-ID: <20200625153516.fibpfsodnogrimlh@pesu-pes-edu> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20180716 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org staging: media: soc_camera: soc_camera.c: Clearing coding-style problem "Macros with complex values should be enclosed in parentheses" in line 241 by adding parentheses. staging: media: soc_camera: soc_camera.c: Clearing coding-style problem "Alignment should match open parenthesis" by adding tab spaces in line 410. staging: media: soc_camera: soc_camera.c: Clearing coding-style problem "return of an errno should typically be negative" by adding a "-" in front of EPOLLER in line 812. staging: media: soc_camera: soc_camera.c: Clearing coding-style problem "Alignment should match open parenthesis" by adding tab spaces in line 1270. Signed-off-by: B K Karthik --- drivers/staging/media/soc_camera/soc_camera.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/soc_camera/soc_camera.c b/drivers/staging/media/soc_camera/soc_camera.c index 39f513f69b89..66a14ebd8093 100644 --- a/drivers/staging/media/soc_camera/soc_camera.c +++ b/drivers/staging/media/soc_camera/soc_camera.c @@ -238,8 +238,8 @@ unsigned long soc_camera_apply_board_flags(struct soc_camera_subdev_desc *ssdd, } EXPORT_SYMBOL(soc_camera_apply_board_flags); -#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \ - ((x) >> 24) & 0xff +#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \ + ((x) >> 24) & 0xff) static int soc_camera_try_fmt(struct soc_camera_device *icd, struct v4l2_format *f) @@ -407,7 +407,7 @@ static int soc_camera_dqbuf(struct file *file, void *priv, } static int soc_camera_create_bufs(struct file *file, void *priv, - struct v4l2_create_buffers *create) + struct v4l2_create_buffers *create) { struct soc_camera_device *icd = file->private_data; int ret; @@ -806,10 +806,10 @@ static __poll_t soc_camera_poll(struct file *file, poll_table *pt) { struct soc_camera_device *icd = file->private_data; struct soc_camera_host *ici = to_soc_camera_host(icd->parent); - __poll_t res = EPOLLERR; + __poll_t res = -EPOLLERR; if (icd->streamer != file) - return EPOLLERR; + return -EPOLLERR; mutex_lock(&ici->host_lock); res = ici->ops->poll(file, pt); @@ -1267,7 +1267,7 @@ static int soc_camera_i2c_init(struct soc_camera_device *icd, } subdev = v4l2_i2c_new_subdev_board(&ici->v4l2_dev, adap, - shd->board_info, NULL); + shd->board_info, NULL); if (!subdev) { ret = -ENODEV; goto ei2cnd;