From patchwork Fri Sep 1 03:53:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Orson Zhai X-Patchwork-Id: 111462 Delivered-To: patch@linaro.org Received: by 10.140.95.112 with SMTP id h103csp472230qge; Thu, 31 Aug 2017 20:59:39 -0700 (PDT) X-Google-Smtp-Source: ADKCNb6d6wzpSjZBd431NmblsyhltBwBREAWEZiNGgHPTh7bmGQTvhG6gVf3Cv5DNGMqhOqK/5Gv X-Received: by 10.84.133.111 with SMTP id 102mr838284plf.112.1504238379311; Thu, 31 Aug 2017 20:59:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504238379; cv=none; d=google.com; s=arc-20160816; b=IXXmp47jPDmboem+jQIqTGdEHgsBjRy9CLVM7wtpKzdhNCj4SFQDYegKQe6OJYivTn zrpDw62nuXfdF0ZE0dIsVzFRlWHSnDidF4iDybu9yRdzztUr8FP5BbQsph4Hr32MqNUI SE3+ADIlF8a0pz6Nrh6sDkAN9arCD7wKb5rRc8fZtmYaInasucP6ziZ6tj++ypwbSRPS mOaAEyQ8wu8Gql/jGDu1npj6R5/WJxiAcDMzRpW8si4EU4t7yyLebELK7xrd+GZpI6ah 5K7Axp9TWlC6uMEgzsYYKHVQrvJ32Vch34/SHI9HrsDRSAw78PE39Jwj9Aj6oa+Oy4RN Rxsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=Mv+IbroZA4NjLhFgR/8sCKEyivxPaNxkhUM2Zma+KO4=; b=INPsBfSGS+f3e2oj/io4mmqWEzsA7ihiXJ8BlPBSptI+pd3qtXJ7zL26gi/qK5vPya X9K1sz5qGB9MvVKGvvQoEVQXfSqJhlbQMRuIWaamRDX13bRf9kW9mSKjUToHTnhxCYiH uTEWwPy+5sjjrKZHk3Gxc0rmHhweXQARJAA825jyJBRKu5iEVmBYQXG9Kwqwte9/stNw PUpOFPiX02kcTF4pqiQcgnbDIXyac6fwRewGS+R5WeCxKWU2wOJwdZEL+vxUW73ruaTL XtUJvJAj2HcqMfDnWOTnPXOz3p8GuMkWNNi+0wguhMt8Yx+aoCZP26Qql6iKVBOCNBaZ JoYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2si1069711pgs.702.2017.08.31.20.59.38; Thu, 31 Aug 2017 20:59:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbdIAD7g (ORCPT + 7 others); Thu, 31 Aug 2017 23:59:36 -0400 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:55238 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750762AbdIAD7e (ORCPT ); Thu, 31 Aug 2017 23:59:34 -0400 Received: from ig2.spreadtrum.com (shmbx03.spreadtrum.com [10.0.1.208]) by SHSQR01.spreadtrum.com with ESMTP id v813wtZD009771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 Sep 2017 11:58:55 +0800 (CST) (envelope-from Orson.Zhai@spreadtrum.com) Received: from SHCAS02.spreadtrum.com (10.0.1.202) by SHMBX03.spreadtrum.com (10.0.1.208) with Microsoft SMTP Server (TLS) id 15.0.847.32; Fri, 1 Sep 2017 11:58:57 +0800 Received: from localhost (10.0.73.143) by SHCAS02.spreadtrum.com (10.0.1.250) with Microsoft SMTP Server (TLS) id 15.0.847.32 via Frontend Transport; Fri, 1 Sep 2017 11:58:56 +0800 From: Orson Zhai To: "David S . Miller" , Shuah Khan CC: , , , Orson Zhai Subject: [RFC] tools: selftests: psock_tpacket: skip un-supported tpacket_v3 test Date: Fri, 1 Sep 2017 11:53:45 +0800 Message-ID: <20170901035345.15512-1-orson.zhai@linaro.org> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 X-MAIL: SHSQR01.spreadtrum.com v813wtZD009771 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The TPACKET_V3 test of PACKET_TX_RING will fail with kernel version lower than v4.11. Supported code of tx ring was add with commit id <7f953ab2ba46: af_packet: TX_RING support for TPACKET_V3> at Jan. 3 of 2017. So skip this item test instead of reporting failing for old kernels. Signed-off-by: Orson Zhai --- tools/testing/selftests/net/psock_tpacket.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) -- 2.12.2 diff --git a/tools/testing/selftests/net/psock_tpacket.c b/tools/testing/selftests/net/psock_tpacket.c index 7f6cd9fdacf3..f0cfc18c3726 100644 --- a/tools/testing/selftests/net/psock_tpacket.c +++ b/tools/testing/selftests/net/psock_tpacket.c @@ -57,6 +57,7 @@ #include #include #include +#include #include "psock_lib.h" @@ -676,7 +677,7 @@ static void __v3_fill(struct ring *ring, unsigned int blocks, int type) ring->flen = ring->req3.tp_block_size; } -static void setup_ring(int sock, struct ring *ring, int version, int type) +static int setup_ring(int sock, struct ring *ring, int version, int type) { int ret = 0; unsigned int blocks = 256; @@ -703,7 +704,11 @@ static void setup_ring(int sock, struct ring *ring, int version, int type) if (ret == -1) { perror("setsockopt"); - exit(1); + if (errno == EINVAL) { + printf("[SKIP] This type seems un-supported in current kernel, skipped.\n"); + return -1; + } else + exit(1); } ring->rd_len = ring->rd_num * sizeof(*ring->rd); @@ -715,6 +720,7 @@ static void setup_ring(int sock, struct ring *ring, int version, int type) total_packets = 0; total_bytes = 0; + return 0; } static void mmap_ring(int sock, struct ring *ring) @@ -830,7 +836,12 @@ static int test_tpacket(int version, int type) sock = pfsocket(version); memset(&ring, 0, sizeof(ring)); - setup_ring(sock, &ring, version, type); + if(setup_ring(sock, &ring, version, type)) { + /* skip test when error of invalid argument */ + close(sock); + return 0; + } + mmap_ring(sock, &ring); bind_ring(sock, &ring); walk_ring(sock, &ring);