From patchwork Fri Sep 1 08:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 111466 Delivered-To: patch@linaro.org Received: by 10.140.95.112 with SMTP id h103csp697883qge; Fri, 1 Sep 2017 01:01:58 -0700 (PDT) X-Google-Smtp-Source: ADKCNb7V9fxBaRNiYE+W2Co/g2hrYDWLFQ3WgPphYelsx+S9xuThFlYXcEfaBl87iBB9iKteEYcH X-Received: by 10.200.49.114 with SMTP id h47mr1559404qtb.148.1504252918285; Fri, 01 Sep 2017 01:01:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504252918; cv=none; d=google.com; s=arc-20160816; b=PqRC5Vri9q6wP85WTWPNvbRvE3EKwu+rawXLKPfvTx0GAjpomhzdOXMSJRvk90fjHq 5+Qq5h+u8vqNCTUoPKPQZj8CQi7ze7O7lhieX4acock5Ky8e8Uq8O9Jb7dsvMvdCY/jY G9i4rlcIVP5NzW1OdFLmLUkO7olvDEAZoqJ8T9jYZHQb2GufERVdpQnXQtz9ccBrs+2B lszZGRdXUAjCV9ZiZZXMkYJlTOTAvi38+zXAXR3Vu2Zy8sB7LiGYXxTV2QcIpGEk9ea2 7g+/xSWqhrIyNMV5KkcF7vdV7PHiMSF0yyzuDSbyWy/cZzSq8k2aI+7jT2RREVHbLr7s KdEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=HomlpSpMe1u9Fwe6XpB8U0hRdxWQiVjktSFct7baMIo=; b=ydPPUuJfVHXrGSnmuh68sM27shG3K0rdZ2SkO//zjKnrR00Vl6VNjXesPAYRY8e2WJ 6j64q7H0YMuuINwX65Ewx1xIXbtMERR4uNgQjow3qgcdf9Ki2+eiBO7EmcN10towuSK8 mCMCfoZ+UyS/kSkjFStnOecyCABlfFfRimOKVXmOome85e6s6O6XQcpKAERfXzDp2mHo 7injwilir1cYvhYF/k2UZ90dAogTF5MubS2fd0NigwKhhjuun1qjUPFIgR6V0/jC/k0k 2GLdk9uG11ABTAQQ5HMN3Irh8U6pdPwUX9gnT/2nurlRKqKZjFImoIU7qTu/33rhMSlV YOew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id k2si1870303qtc.335.2017.09.01.01.01.58; Fri, 01 Sep 2017 01:01:58 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 0143E644C1; Fri, 1 Sep 2017 08:01:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id B7ADF644E2; Fri, 1 Sep 2017 08:01:00 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id A1834644E5; Fri, 1 Sep 2017 08:00:51 +0000 (UTC) Received: from forward3o.cmail.yandex.net (forward3o.cmail.yandex.net [37.9.109.247]) by lists.linaro.org (Postfix) with ESMTPS id 919D4644E5 for ; Fri, 1 Sep 2017 08:00:20 +0000 (UTC) Received: from smtp2o.mail.yandex.net (smtp2o.mail.yandex.net [37.140.190.27]) by forward3o.cmail.yandex.net (Yandex) with ESMTP id 439A421184 for ; Fri, 1 Sep 2017 11:00:18 +0300 (MSK) Received: from smtp2o.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp2o.mail.yandex.net (Yandex) with ESMTP id B9E9C50811F9 for ; Fri, 1 Sep 2017 11:00:13 +0300 (MSK) Received: by smtp2o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id sQ2LA8I5bh-0BTCVSna; Fri, 01 Sep 2017 11:00:12 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Fri, 1 Sep 2017 11:00:06 +0300 Message-Id: <1504252806-2866-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1504252806-2866-1-git-send-email-odpbot@yandex.ru> References: <1504252806-2866-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 157 Subject: [lng-odp] [PATCH v5 1/1] odp-generator: Use clock related functions less when printing X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Ilias Apalodimas Using odp_time_local() on each iteration consumes too much cpu for no reason. Netmap pktio reported a boost from ~550kpps to ~1.2Mpps when odp_generator was used as a receiver on 1Gbit links. Signed-off-by: Ilias Apalodimas --- /** Email created from pull request 157 (apalos:gen_cpu_fix) ** https://github.com/Linaro/odp/pull/157 ** Patch: https://github.com/Linaro/odp/pull/157.patch ** Base sha: 7508c5ac906bb7cb1d339b4c5e924f3a18e504ca ** Merge commit sha: 0b6276ab40a57f154131a3815f95b7fb2ff59e76 **/ example/generator/odp_generator.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index f3ec43be..bcd329b4 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -765,11 +765,12 @@ static int gen_recv_thread(void *arg) */ static void print_global_stats(int num_workers) { - odp_time_t cur, wait, next; + odp_time_t cur, wait, next, left; uint64_t pkts_snd = 0, pkts_snd_prev = 0; uint64_t pps_snd = 0, maximum_pps_snd = 0; uint64_t pkts_rcv = 0, pkts_rcv_prev = 0; uint64_t pps_rcv = 0, maximum_pps_rcv = 0; + uint64_t stall; int verbose_interval = 20; odp_thrmask_t thrd_mask; @@ -786,8 +787,14 @@ static void print_global_stats(int num_workers) } cur = odp_time_local(); - if (odp_time_cmp(next, cur) > 0) + if (odp_time_cmp(next, cur) > 0) { + left = odp_time_diff(next, cur); + stall = odp_time_to_ns(left); + stall = (stall / ODP_TIME_SEC_IN_NS) + 1; + stall &= 0xFFFFFFFF; + sleep((unsigned int)stall); continue; + } next = odp_time_sum(cur, wait); switch (args->appl.mode) {