From patchwork Mon Apr 6 07:30:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: karthik poduval X-Patchwork-Id: 210288 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CEBC2BA1B for ; Mon, 6 Apr 2020 07:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1DCD20672 for ; Mon, 6 Apr 2020 07:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ruz5H+af" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726543AbgDFHai (ORCPT ); Mon, 6 Apr 2020 03:30:38 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:36895 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbgDFHai (ORCPT ); Mon, 6 Apr 2020 03:30:38 -0400 Received: by mail-pj1-f66.google.com with SMTP id k3so6087143pjj.2 for ; Mon, 06 Apr 2020 00:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pG/RazX9Sl3A3pCDkZw0apl899O9yG3jRB1KPgFB0T4=; b=ruz5H+afm8ZmWj28zZzEW6ZicA4AcWTHwW2wYMWiCxzQ6w6IOQ/h9AbgOWVzZx1yZQ ikRIavLY1bMu7LDvI8xuk6SKvimQjCQ8qv2GB1EP32YUZAXWFNpzBjMZ2k3SKjqZDbSK GJ4sZobxTK/Y3qSJrzeTgTx/6nC7ab4yVMQAnzd0rUBorANJ7NSP95JSPvj5i2BpCKCd JwjkzKABK0ecm2hJ87d7/WL6Oc3xSJZUNPoihF9vMt0Hjpsg/SbWmFMPGkU+RwxBYufx b1ZQDKHfNclgy3CmCq4YQCCDbhS84ghJcFOftOg6Qw86R0dsPMHSeyewnRQ4x19BWs2K vftw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pG/RazX9Sl3A3pCDkZw0apl899O9yG3jRB1KPgFB0T4=; b=TzpFvGunIdnnQsipIkx6j+T8TdRV5Y78HURyg61nCwPTwEHWCGe/G3Fiv5EEzDcnTZ /MAAeEvevbgMl8aY4vRJ/+EWVDla8kyGWnQrYh/6pPsrp8MVEIFVfPLg+8XBqwrGR+e7 KMrEgQSdK+h1KFZqnVJFxsM+o8CK/7Tw1TukyFqqr1rVejrBj/n1nBQ4sTjOykMWknhB h2qZeYJN+bmK4/i7d4BTcvpkp0JW18AVQ6H+46mj9ltCCcXGM2dccIiJhzP9Jlrc8bh6 dhlWN7oS6uv+nnGmidSzKnXsPZr/E2r7yto06WmWToTO2l/Mm+tv+s5+dfNsTDVFBbge N9hg== X-Gm-Message-State: AGi0PuZTrVVqqyydddP9eB8AHDNtPs6iDZAElBiZkKwpwSrDO2SIoZrZ RIO6soyToniLfLBoShqOINn0NbyU X-Google-Smtp-Source: APiQypJb0rBTogkwmlQLRYglLBp5zKJCM27uYYuFoqCaFY/qIljDYVqcVnYaHRrKDSDtWKPdRo14EA== X-Received: by 2002:a17:902:107:: with SMTP id 7mr18639285plb.302.1586158236696; Mon, 06 Apr 2020 00:30:36 -0700 (PDT) Received: from localhost.localdomain (c-24-4-174-82.hsd1.ca.comcast.net. [24.4.174.82]) by smtp.googlemail.com with ESMTPSA id z6sm10170179pgg.39.2020.04.06.00.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 00:30:36 -0700 (PDT) From: Karthik Poduval To: linux-media@vger.kernel.org Cc: Karthik Poduval Subject: [PATCH v2 2/3] media: staging: rkisp1: add rk3288 support Date: Mon, 6 Apr 2020 00:30:16 -0700 Message-Id: <20200406073017.19462-3-karthik.poduval@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200406073017.19462-1-karthik.poduval@gmail.com> References: <20200406073017.19462-1-karthik.poduval@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Add rk3288 support to the rkisp1 driver. tested on tinkerbaord with ov5647 using command cam -c 1 -C -F cap Reported-by: Karthik Poduval Signed-off-by: Karthik Poduval --- .../bindings/media/rockchip-isp1.yaml | 1 + drivers/staging/media/rkisp1/rkisp1-dev.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml index af246b71eac6..4c31294cf14b 100644 --- a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml +++ b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml @@ -16,6 +16,7 @@ description: | properties: compatible: const: rockchip,rk3399-cif-isp + const: rockchip,rk3288-rkisp1 reg: maxItems: 1 diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c index b1b3c058e957..1df4f5906fd0 100644 --- a/drivers/staging/media/rkisp1/rkisp1-dev.c +++ b/drivers/staging/media/rkisp1/rkisp1-dev.c @@ -403,6 +403,20 @@ static irqreturn_t rkisp1_isr(int irq, void *ctx) return IRQ_HANDLED; } + +static const char * const rk3288_isp_clks[] = { + "clk_isp", + "aclk_isp", + "hclk_isp", + "pclk_isp_in", + "sclk_isp_jpe", +}; + +static const struct rkisp1_match_data rk3288_isp_clk_data = { + .clks = rk3288_isp_clks, + .size = ARRAY_SIZE(rk3288_isp_clks), +}; + static const char * const rk3399_isp_clks[] = { "clk_isp", "aclk_isp", @@ -417,6 +431,10 @@ static const struct rkisp1_match_data rk3399_isp_clk_data = { }; static const struct of_device_id rkisp1_of_match[] = { + { + .compatible = "rockchip,rk3288-rkisp1", + .data = &rk3288_isp_clk_data, + }, { .compatible = "rockchip,rk3399-cif-isp", .data = &rk3399_isp_clk_data, From patchwork Mon Apr 6 07:30:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: karthik poduval X-Patchwork-Id: 210287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711F9C2BA18 for ; Mon, 6 Apr 2020 07:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48F2720672 for ; Mon, 6 Apr 2020 07:30:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SflXx+0e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbgDFHak (ORCPT ); Mon, 6 Apr 2020 03:30:40 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:41389 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbgDFHak (ORCPT ); Mon, 6 Apr 2020 03:30:40 -0400 Received: by mail-pl1-f196.google.com with SMTP id d24so5570728pll.8 for ; Mon, 06 Apr 2020 00:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eeV64KF8EzeWB1sPtni4tsOc6wcRgaWFJWWM75CERRA=; b=SflXx+0ef+78xdPDfBXkYFU0A/3xMKDBIi/+bX6AWMjPlEXQTreB3Hadce34ZQOcqy oo2wGWvKF/8IpeS6ahumzedWi2HPQuVK7w9w2ereAbvVj+gFkfLGtFuKT1TpML3DocwD NPjGwMyofTaBKM6zFoyI8Qi/H9T+XdUv+nIGe0MRJfKbbpSEPt1DeJBtdoSyAKYv3mWe x4vSRPQ5FebKCEYBHQewBNG4/AQQYdjWa9hzZxTAxvwCpU4IyKqz/sCm847letb6hJoM e4dQ+NrCYTY2IRaq+9q3Oq2zTjSbuzrG0C2dE3i/0sFz3GozxzR4CqyB+jxgUUUJsdyi lQfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eeV64KF8EzeWB1sPtni4tsOc6wcRgaWFJWWM75CERRA=; b=DhIbam5DMvZL6C6OpQsOAyuLesyeL5JeiKatIjVBMK3U9/h1/EtYirGw2wJe741F4j q7Fq72aeKNXJnaCE3tqSWFZ7k4+vsLZ2+JC5RUGbpmNqtb/cIsRDgeul+Tp34zq1Hrqr mQh70FmPB7fQexShtROC0ZINPkU8fgHbls7qDpScemp0gjuxPXn0n3MnEb7tJqTWS9mz W04PFiZK86/Nxh49VK2Ao2i0gsCh2GypdvEolC6+CsMUoIJndkE+0RkQkIf8/2v+EnTd /etVJtt7LE79K99+tEmRO5bDR09HSslZsoMKL+nmtAZoxkkoZTh5w22lb3TsJlHgbbr1 OMjg== X-Gm-Message-State: AGi0PuZ96vtGLb8y++owpCoF7chBd0eKIylcSX1P59C/r4kX9FjyiFsv eh5oBnON5cD93s+flRjtCWhtH6Na X-Google-Smtp-Source: APiQypIg4r88Ug9/WLRkPWolJVDWVc/22Qd8de1E0AHaGSbTfqLjEz+W12AJNkY38HrNyfgohHn1Aw== X-Received: by 2002:a17:90a:b395:: with SMTP id e21mr25541123pjr.33.1586158237600; Mon, 06 Apr 2020 00:30:37 -0700 (PDT) Received: from localhost.localdomain (c-24-4-174-82.hsd1.ca.comcast.net. [24.4.174.82]) by smtp.googlemail.com with ESMTPSA id z6sm10170179pgg.39.2020.04.06.00.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 00:30:37 -0700 (PDT) From: Karthik Poduval To: linux-media@vger.kernel.org Cc: Karthik Poduval Subject: [PATCH v2 3/3] ARM: dts: rockchip: add rk3288 ISP and DPHY Date: Mon, 6 Apr 2020 00:30:17 -0700 Message-Id: <20200406073017.19462-4-karthik.poduval@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200406073017.19462-1-karthik.poduval@gmail.com> References: <20200406073017.19462-1-karthik.poduval@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org ISP and DPHY device entries missing so add them. tested on tinkerbaord with ov5647 using command cam -c 1 -C -F cap Reported-by: Karthik Poduval Signed-off-by: Karthik Poduval --- arch/arm/boot/dts/rk3288.dtsi | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 9beb662166aa..adea8189abd9 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -247,6 +247,23 @@ ports = <&vopl_out>, <&vopb_out>; }; + isp: isp@ff910000 { + compatible = "rockchip,rk3288-rkisp1"; + reg = <0x0 0xff910000 0x0 0x4000>; + interrupts = ; + clocks = <&cru SCLK_ISP>, <&cru ACLK_ISP>, + <&cru HCLK_ISP>, <&cru PCLK_ISP_IN>, + <&cru SCLK_ISP_JPE>; + clock-names = "clk_isp", "aclk_isp", + "hclk_isp", "pclk_isp_in", + "sclk_isp_jpe"; + assigned-clocks = <&cru SCLK_ISP>, <&cru SCLK_ISP_JPE>; + assigned-clock-rates = <400000000>, <400000000>; + power-domains = <&power RK3288_PD_VIO>; + iommus = <&isp_mmu>; + status = "disabled"; + }; + sdmmc: mmc@ff0c0000 { compatible = "rockchip,rk3288-dw-mshc"; max-frequency = <150000000>; @@ -891,6 +908,14 @@ status = "disabled"; }; + mipi_phy_rx0: mipi-phy-rx0 { + compatible = "rockchip,rk3288-mipi-dphy-rx0"; + clocks = <&cru SCLK_MIPIDSI_24M>, <&cru PCLK_MIPI_CSI>; + clock-names = "dphy-ref", "pclk"; + #phy-cells = <0>; + status = "disabled"; + }; + io_domains: io-domains { compatible = "rockchip,rk3288-io-voltage-domain"; status = "disabled";