From patchwork Tue Sep 5 07:49:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 111631 Delivered-To: patch@linaro.org Received: by 10.140.94.166 with SMTP id g35csp2501796qge; Tue, 5 Sep 2017 00:50:15 -0700 (PDT) X-Google-Smtp-Source: ADKCNb7nDwHDZtTCG50+udJwXlGirxg4yPtzUqW2BObu/t0HPLFlRednDLiISdPKMTxIRyGA6MI1 X-Received: by 10.98.110.131 with SMTP id j125mr2879907pfc.298.1504597815234; Tue, 05 Sep 2017 00:50:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504597815; cv=none; d=google.com; s=arc-20160816; b=fg/ATQokmjV8dGVW4wzCT+bYj9kaiz1dKrIWx0MwbujNjdlct6qQSetUqc41u4kss8 tLe6ZYuaf01+OJ8H2BRgNDGhz4x8YtiCp7XVwLxGOaH489cInFwix5TAi6xXxCUxZ3u9 W+IB7gDYR6vUdkb+0p3b/o1lMM54xH4MsJ3AyZ5K5lnlodcU2xFahDzWhKg3KL0KC73k dLVvbay0Y2opUDaTOsd0MBO7qehuP0650yQPzzPHL2+ceL7nGOVcXlrixcom6mAv/WI3 6Z9urNoFaHtCWVtySjM3KOmo+Zx9q8bVTxLLGXj2nlZ2PeOKePH9dPOZZXzewCCKXlm3 5JKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=IkDkIRc3BN2FVYnNjEEsLj0gUeQThRR0srydT4WEcqQ=; b=ONWXuw8ndiy0WaVApECxFMZ85E/muAUQCT+oDilAPns/RxaEYK73Lxk1YrTBnHjmUN EkPacDxUZa40Nwml3C/iaYFO+jJC0ub72YbpuHJNaWVzNbjZ6aqsJrk04nf8mEAeyBqK wBR30pmuGUTmkXKAKVkO15IGJI8y0Vk9us/sOFTIllsheQCvtCfs16Pl7InhBs7y/UO3 eicJmxRms+ppZTXlJEC6gK7ZgQi10aQ1jB9X8MVKAjh/VumNKA9tYTPV/n8fnYbK/Tsd dDqJUiSVKzl7l8ZgQlwj+v5Q1VY/MfCuTSbHM+2tbnxzPF+VyxRdV9Me9tMzjFUb50hV XPNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m65si92666pfk.120.2017.09.05.00.50.15; Tue, 05 Sep 2017 00:50:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750954AbdIEHuN (ORCPT + 1 other); Tue, 5 Sep 2017 03:50:13 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58400 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbdIEHuL (ORCPT ); Tue, 5 Sep 2017 03:50:11 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0LnX10-1dGc5T3rvK-00haez; Tue, 05 Sep 2017 09:49:58 +0200 From: Arnd Bergmann To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Christoph Hellwig , Johannes Thumshirn , Arnd Bergmann , Hannes Reinicke , Finn Thain , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB Date: Tue, 5 Sep 2017 09:49:23 +0200 Message-Id: <20170905074956.469733-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Hlj0W3wBG0PspeS/G5Gzjp4/1KtFwy5cVyzrOU1dU4GPiSam3Vk ig1lPJShSa4qQnzQZDCn71t02/ecgXcOcARnqL9o5fn0phdAB1/Z5mcdlhw8QHcVuj4qqUt Er5AI7kR2q1xx4XbqCSlIb1ETz3C7ijA5oyBw3un5DbDreXUbk/jAcWB/C3wp4DYdQmq08v +XbdYojUQuxmQbt3CmXrQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:QzBs8W0QEh0=:QiN6YTDkpHOZfM8ucgfo4l 1Lv0JtuqalHmAsp2S4ReoYktg85MXe0N/8jewmir/Q1x7lZRVYJE+Wm83OVDr2iK40I8WCkQQ gffkI3IEJNyfv5hGFwq2wneiZ7+T/6Yl37YX+V/Ie88XRfhLtChp8LKb6NwDosMx5c3qVm22A altOvTbGDmxdcvDQF3afCCoO41FFRtBRrOTgvPM+5+igynBjo8nRxVOmDJtqia+0J6MMDjbxD WcGkA4uJ0Vcu2tJm6fnLaPUjusOHWijHKIy6ghO/TKGTM13DYfp842yM9l/EpAyw7sScqTkyW 1Xvj2pn6bnF7TL/RyK1MSHvLDVSbdbXS3NZ1sy3NXYEQdSpvMyPJ/q7QL+r1hwUQmmlSCVp4W Jdes0Y8aSKso3VFKn19wTT6syBTHCzVevX0hVCEXP6Dwa4dv7vyNSqRzMjxIa5v8kb4Wn5RsQ BTRR/GpQ8QhZ8XozRsZjxQ3HCDp0hYl1XfCPsZDPXiKrqzjAb78w2sDMl+egA7bcUapybIlAu KYi0Yg4Cmnc09WY57pmJ3zo3cG06oK4hLnBMIebHDQTj8hn7cby+snzwW2vkDMwlwjJihJp1r gguYyqD9HYghQPPN98ob9FbfaUatBbjXn+ZE7gQjtA0DKxn4rwlcm6Q5w+Kr3WkiqfiaT8rtl yJe9Jfp8BcruSsvqX7f8VJhzCuDK4mX3mMzXLCgmR2lYZYgdNy7vesLk6ZdtdPsmqe+tPWUMo 4WHM7KCsQ4KRamS7dUIMNa27mCCnjAII3nv02w== Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Without CONFIG_BLK_DEV_BSGLIB, we get a link error here: drivers/scsi/scsi_transport_sas.o: In function `sas_bsg_initialize': scsi_transport_sas.c:(.text+0xcc0): undefined reference to `bsg_setup_queue' scsi_transport_sas.c:(.text+0xd10): undefined reference to `bsg_setup_queue' drivers/scsi/scsi_transport_sas.o: In function `sas_smp_dispatch': scsi_transport_sas.c:(.text+0xe8c): undefined reference to `bsg_job_done' This modifies the Kconfig 'select' statement accordingly, and matching what we do for the other two scsi_transport implementations that use bsglib. Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough") Signed-off-by: Arnd Bergmann --- drivers/scsi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Reviewed-by: Christoph Hellwig diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index d145e0d90227..41366339b950 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -283,7 +283,7 @@ config SCSI_ISCSI_ATTRS config SCSI_SAS_ATTRS tristate "SAS Transport Attributes" depends on SCSI - select BLK_DEV_BSG + select BLK_DEV_BSGLIB help If you wish to export transport-specific information about each attached SAS device to sysfs, say Y.