From patchwork Thu Sep 7 18:17:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 111954 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp516689ybm; Thu, 7 Sep 2017 11:18:41 -0700 (PDT) X-Received: by 10.98.155.76 with SMTP id r73mr257812pfd.182.1504808321490; Thu, 07 Sep 2017 11:18:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504808321; cv=none; d=google.com; s=arc-20160816; b=voQrj/i53pCNivh4fz1TgtMJB3OWP2BnglbiAarDvj700QqFLxhMFuc34J4MIuPK8V A3CVLUc7xnxkkSnLphW0uO3INBXOpEstab8SB0EOjCTs1sjy3yXvll9QaUxUCWVFRZqq p0IrzZru7I9bovhZIpmH2qtfcOKJVzHofKmJ/CYhrHk9inqk3GjxLuA3/V4yN/SSoqb8 zNoED6IqZRYUejPvVwO6NSjk8COOXSZ+LLkWTSLilrsawUUT4zg51G9yybaSJkgTaotr me1qD2QP3u/KfEwgV2yUDesaYXHSRxD6a8jXwD461tyl2mOphItaNe8gtwV3uSg6SaW+ RM9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=ZGYLCJaKpz5uauuJZrW/GXglE7nbKzFKnNB9pJd4AwU=; b=rZ/sH/RnmGlqKm9AVt4sOit3G+WETS5bl6UBTk5UxdBMEF3yMQmAQnJpGeRNCFC+Kk W/mQOi2vVjTvFZN1DG6Lw4meJdC/Jw51xoCv4Oz3Ql3Iazu/vjlFiToB/xE8MDPsvyaH /IlbNsCZoPS8ahCvLZwVPvWi5WKpzEqZAwMcUnm6CmVFPcp+NoZrioMSEp1JQePNtQfx PMn16xaDqzZjXUzLhD9P25ohvIR2AprWL4wNmQ1XKa/doNM/sMCYhNMi2UxAREx7Omtp ujDKygAhGnY5RRyhqv/77Qty0NVKg1vgn+pU+rczdTzatHe9E7kJ/K7NqJE/lrxXrLGb KhJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PKl1DnTl; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 67si185451pfz.38.2017.09.07.11.18.40; Thu, 07 Sep 2017 11:18:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PKl1DnTl; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbdIGSSj (ORCPT + 12 others); Thu, 7 Sep 2017 14:18:39 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35560 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdIGSSj (ORCPT ); Thu, 7 Sep 2017 14:18:39 -0400 Received: by mail-wm0-f52.google.com with SMTP id f199so3678010wme.0 for ; Thu, 07 Sep 2017 11:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=ZGYLCJaKpz5uauuJZrW/GXglE7nbKzFKnNB9pJd4AwU=; b=PKl1DnTloykUo4NWsbPQkbyVZf+rdH7vC1mwEJHIKdXHWvy9/DIHNAjRN0SjW9JdHG ls48xzMJ0Pc4iYqS30mFUs59BITn18UHfVBiCDdG1c6v8LxryGt7BfQcRwQcHiZkBAiu Bei5rmNT5YeO8GfYHEE0gFKHgZABmyGkeO+cs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZGYLCJaKpz5uauuJZrW/GXglE7nbKzFKnNB9pJd4AwU=; b=PXlcDVoPM/MqNsPEPmPUAxq85sUrhVlYxXX1gJO+DlRM3GNckjFEvlVVMH9azov9Y1 ZIwGWtZ9qZdcPzPBYxaTdFCSFhTC6lpexFxDtXobVRd7A0acQvPLEgG8z3WtFGl4JTxe 34QdboashPywIBB3pQ65eAVIx6fmNm4vblVJJq1SY+Fc336mp77EAq0YnhDqKaIOb2N+ o5fPKY3IITvGjY7JqPP0/PcZb3BS+n+Csp9AkKxCT8maA2B3Tt8Zw7YDeHsfda7/FFw8 10jDcEwg9nHIKofUhvPyGBD9r2hz0/AVt8FUy1rPwtqsgKycgLrbg44HnRalXJMoFG8W a8Eg== X-Gm-Message-State: AHPjjUgbmLiwC/M7htP6uON/tRalqOrbEx4oxxo629EkEEtHyTePcfi1 Iw93eSsKSKxmWuVL X-Google-Smtp-Source: AOwi7QD7E3GyFdzDYYgzdc3P/VMjZPZl8sr1QxMWcKeOOlBrya6F+9I/0lOVq+nBpVv/8i6bXSxamQ== X-Received: by 10.28.217.73 with SMTP id q70mr119323wmg.9.1504808317784; Thu, 07 Sep 2017 11:18:37 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:fd1f:127c:840a:f61e]) by smtp.gmail.com with ESMTPSA id w204sm215133wmd.13.2017.09.07.11.18.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Sep 2017 11:18:37 -0700 (PDT) From: Daniel Lezcano To: edubezval@gmail.com, ldewangan@nvidia.com Cc: linux-pm@vger.kernel.org, Zhang Rui , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] thermal/drivers/generic-iio-adc: Switch tz request to devm version Date: Thu, 7 Sep 2017 20:17:10 +0200 Message-Id: <1504808230-12288-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Everything mentionned here: https://lkml.org/lkml/2016/4/20/850 This driver was added before the devm_iio_channel_get() function version was merged. The sensor should be released before the iio channel, thus we had to use the non-devm version of thermal_zone_of_sensor_register(). Now the devm_iio_channel_get() is available, do the corresponding change in this driver. [Compiled tested only] Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal-generic-adc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) -- 2.7.4 diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c index 73f55d6..71d0365 100644 --- a/drivers/thermal/thermal-generic-adc.c +++ b/drivers/thermal/thermal-generic-adc.c @@ -126,28 +126,23 @@ static int gadc_thermal_probe(struct platform_device *pdev) gti->dev = &pdev->dev; platform_set_drvdata(pdev, gti); - gti->channel = iio_channel_get(&pdev->dev, "sensor-channel"); + gti->channel = devm_iio_channel_get(&pdev->dev, "sensor-channel"); if (IS_ERR(gti->channel)) { ret = PTR_ERR(gti->channel); dev_err(&pdev->dev, "IIO channel not found: %d\n", ret); return ret; } - gti->tz_dev = thermal_zone_of_sensor_register(&pdev->dev, 0, - gti, &gadc_thermal_ops); + gti->tz_dev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, gti, + &gadc_thermal_ops); if (IS_ERR(gti->tz_dev)) { ret = PTR_ERR(gti->tz_dev); dev_err(&pdev->dev, "Thermal zone sensor register failed: %d\n", ret); - goto sensor_fail; + return ret; } return 0; - -sensor_fail: - iio_channel_release(gti->channel); - - return ret; } static int gadc_thermal_remove(struct platform_device *pdev)