From patchwork Mon Sep 11 13:01:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112180 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5759109pji; Mon, 11 Sep 2017 06:01:58 -0700 (PDT) X-Google-Smtp-Source: ADKCNb4OlLPqtie/97zXPM79YFFJUcOpV9FQ/nWEUVxTGiyuiomwHEP7h10fgwU3TZmApLS/+uJF X-Received: by 10.84.136.1 with SMTP id 1mr4039697plk.101.1505134918253; Mon, 11 Sep 2017 06:01:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505134918; cv=none; d=google.com; s=arc-20160816; b=o9h87yXajVW7EgMt/KtQSLfx6izeDrTeBgGgfU6WeOnCb6OWh1ttuzTHweAX/I52ds pi0WcJBHxnIlQZTsUo6ZcA/TLQ1ywH28jLXx7Tn5XldncomBUWr36seC9G8bmeXwb3Ju WwFbpmwdfO9yJ494pmtGOQQnof3EstH+xduUez8iCyFeEDOYA4JbpJ6GUdB9X1KutDX1 FG2lT/PHpoR9p5FGvuf+kihYNVzue4BtGOx5TvHj8QO5LqB3J3ANUsWejhaM0B0+z7c1 86kM0Ke3XkrN9RISuYb/1y9E6nAkz2QdB8REWrQdO8TWwgWxc4nT0rOgO7ZE+EiUxDgc FnHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=n6pNd+oIaZZaEWsO4aUqOErHPYJTdB8dzajXRk2tQwk=; b=kYdBb3htBHpuG484IaXOMXp3JV3pDuNrGXTAFTMHCoZddov85GHCoe7bh6IoMYwIQe vunTCW5VjhvL7q0sU0xgB65fGD9LUvIJBx8liIRw0X34v2m3Q7aaZQTKXlodMA3f3t2V PP9EhTfNGpqR9RGslkfq/YSpq0Rl95tf2dhHrcf6TzJO+0fdGExntoU3MlgBZxkk5BsA zEVM2jzey4JYAJxyfgq5tXoUWmnDiOdiZ2IxBRSFZ6iTuZRVKSTY2E5ClLviC2XnryQT L+S2kyyBU/7Y1UroUciCKiY+M/Sy2dC3RtLeTPZiUUDeRS68+dzVoUZLCF8W0VSP2+sy SPtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=RXrY9tH7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o71si2022174pfa.380.2017.09.11.06.01.57; Mon, 11 Sep 2017 06:01:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=RXrY9tH7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbdIKNBv (ORCPT + 26 others); Mon, 11 Sep 2017 09:01:51 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:42227 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbdIKNBt (ORCPT ); Mon, 11 Sep 2017 09:01:49 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4X001997; Mon, 11 Sep 2017 22:01:20 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4X001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134880; bh=n6pNd+oIaZZaEWsO4aUqOErHPYJTdB8dzajXRk2tQwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RXrY9tH7UWyRqekFrCa+r8ye8LCIGm7fqJwHjYMCd+1ch5AWqEwaJtVYUalJ5NcL2 mQQnmKEs5xv6jeII3AxABjwlig6vhwqwf4HUzucW0lEWgsRZ62NLI0HsoCUFqNwTBz 6jcz6qUO7oCSmNJD2MC8iooDY7J6/iFPN+vwNvPezYcH/Lr6eIZDmAmWs0DOT1Cd6w 4oQAArdApNR25U2uYhU5tLWgAx+ziy9OtOqi5UtLRUUR0Pt7gFpiWSwyrNbR9qMwbl 0gY1EUUhlIAtLTeuCUTdAYAyN56+EIRXTkVGGP6qd9Yq2bSsP6QHkHyU5vv6BXg/ei wmGECciPV9ugQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 1/5] nvmem: imx-iim: use stack for nvmem_config instead of malloc'ing it Date: Mon, 11 Sep 2017 22:01:00 +0900 Message-Id: <1505134864-11975-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org nvmem_register() copies all the members of nvmem_config to nvmem_device. So, nvmem_config is one-time use data during probing. There is no point to keep it until the driver detach. Using stack should be no problem because nvmem_config is pretty small. Signed-off-by: Masahiro Yamada --- drivers/nvmem/imx-iim.c | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/imx-iim.c b/drivers/nvmem/imx-iim.c index 52ff65e..a599260 100644 --- a/drivers/nvmem/imx-iim.c +++ b/drivers/nvmem/imx-iim.c @@ -34,7 +34,6 @@ struct imx_iim_drvdata { struct iim_priv { void __iomem *base; struct clk *clk; - struct nvmem_config nvmem; }; static int imx_iim_read(void *context, unsigned int offset, @@ -108,7 +107,7 @@ static int imx_iim_probe(struct platform_device *pdev) struct resource *res; struct iim_priv *iim; struct nvmem_device *nvmem; - struct nvmem_config *cfg; + struct nvmem_config cfg = {}; const struct imx_iim_drvdata *drvdata = NULL; iim = devm_kzalloc(dev, sizeof(*iim), GFP_KERNEL); @@ -130,19 +129,17 @@ static int imx_iim_probe(struct platform_device *pdev) if (IS_ERR(iim->clk)) return PTR_ERR(iim->clk); - cfg = &iim->nvmem; - - cfg->name = "imx-iim", - cfg->read_only = true, - cfg->word_size = 1, - cfg->stride = 1, - cfg->owner = THIS_MODULE, - cfg->reg_read = imx_iim_read, - cfg->dev = dev; - cfg->size = drvdata->nregs; - cfg->priv = iim; - - nvmem = nvmem_register(cfg); + cfg.name = "imx-iim", + cfg.read_only = true, + cfg.word_size = 1, + cfg.stride = 1, + cfg.owner = THIS_MODULE, + cfg.reg_read = imx_iim_read, + cfg.dev = dev; + cfg.size = drvdata->nregs; + cfg.priv = iim; + + nvmem = nvmem_register(&cfg); if (IS_ERR(nvmem)) return PTR_ERR(nvmem); From patchwork Mon Sep 11 13:01:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112182 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5760277pji; Mon, 11 Sep 2017 06:02:37 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5HUQQO+n0Jhg3AqLPZZaLGsDFzZdSQM8Sh/LxdZn4k+aUU91Oiz98LPB1THEmDJhcJqVh8 X-Received: by 10.159.218.7 with SMTP id v7mr14040507plp.322.1505134957317; Mon, 11 Sep 2017 06:02:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505134957; cv=none; d=google.com; s=arc-20160816; b=TJWk9/m5+VujbMZ3DpvY8Q9ibw47ylanZqvhmF9uETX48tjN5mY+y/zyjGgwZh8G0w GZ4pdnqsTNrgc5EmWZR6flCAsQWmFekuzqT1srm0cHnaCGzM+uo+zukj9z6IYydao0sE +cu+Pt72Uy5vCZmYzvLTg+PJy5Vpjb9Ph8B5PmsSIVDjthPXg59/9e0i4IMW7e4XNwc4 tCPJp0Jcv0c5v1ByZs2mp0wgXK7mcJhU5dtx5HvmK7HHwub8Cn6h5T/VLcbLNgMzVNu7 zwrZHhgfRL5s+rqLCLWK7YBptVLrWrxuJycbsdZxrWkKNI6pVdWRSUzUXlA4PTek/Ef4 Vx7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=X52ca2UoLyliDphAC/BBOhOi9nkkHyWNjTnaUBEjfuU=; b=C8+Qr6vGb4C7f3eJo5GznmectqYpD2WMFepiAfsBVClnrm4iAff8sr888+XKGyCcRk TTz7EiBYwjE+LGZ/U7X413o5L3zDXoPR5+2huozYEZCWfNPqP/GTWKEomnlzdmMxyZuK t+6mgtt3CUkGc5+cBSFKF6yslh+2QedxXcnUuvoOQS4hNIm3Lv3rOC/r/65K51cgfw4C AVQ/U00ZoW/L5FrJ3qEEWnrIZ3I0R8+IIkynIilZaxdMQGa4SwaMWc50+phuMI/7z1HJ n6wtdIaBSKnMnLTpXkxPU82XBQfqSESJycjS6ekQEC/kK92vTEz4IDosD9HO6Qc6ojzi zwbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=mg7IGa0z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si5904940pgc.459.2017.09.11.06.02.37; Mon, 11 Sep 2017 06:02:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=mg7IGa0z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbdIKNCf (ORCPT + 26 others); Mon, 11 Sep 2017 09:02:35 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:43565 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbdIKNCd (ORCPT ); Mon, 11 Sep 2017 09:02:33 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4Y001997; Mon, 11 Sep 2017 22:01:20 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4Y001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134881; bh=X52ca2UoLyliDphAC/BBOhOi9nkkHyWNjTnaUBEjfuU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mg7IGa0z0vyikbs77/pFU6hFd+4npdwN63QZ/luczRe+ZrcSyBpuqFfnG566SvjYs YHsW+828Fr0/kHK5c2yC0/fv6QTF747CYVp2ySmSuratQVbWAEmO+VdoZ/TTU62/CZ zoHAvttuSDhTvk7mCmuNkLq/W3C1oQJtfP6PzIXHCt0udhP8dXZ8Y8ecvZn2cVOjbO I/WfLB4Bk9KiwIr+Rlwm9nMfiSDHH0jWbpSzv2W8QzyPejuEEsBvorc9wlsSsCImU6 m5P1tSE3MGZ7naYrnWyvtCjQmENUOcy/gCA69kAeHY9eoHgvArAs1TxdzY5I2riDt3 bQ4xacP9Jy2fA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger Subject: [PATCH 2/5] nvmem: mtk-efuse: use stack for nvmem_config instead of malloc'ing it Date: Mon, 11 Sep 2017 22:01:01 +0900 Message-Id: <1505134864-11975-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org nvmem_register() copies all the members of nvmem_config to nvmem_device. So, nvmem_config is one-time use data during probing. There is no point to keep it until the driver detach. Using stack should be no problem because nvmem_config is pretty small. Signed-off-by: Masahiro Yamada --- drivers/nvmem/mtk-efuse.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) -- 2.7.4 Acked-by: Sean Wang diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index 32fd572..fa7a0f6 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -49,7 +49,7 @@ static int mtk_efuse_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct resource *res; struct nvmem_device *nvmem; - struct nvmem_config *econfig; + struct nvmem_config econfig = {}; void __iomem *base; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -57,19 +57,15 @@ static int mtk_efuse_probe(struct platform_device *pdev) if (IS_ERR(base)) return PTR_ERR(base); - econfig = devm_kzalloc(dev, sizeof(*econfig), GFP_KERNEL); - if (!econfig) - return -ENOMEM; - - econfig->stride = 4; - econfig->word_size = 4; - econfig->reg_read = mtk_reg_read; - econfig->reg_write = mtk_reg_write; - econfig->size = resource_size(res); - econfig->priv = base; - econfig->dev = dev; - econfig->owner = THIS_MODULE; - nvmem = nvmem_register(econfig); + econfig.stride = 4; + econfig.word_size = 4; + econfig.reg_read = mtk_reg_read; + econfig.reg_write = mtk_reg_write; + econfig.size = resource_size(res); + econfig.priv = base; + econfig.dev = dev; + econfig.owner = THIS_MODULE; + nvmem = nvmem_register(&econfig); if (IS_ERR(nvmem)) return PTR_ERR(nvmem); From patchwork Mon Sep 11 13:01:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112183 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5760468pji; Mon, 11 Sep 2017 06:02:43 -0700 (PDT) X-Google-Smtp-Source: ADKCNb4TtbYX0I8y5J334Mg74GnJO0vfMQmasvVaJ1UHA0jdJYK1swOpAulye7cn15/FNWnWNkMr X-Received: by 10.99.95.204 with SMTP id t195mr11776919pgb.135.1505134963431; Mon, 11 Sep 2017 06:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505134963; cv=none; d=google.com; s=arc-20160816; b=tBrOMvun4hHUts9UDJbsF9Keb94phpVfD//RtH3sTewv7u40J1HD7YpU5UblPHqNO7 3hq0ylSRVys7PGg2XUZJql6IyVhsWNoDc08k+siWXzs5TwtsuXlC/w00zi8EIX6IlYdb a6tDjaQMWXuBIfhs5Mu+eJ6bfmN7/yah5LFKiwhsWjR5RJ8RfnbWVhGYCbeI9aJAkY18 5Xm146aZpUImX9hUAW+RIOX9FpX7qShWw6loL3wqppdB0Rd8Nnj4RxPfLLxa9N/sqkck +Tn/x9mTh8eXoPRvg+zH5f0PqFVuabpGwMIDkCgzrlnuL+rPKS0zw0ZAlYjJ+90pkfl3 s7UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=XjJuoI8DZefJ4kMqn3Ylw8/xrv/j5RPGnE5deRFs0EY=; b=ciDzNPGdjRfumBZA6p9Qdd5m3zyhu625fta51j2MPC9ZysFH3O0zJBGBshC8rkGzMJ PX/CrozTOCjqu5a8P1wNyG2ba/XgmlT4J6qxHtEr8PezV0pate8NNwLPsnBGNAP2FMeu Zd2a+mLhX4UMOOhv/jczpyfbI1eCouROGVLUi2fXumf6tqA4scMy6MmdammZ8yFSgGso eP3jUHd+cVg9G1RTxmZfVUNOFhijWwmMCetE0VChrAIZjPpuVCY65IBtUhjbCpUSlAEl YVevZpHlrW82/UqOeA1Goo5dipbQUzr4tOUnBf7nXIs8AHeofcfsjaz+TBY8m5d/iBdu ds0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ptXHsyUO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si5920772pgr.677.2017.09.11.06.02.42; Mon, 11 Sep 2017 06:02:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=ptXHsyUO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbdIKNCk (ORCPT + 26 others); Mon, 11 Sep 2017 09:02:40 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:43684 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbdIKNCi (ORCPT ); Mon, 11 Sep 2017 09:02:38 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4Z001997; Mon, 11 Sep 2017 22:01:21 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4Z001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134882; bh=XjJuoI8DZefJ4kMqn3Ylw8/xrv/j5RPGnE5deRFs0EY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ptXHsyUOvCXpghicxzYlJRRNlk2YkpGL3I43Ps1Z6GqpNpZQC6+msgWm23loJY9aK uCNkO/g15byAL7wVVI4nKwityag4Vy8y55UK0SwScx4Fm/PPuVjGvA0AmN8LeWYBeA FfU/2Apv1g96kwmBlLJEUvgXCop30NLuZIc1qLn5ZAspkpRquu3By8eTbbHNI/4KOF I1atUnA70E0VuLj5/jqmOVbo7kUjrJdo9G0mtTWLVgcCuE+ipbTMeEFSUO7iRTUocr vTvK5hcJsinHZ5e7W/eb7GnzljI7TGCtS5OccbAF9F/1Po8vrL/rPPxD3M3NdnplUx xogDULPccIzew== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger Subject: [PATCH 3/5] nvmem: mtk-efuse: fix different address space warnings of sparse Date: Mon, 11 Sep 2017 22:01:02 +0900 Message-Id: <1505134864-11975-4-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warnings: drivers/nvmem/mtk-efuse.c:24:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/mtk-efuse.c:24:30: expected void [noderef] *base drivers/nvmem/mtk-efuse.c:24:30: got void *context drivers/nvmem/mtk-efuse.c:37:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/mtk-efuse.c:37:30: expected void [noderef] *base drivers/nvmem/mtk-efuse.c:37:30: got void *context drivers/nvmem/mtk-efuse.c:69:23: warning: incorrect type in assignment (different address spaces) drivers/nvmem/mtk-efuse.c:69:23: expected void *priv drivers/nvmem/mtk-efuse.c:69:23: got void [noderef] *[assigned] base The type of nvmem_config->priv is (void *), so sparse complains about assignment of the base address with (void __iomem *) type. Even if we cast it out, sparse still warns: warning: cast removes address space of expression Of course, we can shut up the sparse by marking __force, but a more correct way is to put the base address into driver private data. Signed-off-by: Masahiro Yamada --- drivers/nvmem/mtk-efuse.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.7.4 Acked-by: Sean Wang diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index fa7a0f6..c4058b5 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -18,15 +18,19 @@ #include #include +struct mtk_efuse_priv { + void __iomem *base; +}; + static int mtk_reg_read(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct mtk_efuse_priv *priv = context; u32 *val = _val; int i = 0, words = bytes / 4; while (words--) - *val++ = readl(base + reg + (i++ * 4)); + *val++ = readl(priv->base + reg + (i++ * 4)); return 0; } @@ -34,12 +38,12 @@ static int mtk_reg_read(void *context, static int mtk_reg_write(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct mtk_efuse_priv *priv = context; u32 *val = _val; int i = 0, words = bytes / 4; while (words--) - writel(*val++, base + reg + (i++ * 4)); + writel(*val++, priv->base + reg + (i++ * 4)); return 0; } @@ -50,19 +54,23 @@ static int mtk_efuse_probe(struct platform_device *pdev) struct resource *res; struct nvmem_device *nvmem; struct nvmem_config econfig = {}; - void __iomem *base; + struct mtk_efuse_priv *priv; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) - return PTR_ERR(base); + priv->base = devm_ioremap_resource(dev, res); + if (IS_ERR(priv->base)) + return PTR_ERR(priv->base); econfig.stride = 4; econfig.word_size = 4; econfig.reg_read = mtk_reg_read; econfig.reg_write = mtk_reg_write; econfig.size = resource_size(res); - econfig.priv = base; + econfig.priv = priv; econfig.dev = dev; econfig.owner = THIS_MODULE; nvmem = nvmem_register(&econfig); From patchwork Mon Sep 11 13:01:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112181 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5759420pji; Mon, 11 Sep 2017 06:02:07 -0700 (PDT) X-Google-Smtp-Source: ADKCNb6FBgOTO99TLWdqwe6ZHqlR2SkButpfeGsImTeV+5SFt3TkuJzXIxt8rl8Psg3n0/Z961QE X-Received: by 10.84.209.197 with SMTP id y63mr13575229plh.436.1505134927667; Mon, 11 Sep 2017 06:02:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505134927; cv=none; d=google.com; s=arc-20160816; b=sBJ89KL328TsmO9SblpmMw34Op5JVMU03BfLj7Wnp0porH+iU3HkVeUFlsojTVL6S0 xnMN9XyHK8viqehWzHa0ktsn2MOI+ctqf0lMWNPPl1Lm2uekkaUXnCTSK/SJfr2S5ZUI jvjTEHXUfKcYkFKlaNlfZnrbAJZZLlQoMlX6+lnCJBu7fTkoHxJN8AcqXp/jULbNN2qi +NNPs6fNXfoCOOxfbueM6GwPNOUcJwQRgjidc5HenQc3X//990KQfv1PKJB/PYrHXXQm R09ytpGiTdlhrgV1ReQvWKuZNwUcr01SwmKQYjTWszNJiEYweLj3QaulBn9yc3qhk/wH EnWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=KKy942Lk7jTu/OdoX6JFhp2dbbuBTrKU82hCXG7jjkU=; b=CzLjRg51iHJR0r0Hy0PynrdHi1kJj8HNwLauV6AuApZylsoD3Pra8TdgziuAuV/Ijc JmqqdMPGHfXq0lgV6jckt863jLwM5TX7R5HlBYXpBU3VroUSOYbdUnTfhASN849+m0+D VweMsWrbJvnx3CpK/Y4FW3TTRPCxDtLXzLw8IwyQIhjJA6PuUYVGvS+BWeM134Je7JXf G5V6gDm70dXeKwkMhqQ3pkiiIytfhWJRxhVGc9PXrNn3mOhmKlB031JGdiQ0ICqwQi7H 6Sy8bJIyKJ5x77KhzGY73XUXZTptrSbh01+kytmyhNcKDCsMqtwnsFW7/4h6Im1CIRw2 /kzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=F/La4MBf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si5904940pgc.459.2017.09.11.06.02.07; Mon, 11 Sep 2017 06:02:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=F/La4MBf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbdIKNBu (ORCPT + 26 others); Mon, 11 Sep 2017 09:01:50 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:42228 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbdIKNBt (ORCPT ); Mon, 11 Sep 2017 09:01:49 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4a001997; Mon, 11 Sep 2017 22:01:22 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4a001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134882; bh=KKy942Lk7jTu/OdoX6JFhp2dbbuBTrKU82hCXG7jjkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F/La4MBfFmFJVfMJX+lT3WQFRn7MjalmWPiBd9O9lEqRaCtYVO5jXPT1l8psGlCo8 VMbv1dt3FQFcWRyxt2iWFNSgiuJoXRr9DzcFDh9NbnN8/4n3r/yLs+EfruBbKuYwR8 q0b2CsJe5H1bhyUDjoG6vTiBoCLX0axLMzXY5HwQuz5ZV0r5j68qal14x+2djn39dk 3kXn4Mc02bdjmSQm+AU4Y7YHHDnU0xyqs2ZSRWlFrNvo2W3yh1ROynQCnHX3l6er7L /B1xz61Q5qHJe/mGzrFCXBEDFeA0sisCbRALGR6W21P8uPeJeTOOAcnsAHjC4/B/24 Q4KN/GtZRtXqQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] nvmem: qfprom: fix different address space warnings of sparse Date: Mon, 11 Sep 2017 22:01:03 +0900 Message-Id: <1505134864-11975-5-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warnings: drivers/nvmem/qfprom.c:23:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/qfprom.c:23:30: expected void [noderef] *base drivers/nvmem/qfprom.c:23:30: got void *context drivers/nvmem/qfprom.c:36:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/qfprom.c:36:30: expected void [noderef] *base drivers/nvmem/qfprom.c:36:30: got void *context drivers/nvmem/qfprom.c:76:22: warning: incorrect type in assignment (different address spaces) drivers/nvmem/qfprom.c:76:22: expected void *static [toplevel] [assigned] priv drivers/nvmem/qfprom.c:76:22: got void [noderef] *[assigned] base The type of nvmem_config->priv is (void *), so sparse complains about assignment of the base address with (void __iomem *) type. Even if we cast it out, sparse still warns: warning: cast removes address space of expression Of course, we can shut up the sparse by marking __force, but a more correct way is to put the base address into driver private data. Signed-off-by: Masahiro Yamada --- drivers/nvmem/qfprom.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index 2bdb6c3..b96730e 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -17,15 +17,19 @@ #include #include +struct qfprom_priv { + void __iomem *base; +}; + static int qfprom_reg_read(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct qfprom_priv *priv = context; u8 *val = _val; int i = 0, words = bytes; while (words--) - *val++ = readb(base + reg + i++); + *val++ = readb(priv->base + reg + i++); return 0; } @@ -33,12 +37,12 @@ static int qfprom_reg_read(void *context, static int qfprom_reg_write(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct qfprom_priv *priv = context; u8 *val = _val; int i = 0, words = bytes; while (words--) - writeb(*val++, base + reg + i++); + writeb(*val++, priv->base + reg + i++); return 0; } @@ -64,16 +68,20 @@ static int qfprom_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct resource *res; struct nvmem_device *nvmem; - void __iomem *base; + struct qfprom_priv *priv; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) - return PTR_ERR(base); + priv->base = devm_ioremap_resource(dev, res); + if (IS_ERR(priv->base)) + return PTR_ERR(priv->base); econfig.size = resource_size(res); econfig.dev = dev; - econfig.priv = base; + econfig.priv = priv; nvmem = nvmem_register(&econfig); if (IS_ERR(nvmem)) From patchwork Mon Sep 11 13:01:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 112184 Delivered-To: patch@linaro.org Received: by 10.100.153.131 with SMTP id 3csp5762940pji; Mon, 11 Sep 2017 06:04:03 -0700 (PDT) X-Google-Smtp-Source: ADKCNb72lMrzRMXmxvrDuc/6zVyDnq6Ub1KSq2H8cFspSx6mExr5uMSNu+ABuDiZ0mflr4hcwHhK X-Received: by 10.84.210.163 with SMTP id a32mr2817311pli.365.1505135043399; Mon, 11 Sep 2017 06:04:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505135043; cv=none; d=google.com; s=arc-20160816; b=ScV4lk26tW5Vu36cGqgevF0lljDfXIaxs4hLGHZ9bTJoenF3xHjBaJHllkKHR8YzCW MJsHDi4JAnxUvpjOmCRmkiUotMNs+jaFTHNywEM3YznwtP0yQUiQM8d2mXB9Ym2kF88/ yCTkXj8F/AT6XMAHFxKXvtkIoZ4+BFH5LB5FLs9RP+Qgfmbdk8PmwFdQFLQyOQ9nH350 KvVWf5551kZxT7U3pynQBSEJ21FAwuzGATiSui2Sh/RwWxercWtWmcVT3E+7ljh2Un69 yvmeBv8OzDVBBOIzBpdk+YQL/QGAEDvfjb3kwkuyV1Iuz4UTB0VasvcGSnzBAzfkAyyy FNxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=kzkeXSzb+VAswXkF2EB6z1m+WSYSrD22fw98Ap/Oh4s=; b=A0BSrtZcd1j2VqC9DKNiNQrS6IvXPL7ttNY8FWZ1aC1I4V6DbdgZH18Ci6DO1Tahlj leeIdFZICCCPBqAKbjvsqSqzs0wrMBl3DX5GJcu7TF8UV2cL1PWdgvuJAH1161ERcPYL YAB2e7bpPKPmxoZmnEwXUDqkrZHFPdmsKfxGujyBGWz5WAVJi2L3di3DltJllJHq1JuS kgVof93ot7If6lL6wZidY+r6KuteXsWjQ72XKWj72jv5ZmSRDNhOxVnqFOH5Gw8VbaCX 2hnnUVqpy6SISLEfVEwQ23MiXumU3TVsifroW1IY9eqO6xU8z9spg98yijbLns9Rvuxj ZU7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=yGWo2q6q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si6838284plm.360.2017.09.11.06.04.02; Mon, 11 Sep 2017 06:04:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=yGWo2q6q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbdIKND7 (ORCPT + 26 others); Mon, 11 Sep 2017 09:03:59 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:45848 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdIKND5 (ORCPT ); Mon, 11 Sep 2017 09:03:57 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id v8BD1I4b001997; Mon, 11 Sep 2017 22:01:23 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8BD1I4b001997 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1505134884; bh=kzkeXSzb+VAswXkF2EB6z1m+WSYSrD22fw98Ap/Oh4s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yGWo2q6qR5th8iDvfcgeWNs3b37c66tdeflkimGm43AktXU7xUE7maq/44UDuB7Fs vAvLqy6OZ/U1ZTlOJKvpvq3RkYxBtJDfJsyaDEDFTKQETvWT4sJ2xZ7Wv4Gv/2Aqb3 O4OZsbXYO3aqME24sJ26uVgCCMed98Dfwo44TAZAnzgpxJTuvHELcUrpL3C5PHA9Y2 ULgEQP28Yn0IQ02NMfYzbGTI/s/XQup6XmrIwG8X4uQlGQuZXWgQ3kxDnsaH+98IE0 LVapvGYj1uSAAgRstIMmHRwKvDAirlIcr0k7URdJsTgG9J8jOF8wmbNsWcw/w2W4LG cwVU3DbNrV1Lg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Keiji Hayashibara , Masami Hiramatsu , Jassi Brar , Masahiro Yamada , linux-arm-kernel@lists.infradead.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Kevin Hilman , linux-rockchip@lists.infradead.org, Joachim Eastwood , linux-mediatek@lists.infradead.org, Carlo Caione , linux-amlogic@lists.infradead.org, Chen-Yu Tsai , Maxime Ripard , Matthias Brugger Subject: [PATCH 5/5] nvmem: set nvmem->owner to nvmem->dev->driver->owner if unset Date: Mon, 11 Sep 2017 22:01:04 +0900 Message-Id: <1505134864-11975-6-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> References: <1505134864-11975-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All nvmem drivers are supposed to set the owner field of struct nvmem_config, but this matches nvmem->dev->driver->owner. As far as I see in drivers/nvmem/ directory, all the drivers are the case. So, make nvmem_register() set the nvmem's owner to the associated driver's owner unless nvmem_config sets otherwise. Remove .owner settings in the drivers that are now redundant. Signed-off-by: Masahiro Yamada --- drivers/nvmem/bcm-ocotp.c | 1 - drivers/nvmem/core.c | 2 ++ drivers/nvmem/imx-iim.c | 1 - drivers/nvmem/imx-ocotp.c | 1 - drivers/nvmem/lpc18xx_eeprom.c | 1 - drivers/nvmem/lpc18xx_otp.c | 1 - drivers/nvmem/meson-efuse.c | 1 - drivers/nvmem/mtk-efuse.c | 1 - drivers/nvmem/mxs-ocotp.c | 1 - drivers/nvmem/qfprom.c | 1 - drivers/nvmem/rockchip-efuse.c | 1 - drivers/nvmem/sunxi_sid.c | 1 - drivers/nvmem/vf610-ocotp.c | 1 - 13 files changed, 2 insertions(+), 12 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/bcm-ocotp.c b/drivers/nvmem/bcm-ocotp.c index 3c56e3b..5e9e324 100644 --- a/drivers/nvmem/bcm-ocotp.c +++ b/drivers/nvmem/bcm-ocotp.c @@ -232,7 +232,6 @@ static struct nvmem_config bcm_otpc_nvmem_config = { .read_only = false, .word_size = 4, .stride = 4, - .owner = THIS_MODULE, .reg_read = bcm_otpc_read, .reg_write = bcm_otpc_write, }; diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 2ba5589..0d5e893 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -462,6 +462,8 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->id = rval; nvmem->owner = config->owner; + if (!nvmem->owner && config->dev->driver) + nvmem->owner = config->dev->driver->owner; nvmem->stride = config->stride; nvmem->word_size = config->word_size; nvmem->size = config->size; diff --git a/drivers/nvmem/imx-iim.c b/drivers/nvmem/imx-iim.c index a599260..52cfe91d 100644 --- a/drivers/nvmem/imx-iim.c +++ b/drivers/nvmem/imx-iim.c @@ -133,7 +133,6 @@ static int imx_iim_probe(struct platform_device *pdev) cfg.read_only = true, cfg.word_size = 1, cfg.stride = 1, - cfg.owner = THIS_MODULE, cfg.reg_read = imx_iim_read, cfg.dev = dev; cfg.size = drvdata->nregs; diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index 193ca8f..e57e2a5 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -303,7 +303,6 @@ static struct nvmem_config imx_ocotp_nvmem_config = { .read_only = false, .word_size = 4, .stride = 4, - .owner = THIS_MODULE, .reg_read = imx_ocotp_read, .reg_write = imx_ocotp_write, }; diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c index 6c7e2c4..b1af966 100644 --- a/drivers/nvmem/lpc18xx_eeprom.c +++ b/drivers/nvmem/lpc18xx_eeprom.c @@ -159,7 +159,6 @@ static struct nvmem_config lpc18xx_nvmem_config = { .word_size = 4, .reg_read = lpc18xx_eeprom_read, .reg_write = lpc18xx_eeprom_gather_write, - .owner = THIS_MODULE, }; static int lpc18xx_eeprom_probe(struct platform_device *pdev) diff --git a/drivers/nvmem/lpc18xx_otp.c b/drivers/nvmem/lpc18xx_otp.c index be8d074..95268db 100644 --- a/drivers/nvmem/lpc18xx_otp.c +++ b/drivers/nvmem/lpc18xx_otp.c @@ -64,7 +64,6 @@ static struct nvmem_config lpc18xx_otp_nvmem_config = { .read_only = true, .word_size = LPC18XX_OTP_WORD_SIZE, .stride = LPC18XX_OTP_WORD_SIZE, - .owner = THIS_MODULE, .reg_read = lpc18xx_otp_read, }; diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c index 70bfc98..dbedfce 100644 --- a/drivers/nvmem/meson-efuse.c +++ b/drivers/nvmem/meson-efuse.c @@ -37,7 +37,6 @@ static int meson_efuse_read(void *context, unsigned int offset, static struct nvmem_config econfig = { .name = "meson-efuse", - .owner = THIS_MODULE, .stride = 1, .word_size = 1, .read_only = true, diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index c4058b5..9ee3479 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -72,7 +72,6 @@ static int mtk_efuse_probe(struct platform_device *pdev) econfig.size = resource_size(res); econfig.priv = priv; econfig.dev = dev; - econfig.owner = THIS_MODULE; nvmem = nvmem_register(&econfig); if (IS_ERR(nvmem)) return PTR_ERR(nvmem); diff --git a/drivers/nvmem/mxs-ocotp.c b/drivers/nvmem/mxs-ocotp.c index d26dd03..7018e2e 100644 --- a/drivers/nvmem/mxs-ocotp.c +++ b/drivers/nvmem/mxs-ocotp.c @@ -118,7 +118,6 @@ static struct nvmem_config ocotp_config = { .name = "mxs-ocotp", .stride = 16, .word_size = 4, - .owner = THIS_MODULE, .reg_read = mxs_ocotp_read, }; diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index b96730e..cb3b48b 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -56,7 +56,6 @@ static int qfprom_remove(struct platform_device *pdev) static struct nvmem_config econfig = { .name = "qfprom", - .owner = THIS_MODULE, .stride = 1, .word_size = 1, .reg_read = qfprom_reg_read, diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c index 63e3eb5..e292bbe 100644 --- a/drivers/nvmem/rockchip-efuse.c +++ b/drivers/nvmem/rockchip-efuse.c @@ -149,7 +149,6 @@ static int rockchip_rk3399_efuse_read(void *context, unsigned int offset, static struct nvmem_config econfig = { .name = "rockchip-efuse", - .owner = THIS_MODULE, .stride = 1, .word_size = 1, .read_only = true, diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c index 0d6648b..1c3b5cf 100644 --- a/drivers/nvmem/sunxi_sid.c +++ b/drivers/nvmem/sunxi_sid.c @@ -40,7 +40,6 @@ static struct nvmem_config econfig = { .read_only = true, .stride = 4, .word_size = 1, - .owner = THIS_MODULE, }; struct sunxi_sid_cfg { diff --git a/drivers/nvmem/vf610-ocotp.c b/drivers/nvmem/vf610-ocotp.c index 72e4faa..5ae9e00 100644 --- a/drivers/nvmem/vf610-ocotp.c +++ b/drivers/nvmem/vf610-ocotp.c @@ -206,7 +206,6 @@ static int vf610_ocotp_read(void *context, unsigned int offset, static struct nvmem_config ocotp_config = { .name = "ocotp", - .owner = THIS_MODULE, .stride = 4, .word_size = 4, .reg_read = vf610_ocotp_read,