From patchwork Mon Apr 27 13:40:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B9BC54FD0 for ; Mon, 27 Apr 2020 13:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F03D206B6 for ; Mon, 27 Apr 2020 13:43:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="lg3SeNf/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbgD0NlH (ORCPT ); Mon, 27 Apr 2020 09:41:07 -0400 Received: from mail-mw2nam12on2055.outbound.protection.outlook.com ([40.107.244.55]:9980 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727944AbgD0NlF (ORCPT ); Mon, 27 Apr 2020 09:41:05 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=duMt3DXje3M2rE+HihBK8AP9s+XUHe8pIxOdlqxx0HziSfqYleG64RmU52iv7hQ4g8veSipWJ40nm/1vKJnLKX6fuXrgVZeGXqP4b6ta/h6oFx7MoJSF8GiksUiMQ06Kea5FUsvu+yjSRNMU3UJeIJq8KGjMVLqZ8DS9sSlHS+v40xXHMsEObpkDOq2+f6XDidqWq9qu3o/ivGHrEgiBlR+tV+xGGt9qk3Xz4Re6i7GUZiYqZDrbuaJaN9ysaElT3q9YiaZFo2ZvBWk0ZAyO+3EwJMzG3I2RI2Ax295CoX1vOLxWrtAS5ox7uhGL7gBuF6dcUpDVkfh3VPbfKvDeWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wPGhlRhQV8LoVCtdI7RwpboNHZqL6bcToiGsJGCk/yk=; b=SCXq5+mIbLdIMknmOkj8i3Q6L1qo3MYxhaUmSaXvhQ2PjWr8O8jXhrKxVi1ZjhF8kELuKCHALkBbGugH5dbzBg6RolFJ0ZVOB3pLviJYv5Fkmfp12LLqVUA54wtVMYQaqxqhcGLIL8Xm4uAtheWiApJBLDun/mfIyruN/T2BMX5hqMXnGrRbu2Qhs/CTDESOv4gIyzn6ThdNVxsML/d86k+p2vaOq2bVHnmP3bd27Zlzm+gT6Fja7tsKl7WNbUgI20p+tz2WRQ9LdklZYKBhb1uv8r5iZZFG2MQlhIFFQFpYJNa7u4+8GnRljGSsd9276NrI87CrMR1/mYsgelfqMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wPGhlRhQV8LoVCtdI7RwpboNHZqL6bcToiGsJGCk/yk=; b=lg3SeNf/vysYQArUz9jmUmsK0oa4V33rgnJBCrp3QkvEO2Yk7XkcJSlTzPFU3oqZZCRH6sHH+btbUVlzv/CQn0YcOGqAZzWGsp+lxTkFOXmTcj7JZQuWIhu0U/g39GpUtXQilXm354nnjlW9NTCJWHpkrmTJJyvB9FmbggXtWqM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:03 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:02 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 02/17] staging: wfx: change the field chip_frozen into a boolean Date: Mon, 27 Apr 2020 15:40:16 +0200 Message-Id: <20200427134031.323403-3-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:00 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08be903d-4b18-450c-a142-08d7eab0a090 X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4326008)(81156014)(86362001)(8936002)(6486002)(52116002)(6666004)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(66574012)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L53ToBQjJvlKhpNQRoKP+1NhERmTbDHOSxbBT39ZoXgzo8u27hJMdXVPJoaYWXsVRNxiXmIEC/OOqfHB+q7a/zyvUP6Xa2rwID6m6PEwQ6EPzIGpH6wtX+Km0iLJvA0WBqj4SQw65jCobKM/S0L4bwGRQJq53STkBjSEDUf4Ln/zU8D9LtZPs72fdekqZQ78oeTB9zj/4xi7aC4eaP2N7XtdEHtyRGItct69xXATRljo+nW5ZOzFvhNT+HwSDE6PI76u+AbL43SJHiL5ior+gtzwzLBKvxATVczBeGpnsD6Fo6cVdp4mNQVN9beAMU6OvqfgeZM3dFKVCpGYk81urbr9p9Ll8o3zYgtpVqSM9UkarZX/YtPI/EoEpsD9xIgsrmRGoU2oJqKq73PxmzTIxB82YRCywelRuRILPk3hbDt9YHLH4vmuZIpiR5gSlRH/ X-MS-Exchange-AntiSpam-MessageData: prQW5TJgEOafXAx1bEG3Jv/j3LvpuWPZaC/u6jDwVFJOqxI6buRbIqmfHUGasZQBBOa5n3KlBfZTJ/d5t+tR+gOX+Z+CGxoc8kJ+VBA1i167IXHQXFdA4U+mCEgeDkKMw7P5I0YMzAa4A5JAHdDb05vSBcFcIfckwsxNsc2SMA+C2xrF1emx+9Av9NvOai3B6EUy+sW7rgU0ns9jT3KvqoX+TQUiGoMI2tAel41VISZac7Ju+SiIJqrWLGX1M17iCJ5IxTBGZa7ZaNFSpuyY3eZ0YaAXEEPGb30k5IcLCxVbgtZL0f6758Y17gDzJ1j6JqPTR4wbSTJnFfOM8r/vza6cWusfGAG+PqpjbLC+nUqV9FpuSiEzVqXEq86jL70gH/acpVDbiwELIbXyOOT+rqaT8xF+6KkNjlU4XtRtBu2Ni306uEZMOpihYJEjilYcuU0mVACfBU//5fvtnjEkWJq6fR0YZVTKOKXKJAD5cEDNNGi5iiG5BsATuqnO83Uk2gRIjv9I7TX7x1tDvTm3KOBEfy3QP6MCze0w2xyZoNVQ9H5HlGS4sARklalvNgGa9d2h2FM+kag5kKT1UsBC6PQGZhitFKQ3kDq3b8t1ckshq67e8Dv+B1couubOAXWnpRyFBFz2YB4/KhrRd7QmW/LqJaY/aJ3EXSoPZ7Vs9F2t482Wy1ZqW5I3VSjvssJlLyHnE4rncXEFB4IXwMch4AJOc2oKI4gWJ0sDkZ3RwNl5a/2ST8rX8qOk+Ehidl1np3oPyqNukZqiaARfwyXiDNHqe8K+KwmmhqVt2x+HRe1yIGw6OVODeRCdPlDrJcrKd6ilTkQDaORahq0QswlGiLoDUXeRpCVTOcPX+dnLgf4= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08be903d-4b18-450c-a142-08d7eab0a090 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:02.7210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YVQn3ZzTd9FhLgwE+w9KESby9ls8/l2ynWnASRqOnZsvdc8yrKK8quY+F6B5JH4pfYtg+FZ68jkaRjpapM2RPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The field chip_frozen is declared as an integer, but it is only used as a boolean. So, convert it into a boolean. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_rx.c | 2 +- drivers/staging/wfx/hif_tx.c | 2 +- drivers/staging/wfx/queue.c | 2 +- drivers/staging/wfx/wfx.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index b8d570256498..b56138fef0bb 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -316,7 +316,7 @@ static int hif_exception_indication(struct wfx_dev *wdev, dev_err(wdev->dev, "firmware exception\n"); print_hex_dump_bytes("Dump: ", DUMP_PREFIX_NONE, buf, len); - wdev->chip_frozen = 1; + wdev->chip_frozen = true; return -1; } diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 17721cf9e2a3..e8f3c5f9ce7b 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -91,7 +91,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request, void *reply, if (!ret) { dev_err(wdev->dev, "chip did not answer\n"); wfx_pending_dump_old_frames(wdev, 3000); - wdev->chip_frozen = 1; + wdev->chip_frozen = true; reinit_completion(&wdev->hif_cmd.done); ret = -ETIMEDOUT; } else { diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index 2f6f9faf15be..0c799cedd101 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -52,7 +52,7 @@ void wfx_tx_flush(struct wfx_dev *wdev) wdev->hif.tx_buffers_used); wfx_pending_dump_old_frames(wdev, 3000); // FIXME: drop pending frames here - wdev->chip_frozen = 1; + wdev->chip_frozen = true; } mutex_unlock(&wdev->hif_cmd.lock); wfx_tx_unlock(wdev); diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 706e95cd1092..77bb6c617546 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -45,7 +45,7 @@ struct wfx_dev { struct hif_ind_startup hw_caps; struct wfx_hif hif; struct sl_context sl; - int chip_frozen; + bool chip_frozen; struct mutex conf_mutex; struct wfx_hif_cmd hif_cmd; From patchwork Mon Apr 27 13:40:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215806 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4CCC54FD0 for ; Mon, 27 Apr 2020 13:43:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1B16206B6 for ; Mon, 27 Apr 2020 13:43:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="PtYagRck" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgD0NlM (ORCPT ); Mon, 27 Apr 2020 09:41:12 -0400 Received: from mail-mw2nam12on2086.outbound.protection.outlook.com ([40.107.244.86]:6127 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727992AbgD0NlL (ORCPT ); Mon, 27 Apr 2020 09:41:11 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AuLPTCJPT+pvTo2W3Qllvd/2i/Q+yLAU1GYPY2+Mc5ISiSn9dQCSKLGFQwYpCDdhLS2EXUCygragCDtAR1lBz+7rDxSOvfMtTZmIlQrVxAp8kkyAC/d23eKyCMCQFdqZytYccX7jx2FZX6wuu/PXnh2eRYftJotvSbFPLYjOZrPgYYnM12bEIhkOQUlGkyzAzXc18B1J1yV/kczecerxTXZXK4M1oMNXILKTZ3/lgE358rtFMre+J7w0LJspBIXHXwSkS5mgWT8j2p5T2DieEGOmtX/8L/ro5HSjzbyVVh36pmlFqn1yfdmqwXh4btqbsknw+PCmKGi/9dwnKGCm1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P4Z9XHMk2EIFcuuUeSbslGWvZpkT0RcgtGB0oJKFgr0=; b=NlL99G+ohndy3UsnU7yDVJBHDhRbcafjHZBJsLLJE6Cx8ZxLGfGWtm+XVCn50U0Rfx8GGAVijqcDttZxbyt4Cny6xkmC0M9VHl7j6y0B0fmqx1iw4ruULCPDqPBacPHDnxc2z8w3OMvORsSrHkIYnoC+NJleY0xfOI3CkxdkkyM2oTL3/4AHRat/B7gmb5a281TimvjX//ASlAvY52XjP8hXKXX7U+HZa9ZMOrjSBQrn7C6mjci5lb4bA98p0rUQbrY35DTPFKpcnY08985Itu9PPfwuu6vqLqOqz30hSAmTit0taILkKe3xQ8N5l5S5lDH1wQ2BfWHhwB4KTRQM2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P4Z9XHMk2EIFcuuUeSbslGWvZpkT0RcgtGB0oJKFgr0=; b=PtYagRck0n60073veLaoidcJxOzY9EtbiBg8FRjMSh+9IiPAvQ+E4Ae9g7dSwQQp/3lEmWPY+xT5vJqhtlJ4e9k5JzUT5tF+4l3/8FtfiDVzx/ptSWvJ3FaEaJIM4/gFtoY/mQrKLHap0FoDqHJB4ttuWXGhhJIVAXMDZGZs4AA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:08 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:08 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 04/17] staging: wfx: fix support for AP that do not support PS-Poll Date: Mon, 27 Apr 2020 15:40:18 +0200 Message-Id: <20200427134031.323403-5-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:06 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5619c46f-bbb2-4c49-21da-08d7eab0a3ef X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:800; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4326008)(81156014)(86362001)(8936002)(6486002)(52116002)(6666004)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(66574012)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fcEtMjYai7Rq7+dJ45dUF4QdCRG8QD1PBOodE//mBLCqc0bkH5UkTHI9JUhFBDFBqv+ebWi9aJ4JcNfv+NXVi390TAC+n9RdpC9yKhke+007YE6SDn7I01p+0TqfDg04Tpq0+v0Qgz/qIx2pVfwEgM9e1AxlyQXWdJo+icJr/Z7SV2kG+NQjAplmT6eWNzViAFQGHWpjjCDe98bBzOC+EW9pG+c7teBGoD0EfnWI2waZj/b0qrUJYTj7PFkpX/u68zHVPDjx5bG3kLAXNLB6VJeRvsPwpjughOyS7mJbzyqNT4pBbdbNv6m/MX4MbQzx31RlCr3ucS+rtMraoyG5UlNwCd5amYpXx0Nk6O/F/hgirELmfaBhdqovVelX+sS8HHYtlXpqIrywwMl7yFlqH8ufHgc1KEyg1505Qy8U47yik0WLRr/YYm1kA3mzSWOK X-MS-Exchange-AntiSpam-MessageData: xBrZGCj7CYMXoY49/QH+1DVO5CAG6zPu9DFeXUw2yh7THlJMLK3MeQ3B0MSyk8QgL/H9J9+/B62goWz5dWHqjheZcd5mPclQITlZ9MPry1l5hNadVFWqT+LtW17U9+LmieLNXC+xuVvMd0bKGtxY6IuOX4SbmEt354yXowjB1mOoCl1CW6UgdO6sz/DhF3l3vivwtr4nYmPpFFUPTxM1VEQNJq1lYTAFofMbcCARiLfGi+c/eun/aR+3Qas7oxXGm0y7H9IC6J40/iEeq17XLPeokRiC1HsktTmh74C4RAZkWC0+hygbo7//PJM4Aj8H0cGaeF2aaiqMNDpdtcIznUQDlTHfKjKkzQASN8PbyRsNJhwpXRfB4D3+tRWnjDv1Vg/JQJ0l9//sCCzljnz0BVhdKuSAxWQiBdszdimf9gZLB/vz/d1jpqLvBrB1uaqcDuVD/+HacqiAzdbte5FvWPskYFjAe3kdQ2ImS6Ld2g4DEu86sfnPoOtSwlZ/89RAlQVJ6BCfTYnCchq7gZ+7lASu4Eap5wS2stYRXtchZrn4yPe97ztrRs/lY3cMsSdrBK6A07DLD2ADlYW8QXBWCFWX4UThcSEla6+zUn1ZPbuLe0gWWnGOYav141pw11KUBTlt5UCtfMEvriJCTVLnv7KyMe1MkXCy3Lo4sI9S37mmlMRYdJhkVGPR29vZRLDqU/dTNJjZ90NgMiayp9Dycod1+G1XUJ9/Z4AbeXiKKMp0FGxKBYYknpQFSr4Y8Vw8PfswlICH9PSTtRyQ6lcG/Vzgpw8nFyFARoELrSRmcI39Kp9WCSbrmh4S/72pUmUfgQy12gZGatdov5JneBVTerRp08RQDUn4D/3u/5cOuhw= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5619c46f-bbb2-4c49-21da-08d7eab0a3ef X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:08.5734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uG9VmFYLpqLCr8aRi98Z0BTZ7fuVcTe+5mC6jYWDJIH8ZvQHEGn4ttnVb5gtZZQ6AzpJhZ3ZV6yEutavh5cdBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller When multiple virtual interfaces (on different channels) are in use, the device ask to activate Power Save on station interfaces. The device developers recommends to use legacy PS-Poll in this case since it is the mode that disturb the less the other interface. However, some AP start to not answer anymore to PS-Poll. The device is able to detect this case and return a special warning in this case. So, this commit catch the warning and force usage of FastPS in this case. In order to confuse the less possible the other interface a small FastPS period is used (30ms). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_rx.c | 8 +++++++- drivers/staging/wfx/sta.c | 16 +++++++++++++++- drivers/staging/wfx/wfx.h | 2 ++ 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index 6dbe289a368f..a2ac6c098163 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -176,7 +176,13 @@ static int hif_event_indication(struct wfx_dev *wdev, dev_dbg(wdev->dev, "ignore BSSREGAINED indication\n"); break; case HIF_EVENT_IND_PS_MODE_ERROR: - dev_warn(wdev->dev, "error while processing power save request\n"); + dev_warn(wdev->dev, "error while processing power save request: %d\n", + body->event_data.ps_mode_error); + if (body->event_data.ps_mode_error == + HIF_PS_ERROR_AP_NOT_RESP_TO_POLL) { + wvif->bss_not_support_ps_poll = true; + schedule_work(&wvif->update_pm_work); + } break; default: dev_warn(wdev->dev, "unhandled event indication: %.2x\n", diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 2262e1de37f6..77d5ff17a59a 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -205,7 +205,10 @@ static int wfx_update_pm(struct wfx_vif *wvif) if (chan0 && chan1 && chan0->hw_value != chan1->hw_value && wvif->vif->type != NL80211_IFTYPE_AP) { ps = true; - ps_timeout = 0; + if (wvif->bss_not_support_ps_poll) + ps_timeout = 30; + else + ps_timeout = 0; } if (!wait_for_completion_timeout(&wvif->set_pm_mode_complete, @@ -215,6 +218,14 @@ static int wfx_update_pm(struct wfx_vif *wvif) return hif_set_pm(wvif, ps, ps_timeout); } +static void wfx_update_pm_work(struct work_struct *work) +{ + struct wfx_vif *wvif = container_of(work, struct wfx_vif, + update_pm_work); + + wfx_update_pm(wvif); +} + int wfx_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, u16 queue, const struct ieee80211_tx_queue_params *params) { @@ -293,6 +304,7 @@ static void wfx_do_unjoin(struct wfx_vif *wvif) if (wvif_count(wvif->wdev) <= 1) hif_set_block_ack_policy(wvif, 0xFF, 0xFF); wfx_tx_unlock(wvif->wdev); + wvif->bss_not_support_ps_poll = false; cancel_delayed_work_sync(&wvif->beacon_loss_work); } @@ -453,6 +465,7 @@ void wfx_stop_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) wfx_tx_policy_init(wvif); if (wvif_count(wvif->wdev) <= 1) hif_set_block_ack_policy(wvif, 0xFF, 0xFF); + wvif->bss_not_support_ps_poll = false; } static void wfx_join_finalize(struct wfx_vif *wvif, @@ -737,6 +750,7 @@ int wfx_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) init_completion(&wvif->set_pm_mode_complete); complete(&wvif->set_pm_mode_complete); + INIT_WORK(&wvif->update_pm_work, wfx_update_pm_work); INIT_WORK(&wvif->tx_policy_upload_work, wfx_tx_policy_upload_work); mutex_init(&wvif->scan_lock); diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 77bb6c617546..c7a58ab3beaa 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -89,6 +89,8 @@ struct wfx_vif { bool scan_abort; struct ieee80211_scan_request *scan_req; + bool bss_not_support_ps_poll; + struct work_struct update_pm_work; struct completion set_pm_mode_complete; }; From patchwork Mon Apr 27 13:40:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215812 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CAEBC54FCB for ; Mon, 27 Apr 2020 13:41:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AD9D206B6 for ; Mon, 27 Apr 2020 13:41:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="ce5Ohdhf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728083AbgD0NlZ (ORCPT ); Mon, 27 Apr 2020 09:41:25 -0400 Received: from mail-mw2nam12on2085.outbound.protection.outlook.com ([40.107.244.85]:27104 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728039AbgD0NlW (ORCPT ); Mon, 27 Apr 2020 09:41:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WKEbyalUu3uCswzX3SyS9H9CwFiTZPf32suLvOvIm55iOvb69Q6KZa3BlIqstLtFgdpQjGMyBIcs1PjX0tJI1jjUcDiK05btlE0i4XnYy97sxwZAYQG9NfZf9glFcNBXA6q0VBSI8vOCz/kz6LUJOUetNwoo7+RudAYUCwEK1BTQrvk+1+xrPkXH+dfZzNesR37o/VPPEWA9SSkERb9+6Fqh7a0HgnedcfOtqn2ALnmwnolYSOiq8MxbIA1DBgqrYfMmMT44txuyrtz3s+j6Y3WXhX0l8khcL0fBlM4TTFHyc8TKpCRLW8DfG+6XIlV4+8iXrQv3YaILAqYD3JiXtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ArHefbqV21SB9u1u11bvJ2ldj7JfEtPQEMPuhZ4pQ5g=; b=I56hOfbq4TrBDzeUhsvWIxUabhqJo6wprRGXXV+UOcPMXRWyi/NqPRp1Rf0upKMxzhIIQ4Ncx+GXaJldmhHBtXQ7Y5xOcYpuYitG6k/l5WMU6PcM9JYvatDQJGU83B+FHfJVsOs/cbvOeCXyt8Aj+yHGX34Ui+s75d/ik2sVyJju3PsIydos0zndBzqQVIw1FOspauxNBXQkBj9VYFxOpJjs+4QivD/gI+bABg/5QLV4oVIyg0V8c2rxYzY+r476/hfZUEgs5ayHMjeR+Wn27m/q0rLGAwy9W/4A4kkYlj3f3P2Hlzr9y4pMnc6BKd1Hcm8wj2f2pAt38LdlBKCKrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ArHefbqV21SB9u1u11bvJ2ldj7JfEtPQEMPuhZ4pQ5g=; b=ce5Ohdhf7qaqf1df7or0N+cFDReMdZbOsXErFJQaaMi5U4URbiBrv0hIGhak8drqOYnNq+cQG2jK1E9GiVVKeaKA4bn+zGDE6vIJQqqnTegtV/ucMNRRTMdcLb+3mYFaOFLAe6dEtOQPXx1fuRnkNPwhrh+AzxioFT+bY6dWjqs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:20 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:20 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 08/17] staging: wfx: fix highest Rx value declared in ieee80211_supported_band Date: Mon, 27 Apr 2020 15:40:22 +0200 Message-Id: <20200427134031.323403-9-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:17 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3383b784-e967-481b-15d3-08d7eab0ab25 X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4744005)(4326008)(81156014)(86362001)(8936002)(6486002)(52116002)(6666004)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(66574012)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q/1XJupTjPYq0sCCH0R44mnao4/5sG1nGuuechHGjbPeLF4rNE50gMz4Zg8MXsPXweFj7e7pBDdbCfyL5RIUkgZBLI+4rhdDbY9+9ZYhvp0GxQ8SIOrleE+WSuhPFY+4zCiNQL5+47eS2mIN6bkvdkAwE7MuEY5i7TVTDm05LDErbaIEdtWfUwwH+QkiyRla1Yn7t2Pl24dAXFfti0Ba4LO4y56/hoMRExF39XWLd+o1AwBduejGR//Qd452I8Wzps64ZcTnQXypAmvhi6aF3Xo2H4xRv5JXflkPGt2OnLz9O8lwhNeH2AShTqDEs5iD9d9wI9349HovU/vU3isDLKYfGOwaEvylCdc6qF58A9of3gLQPbKBjhq1jcX36m+76ylAbiSCkGYVxDH0niKNnPR3CiQ61rWAdYv5KUiIzn2W4GNMWHpYEXQiyCuIyBhM X-MS-Exchange-AntiSpam-MessageData: hbqOdKH4fSxR0R8Csou9gs1K8E5bRbnHedGm+rB446MzJuuMtLt9Z7DRosxE83acHqouh14xl+oWej6OIU+NT3gqT9Pm9+m7dvqSJb51fMIvTADzVH5yDF/R9hqF3/GgeoocOMy+TCOTHz1pxyONckXLLe6cWEoBuPFtoCoF8Dj2pnxzbiNWbxH49vCG0L3J9jBL26MPTfkko1bBC+L1y6FBkPwLoJaR82Z8MIJjc5AOwkR1zkukN/j7DiJZhmMaNCc65LQNFVL+2QDHaF5TwEzVHDU1iQ1vGoqfsmjkoOjRpdIyP3hvi4KBl4ZOhbdbFi+FSrCUPcYusjQL+/EqnuHyHXx15FMkEKWM6hagYz51GR1AESNyKWrtqT9RZQqQuU/lIk+8aMR1RRSNqo9uNyG0R62u494wpvnYQUv+7hFqcqYlXzi/kB8QG5NNuHnVgLK1wIeHFL66Xt77r8ReQ34k0R6rR1fkSMCxxip+barbDxDGNtQeVeEIhKqQT4H7VEbHTPY+DoJcENt3rShvR/3eE1a5odlOzDn5MKZyMfJJesXPMGJ24QLsuHNuifM8DJ8f9lnKyP5zSPnVAEBp8vQ0fmL7HAYGUCG7IAVm6tLPcxBuuYIt8v6EMhNb5VE2KQlTfaj1cYyqoPrPj77tx7F4IfRk2XAbyLfxoK8cwBYSojnMAlyYLa1ng3LhC6fyRTGh5IC9Bfuf2YJIcWpoUrX5qavOcMACDUjFUCQdB8r4q6oT3QWWn3MG2L3yJE37nkKpkfvy6wI5HuyokoqGwnM0DTjRlaMlfXdpMjKM0ZHg0xOVJxjV2Fn7ZvfqjnJ8c/1tIkRzyPCHOsxHWpw8d+MysDeHrTWz7PVUFcyBYrU= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3383b784-e967-481b-15d3-08d7eab0ab25 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:20.6990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AZ/HkmTCTFLt27RL1TbCOaOKQpv+jsnkJSnveze61ptkiqn+gkRLiQyLwiu89goJUdF0GHbkkS6JzV2+cRsJ0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The highest Rx value declared in ieee80211_supported_band had two problems: 1. The value should be little endian 2. ShortGI was not taken into account. So value should be 72 instead of 65. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index 1093584373ad..742a286c9207 100644 --- a/drivers/staging/wfx/main.c +++ b/drivers/staging/wfx/main.c @@ -106,7 +106,7 @@ static const struct ieee80211_supported_band wfx_band_2ghz = { .ampdu_density = IEEE80211_HT_MPDU_DENSITY_NONE, .mcs = { .rx_mask = { 0xFF }, // MCS0 to MCS7 - .rx_highest = 65, + .rx_highest = cpu_to_le16(72), .tx_params = IEEE80211_HT_MCS_TX_DEFINED, }, }, From patchwork Mon Apr 27 13:40:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCDCCAB360 for ; Mon, 27 Apr 2020 13:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7D64206B6 for ; Mon, 27 Apr 2020 13:42:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="VB5ufhil" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728283AbgD0Nmn (ORCPT ); Mon, 27 Apr 2020 09:42:43 -0400 Received: from mail-mw2nam12on2085.outbound.protection.outlook.com ([40.107.244.85]:27104 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727977AbgD0NlZ (ORCPT ); Mon, 27 Apr 2020 09:41:25 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPNxTLltAoeN7+UdBsxPu9j9der0VUi/uuHLM0/85R2+V0+Zv2tNGTh2QuB4NGPrjFCfRCKWGD4t86LJjAmEjkWLGkfrCQ9vNq8wWmBqyouJXRHXB5M1oryIyghWAtkoDmFf7Q8LQD5OsZgA/yQKWHycWmxEsCx3ZMzwOQEB9x1jFhx88XvFl/pyGhrZ2cMD2NiTQ6jWdSDGkwCEpdT6z1dGbDK1gIKEtLpH56nzFjFiXIWmkxzqV3bAFhchX2DUWcdcLjqqVhNAD8I1jaWFaw6jwsdv3owMYyomrM4V71P5klBRwsO+0aQlLdbkQ7FcBg7yZDVJeTspAB4crVgT/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X6uDElDmF4BJeb2iUOBzvnX7akdRxQ+c+0g1HkzX/GM=; b=WWjusyBTQ866lZCem5CPf64XsZgzk3oqQz0reZ9YgXR47ckXNnDgcfrRz3teEVDVypufeaXtMSC+fHFxv29MzCb2oFJ68TMOBF+bwaiifiUAfHszxN5Bk3xhs8etNHThnALC84BR5nPPnOHlKrjAVyWe+InSqJAVN4SyAtH7DDOaVE9I/ciknYUBmNjbtAxwpiEqqL8kcwh3zlODSf2q+v1RS4pgLoKFxubT9WigeMsSXuPnBR6H1uRGGjRrKw+EIrPbMY3GpbVvQANlatNghE6TNxkj+X3p/5aQalwljDB11iNB+wfG2fA+GB87PBy0FkeSx0kCRhgFWV25+wWX5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X6uDElDmF4BJeb2iUOBzvnX7akdRxQ+c+0g1HkzX/GM=; b=VB5ufhilHdM8ETSpfQ7ikf8suERL/o8jfMltvqZSURkBYQjQ9CwUf1Kew8M6wwzJKZSHLBBmcgX4PBEsAoI+BCfsXwIQlhFxxEE8+xSGt9p4cxoOA4H04FLsz6XLV+hpY/1Jo9tplGDofjp2Wam63AIbMbDc8Ob+5qjkAE+E3Q0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:23 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:23 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 09/17] staging: wfx: fix overflow in frame counters Date: Mon, 27 Apr 2020 15:40:23 +0200 Message-Id: <20200427134031.323403-10-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:21 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8144568-c3b9-44ad-0f53-08d7eab0acbf X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4326008)(81156014)(86362001)(8936002)(6486002)(52116002)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(66574012)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oAw3BhWUPavU/AZbmVr9LNN4dHLJMg7ENUdusnhN2v12wH70GBZ9z29lwrT9BUW7Ca0BeSDse5ao3dDFy1yPUwe0rLlP0mjkCcixNtCWTZQhyBFx6DeZKQiQ2rZKRV66Un/BqHpaEOr5aFk6dkfIyWyxjlPSYcxa419E/3roWKiL8pXcY+To67se2B7YSxcKdDMdr5e3jBlNGehrbD48U6nYJ/K8VJPopv/JYbwnWo+9NIEsn3ThVKvSqMOqQlXsWJF3sGUE1jBYvW3rBvH+NajCm6aj7VGmjfC1gii1O8OajkBDXhKzyqP81k8glCqXreB8aVtuFvTolcCexyH6hvd9eJrDujqe+dx7brm1qEufkr8A43fH3BoZkDassXZD57mxEkYFEwpYqaJA7eBAxwxLsJRKAuRc0VD97CmFBUH8HsUd4g9Yx2H5bU60VuPQ X-MS-Exchange-AntiSpam-MessageData: Td3FUCpur+o/8/tuhiiojX1PzqbuR148dlnub+o7UAmcD4nUWaKW7vVEMCoUp/NBCpTNJwwE6eOJz0X2/n5EEmHEEoqMFyqv9fGjTMlXmeDhG26yi7rSi6RpJeVnaGNqJQ8Z5F55rWGiPXbT+58wxD+nCPS4LMXOKVhsJtuVxhcTZR6u7qxsD5dIieYvmKoFkE6ZSPW1R1qdeNwqZj31uDz7Gd6e8kzSFinnU7E9obFLuQeOpRXsJjjE7NyWDRBdLMzSeiY687kw6cNcYsgF2g4VkpAwzR5gf/AcK4WSNojiLPq9eV14pMlRMa2hDM4gLpZ9jqUuta4KBKpnt7/wwrfKzUfehIf+ssTRVd49QC9/nJH7rgVkMw0hVhiOdOwtbnG/YAh6n/AcZ2YiLywksfad+aAfJ9k4YtyatTbKeJgo6406d8DnNlVYJvWpxykMbR5Dne0D0WCoprwj13dY8QmDfm7ERIVa4QB2h/jfr3Qvc1DnvuXw9UTqwrgF2IG1B27mXdqdHvZqxuRKPLg02vfDt9ZrrOwd+xI5K1sNm0p52wBP1lKL/EWeVfnmuPYu2g3WV4vUn2Kw7rA3ebEUcWVsvWAyVVjyZmmaKb399jxV9QhCqqhIItM+bbD2xh63QnFOtmkj9sKVppNERPfxKgtUbCimvCzdA4t5tyXlX6RrrxV/z9LJzL9og/4MsqGOPlT1Cf6LfKI118MS953VZkdwYTXnVDNg8OLvpQ/Ozx5H7N/Qt88WcCpcV3bdVNARFnraVwq4Z6OS3MSLp6dVVmazbbYGMdbXwVr0KQIKyABTINuplUz7I6QjgJAz/j1ne8JOWeW6GdwlRuMVpLDKGUzhPsAhAY34odLNnd/BxYU= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8144568-c3b9-44ad-0f53-08d7eab0acbf X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:23.1859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rz7hRVIQG4xewr/kk8yR1hAamNtlD8DPCjPyiMvAtZ/6tXeRXwWzDp1W3Bv4kUHo2lkm5heujUOEwsccl7SNug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller It has been reported that trying to send small packets of data could produce a "inconsistent notification" warning. It seems that in some circumstances, the number of frame queued in the driver could greatly increase and exceed UCHAR_MAX. So the field "buffered" from struct sta_priv can overflow. Just increase the size of "bueffered" to fix the problem. Fixes: 7d2d2bfdeb82 ("staging: wfx: relocate "buffered" information to sta_priv") Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/sta.h b/drivers/staging/wfx/sta.h index f7e876d1b031..a0e025c18341 100644 --- a/drivers/staging/wfx/sta.h +++ b/drivers/staging/wfx/sta.h @@ -18,7 +18,7 @@ struct wfx_vif; struct wfx_sta_priv { int link_id; int vif_id; - u8 buffered[IEEE80211_NUM_TIDS]; + int buffered[IEEE80211_NUM_TIDS]; // Ensure atomicity of "buffered" and calls to ieee80211_sta_set_buffered() spinlock_t lock; }; From patchwork Mon Apr 27 13:40:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215808 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3642BCAB360 for ; Mon, 27 Apr 2020 13:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F86A206B6 for ; Mon, 27 Apr 2020 13:42:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="I3fGbg5C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728270AbgD0Nm3 (ORCPT ); Mon, 27 Apr 2020 09:42:29 -0400 Received: from mail-mw2nam12on2085.outbound.protection.outlook.com ([40.107.244.85]:27104 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728116AbgD0Nlc (ORCPT ); Mon, 27 Apr 2020 09:41:32 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XPj6v55XamexDKiGixbHEpWScxaYmMKB90SIyuZrB25Bb7y/9mbvvN+lgauLJSzF2jyWXYD2beDOLALxcMD6kuWIHoLt190qWNrwQPXOfngh2SBlLRG3pSlycIwdX/4tB8o39MctfvacJwjRPEOV3FmoKcdYg1Es21AvfpNDFkKkzRvEPHxYdwwa8rTjX2UjaUhV3mdo+XTITDLvGueoOQDPi5csVm1An0U1UMPD/MdrHZw1pmINDgvD3wtWqom4B4LgrvA9TVnVzFyFRQW8WIjjr///D2xcHshMEp6iXl3qGBTxtI8QK8HCxLjl3zkYgTq6kgF4w05G719ppC7REQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=On2eMFuNjyY36pdcuuXf4k4EUyRYjcNDklcZkuROdwE=; b=eTBpRhGAzr6vcD3UgtYVXVb6T+Eszbxtw5VfB9NXJVESCtvPP6YyQuJxJU570a3OSpBnL6d/8wbpOSlnUWkq/AUMwqyRnhst06EXVaPy81rPwHzg9YwMlwqtBMXwIN+muxyCxiJ7yfghGJuU2F6moSmiKK16Ogl6aJUkzyJpWdZT7nS+ZTtgmy9a0myew4Wq7X6t4gctAe0g+qWP2j6g3TUeGqPkt+tifaAMLC1GLCr2rPBy/pEg2QXEZqM7SBOxuv3VVxnk6Wi1R4pqf9s39JQy7JxPzE0ApQq/eLIY+7HW+TACSoenolUAhZXyitwy8/AjdtKYoOObhlnI4wtfsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=On2eMFuNjyY36pdcuuXf4k4EUyRYjcNDklcZkuROdwE=; b=I3fGbg5CXtcHEva16WxHN99XUdW1mgcNVfrWBcK6X5KVd4ZVGy/lhR16SbTgqnjZL8MxVIGXsFXHl1htvPoSi2UPza0V64xMWIKYWsPLfRJ95Fu2+s42yknJLu8zyTJjRPETippWNVq7JFj2ZsYLx+Oc7BiH9G6usDOFR5AO2yM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:28 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:28 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 11/17] staging: wfx: fix double init of tx_policy_upload_work Date: Mon, 27 Apr 2020 15:40:25 +0200 Message-Id: <20200427134031.323403-12-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:25 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6a75ff4-01dc-4d4e-3162-08d7eab0af8e X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1247; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4744005)(4326008)(81156014)(86362001)(8936002)(6486002)(52116002)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(66574012)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JhQrA7DO9Ue1NQkIv7op2nnRO9BnnmtYYQIgXd+uGXda4vEMTbqrcQ44YPrZhOkgNSpD+vuoisH6bJrNfl6KHHP3HGW/7JwmJ2xVF1HnuoTC/cIbsaw0yDOYflC0bOhdlJQxbKirSEXaCIl1+gNB3lA8QBC0F7Ee+b/KBAhH7sCindZ1/ZaB5UfughoXUjw+i6Ax+BJHQFZ2Hsb7aRgaTlwXa8gbgK1tXXf7ksvKT3VkPlUYzhe2L7zwiszhkOilQN7ZbaAYEKy2fLWxF94XqtUnefFP/WO90fb9ck7Re8OYUSnOp89w0ucAC8k2ApbHLxBHJqdmNkA29KZe/lBdhP6wZ3CbK64BAzc7pxXRLx52ZUecV8m4xBY6/9lfmQKparvmhhjZnUGgU3eNhCPkOM/ORwlpKdJgvgj8YfG1g8Ex12wVb/Q7IwtSCRoYukI7 X-MS-Exchange-AntiSpam-MessageData: Ytz4JuhSDdP3QtvfbYHhEOznn41/Sv+izIYYKkGhYE/filRoTqSzPSa3c6yXGsrDQ2kSpxnBk6yU6EpQprNkBUUmsBENC16NcOBMEd9V0PzKu4xXNKH6WkAzfrJdX4w9ryTgrl8POU9BHGtYBOeCBKexvsBLoYLx44cVytmXcRUhlum9Rj9b6nebNkWgJz6HqnsFGrZloEc3vuw9pKo/AoO85wE2wGiESC+aC1VdueB7Sqn13sYq9f4E0MIItr7u57+msZkczlbCQaDgIRuwfNhiu9pyFO279XZ6/tg6PxzOks1y58sFdZr6kP85ZRyf4bhA8YohGhkB7DX8ETbs9BnZ0blZ+Pv2lfPPuDdFaQ1mstxvFkAe0tlSb/pjOsy2naKToer+9DLehQm2Ys1ucP32pRpeUDzVutE1cCLXK/70CfZWKysAisodhvJ349WTKtF1cAPe11S4yf3AfN5x9ysyf7J27v1YmQLW/rZ3T/En1MhLySlH/so7LcJuMdd9e3oGFa0z8TbthqZcvvglM1UI+QjEsdrBkre5Hn8hXIOJzqTisZZlek/rAqqC8jkcAIX1mHLuZhki5LW0D97lrPQR3Me1mz9fOAq63KIzexj6PH0An6DiKAF3HjnWSSBg2Plyvk54dfC5FNc/wZ9jUuzrQhY0phGJjmzPUjCV3tOQg31s/UsY83VZdDMw2xCTuDA665xwTt4F9z/bOC9dE46AP21DeIceSa2OlnlcEYtqm802TKY8rKI9yNhShvQiVCpUdh7j8Y0M094MCGaQyxORuhD/8bAHlFccIvTtIwIGwlEydkK9ZcgxNUXuqA3keZSrxfFtpZFE0hXkMMzFHkWAxuV02tZ9oQg/7zrFk7g= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6a75ff4-01dc-4d4e-3162-08d7eab0af8e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:28.1927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eqC01YgsYeKsFUpm7BwCQuYx9iZA5ibp4GxKgu50RTK2fjlIKagAWSL8K9EdJVs1XfrfH4Q7mT2aFcgE+aDoHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The work_struct tx_policy_upload_work was initialized twice. Fixes: 99879121bfbb ("staging: wfx: fix the cache of rate policies on interface reset") Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 67eb4a6e176b..74ec0b604085 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -782,7 +782,6 @@ int wfx_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) init_completion(&wvif->scan_complete); INIT_WORK(&wvif->scan_work, wfx_hw_scan_work); - INIT_WORK(&wvif->tx_policy_upload_work, wfx_tx_policy_upload_work); mutex_unlock(&wdev->conf_mutex); hif_set_macaddr(wvif, vif->addr); From patchwork Mon Apr 27 13:40:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E3ACAB360 for ; Mon, 27 Apr 2020 13:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C060206BF for ; Mon, 27 Apr 2020 13:42:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="Ff/YWolO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728228AbgD0NmV (ORCPT ); Mon, 27 Apr 2020 09:42:21 -0400 Received: from mail-mw2nam12on2085.outbound.protection.outlook.com ([40.107.244.85]:27104 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728091AbgD0Nlg (ORCPT ); Mon, 27 Apr 2020 09:41:36 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SyYOQ7bAVzSSajIbQmParbHG4LolEZxkyKbYjNssleEX33vYXNHhuSgHTvcCrlU2jAymr2HV7MoUOhCCfZe6JYafPu7+S/r90okjoTIelFf/YtBRyQic7NsYoSvSjLh2LvLi09ZvxIIZrtiJ4qSP4hcG9h2kfRLwQRvoJcunqenn6CbENeyNvxMUb2po7N5jd0lgL+Tt7tTe1HMpWIQqFalmwNyxrDT7oOEKd/SpGaiAcDfFukbpI/TbCt5pmSXNGoFnKGr71BR5NC/lwiHKCkM9aGZTYz4XPf00WiC2V4SO+2HN7AP8ld1R/DafamlTZCrao2AQVnHjUJ6YJFwFLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SfI8C4D8XYBn/gT5TXywrCOmodway3QLz7Dgr0sbX2k=; b=U8guohqWx0M+oFeBsOfxR1zKJRWgM/0pWWYQsDHc4GQVGNR8OEWbpkWOEX9mn9V/SnlMOYZ0nCmQIbGsLNjxAwxElld6y0PVSXhxZyuREh53AOQGBY8QjE9UBlMoYfHkZidECGnxqzKPlbyiIzUZ06mCWOhlWCLCT7jmEMYGltA4Jc4j45LyJ4sEzdN3rE/mj1ua+ZbGaDLyYYrLU99F/XrjzboLkY8+FDvfeGFcvyVRN+ewweEGzA12SHGVLCmmlag1VmIFWOGvfqTysfw35TW6GkHUD0tOVSoTOM5YqVRP4ai8ntx6RBfV3Z69rggFBIqYLeDx8frRdX4CiFxfzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SfI8C4D8XYBn/gT5TXywrCOmodway3QLz7Dgr0sbX2k=; b=Ff/YWolOkqVBA9bZHrShvlIj8N4OIQMheysvqWUii/WAD2ugfYTdJkMW0dmJdYRR5iCRRNq/5+lvnyXBA1zBgM+bHjmqrGl779HalOiO0PTjoEjC1fOfjKmI2yEvjeHyJWWPHCkxvD69WAQuBVxJpJTpZEplbbo/IXkNMs6ZnvA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:34 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:34 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 13/17] staging: wfx: also show unnamed counters fields Date: Mon, 27 Apr 2020 15:40:27 +0200 Message-Id: <20200427134031.323403-14-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:31 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a248b770-01dd-44ea-a825-08d7eab0b37e X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4326008)(81156014)(86362001)(8936002)(6486002)(52116002)(6666004)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(66574012)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R8kUwl0W/kr5VWMsES+E4RocR6Cf+I43flKzR2YP9XPLjB/RFwpOzOyH96lrk4B4r/k7is8DoMS8EEdBXAHU5JjSi5bAbahsS5UkpeyKS/bzDCoUTogd3HyDtzQ9JFFT7qB1lzdTsW1TSe7uBg+750tnr8AZyAX9cplBgwXVo6QTpKd9wO7N5hNxycn/ToDyxQcz5lgD/GSYsZ2sK7uJ6tdl4l4GabpCOXLqYX8aLp4FfvSIQcgVyCPoDdbj/n5m1H0EgDoOV3+tQO7JZcSogw2m5oXmVbeZocqG0wO+e130i57mHClLJ6nw8JHVrtFYXJRlpF3hq7wtcGuNUHY/kGSA/M5WkXkyC7a9IwSbpxENf5JYOxRq5wL34ZYGUUZ5o2GYCCkDthqQ8/qlOffa4n1kJ7kXlnFyAuN+Z2kFeEklldSorXS3W/H7TCiq9zHY X-MS-Exchange-AntiSpam-MessageData: nTTjR9kxOOcXL3gmL4VOyv2RaKPPLhQ4fnYqY6vvu3jqqJQbWumcPx8RLrUL4fH1YBLOPBW5o3tMr5jIqbJTVcG4cZvoWRfqSVYarlSrhCtt5tO02Y5hwiVfK/1Sr0ZGKPrK1BiPDHIbKzjSHpjVtw0fL/9tG9G6YC91IlO6jF/l1a4LYxPxfqbE47jI1crPNveA46LGc0567KB6VHaNS5gojPL3KNnWvmGgS+kpjsFTSwwBv2equJ9MB7vOiUqwBSGuu94rEfwLCrxIu4CFkhCaGbIk88Q3yK7vgsJOsQrTm12tH0vSG8yJmE3afQyQnoWljF2Z677q/k/icTzjgwaQCvmscDJ8AWwQx9aT4ifagxmGjVclv/dg8HpPU1vg/G1u5ItkY8DeUkDd7cnO4wrbEHJ58sPF/F2Z/R8uVk6KVcoltwZszTnJd5ophphqc0qbTUbpom9A8jyWlMeM4nfcWZ6U+g13c06+zEb9OVfuf3RpEOs8JTpLjA9wZSkR0x0Qaj8+kPy16AYFiGx5/jjl28gBdvI2rfEU+PLARPD+B3Yy3pMzGsmH6qyYxJXrYnRtnT67mow5xysUsQMuEm7aPL3tyfe4/55dnvkYQN8vokD2KYKDWV0G9g0KURyUWrjURGIM3fEzaOLrKqapieaq0YAYLADQPSp5sp4u1OqbOniqUreqbdmhQLrNdoQICrvcGJNRpaQAYzUv32fzUaCqFJiansa5NlquTeueeCfVaa4vvjJ4uZ1kINltEA3mxYQAeaTf4oEAlxWx4qEopGenqY3wzuKQxEdg72YUearWsAan3q5ZTkp5o2AnXDSfU+vA8R1fnNcNSRQ3FdU6Fs7MxK5SLSl/xEBlLsKFsPM= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a248b770-01dd-44ea-a825-08d7eab0b37e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:34.5409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qrmbRQpZy9T25MSTA4Gr16aVwgIUBRLRBR4/xrJ0z3XgSjIsPxwdlfRNOggWcwSk95iWLJkUZcqxW+yt3y4bTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The struct hif_mib_extended_count_table contains some debug information accessible from the debugfs. The struct contains not yet used fields at the end. In order to support future firmware versions, this patch also show these not yet named fields. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/debug.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c index 4dc4f6a0b92b..2fae6c913b01 100644 --- a/drivers/staging/wfx/debug.c +++ b/drivers/staging/wfx/debug.c @@ -112,6 +112,12 @@ static int wfx_counters_show(struct seq_file *seq, void *v) #undef PUT_COUNTER + for (i = 0; i < ARRAY_SIZE(counters[0].reserved); i++) + seq_printf(seq, "reserved[%02d]%12s %12d %12d %12d\n", i, "", + le32_to_cpu(counters[2].reserved[i]), + le32_to_cpu(counters[0].reserved[i]), + le32_to_cpu(counters[1].reserved[i])); + return 0; } DEFINE_SHOW_ATTRIBUTE(wfx_counters); From patchwork Mon Apr 27 13:40:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215810 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4592CAB360 for ; Mon, 27 Apr 2020 13:42:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98D3E206B6 for ; Mon, 27 Apr 2020 13:42:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="X4DyRizG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728162AbgD0Nlm (ORCPT ); Mon, 27 Apr 2020 09:41:42 -0400 Received: from mail-mw2nam12on2079.outbound.protection.outlook.com ([40.107.244.79]:26048 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728128AbgD0Nlk (ORCPT ); Mon, 27 Apr 2020 09:41:40 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UICqT+9rq4c/5qgq+AqBWi+MK59BcOw490o43dUWW66Dc7bRlT/OE96sx7yoZws5yHRbl5TrfKyP3HQtzec8unZKSjHmhXeC1v2m/HddMO8C9Z3cbgbNg7HQEXN5Qz095UXCEwWFZs/p11K/F3SHvbHXUwwQqirqQMMx39a0pm4kgKUNjnij6qgNI2Y/a4R0pifUEoaxk/jIY/GfOU4n0WvW4yIGh0y3qwwKTft2PA6rhV6oT0fL0c+/mRfkf/FXZjk1RY9gWIs6gYZ/DoIzU5uveYjB7ptpaFJ/MbiVTMKnXvmWZJaQlXzgJYj7odW+KMjPUJpNVtf5GJ/nCyzQwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4/GjzrCFiTbCEHiqTUBdkSPriUhMCEf9S0AkojpW7U=; b=MBR/wXn6ZyeWv88qERfdGXYCSPU3XL5EOhdIhVfirNQxwZjThxlVrCidTqQ7d7DRNOWYKM9EIqAF5g6mbn08CVPLgGY2lH6Y0YzSwNPJ7TBIGxHwPRCFU5TLzCtxKwgs2bFfUKmYRJH6sAspZd5MLawxC3WH6vmnVLPueqiIKkvpuMONOGsdkusFg0mt2TyNFGUAIrtAxAEbtrL+EP6sFKM4VvHF3m338oe7eEoQW3x2CVGWWCp+dGXXWVsNFz0eD9c49eiOZvJ/hnpi9Soz0Dc1JXO3DGOue/NxcpQLek/rRmqWwwvHE5sMPn48i8KfowAHhilj6bZ7brAtJS9leA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4/GjzrCFiTbCEHiqTUBdkSPriUhMCEf9S0AkojpW7U=; b=X4DyRizGBV+fpntuDSsI3I5FnSPtkCRNuPdAB6d6QqNJX4OYvr40ALBurzUxrcaUDvljFEnZSA6vSkkh99Iw8ci0Z5Bbdq2EENLa44gHs1/TeoOPt26YyEjS9XFoTihdgfWanAY1M5z4eR+PTH7z8oeNuwBX4SfEa43xY6FRq1o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:38 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:38 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 14/17] staging: wfx: update list of known messages in tracepoints Date: Mon, 27 Apr 2020 15:40:28 +0200 Message-Id: <20200427134031.323403-15-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:34 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4b9079f-3866-4906-231b-08d7eab0b5a1 X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4326008)(81156014)(86362001)(8936002)(15650500001)(6486002)(52116002)(6666004)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(66574012)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wbShc5w4OgEyQbaWGdk4fr6qih4y8tlox4MGCSqefacAjzlRLTX6h7lWlJyIseNSRUdJyTPg7CScrytSzP99ThWz/3ahbBzHRa63PFukUMX5L2HEPc8J2nmLFrQ7uVmkXZM5JurTHIxMmn9zzeQFoaHqPZoH/zj8kURPAIzH6Mm9U6ntSeXUNlQV+8Q/n9SLzm05m0xLSd787Id1SGcfl6N+FAaYlItdyViQyM6LHkMqKV8uXFA022vY+n7Un0xpVSiyRA2cSAsE+Z6DO/8JKwCDoaOXusuhwakbg5k/FJl8KeBSvUdUP2J/sE8KLDYnn9nbliiFEgz/txX0hqNk2HdH9RTpB7lq30AWtu8DtNYfrre1XAHQL5G9IskbFF3JI1KHuVeFKK/9fc7838iQImVcxpu9NLE0ydCjdB72HX25RSPZBY5CneKAKJ1bVl1d X-MS-Exchange-AntiSpam-MessageData: 1chnTdK9BOV2MpXqa5F29XRxUwKQDka7YjQRZ9hf8z8+Jwo/WY/ZYirHDC7ZEwJ3S0lZ2D+UdUdMYGBRATp1pHdFnqeK0MxQb6V8Wr4qLYoLpXLeFOsnnOLp8fqXxuNgJ9Roao06CVhVJpzrasmaCcfeZDWThMvg+rwLU3dA/dM5zsEBdHlSjzR38E5MuGlVd/xzBOt8iCwRJO08ICu2cWFfU8SBH3wIB8/UGFmKEmbljDTczCzPzxqdmbyy/Z8JXKDkRlRGKmbYkXjCHD9el9JLhGEYMZNs8pNmXedx4YZJ/Q+VG7vSOn2YsTXd/gL4xFVXjFBdscppS3Qz2sO7/iYFMFdLe1vxJC313z/omfwVVAn+TXDToB6t2WCpA4304SVgXJnxXj1lZTobjMWKy6Na9b5WxoL8pR/ZHxaevnLD1rUsWwbVuUALHH1xxi2T190vc02DHgl34yXmkxEYNxDEWCp76+ns9KGsijU8BRyfPKE66K0QzmAHRH5oMibSfBwRdDFwQhfHFN/dtkK+X3mGGzPS/oI1QYJs9Fv6R8X5YaXRgxW5BcspUdcGAdOISZVwJLgddPOG1e8h9NtOJ4PBIoYD0EneWty/8CmqFTLa8s3g+T9CabnV9kpt5XoIv9fI9zAQvQKxRsxXHj7vI3MtdwialRaEfOoSyhxy6ZiJC5wmX5Uj+ej0Ss9O3V12Vro6gDktUa7Njs2Ky5NxEtR7w44DLrGqvreN/0DpGfvF8ERX5C9E56xxzeqYCLAbBMAhP/fVEkVSU/wtAIfA3pCcEc1+m/2Ljqq9dQwsl6hdi/+U7g7gpzxPBOtaNYs94juvFx3/crqppjVp+vFADj/L4inkVzG7pCUqXsdR280= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4b9079f-3866-4906-231b-08d7eab0b5a1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:38.0503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5oV16SfmD+AyWG8740O2LV6e3aOvVGusXWfBaDbze3vDGRqegxVeiORfYvJkMdH4is/adh6QCYerN+6Q4GQAng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Some messages are missing from the list of symbolic messages defined in traces.h. Add them. Also sort the list in order to simplify next changes. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/traces.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wfx/traces.h b/drivers/staging/wfx/traces.h index 30c6a13f0e22..7b25e9511b00 100644 --- a/drivers/staging/wfx/traces.h +++ b/drivers/staging/wfx/traces.h @@ -104,8 +104,10 @@ hif_msg_list_enum hif_mib_name(ARP_KEEP_ALIVE_PERIOD) \ hif_mib_name(BEACON_FILTER_ENABLE) \ hif_mib_name(BEACON_FILTER_TABLE) \ + hif_mib_name(BEACON_STATS) \ hif_mib_name(BEACON_WAKEUP_PERIOD) \ hif_mib_name(BLOCK_ACK_POLICY) \ + hif_mib_name(CCA_CONFIG) \ hif_mib_name(CONFIG_DATA_FILTER) \ hif_mib_name(COUNTERS_TABLE) \ hif_mib_name(CURRENT_TX_POWER_LEVEL) \ @@ -114,29 +116,32 @@ hif_msg_list_enum hif_mib_name(DOT11_MAX_TRANSMIT_MSDU_LIFETIME) \ hif_mib_name(DOT11_RTS_THRESHOLD) \ hif_mib_name(DOT11_WEP_DEFAULT_KEY_ID) \ + hif_mib_name(ETHERTYPE_DATAFRAME_CONDITION) \ + hif_mib_name(EXTENDED_COUNTERS_TABLE) \ hif_mib_name(GL_BLOCK_ACK_INFO) \ hif_mib_name(GL_OPERATIONAL_POWER_MODE) \ hif_mib_name(GL_SET_MULTI_MSG) \ + hif_mib_name(GRP_SEQ_COUNTER) \ hif_mib_name(INACTIVITY_TIMER) \ hif_mib_name(INTERFACE_PROTECTION) \ hif_mib_name(IPV4_ADDR_DATAFRAME_CONDITION) \ hif_mib_name(IPV6_ADDR_DATAFRAME_CONDITION) \ hif_mib_name(KEEP_ALIVE_PERIOD) \ hif_mib_name(MAC_ADDR_DATAFRAME_CONDITION) \ + hif_mib_name(MAGIC_DATAFRAME_CONDITION) \ + hif_mib_name(MAX_TX_POWER_LEVEL) \ hif_mib_name(NON_ERP_PROTECTION) \ hif_mib_name(NS_IP_ADDRESSES_TABLE) \ hif_mib_name(OVERRIDE_INTERNAL_TX_RATE) \ + hif_mib_name(PORT_DATAFRAME_CONDITION) \ hif_mib_name(PROTECTED_MGMT_POLICY) \ - hif_mib_name(RX_FILTER) \ hif_mib_name(RCPI_RSSI_THRESHOLD) \ + hif_mib_name(RX_FILTER) \ hif_mib_name(SET_ASSOCIATION_MODE) \ hif_mib_name(SET_DATA_FILTERING) \ - hif_mib_name(ETHERTYPE_DATAFRAME_CONDITION) \ hif_mib_name(SET_HT_PROTECTION) \ - hif_mib_name(MAGIC_DATAFRAME_CONDITION) \ hif_mib_name(SET_TX_RATE_RETRY_POLICY) \ hif_mib_name(SET_UAPSD_INFORMATION) \ - hif_mib_name(PORT_DATAFRAME_CONDITION) \ hif_mib_name(SLOT_TIME) \ hif_mib_name(STATISTICS_TABLE) \ hif_mib_name(TEMPLATE_FRAME) \ From patchwork Mon Apr 27 13:40:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EC6CAB360 for ; Mon, 27 Apr 2020 13:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77B64206CD for ; Mon, 27 Apr 2020 13:42:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="jYxyC/OA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbgD0Nl6 (ORCPT ); Mon, 27 Apr 2020 09:41:58 -0400 Received: from mail-mw2nam12on2078.outbound.protection.outlook.com ([40.107.244.78]:6167 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728181AbgD0Nlr (ORCPT ); Mon, 27 Apr 2020 09:41:47 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+m8A4dkt537S3/+e0Yhi6kWCWCNBlzSx4OyA5+s4UoKGCxvOGFUFsocOc42lHWt79wBYkivluKtwsT1SS69y1MAWZwqusiwProb2egybPXU0Fip0V1yXUJNufUMHNgd08TN8sSwZIu+lbzTtc8IfKtP6GfgopgWF81XuuEQ9gW+7HG/f8zHdeLXNCkaEXIysvTV50BMC3xjoHzUsDaACuwNwOmPmJ6f93+669c6JAtcbu1DPBChKM9i5Nm0Lblbo03+5HABnCEqtpVk65duCvWknMNJs9Y55Ez/di8+acWzwqZRpjk9PVUw4dl+sJ37vNxC3hVv6K9Z2u4qMMPpNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4Qf85QInMmItIH52jEcdSx4hflv5Asj3HUCTAdM1jU=; b=UZd0Z97EnilVKjt6MqDEZ5/1uN4az8WdeM9ZfqSEMsNkCmX4Ha8mmTinKHKCvuokJ/TDfN7q6IM1yoDR56c0bwsDeMpaqWWOKV07eBVVVpPMhMIjrmnpTAQgGCmwZ9gbjfWr1O3U2zl30Obiji0to0Bb4bYCff6vQXT9P5cLK89HVVTDXBrohJRSGwS2xsKEsKyamulOqCl5WYA0ycBuMjcWdzZoYL90Xe+Hx2/c1HM/a05P67AgkndO4aXFA9KILlYWRl/NHXQCq5q6CBh4KddaUeOp5+Um04QL6IwhUg/VvZ3Ic/JRDehh3krA2tqFsLMJHHOXX2JZuVWgW7mGRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4Qf85QInMmItIH52jEcdSx4hflv5Asj3HUCTAdM1jU=; b=jYxyC/OAyvoD3iX17p7QvSisTkTj13bnCgIo1oXn6rQC3j5C4om5j3SdpmGRAGZjmyJY+A893YBZRMh/kGydtNWaeuMgN4tm65RSimoRzI+wrhO1tQNWbKa8sZlwCadb7LGr7lRHml6lxceBGnW5vp/4VhaFM94JbqGEQONBu+c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1424.namprd11.prod.outlook.com (2603:10b6:300:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 13:41:45 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 13:41:45 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 16/17] staging: wfx: fix display of exception indication Date: Mon, 27 Apr 2020 15:40:30 +0200 Message-Id: <20200427134031.323403-17-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> References: <20200427134031.323403-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR0P264CA0232.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 13:41:42 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca74b27a-f279-4da2-a0fa-08d7eab0b9ba X-MS-TrafficTypeDiagnostic: MWHPR11MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39850400004)(376002)(346002)(396003)(366004)(8886007)(66476007)(66556008)(4326008)(81156014)(86362001)(8936002)(6486002)(52116002)(6666004)(6506007)(5660300002)(16526019)(6512007)(1076003)(478600001)(8676002)(36756003)(186003)(2616005)(54906003)(107886003)(2906002)(316002)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5xis6d1uaPVeI6VEx1aEabKBIGp1o17Acq+U8LrhdMuKiEWuOjlXTsL/Fjod7KAxp6KjyAIn+VJw2MdYTe9JWderKZRteIKGm9B2PKkcPTeaA0xu9Fxizfna4WBsEaWVj0l5dAYAX1+kJaYjHeyx1dOzsewCHMipZjFS9thGdDLp+A5fSL4RAJPIVUNvVtIewgyZHcaDZE5HU7altJmQODnG1gLqI8t7vFcjrKAK377fGMKFTAjAi+WYFeBJYMTr4s1+nb9Z45R82egNqp8tmSGaZQt7+k+WphaM9ydoImB+kFJso+cUkqaQKvgy2+7XlcQgCc0FD4RsZ7cQQDE0OSN8i5J1+AX+p8hpEebHkAhAfJlS5ul5s5vJ3Bnzkaai1+Ocw9l7u1qfFjaL+/avSGj4p9HcmJeMuiAgVE6ftxJ1Lf4GaDe+wnn0gcS0zt98 X-MS-Exchange-AntiSpam-MessageData: JIRBfXEPyonqzp5gVPWhM1IBmZ4UgoN4ixLvUKphcwR51GDWKY8Snrwdm7i8DomLqwzH3NwWpYucRZt89RkDozxILHbSmuvIJ5iMmUprZTqkbDG/Wvu7SUCjGM7HqGJzpTXRaBnQsyHQKEK3rQ/xXNl3XMbgkfT2pKd1G2syK3M79+stu1CuhEGPVqbiJsk+SC0i7FkI1+zgKHNgp2vftEDHBiMNTm5TvLha9WgF8zUGrOudV9fksgdzjUKcfB/9KWUAl4T2woBe7uYJ/47n0bui6cUhiUOh+pI5PNWD+sSs20TAP/Gsf7p/XObr2MHHIWKcQ7uqTR6h6uzgTR0rWiYQzUawrWDzQgtdP2PIXppChIzCD5yD4j81mq97WnMsN+hzhhn5zKeJ6rQzMTna+aaEDUJtgAz3e9Lhyz6Lrb5bdDGkxCKaI1NfyacMRnymR05ImJqbz6eCW+dRtl8RHLJTlScfPtoMNBWKlOpDjQjcM+EN9hKMH6OIY0pmXi4Q3cS+eXjfceV2h4Co3e5K/veyHeVcxS6JbM/zcfdFKNW154WfkPz+KmzigmyWyAu+aXr/PBdAjEGfWUdFbQzVI/P2vXONwd/aoviD1hU88rgWlFW3LoxfI4aGPzZpG7m4TN8cPdhTWKCBumWWmfMtde5RFUe7dk7jhyyk4dyYRJ1w+vC3gq5cE5mnlH3LhWzN+4+ifaDYuLXJj11Au7oH5eKZcwC7RBbMfbjDaY51OoKfyQ6Cgh4wPQViLJSDNg2h4+qjp+H3K8plIooja226JH069RGXc913DOH1aQdGJerQtxqXV/OIGP1TQ+eR9pCYbkeRpyHG9Qsv7e8rS6rJA0j9gxf5YhXey+YAKzNKa3A= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca74b27a-f279-4da2-a0fa-08d7eab0b9ba X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 13:41:44.9663 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +HPJC8v9Ilapq407cIMrFpD6Ze1uJYMSdekVnQE7J8bQN+BdYAdWM1tGCqAMu2Biuf+zDOc/yCWFksdDFUYW3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1424 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Until now, the exception received from the chip was only displayed if driver was compiled with DEBUG enabled. It was not very convenient to help users. We prefer to show the exception unconditionally. In add, this patch provides the semantic of the first bytes of the struct. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_api_general.h | 11 +++++------ drivers/staging/wfx/hif_rx.c | 12 +++++++++--- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wfx/hif_api_general.h b/drivers/staging/wfx/hif_api_general.h index 275354eb6b6a..1c010f15c6d0 100644 --- a/drivers/staging/wfx/hif_api_general.h +++ b/drivers/staging/wfx/hif_api_general.h @@ -223,12 +223,6 @@ struct hif_ind_generic { union hif_indication_data indication_data; } __packed; - -struct hif_ind_exception { - u8 data[124]; -} __packed; - - enum hif_error { HIF_ERROR_FIRMWARE_ROLLBACK = 0x0, HIF_ERROR_FIRMWARE_DEBUG_ENABLED = 0x1, @@ -248,6 +242,11 @@ struct hif_ind_error { u8 data[]; } __packed; +struct hif_ind_exception { + __le32 type; + u8 data[]; +} __packed; + enum hif_secure_link_state { SEC_LINK_UNAVAILABLE = 0x0, SEC_LINK_RESERVED = 0x1, diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index e6daac36f5c8..783f301d58a8 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -331,10 +331,16 @@ static int hif_generic_indication(struct wfx_dev *wdev, static int hif_exception_indication(struct wfx_dev *wdev, const struct hif_msg *hif, const void *buf) { - size_t len = hif->len - 4; // drop header + const struct hif_ind_exception *body = buf; + int type = le32_to_cpu(body->type); - dev_err(wdev->dev, "firmware exception\n"); - print_hex_dump_bytes("Dump: ", DUMP_PREFIX_NONE, buf, len); + if (type == 4) + dev_err(wdev->dev, "firmware assert %d\n", + le32_to_cpup((__le32 *)body->data)); + else + dev_err(wdev->dev, "firmware exception\n"); + print_hex_dump(KERN_INFO, "hif: ", DUMP_PREFIX_OFFSET, + 16, 1, hif, hif->len, false); wdev->chip_frozen = true; return -1;