From patchwork Wed Apr 15 16:11:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216006 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941DBC3815B for ; Wed, 15 Apr 2020 16:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 586AA206F9 for ; Wed, 15 Apr 2020 16:12:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="f1iFxbAc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415145AbgDOQMT (ORCPT ); Wed, 15 Apr 2020 12:12:19 -0400 Received: from mail-eopbgr700077.outbound.protection.outlook.com ([40.107.70.77]:38433 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415170AbgDOQMQ (ORCPT ); Wed, 15 Apr 2020 12:12:16 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZrAAMrD9P0wc82+GupXlJdFboETZ0IZxX/qYVCNgeDUNDss2/1sm1/R6hrqe/0GLPZ91ABYyssD/FsEOPySMRwfLi4R6NwISkeC4qucuk+o30ePViF3rW2v6JXQ68OWuuuUtTIP3OF3mlazNWmZhx838rq/EV2KyMbTJOQBkRi+XZLj/Vn4RywUcVfHl9wpJtBrUVaxumccH77H3Cv1jC4CeUY1gv4WBCSHPuLpbtqDn6f5kleWJeCuyd+ztWIExlwLVL7A0ZCW77Q1SUMQ3jgYCAkC9i1UJXqXCyNi7NXA54uYM1Y9/ZxPiFhE8gGgSrzTtc9y3sBp9Cx8ojf8w9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNbWrpIqbUX49u4kph7dvG45SXR9AdixdFlt2Qcglfc=; b=Aa9pWWuShoiLuyQRFYN9Sgg4RsL7eexTocQPk/XO7KTfVUWADTf9RHKhvFb3+dLfLa1nOHd4+1j4Mft20BjFQhVLN0VWi4eQMu40n6UG0XdOE0FU9C3yCgXd9LLnOD4POmhmdDfbupPCdIgPKYKLX2lUN+wLChqxAeHj2YOBWEDV5juyqd8JT1hMdGW67yR21MN7T4syyVXqO+IqGpy/WfVSwohn2ZXRI2fEEYfKcj/9YjqL0wWtHh+gQ2gK1ocRJ39GI1lRsNWnsv9A9R7iolAv/oCG7plb0UodKvu5oIYaKILiQZoRHAjSo52MgSKktJAZwfYvQjTtI5K055/fGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNbWrpIqbUX49u4kph7dvG45SXR9AdixdFlt2Qcglfc=; b=f1iFxbAcoKAojDhGmI2Zsy0a6BVXOdURChAISedHV1gkh6Z9EWSrILRNoVMQcmCvGxjd9e2hS4qCM1Y0vvjcR26pE7EB5Gic6koLvMSQrRFfgqQuwxIahdxto1PhU6nb9FiA872FDzWUR4OP6wOL9IjBJuj44pe69wgwJynbHGg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1408.namprd11.prod.outlook.com (2603:10b6:300:24::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Wed, 15 Apr 2020 16:12:12 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:12 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 01/20] staging: wfx: update filtering even if not connected Date: Wed, 15 Apr 2020 18:11:28 +0200 Message-Id: <20200415161147.69738-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:09 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cec6d37c-7244-4ba7-4333-08d7e157c199 X-MS-TrafficTypeDiagnostic: MWHPR11MB1408: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(136003)(396003)(376002)(346002)(39850400004)(366004)(8886007)(8936002)(4744005)(5660300002)(2906002)(6666004)(86362001)(8676002)(478600001)(81156014)(66574012)(1076003)(4326008)(52116002)(316002)(54906003)(107886003)(186003)(16526019)(66556008)(66476007)(36756003)(2616005)(6512007)(15650500001)(6486002)(6506007)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p5TagCX4AS/s9Mwu34h50MnwLVoe5e2gmbpUCENzo83AXCCwDivjXEyBcrCv+BXM8qKTy3z4cUutlt+SAvr9+Ff7mUtCT2/ySBne3DQChM3pKe0Ns6Uyuuke39I5XvWcCBO4YtUdX51Qhey/O9lbJbs7oElyOoDXBkjUiTIUbhC+6OmSR/pdzVH3inXNcN990DS6uwenCv1+0bx+FwupNB+ScysZ48uDeumNpw+VJ+WIsrLBom0v2WJw9vcWN/WQJfS/XJWKKx/2+PS7mbffukwF507JECTCp1IlqYVw4sbYYKokxFrP0GoT6174SdIBdyzqzSjJbdgSi3gN6jv7EGWwWJc7HD54C5s0082GzAdemKq7759vywbxvoKN1DtigTKHSv0Lh3wJ2UhlwvZDSRerCE+HB30NXOWkYV1pA4dWfT2MIsnPop1WVQ08K2VT X-MS-Exchange-AntiSpam-MessageData: ak5tVTD+ugDt9ranHPysrYCtmirfyyynNGC29XHj54OUXYv3rszI4WpAI3VU9n5CtfAHkL5c+Dx8vBdoF5KY/TpI02jmItTAgZ1ZfRNeW3/EHI/TvtZI/WrG8CJzBQymY0A0Ha7dx61itPYlD96W7+qOZaVulz2D5zAKXKb6+si9VMJkLm3GpcWD6o+6gO5BK8Y59zF7zqtKiTpoK6Ivaw== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: cec6d37c-7244-4ba7-4333-08d7e157c199 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:12.6354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f+hRf2ajPCoNYN0dKLy3MTVl3eg1W/CNN10pGhcMzGDT8pswcMoBWIX3mPSy45UH/Pa15wPMvqL22ANVSSTs4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1408 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Currently, filtering are not update if the device is not connected. There is no obvious rationale for that. Updating filtering while it is not necessary is harmless. On the other hand, it is difficult to ensure that the filtering rule has been correctly sent to the firmware. Just drop this useless condition. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index f1df7717d5f4..cb9d14471745 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -168,9 +168,6 @@ void wfx_update_filtering(struct wfx_vif *wvif) } }; - if (wvif->state == WFX_STATE_PASSIVE) - return; - if (wvif->disable_beacon_filter) { bf_enable = 0; bf_count = 1; From patchwork Wed Apr 15 16:11:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215998 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42CA9C2BA19 for ; Wed, 15 Apr 2020 16:15:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18B1B20656 for ; Wed, 15 Apr 2020 16:15:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="Rz7R/kSv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415217AbgDOQMl (ORCPT ); Wed, 15 Apr 2020 12:12:41 -0400 Received: from mail-eopbgr700077.outbound.protection.outlook.com ([40.107.70.77]:38433 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2410235AbgDOQMd (ORCPT ); Wed, 15 Apr 2020 12:12:33 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C4X+dWKGir9hmlC69xsQl0BrG+RW6tFS2+ejSn6ATxwV4NH5BXjw60QkB3GKDuyQDjygMfHeWvx78BqCkOgYS6mVja+wJauj2Ex8KsMQb8D4HPNk8AiORGFqsn3QMiPBeD4f3Y7T35LVlH35/p5di+wRp4yGh7ttsmwEwD4e4NaEXSgt/uJqazTyszZTma+H7hxo6HLqPV7D4vDZMEEE3zUM1zK/0isKsWXlbfev7bmagbACFtZEZTGlo0Ak8G26Y4Fh2P/pAkhLYiDTGjU4mUmgEx7wYt6GpiQP0JzJ3yH80ahrAAgcF1dU9ATiQVGyv2nRuAG1HuWGMHiqmRNIUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+YT2VADB+GGJ3Msh7hizMM+OgRTfpOnA8TW0G5pIreY=; b=XPHICGMB61pJuUD7ReNsU5j0cMfla5634B3ZEwbCYUpn/2eQi19AehVXsVM919vrMyXD7e1qIb+p8pAgDyRKVnIz+wlrKDAXKpxzh3d3YSpmM/c/cZLVdsLynEZDtpB1kU0Z8YaZl8hFbqlcoBvyuDte2UZWuhMyO2KDZZKNQ1175NFEBO7fp12HSGcav1ZqZP3WElg94V9V9ADHEBCZzwUD4UW++ijrHfBgMWjB/10se6OolmDlEQy/bQKLaG/5+KdKhSDSG5fuZD7iZ/kyNQ7qplS8gmp2bYnMOPVQ7CR5hwLlGb0yaPWidCQrlfQDwCzy5yLDN+CEK+iYXxPFew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+YT2VADB+GGJ3Msh7hizMM+OgRTfpOnA8TW0G5pIreY=; b=Rz7R/kSva9UsHxmnl005M8eNJDFtF4blxp0UBtj58sVUHGf9nzqPkk2wf2ANyCH0HLc0ul9MDQah8UbwwVV8tbCbbCyqi2NGZzbU9st8aTNxvSZ3gkLwGfb+dTzjK/W7vd5K19LN9T3zNs0gGRpUPYoF8qB4wr3I6PG7+qRUPDU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1408.namprd11.prod.outlook.com (2603:10b6:300:24::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Wed, 15 Apr 2020 16:12:21 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:21 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 04/20] staging: wfx: simplify handling of beacon filter during join process Date: Wed, 15 Apr 2020 18:11:31 +0200 Message-Id: <20200415161147.69738-5-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:19 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47210ce1-d1af-41f9-f4c5-08d7e157c6b4 X-MS-TrafficTypeDiagnostic: MWHPR11MB1408: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(136003)(396003)(376002)(346002)(39850400004)(366004)(8886007)(8936002)(5660300002)(2906002)(6666004)(86362001)(8676002)(478600001)(81156014)(66574012)(1076003)(4326008)(52116002)(316002)(54906003)(107886003)(186003)(16526019)(66556008)(66476007)(36756003)(2616005)(6512007)(6486002)(6506007)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: euYUjX9R6wi7fdXtf8ebMg+hsPV5rSRbv71WN0LP6bOHpDmQnxP4RFP3Xjun0rpd/ebVrLD5O7HeU9TX74SsyIz9ZuZFfynnKh+HPv9FGirRMjf9DQ6rqolzOvOTiMeaPI3DAPRfQjBuBZamy2jvTExbpBsZ3owG/9Zt8p2EMWNXAYfgih2He3fFPyHSzNdzOL76YuWGYxQgHOXZwCaH37brTeB/XsOfS1DfEH8XYN+Zt56RuZ4fibNDR/KL7dcrCZaBBxW1ci1Z8lk55YaHv3J7EG2uWtwGOymUnWKTgzp9idiGBCzgLX9sm7ZUFMVq7JnghMJEFLcogfbpUm87YIFLJasuA9aZjrZW9N3JyNAyw5xlThqIlavDSL0h+BHnhjEzZMYkKnO8tgDT72ffsoSFdL11EM8PGlnzAPmxxvcyWprbsFy8RRFBHNdTD1ED X-MS-Exchange-AntiSpam-MessageData: DoIew2VXx8pq2u51uoFtaI4BFoARMs3Ve3xe/llbwC1JsP9jvCID4cwpwEht2Y6swUshrpancGvvGfMDl37PF1shYVYzi2MJMSKEaUehxlCWT8ZCw1hTWoh9Tkef9zG+cXuf6ktkWmXH3LkpXhfRXLlNWpiBc4tkVrryh3BQ5P6uFbuq8eMrwxVRsTQ6NDs4fbOL6LOqHdF6iprr15QZaQ== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47210ce1-d1af-41f9-f4c5-08d7e157c6b4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:21.1885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9PMnHxfvb+lFwHmAcP5kTHFUYoYox97m/ptrwar0e+Kpg7dq7ajW3oBaydSmPS0m938dKuuyj8LHXO27TUhqHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1408 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller When the device joins an AP, beacon are forwarded to the host. Once has retrieved all necessary parameters, we can start to filter the beacon (and only beacon with changed/new data will be forwarded). Currently, the driver detect beacons in data Rx process. It is far more easier to just wait for the BSS_CHANGED_BEACON_INFO event. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_rx.c | 12 ------------ drivers/staging/wfx/sta.c | 10 +++++++++- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c index c5b83fedeb55..c3b3edae3420 100644 --- a/drivers/staging/wfx/data_rx.c +++ b/drivers/staging/wfx/data_rx.c @@ -118,18 +118,6 @@ void wfx_rx_cb(struct wfx_vif *wvif, arg->rx_flags.match_uc_addr && mgmt->u.action.category == WLAN_CATEGORY_BACK) goto drop; - if (ieee80211_is_beacon(frame->frame_control) && - !arg->status && wvif->vif && - ether_addr_equal(ieee80211_get_SA(frame), - wvif->vif->bss_conf.bssid)) { - /* Disable beacon filter once we're associated... */ - if (wvif->disable_beacon_filter && - (wvif->vif->bss_conf.assoc || - wvif->vif->bss_conf.ibss_joined)) { - wvif->disable_beacon_filter = false; - schedule_work(&wvif->update_filtering_work); - } - } ieee80211_rx_irqsafe(wvif->wdev->hw, skb); return; diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index ec949ce0b256..b01467f7606a 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -712,9 +712,17 @@ void wfx_bss_info_changed(struct ieee80211_hw *hw, if (changed & BSS_CHANGED_BEACON_ENABLED) wfx_enable_beacon(wvif, info->enable_beacon); - if (changed & BSS_CHANGED_BEACON_INFO) + if (changed & BSS_CHANGED_BEACON_INFO) { + if (vif->type != NL80211_IFTYPE_STATION) + dev_warn(wdev->dev, "%s: misunderstood change: BEACON_INFO\n", + __func__); hif_set_beacon_wakeup_period(wvif, info->dtim_period, info->dtim_period); + // We temporary forwarded beacon for join process. It is now no + // more necessary. + wvif->disable_beacon_filter = false; + wfx_update_filtering(wvif); + } /* assoc/disassoc, or maybe AID changed */ if (changed & BSS_CHANGED_ASSOC) { From patchwork Wed Apr 15 16:11:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215999 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E64C2BA19 for ; Wed, 15 Apr 2020 16:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36E0220656 for ; Wed, 15 Apr 2020 16:14:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="JZSI3B4b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415427AbgDOQOn (ORCPT ); Wed, 15 Apr 2020 12:14:43 -0400 Received: from mail-eopbgr700077.outbound.protection.outlook.com ([40.107.70.77]:38433 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2410247AbgDOQMo (ORCPT ); Wed, 15 Apr 2020 12:12:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aw89wFnFiXyOy1NTj6jt5YzNU+gCB4eia3BTPbQ0i/2EQFNkq4H8cQvtwVoTa9t557hrFly+mD6G57GCJpTc+bN3TihWh3dVtxLQsdo5/w2x/kHFDM2/7LGm22nHIHTzK8ZpOumR1BoJqmWIGQwfH1gja5BQsY5VFk1s6SuA+snLjARBttl4in7WeYx8H71Ej5FFHXQz4dLQ9z7/S2cXqQVH+Gsrb/vaWGjdjUEehEKIwHsz47EPNwbbrNwqH3+PJ053TJuGvmi7S5o3x8+8w+U+x9ugTv5AAlojtuGXV4r8t3uHA3yx3bHnCJUBdLYmHlFXZGa8HzRj6mXho+B8/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXSkXJdfqePl8P54mePNIrqH+SgdP2ay3f4f2zGGER4=; b=dNnDeljbJeSdPSX9FO7yPaXUwiY537POpyzVQNg0Y/AcN5dtFJVBRPU+nhvq49F1xhpKo5UJHcYUyriXyFgfqteTbBqjvTtrKwNi1pifogrVOs57HJCEoo45/sW5BzZG8ZJ1/mQNyyogfLnQHKIk6SZE8bH8LcmtHNynLoLOI/OyZOXRgnLx1dnJo7mjd60KcbZlgc51xp6UVMXnoVeKsdzWoHEGQgt+OkbTFfHuCPGguhv+FZz6y5NU8+ci/3KtfIuXMSkp1idU/MxqWEC3bwU+J06eekOqBylVBHwVre3yZdZy1KZ/ON5Sf2SnjTEY/f343WT4+nQcZQxatltQ1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXSkXJdfqePl8P54mePNIrqH+SgdP2ay3f4f2zGGER4=; b=JZSI3B4bVPLdVy2L86wpoI+JMtvtR0d9eFhJFnoZiyRn0BRhEZIjegImUFWw79zxliLPrm8H9xkgMnhzfNI0cHKfIpF82uVkaclZ6WwJ0sJYl8fZqAy/vGsyD5anLflmlpqnF1BtMAGE9l26fsQ68MHOBG8nZ0jOpfroRLGfmaU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1408.namprd11.prod.outlook.com (2603:10b6:300:24::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Wed, 15 Apr 2020 16:12:32 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:32 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 08/20] staging: wfx: do not use built-in AUTO_ERP feature Date: Wed, 15 Apr 2020 18:11:35 +0200 Message-Id: <20200415161147.69738-9-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:30 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c617be1-2dc5-48f5-0932-08d7e157cda5 X-MS-TrafficTypeDiagnostic: MWHPR11MB1408: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(136003)(396003)(376002)(346002)(39850400004)(366004)(8886007)(8936002)(5660300002)(2906002)(86362001)(8676002)(478600001)(81156014)(66574012)(1076003)(4326008)(52116002)(316002)(54906003)(107886003)(186003)(16526019)(66556008)(66476007)(36756003)(2616005)(6512007)(6486002)(6506007)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Sr7LbRYOVPIULkgTdBv7PPqL+HT9eyOZ03P0Bdqd0LwnI0NpkVe1BuFENrgCivzcdTFuwtnRk8zAhIJGHCjW/PnON2TEHX7OwRMjSLoa4fMYwmYTpSJJ0LWHfQjaIpFG4fP9BC+Xi7IDw7keW5+pqHYMnPiWfbNWq8RnpGC1Gvz4q36g0xGyoXm6iIgRWWclzU44DOvvuhf10cLkshmvJANd6qCghOsZtjM2mqv7cJByTtwxWsB23QJuoDxIL13Q9Wb1jxV/3FI9hAyDzN9SfBbCO0IAnYCrcw5D6/U7ZxIC/4zPyuy2c2HAPnNx9azT5xUBvJDYiPi3j9wX/XdHFAhx2nEXvpcSqRChVnUJQsoeo79MTFFwIhtBxkInGzNCcARSA52elTOtGWQGvSHXcVSV927qTPxSsCphD7wBSCiiUBquj4+cBN3VbKXvB/d X-MS-Exchange-AntiSpam-MessageData: NKo+Jo58MEvUvJcCeI9YtH/V9C3ZbeVmILLFz7IatnV/51eMNVy4/1Qur67KLEsWdAnI/GKhr84VR5Qg7uSAI0E7Op/+WCaMOwQR70fu1HJSRwN7zNP6wLRQyaiDPpBKFGSnbhcd29tVZhgMwCyiQx3v6jE4wL6G0kDrVd8ES1vSd6Au4uv+mf4BogmsGlL89aBGhqUGRuNVbIv9wZM2ig== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c617be1-2dc5-48f5-0932-08d7e157cda5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:32.6693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A3DVQMQ1DLeYTQAIAg+/wIQCaA0L7XvHQNcDnQ3HknUDColZ95+Iu3J5cwcry1xnhikYstW5uVfu83/6q+orKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1408 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Firmware is able to detect detect changes about ERP protection in beacons and automatically enable/disable ERP protection. However, it not bring performance improvements and we are more confident in the ERP handling of mac80211. So, the patch disable this feature. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 7c8ebd76114e..0b2ef2d3023b 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -147,10 +147,6 @@ void wfx_update_filtering(struct wfx_vif *wvif) if (wvif->disable_beacon_filter) { hif_set_beacon_filter_table(wvif, 0, NULL); hif_beacon_filter_control(wvif, 0, 1); - } else if (wvif->vif->type != NL80211_IFTYPE_STATION) { - hif_set_beacon_filter_table(wvif, 2, filter_ies); - hif_beacon_filter_control(wvif, HIF_BEACON_FILTER_ENABLE | - HIF_BEACON_FILTER_AUTO_ERP, 0); } else { hif_set_beacon_filter_table(wvif, 3, filter_ies); hif_beacon_filter_control(wvif, HIF_BEACON_FILTER_ENABLE, 0); From patchwork Wed Apr 15 16:11:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216001 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3249EC2BA19 for ; Wed, 15 Apr 2020 16:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0900D20656 for ; Wed, 15 Apr 2020 16:14:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="hVcCur3O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410286AbgDOQMw (ORCPT ); Wed, 15 Apr 2020 12:12:52 -0400 Received: from mail-eopbgr700077.outbound.protection.outlook.com ([40.107.70.77]:38433 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2410260AbgDOQMr (ORCPT ); Wed, 15 Apr 2020 12:12:47 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6182+L9AyRlyyXJW+3iFVmhhTKq/5SFWxCkJVeoBNPSBxYgwVqKYrvJh47jb8sXkNhDVFRj8LpVG9CcQ34pz1kgLxKdHWD9eUqLUD6juJmG3G9LXYSCI4s7045mIMPP1Y+JQN7xa5DghEYwcREtWZp9XqkvSgE4rxy7SefmkbPlvtlaYLo8oCK40UP3DnZ//nHVOiy84V+rxZTg6P2mdvcoMPcd5I7pakSGTjIO1COkqxtKdet1CITtKfDXETyzcCvoeOl/Z0JSeYotPZqogcd0dF1rO9ZMx/gB6MD5+1bCnMdP3yGEHRvVhb8WPiZEL2wxGgpnBxDbOLhMqYoftA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/GgTYWIabQecCI7PUZfPoM9nNc6ZjdlRRo9IajxQppw=; b=R/PbykHEmbSjhK7qUAvRBPi5KlYfjNBWiY7u/2St3JGtJnb7eGbgLcXGUh5kTaxdSamHrm7O0jTWO/FQaaOWSdnaWcm9Zn6EUBBggLEuD1LiDWguSybaf3vgbSgDqsH/7e0oEkT186GEcolJvT630p7L17YV4a9zZL8UuZVvd1o/dURT8S6kND4YZ7mCvslRDgTEd+b/VY6x3qKCapFYAUshTTlXvY/Q2+fNKui56gpNmkhnI/Wi18ALd+yRXWBeMnZHgQztUccDNu9NLPHtHwmUeeQ/+V2IL1E5+tp/+1FZgL2oaDpX1fPc6zWCKUlNykBB7cUjYoogUjqVLJWUtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/GgTYWIabQecCI7PUZfPoM9nNc6ZjdlRRo9IajxQppw=; b=hVcCur3Om5eSyV4o5FNHipaMDP1SuXO+sSSyfMOWvgPUElf/Pc95BoLi/FhGCblAqiePKbIKXsJOsYEvNXF/rfTfX/PSe4bCIFbc+PRBXfniWy3dJlVAaRbX14DyliiSuk2WDcSG7FccpkAAmFa3CaOf1Lx9QrPYyBLsxwGztVM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1408.namprd11.prod.outlook.com (2603:10b6:300:24::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Wed, 15 Apr 2020 16:12:35 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:35 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 09/20] staging: wfx: stop changing filtering rule in wfx_hw_scan() Date: Wed, 15 Apr 2020 18:11:36 +0200 Message-Id: <20200415161147.69738-10-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:32 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b14572a-2c9e-4600-78dc-08d7e157cf09 X-MS-TrafficTypeDiagnostic: MWHPR11MB1408: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(136003)(396003)(376002)(346002)(39850400004)(366004)(8886007)(8936002)(4744005)(5660300002)(2906002)(86362001)(8676002)(478600001)(81156014)(66574012)(1076003)(4326008)(52116002)(316002)(54906003)(107886003)(186003)(16526019)(66556008)(66476007)(36756003)(2616005)(6512007)(6486002)(6506007)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jh12hm997oRmI0gUR2Ph5zCOBwwWno6Jz+Le+QSLbxBefb9UPf/6j9QvqHuQCSCfP8dO6+YpvNLECrXmAGD3X8kUnsrxcA0IwqaqvZI0eWr+IQZoWed+aDbszb7JYE5HZ2rz4M53UzdlGKgeuwsO3UJ52pZy/dVsUii9mHMMj+vVUTfEbXpdEyuxPBMIi2N9NU+ZklB7JEyDNag9LcevODA6AXH5w2/J0+R/lVrzk68EJhbeNexuwcydnbl5+DLFokLlkaJaGlBPmqZ8inQvt6RbLmh146UbZeU0gwAMXzYGRFsGJFHxYJ9wqBXJlOGeEjQOtm4TmHlOgLAU5cww78hZnWsbcl02WomTChGzNbKk6agXO0yoqm4kgZng+LanMESthMi3orFaV4c9US7N07ZMx7iMkW2IEsHBXn4/60OTLXhTg016G0W4sJdXfn4p X-MS-Exchange-AntiSpam-MessageData: kO8pTUS0KVhMRgpMuMUbKeWjalWIf9S2qBTP1Tl8Es6d8Tj0CaiQt+Hu3mVwimV0xSzWIyPRONaulM9cDgkwWWkN5SyyhLYLPe7GPCRx3hDfS7v5KT429ZeSqgK7jFFn66o7KfZ6SVsawActD4vGQ5DiBrAZOzVHZjyjXUtbMN+wu34gnZS7TmElfIFH2Lx8+iWP8HsvG6d9hrYu7GbNNw== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b14572a-2c9e-4600-78dc-08d7e157cf09 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:35.0922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ApX7y/UCqVb9mBWkvKwvd07U7QfxSVFVbzv61/E7prQuUgIFlDzjKfMaie08JpUw1nF+xndp3KUdXSHs8z/2Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1408 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller It is not very clear why driver ask to firmware to stop filtering probe request during scan. It is particularly weird because scan is not supported in AP mode. In add, it does not restore previous filtering state after scanning. It seems to be a mistake and should be dropped. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/scan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.c index 0c7f4eef045c..276fdacd7143 100644 --- a/drivers/staging/wfx/scan.c +++ b/drivers/staging/wfx/scan.c @@ -89,7 +89,6 @@ void wfx_hw_scan_work(struct work_struct *work) mutex_lock(&wvif->wdev->conf_mutex); mutex_lock(&wvif->scan_lock); update_probe_tmpl(wvif, &hw_req->req); - wfx_fwd_probe_req(wvif, true); chan_cur = 0; do { ret = send_scan_req(wvif, &hw_req->req, chan_cur); From patchwork Wed Apr 15 16:11:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 439E0C2BA19 for ; Wed, 15 Apr 2020 16:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17EED20656 for ; Wed, 15 Apr 2020 16:15:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="Okii4WV7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415445AbgDOQPZ (ORCPT ); Wed, 15 Apr 2020 12:15:25 -0400 Received: from mail-bn7nam10on2054.outbound.protection.outlook.com ([40.107.92.54]:6037 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2410244AbgDOQMl (ORCPT ); Wed, 15 Apr 2020 12:12:41 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqDm9owojMYMX/hrwgy1cVgcCMS/sSUvFuqP4b0TW4NeJnH4N0at0GfOYBYd6PMpiUQemeU13+3crqOQ0svIRRj+rqmj1xBJT6pkTW2tLcCul/UtAxOIIf9atIRe6MouPx7x0hyWN9tb5VKeksGUrvYUu663vVhBsT0j/w5urNdUeFvBqdFfADlW8Rn89gFTKZ1Y40NVTZK+hOlmQanS9iXTIyID7Zz4XTsRuHXgQeh0v5G7mnKoU3N7smv4i2s97EyMo3kbwF6kAnLjrczcFGjs7Fm5mK/8wnI2Tgd7ju2PRJc/LCnejn2zNwdjOsdC5vcZLxAt6RAe7hDq2neD6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9nxtLj7G7XHMe7btmeHWLVBb66C5a5GyMZEEY3gGfKc=; b=mH6HMefeS1tOTD2aSLSd1fkGnbhp0Gvd72kskPwOUF/DPq+FQVo+g8oii6AugniOXJnbWfbUlv0G/36lgmGAkb1uSCaMny1/ROzKKQi6Rtdw623nJbF2O29mBzp+0bS2b0txEgAoD+pRVPa1ujCbWvXOWv87V6HhZ9jVMHeJM8HOves4gXIw3E6cNyW0pO5uBQYooijOtQaPSdauxOo29p9dXy6r338GJ0r67pOjoffZZ+O6wzbXAeG9fpccTre5d09EIT2Vzx6QGomWL3lZqZZsrLPtyWLekhNJUriZ3b/v3os4D1MloGmUoCbbpdaIYuKEItNLLlK0MlRFkOWJlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9nxtLj7G7XHMe7btmeHWLVBb66C5a5GyMZEEY3gGfKc=; b=Okii4WV7JRTVtHBhesSpJe8YDH8sID9P2F+3mt9RDb1POYzxjPcBV2tSWOh9C5rqglphQEJbLz89SRwhBwN0AG/0XMzThbNpSb6qyNogdZEpMQFlYeLRrdAVwNJP6VkRzOWgQDqCXZd94MeZr+waN/WBz201VYPkdPvP7god4ls= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1599.namprd11.prod.outlook.com (2603:10b6:301:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.28; Wed, 15 Apr 2020 16:12:37 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:37 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 10/20] staging: wfx: ensure that probe requests are filtered when AP Date: Wed, 15 Apr 2020 18:11:37 +0200 Message-Id: <20200415161147.69738-11-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:35 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e33c508f-29e6-44ae-d460-08d7e157d0b4 X-MS-TrafficTypeDiagnostic: MWHPR11MB1599: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(376002)(396003)(346002)(366004)(39850400004)(136003)(4326008)(66476007)(107886003)(81156014)(86362001)(8936002)(2616005)(6512007)(6486002)(316002)(52116002)(66556008)(66946007)(6506007)(8886007)(2906002)(1076003)(36756003)(66574012)(5660300002)(54906003)(478600001)(16526019)(8676002)(186003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B/cicagr4l+JnqMyR1SA353fr7oCh+XlYbeD/hRppwtTjt2jEjpUpMwLK6i1zsBWLON/sJS0s0HNyuYXsjCFxJSFa3qIcBg9hxvkBRs2Dl7uX4DalitJGUualO9oHLtCkJTDDJGsMTPP8KWnPNaSF3d+5cVGzhtvFjvy2jTmpkNBO+I8SfkDz7aFuHWrB+z/goZcmlspDQ+PP5/z6E5zAWirXDfELbExW+YpbAks7FCDyAyC49PfR9+qe8FzvTjT6kgEuZfAaSyQbfnsjooQiaTWJlqSW0E2F/xk+U5Ja4m8wWjvFncr9rKI1NOb88zCPJ9vEAeKcMadOV7ODsumeDrCkor2JHPLoAQXkudiM8JQ3fGdMr1hZYsLZLC/2kXbc2bzrzGpSs3JYyaRGiT5/WcCsB7x0UjkzEVXac/DqkWTxJXLkkE3h9c8RaHrNkmL X-MS-Exchange-AntiSpam-MessageData: /73MTPv8s1zrdRgheHZ8ScoJ0oZxze/PFaHSe7Vuu9k9Xj/MCC8QEj2BLuQvEPJe8RFB4vq27b1s+t702GpNtpsIEmNN+7rLfQXAEk9cGjLS9cYw5ZnOg7gSc/H7Y96H3cOSWhxb7Kb703B9tUyItbVsfq5sSewaOOsOldTX/fUvz7Mn66T0tdJD/8w+tdSE7oJQUwmP9E9vH91CWjKPqA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: e33c508f-29e6-44ae-d460-08d7e157d0b4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:37.7110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8D7tuwZ9TNJugDx5tNPj/mqnH1E7w4KUOsoLQ1e/AzbX0BsAUoYJ5wjjGTV8+qpVxWuSrjv3L6gvd4x3/NzuYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1599 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Device is able to automatically reply to probe request (therefore, the probe requests are not forwarded to host). This feature is enabled by wfx_start_ap(). However, further calls to wfx_configure_filter() can disable it. So, relocate the handling of probe request filtering in wfx_configure_filter(). Note that wfx_configure_filter() is always called by mac80211 when an AP start. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 0b2ef2d3023b..b785b1b7d583 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -241,6 +241,13 @@ void wfx_configure_filter(struct ieee80211_hw *hw, else wvif->filter_bssid = true; + // In AP mode, chip can reply to probe request itself + if (*total_flags & FIF_PROBE_REQ && + wvif->vif->type == NL80211_IFTYPE_AP) { + dev_dbg(wdev->dev, "do not forward probe request in AP mode\n"); + *total_flags &= ~FIF_PROBE_REQ; + } + if (*total_flags & FIF_PROBE_REQ) wfx_fwd_probe_req(wvif, true); else @@ -577,7 +584,6 @@ int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) wvif->state = WFX_STATE_AP; wfx_update_filtering(wvif); wfx_upload_ap_templates(wvif); - wfx_fwd_probe_req(wvif, false); hif_start(wvif, &vif->bss_conf, wvif->channel); return 0; } From patchwork Wed Apr 15 16:11:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216000 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058D0C2BA19 for ; Wed, 15 Apr 2020 16:14:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D250520656 for ; Wed, 15 Apr 2020 16:14:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="T9oG9EHA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415398AbgDOQOd (ORCPT ); Wed, 15 Apr 2020 12:14:33 -0400 Received: from mail-bn7nam10on2054.outbound.protection.outlook.com ([40.107.92.54]:6037 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2410266AbgDOQMt (ORCPT ); Wed, 15 Apr 2020 12:12:49 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gmdcbN2X22IRIYvAaFD6rV8G77/wY/mw9hAZhc/yVAjD6w7YeTrJL67E1+vU7ZUFMseSN5MdInsjwTPuotko2lI8HhTllLN9Po65fzAw7D8KmLwQcvJKTxLeieS9kwQwFGIPNPu8kKBryihDUz5FVBnBdQ3YQkMxOL+yUy1CCvYnjFjd2BD/qnRCHBESzM9gYTEn12yAkIiN4O0IGs/jPoVMmG8Jvh157Ee32lSvXDH8yWqg0W1t8M0ecFg9zKtJOQyPldNpj1/njJ4Cg9VTzQuE6tfIitH3AzLZCjKkhM6nfS5h3KqpfKVNizN1dxamKzCLknYKAGfFlwoouwmEyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rK17iCaJqdfonxdRRm6js7bY5I5PDEuTiddcxTRb2M0=; b=VPTMlIlDv/RT73xFW/HaqKklDNdJnOAIvFxfddpG5cEQ7Zgb8FNEXhjC4rz0GdqAQz+NKXn27l/753eL3fIQQYAtvYPjsZQuJH5RuClrYPROePsXAfZA+1wgfwULMiGcOtHVwVOM+TCRLiPaqV3e//xmlbQJlSiTlsKQCZoVlwJBgK87V7fVIdr/Ixjze3yePEhCiDJQk2Ie76uKtq3+xVSQZoQYaIsy2cYnYVxxkaAcITo8ODxzD3PoUb+BLcPw2+486qwZciwHQidOlOTC7xfjk8H1bT47vNm3MQMqWYmiG2J7CH98NPG090og8YmAxo5xzdr2xFPwA7mkpC1t6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rK17iCaJqdfonxdRRm6js7bY5I5PDEuTiddcxTRb2M0=; b=T9oG9EHAxuL4p4zYhVzzJFtetK9vgnunZSGVrGQnU1VLLBmCpnaEGCHEa3CamAo3HDNldZ3m7ShCH7QR7r4GaJ/T3A0PqXB63fF6KcrL2W35pLv7c5XnzNf02LiDj5et2u+e8+Swatk2JjzONyV4LWDVtdVv9XBF2TNoKfiIBr8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1599.namprd11.prod.outlook.com (2603:10b6:301:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.28; Wed, 15 Apr 2020 16:12:42 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:42 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 12/20] staging: wfx: align semantic of beacon filter with other filters Date: Wed, 15 Apr 2020 18:11:39 +0200 Message-Id: <20200415161147.69738-13-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:40 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12467678-01af-404a-bc48-08d7e157d382 X-MS-TrafficTypeDiagnostic: MWHPR11MB1599: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(376002)(396003)(346002)(366004)(39850400004)(136003)(4326008)(66476007)(107886003)(81156014)(86362001)(8936002)(2616005)(6512007)(6486002)(316002)(52116002)(66556008)(66946007)(6506007)(8886007)(2906002)(1076003)(36756003)(66574012)(5660300002)(54906003)(478600001)(16526019)(8676002)(186003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ZIlRigiESqv+m513K7CPYI0ZnrwEVmbqyCH34GWjVTBX0yJ/bsKFZ1k5+ObIgkpnFPN7thCDGIS2TvXMlqlYYQO6ApxKqMe+/hMVfA1yivc7kiLTWoTAYEBENvkpyAIKr/xGf4msni7AOeYDpLGQZrI6onZydQt83xFR7MF7to7oQd0mbO2gZR37EhMUPWX/NBKQF1ANZYKno7cXFbiOkMugUpfgtbjPuGEblsRIurrxa6hIJ6TiUWXOmSRnz1uUXWnz7CKBdTRU+BG+L7OchIk0DSjT+9qNdaKZ403gK2Fcm3f3UqkVdMhjABtmBEw+CmOjUWH+BJeZm9AB53lhyuOly2ljDATaFPDhlQDDI1sarYid0lL5q5PbBa1pGBXe3cy3uA7WTO3R4y6ERZFMEGe0lvf4pUv0qZL6JJX+7eJ2dQdEufksN5eXkPRdWzJ X-MS-Exchange-AntiSpam-MessageData: ac/QGJl7KmYU+ofPP0aahHv+oiGZULvwnNqjmTLwPXz0qg19D6lr4PzM/9YcQVgDI6jiLG2OQi3OaZjqJkLwxk/Itb5bybdym7Yn4UAOJwP5z3qrN5GoAqRwLtqAntzwrqsoNGy5RrbrOD7754dQ/hhYrq8rgTWaSbDI7EEGWeE4t2Lp2anvBMqWfHKlyIf1aMf47RA+TwB2LZTIlPMcFw== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12467678-01af-404a-bc48-08d7e157d382 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:42.5408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YBnkrC0+Q5B8vYxmxecoec5Ua1ko7ULrDI16NlIx6jM9NzIcC5fP4fLHjBbKCxwqmxI9QFz/wnfqEr9mTH7qUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1599 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Filters provided by HIF API are sometime inclusive, sometime exclusive. This patch align the behavior and name of the beacon filter with the other filters. Also avoid double negation: "disable filter" Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 10 +++++----- drivers/staging/wfx/wfx.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 8d2365a2e35b..963cac83b6a8 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -137,7 +137,7 @@ void wfx_update_filtering(struct wfx_vif *wvif) }; hif_set_rx_filter(wvif, wvif->filter_bssid, wvif->fwd_probe_req); - if (wvif->disable_beacon_filter) { + if (!wvif->filter_beacon) { hif_set_beacon_filter_table(wvif, 0, NULL); hif_beacon_filter_control(wvif, 0, 1); } else { @@ -215,9 +215,9 @@ void wfx_configure_filter(struct ieee80211_hw *hw, // Note: FIF_BCN_PRBRESP_PROMISC covers probe response and // beacons from other BSS if (*total_flags & FIF_BCN_PRBRESP_PROMISC) - wvif->disable_beacon_filter = true; + wvif->filter_beacon = false; else - wvif->disable_beacon_filter = false; + wvif->filter_beacon = true; if (*total_flags & FIF_ALLMULTI) { wvif->mcast_filter.enable = false; @@ -504,7 +504,7 @@ static void wfx_do_join(struct wfx_vif *wvif) * Disable filtering temporary to make sure the stack * receives at least one */ - wvif->disable_beacon_filter = true; + wvif->filter_beacon = false; wfx_update_filtering(wvif); } wfx_tx_unlock(wvif->wdev); @@ -706,7 +706,7 @@ void wfx_bss_info_changed(struct ieee80211_hw *hw, info->dtim_period); // We temporary forwarded beacon for join process. It is now no // more necessary. - wvif->disable_beacon_filter = false; + wvif->filter_beacon = true; wfx_update_filtering(wvif); } diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index a69d9c9c37b6..53ed4c137b19 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -90,7 +90,7 @@ struct wfx_vif { bool filter_bssid; bool fwd_probe_req; - bool disable_beacon_filter; + bool filter_beacon; unsigned long uapsd_mask; struct hif_req_set_bss_params bss_params; From patchwork Wed Apr 15 16:11:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216003 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B4B3C2BA19 for ; Wed, 15 Apr 2020 16:13:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 539B0206F9 for ; Wed, 15 Apr 2020 16:13:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="AaWXN09p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415257AbgDOQNm (ORCPT ); Wed, 15 Apr 2020 12:13:42 -0400 Received: from mail-bn7nam10on2054.outbound.protection.outlook.com ([40.107.92.54]:6037 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415263AbgDOQNE (ORCPT ); Wed, 15 Apr 2020 12:13:04 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIOeTWnXNd5YcHMdtFUvOuVWBNOmc0hZjbaAHKhbbElh9OyvCDLNMUyYulXNRD/JhWDFXNjIWIdMzylCIgzhSVgTx74beUJrZB8B90yJWBtzhfkhJx5FbS7sQ06H7P8lqR0jWRZTQJv5IMZJKrtMjS6cWy3UKPY6lKrSOOcPupD3cjsTm975xJfzmUqSxFy3b3sKWGc1Fb1YjQULPHw881UwZFKNycSUMAewxJiieTXHUoGhu6HE0PlA6sKtIF3aJCpKgXz6l/fL/le2KplrEAr2TIhzuEX9U5/WWALdICiJDnslE54TXkX+SjQTVMRJkhf/2nuqzqT55v9EJaImVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fF1c1odyUWEdA7qk8eY48KJgo84mmGoLbVm+zHbzEg0=; b=UV7WcLmMko5JjLsAuCqpUWmsEujVzY9sW8vT4JQLWleMhAlhbxjxsQ8krb65O1jNm7t3+F7OzZkpOsUPOtCVmVvMERDjbVKUIKOi8z8dFqJGelrZMtefE0bTzzDYRd7RmIoM0k78hsLd6jmdVyNma2KaPens8k94JsVJOIfJ7QLPXZ4yUPIVp/O8g9OCRJqWwjpUm88C5leNxZIx0nOmLH8aktCDGEbZ+LhdVc56NOFqDFy0x5v0O1lDJh2CQt8d+h7mBRnFEJg8G+SAvlMg1d43kpy5HUxQPFQb3z3WYwlbahvqcX5G7gR+qm5o6Q1BNVJOYi+/z2B+Pw55DxL3gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fF1c1odyUWEdA7qk8eY48KJgo84mmGoLbVm+zHbzEg0=; b=AaWXN09pHlu6l6xrpJji8UE716iUczqLs8z1Fk/HmpA1TL9lLBunFaCfyC9L8TttFbM/JETlGn4m566s4pb/eBoOHNBc9deAbch0ETMFhNhJJWZiZBAKqLbtOyoNBg6bb2E1HXpn630BZGuGmoP1TXQZp29DwwE0O6srA8oBDp4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1599.namprd11.prod.outlook.com (2603:10b6:301:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.28; Wed, 15 Apr 2020 16:12:50 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:50 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 15/20] staging: wfx: drop useless call to hif_set_rx_filter() Date: Wed, 15 Apr 2020 18:11:42 +0200 Message-Id: <20200415161147.69738-16-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:48 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec2eb62e-35a1-4724-df1a-08d7e157d836 X-MS-TrafficTypeDiagnostic: MWHPR11MB1599: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:185; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(376002)(396003)(346002)(366004)(39850400004)(136003)(4326008)(66476007)(107886003)(81156014)(86362001)(8936002)(2616005)(6512007)(6486002)(316002)(52116002)(66556008)(66946007)(6666004)(6506007)(8886007)(2906002)(1076003)(36756003)(66574012)(5660300002)(4744005)(54906003)(478600001)(16526019)(8676002)(186003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JrXIxa1sJxvXKClEqEwTMHlrTHQ358ARAoi+Yrt+cBLaxauXBz3KENGABwk5S/AzbiswvrjZiR00Gm7sYLZ2zzJJNXmKZpBG3SlZjWeT4unYGMgoZ3cpTSpN3fZGD8YZvk7vAfdpbcZiNu+QYT9WLb+5E031W9oI8dl8J3QRZvB3xbA6Zt4MM9rTfV+XVIEiCQfHvhEA84KYUFiDaI4LW9kYT9lT37AmjYro9ZuH5UQvWVkV07l7PlOnKUErk/P9JVElORO+LU9LTdLjBdCmKJ+6FUCtyW3Av8eSqwy6cX+ADL2us48VJLFhWLrum6vBSOd5COQCJdXu2Xvus2XTGWdHG88Cj9oHBfzfpCCAZA8LAOxnkW8JoRW48Zushr3RgmRwyMeq6PMVhe9mU+d3beduOCQBHZPGMyetJFmZkCBSD9wAIG/8Oy4urkv5ypI3 X-MS-Exchange-AntiSpam-MessageData: m5qFc93zg7Vu5iOVsoKjNXhPjWuFo9n1IkmLDhbYFuNv4Dq7//H2Vu3ua0qQ51sYCWwYE4dpdIDFI5W9YeESrEHBn5hyzdFP5pZjCdNwVSn9jwdHGpS2SGArj5eq+ay6fr86/XTWcrJ/KFXRA7qtx0uKDnAzKzUKP0k1zs5yHt7Hi/YASudHHnME3GPe9iRky42UOawodVEKfOS2hqgkAg== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec2eb62e-35a1-4724-df1a-08d7e157d836 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:50.4902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xf4ZEMEV5SAcI8ozv+DGdujQPzkkDgKVg4DezjpVZS/rb40J5FQMLDb1Dyu/IeGSBOwScy+ao1e9+zNhZrZW6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1599 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller hif_set_rx_filter() apply changes on filter_prbreq and filter_bssid to the hardware. Each time filter_prbreq and filter_bssid are changed, hif_set_rx_filter() is called. Currently, on extra call to hif_set_rx_filter() is made from wfx_update_filtering(). This call is useless. Drop it. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 70342bdd9d96..c7505b5d0947 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -136,7 +136,6 @@ void wfx_update_filtering(struct wfx_vif *wvif) } }; - hif_set_rx_filter(wvif, wvif->filter_bssid, wvif->filter_prbreq); if (!wvif->filter_beacon) { hif_set_beacon_filter_table(wvif, 0, NULL); hif_beacon_filter_control(wvif, 0, 1); From patchwork Wed Apr 15 16:11:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216002 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B10C2BA19 for ; Wed, 15 Apr 2020 16:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0CE3206F9 for ; Wed, 15 Apr 2020 16:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="kK9/gM8Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415252AbgDOQM7 (ORCPT ); Wed, 15 Apr 2020 12:12:59 -0400 Received: from mail-bn8nam12on2062.outbound.protection.outlook.com ([40.107.237.62]:4064 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415229AbgDOQM5 (ORCPT ); Wed, 15 Apr 2020 12:12:57 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRWCcrVRL9gEZO84EI88GPd9wnZwK1V+4XUbOqCa2h8GIfB/KPByxnBdFNbWpOYfD4zCbC/n/qtjmte85MGC++rwg9LuYnLvOGFqcw0um/5uTnMBsot9xgQ/WXkiTNHxwckH/yQC6AGV9fu/56Ls27TjCFtdhOh1iEQoPpS0zKl03ypH9WC05iC0oLovTSr3Gzc/4FQgpJAH4MwTb0Ilkxt8fxPWs8P9OGxY+aZ00CMbnlJ/ryBtYxc9yDi0/f+SrqTiI7RoCLcDj1dZjDSb2vTvePekr9NVkBZa0QmBY3StAWYQyFyi9cBkbuwQNbI4vX+yBZmiJQt0mkro5YPk3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNLfJVzh5VJ31qEn7gbyiYEuSbHzRJCYxbJgsAgxrkk=; b=ihMYL1lEEghaXUNBNB22QzkazDmRWjL34oxbO5GJYhEiex5vDR6DtK3HBKjJJdTD77rgWQfOG0CpInnYKOjIat9PZJbZ8bEEnmhJXKPLuA841lnsiaj4E6jzjKvaMVp1opj90nyuwXHa9jGnG/iEA9h984SKWrQVf/+NKtQJXhA1ov8MfYpqhm+gQ9ER+KqerhOdpbDdBgdlkc8CXi2fjQKNan3zxDL+suvCbUv7BAgk6PQGbpenXoULkfV/7kL/RGPFfXvPZ/MIP27eDDgT6J9CMG+PkL8xfSfrp8g7JWanoQJxTcS04U2UVkYs00iUzfISQoWzBmppapqYE4smhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNLfJVzh5VJ31qEn7gbyiYEuSbHzRJCYxbJgsAgxrkk=; b=kK9/gM8ZdOHvF+JGTj5I3C1xCCtKarUR+I0k0I7PHk6awaB9e0o1inY1l65a+fYDyIUfXxa5LpmkI5GHDOa3DgcVeKJHyBkb/1pC/BOhd/W/jXuQmz8GOuLOvqYHSAK8wkuAJZlpZf6tn98H1kIwanNUUSlPxoaXScsFP48z4Jg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 15 Apr 2020 16:12:53 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:53 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 16/20] staging: wfx: drop useless attributes 'filter_prbreq' and 'filter_bssid' Date: Wed, 15 Apr 2020 18:11:43 +0200 Message-Id: <20200415161147.69738-17-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:50 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5b34595-86cb-4be6-68c6-08d7e157da0b X-MS-TrafficTypeDiagnostic: MWHPR11MB1327: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:317; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(39850400004)(136003)(346002)(366004)(376002)(396003)(4326008)(81156014)(107886003)(52116002)(54906003)(8676002)(478600001)(8936002)(6506007)(5660300002)(6512007)(36756003)(8886007)(86362001)(316002)(6486002)(1076003)(2616005)(186003)(2906002)(66574012)(6666004)(66556008)(16526019)(66946007)(66476007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RvU5qAJMv4nCX8E7Mkvbb4WE/ZLu7umW0QyORGO5USwTIN0Bh9LeSRfI4ubmFkRKOZ420Nk0Xu/E038cwWTENY0yyBqJMAhX85LT0xzlf5AEUJrL1JPLLDrS4feVTWNR8qkWwlkaJ2oApOczTxpdfNIB8zv3qTaC3Rwes3c2i+7+PFsAtho6FpTrkAczswdrnUmE7Fbq+7xBZjamDLglbLgSMuwNonO+tnedTRY24nH1Bm6DG4GtJ89YsTniEXjYGY04FrMUU2E8Z9KUJtZC/9p92IhZJ50eOpw3sBd3laYxp4bnU8oPtgiSQjPxa5/Dt0xIxWiFvky3Nc2e4J2SLW6lU0cfqB2qczBoXcxt2vscGzeQF7GKt/YYZNudVAcUYC6tO2aOuUC94QEBlUO9wTJ2YM6xSIKTvI+PbaoP74HhOOUaQ5B9HzXjNj5U8LLu X-MS-Exchange-AntiSpam-MessageData: +CQhcFEbKDIiv+oxAzja5MDfPyrfJZRM41ZtZyUr3I/mTLoE5mQsLTsnP6xcW8f4vE2glOUpz0Q8vhCwCl1aXuNWfCrUoECCjeOBUYfA/4cW0N30fL2PrRjeNyTBYd/uB+4abiwGLZMxSBDR4CaXt564DzHgwxflel5AqR0xFhP4djbXWe9v8otLmn2uQLXzyR7+EtVWNTj64+EMfSGQjg== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5b34595-86cb-4be6-68c6-08d7e157da0b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:53.5588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U76nZlfXbO2Sm+/5omj7Ox5HrJZNYwjGyLap6wpSHSJd1l7dPAvm8E9GXgZdBGcZ+SpwVHNbao2jrcev6qbWaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller It is now useless to store filter_prbreq and filter_bssid in struct wfx_vif. We can just pass them as parameters to hif_set_rx_filter(). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 12 ++++++------ drivers/staging/wfx/wfx.h | 2 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index c7505b5d0947..a9261ef4b4c5 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -194,6 +194,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, { struct wfx_vif *wvif = NULL; struct wfx_dev *wdev = hw->priv; + bool filter_bssid, filter_prbreq; // Notes: // - Probe responses (FIF_BCN_PRBRESP_PROMISC) are never filtered @@ -227,9 +228,9 @@ void wfx_configure_filter(struct ieee80211_hw *hw, wfx_update_filtering(wvif); if (*total_flags & FIF_OTHER_BSS) - wvif->filter_bssid = false; + filter_bssid = false; else - wvif->filter_bssid = true; + filter_bssid = true; // In AP mode, chip can reply to probe request itself if (*total_flags & FIF_PROBE_REQ && @@ -239,11 +240,10 @@ void wfx_configure_filter(struct ieee80211_hw *hw, } if (*total_flags & FIF_PROBE_REQ) - wvif->filter_prbreq = false; + filter_prbreq = false; else - wvif->filter_prbreq = true; - hif_set_rx_filter(wvif, wvif->filter_bssid, - wvif->filter_prbreq); + filter_prbreq = true; + hif_set_rx_filter(wvif, filter_bssid, filter_prbreq); mutex_unlock(&wvif->scan_lock); } diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 53184fe2da4b..310d95478824 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -90,8 +90,6 @@ struct wfx_vif { int filter_mcast_count; u8 filter_mcast_addr[8][ETH_ALEN]; bool filter_mcast; - bool filter_bssid; - bool filter_prbreq; bool filter_beacon; unsigned long uapsd_mask; From patchwork Wed Apr 15 16:11:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44787C2BA19 for ; Wed, 15 Apr 2020 16:13:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D67C206F9 for ; Wed, 15 Apr 2020 16:13:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="frVDpIDi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415275AbgDOQNG (ORCPT ); Wed, 15 Apr 2020 12:13:06 -0400 Received: from mail-bn8nam12on2054.outbound.protection.outlook.com ([40.107.237.54]:6138 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415244AbgDOQNA (ORCPT ); Wed, 15 Apr 2020 12:13:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRhExUrctMZxxmugiV57+YkvEAV8rFGVWXsb7NcmOjOwdIzDBo0R5E8E/F2wCQcqWwjrQav1+2LjEErRMWC9q+A5hWOYkN1blLd3HeJmDF1312xODFoYQv4pYPTz1M+5HUpUnT4eqVdruR6v6K0YBb71aziWRjRxmmb8bm0xgPVmvFoB//D9KwxwQNWHLY2oeHDBpmAKRUzO1Zwwnj//FnXYYxTANiRaW61D6Dx43C8+Zhv/zozOAyB2PwaF6+SCtFGh9boYcppUakoo8veHxIpfJed+hrYKpETa9e7jiC2agLcdAlR2ilcyBa8ZEgFwWeXWvqv136xCYKZI1jxg8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsLs1OxEeKp373acEswvEzW2lwt+yt9ZoQQ9xvugGxc=; b=CErpnoB3ydnf5AwfRodH6hQ9idkEY9vP9eN6RjrpLGOdSGH8Oe0H68jA+mf1ourRDcHBaLj8n/ljrl8dwNsmlLi1md2hky8yvXJFhKaQfT0hRdYHl5IlSZd182KyDLvhuQjvDhF1iZHhDp9IzuMzUXjCvM+9E2Yz+ZyFvIdMIv9687Tv6uK9z2mutVVQRe/eDQTOofSAFMysZ9Dob6APLiZS4A+rYJGKI0qXTLvZi75RCtz/FajPYDrTJvXlr+zT6rMEIrgbf933PRDBtK7UbZe5iWHQ9nUHh2c0uH4RMe2aE5vwhJv8GHNdLM9xT+K/F4dbBM77BT3nsD/vBKZyzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsLs1OxEeKp373acEswvEzW2lwt+yt9ZoQQ9xvugGxc=; b=frVDpIDi/GshSU3iwaa3n/84W7bQyYS4otzWPuPP3PrU0kNNwdyJKUGczHMSPmFx6Kf+zjxLAQV3lO+qQCMVAq51TMab3y0XC7Qgg6aR8sYNTMwtaSMBheAgHJE0nOlsPZNoDxvzTsiPxBH1T+8boeqzPcIMEZFQ3ilxXxL55dg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 15 Apr 2020 16:12:56 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:56 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 17/20] staging: wfx: split out wfx_filter_beacon() Date: Wed, 15 Apr 2020 18:11:44 +0200 Message-Id: <20200415161147.69738-18-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:53 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea04f042-a629-4c60-e80a-08d7e157db9d X-MS-TrafficTypeDiagnostic: MWHPR11MB1327: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(39850400004)(136003)(346002)(366004)(376002)(396003)(4326008)(81156014)(107886003)(52116002)(54906003)(8676002)(478600001)(8936002)(6506007)(5660300002)(6512007)(36756003)(8886007)(86362001)(316002)(6486002)(1076003)(2616005)(186003)(2906002)(66574012)(6666004)(66556008)(16526019)(66946007)(66476007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O2Lp7+U/OT/rMJQBeD0/iBf8c2b/yhzRtiCQNs+i48TsH3kW3V4lGONUcI8DosZPexZKXibdizDt6QyxBvMQBQZlxP3B/LZlhSY1BgDUSibI1ExNxo1dS+E5CCkfBBS1OW/i+MsgrH4UbE37CYm/ESlfN0w0tQSqaM4YYcDLpP9GONWUvoF2UEfSj6RKWsesVQsrZsbr0yd+OZfR8MpW6FGpLy3GAZ+jw94UuJHlIVavP4dsn4PxM/1UcrpdM5kTozJRXtvJ1jLtBxKINWlOgXxelbwsjnY1kZZzhcJTaCr17Ix0KkvbJ0PxK9teYFreYNdoCtaR5pompl+Vg1D0B4Eo0xtePjL4HBpIzaYZZdHRaxhKCRh36XG+YmOZccWV5yLW8EXovjpY+OYjTBZYyAb0jDq70jnb/XX+HDHLwUnP9gbRNzFCjH6PiMRSNjcY X-MS-Exchange-AntiSpam-MessageData: 05Osgtzraxa5JC0PyCJDDxDkke/AGxh74JWqKTJRwrdYsv3urwAdvrYes4v8gcVU3Ee7T2MwucWTmg/nmOZGLA5mYV8vqzTdf1/2xGe8RIYq4mwpXNfJiclDXt5bDxT/nZ8Mn4ihRVDEAQSR6md0J/u+4KJGHVI7dVvWPXPpA9kEGbYBUp8p8b7oU504quxt3T6QwBEYOAxwuncruHlidg== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea04f042-a629-4c60-e80a-08d7e157db9d X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:56.2256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: isU5zsJC5pe/1+Sc0h0ujkpKofWmY/dSbC0oxiA5pvJOOQl9z0YXYmmzKej6I/xELhKERMCrn3SYON0xN7MH2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Currently, wfx_update_filtering() is sometime called only to apply the value of wvif->filter_beacon to the hardware. It is nicer to have a specific function for beacon filtering. In add, an attentive reader would note that wfx_update_filtering() is always called after change of wvif->filter_beacon. Thus, it not necessary to store filter_beacon in the struct wfx_vif. We can just pass it as parameter. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 23 +++++++++++++---------- drivers/staging/wfx/wfx.h | 1 - 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index a9261ef4b4c5..1ccd40a3322f 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -113,9 +113,8 @@ void wfx_cqm_bssloss_sm(struct wfx_vif *wvif, int init, int good, int bad) mutex_unlock(&wvif->bss_loss_lock); } -void wfx_update_filtering(struct wfx_vif *wvif) +static void wfx_filter_beacon(struct wfx_vif *wvif, bool filter_beacon) { - int i; const struct hif_ie_table_entry filter_ies[] = { { .ie_id = WLAN_EID_VENDOR_SPECIFIC, @@ -136,13 +135,18 @@ void wfx_update_filtering(struct wfx_vif *wvif) } }; - if (!wvif->filter_beacon) { + if (!filter_beacon) { hif_set_beacon_filter_table(wvif, 0, NULL); hif_beacon_filter_control(wvif, 0, 1); } else { hif_set_beacon_filter_table(wvif, 3, filter_ies); hif_beacon_filter_control(wvif, HIF_BEACON_FILTER_ENABLE, 0); } +} + +void wfx_update_filtering(struct wfx_vif *wvif) +{ + int i; // Temporary workaround for filters hif_set_data_filtering(wvif, false, true); @@ -194,7 +198,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, { struct wfx_vif *wvif = NULL; struct wfx_dev *wdev = hw->priv; - bool filter_bssid, filter_prbreq; + bool filter_bssid, filter_prbreq, filter_beacon; // Notes: // - Probe responses (FIF_BCN_PRBRESP_PROMISC) are never filtered @@ -213,9 +217,10 @@ void wfx_configure_filter(struct ieee80211_hw *hw, // Note: FIF_BCN_PRBRESP_PROMISC covers probe response and // beacons from other BSS if (*total_flags & FIF_BCN_PRBRESP_PROMISC) - wvif->filter_beacon = false; + filter_beacon = false; else - wvif->filter_beacon = true; + filter_beacon = true; + wfx_filter_beacon(wvif, filter_beacon); if (*total_flags & FIF_ALLMULTI) { wvif->filter_mcast = false; @@ -501,8 +506,7 @@ static void wfx_do_join(struct wfx_vif *wvif) * Disable filtering temporary to make sure the stack * receives at least one */ - wvif->filter_beacon = false; - wfx_update_filtering(wvif); + wfx_filter_beacon(wvif, false); } wfx_tx_unlock(wvif->wdev); } @@ -703,8 +707,7 @@ void wfx_bss_info_changed(struct ieee80211_hw *hw, info->dtim_period); // We temporary forwarded beacon for join process. It is now no // more necessary. - wvif->filter_beacon = true; - wfx_update_filtering(wvif); + wfx_filter_beacon(wvif, true); } /* assoc/disassoc, or maybe AID changed */ diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 310d95478824..c30e6984aec1 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -90,7 +90,6 @@ struct wfx_vif { int filter_mcast_count; u8 filter_mcast_addr[8][ETH_ALEN]; bool filter_mcast; - bool filter_beacon; unsigned long uapsd_mask; struct hif_req_set_bss_params bss_params; From patchwork Wed Apr 15 16:11:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216004 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060F6C3815B for ; Wed, 15 Apr 2020 16:13:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D611E2076A for ; Wed, 15 Apr 2020 16:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="fCxQBa+h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415323AbgDOQNd (ORCPT ); Wed, 15 Apr 2020 12:13:33 -0400 Received: from mail-bn8nam12on2054.outbound.protection.outlook.com ([40.107.237.54]:6138 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415293AbgDOQNT (ORCPT ); Wed, 15 Apr 2020 12:13:19 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jpXGtCFGELEqSPYIPzJfzget8T7ZEk1z1+RCOYaM+rd9kK8+aNfgN5rRHhuKjTVqOY+r9pykab2jwpPFMWBfGo4JLIlFO48EhM3kV78gh6CdrY3Ll6C3V7axBxUoJxjxy6kn466y7OBIbzDq7vJPMmiwtKiK4JAU6JPdJ2ft7RFOtSwTX0NTnlFYUw7+3XGoDs776TCkjMSdNbIC2OUCSvZCyJXlKxRocaWhXri+KvsSxWZosw5kZa4t6o6zY/mGySTMkHLs2Zedlcpm73HBUhxaqXK8VdxCAfqPNEZsejNF4Uj+KLCz17gisiuHO+/tJHnzFNv0Pm8JIBRRZ1NQMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xMMpG8gnISmIROGGpUscDAlczvuyFeJmquYoEVpkyCc=; b=LzMRUz1SYcRd2U+L/akzoL7CzfaRb3XW2VbKaBloheFyRq7RQNvHIUmUWdj2LzZMy8JnDM2hk8gQDybqMPqBYhptHWWdIHZVgdcGTIk1DBw1rwv076QGV8NvVjo/gnI/d7LvB7sMzi9pw+9tGkFWOtDBqOZwWd3yPak2TuDXkGgz9cyJ/R1SRCM/dc2yWm8JODGkzi+Opqk79BICLUpl/ExgxqxHJSmxUczlHatmF5MXx+CTKT2JIwAy9Q63SuWd+y+zFlBZhXnkAWUJmK2BNP1TqZn7txEC7P9jJtH+qi0fnqpp6Tb/GJZZQI88xvLljHpWvsHU/PGprvjhQI82Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xMMpG8gnISmIROGGpUscDAlczvuyFeJmquYoEVpkyCc=; b=fCxQBa+hQFwVK5FWAA73+Evh7H2VLdOy4+W6tyuUJARgu8LcJYdO1Y7xXTbzGLqKJ8+DS4PKtwq2/5iYvzX9PEN5B/3ppgxiE0C1BxmV204b4YadSvALQCtwMd8/JBQmF/+J3abhEcusuzbdFXIebRfcNaYsJ3Z0/yRATAS2t+k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 15 Apr 2020 16:13:03 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:13:03 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 20/20] staging: wfx: update TODO Date: Wed, 15 Apr 2020 18:11:47 +0200 Message-Id: <20200415161147.69738-21-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:13:01 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1a22fcc-e692-45d0-a3ad-08d7e157dfcf X-MS-TrafficTypeDiagnostic: MWHPR11MB1327: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(39850400004)(136003)(346002)(366004)(376002)(396003)(4326008)(966005)(81156014)(107886003)(52116002)(54906003)(8676002)(478600001)(8936002)(6506007)(5660300002)(6512007)(36756003)(8886007)(86362001)(316002)(6486002)(1076003)(2616005)(186003)(2906002)(66574012)(6666004)(66556008)(16526019)(66946007)(66476007)(15650500001); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KiB6MGJ3LRxuqSR9ScBeyqxStb7RTb+RkengRBAsQ2e0oVag/7uoLTuK7Amle7WzDmniCXO47tFcuPUx02NcPAlvjgLv9PiNg0Bi3JfVLVOLybnzVBI1WUFMXGQFJLrpUoumWVXAjc2dmJJkShPUXlDgG56gAX51R2BxwBVFVCQ+Yljtq6HeKTvLzB4j3gezFbUpAQsFu16yDKlko6LBo6m+TEB5P1Lv9y/003X5eB34PAu3SxaqkzP141WvGjkQIQ1wDfOo16X35JyPDnD6yCwTVvIl8/AflzHmJAWz804/s+WK+zTziwvhn1V5VDp9NqcTc4/wHBr+vLWpDbQcd1/3Dvj6NEOMm4gGBD0UleDyjZaH17zX+eV7a8XUAjgEF6J2iOHvNnKghvlRSsTgHhhydm0oQeQ02vTgX8N0TMY0OvPGqqZiU09twAurTUFiw1tgMSm+WyQ5MREzDm3xucyzlfMAkiQUoif29bCy/hyB4epXdXev4vmEYWvHPLoNuy+qEw8C1BROXWh20YD+SQ== X-MS-Exchange-AntiSpam-MessageData: 3ImYzr2IDHDpw+QGVHWrxWCEaO++cRZ0WTIPpjcWED8fv+atShJRumVSzxW9z6tP3Do7oFvG2sOU0aJiFr4eKi0WRegwbLwv5m26wwQ/oAR4O25qrqT6lIp1twjMwtJx//GpccBmpDtRsUH04Y/qY7QERWUsK76fEqIesbRm3AGJ/fL/+A6bueTJ8mhNEWXA9nZyOT4eEcIpvzn8JrwsNQ== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1a22fcc-e692-45d0-a3ad-08d7e157dfcf X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:13:03.0635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zqMko9GGvsZMwM7qX9CPHvKCC9ctloagB2NdmXMYs5kr1CgS1IskcfnuozwEIjMD0C1TtYIT22z9SLXRAa/Siw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Update the TODO list associated to the wfx driver with the last progresses and last remarks made by reviewers. The items about support for P2P and mesh have also been removed. Indeed, it seems that the device does not fully support them. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/TODO | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers/staging/wfx/TODO b/drivers/staging/wfx/TODO index efcb7c6a5aa7..fca3332e42ce 100644 --- a/drivers/staging/wfx/TODO +++ b/drivers/staging/wfx/TODO @@ -1,26 +1,18 @@ This is a list of things that need to be done to get this driver out of the staging directory. - - All structures defined in hif_api_*.h are intended to sent/received to/from - hardware. All their members whould be declared __le32 or __le16. - See: + - The HIF API is not yet clean enough. + + - Fix support for big endian architectures. See: https://lore.kernel.org/lkml/20191111202852.GX26530@ZenIV.linux.org.uk - - Once previous item done, it will be possible to audit the driver with - `sparse'. It will probably find tons of problems with big endian - architectures. + - The pointers returned by allocation functions are always checked. - - hif_api_*.h whave been imported from firmware code. Some of the structures - are never used in driver. + - The code that check the corectness of received message (in rx_helper()) can + be improved. See: + https://lore.kernel.org/driverdev-devel/2302785.6C7ODC2LYm@pc-42/ - - Driver try to maintains power save status of the stations. However, this - work is already done by mac80211. sta_asleep_mask and pspoll_mask should be - dropped. - - - wfx_tx_queues_get() should be reworked. It currently try compute itself the - QoS policy. However, firmware already do the job. Firmware would prefer to - have a few packets in each queue and be able to choose itself which queue to - use. + - Support for SDIO with external IRQ is broken. - As suggested by Felix, rate control could be improved following this idea: https://lore.kernel.org/lkml/3099559.gv3Q75KnN1@pc-42/ @@ -28,17 +20,8 @@ staging directory. - When driver is about to loose BSS, it forge its own Null Func request (see wfx_cqm_bssloss_sm()). It should use mechanism provided by mac80211. - - AP is actually is setup after a call to wfx_bss_info_changed(). Yet, - ieee80211_ops provide callback start_ap(). - - - The current process for joining a network is incredibly complex. Should be - reworked. - - Monitoring mode is not implemented despite being mandatory by mac80211. - - "compatible" value are not correct. They should be "vendor,chip". See: - https://lore.kernel.org/driverdev-devel/5226570.CMH5hVlZcI@pc-42 - - The "state" field from wfx_vif should be replaced by "vif->type". - It seems that wfx_upload_keys() is useless. @@ -49,12 +32,13 @@ staging directory. - Feature called "secure link" should be either developed (using kernel crypto API) or dropped. + - The device allows to filter multicast traffic. The code to support these + filters exists in the driver but it is disabled because it has never been + tested. + - In wfx_cmd_send(), "async" allow to send command without waiting the reply. It may help in some situation, but it is not yet used. In add, it may cause some trouble: https://lore.kernel.org/driverdev-devel/alpine.DEB.2.21.1910041317381.2992@hadrien/ So, fix it (by replacing the mutex with a semaphore) or drop it. - - Chip support P2P, but driver does not implement it. - - - Chip support kind of Mesh, but driver does not implement it.