From patchwork Fri Apr 10 13:32:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FB4C2BA2B for ; Fri, 10 Apr 2020 13:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FF70212CC for ; Fri, 10 Apr 2020 13:35:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="ZP34UKRK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726679AbgDJNdE (ORCPT ); Fri, 10 Apr 2020 09:33:04 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726181AbgDJNdC (ORCPT ); Fri, 10 Apr 2020 09:33:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C+qR9/kFx9PiB1bvI6ufuB7MLlxITyIK0I6BK1QwoO2LfozWcvMygKuCTgIQgXE5qUY5OahgE5x0ZlsKjMn61K5kXZ57QzRVKHit8rMAvF3T6boa3/RzVKUY0pq37BtpyK8auYdqVFSoFDQ9SBkED7yN1XE6sI6VO73msC9RAXDpFfx1dpIMf77GGhegXsV3Ph3tTcVwmm0CCdKybF5JxtceM7yDYGlxINJZEjzua0mujFjw1I7i1PXHgfMD1tLJGSG3Ib5h2QabRTiNZ53II1655DSsGCf1/XaDyTEuQCVh57vJkpYidjAVhaH+CnbuH0Uav66ugraDYkwa+Z5pfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ReanvtT/cyTujwHvDghjxXROX8i/R50wqYa1At2zGA8=; b=JaUIwTDBmPhL49f9jALR8HUr5Zpx1vTrKw68TBUev47Gg+mYCr4D6eG61O9niOX3o+you8a28167MJHtC3QGE+CG1vI//L3osi+DNFbs1E9oG27HfoV3wudGsgr8LcJAQzQz10xWJZVowXdyuo0v8nyVK1m3o5sKqlYRId8MchmaJvo5aokpNYq7TAbFyBqxLAWdcS5mgPVn3YX/8zTEeSJ4GUq8zf0P0o3UZxLFSZopoRKtfXVqxrj50JBHl/2K+givTH9/sDXTGUQoxHsnrcRzJyA7UMbg65GRdhhGgC65GauRAWd73SclvdPKUMrFr46H2qyEmhNr1cylht28gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ReanvtT/cyTujwHvDghjxXROX8i/R50wqYa1At2zGA8=; b=ZP34UKRK7IpoRxhQNBINdGyk4jaL72rciCR+t3GeDDzeXejGwOF302U5RoF6e9RdTFz7l36CXCUi/vqr7ggz6pjcnBJh0uswsJ5okcRv1ybkjLTZ1sIJHYmx6Vea0pstCSKKU4JeWf1O8hwEOL3e1QDGzkJWdIZYbAZxY7LLNu0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:00 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:00 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 01/19] staging: wfx: fix race between configure_filter and remove_interface Date: Fri, 10 Apr 2020 15:32:21 +0200 Message-Id: <20200410133239.438347-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:32:58 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a4dcfdaf-15c9-4f30-d679-08d7dd53b025 X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v0Wn3IGW6eZ4aNivT+cWGTppfUhEojxQyhVH7xhCU73v202QuuIb4XaZXf+MfwxUzxB13+63o/5LohZ7wotmjgDnRzjqUQ7DF4v6Mld1mfP96E7tUwIhLcTvp5qOl7gqvvqcHsubO77vKaUMWY51Ddxoyuh4yh5gSWi8qFJIgSJEQ4cHElucCH2Avvs2evOsiW4XwcPlAgz/pNJbprobLXmF8rxl+BLrvdZNr7ZFQxLbDezRN/LJBeAi3bib0YdggWtYotEb8+C9Nqmx+XjWcBhk+EUXcNdjCvNDnzQDdhtVZDWBA4vVDLm+XZInFvOqmm9nYeOWwvjAN22e9OaFE6aXiZmyhHUbVA+MLw4hQIkmpVsDlr50KaTakRfCZhmJBXnXKrFbVm1JCtYBJ2N02KYvSziQ5q7TmCtxrGn63f8pPosJi25FVZ+Lzfto5PPi X-MS-Exchange-AntiSpam-MessageData: BV7TAgthZtvpA8E4WnEqdvki/WQfPY7xz5HRgwvRo9EHJlpTaJZZ8gfdg2TRFpJCx13D3eTZQkztOmdMExA54pnl8hPq4SoF8IYMOFINZ4g6O8f1jT+irQrpTypr8rGEuM01wueuy1XVXDnb6ySv+SvYG9tpgncIIMbZsIbu+jaryFQR3eF3+Y5pVXTSGzljg0lb6vfAStlIbxDc0nhYjA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4dcfdaf-15c9-4f30-d679-08d7dd53b025 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:00.6406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ztRYh3Vn6oKwxleerpzGG332KQQQy45A/u8XbkLH5RappaCNLxx/klDndRl1S26e9JlD9qT/0QPL86zJT87XwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller wfx_remove_interface() and wfx_configure_filter() can be run concurrently. Therefore, this patch protect access to the list of interfaces from wfx_configure_filter(). Notice that wfx_configure_filter() now lock "conf_lock" and "scan_lock". Beside that, wfx_hw_scan_work() also access to the same locks. So we have to lock them in same order to avoid any deadlock. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/scan.c | 4 ++-- drivers/staging/wfx/sta.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.c index 6e1e50048651..0c7f4eef045c 100644 --- a/drivers/staging/wfx/scan.c +++ b/drivers/staging/wfx/scan.c @@ -86,8 +86,8 @@ void wfx_hw_scan_work(struct work_struct *work) struct ieee80211_scan_request *hw_req = wvif->scan_req; int chan_cur, ret; - mutex_lock(&wvif->scan_lock); mutex_lock(&wvif->wdev->conf_mutex); + mutex_lock(&wvif->scan_lock); update_probe_tmpl(wvif, &hw_req->req); wfx_fwd_probe_req(wvif, true); chan_cur = 0; @@ -96,8 +96,8 @@ void wfx_hw_scan_work(struct work_struct *work) if (ret > 0) chan_cur += ret; } while (ret > 0 && chan_cur < hw_req->req.n_channels); - mutex_unlock(&wvif->wdev->conf_mutex); mutex_unlock(&wvif->scan_lock); + mutex_unlock(&wvif->wdev->conf_mutex); __ieee80211_scan_completed_compat(wvif->wdev->hw, ret < 0); } diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 4d5dbfc24f52..380e5319472a 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -242,6 +242,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, *total_flags &= FIF_OTHER_BSS | FIF_FCSFAIL | FIF_PROBE_REQ; + mutex_lock(&wdev->conf_mutex); while ((wvif = wvif_iterate(wdev, wvif)) != NULL) { mutex_lock(&wvif->scan_lock); wvif->filter_bssid = (*total_flags & @@ -251,6 +252,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, wfx_update_filtering(wvif); mutex_unlock(&wvif->scan_lock); } + mutex_unlock(&wdev->conf_mutex); } static int wfx_update_pm(struct wfx_vif *wvif) From patchwork Fri Apr 10 13:32:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216051 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BD5C2BBFD for ; Fri, 10 Apr 2020 13:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3F0D212CC for ; Fri, 10 Apr 2020 13:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="VX67xLs8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgDJNdF (ORCPT ); Fri, 10 Apr 2020 09:33:05 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726009AbgDJNdF (ORCPT ); Fri, 10 Apr 2020 09:33:05 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iVCHW1E4NZ/AHZe0s8jNTL9P1+lge74w3qBFfESKstsBAYq2kOJnmjIsXKODZXlB+qZYTiSbdAFXFK/0CovwNnQ1TSH1yZj8aKX/n0e6O0VvbvmLKENwMpwee8GqlSAP3/SDUHqgq3n3jhQATyLw+rOTw59Md2a74PU4Tei5vKQ/alDsfaRc7WJuWDV94QxzmreOFa46Z3pgLLCrOhpLkQJ47wfhfjNwFH24GzzmK1VcK9Zqtbf/wG29LQF5qcVNt+4IzOXZwhFQR6gbohe4JN/b8+xO92LH+gbzzRLoMljGatGWWhMqc/FRqqm/SWgcQnA+OFKN+zb4Jgylw7CyRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kjI0Je6vHCyxCyoGkgaW23q63NlgIf848mcwi2srrio=; b=JAAWpKFi+snyQCNgb5YQDgPqEr22r3elE262YEbXtzFmjOro/kfLC0jXLPKxsNtLsxPmLXtcJiUGtnbc7SLyWcnHgz3N5LOmY2L1FkUXSZnJkp4oMb23Af6VO7n4nhzrHkcB+Alz03n86o53xPn813YAqSq2Uq8BAgv7t563JvRj6PyoRzTjebSlOskV6xt9n3VzpH//sNBCFyAjFFn2+SHtwfzpzl0GxxwWJcOJ8tuN/JPTDgBMzp/S//8irHg/rJm3/Plt6pvk2T0RfkBBk3kV4mVWXrfOQtPE1wDLE/rHjKZ6MN/pk4UXHfzfdJLg2/1H6q6LhCaD7T40hGjCuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kjI0Je6vHCyxCyoGkgaW23q63NlgIf848mcwi2srrio=; b=VX67xLs8IW+KBUOOLDOI5++kIIp3SzNJZ7gBdutMK9tUc833tZAl4CeI7No0UyPgZ/vTbmedWE1qAIMCpp24JnkZBMsOL5xHwZSQ5tJls6OoVwgKJol5hs2tLE0j3+1iyGJh58RgGZXB0DfIOQkKttUE3hkd/Eet0+g/CzwsQNA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:02 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:02 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 02/19] staging: wfx: reduce hold duration of cfg80211_bss Date: Fri, 10 Apr 2020 15:32:22 +0200 Message-Id: <20200410133239.438347-3-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:00 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef8292e6-6543-425b-5052-08d7dd53b14c X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1091; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(4744005)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HYiViTNkZGrUfBPkg5Rf9QZt9JUYs5cVihyvIL9taGXzRLq4OzierheUvyiX9Qoi4N7KvYl19ebp+Lz7llT35Cl3dD+E9UTqlqNCwW+f2WXxTav7M32IIPnm5c015g3fAxZBmb/ppivBk+Y9wvfxEfKl2sTg0cfAP4ifba4AbSbB5NlKqfD2iPW46mW9oyRgItI/X3Xy+oDRHSc17WZwYDecnlBqbVAngkAT0uT1qb3AcLbWvmt3s//BAivGpnrlN0q5e7I1GQ6A6AeWK/CRMRMIeFsbpIaA4afaz9kFMWQaPVwQ8UXQJn/xdeQtS1AL/EEmOJf1jT4++1HgwwuiecbKQ3yuKo4RuMJ+tuLm/7YyEPakciP4nrhlAHj3vx9xyHhd5ggw7h+Rkkq2yZ3wyY4vy4oUDxacEucWnrFCfTCr2ksP0DoUuV3z8z5QtOOJ X-MS-Exchange-AntiSpam-MessageData: W6i06sxqp7r9y5ociy3puoMUyrjLqDCCpy6Aw+N0N74Qu+cNMZUdCL5DoOsjQUjpBSV76g/HYz42OcLBzGnJoKVLLXmkSXKBqWlQXKB7H/LBcjT4X/CLp7rUqzJhfy4exxcSuRztOzYj5PJJhcznuLr4jDa2XNtZOwR8az9uNuSMOmROXRgNU2Z4QkF8edOW1DV2u1Q6qiwrD99Ju8WeOA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef8292e6-6543-425b-5052-08d7dd53b14c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:02.5675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pl+s4sFudDAgNs6/t4nOjCA+0srZtx2fI/wF52H1LRQmh7J5FLFph8vcsxbImkrFPm2NIBJPsZaHUC4f8c+wPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Pointer to cfg80211_bss is held during all duration of wfx_do_join. But, it is not necessary, We can release it far earlier. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 380e5319472a..c65d464a7a9b 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -509,6 +509,7 @@ static void wfx_do_join(struct wfx_vif *wvif) hif_set_block_ack_policy(wvif, 0xFF, 0xFF); wfx_set_mfp(wvif, bss); + cfg80211_put_bss(wvif->wdev->hw->wiphy, bss); ret = hif_join(wvif, conf, wvif->channel, ssid, ssidlen); if (ret) { @@ -538,8 +539,6 @@ static void wfx_do_join(struct wfx_vif *wvif) wfx_update_filtering(wvif); mutex_unlock(&wvif->wdev->conf_mutex); - if (bss) - cfg80211_put_bss(wvif->wdev->hw->wiphy, bss); } static void wfx_unjoin_work(struct work_struct *work) From patchwork Fri Apr 10 13:32:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F5EC2BB86 for ; Fri, 10 Apr 2020 13:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 489712082D for ; Fri, 10 Apr 2020 13:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="V15mqtmZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgDJNdO (ORCPT ); Fri, 10 Apr 2020 09:33:14 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726703AbgDJNdM (ORCPT ); Fri, 10 Apr 2020 09:33:12 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xplqye7VFTMOtvMguqt5x0LP84S1J6YT2H53F2NLe2uBdOcpKkJJZBWksMJqJ8aIFzILiAeXob1oIq7ZFNbvpjxj1OnrvxoirSavuX8EB9KD2tkUSXY+3frwkIEhXY1JW0yn+ZLzurI4Of1P6AJ0IeY/+eU9xFxD8042FK1sPXOgsMuHJqZhvSeb76aiM0oqcJvG9bWB45x9jFFOtHr0hXpB2OnlqXDZDle3IbmS3TVA/ZCelILbYnE9FvTdIxxiaR4N3tQ4EubyjvbQcP58cIRuA7PAWBlUjjy3h8zSXxbqDmdxFVY9YLHAI9dJQ7RFpv7oaCU2Be+4HTrOIrVryg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pLQq6o+gVwbcpjPZoHdr6jmvl/zD0xDyVzifFhX/kQ=; b=ImHb6PPRwCBlNI8GnvpZDQC0SvnmCs5/vP76ZGl0u2y88TX5JErXLNTKA41Zi1NYtA99V++kuv1NVKvbz3NB3oC0RZgNFmcLtWDt4ebyJ0tzKGcPkuNKvfeCP9UCGTpfQm+xezt1C9tzAx+jMrN1aAZ4kEYeVhn+jirnZfPuCPYK/WmFYKrqQkxyY1NlEsRxDIM/GsJtryrI/NExHZ8XodAHhSQVSic4K5RnMpksH6c3vYZWZPzEgJSVb7PJGwJiXW9RWidv0ZvHbmdvrd2HB88LOIkpaSibtSAcZY1dQR+JR6G4ts8d2OKFY54ufNoUGG8rPlCICGB1QKZV241X3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pLQq6o+gVwbcpjPZoHdr6jmvl/zD0xDyVzifFhX/kQ=; b=V15mqtmZ7MEteDfIMZorpRln/6yTG/ehVGUZtgzHYIPGn4RioE/MnIPeTFczymsenQHxDi7d1BanaGNG5O7Omf9gIi9XI+qwV7pkOkULD/8YhlPX2SWN96lY9mq2w2PUvbGs3zC7KPsF86gVcP7mld9td8IX+BaMl0x/mRwlbS4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:08 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:08 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 05/19] staging: wfx: set all parameters before starting AP Date: Fri, 10 Apr 2020 15:32:25 +0200 Message-Id: <20200410133239.438347-6-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:07 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc5f3257-0172-4815-a052-08d7dd53b4ef X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: izLELvSWaS+z+KGfLdC65nbADG9PaHKPzoWklmNzh+gWrQIGlBMoZ249hEnz26bqzNEssvp/kgRWCIqP252Ts5746yZ60fi7wczeoe4pLZ51tTlPlqjMGDOqNNkpr/6eentgLoz8ymdxWTB5FJA1T1Rn2Ga4GxVVjr4YFb9fzmfNNXvyoy8Smf4f8hhGq9Wk2fhp9snBuOhuKHedaGUrCgFtMgK4RBNOnclk22rAaJFjSC4fJ7CjEZentXH0U69GUaTp6gs42bUGq3jozL63OS6GuNkP6+6/+Zbgnx5pEQCYDzU34aj88ZSCOTu1mXTF55V22f78yojk6Y4nP7qONeAmQL8uVLhmu1z+hQKtgc6UG1ifz4SMa7WEOWDni8cLnr92B8d0BCw+psINvzqmxeFCwoWvZ80tVu4o7CEUeXf4ESEkE0E4oI7kRQMDge4O X-MS-Exchange-AntiSpam-MessageData: A/Ukp1BWA4r7UlwY0ynj4sCoqdSaod+AwdylsoAD1Bf08F3PNhbFjECoJ/RBrheEtjufyZ6uSI0h2tVPHs7v1v1O6ZjCSsTyPq8c1e4RB9ZgHaSNBgstYfgA8VhMufxPIDGws0gzLlSYWRNcoJu7BoSsd6EWkyCNV+2nENJTTVBfTbvP9FBjwdasiBWv7inH1jzne4PVtHGfB6r2AvU9bA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc5f3257-0172-4815-a052-08d7dd53b4ef X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:08.6659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q9lFGKOm1IByjgyStqHqUI65UkMQjlHngWPRHb5lsEUffK8mnoimdB4EplfGFU66SPURvVz2VrGp0QP4LaQhhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Current code start AP and then configure the different parameters. Since all the configuration is sent quickly after AP started, it works. However, it is not very nice. In add, last firmware releases start to disallow incorrect settings. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 92bf317b57bb..1e7ff2ba33d8 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -604,7 +604,6 @@ int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv; - hif_start(wvif, &vif->bss_conf, wvif->channel); wfx_upload_keys(wvif); if (wvif_count(wvif->wdev) <= 1) hif_set_block_ack_policy(wvif, 0xFF, 0xFF); @@ -612,6 +611,7 @@ int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) wfx_update_filtering(wvif); wfx_upload_ap_templates(wvif); wfx_fwd_probe_req(wvif, false); + hif_start(wvif, &vif->bss_conf, wvif->channel); return 0; } From patchwork Fri Apr 10 13:32:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216044 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7113EC2BB1D for ; Fri, 10 Apr 2020 13:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E6012082D for ; Fri, 10 Apr 2020 13:35:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="ZsaMrTm1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbgDJNey (ORCPT ); Fri, 10 Apr 2020 09:34:54 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726801AbgDJNdR (ORCPT ); Fri, 10 Apr 2020 09:33:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTHjElsALF1Gt0AhXSaoGIaUGY+fiCY0amaedpjphvjxfDirnFyKtelV7eswOAmFREHnQYsr5YFhxNAOFZsCBM18fagXkQY9p4mkw3qbMb29KIDW5ylGyfE64rHoMgmOhH9REqRXe1St9+reAttbZrSKtUWTaPMIY0+tLjkHD9EhdXtuD/JwtxQeHkuV4Cvvc1Vase/rPb+eizcbeuVZa5ecoprQAeerIFwHD+uOr3nn9I36DqHOOR+LTxGNpcy9lJkmLA0QrQ4cGsERYhCZV2a6/sv85nwzRpiJfWNQ97qKstv5hsN0xT3fsAjli6YhWsmjsmubUlwQ6EnLKSQvuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIZUy/h6rYzymHnG1QdL8KvuWbTsGwdnnb/NhWHB+MY=; b=EAzjcKlXqnPSEPMQA4rZM6PJvgklml498lVLyMfL3PzfAJgsq71G7lpXN42vcMHgrgqPLWMh57vskawM8nBpr+dae0KnzicS83dHKlsjecTaW0cIC+2IMRWLjdLnrRzDGQ7nixsdlknrbDYGuA4msELxRg1ceXkeAZz3SQ1EyIa+Nn1acivysCPvZgBgUJAimWKtuL271EP/XQRhBLsPNWIbU5J2dCHvAj1A1WoM4vV1ls5RBf7jEtgci06BbeNAHvSHOAbC+ikjWdBd+U2mb3iHQfPZoS2bOMfZsVQoVn8BidOZhAuuscA+qGI7g2FfnSSftraOZv4jlf3qmLs3ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIZUy/h6rYzymHnG1QdL8KvuWbTsGwdnnb/NhWHB+MY=; b=ZsaMrTm1F05fpJyefqKxmjCE9to8EBCNIGp3BItNJaykdrRCMHr8pzf4dspiAgVqXpAyJiZanl4y41KnjlW7kNCmMVtToUI3KATZaCJjp22MYsiE0tDhikErXRKBKbtOMmHxtJ71pBljuSPbjqS6aAtAsNmNe1Fvi6Tca73vdWg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:12 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:12 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 07/19] staging: wfx: remove useless call to wfx_tx_flush() Date: Fri, 10 Apr 2020 15:32:27 +0200 Message-Id: <20200410133239.438347-8-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:10 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c02af5d3-a0a2-425c-b035-08d7dd53b71e X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:169; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(4744005)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2nN0t1b3gOWheFtt7aWWG9QQUw72G3p8iKFH39lFEHWBlQ0b7VWhxSotjLzPhUaJokeeq7HDA07/IhFBNwY20d/FmvpzWIw7pEixhjysQrLO2SrKJMYZNGQfwDo+mz2KMzMu80N9A2Oacs3Kl+EFEGgJf+eerKeX6fSVIjvi94u97odJn1yw/EGe8GZcjQa0a2NXx7WsKOKYb4T2UIfEAwX5z25dfrWW/RgR16eyNWgRx/zny3TKs76sM1rm8WjUyaiL0N3+05kmtBDG/Qm+glIpNWwzeuKzXPpWSr6QXxXuG9P1TIVqj8LYo1x2cCd2/ugrPqs4QBwT75erP3QKYzZ8E7fwSDVvakiO4+thGv2ukbxm9yqwPnIn0KdhcASIpkHpk0hoYB4eeHFHAMejt/Peyu2tCcbIZcFNAGaEHOa9HFKoNZjoFsO1y8IT4FtH X-MS-Exchange-AntiSpam-MessageData: 6IbbNJoRZpQUaDOUszOkW7jVPdJ220NNGJp/Uh8BeJerbndm2hHqkFSDL3xKQGXwarmc2m1ZDgRlMPoKf2OqvFhgEeoqzgtSz2LwhFzHQ9NrIj49QGfPQjnuO2NzciPvX40ZfeYYt6MGkOqY68ZgIVuRl47EFTrK18MEAZ/BxIE7d3NIBEVrr/HVff1ACkDiQirP3VpAoP6PKXlS2QzsvQ== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: c02af5d3-a0a2-425c-b035-08d7dd53b71e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:12.3538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qb/wJvDMCnNregBVOfwizXOCpZS4lHPbsir4Rne4WoUkVFyI5AAn8B487uNPuGZn4q1Kug6hXXpQHNc4EYox6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller wfx_do_join() calls wfx_tx_lock_flush() ate beginning of the function. Therefore, the subsequent call to wfx_tx_flush() is useless. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index acbbc3a44733..7693ce22f300 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -493,8 +493,6 @@ static void wfx_do_join(struct wfx_vif *wvif) } rcu_read_unlock(); - wfx_tx_flush(wvif->wdev); - if (wvif_count(wvif->wdev) <= 1) hif_set_block_ack_policy(wvif, 0xFF, 0xFF); From patchwork Fri Apr 10 13:32:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216045 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C44C2BB1D for ; Fri, 10 Apr 2020 13:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CD2720673 for ; Fri, 10 Apr 2020 13:34:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="NYUfbvJe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbgDJNdY (ORCPT ); Fri, 10 Apr 2020 09:33:24 -0400 Received: from mail-bn8nam12on2076.outbound.protection.outlook.com ([40.107.237.76]:32790 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726817AbgDJNdW (ORCPT ); Fri, 10 Apr 2020 09:33:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e45X+I9InV3K9ZuJIfuvX/0mMTQWB+TjJvFL/IHIopXjS/zykl+/mw+7OL6Y30k2czlSNQTNOcbkw8bWNLF/BqmtTCEQ5LfcMzb2c1NNYIiQVEBHwSmgGyGCyx1DqUzAnjr9hnZBoJbNls2L18pSvDFRPnyBJyhJSPQuculWkX2g2tnKBWthN+Ato76fBecW6zB0PE6SpyAWGKmkITcN9lRyQ2rDHTrJrWON6qEIDjjTQbSgj5hvfoCae2tY+OGsYZeYTMcKprtVsIpse527uPWJ7sr63vuqt+m1v83hRjvSNwkenpvfU7G5rAy6dJdUyKjYxkl7/NxWoqKcsliblg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJTAQ/VR5u4yLmSor5pc09/mMk/uKUBfJs00iVDEZYw=; b=IKOS5hlWwc5/Yn/xEFqAQG4dcFZIwrC+P5G5tkS3Y6DSx0GcFs/+EWU0xG83DZ+gb1T+6M5VgeSdVlzf2WdgA1F0smtDN449050y0nVKR9IBKQsaPAWCWI4jZrdE7+oz/BWKcNBR6hRZVUT11fl/MuZxDhBP2y4Q4YehlhW8LqIsPBWo3Wqz6MphsgHnwfCXyzB1SSrNY7u10BC2sgEDA5UnfVv5KkqcdfNTc8T8P87f+vhsbDEY516M3FjCv59yQww5bte1e/GeEvEL35+qOFQfgC2a3mvoc6DRkO+scJLPzQMXjDCYy5xwezMzYg6B+QnsPqrXNF0uHLsWpknMCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJTAQ/VR5u4yLmSor5pc09/mMk/uKUBfJs00iVDEZYw=; b=NYUfbvJef0Z7+J4XiTcfkWk/vXtlqXdG1VL+7azzWte3hWew+J40n7Ei7S2CExnFjsOtZFPkCreM7D8MBctrl8X59chFQg0HxKGcPy/I7NgbrC4gwBKH/Z22nnFpt7Me4Q/hojvvATyL6FaqFAYRaxMf0ZSAVTm4AqxoYIg9hTo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4333.namprd11.prod.outlook.com (2603:10b6:208:195::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Fri, 10 Apr 2020 13:33:16 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:16 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 09/19] staging: wfx: disabling keep alive during unjoin is useless Date: Fri, 10 Apr 2020 15:32:29 +0200 Message-Id: <20200410133239.438347-10-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:14 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55584d7a-ddd4-4589-c2ab-08d7dd53b966 X-MS-TrafficTypeDiagnostic: MN2PR11MB4333: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:193; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(346002)(376002)(136003)(366004)(39850400004)(396003)(2616005)(107886003)(86362001)(316002)(4326008)(8676002)(81156014)(36756003)(52116002)(7696005)(8936002)(478600001)(6486002)(2906002)(66946007)(186003)(66556008)(16526019)(66574012)(5660300002)(1076003)(66476007)(6666004)(4744005)(54906003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ru0fzvK4rAAZVCuCbCQKxWwz55m99BoQrYzUgxNrMKurKKbQKb/R0W/XwesI0pwcyDSojprxEi5TeGj85GU+EtB2PZBTnRtvKpdOXLVPSeexVaBOfFY/HaQeVo3K9BrEugv6FkpNmx8OvjD/xzz49nvTA0MCtFIkCqgvIo/pXnsnjElF7PFPTGvhQQ6v1tdWIOz4JcqJKI7KlsJv0U9CEnHRqaF5wfpTYCNb/IOrGLQPBe0qd3J31BCAo9CyBVmSUkPGRgYpU5dgTqSMtLAeUQfANzEA3dLWtv0DD+LQKleoAVBiwUocHpHBE+cguiWHY8zLtTZtWbwJHmAmIV663NObgyKuNe2Tdg3HMLNdjWMCaiV/vYtaFnNikaVLE0023WAFy7uGGdWt8UFxm/AFk+0OjSdd0F+DF/NsTVvskPZy0ZXUp98GVwnOGHEriyN7 X-MS-Exchange-AntiSpam-MessageData: TKVmW8jLIsHP69lcPzZswanDuQ01Pzvg4O6kXtZJFdig8vPH+TVeCSEhgJF1QhH7vkCsENRz6sqpbVb4bM+2NwhZdd8iY9S+xb7KVFSq6TTZelqZWOz3BsAvvwQ8AS2At2zGXGmiyZZ1RdbcEfx7o0akvqUTAbofBPPfhw19NMN2DMXeGg3467hfrWsUoIDNhxy8+fgv6ngB3uH9t5pY0w== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55584d7a-ddd4-4589-c2ab-08d7dd53b966 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:16.1636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tVs4MvFhCBEjN9vu1XjeETFAh+VWY6Uab1RmmaeNlRWxEu8H1wC13BaP+luZiZyAOwE+YmEeQp8sB3T/U5bVbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4333 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller After a call to hif_reset(), the parameters associated with BSS are reset. So, it useless to explicitly reset the keep alive period. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 67e16c435848..b0557dab91fd 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -413,7 +413,6 @@ static void wfx_do_unjoin(struct wfx_vif *wvif) /* Unjoin is a reset. */ wfx_tx_lock_flush(wvif->wdev); - hif_keep_alive_period(wvif, 0); hif_reset(wvif, false); wfx_tx_policy_init(wvif); hif_set_macaddr(wvif, wvif->vif->addr); From patchwork Fri Apr 10 13:32:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC331C2BB1D for ; Fri, 10 Apr 2020 13:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAB9420769 for ; Fri, 10 Apr 2020 13:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="eYztXJwl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbgDJNdd (ORCPT ); Fri, 10 Apr 2020 09:33:33 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726882AbgDJNd2 (ORCPT ); Fri, 10 Apr 2020 09:33:28 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZ82ueTcHM0et4w9t46ImAvnrmgblBFFfLuyO98gzP6xL3JW+S7sFpoTKwYTG4IWd1de8/MeSbZMLUubkxWyI1Vph6Cz1Nx71xKoDP6tP8FlCvhpxJBX2OVGlNjZh5Xh1SKPzq1phIc3qdEtR/jr1/adHltQHoU5cvUxPedI3WG7mKx8pDN9iTwhcDSYon4RWnuer5x7I9U/X1T8PbFksGObnL5TjaShJMZC0LSN4nMWs5qVHiwJc+ihFqFivltTKlqKKrHRrkTznfd2z1M5+q45yjFA3RVYTcqbnBn1I6b0VEigYgxncJp/6dlN9Pe4bmYHjVFBg9w6TSBZmlwzoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WLP/tXNbrsZ3QDmxPqEtAoFTBekIcBSBvX/C3FvbAhQ=; b=OLgudng99DlPcDkPyTBQX8eZpTct5cY93hi7CIMOQ2yR1CdQRiTpPA6MKKbuiVbOcp4Vs4SxWDfW8ygf6ZWlZnAaCScF0yWlzWRspatmtGHu5UJJx/RVaasYJBc+k6TetyIV/3c6PNZozNMgP3SJMyEFyUsxaMT/Z9oOZ0Ns4Xd/ToHmCpnQfTndD4lDQCbTmgtwU+vFnAuZJxP+dgPfC4HxxQvOEyx2roxQTqKlYrT5AzMamCOD3X5ytPTCENpoSuEQN6XzHyKJRlai+f/7PQkBqDjwO+GZF5YJjNFUUzomlEz5IFMWkM+jRLJfuUMn0r9/sKjfWRwRv/gdgfsjVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WLP/tXNbrsZ3QDmxPqEtAoFTBekIcBSBvX/C3FvbAhQ=; b=eYztXJwllxV+Q7qm1uP2pfdlT1Q5XwtlJ6y9JwuH6q70BmaGfj0zlyj3VyOEMp8hH0zSquyTj3UmmejVUSfNZgIRBmjIxhWFNr244b+rQraWasCcQve/u5ynBCH2plQam7SXwq0yFo46D5KH5yqvaxDRn/1Beb8zDGXZdI0V7TM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:20 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:20 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 11/19] staging: wfx: request to send beacons in IBSS mode Date: Fri, 10 Apr 2020 15:32:31 +0200 Message-Id: <20200410133239.438347-12-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:18 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f17c5843-ce79-4dbd-aeb9-08d7dd53bba5 X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5E8Y5U2Uat11wVDzA/Pkyh4dzF6vr1w43K9q6iJOmY/4K18A57NdzXi7A4+Q51wCUXFc5DunuCBKBqeEyNSE6fpgQK3V5jkFEZfeHTxzCMsclDCGGRy1quwh754LbY5BN9wkna4pPjbJ1/K7LRuc7jSTlVyXvdxBrHoEJChDVP7RWou6zmwmUVGDKCYiyM7/uFxAXLB7ta2lEQre89/rtC0qMFt/agaqAfMDtf2bPJYzx8bWYzGjrpdMY/4fbcpF92lDIMbGiCfUr8wXahWJkdwqst4uVYGxhF7mQLysdq+bwdYWETnQ/mAaAe8qzzyLQwV3Eb/SziywbR14Mbo8I+YCApLg39QoVsMnygN3UCYh6DJJU1RY0+Sq3oiH32nzLS+ZNffXMXKSczvo5E9hLerjehad29gRIqNn7HBvdmUMYugb2czWo82Xh1MnLOn+ X-MS-Exchange-AntiSpam-MessageData: 5u1JcM/TR0jYP8nqRgwoPOzoJLT8u9ArwpxnBhWf3KlpnhFNDH8zUQ4VB/KapyWbXMJkUWUDmezTql5qwAwyh+b3DfaOJc4d22V/eb4lYyeA/fK+xh2cYAgIqQyc9rFD6T9moiMB4NHZ/RD2PQV8FITrJ4qywMSFy+tZLdRMO7x5R8rSJ1umD2zuWNiZQmK5VvwCMlx6gaOp7CIcdN0fUA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: f17c5843-ce79-4dbd-aeb9-08d7dd53bba5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:19.9954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CvxjMdbUgGs70Q0P3UePEJjxzyYG6SjiuYiAiJWBar1himCiRiuEcuoKX0MdGhYJQn+XB7GpRJIn7EZTXOhu9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Currently, firmware take in charge of start/stop sending beacons while in IBSS mode. However, this behavior may change in the further releases. Currently, asking to firmware to send beacon while in IBSS mode return an error but is harmless. Therefore, send this request unconditionally. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 7af7bfa4ac99..3512e59f0968 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -697,8 +697,7 @@ void wfx_bss_info_changed(struct ieee80211_hw *hw, changed & BSS_CHANGED_BEACON) wfx_upload_ap_templates(wvif); - if (changed & BSS_CHANGED_BEACON_ENABLED && - wvif->state != WFX_STATE_IBSS) + if (changed & BSS_CHANGED_BEACON_ENABLED) wfx_enable_beacon(wvif, info->enable_beacon); if (changed & BSS_CHANGED_BEACON_INFO) From patchwork Fri Apr 10 13:32:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216046 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92FB4C2BB1D for ; Fri, 10 Apr 2020 13:34:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61FB920673 for ; Fri, 10 Apr 2020 13:34:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="kobS98tK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727220AbgDJNeV (ORCPT ); Fri, 10 Apr 2020 09:34:21 -0400 Received: from mail-dm6nam12on2089.outbound.protection.outlook.com ([40.107.243.89]:6130 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726864AbgDJNdd (ORCPT ); Fri, 10 Apr 2020 09:33:33 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpsdjyomrqNf/9TneYJ76lIQb8DwiXodNKov/orvvnn67tVH2Ro6jmf/BsMSaEvsWm1USTj1yKWu5S2gajf5OfDvAiw625gDN1jDMcmzf7ipBGR+nRpOUi/SJL4oI9fd865sz+GbQqoiTlgcoc2Bp9VASrqJ7EfZHQZkP9biM1BfAZ2XsHWmOqDkCeAf7OGAkTJCK7Bi0u0WH7lxKYXOFxHNiB3mbcyFfR4zmAm811G4Q71oCbwH2zIpYJLoxTENPYvvJ2vaA0M0m/H1cSsgYgguLGtxEL2hlEczuzKI8uEfmdao1EuhG5Yt9bKTHtRLpY47b5N7j46q+Y0uz4UZig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Ve+8SIp3rtlHm7bPzlyH7FGbTwMhSVUoT+6DV6jEyM=; b=ejfwABO2HUFoK/3JTPXVZps0gLTqAsGSXpe0HG12arsI0l6XA9goDSc/yLudZHf+Au8QEdO75MioFLJSklzSg/OXu+M91blucHmdH+OD+5z3mFYYjm353NK1KWeLY1bDJynoiBy80jxlKA2PQugkYolTfuJQ/kQ1wDJv1ZqW+jMtkJfCtMWKy6mf5eNJQARX0f9kZaExLkzsiCz6DLl+W2iTnPAJ5XK4TZKLFUBVSATtTMAqeBW4MFk/xWwW33csBWx94xRdb64H+QkSs7XMBvGFvJabF6nxb59AJC/oW21Tzy6eMQKMYwC2MdW5GIVgLmb14fgIe090kA0PbGAxQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Ve+8SIp3rtlHm7bPzlyH7FGbTwMhSVUoT+6DV6jEyM=; b=kobS98tKyDzRSWn41BYYnuOE8/UiayB2dM5Oz1m/OFuqOWKNN9kWB5/1h6Tqg0wokIb78cgMmWc5l/XVXkKKbA7/aPjUfp7h9HX4bUhJ1U08yxGU/CNS4cP0UPBqqqCP9HvMit4ZG31/lmmVA4opiCBFfbeHGaP1aT8tZvFkQ/8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:23 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:23 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 13/19] staging: wfx: avoid duplicate updating of beacon template Date: Fri, 10 Apr 2020 15:32:33 +0200 Message-Id: <20200410133239.438347-14-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:22 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8143d64-7beb-4f31-a322-08d7dd53bde9 X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7FoVybUYhEXzDTb06r6lBdYNwzFL4VyZ+euwYd+f2yxz7KIc99idJ9/OGOXUQcAYKgeCj88OOxRoQhljSXc6l/z27VVGKFroMrh3ttn84BTTY274ZfMFNuDqT8/N80zClbOwraUslXq8f4hKqMmTw2Mle3JJozdhk6HWmwmWeYg4V09UrFXVaFh/TP9eQIt/NmhlYa0TAHxi8sc5LJJ9LBLgvGP5hPl8G9FBWfv0Hiq8U98e93EPjM2aY2gjPuhGS+6FE7I/OR0aFu7HSg+LAJZfVxCYbWYSLCK8AjGBiSczz/wdz9mWfAdPLtfd4nR5VUl6i0gL84J0l6cySxm4shYVcok2nIthQ6UY+VAF3IgeRK+X45z5rkFUBmNM4RNUSs0SYyt0Tt+97r5fe1rOM6A1tBC9WwKZXSf9NISmh/SMPiaRoFquQ6XWxnGusgDe X-MS-Exchange-AntiSpam-MessageData: 2pOL9djZlemsc473Ssf0n6TLFxaTWhJX+xgeR/UrqU3EUmMF/LOk8dHbETO3ZF3uXlVUhdvQDdDIyV6pLPKcgF2M37NvL3t4jdGv3ViT+Yy3VwE7+JE5ypd9SVAq75uxO2d9drE7Gg33LhRdv2b8VaOQFMIYEKrvNR9CQexaQmU9BtQcu0SX0RUDo3oFcv4CraiGZ0e9dKHU1Cf6crFPeQ== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8143d64-7beb-4f31-a322-08d7dd53bde9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:23.7422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QcOdWAJJvbgO9nPjv9ziPXFIDsMmY7BjJFg0Gbb5BP1avBgEtDmAxr+hdWTBmOgofHMQJdtaexGaNIskJtbuBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller When ERP changes, mac80211 call wfx_bss_info_changed() with BSS_CHANGED_ERP_* and with BSS_CHANGED_BEACON. The driver already update beacon template because of BSS_CHANGED_BEACON. It is not necessary to also update beacon template because of BSS_CHANGED_ERP_*. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 11d62de531e7..75f1c515751b 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -725,18 +725,8 @@ void wfx_bss_info_changed(struct ieee80211_hw *hw, hif_keep_alive_period(wvif, info->max_idle_period * USEC_PER_TU / USEC_PER_MSEC); - if (changed & BSS_CHANGED_ERP_CTS_PROT || - changed & BSS_CHANGED_ERP_PREAMBLE) { - u8 erp_ie[3] = { WLAN_EID_ERP_INFO, 1, 0 }; - + if (changed & BSS_CHANGED_ERP_CTS_PROT) hif_erp_use_protection(wvif, info->use_cts_prot); - if (info->use_cts_prot) - erp_ie[2] |= WLAN_ERP_USE_PROTECTION; - if (info->use_short_preamble) - erp_ie[2] |= WLAN_ERP_BARKER_PREAMBLE; - if (wvif->vif->type != NL80211_IFTYPE_STATION) - hif_update_ie_beacon(wvif, erp_ie, sizeof(erp_ie)); - } if (changed & BSS_CHANGED_ERP_SLOT) hif_slot_time(wvif, info->use_short_slot ? 9 : 20); From patchwork Fri Apr 10 13:32:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCB6C2BA2B for ; Fri, 10 Apr 2020 13:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7A2920673 for ; Fri, 10 Apr 2020 13:34:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="ZAtuIDnj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726955AbgDJNdh (ORCPT ); Fri, 10 Apr 2020 09:33:37 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726940AbgDJNdh (ORCPT ); Fri, 10 Apr 2020 09:33:37 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KY0JBxZrsUcCvavNEYzkfZtQ5zt4IDRaV3qt/YwbEYCH172+VhiT/GCn99XrpCP5AyuKeoRxsa99hZo8cAe16S/t5kVE6XCMeHYXPezPhrv4xjG/oU2nERZ2eIbicchX7w48xLOi2sTrO7VHpqyW739cCsnaD0YgNSMLcO4DRNHYyXly+bVJwSG6IZRG/p0okzf+0ucrP6FEhxoAZWn87XLGHiYnDAUm0FNu4XQhbbkKgzSv5CRdQmqCO546NOBvSwfJW5IfwvjJSDviMojh++IpQ9N+c8PrVxdd1ewx2ormeWJv0YaXqlHvomvgiGqk4xeD1iAclC3z8vFq1U74lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7+k6i3QYl7UNlie9H8QNJ3/xlP3O6itZF1R+aGTJlHA=; b=JPFW+zeh6MbuXakWdAKRcQWJ3YF5LGrgXvLvd5Upx5oQJldiJI/EZ+vWZAmPuKR9KWwSPITu0/KxtipISN1LosWCs0r7yErASdi1ihyEhbeBkCrPJEVs/TUSLqIz3SpW7i69EA7ElY6qc2NlQwRKh6hqu02LU7adpnrzErgY0dllj9etBb0k0muyxO975BcmrQgIawBg/cdM4fELPZnV6j8cPKZzoZHcFhG5F9/QartzifDy9m50kNv+zP4SVPUm5OpYSmZ4onj0U9IB7660hXQ3eVnwtMerELijhSOK7Vq1LVIidepM9DgtdXSXMA3hQWIUCckmVqrxjJLmx694aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7+k6i3QYl7UNlie9H8QNJ3/xlP3O6itZF1R+aGTJlHA=; b=ZAtuIDnjB63BO+9h44YrraeIf4MbeSGMhVavl+4r0924Io4tdbfa5gzh8lH3e4dTStyDqNXO9aWfMXQoGnuYKDejeI7iAlPlC9b12fbKzLL0TADF8ZRRMhhQSVfFB2AANKgs6CVPGocpN7CLgkZDBwg8gvRhxycFuXhPwrucXPs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:25 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:25 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 14/19] staging: wfx: allow to join IBSS networks Date: Fri, 10 Apr 2020 15:32:34 +0200 Message-Id: <20200410133239.438347-15-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:23 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2df7867-4904-4cad-2a7a-08d7dd53bf0a X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:873; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(4744005)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3XcRfiAq24UpqNBdCgHp79U7i78XDtukphHfLc9d4rs509UNIG1faO2iKfymQ6laD3Pg/GzrCwCnuItSE+pV2w2SumWfif9ZJ6fPHgWcjVkw0ZVjD6X7bpvg7R/LYmcpK1v95U9/dTBuqe2AhSO6qTss3Jfufzyh4XO1qOLQEj04Ddy2Rim8jsPBaSxDw4DSy5IO6ohzkkTn0fb0P9Xy+GEF+qAhiNgyWZzJ9PygN6YR8wXMyJwD79uUBiOEjaCpHsN/o73VLRXuk2M8c4HBrL/vXl6IK3VsQAS42cPobk2NJKJoeG4oIr62mQnBhba1q04CCgXGVjY6UEF5HHYVRjjhVStgxIOixLzDPUlpadphlIUU37XoxtbHA3etSlVHGuWuqxeSaLDYGqljkeJqomTpNytXH5gWdTwnBEq/L3u/3Dr1Y9LvObaonfNxGfbA X-MS-Exchange-AntiSpam-MessageData: 5ziEVhuLPrApIvhgrSXs9Ss5a07cqykIfK3VKplORHvACDS7z32NS+nAApFy/DExA1W5NTsj2FAMGQf0CyNhPL0lqu+ERoYI9jL33rdbsfIwkw1r+zClxaqhbtaNbzjqDMPRyII7prGMMMO1WZhjYGC2W1AGUjxuwCG3ExVe8QE/71C1Sgj8A62XC7Ug/PFeWqRORqGZkr6ICVD6FFYJwg== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2df7867-4904-4cad-2a7a-08d7dd53bf0a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:25.6331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yep5ktm1l0/oMQKKqKZlWQTnsaXDUDTgetlyGl+lS/rcMaVt3mLYiMKT6zISvISlNt1GVhqUFgrlsnTwddtuYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Current code does not permit to join an already existing IBSS network. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 75f1c515751b..8aa373f5deae 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -484,7 +484,7 @@ static void wfx_do_join(struct wfx_vif *wvif) wvif->beacon_int = 1; rcu_read_lock(); // protect ssidie - if (!conf->ibss_joined) + if (bss) ssidie = ieee80211_bss_get_ie(bss, WLAN_EID_SSID); if (ssidie) { ssidlen = ssidie[1]; From patchwork Fri Apr 10 13:32:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216048 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30712C2BA2B for ; Fri, 10 Apr 2020 13:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F23412145D for ; Fri, 10 Apr 2020 13:34:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="hLST5vOl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727136AbgDJNeF (ORCPT ); Fri, 10 Apr 2020 09:34:05 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726950AbgDJNdi (ORCPT ); Fri, 10 Apr 2020 09:33:38 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Do9wm2Ed6CXC9vk9B+ydY/AFSGCyAq6zkUZ9iKMjxM6j338xhOpfmN+4RkauGFVU+DV7AcZXPMthrL4YgnIpSyhYW/TOCMPc9apK9xas7zReNVlMkYtDXoIPl5F93gN3Iq71jpBVZgiiZWJk/qRaBNxuxDWDYcSpcS8EtdLf7PzFCqPe0IxIv9DNjz385ox5dvzwJOVY9ZB+HTzQWjgLWEOmVe/rUylt3nUR1GgoLqkGNW57X3yctE2omP9pwXJDsonHWrREfC0sKj61i30WTl08nzNzyCeQkux6Cidc1rbIKTDUWMUv4+/DtTyPIRHjvRw7F6dwIeHbGrMp7D/NSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8AN5xT7IguMhQFKKbm8f6euP1V+PzcY6ax0tLhh4Yc=; b=W5sDlwfm7H9uuIxg4BZeHnrT00IV+dLdGG2i8K6O7G6jQQFdppUzLDhBViZNZxzm/dKLW/9Y7I0jYgj8zDqv6EH+2iWNIWcT6XppeGL2iy65yCSHGTeaz/8wKweIFeAjkpRptIzw270+WyqyydM0oMiV2VjqNjXNZOKGhTvaiPsRPPnumEbQOsiMzo1agIQby6ZuYJJ7BdVK98ltHctXjnQJj+4zVYfdXBPeAkiQZ94hbfncqlbj0C514YM0CvreUs+jsSjNQ3odjNz/DAE6vvtwPo73nZe4BH1XCZ6mm48c1Tpa0+hxm650lw39bBR9Q8lOk9lgPYOOb9fgCFp8Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8AN5xT7IguMhQFKKbm8f6euP1V+PzcY6ax0tLhh4Yc=; b=hLST5vOlGHkn7CPSqY75SDrSRhX7v+7BYagqH7XTKNoFIbAeJWjFT62OD7/jAwH3PbTcamwWDALG6Lw1900kToNKauhOtMS2VQVmpQa15F74lP9WVnlXqbLDEiRZF1VaYESBGzYFGwfMNeOajArrdfbHFEFk3fL6lc1b+lr7UbQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:29 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:29 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 16/19] staging: wfx: re-enable BA after reset Date: Fri, 10 Apr 2020 15:32:36 +0200 Message-Id: <20200410133239.438347-17-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:27 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9eba5aa-0f4a-45bd-8741-08d7dd53c14b X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:466; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2AzICaktitYAJdEPNOKM9VUcnrZEAx+prlsUnKjQcOn6+WesOzesmfrN7KNMwffmBUX1ZZ/gd7mSWAW6KD4Ee5UCZOtg5HXBCmA1lcfzfQGSsWvO1x3wzniKO/Cy9azqasQSS+PuODIShj2v7YENzTh/+NYeax9y8EoQcNt+h2EmUWD6bfAV0GETBG3XIeJlfXCyJl4nojLUy7buHTNogQ4PiNEAHJtclDsdRseVWtdfB/Z0h/DSZuX7V2UbiMxfYDJX4ro9ZrA+2XDcrrjDNUXAX2V1jhXsP4HhmpdYfTgs8mRZ+S2bZyRtI9ExmS7yz0nvQrsFLI3pTH2ueGO7IC76dVlzRWpBUK0xj1BMLmeHzbCRSqt2C3/2JO1HhbsKvp+IW7ZA0urXfyGzHYdFZzc1qcEQD683sxz1GyOGMMN0V3UerAw5N/cYGzpVMoNu X-MS-Exchange-AntiSpam-MessageData: Byf+8mTT61DGtMMp3IaIrI5vyy1/qXQUhQxj6UUzL3kHgEnd/k+FySUwrt8Ag+M0HYsRjL02cKjPBYwrC0UwH5tzM+mIkBVmi5NAU/MGRb+riv2p+mVLD6eaSxKe+hn1tQBkRjGjJx6nEw3eHrYOs6c33965TQCuC/SjcfoTnIcU+5qJKsp1Qq/lzmMouQP59Aa9o0UJ37lCTMTiybOiWA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9eba5aa-0f4a-45bd-8741-08d7dd53c14b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:29.4199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4DPcqjRyX5yNc2jKSzsw1oN51eP2ZA9lL2tPVIe/EbngtTONHH9CKC7IbQyMTlTLhFBPbh63owIOpzFTHN6LUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Firmware does not support Block Acks when multiple vif are running. Thus, wfx_add_interface() and wfx_remove_interface() enable and disable Block Acks as necessary. Block Ack policy is also reset after hif_reset(). Driver have to re-enable it after each call to hif_reset(). This patch reflects this behavior. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 21eceafc9a95..91b4ce945598 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -416,13 +416,12 @@ static void wfx_do_unjoin(struct wfx_vif *wvif) hif_reset(wvif, false); wfx_tx_policy_init(wvif); hif_set_macaddr(wvif, wvif->vif->addr); + if (wvif_count(wvif->wdev) <= 1) + hif_set_block_ack_policy(wvif, 0xFF, 0xFF); wfx_free_event_queue(wvif); cancel_work_sync(&wvif->event_handler_work); wfx_cqm_bssloss_sm(wvif, 0, 0, 0); - /* Disable Block ACKs */ - hif_set_block_ack_policy(wvif, 0, 0); - wvif->disable_beacon_filter = false; wfx_update_filtering(wvif); memset(&wvif->bss_params, 0, sizeof(wvif->bss_params)); @@ -492,9 +491,6 @@ static void wfx_do_join(struct wfx_vif *wvif) } rcu_read_unlock(); - if (wvif_count(wvif->wdev) <= 1) - hif_set_block_ack_policy(wvif, 0xFF, 0xFF); - wfx_set_mfp(wvif, bss); cfg80211_put_bss(wvif->wdev->hw->wiphy, bss); @@ -591,8 +587,6 @@ int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv; wfx_upload_keys(wvif); - if (wvif_count(wvif->wdev) <= 1) - hif_set_block_ack_policy(wvif, 0xFF, 0xFF); wvif->state = WFX_STATE_AP; wfx_update_filtering(wvif); wfx_upload_ap_templates(wvif); @@ -607,6 +601,8 @@ void wfx_stop_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) hif_reset(wvif, false); wfx_tx_policy_init(wvif); + if (wvif_count(wvif->wdev) <= 1) + hif_set_block_ack_policy(wvif, 0xFF, 0xFF); wvif->state = WFX_STATE_PASSIVE; } From patchwork Fri Apr 10 13:32:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D7FC2BB1D for ; Fri, 10 Apr 2020 13:33:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E78220CC7 for ; Fri, 10 Apr 2020 13:33:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="Qlu8cYo1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbgDJNdm (ORCPT ); Fri, 10 Apr 2020 09:33:42 -0400 Received: from mail-dm6nam12on2089.outbound.protection.outlook.com ([40.107.243.89]:6130 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727004AbgDJNdl (ORCPT ); Fri, 10 Apr 2020 09:33:41 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRtfLAK9MF604L0ULh5B1GidV5Vt2CeEP/WQfHQ6iw1L6wlRKds6HsNgCH9GE9sGMKCuB2l+2J4pD0obzTGBCCGiBKDm7kPhAcKz+x/PndnYo2IUyoKjTsffAGlMLzhyei7apofnjC+AbY1ix8YzFQt7LNoIXGfUFoiTsJFBOPEo1lilHv8Auh+ttVY1LwVK4RHQc0YTAkPG3NDEmD1SsPXryzvUDJ1jfRrLlGyVz6o6qRN/GIfdN2vYwxmB5xpSkQbaih3WGmrfIBgw5ueOJqQyHjgEaPemh5+BTwvZT84VJ1n3Mi/7ek4m0ObxtIpJyy0i+uBND7/9aVzLoAlthg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BaGk8gCExtKTCjraJxOhIJhwABtKx5Qf8bQqk9FYAl8=; b=fNdWHiCksIhjYudsRakuwrY7ORvBqxoXmUIizLVBsgJwdURG+0iIYkIVaxkS98aH0vX23FDj+g71d4bA7U3JjlwA7P22XKlvQCTCC2t1/AybP3jhWzMM42oAlWgz8mcHA3DtXRqVBhsYHIwaM99rx+Sol/Z5D3xF+0eU0MwUOBojI7Y0Jvxg/Jct+dv/8saMrW1EhKND9wxDHsBrowvOm7ctOVl3joJAAULEQEkRuzWKVhgQxFkZgp8CaHKNCdCPMEBY/0kmSJAt7WXJsipe1t2wzU7Y5mlwZqGmowDMlRbMOE1J5FBkX++1jFfaNM8eiUusiGTEmJWgM4yZ2yT8qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BaGk8gCExtKTCjraJxOhIJhwABtKx5Qf8bQqk9FYAl8=; b=Qlu8cYo1PB89IL4/2Jrw6nzS+ultyPZzlDYgqma49Ix5MoxmtyPUnpFIqNBxdX5s0Wy3bHfzR/YirYaJw6fwahXiejPCMwR8bhue8t06oMmX/M/knNMWvVKOp0piAgPKmHyit7ctE26BOouMKOf91ZtUxHbZH1l6VC0VWub15u0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:35 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:35 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 19/19] staging: wfx: drop useless update of macaddr Date: Fri, 10 Apr 2020 15:32:39 +0200 Message-Id: <20200410133239.438347-20-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:33 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 898d1396-568a-4c2c-8deb-08d7dd53c4af X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(4744005)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(15650500001)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o+wbhnzrBwOxY/RhEdWm7H+P1RELqU/JSenBl6tiQ0V8vz51knFIMhLt80lP3Y4wXVg8+7I8uqy9XYwyn8wvZjF8OrXNYX3xvvMG5dJuHX0i8o9fyhTk2wUggxzjyLUKWXhAdm5mprU8FAob49ZwFal/VqTO7ygqen9sfrEkYpFNQtUrWbYnj9brZBu/LqDsC8z7tr7Qcj7XWZJTMUG5I2QazdoddF+IRPk9pp49xT+9aDo9JHBJ8WT+OtZQV6fF8DWX0bZiQK+EQJZ5ku4nJr0Zse1nIuN54PXNJI7I7nwUrYv+b+QzzQUmmOmip8MaCWbtpMZZU3Mp4jGvNpHdHg2EM2jzsBT/FMvFQE1vc4swy2t+AdoQTHJDG03naoP8I31aJkT/04iMeELZppy4ltDHKgzALUM86wf+BMYS+ZRI18k0syklBiJYD/Tlkxhe X-MS-Exchange-AntiSpam-MessageData: 7cTXXVfPulDKbHkDf4fAls7b6LoqnjftCttoP60O9nxLNlC6DBD1EYTl0BmQcm+6e5y8lAAqyp7K28PSao+tqmXulGTiE4hcf3Hr9+ndJHQKr384en4UVYqheLOnqEOv6TqBSTKlVUu22qExsMo18Eg6W8YHOOLSmHuGXijPBRN3NfbsO5Qu6/C8dX7bsTLqhMHQW6+X+aQ4C1v5FWu5NA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 898d1396-568a-4c2c-8deb-08d7dd53c4af X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:35.1296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UGyz/TjxRt16Ov6FedBfQdnCPNySsSLrtJuefnPCfMgEDTOW0n0em90IGbOPvp6JA6BxizJj7lQXDRZcBtXFSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Mac address is set in wfx_add_interface() and removed in wfx_remove_interface(). Currently, there is also an additional update of mac address in wfx_do_unjoin(). It has no rationale. Mac address is already present and nothing has changed it. Therefore, we can drop it. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 53ab9648184a..f1df7717d5f4 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -415,7 +415,6 @@ static void wfx_do_unjoin(struct wfx_vif *wvif) wfx_tx_lock_flush(wvif->wdev); hif_reset(wvif, false); wfx_tx_policy_init(wvif); - hif_set_macaddr(wvif, wvif->vif->addr); if (wvif_count(wvif->wdev) <= 1) hif_set_block_ack_policy(wvif, 0xFF, 0xFF); wfx_free_event_queue(wvif);