From patchwork Tue Jun 23 19:52:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217288 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B256BC433E0 for ; Tue, 23 Jun 2020 19:53:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D5D62080C for ; Tue, 23 Jun 2020 19:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="ozH+VDEM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387416AbgFWTxI (ORCPT ); Tue, 23 Jun 2020 15:53:08 -0400 Received: from mail-eopbgr20045.outbound.protection.outlook.com ([40.107.2.45]:63363 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387474AbgFWTxF (ORCPT ); Tue, 23 Jun 2020 15:53:05 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H3jca+xwQeBedySrYM/DtEMH6qKBwzhKQ/AoDHzbvav4FDYPOSwp8fP2MAhP1Gj1d0+NdSf5LAY2DiZgz9rAL92qmoZQ0S5oZAom8/sp7WdImp9SmUfrJ1q1oRJD3SdHCYJor3Dye2n7XdsKI79M29lhjqUR12IwyednMgN6i9mHxsrVnUVOU6K85aOGr81OipsXjla4M0OmjtDlacfd3eb4h8CxfOvFYb18eZgd4lqW/iXq04i+d4ywfFhH3xG8kJrpgORlX62LhBAHFUqjVufsaOZmzO1Onn1pkvE+MJLDBqNFR8LZ9hYiHuvH1Ai/L0C1Ie9w9se6NutiRmOgug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=571NT07tMexOGWUDw9lkMSfLxuBGVsPtYDngHakIEl0=; b=VtUWqTRbCd5d1pzFK5zIEvsFkg+VBxv/pcwI4YH2y9PjST/m9HKhHNabHf6dLYTofYlmHCcqSfYCNO6orQcoByP2NF8+LuFJ6hKKi0vyY8M4o3nUC1HmYW+dgPsB7D1eLnumEJoaIHlzzqUzRZCZVTHMVydaEmsIm2r2wpofiG8WK/vRy0967u966kwllNsQ8E8gvP+5iFLl+TPbwdnWHq78tDvlwsno5qSBS+WEJvRAE6yOD1ub6Qr1L03+NewNvE3huYtR0Bg5skvIFESk9SS6fG+tBR6q9y21YCRcvQPMl84meOBGa10l/8vEt//7VD+Bh7cjTSxUjob0fb/m9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=571NT07tMexOGWUDw9lkMSfLxuBGVsPtYDngHakIEl0=; b=ozH+VDEMq7tyjP6YxIpT2t+mRUo2sdamVtsrRSiQY07f1kgW3S3xWvRLJC0Sab5NMivd/r06Hi/QoNDSXpYQad4T7UN/02QrOyIIX+IGtVrdo86h1p5al/po55sZMsVmYfKSTnczldj01MhrGiVCQT/m7NxcEMJVxEPCLd7yXW0= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) by AM6PR05MB4374.eurprd05.prod.outlook.com (2603:10a6:209:41::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.23; Tue, 23 Jun 2020 19:52:57 +0000 Received: from AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5]) by AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5%6]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 19:52:57 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Hu Haowen , Saeed Mahameed Subject: [net-next 02/10] net/mlx5: FWTrace: Add missing space Date: Tue, 23 Jun 2020 12:52:21 -0700 Message-Id: <20200623195229.26411-3-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200623195229.26411-1-saeedm@mellanox.com> References: <20200623195229.26411-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) To AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Tue, 23 Jun 2020 19:52:55 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1d531298-a54e-45e6-0163-08d817af06a4 X-MS-TrafficTypeDiagnostic: AM6PR05MB4374: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-Forefront-PRVS: 04433051BF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yTC1phKevIhRvMxsdBzYFv4+OreQl2lm71fSNkMEoFDmgjPCdOQyPiQEIzIIQ9F5KHGcwf1EtaDbiDvJtQ2v/h0AMnefiHj+qZwwI+0Px0CLn02TiMCHye/8dP+JioVrC9tm5O3275Qs/I5OO6s75gxwC2/WVQBORnBrZJrz6UJ6Pvmf26k5klnIFsKjmhw9K1/32fPTdLbfn5z+UKKaDw6WVD02hAA5lY8s6fjoJGAh9/b+0THHi0JYuwfQQR6+0q2Fd0V3DQY2KxRqx+qN7W3p+fKJHx5E148mGqb75y5kYHCyidNLjqPubJM2XgnBJBvzPy8qSL7Cu2NXAczF12N5TucYXcLu7iMk1fwdB9hInoDBZKy1cD2SX4JWv52l X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5094.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(39850400004)(346002)(376002)(136003)(6512007)(2906002)(26005)(4326008)(16526019)(186003)(107886003)(6506007)(54906003)(316002)(52116002)(36756003)(478600001)(8936002)(1076003)(8676002)(5660300002)(86362001)(6486002)(956004)(2616005)(66556008)(83380400001)(6666004)(66476007)(66946007)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: kG18qYhHbKVWKskBMMyeP3gNlqHNpr2pxKZSF2EHumO3pUdrE5A8Q8OViJt0yqnqe12QSAxHThCiLm+JtPfoCuUeNKKeYHWZ9HD9veB2ZRTl/uOfVlFyoX2rK+rzthnLbMiavaVyRzDX4bFfN8QlksvpZKBXezs8HGblLdgx/Gh2XQYjvG07HRRYyBNS8Wb4yPcilAuaw3dPB8Ov6OimHcpvq6TBtT0P2sbU0NMhjGmUCkh/c56SbqOHHmG4Zc6kZKEcZ58dGZeTxVqbyolLAWQjPBmVKrxoKwaBoUaTneGFisN0sKMB1lKE1OeUjHbpEaqb5v19jx43RxCkFzf0FAI6PjjWWei/rS65NY+AWiHOCpliFU+kJtEl/F61PGWOtm1VvQNvkvBUbXcTgsX6RyMr5XJ9rGRVDpybs4aHBgZvdL6Ps4Ji3HQFldeO/2EhegKYmASqjAl5Rctwgkq5eqsXPIDdGpgIjiq1RInX4mQ= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d531298-a54e-45e6-0163-08d817af06a4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2020 19:52:57.4420 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CX62dfLwdSoZJseBrLGkQqWpYIOk7YD6iEGDPVcI4SjDPRu4y5lXTz32GfdUX33eS7NfjyK1WHvTJBX51e2X9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4374 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hu Haowen Missing space at the end of a comment line, add it. Signed-off-by: Hu Haowen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c index a7551274be58a..ad3594c4afcb5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c @@ -676,7 +676,7 @@ static void mlx5_fw_tracer_handle_traces(struct work_struct *work) block_count = tracer->buff.size / TRACER_BLOCK_SIZE_BYTE; start_offset = tracer->buff.consumer_index * TRACER_BLOCK_SIZE_BYTE; - /* Copy the block to local buffer to avoid HW override while being processed*/ + /* Copy the block to local buffer to avoid HW override while being processed */ memcpy(tmp_trace_block, tracer->buff.log_buf + start_offset, TRACER_BLOCK_SIZE_BYTE); From patchwork Tue Jun 23 19:52:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0511C433DF for ; Tue, 23 Jun 2020 19:53:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D09312080C for ; Tue, 23 Jun 2020 19:53:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Alh/rTCx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387547AbgFWTxN (ORCPT ); Tue, 23 Jun 2020 15:53:13 -0400 Received: from mail-eopbgr150084.outbound.protection.outlook.com ([40.107.15.84]:47755 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387457AbgFWTxM (ORCPT ); Tue, 23 Jun 2020 15:53:12 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/7cgTcFBcBSwVBLG45eCYkXZAeKs9gaZDxSEsmGaB2XC5j2OaE9EGWDkd8E44k7yb0WyNOwO9VHbmgETIeMPgVgW0yrljEfADxSsmm17zgFPmSwx5shpD/DyWiFYlsoWvmOdglHlTJvuRdECN14ArB96xtYF6FkTE7eX4x5qV41JaLuScpIalbsF127O21fsCfM+QRpcI6hEvU2PD/xp3wxyrlZHwup6xvhyQ9Pqcka1a43P36AaBXOtPJebIrjz8FYMV9OGbF/X1jnqFOlvLx3Yx2cKHwkxrUoK+yawHqHOXHOD6/tZoA37yTCMftNaxqZCe5Fk8VHQ1fvsOSr/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MvlrTmQHnXAEK9ooKha8cL1GrEdP0cdhD8iDygZfaQ0=; b=PYTRZT1dwtJ9iHJThK8Dl2annvvl5AknZBMimLgowREcf07qbXkTrfbZQ8T179gwG2MxvFA8Gipi0it0gVpu5Wwem1uLVWZlkHf2f3NcbaYY5e7O+ly3SFwrZjoLJPJ3p0eDeDxudxfHo02Ok4GSvuBH3YIuaDP1iVzqw0H0romf6Z61yp9yx9Uu+nQTxCLhpuJtdtvJce8w/UXJ5s6ACsnoryWWhWdpIzAaKtjcx+nvPWr21Orx+SWTGKlA4B8iiK/vxZG+18/ghfdNgTou9tBf/bDiwa2RStLvH7TsmT65dFVJmZMeAl2NsKTTBMFiV1S/P8uX5SP5RWdaE7qycw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MvlrTmQHnXAEK9ooKha8cL1GrEdP0cdhD8iDygZfaQ0=; b=Alh/rTCxnzOyrDTciBdvYuK6uGo9Mm224wrrQ4fd0kGb17uTwxdMq2uIuDf234+xz65iAda14RkOAlBV7vus0dQyF8jjulOOAdS0feGQz+/fCGdSf2iHMAHvKuUgFJL6ZCRTNnzSl8HsjywmYBY+Q2kkpiFoKp60I5+7c2YQ3Bw= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) by AM6PR05MB6101.eurprd05.prod.outlook.com (2603:10a6:20b:ad::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Tue, 23 Jun 2020 19:53:03 +0000 Received: from AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5]) by AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5%6]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 19:53:03 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Maxim Mikityanskiy , Saeed Mahameed Subject: [net-next 05/10] net/mlx5e: Remove unused mlx5e_xsk_first_unused_channel Date: Tue, 23 Jun 2020 12:52:24 -0700 Message-Id: <20200623195229.26411-6-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200623195229.26411-1-saeedm@mellanox.com> References: <20200623195229.26411-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) To AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Tue, 23 Jun 2020 19:53:01 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 354ccae0-6a57-475e-5c42-08d817af0a31 X-MS-TrafficTypeDiagnostic: AM6PR05MB6101: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:162; X-Forefront-PRVS: 04433051BF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /LG59X74pPF4k6mgMQe2fCaj9Xo7utZWtYBjbukwVLqrlwW5iWjBLneqBb+OxzxQxwzmoDYsWrP3KL0+B2xmOCi3h5fcEcXasfE7hcbRUret9mgNen4u0Ax3hvKuhIWJfztYOc0V2KIKS611L9UR9Qzjw3+TD2cC2OQ6C7lQr2NBrsMss84vQ6jWH6HyXJ6s7I9/aegVOxACt7Pipuyu2IDD+76KEGeK2SakXAKcJ9Uoi+h/ylvazYKeB80X9q5yHi1mNMUXaVLpUR3VZthFRjKuEmraAAyUVyOlynMlggtbkBoHEiAwbGCKtOog6EKM3QNHnbXpFF6SjPldwB6Qqh90QJgdbJHuaoz8AYMQPZgzmxUd5O1HHDkLqHxu1g4U X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5094.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(366004)(376002)(39840400004)(346002)(316002)(107886003)(2616005)(4326008)(6506007)(956004)(186003)(54906003)(6666004)(16526019)(6486002)(66946007)(1076003)(66476007)(36756003)(66556008)(8676002)(52116002)(8936002)(86362001)(83380400001)(2906002)(6512007)(26005)(5660300002)(478600001)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: /yT3VkdRbo2aVt1M83kgEOqbpMvfvNHcDWKFaj7pFa8H1U8r7zFz5Z7z+6Un730xb0eDpcEbZRtRnIeLqlUEhyBG4lNMruJ0Z1Dp5kd/vyq3HNlGneZGyJsx0ufpwQmfxcj3H8nO11YHNi33z8b24HBW+i2sOsqS97LGi1CO/kQG3c110Qw5cGyxzJmd8RweT86j3YpSBzC6vWzlaBNdMrtC8+UZyNQMNR4Iv/XzRWF5Bf0BLxEcjpo+xsnLRLo+a7hiFTpdORVkqfNd2FoiGYZdo1pV0cImB4mzZvVd2By/DA/SIZaEduS0bV2ROxPjgA1F8N3OgdHeyK2qgzGInWyLblecsKytrqzz4lxMz7dJkbMcbgQIIodFkKIU2EbFPMFlbCpvOqNUpRCI6kDy1unaJwCU/JM7S5rvB3XDHCYHidaRcOSc6vkZyLylZW9cLwusQWXtCj8nsYa9AdWJU2I2LQUCwKhB/hSnNh3wNws= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 354ccae0-6a57-475e-5c42-08d817af0a31 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2020 19:53:03.1897 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zWQMY66bd2hDXZxFIlePlmApKoCyUFXPno8vvch0Eq0dCOqSCFBAEEHL3duPcVnqpwYGzHngmJVRmrUrefI9iA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6101 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maxim Mikityanskiy mlx5e_xsk_first_unused_channel is a leftover from old versions of the first XSK commit, and it was never used. Remove it. Fixes: db05815b36cb ("net/mlx5e: Add XSK zero-copy support") Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/xsk/umem.c | 13 ------------- .../net/ethernet/mellanox/mlx5/core/en/xsk/umem.h | 2 -- 2 files changed, 15 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c index 7b17fcd0a56d7..331ca2b0f8a4a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.c @@ -215,16 +215,3 @@ int mlx5e_xsk_setup_umem(struct net_device *dev, struct xdp_umem *umem, u16 qid) return umem ? mlx5e_xsk_enable_umem(priv, umem, ix) : mlx5e_xsk_disable_umem(priv, ix); } - -u16 mlx5e_xsk_first_unused_channel(struct mlx5e_params *params, struct mlx5e_xsk *xsk) -{ - u16 res = xsk->refcnt ? params->num_channels : 0; - - while (res) { - if (mlx5e_xsk_get_umem(params, xsk, res - 1)) - break; - --res; - } - - return res; -} diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h index 25b4cbe58b540..bada949735867 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/umem.h @@ -26,6 +26,4 @@ int mlx5e_xsk_setup_umem(struct net_device *dev, struct xdp_umem *umem, u16 qid) int mlx5e_xsk_resize_reuseq(struct xdp_umem *umem, u32 nentries); -u16 mlx5e_xsk_first_unused_channel(struct mlx5e_params *params, struct mlx5e_xsk *xsk); - #endif /* __MLX5_EN_XSK_UMEM_H__ */ From patchwork Tue Jun 23 19:52:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217286 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A08C433E0 for ; Tue, 23 Jun 2020 19:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCAFE2080C for ; Tue, 23 Jun 2020 19:53:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="pELpUHQW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387574AbgFWTxV (ORCPT ); Tue, 23 Jun 2020 15:53:21 -0400 Received: from mail-eopbgr150084.outbound.protection.outlook.com ([40.107.15.84]:47755 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387457AbgFWTxT (ORCPT ); Tue, 23 Jun 2020 15:53:19 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LdoezjDpfNO/VbAOOokicMVl+VNplzvRFUkP1e1LCU4KJjFZimDRxpJuQL22yKgn9BATosjszmj+lGHo98J3hWdJx/0ph6hnk9qkEov3KXIwsaSQEJAKx3zjnS7rw9541NBDCtW45wvMfEVoo1olewkNxvmEyVsGgG0EUMesg5Tr/a/km0qMspqcLPUYLAaHO6TlygpHshOnZZ6dr9FmQY6fqerJZxrTb2OomSlTrVBq4HHZmVPlheS0o/Q4LhxDQ4bQHr23kcRKPV+1AKIVcqffwdXtrVTL7F2kOOKrcK7xlntC2S3KwywArWtK850BnlwqIUxxb8SeBeSTSRQIYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCXRlHlu5CEt/4nsKsGeDz5XXV6Vz22WvOtXlDzTxto=; b=mr675TVsVOo02/YyU8q2esHawxSuGefO2b/NISNJnz95esL1hds/qmrMZzLL6yEyXvq2yMWwPVANHBxp2Tm5Z4ZsRtPF3fCK/FkTXJKECr19f0YFJNQkiuWMwvx/FSw19tJq1RMEuHt50WOpy5xqbJ4g/O4TNyhUb0gI+d2mz3T1iWwS6IFRHBh1a1u7eoZO+9iT3xB0GYRoCIeFvqsS7jy2FoUIgJC89iT4fAPkYb7dkFggBA34Tskde8pppIWRKIvDIRXALXjoBf54Wui5LCUAr95mvCSQRGvFk50IOI3blHUvJIU8sFuMFbkwoMheqWhFxOM1C/pJHOkWme/pDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCXRlHlu5CEt/4nsKsGeDz5XXV6Vz22WvOtXlDzTxto=; b=pELpUHQW2URwdzCzvQt6Tr2+ixe13xKM6Ey1n6pqUshq8qor20Gm7ESBL7B1+xgFUmISiHPI+zq+YRPGT2UnAuEPgNd8ZA7RJe8ou5oR47dVqjoHq16l2BBYEyrDACl7FEUo2+ATdyD1LnWFtPbHFUWUw2FBmIyyfCLGpLJ6Awc= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) by AM6PR05MB6101.eurprd05.prod.outlook.com (2603:10a6:20b:ad::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Tue, 23 Jun 2020 19:53:08 +0000 Received: from AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5]) by AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5%6]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 19:53:08 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Vlad Buslov , Roi Dayan , Maor Dickman , Saeed Mahameed Subject: [net-next 07/10] net/mlx5e: Move TC-specific function definitions into MLX5_CLS_ACT Date: Tue, 23 Jun 2020 12:52:26 -0700 Message-Id: <20200623195229.26411-8-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200623195229.26411-1-saeedm@mellanox.com> References: <20200623195229.26411-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) To AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Tue, 23 Jun 2020 19:53:05 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 63f0fd1a-ce25-454b-b0dd-08d817af0ce7 X-MS-TrafficTypeDiagnostic: AM6PR05MB6101: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:308; X-Forefront-PRVS: 04433051BF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tHqfIP4hkvgAxdrn+kJX2UYXGNeAKqATStv475s423PYWNvSwnTetXi2eAyWRCVpTWEaleLC4SmDrmJVWVST2fniwOGRNDrQxOf/Kg2quFOLJtrcBrU5jKBkzIaGT9/4bNMkuL2kAJGOmfLmXRnDd24CMYM3mAJJbkT6EAoDedm1CMRHXfZkKU79hP4vaXWMAIzdicEEVLYREk0/tXQvVQdRx2iV3mIMMcOLdlPm04B93whD8pp/eDi6Q6rO61Y6OKcNzoQDiilNBn6p9uQDMrzjc97Nhebb0kPp42LBCNganRfLmWR08zK1if3/dAX4ZiQ3iVcxaRTuPwn7AiCidY+VEJX6n1Mj43TaqKuwEf02EVnOwyNhBgJwfE3rC7s/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5094.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(366004)(376002)(39840400004)(346002)(316002)(107886003)(2616005)(4326008)(6506007)(956004)(186003)(54906003)(6666004)(16526019)(6486002)(66946007)(1076003)(66476007)(36756003)(66556008)(8676002)(52116002)(8936002)(86362001)(83380400001)(2906002)(6512007)(26005)(5660300002)(478600001)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: UGU7P+957ClJDnRGAfiZm+c20kZQOgdxICqB8CEmZVQTY8ft1j8hgxEbgpiPR8y6dIY0GeiFMMN4dYredQunx/z6jWQrovf2CSQOmtp4hYBUZjAjZTd28H3Qe/mt3Nt6dh1+DenOF2NX5aflBToCPDk2Y6ScC2LGPt5iVvp5Ih14/hYerdnKHFihTrAiJxZWRiXjeXPwDglSDTl7eyZoCRrJ5a76+P7Qt4xNZ6P2Hc2gCqsA8lfoXAQtJxeT7aj7KFEyj00J3jacUA0ZyLwaMldCP4kt2LUAECW/Y5ho16mgIZiwoK7rJF+5FSH0x0vnrto8rDy33zlJv8W0WpKzUX/4cBi8VkVwPor8HRgDY06nY8KV0pB0CbtN/HWQKC7bWk6yAAoCswm0i3XZuvfh1BNV/PKqpweutTlFLEHI1rQP8uBBn9pqUb0HEToQBISj/eUHDtmCPSvHGvgouvSDlM4RYatl5unQfajbgjyQhII= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63f0fd1a-ce25-454b-b0dd-08d817af0ce7 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2020 19:53:07.7830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7fBxWMvGj/C6C/uLVifzOpdLhupbt7ZWEsNybGQqCHwZ6l2DKAA42h/LtYMGGFQa/8uTjQnuhffMQ3hgMLhoFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6101 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov en_tc.h header file declares several TC-specific functions in CONFIG_MLX5_ESWITCH block even though those functions are only compiled when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move them to proper block. Fixes: d956873f908c ("net/mlx5e: Introduce kconfig var for TC support") Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Reviewed-by: Maor Dickman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h index 5c330b0cae213..1561eaa89ffd2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h @@ -40,6 +40,14 @@ #ifdef CONFIG_MLX5_ESWITCH +int mlx5e_tc_num_filters(struct mlx5e_priv *priv, unsigned long flags); + +struct mlx5e_tc_update_priv { + struct net_device *tun_dev; +}; + +#if IS_ENABLED(CONFIG_MLX5_CLS_ACT) + struct tunnel_match_key { struct flow_dissector_key_control enc_control; struct flow_dissector_key_keyid enc_key_id; @@ -114,8 +122,6 @@ void mlx5e_put_encap_flow_list(struct mlx5e_priv *priv, struct list_head *flow_l struct mlx5e_neigh_hash_entry; void mlx5e_tc_update_neigh_used_value(struct mlx5e_neigh_hash_entry *nhe); -int mlx5e_tc_num_filters(struct mlx5e_priv *priv, unsigned long flags); - void mlx5e_tc_reoffload_flows_work(struct work_struct *work); enum mlx5e_tc_attr_to_reg { @@ -142,10 +148,6 @@ extern struct mlx5e_tc_attr_to_reg_mapping mlx5e_tc_attr_to_reg_mappings[]; bool mlx5e_is_valid_eswitch_fwd_dev(struct mlx5e_priv *priv, struct net_device *out_dev); -struct mlx5e_tc_update_priv { - struct net_device *tun_dev; -}; - struct mlx5e_tc_mod_hdr_acts { int num_actions; int max_actions; @@ -174,8 +176,6 @@ void mlx5e_tc_set_ethertype(struct mlx5_core_dev *mdev, struct flow_match_basic *match, bool outer, void *headers_c, void *headers_v); -#if IS_ENABLED(CONFIG_MLX5_CLS_ACT) - int mlx5e_tc_nic_init(struct mlx5e_priv *priv); void mlx5e_tc_nic_cleanup(struct mlx5e_priv *priv); From patchwork Tue Jun 23 19:52:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 217285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6961C433E0 for ; Tue, 23 Jun 2020 19:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D0FC2080C for ; Tue, 23 Jun 2020 19:53:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="hjWPQyPu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387596AbgFWTx0 (ORCPT ); Tue, 23 Jun 2020 15:53:26 -0400 Received: from mail-eopbgr150084.outbound.protection.outlook.com ([40.107.15.84]:47755 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387457AbgFWTxZ (ORCPT ); Tue, 23 Jun 2020 15:53:25 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wx7JUZ0LGvXK/umg2/DCbC61u33awUwFEOJebLn9vXhNtS04O5TLhCCi4nbwqTn4/z7joiklKr6JUymFyQelX8KWk1h67cy3FxlPJ07JZWiHoAjGJvzzbU3ZZ9XmewM/agIOQs096n2OrmYW5KA7Ag1gEEO9e6uJS1ZotsDTn7/TxA4UoRwZj7H7EsJUbi31rOrv05Rzg04lwnmFEWPZJq7/Y574o8sLRMg2Sa/5IvnEFRyL17XNN3wyApxzkVTwqonOqLVlMnc0gowStip6kHzG5foDH8UBJpJK7tvlAkZqkJX/oQbU8vU6sJPcEy81ftyb2tAyECYdjTqAxHgf3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xO3DnVWv1QEqusc+nGUHwMvFvdcoYJPgoujYQZhZ7O8=; b=FkPqEiN12J07Way8CK/5f02uUTsf9t41Ib0e3/IMNQhmWoFklshJba2qFnJ4I0MRGoIold4AYGVdj/YFdA5hpwb6u5ikbZtB2JIDq3gn1t5yWqp12z6WpJC7dvW6LhUE1IO0VUZ0rerNAx2lOhbmuK0A1pzPsO7PtRfM0f39/+iGhwDCBa1XzOjcR8Bambn1OsD91L3qpKRUKZ3ixzL7MpQwj23IenSew2/5QIXNxNM8SzNnS9CjWWVgBk9o37YUYe81fM//uFwhb7Uu0TB5oNE+aLY7ZLIcAIkGXqgOru/KvGjsCEoNFC6LHAW4oE7hVAih0KcDvE+hrFKz6ugm6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xO3DnVWv1QEqusc+nGUHwMvFvdcoYJPgoujYQZhZ7O8=; b=hjWPQyPuui4Cwm6YgZr9EF+ndJPITcCEqWgUKJibqA7p6yUIzdPS5qFun76o7G2p34+pJvc5Jiym/qG3vaRK3WBZLC1yDIiNeLag4yUbYe6DWEAnvjRnElTJDG74CklRma/HsF15tKyV864aCCxGtMr7oIx1Pk0qDjmEz0Ufp84= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=mellanox.com; Received: from AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) by AM6PR05MB6101.eurprd05.prod.outlook.com (2603:10a6:20b:ad::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Tue, 23 Jun 2020 19:53:11 +0000 Received: from AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5]) by AM6PR05MB5094.eurprd05.prod.outlook.com ([fe80::b9f1:d8a2:666:43d5%6]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 19:53:11 +0000 From: Saeed Mahameed To: "David S. Miller" , kuba@kernel.org Cc: netdev@vger.kernel.org, Saeed Mahameed Subject: [net-next 09/10] net/mlx5e: vxlan: Return bool instead of opaque ptr in port_lookup() Date: Tue, 23 Jun 2020 12:52:28 -0700 Message-Id: <20200623195229.26411-10-saeedm@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200623195229.26411-1-saeedm@mellanox.com> References: <20200623195229.26411-1-saeedm@mellanox.com> X-ClientProxiedBy: BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) To AM6PR05MB5094.eurprd05.prod.outlook.com (2603:10a6:20b:9::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from smtp.office365.com (73.15.39.150) by BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Tue, 23 Jun 2020 19:53:09 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [73.15.39.150] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dfda49e3-b9e6-48d1-ffdb-08d817af0efa X-MS-TrafficTypeDiagnostic: AM6PR05MB6101: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 04433051BF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lyQMNWbChBnfEBOngEy/+VYG7BjOmoAtet50ZeByZhGgG1TD0vJpFa4SRHhyViGMi7iDuxDhN3WHLTAX4WAc0zeYbF8gGzy7ihHNsmVWWnZDxKUmnktfayvF0OtzME7UMD/WxZsz9MsgZQwG1kJpj8smElUaLIIHVRbg73wRGXwJKjPogkVGjA74np3Z0EullbCHrVY2mH09KF2prcBgwQcR0F26oDvEfxTZAFTsLYpqv64lY9hY/iGpQP2i+LO4jhDhtBX68TC0TWya8KHhjZTrtxe3k2X2HUUisUJcaZsDYooQ7kuVEsy417VjCcBpKUYXBzp67vhxkN+oySyLzOGrl4kIeUDHATuEtY0sVVIEdl1y946fYG8YvP3Lo9up9mi/YKxTMd7mVsUecdFNO71i7U+D3LZW1xTDa4bxDkY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5094.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(366004)(376002)(39840400004)(346002)(316002)(107886003)(2616005)(4326008)(6506007)(956004)(186003)(6666004)(16526019)(6486002)(66946007)(1076003)(66476007)(36756003)(66556008)(8676002)(52116002)(8936002)(86362001)(43170500006)(83380400001)(2906002)(6512007)(26005)(5660300002)(478600001)(54420400002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: zq+y8O+tPWnMq0LcoWLwmluZrvpDspmfZi47W5sOLeXy1XuzG8lmT9TN/saLhVB3V0TMm/xQs02pSpLDGeh67GC8lgQP4qWEgSe593+DDirjC9ceLLi+Qu7VCkvoaU2bHl1phuU+5qknHlV31V35QZhLprWoYJ8JOPVKwaLpqWuE/nOpLiNqG4S3aWe9EXb06Kj2kblb92nGgajW3GxDxszWsdQ6MOjAFiAGfkjJp/ZJzGs5sdpAqTtMEt4fPB70q+QzrlP5FE8a/zRDOOe5lXOFJGv0tNAh5hmYPIK65+6cVEzNmI3HW29PzFEQvZTS1uimdzqsh56lJAb5ZXUQ6Frd8CFbTalegoRf37uTBy365i09oJK9DwMzUBFm50O2gkVFYcYuAyJvIqTkN+3+4dP1hbv79hf1ylK6//U9kQ7bzGIh4MPQUcxjGPLUa21Rm4PyRWAhOh3W9N1Ur/ps9Ae7lpkVdm9060wk/cwX85Q= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfda49e3-b9e6-48d1-ffdb-08d817af0efa X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2020 19:53:11.2550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4M81+xVkGY52+MzPJ7BEdoy+U4D6O4lgiV+fMgXxrHhoZNlgOHx9LEd+ugraFVPSGG2Iyp5X2fHjWpIgWbmGnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6101 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org struct mlx5_vxlan_port is not exposed to the outside callers, it is redundant to return a pointer to it from mlx5_vxlan_port_lookup(), to be only used as a boolean, so just return a boolean. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c | 9 +++++---- drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h | 5 ++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c index 85cbc42955859..be34330d89cc4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c @@ -77,9 +77,10 @@ static int mlx5_vxlan_core_del_port_cmd(struct mlx5_core_dev *mdev, u16 port) return mlx5_cmd_exec_in(mdev, delete_vxlan_udp_dport, in); } -struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) +bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { - struct mlx5_vxlan_port *retptr = NULL, *vxlanp; + struct mlx5_vxlan_port *vxlanp; + bool found = false; if (!mlx5_vxlan_allowed(vxlan)) return NULL; @@ -87,12 +88,12 @@ struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 por rcu_read_lock(); hash_for_each_possible_rcu(vxlan->htable, vxlanp, hlist, port) if (vxlanp->udp_port == port) { - retptr = vxlanp; + found = true; break; } rcu_read_unlock(); - return retptr; + return found; } static struct mlx5_vxlan_port *vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h index 8fb0eb08fa6d2..6d599f4a8acdf 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.h @@ -50,15 +50,14 @@ struct mlx5_vxlan *mlx5_vxlan_create(struct mlx5_core_dev *mdev); void mlx5_vxlan_destroy(struct mlx5_vxlan *vxlan); int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port); int mlx5_vxlan_del_port(struct mlx5_vxlan *vxlan, u16 port); -struct mlx5_vxlan_port *mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port); +bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port); #else static inline struct mlx5_vxlan* mlx5_vxlan_create(struct mlx5_core_dev *mdev) { return ERR_PTR(-EOPNOTSUPP); } static inline void mlx5_vxlan_destroy(struct mlx5_vxlan *vxlan) { return; } static inline int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port) { return -EOPNOTSUPP; } static inline int mlx5_vxlan_del_port(struct mlx5_vxlan *vxlan, u16 port) { return -EOPNOTSUPP; } -static inline struct mx5_vxlan_port* -mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { return NULL; } +static inline bool mlx5_vxlan_lookup_port(struct mlx5_vxlan *vxlan, u16 port) { return false; } #endif #endif /* __MLX5_VXLAN_H__ */