From patchwork Mon Jul 6 20:23:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 234885 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp289723ilg; Mon, 6 Jul 2020 13:24:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxExLuOv503xBLsf01SSAwL9KtS2Leizj8y/Cg7nFNzhGBwyv5v7pV0iSyA8D940qN2Im9G X-Received: by 2002:a25:3155:: with SMTP id x82mr27115170ybx.492.1594067041062; Mon, 06 Jul 2020 13:24:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594067041; cv=none; d=google.com; s=arc-20160816; b=J1PMaP5VyaLsXBiTHseLqIkepE9aoNcgL9IFMlcRIVUyXYKi8RaWsuZBjeaRV+/ubu 6Zayy8A0q8uOCFlfZ1apDDGRMpD7g1Jf16Vr3HdvV1gmlAz/PE+MuM1rTQaRwNaZdfZa KYdFOVKV1EhYGz0meEZi/y0etBzuyTKaLfLGHQHVibLZY4FFT23zow/JbtFSvDXuLQoq 0p71goGLO8FtH021SjQAhqZPtOOiyVLucPA22TvhB4icqdny2mruawXAp2wBEbqh4S8j f3vtQmUxJ1o+3r7tU6yNKxl8tLx6Yco12i9tykLrHTgewi8eW5tjypA5CF0QAz6ROOQW aJLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=VkI/7OkT/JQH939iZ2rt2OKPxgnREi50rQESgyzIJ1k=; b=gcN4Y8mj0IQUTZftRgJ8zsf4EEp2sFhgAEbDAPEEPdhdr8+8fW5akWSjkkuFbUPA4q 41xlL9oWFDU2nWz475PeGkjzjvVzRgIiGl+UPRN31xsz+y43+vRStF30ss00lZ+I1Vf6 KoYfk3NYZSK5rJ1aG51ITKkygQ6Hih2wYDld49Ua2WbhhVDP4MLWc7aQ+AwVJqnSEmaT LQf/geVpC1WKqUBrflDo9TknSkA1eB87OO+xgQEg38lLJVKQSTcdLgQxybdnYrB5GSAj +arXpP2+Ka1Ofmv3ZYDLF6yk1eOHl348/4xUyR5yF6+kLHWeL/Tf2T+85dqbhD8WKmEY xnwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JuqgzU65; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 203si9317164ybl.405.2020.07.06.13.24.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Jul 2020 13:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JuqgzU65; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsXei-0005SL-Ib for patch@linaro.org; Mon, 06 Jul 2020 16:24:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsXeZ-0005S9-Ut for qemu-devel@nongnu.org; Mon, 06 Jul 2020 16:23:52 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:46546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsXeY-0007f5-63 for qemu-devel@nongnu.org; Mon, 06 Jul 2020 16:23:51 -0400 Received: by mail-pf1-x441.google.com with SMTP id i14so940851pfu.13 for ; Mon, 06 Jul 2020 13:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VkI/7OkT/JQH939iZ2rt2OKPxgnREi50rQESgyzIJ1k=; b=JuqgzU65FoRKodaR9pmkpQqoFSVyafa+l0Ri8y9ZnOxXxlD74WTnzwf+jI3ZWJnj8H aYU2CqcFH6py4Mp6DKGodjxMBuOfYbnHvYWkTLrCr3ztk2Z+OzVloTj7lV1+2QTlRFeE tuMJIqolNuMEtwVQ2T3ZYaIK4pXYqjUV5/Dd+tEEQNLMmRBgtld2xB+5hj6hwxAWsb/w NYWLsl9UDjKOFSPkebRiP4kPmjNT2Ps1hGxAxM2sPd6+iONQusbvlTPkLjtEh9UeGbfZ /dcb4jI29+5kbkv6fvcXu9lK1YaSlhTaKnTUsHp0Elmcsvuwm+31VpRuGyxBp4xtESiO /5Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VkI/7OkT/JQH939iZ2rt2OKPxgnREi50rQESgyzIJ1k=; b=DDl5DX/SYMyfsu33GlEVBy6vZfVoym4fuRgOHHLHID4H+At4i5rNfjGdUeGL8OcXCO qqUQ268b4DwnoCdJM0MVihbKkh+LBYtiwIBbW/0RJyzt/Fi1OALdUB5ch4q+2vmH/nOG fzdsukXpA/TXnuOPoEN1axyViE1rI/rLkJR/YCz1TbpsJOLCQvegiP8Q/RH6szb7BKxW RyaPJY7fOqf89F6aN69hXpbklB0Z9VMVi8df4gzdw2urzHYdk8HqD4gs7UXx1k5jVgpa EvanZIBJgMhyG7YTkQ5lBSCzKM7vaIAfa3Kd6e5Mm9zAiCCnPHA2QH+aJc4FjNtbX36B fn7A== X-Gm-Message-State: AOAM532kNBvxREnwEnct3QU5ai8l/Batdf7/D60r0pXGkG2Nl4QkaH+o l1ko452X6DZAZuUXS/AltBJZySvtvjc= X-Received: by 2002:a63:3ec4:: with SMTP id l187mr9547145pga.371.1594067027804; Mon, 06 Jul 2020 13:23:47 -0700 (PDT) Received: from localhost.localdomain (097-090-106-114.biz.spectrum.com. [97.90.106.114]) by smtp.gmail.com with ESMTPSA id mg17sm282049pjb.55.2020.07.06.13.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 13:23:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH] target/arm: Fix mtedesc for do_mem_zpz Date: Mon, 6 Jul 2020 13:23:45 -0700 Message-Id: <20200706202345.193676-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The mtedesc that was contructed was not actually passed in. Found by Coverity (CID 1429996). Fixes: d28d12f008e Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 08f0fd15b2..88a2fb271d 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -5275,7 +5275,7 @@ static void do_mem_zpz(DisasContext *s, int zt, int pg, int zm, desc = FIELD_DP32(desc, MTEDESC, ESIZE, 1 << msz); desc <<= SVE_MTEDESC_SHIFT; } - desc = simd_desc(vsz, vsz, scale); + desc = simd_desc(vsz, vsz, desc | scale); t_desc = tcg_const_i32(desc); tcg_gen_addi_ptr(t_pg, cpu_env, pred_full_reg_offset(s, pg));