From patchwork Tue Jul 14 06:47:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 235506 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3482081ilg; Mon, 13 Jul 2020 23:48:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxu8XIjuXJJI0odYpCb06cT+73tHJwTqmTtGI3deh+OfHZ4pj3ewPDE2HFwi0V1Yg5HOdQ1 X-Received: by 2002:a17:907:7245:: with SMTP id ds5mr3112687ejc.1.1594709308124; Mon, 13 Jul 2020 23:48:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594709308; cv=none; d=google.com; s=arc-20160816; b=b6IqM40/op+NnYvi9RGf0D3DLETVP1XDTpZUBnPY6zHR89NUqG7bsTpJOxPPawUlO4 xiezM0pqruR4cS/0R0M+v1JtcFQVw2k6uVHmx3xDwfBP/ildjPKXwzKOJBMuX/hdtiv8 3REml/8Zj+tSGl6eiXKoa3A9moDW3/9Wfxla3KixoBJFr6rP/aMdfvvdJ+s3Iw4dhPBt bvBjoCk/qDfDQmtwIIQmRfUapArkOSwXzsL5Dv/4C90NUwlsYl0lcHvoSDzNYnHlPZUr By/7byAX+5JUr7fyuyQEzzeFDlDPN8Ka5R+W2BUQ6rKLfHUmlOd73WwcWpnBaS8FdxsL U93Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=ktQQIQEMhkR4F9kpdyKQJsHX/Rt+fNec/hA6GOQDIDo=; b=TvWmXvjx5Ah9LbIvqEFhQjg6IrFaPXorNzOfVtVpZSZnBaGN5x02tLKnd0UZ0n5qFB I3zPFbcEwihw3RMKKToqQSAja0QGoe0HOvQ051GYke+ncKhXkmct5EO4E+A99m72vz7H Q0W9zZpqIdqOF5zZOxuAMOi3h8HHxExJ6WbIvfhzFiXms0SUwdkV95+K9J1OSGsGX2U8 aWwC63HhUAraHq4G90B3OwVRTZZl/azmV3GuVUNHiEVxwrF+Aqc3FV7R1UqrwFnbQzRH X1R/4U+fu0zEjhTZBqd8v/3dqYWMUBD4REZsHMSVPlaBB3knFaZ/PmdZyxa4CTYxhfEJ lFgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=KnFLWT9e; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si9972813ejw.169.2020.07.13.23.48.27; Mon, 13 Jul 2020 23:48:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=KnFLWT9e; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgGNGs1 (ORCPT + 3 others); Tue, 14 Jul 2020 02:48:27 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51107 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbgGNGs1 (ORCPT ); Tue, 14 Jul 2020 02:48:27 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200714064825euoutp0182c9f168b7be69bfc68d2ca8214552fc~hi6oP9jaj1645516455euoutp01j for ; Tue, 14 Jul 2020 06:48:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200714064825euoutp0182c9f168b7be69bfc68d2ca8214552fc~hi6oP9jaj1645516455euoutp01j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594709305; bh=ktQQIQEMhkR4F9kpdyKQJsHX/Rt+fNec/hA6GOQDIDo=; h=From:To:Cc:Subject:Date:References:From; b=KnFLWT9eNSHFdbpy9cpUFYwAWafrfbss2bYHW6WMcqUHuR8oA/4wD3RgLLVaKDsrj oeNKula/6yFuaUGYR/f8OWsWjwwnT716ZLxhwdp5p/aHt5nR73xWJ+g4e7ZRtOoJPe b0fkw3OZXOAgeu7WFSEBCJfpujLazgGJjxNI9SpA= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200714064824eucas1p26ebecc4a1e3f27faa81ae62b7a853164~hi6npld3e1846918469eucas1p2A; Tue, 14 Jul 2020 06:48:24 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 55.AA.06318.8355D0F5; Tue, 14 Jul 2020 07:48:24 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200714064824eucas1p2ea0d2ee2c109c351fe489050905b4104~hi6nRJW4M3028930289eucas1p2F; Tue, 14 Jul 2020 06:48:24 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200714064824eusmtrp1acc85bb4bcfb81bf88cd5c6a6bf0ac99~hi6nQflzQ2736027360eusmtrp1q; Tue, 14 Jul 2020 06:48:24 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-a8-5f0d55381fe0 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 1E.F6.06017.8355D0F5; Tue, 14 Jul 2020 07:48:24 +0100 (BST) Received: from AMDC2765.digital.local (unknown [106.120.51.73]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200714064824eusmtip1439d6154bd89a5cef462cde69ec5befc~hi6m2prql0479804798eusmtip19; Tue, 14 Jul 2020 06:48:24 +0000 (GMT) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Marek Szyprowski , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Willy Wolff , Marian Mihailescu , Chanwoo Choi Subject: [PATCH] ARM: dts: exynos: Disable frequency scaling for FSYS bus Date: Tue, 14 Jul 2020 08:47:59 +0200 Message-Id: <20200714064759.31772-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWy7djPc7oWobzxBqtemVlsnLGe1eL6l+es FufPb2C3uLxrDpvF594jjBYzzu9jslh75C67xfppP1ktvp14xOjA6bFz1l12j02rOtk8+ras YvT4vEkugCWKyyYlNSezLLVI3y6BK2Nq5yu2gm98Ffsu3WFpYNzB08XIwSEhYCKxo8m8i5GL Q0hgBaPElXVz2LoYOYGcL4wSayanQCQ+M0rcWdfEAtPQ/jEMIr6cUWLTtIdMEA5Qwy6gq0C6 2QQMJbredoFNEhGIl3jUf5cFpIhZoJ9J4vGZrYwgCWEBT4nGVbNYQGwWAVWJXe+7mEBsXgFb iea9X8BqJATkJVZvOMAM0iwhcJ9NYsXPqywQCRegbYeYIGxhiVfHt7BD2DISpyf3sEA0NDNK PDy3lh3C6WGUuNw0A2qstcSdc7/YQB5iFtCUWL9LHyLsKHGns5cV4k8+iRtvBUHCzEDmpG3T mSHCvBIdbUIQ1WoSs46vg1t78MIlZgjbQ+Jt02N2SDDGStyd8oJtAqPcLIRdCxgZVzGKp5YW 56anFhvnpZbrFSfmFpfmpesl5+duYgQmhdP/jn/dwbjvT9IhRgEORiUeXgl/nngh1sSy4src Q4wSHMxKIrxOZ0/HCfGmJFZWpRblxxeV5qQWH2KU5mBREuc1XvQyVkggPbEkNTs1tSC1CCbL xMEp1cC47vST0EXt02SnBc1MPp1gr77pfEXFPc7JRddiTL3zJjo4fmo7e5jJUv3N43n3rCPF 2xyPW77p8/2WPLfVLy541Y2HYX1LijZz1ZQIpP29VyrvN9Pw/brwvkMRcUn3H6oeD5lg8OnN 5Qfhb049znm249TjpetOXO5PnLOuLLFq9erbyndL2u6uV2Ipzkg01GIuKk4EAErnwcwGAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t/xu7oWobzxBlMXyFtsnLGe1eL6l+es FufPb2C3uLxrDpvF594jjBYzzu9jslh75C67xfppP1ktvp14xOjA6bFz1l12j02rOtk8+ras YvT4vEkugCVKz6Yov7QkVSEjv7jEVina0MJIz9DSQs/IxFLP0Ng81srIVEnfziYlNSezLLVI 3y5BL2Nq5yu2gm98Ffsu3WFpYNzB08XIwSEhYCLR/jGsi5GLQ0hgKaPEnX9tbF2MnEBxGYmT 0xpYIWxhiT/Xutggij4xSsz+fZAdJMEmYCjR9bYLrEFEIFFi9sfZYEXMApOZJM4cPgLWLSzg KdG4ahYLiM0ioCqx630XE4jNK2Ar0bz3CyPEBnmJ1RsOME9g5FnAyLCKUSS1tDg3PbfYSK84 Mbe4NC9dLzk/dxMjMBy3Hfu5ZQdj17vgQ4wCHIxKPLwS/jzxQqyJZcWVuYcYJTiYlUR4nc6e jhPiTUmsrEotyo8vKs1JLT7EaAq0fCKzlGhyPjBW8kriDU0NzS0sDc2NzY3NLJTEeTsEDsYI CaQnlqRmp6YWpBbB9DFxcEo1ME6XPSgaOs3ZIndhgoDxjYlz52496L+JbTFr0M85Ezb+Z9B+ 4DDp9qRH3qXsq9cruH60vhX2x/iQaPefVpZVJS9vK/y7bPnhruMu6XQ+8V2dttNqDFVvpmiE OfI1fS2UTzmi1ZypsFF/1w3bL7eThdp+Zc8vsPhV37QqiWlS1C2uR82uJkm6E5VYijMSDbWY i4oTAV32XFRdAgAA X-CMS-MailID: 20200714064824eucas1p2ea0d2ee2c109c351fe489050905b4104 X-Msg-Generator: CA X-RootMTR: 20200714064824eucas1p2ea0d2ee2c109c351fe489050905b4104 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200714064824eucas1p2ea0d2ee2c109c351fe489050905b4104 References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Commit 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids") changed the parameters of the OPPs for the FSYS bus. Besides the frequency adjustments, it also removed the 'shared-opp' property from the OPP table used for FSYS_APB and FSYS busses. This revealed that in fact the FSYS bus frequency scaling never worked. When one OPP table is marked as 'opp-shared', only the first bus which selects the OPP sets the rate of its clock. Then OPP core assumes that the other busses have been changed to that OPP and no change to their clock rates are needed. Thus when FSYS_APB bus, which was registered first, set the rate for its clock, the OPP core did not change the FSYS bus clock later. The mentioned commit removed that behavior, what introduced a regression on some OdroidXU3 boards. Frequency scaling of the FSYS bus causes instability of the USB host operation, what can be observed as network hangs. To restore old behavior, simply disable frequency scaling for the FSYS bus. Reported-by: Willy Wolff Fixes: 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids") Signed-off-by: Marek Szyprowski --- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 ------ 1 file changed, 6 deletions(-) -- 2.17.1 diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi index ab27ff8bc3dc..afe090578e8f 100644 --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi @@ -411,12 +411,6 @@ status = "okay"; }; -&bus_fsys { - operating-points-v2 = <&bus_fsys2_opp_table>; - devfreq = <&bus_wcore>; - status = "okay"; -}; - &bus_fsys2 { operating-points-v2 = <&bus_fsys2_opp_table>; devfreq = <&bus_wcore>;