From patchwork Wed Oct 4 06:05:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 114734 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2727093qgn; Tue, 3 Oct 2017 23:05:14 -0700 (PDT) X-Received: by 10.159.197.4 with SMTP id bj4mr7632686plb.354.1507097114452; Tue, 03 Oct 2017 23:05:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507097114; cv=none; d=google.com; s=arc-20160816; b=lB9LBRmm5x3ffEYo922qZvHVE+ORsAveSrB57AJCUCvMq03PKkTcfHCZmAmjCE84nF RMAz8qpbzw5wBJmK/Xv2UFSv9/CCOekIWgrSv3Yk8tDsyvro6C7QHrEHavvqQokBDe5z 8iz0Lqlb0X0M+98aqvOpqmLuB1K+x1HfSZMUS0aX8/2RHUqM1LD/aYNVvo9t0BnIo/wP gTCjLINIi+51IGtyTpmCaCyMjQNb3Vq5GVeFi7AFTMsLCezpLLvn1lQQn4lBJ4MsEPfv Q4mmvBnh/qZ/z1TPfbhwW26UaA0v3aK77d2ETWV9GopV+FBiIMRNOabA4RDqidt9vTAX QhTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=u3oJEI0z6jLo9CmA56ODkMNrU0caEua7PRQhgLl7mLk=; b=CqaXDVAQjPIECa+FZBBdForjocJSAqLOURTBb06DGxpVqcX1RDu4cCgyxz6rblMvzN Gl792hh7hYmqePArHg7hSdxbcG1MjPfhCipsp1VYGuGjdB75UvjTyP9dUnhrfTvLmdc3 0ILYq1Js5Eu3072/tlGHPgjoOUw6gDu9So5t+5dPeLFhFp+Z1TG9ryq/E5qJ9ToI4BfZ MvuwmtO3G9kPFWVuShPpVV5+aZ/ZpuKXFUYuHyQXdQBAvQddFjZ2kJizSe+0rm0Zaulb Poxt1Ah6hPfb9YXki2/HoLXZw9G1p6tmVW/akF5DgaFdilgKsi0shbyz+vSEpKAKw7/v VljQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RdjZgov6; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g124si552629pfc.180.2017.10.03.23.05.13; Tue, 03 Oct 2017 23:05:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RdjZgov6; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751213AbdJDGFM (ORCPT + 8 others); Wed, 4 Oct 2017 02:05:12 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:48405 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdJDGFL (ORCPT ); Wed, 4 Oct 2017 02:05:11 -0400 Received: by mail-pg0-f52.google.com with SMTP id v78so4196646pgb.5 for ; Tue, 03 Oct 2017 23:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=u3oJEI0z6jLo9CmA56ODkMNrU0caEua7PRQhgLl7mLk=; b=RdjZgov6JJP9jXDCT0D8w+RutRmd8QOOj/K6aM1hGVQsI9Uoiw8RsvyAkJO2tlNz45 5GKPh4cPHirLDZyK9qFmkuNgjuHwMzH/WEZGvCHZtPW3zZ3SmEzn7kCS6PtLyx1tEFNM JyGpurAPszoU5TY01q+mKxr3qhhwbCeEcXk00= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=u3oJEI0z6jLo9CmA56ODkMNrU0caEua7PRQhgLl7mLk=; b=slQhoXFhC8vbrHsW82+6+fTRS28V3wO/AoHt5s+ENDcqYufclDRzsTdVkOdMSBnxc1 V6a4AM+TV1J2fTmO3Xx4xl4pCLbT9Z/wtscVMc1UWmkRRf0o5d0f2Sb3iEE//T6RnaLX rgPW/6/H2vyWwDcN70NDrWk4kw9cuCadePa82ldpNsqucPfkYabmKTl5qyqQrYvtRAUz bNzWMIX68LHK9Ieos0AHkDwTudSNHSJv5geYRaMNgKAjqWRVWo9iZy/9F2uHwfL53+9e nU2DuRxio4v/k4zgjeYPDK0jWpegRA+g2VYi4D/zBrB290YmUHCCCYBH8TJ0wyfoHAAR o7YA== X-Gm-Message-State: AHPjjUgmDj68Kni9El3JbtdsVlVr4XwEJsrZY5sBc3QkDwidhc5smPsU 0NAFS1BX10vP00KqwWrS6HYvtg== X-Google-Smtp-Source: AOwi7QDxq7DV1VRM2+BM8pD3bMi86QjUn7hphy6HKyfwjHuKEsALXdMELsLgWc90ZsQJJsUtGZo3Ew== X-Received: by 10.84.130.67 with SMTP id 61mr19467496plc.131.1507097111209; Tue, 03 Oct 2017 23:05:11 -0700 (PDT) Received: from localhost ([122.171.87.8]) by smtp.gmail.com with ESMTPSA id k24sm11980525pfj.151.2017.10.03.23.05.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Oct 2017 23:05:10 -0700 (PDT) From: Viresh Kumar To: Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , linux-pm@vger.kernel.org, Tobias Jordan , "4 . 3+" , linux-kernel@vger.kernel.org Subject: [PATCH] PM / OPP: Add missing of_node_put(np) Date: Wed, 4 Oct 2017 11:35:03 +0530 Message-Id: <3a82b2d3311e16f0f638de18bf0ee803540014a3.1507096875.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.14.1.202.g24db08a6e8fe Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tobias Jordan The for_each_available_child_of_node() loop in _of_add_opp_table_v2() doesn't drop the reference to "np" on errors. Fix that. Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings") Cc: 4.3+ # 4.3+ Signed-off-by: Tobias Jordan [ VK: Improved commit log. ] Signed-off-by: Viresh Kumar --- drivers/opp/of.c | 1 + 1 file changed, 1 insertion(+) -- 2.14.1.202.g24db08a6e8fe diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 0b718886479b..87509cb69f79 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -397,6 +397,7 @@ static int _of_add_opp_table_v2(struct device *dev, struct device_node *opp_np) dev_err(dev, "%s: Failed to add OPP, %d\n", __func__, ret); _dev_pm_opp_remove_table(opp_table, dev, false); + of_node_put(np); goto put_opp_table; } }