From patchwork Wed Sep 2 04:02:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 251200 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE023C433E6 for ; Wed, 2 Sep 2020 04:04:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76EC120786 for ; Wed, 2 Sep 2020 04:04:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="LRZ6KHjd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="agc7SYV7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76EC120786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CDBFD1829; Wed, 2 Sep 2020 06:03:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CDBFD1829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019471; bh=8X6fOOnp8B7Z9ZhXKQ8b70eido++ofAReaSbfr5UfqM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LRZ6KHjdzYGYRglvxrnBZlCQqtrQCpSCWiiWVVrrS4xC6UYOoumH+EkJHo6gXQtxx 1ULM47diC+V1slqjgHfzpQ/OYbuGdfHOFACIugKusQ6bVGVmkXYgi4xcv3UYYCBtrV EO+6NJNYGMX3maETHR77apExT8E1nPPJjB6aytcc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5D3A3F802D2; Wed, 2 Sep 2020 06:02:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9A273F8026F; Wed, 2 Sep 2020 06:02:49 +0200 (CEST) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6F2D9F800BA for ; Wed, 2 Sep 2020 06:02:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6F2D9F800BA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="agc7SYV7" Received: by mail-pl1-x644.google.com with SMTP id t11so1659362plr.5 for ; Tue, 01 Sep 2020 21:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g3cpTjafgayQRIpdf+S3hnTmfkWRIRTNu+EldrSuk9Q=; b=agc7SYV7Bdvne2Q479y7ay01LUOMcmViBmOlwk4qXHL8PMhw7hmOT3BYLTCkJP7iCP OLMOeWB88nBXQ4EoFjVTSOQ10hxacisArFzPsSs2s7DTwqvTRhHJWZXMCEmcI3Uvp9MY Rwjc0Mdyl/85JqW1rA9IIz/rJLXk397jIchAVTWjiQyZweoj8dfxmC5e3uflzFIgQxP5 NVHfoKc/asLgNo/ylE2vw8UAwb7bWNmvFxA9FntZ61l8ha1Wf4KKnpApaOJCA5v4lcRp icKmjFU+XPSmEYaCQqS4QAlfRKPrL+l7fFbidsj3lypF2VbCdwObSULs41PO7AK5HkxG ByDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g3cpTjafgayQRIpdf+S3hnTmfkWRIRTNu+EldrSuk9Q=; b=IELcUI9vikFqeswD00LN3AvVStdRCbudo5fguzlUgBNCSIpjqKgU6cndrPwPRp8yAE eCF5JmWOJICoYxLlaEMAz8FMp285KXpEmqNkyYs7J/3NhHQmLor/4zCp7w0rxcsIbi88 rzyBbf6sTz/C5wbckRfRbVry7BmBiad5Z/XxpG8SYth/Csh1vNCoRJfzBZ5FiXoG+U3u 0gymKVl5eFEWK9vke0l436/xzSg8PSJY+Rr5lO2MvDgvKgQCOAGzuTb4EZJh9Tcx2mFf gDhOxZ9PRJO/yArEn2qAitiO6lfVx0h/WytE4gRBza8kmZ2qAJIZDuABFTvb7xREKk6f 7UsA== X-Gm-Message-State: AOAM532phn79b2V21qc7m/iSF17FHDUnJghKeoBJp+snGyjX5zoQkotW NI1aHgpLLxuJ/yzTJL2ayfA= X-Google-Smtp-Source: ABdhPJxiLH+0iQd493pFP3zsKqoD6J6je95d5IAC9QzEVfGSOjLg9ANjqLdETVBlowAnmQu6tBLkXg== X-Received: by 2002:a17:90a:4401:: with SMTP id s1mr444166pjg.79.1599019355349; Tue, 01 Sep 2020 21:02:35 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:02:34 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 01/10] ALSA: core: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:12 +0530 Message-Id: <20200902040221.354941-2-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/core/timer.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/core/timer.c b/sound/core/timer.c index d9f85f2d66a3..6e27d87b18ed 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -816,9 +816,9 @@ static void snd_timer_clear_callbacks(struct snd_timer *timer, * timer tasklet * */ -static void snd_timer_tasklet(unsigned long arg) +static void snd_timer_tasklet(struct tasklet_struct *t) { - struct snd_timer *timer = (struct snd_timer *) arg; + struct snd_timer *timer = from_tasklet(timer, t, task_queue); unsigned long flags; if (timer->card && timer->card->shutdown) { @@ -967,8 +967,7 @@ int snd_timer_new(struct snd_card *card, char *id, struct snd_timer_id *tid, INIT_LIST_HEAD(&timer->ack_list_head); INIT_LIST_HEAD(&timer->sack_list_head); spin_lock_init(&timer->lock); - tasklet_init(&timer->task_queue, snd_timer_tasklet, - (unsigned long)timer); + tasklet_setup(&timer->task_queue, snd_timer_tasklet); timer->max_instances = 1000; /* default limit per timer */ if (card != NULL) { timer->module = card->module; From patchwork Wed Sep 2 04:02:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 291890 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55610C433E6 for ; Wed, 2 Sep 2020 04:05:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2EAD20786 for ; Wed, 2 Sep 2020 04:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="V/Yffw+X"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aw8ufJR/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2EAD20786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4954F1800; Wed, 2 Sep 2020 06:04:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4954F1800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019518; bh=fD7D97RF+EzSuU8xugzmMqcDcR3p4t9D5EdB3ZJn7GM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V/Yffw+XWTCjqWyU9Ne9YuP95l1F+lknoGs8CeaM7HVVSAr1Dp9Cami3rjBMLv10D +xlLQRxFckeNL/oTOPZK2RZEAkhAcmPGNt2gIZYihNw/649Rn+/40GvZAqkB/9UY+W BAgw9oL12O211H3dDthoMM8rLNek/2VD8NF5tJBs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 579F3F802E1; Wed, 2 Sep 2020 06:02:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4DE06F802DB; Wed, 2 Sep 2020 06:02:52 +0200 (CEST) Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E732BF80212 for ; Wed, 2 Sep 2020 06:02:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E732BF80212 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aw8ufJR/" Received: by mail-pl1-x641.google.com with SMTP id y6so1648034plk.10 for ; Tue, 01 Sep 2020 21:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LdsvlK843OvHUKO3BvTM9ULTMfoE/b1eCx7N5gOQ7fw=; b=aw8ufJR/Zxuzp3V3cdeU8MncizZKkmAsoLzuFltqHudOuSEC3GZd70VuLZVjLYTg4x XQ8nrP8+7rj2GjuT++NgGbZOHC+vxEt0BUD39OHqeMR4vvsF2SuiU5ix+Ia9UYcgv4LS mhhjg7Zjn510I9rn8JwZTm20UgqkCJkOAP8Xr1D946JKdQdxsKFozJM33H4Ykfq7ZHqG 2oVlXbzq1zZKCeqdVBXhFrrGQNs3EQ6eL+31qWnOCK2QZeLdjbPDpg9VFkqapyC5oFra C2KeN7uB8I3WBFZRGkqI4KRJEH01T12FZfesib9oHWaxK8r7Qqm4TWCw43F7qjYNeHqH /VvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LdsvlK843OvHUKO3BvTM9ULTMfoE/b1eCx7N5gOQ7fw=; b=uZJe9i9sQpeBUQdBcWwocxvqU9O78jRKcEJqUyIUWCOurWAENX/oqzYJbAJQjGZ7o0 liUhY4g5GLYm//hCHLfFVqjx2Gm/3qYI2kbg93eB+F+D/mka64AJ/yKAk+E8SrJmk8da +2seUny+PNF1tcoR02mFRdFQ0nx4DBzE52wXatx3xYzwGoTL9w/mmkOlZNWKljT7cZeB 3byZlM0ZkOAw39kDIAWNkFEGQz7tRcBmhA1kGJiPD05/gESmzECo6E7tUXom3k7EPPHc nBbB15NMJ9AX9rKWHIWaWvreE/BOHCBTgwLLDlrGICCt5bJHj5q3iB8cZLZYZJ9WBd5E sQIA== X-Gm-Message-State: AOAM533py82iCLJdMr/PD/GhggcAZfkRmuct4RW+i2nqqCfkaMjKtCL2 t1+VrLPKhsq6p/608hXjHQlXSn/saHrYsw== X-Google-Smtp-Source: ABdhPJx/zehfDCXIDQbY2JBBV2a1VHy9Bl2xcHJ4Fva8Esde2W2acIaQn/HNv9ADTz0PeVU4C3Qa7A== X-Received: by 2002:a17:902:e901:: with SMTP id k1mr412736pld.189.1599019359027; Tue, 01 Sep 2020 21:02:39 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:02:38 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 02/10] ALSA: firewire: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:13 +0530 Message-Id: <20200902040221.354941-3-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/firewire/amdtp-stream.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index f8586f75441d..ee1c428b1fd3 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -64,7 +64,7 @@ #define IT_PKT_HEADER_SIZE_CIP 8 // For 2 CIP header. #define IT_PKT_HEADER_SIZE_NO_CIP 0 // Nothing. -static void pcm_period_tasklet(unsigned long data); +static void pcm_period_tasklet(struct tasklet_struct *t); /** * amdtp_stream_init - initialize an AMDTP stream structure @@ -94,7 +94,7 @@ int amdtp_stream_init(struct amdtp_stream *s, struct fw_unit *unit, s->flags = flags; s->context = ERR_PTR(-1); mutex_init(&s->mutex); - tasklet_init(&s->period_tasklet, pcm_period_tasklet, (unsigned long)s); + tasklet_setup(&s->period_tasklet, pcm_period_tasklet); s->packet_index = 0; init_waitqueue_head(&s->callback_wait); @@ -441,9 +441,9 @@ static void update_pcm_pointers(struct amdtp_stream *s, } } -static void pcm_period_tasklet(unsigned long data) +static void pcm_period_tasklet(struct tasklet_struct *t) { - struct amdtp_stream *s = (void *)data; + struct amdtp_stream *s = from_tasklet(s, t, period_tasklet); struct snd_pcm_substream *pcm = READ_ONCE(s->pcm); if (pcm) From patchwork Wed Sep 2 04:02:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 251199 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC34C433E2 for ; Wed, 2 Sep 2020 04:05:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E566C2068E for ; Wed, 2 Sep 2020 04:05:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="EYeC+NU4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sn/i7Ze1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E566C2068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 876C317F3; Wed, 2 Sep 2020 06:04:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 876C317F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019533; bh=UGhPDO8nZTHSlC+t5iQKmduar695bz15zzqGFgVFn00=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EYeC+NU4uT1vMPCfogaItZyIuzePOJmI4xSqCvr6W1nFAknxiMdTerlNKc8XXcvsv zCAK1hSlA3oAnFFWNUFZpUZdUXK8Nt8s9EspqmVZuYZKeAch/2iigV2BkjsCivlRDY PVyuE+qABtSB+hpyEJlN6WeCOe1QKGKSbM1Pfn5w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD20AF802E2; Wed, 2 Sep 2020 06:02:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0EA84F802E3; Wed, 2 Sep 2020 06:02:55 +0200 (CEST) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D8BA8F801DA for ; Wed, 2 Sep 2020 06:02:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D8BA8F801DA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sn/i7Ze1" Received: by mail-pg1-x541.google.com with SMTP id v15so1865354pgh.6 for ; Tue, 01 Sep 2020 21:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SEMER0Yl1msey7jbmUcwzm9t6QF1uQ9TeT9LlResx5M=; b=Sn/i7Ze1olxlPUS4CFA8N0HTZF3rNAeDg2ZU06A4/M0oX+UKesuASisEf1ZaQ7JcOm o60W6k2JwqlO6qdhbJgu8ZFNFknpTU/fHyoyl0l97E2kSYAhUSAMDEkDm1piNHG5BQQ8 t8IgHYSfbMlG0vSDa/QmOZ35ebqusTx+JQoibqoznLNxnrkVGKKd8LVrzb7bVCLmq/Hw r/mQ1dMY+0ue7WNaxLEDBZ9tw+5ACfU8mKNsc20i0g8Fq2zxhrsdwoQHktbH54MGCZVI p1kLqzLi66n/ZLvyZ0miQJLlcTQADnzNB7ZB0EEELrzRR2zTBYgYja3cQ+SU7N88G/fW NQkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SEMER0Yl1msey7jbmUcwzm9t6QF1uQ9TeT9LlResx5M=; b=JXcoB7Bnon3dkYTt/K6LNxXQzlYihurWiclt/9rBq2ZW/ZxbKINsmml0D4TKBCKq4G XDdOR0OdP0ACcUXIlv44eCM0Af0dNGyuwiaN7G/EnWSsf6BM2RjUAxUn56Moe+MNhIre yi1vFtRJY+XwKd7Anql6jKM5AxMzBTLS7kFxJVzZwb3zwGTXM9KtE1nZPNOBmzQecfra lWOrRvh1IBNrToUSbstcwq8PBi28haBDpZ9uYHQhLz7MpEQbPEI35/VAR4jtQvFfJWbn TLcvBBpYdpIhk7ooVWBmmBqBPg0dMcqawzkT7s9dEjk7nNRR/+SubANC0sZ2xU9o+Mlh HpEQ== X-Gm-Message-State: AOAM530zkxT+qOAo8Jryhh9pPuyLelLRgFzNNlVC/g4mpJopopQFTy8i LkjvkKiZF3ln6Wkmglgog9oRlpubflhUVA== X-Google-Smtp-Source: ABdhPJyoZ0csDV9d0iw+4/HXNVwwWvxBetnbEL0EJPyF00/4qWM2VSm2RX+roke7pN5kih0BpidUtw== X-Received: by 2002:a05:6a00:814:: with SMTP id m20mr1428346pfk.50.1599019362609; Tue, 01 Sep 2020 21:02:42 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:02:42 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 03/10] ALSA: pci/asihpi: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:14 +0530 Message-Id: <20200902040221.354941-4-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/pci/asihpi/asihpi.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c index 023c35a2a951..35e76480306e 100644 --- a/sound/pci/asihpi/asihpi.c +++ b/sound/pci/asihpi/asihpi.c @@ -921,10 +921,10 @@ static void snd_card_asihpi_timer_function(struct timer_list *t) add_timer(&dpcm->timer); } -static void snd_card_asihpi_int_task(unsigned long data) +static void snd_card_asihpi_int_task(struct tasklet_struct *t) { - struct hpi_adapter *a = (struct hpi_adapter *)data; - struct snd_card_asihpi *asihpi; + struct snd_card_asihpi *asihpi = from_tasklet(asihpi, t, t); + struct hpi_adapter *a = asihpi->hpi; WARN_ON(!a || !a->snd_card || !a->snd_card->private_data); asihpi = (struct snd_card_asihpi *)a->snd_card->private_data; @@ -2871,8 +2871,7 @@ static int snd_asihpi_probe(struct pci_dev *pci_dev, if (hpi->interrupt_mode) { asihpi->pcm_start = snd_card_asihpi_pcm_int_start; asihpi->pcm_stop = snd_card_asihpi_pcm_int_stop; - tasklet_init(&asihpi->t, snd_card_asihpi_int_task, - (unsigned long)hpi); + tasklet_setup(&asihpi->t, snd_card_asihpi_int_task); hpi->interrupt_callback = snd_card_asihpi_isr; } else { asihpi->pcm_start = snd_card_asihpi_pcm_timer_start; From patchwork Wed Sep 2 04:02:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 291889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C46C433E6 for ; Wed, 2 Sep 2020 04:06:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 406742068E for ; Wed, 2 Sep 2020 04:06:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kcQPP3+D"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TjgsXOg5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 406742068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CB6ED1840; Wed, 2 Sep 2020 06:05:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CB6ED1840 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019572; bh=x93pgomIBkVJcZhajgAt9oPhkSzzXzyHRpYhezI0NyQ=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kcQPP3+DbaMc5jDTydCfvT5AhNgyXp6DDebmgbdJkT1aa9uqqR8VD904RwbxqUzZG UdqoNcyF1GSUetPoSYhj/WwxFJMry5+9N1DTJnIXiLC1tNG/+lmLMletTU6Y9eJhPb kGCjRWTgsUSK/UA9EilcA2ecaOO7Aedwy40SeymQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2AF61F802EA; Wed, 2 Sep 2020 06:02:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 96DDEF802E8; Wed, 2 Sep 2020 06:02:56 +0200 (CEST) Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1FFCFF802DF for ; Wed, 2 Sep 2020 06:02:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1FFCFF802DF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TjgsXOg5" Received: by mail-pl1-x642.google.com with SMTP id l9so1650915plt.8 for ; Tue, 01 Sep 2020 21:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hszyES/Fl/Gw5AGYyyoWQldbZRH+o5Xzr54HG49ANFU=; b=TjgsXOg55yX9RAn8hTjPVDok97aH/aE/uvSPSjMNXF9j7Oe7EXHHAYXaHiZXr21uYB b88451DV6dwr/5Cr3Y87lJXwnNdsRFJdigYuwvyaM+uzU0LkE91EpRb880szRR93DX+t jE+T1I+NAjsckfnmwd/SxFdtNxmiqzbFS6GEwziyy1E+fyHJEuwx+R8KY3yLmbVE8BUm y3taJo57lv0vECQk6mUKQsdY82lcnhkG39WUka07JlcBE7nqdZNps9dj2hxsiE6G69dB HrlwrCh7BGPi5PpI3ZcffNBovw3BuHPTzZ+0R5/JXrWes5BubW/Wu2sadm9nRWeaynbq Gmwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hszyES/Fl/Gw5AGYyyoWQldbZRH+o5Xzr54HG49ANFU=; b=nU790zqq50yG3po9RpNiz9Ay2Ub2tNZmN9qdKkZVX9PFYOhepiANmFzy2S52ySdAyL 5J8QOSlfSiRkuduNCLzZqxghVqUharuvP5wWoK/VqM/7IrteATjpZDynD6iTeiib83MA XqXmkLmqOk3N4gCXG2cuj5PkbnymVuqkjHbjL1U8xXBpqxwX5M7OGkolOwoSoNOremHH Z3ISnkQPsKxPadXv9c69VfXAn8aNp2LvH72AOZ6zDCsF1q3fJKQluoIkbqhYfVao+8VM SUNj8dV0u9ctENnaHiNieqq4CgN9hPQsWLqgaET+eYg0j/vmSbZr8mzSurtzM+Esa8kL TwAA== X-Gm-Message-State: AOAM530amx67b4VpX+c7mbWQukMXG4Y0hg3lvzi/ysAxyUnTM74UKJJh RtrGlBnOrkj/wG+108niy78hrVYZvxDW3A== X-Google-Smtp-Source: ABdhPJx2dpNYmH7xmBm33vvi67A1Ibu1x1+BBcAF4mDU3sZ7Nv5R+QFauyGsMrXk9uB2yt/Vpc9JFg== X-Received: by 2002:a17:90a:8402:: with SMTP id j2mr461268pjn.153.1599019366292; Tue, 01 Sep 2020 21:02:46 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:02:45 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 04/10] ALSA: riptide: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:15 +0530 Message-Id: <20200902040221.354941-5-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/pci/riptide/riptide.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c index b4f300281822..098c69b3b7aa 100644 --- a/sound/pci/riptide/riptide.c +++ b/sound/pci/riptide/riptide.c @@ -1070,9 +1070,9 @@ getmixer(struct cmdif *cif, short num, unsigned short *rval, return 0; } -static void riptide_handleirq(unsigned long dev_id) +static void riptide_handleirq(struct tasklet_struct *t) { - struct snd_riptide *chip = (void *)dev_id; + struct snd_riptide *chip = from_tasklet(chip, t, riptide_tq); struct cmdif *cif = chip->cif; struct snd_pcm_substream *substream[PLAYBACK_SUBSTREAMS + 1]; struct snd_pcm_runtime *runtime; @@ -1843,7 +1843,7 @@ snd_riptide_create(struct snd_card *card, struct pci_dev *pci, chip->received_irqs = 0; chip->handled_irqs = 0; chip->cif = NULL; - tasklet_init(&chip->riptide_tq, riptide_handleirq, (unsigned long)chip); + tasklet_setup(&chip->riptide_tq, riptide_handleirq); if ((chip->res_port = request_region(chip->port, 64, "RIPTIDE")) == NULL) { From patchwork Wed Sep 2 04:02:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 251198 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180C1C433E6 for ; Wed, 2 Sep 2020 04:06:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AA8E20786 for ; Wed, 2 Sep 2020 04:06:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="a4DAbDU4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJfSZAQF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AA8E20786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 14CE01850; Wed, 2 Sep 2020 06:06:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 14CE01850 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019614; bh=2gINi1V3qDxftE80kJvy9klZRKOxWvJCtV3jvALYoPk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a4DAbDU4jnRw1h0GWMO/XcRrb7RMuEEah4+cATy4jKpP9wQTqYYUqEze32Zr416Ee vIrGtGH9zGPv4wRkTDRwI/RE8knA8ZR0kEW24Yz2KSJp/vUD6CL7Ka+FTYK4CkEl0u eZwVgEQ+J6Iv72T+Wejt9L6/rcFkS3i62HVCQkNE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5D171F802F7; Wed, 2 Sep 2020 06:03:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9BB68F802F8; Wed, 2 Sep 2020 06:02:59 +0200 (CEST) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D5275F80212 for ; Wed, 2 Sep 2020 06:02:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D5275F80212 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJfSZAQF" Received: by mail-pg1-x543.google.com with SMTP id w186so1858848pgb.8 for ; Tue, 01 Sep 2020 21:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sGG3rAOIUtBwifyFrh+uay3mLGw7gglSc8A6kESWHzo=; b=JJfSZAQFEvqT9kbV5uHWA1gotLUHMAdFJQ/LH6wPrHNkEx6n7+RDwywqzSrk7HoanN 6IfloxZ0XHRDZT4QI0q9KkKzAbAjm1nc0dEGvCV01f6ddjlGVnLa+pimhdqZqAjq8wtz 4jQk168hcBtUIn/sF0nRlI5YVCEaGVb+VuN4sbmSVG7EFyG9FMmGnJZ72MBK863kMDB9 OVFjq2KjBdUrbfAjJLIGohVeChnpPgpJnDPTFMyNgP1OAcNxqs1ulAIC7ee9p/z8r40Q Op6tN/Eky3CqXLoVfs2NWqLlhWYRlH4w3EGjXCxTdTrZZL0pVJxVVq2TGYUhl/7rN0kc LFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sGG3rAOIUtBwifyFrh+uay3mLGw7gglSc8A6kESWHzo=; b=erNjP4faR/fcRK3vjm+AQMhYOC35+Ht7hweKOB9tOFkNAxiWZr7UMjuJg/QxcfMdzz GSbvf8DjapAMw/0pBmXG3AWrcQHjw1s1qjVtung1/U43bWJAA61HSV9h8FjmNF76S8je n3kYVEy/uy2O/QBsnS7JtbW110EtM35QORKy4yt1eXh8qQv527qX7NS9Jn8AMFWkqiiI LlBVN6lz9llwd/IwnB/OaOUzVdZkXc3J1PP1U7/oagRLKl7scc0A8pokAs4YqCNVzNDO aQct3pwmFyl87i0kBfL5yJx280hBKrKxigb70OgcCcTDvUCYiUYvTc9HNpSVHqWHrEWq Y1UQ== X-Gm-Message-State: AOAM532dhgb8Lan2mAst8iN6L+MT2QNXIQxs1MrJvqiBtpNV2X5i5LOB AnyrIIW/yA+V6LdN3jQZB04= X-Google-Smtp-Source: ABdhPJyCaY3eWYqoZFQL6PxrM7qyrGmhHHSn5WRwoULcTXOeZIv7VoMCQDkgEAB6l0fPn5c2LWjHmQ== X-Received: by 2002:a63:5361:: with SMTP id t33mr391974pgl.245.1599019370290; Tue, 01 Sep 2020 21:02:50 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:02:49 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 05/10] ALSA: hdsp: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:16 +0530 Message-Id: <20200902040221.354941-6-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/pci/rme9652/hdsp.c | 6 +++--- sound/pci/rme9652/hdspm.c | 7 +++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 227aece17e39..dda56ecfd33b 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -3791,9 +3791,9 @@ static int snd_hdsp_set_defaults(struct hdsp *hdsp) return 0; } -static void hdsp_midi_tasklet(unsigned long arg) +static void hdsp_midi_tasklet(struct tasklet_struct *t) { - struct hdsp *hdsp = (struct hdsp *)arg; + struct hdsp *hdsp = from_tasklet(hdsp, t, midi_tasklet); if (hdsp->midi[0].pending) snd_hdsp_midi_input_read (&hdsp->midi[0]); @@ -5182,7 +5182,7 @@ static int snd_hdsp_create(struct snd_card *card, spin_lock_init(&hdsp->lock); - tasklet_init(&hdsp->midi_tasklet, hdsp_midi_tasklet, (unsigned long)hdsp); + tasklet_setup(&hdsp->midi_tasklet, hdsp_midi_tasklet); pci_read_config_word(hdsp->pci, PCI_CLASS_REVISION, &hdsp->firmware_rev); hdsp->firmware_rev &= 0xff; diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c index 0fa49f4d15cf..572350aaf18d 100644 --- a/sound/pci/rme9652/hdspm.c +++ b/sound/pci/rme9652/hdspm.c @@ -2169,9 +2169,9 @@ static int snd_hdspm_create_midi(struct snd_card *card, } -static void hdspm_midi_tasklet(unsigned long arg) +static void hdspm_midi_tasklet(struct tasklet_struct *t) { - struct hdspm *hdspm = (struct hdspm *)arg; + struct hdspm *hdspm = from_tasklet(hdspm, t, midi_tasklet); int i = 0; while (i < hdspm->midiPorts) { @@ -6836,8 +6836,7 @@ static int snd_hdspm_create(struct snd_card *card, } - tasklet_init(&hdspm->midi_tasklet, - hdspm_midi_tasklet, (unsigned long) hdspm); + tasklet_setup(&hdspm->midi_tasklet, hdspm_midi_tasklet); if (hdspm->io_type != MADIface) { From patchwork Wed Sep 2 04:02:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 251197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90334C433E6 for ; Wed, 2 Sep 2020 04:07:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 159E32068E for ; Wed, 2 Sep 2020 04:07:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="bOYrnnC4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQ7doj9I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 159E32068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9DA3B1868; Wed, 2 Sep 2020 06:07:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9DA3B1868 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019677; bh=p8sv6kqImDY5NVcFwe8mJIagzkq3LIFPLui3Nr+zTME=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bOYrnnC4qpbGvWk81LGVw4WzkxpHjDgI7q0heLW7rLJSBRj1N5+rY6vxWEIfem7AF glbLTaUiS7tb7jWHiJIFTOLIsjFYzSCT/5w6pM1G7RFLa9daZvzZgynVcvltdOD6jn Vv8MNnO9nc4pOq1NoHir3050P5dCcDCtz+/00gio= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8BCFBF80316; Wed, 2 Sep 2020 06:03:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3768DF802FE; Wed, 2 Sep 2020 06:03:07 +0200 (CEST) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0109CF802F9 for ; Wed, 2 Sep 2020 06:02:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0109CF802F9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQ7doj9I" Received: by mail-pl1-x644.google.com with SMTP id z15so1652724plo.7 for ; Tue, 01 Sep 2020 21:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k0GnVK/bRT0aDvxdkx//PUkfpDKNzaBGv8SVt3ojD/8=; b=TQ7doj9I44t0sRzxnzhn0hapcozhgffluKOPJd3QpRDFo22WFPipnr9xKkMyiBO3RQ j4Z9soMSX8e7IuvhciBox0cZD70N6Z6VZ4mtAuqhKfzP3EFS1cw28wKl/nixj279jlmL +lUC0mtE6X5vrdddMWd9h72XDRpiIyWWhy/47TfDS48umoBouugnR+qhHLaJ/axcl8Sb 2NqDcetmYPU8n9o0GYPCGnwUrpihIHpAhQjNhczxp/zd8IZOaGJl5YSrV2OwnAkcJ6gQ lfDSOk+As8gm9joUnPHd2w9nhKgXpeTaL2k4cmXrO18yrElWhyuCZ4TRFDzd90MtvtyB qEog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k0GnVK/bRT0aDvxdkx//PUkfpDKNzaBGv8SVt3ojD/8=; b=sL9SWB40hOHDdjX7DF01mmqgybFCw+BZDsAEs32XKI0gkPN5WPVIG5IWEAP7PrcwXw sUSMwBPJrRGMPcnX6m1cqv/B4Ro3iiuj6jn7tPJbQVwLP2O0pPfLvLknX08qTmbmp+4c jnAluxgNgt7W1aHYOqJo3HVjJEPJb4PdSUy33m7nRh1N5sn1H+nJqyEcNBzraRqvVBfI 1wSjOe3Mvb52pokHo0nI2O4j4XQyvxiy2yXD6c8kQMbe0zFv5+4+25nSGWB9mmQEk5HN jV24O+T55qE4CrULfJyKmtluSCMBvRaqkpgqlUX8/QcDJl2QqwGF+kuhbYxe6HwXDOJc CmQQ== X-Gm-Message-State: AOAM532C1I2HGXBlLKPbGgK49eGtPswEJhXo++deZF666I1Po4ImxSVV NwsbuOBmLUrBtnPGkrd/zRA= X-Google-Smtp-Source: ABdhPJzLGH4+1YM/vJshxTESb6/GURbIA6mgHUWGzcUKqVenwrAS+Ge8bi5y7J0UTp65dF9FW2wvAw== X-Received: by 2002:a17:902:56a:: with SMTP id 97mr450045plf.130.1599019374003; Tue, 01 Sep 2020 21:02:54 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:02:53 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 06/10] ASoc: fsl_esai: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:17 +0530 Message-Id: <20200902040221.354941-7-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/soc/fsl/fsl_esai.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 4ae36099ae82..79b861afd986 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -708,9 +708,9 @@ static void fsl_esai_trigger_stop(struct fsl_esai *esai_priv, bool tx) ESAI_xFCR_xFR, 0); } -static void fsl_esai_hw_reset(unsigned long arg) +static void fsl_esai_hw_reset(struct tasklet_struct *t) { - struct fsl_esai *esai_priv = (struct fsl_esai *)arg; + struct fsl_esai *esai_priv = from_tasklet(esai_priv, t, task); bool tx = true, rx = false, enabled[2]; unsigned long lock_flags; u32 tfcr, rfcr; @@ -1070,8 +1070,7 @@ static int fsl_esai_probe(struct platform_device *pdev) return ret; } - tasklet_init(&esai_priv->task, fsl_esai_hw_reset, - (unsigned long)esai_priv); + tasklet_setup(&esai_priv->task, fsl_esai_hw_reset); pm_runtime_enable(&pdev->dev); From patchwork Wed Sep 2 04:02:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 291888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E10C433E6 for ; Wed, 2 Sep 2020 04:07:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDF7520786 for ; Wed, 2 Sep 2020 04:07:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="KdFtYSzR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fmcA5hII" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDF7520786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 61ECB182D; Wed, 2 Sep 2020 06:06:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 61ECB182D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019631; bh=Hii11Vv01hJLffOFq0gh/Cpl9BEc4hK2AN5GnsqTrxc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KdFtYSzRQ8qgYaN4CIHMShY40ZjLWOP0T+Ui9Bgir1AD5jmSzmy+LhvNfo114q4dl w8qMEq+lmH1hk8M2oGX16MhLrPrKmHR/aprCk1bUfT1IJ/GAtCNB8wd74Oj8DAOcdc 8qw3tyuGnpVQ0Wgw2ccdGUzNO4/6iUwA4tq5u+Nc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BFAC4F802FE; Wed, 2 Sep 2020 06:03:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 25AADF802FF; Wed, 2 Sep 2020 06:03:06 +0200 (CEST) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A6C73F80212 for ; Wed, 2 Sep 2020 06:02:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A6C73F80212 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fmcA5hII" Received: by mail-pl1-x644.google.com with SMTP id c15so1659305plq.4 for ; Tue, 01 Sep 2020 21:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=057MQRcXwBybksLEq1JjeqZlXpzUKHEjqPT9u+T+lUY=; b=fmcA5hIIK6NFT5wXEF/poQ1rqr35v045PQHj49YAznjGCFDbTxJL4Y1DbIoy90PXxc P1F7RWGwdLycks6pPj0yX8kUZM92yWHdhr8d8p3dmovUrTGDyVfZxnbkMfPo5YLgtWRE /HPyRo3YwFNyuKR6SnK+YzXaUXwwrcrkXuIpjVCaG9i3ZcBBKq/22Ms3j7a2YojRTmoh 9tOHkNNcvJU9uMsTexewVTNCxuDzIxKD/AVf0juPJxvJELLqnrmsYlj2QNnhjBog7t1U aZZUOzBTQejbd0sYFvlu3OPrsW573Nj8A0jYgpMcuGDZH/nU/9XbaI7F6Ilrzggex4si N0og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=057MQRcXwBybksLEq1JjeqZlXpzUKHEjqPT9u+T+lUY=; b=M7RJjDFMqOodpa/WKwJM2glmPHRf+ucnoTS3fAqYuFZKUenuryqwHGLl0GouvwvFSn GgFhSr7iTy0rVfHpi6LUPjqHvM0bOtsS7bjtKpLiF+CU2Zto3jraOW/FApAc2F8+C3uB BR4vM56f2TUs3KZezonoQsDeKnPUHGZzcjOQ3xvKsSEIMBzgXrX36Qp6t1f7urszGCeq LKjNu90laRe8qj7H+a6j8flgcNktmiGm5uIUP4rb4oni063uVzA6ETb+nzHl1mptlkxI yl/e8Aii3JY6z/eStiCfvmb9siqE4bQ9M8Mb9iy5as9E+bcPpvLWtEXsFKKhn16JLHqy k8/w== X-Gm-Message-State: AOAM530UYrjw4QrbiCkQZYSyqmsRRZ4J/z9aips2ByabvFINTO2a7ws8 PGinVNx5nRnZwwgaJ/XYtVROic66NrSqfg== X-Google-Smtp-Source: ABdhPJw+0dMt2KzEOeXEwgtu8UEfC0HyjL0lr0vEA6dAFoqFRF+ayNi123BPcbRpoEKpf0t/VPx5fA== X-Received: by 2002:a17:902:8605:: with SMTP id f5mr410484plo.263.1599019377817; Tue, 01 Sep 2020 21:02:57 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:02:57 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 07/10] ASoC: siu: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:18 +0530 Message-Id: <20200902040221.354941-8-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/soc/sh/siu_pcm.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sound/soc/sh/siu_pcm.c b/sound/soc/sh/siu_pcm.c index bd9de77c35f3..50fc7810723e 100644 --- a/sound/soc/sh/siu_pcm.c +++ b/sound/soc/sh/siu_pcm.c @@ -198,9 +198,9 @@ static int siu_pcm_rd_set(struct siu_port *port_info, return 0; } -static void siu_io_tasklet(unsigned long data) +static void siu_io_tasklet(struct tasklet_struct *t) { - struct siu_stream *siu_stream = (struct siu_stream *)data; + struct siu_stream *siu_stream = from_tasklet(siu_stream, t, tasklet); struct snd_pcm_substream *substream = siu_stream->substream; struct device *dev = substream->pcm->card->dev; struct snd_pcm_runtime *rt = substream->runtime; @@ -520,10 +520,8 @@ static int siu_pcm_new(struct snd_soc_component *component, (*port_info)->pcm = pcm; /* IO tasklets */ - tasklet_init(&(*port_info)->playback.tasklet, siu_io_tasklet, - (unsigned long)&(*port_info)->playback); - tasklet_init(&(*port_info)->capture.tasklet, siu_io_tasklet, - (unsigned long)&(*port_info)->capture); + tasklet_setup(&(*port_info)->playback.tasklet, siu_io_tasklet); + tasklet_setup(&(*port_info)->capture.tasklet, siu_io_tasklet); } dev_info(card->dev, "SuperH SIU driver initialized.\n"); From patchwork Wed Sep 2 04:02:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 251196 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16BC3C433E6 for ; Wed, 2 Sep 2020 04:09:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C77420786 for ; Wed, 2 Sep 2020 04:08:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="S/bCle4u"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8vKp6nv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C77420786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10AE5183B; Wed, 2 Sep 2020 06:08:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10AE5183B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019738; bh=RfoDALacRYcfmNG9smq3J49ESPzsHsS3+ji8L6x74Tw=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=S/bCle4utTht0kVcPseY3jq6Zvm4KfZ0dnksHeR5nOQ7J1EOoVpuvnvI+KVNCfm0x 3+UL9kUO0uYp+6VASSxN1akbvWXvfVi5Suk8dmuj/TNPwBfyk7xunrewE9ED74wGDe aAXG2hlf/ht0Ye4XJy5H+Zb5rlfM6cHrb9pnuZRQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 49930F80329; Wed, 2 Sep 2020 06:03:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 38E90F80323; Wed, 2 Sep 2020 06:03:12 +0200 (CEST) Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D84B5F80305 for ; Wed, 2 Sep 2020 06:03:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D84B5F80305 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8vKp6nv" Received: by mail-pj1-x1043.google.com with SMTP id n3so1581419pjq.1 for ; Tue, 01 Sep 2020 21:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4l6m+WeLDQfpIMgWVQGyj+skWIufOXW1m4ZGt68JApA=; b=m8vKp6nvPB2XefuOZINWLncQxz0y3mAzpjmrYSK9li46N3Vph9BM14V8QqB12uFqa+ HzsYvpw9/6xOuJQOwotRNa4zlPMYOLNtGBe7Jl2NWdAYz8QxEsRHMHiSA0puQ0ob0cGo YHqrS6JOl/Z5U+4heEYf+JmNOVUkWhXKTKMPmok16m/IyJthlFCJwBxGKHZidTtPGiRm GDkBFIyZJmFOBHVLgh0ZhDWcR0InuZ3x0GsSmQmvPJOb+cCb/0HriQQhoim6CGOJKRFf pAl78TO424zg92LmAWPnNwDenQIn1UcBwIpIBHBg3RsifjJ/EGMrfoLQ44BEj1u1Kn07 s9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4l6m+WeLDQfpIMgWVQGyj+skWIufOXW1m4ZGt68JApA=; b=IzQGnIem6bneVspOTNbSbe5Gtv9oLCpjmCRer2g0v9HjTQ0LkNzoRMER7MgmG7xV++ SDj05FjoApXwr1Te+7pBuX+7ZxPX0ODTZT9f1K71aOlPLebMtEsbwuktTZScmx6tVkeS WSye4nAc5ChmPcCrpzf59+/OrUWKNQ++5YIEnFp/TrYFU6+RlsYcp575z6/Uy9nLoY8C tRzB8B6GkDT1PFd0uxtt5Ty43A+Z2QaNn3KIAfWYDN++7knaQXmatH0MF5kGRmorIAw+ iWRD/wg+UbU1nDSS9vk/F504vZSoD8OaZ/sptNnx6P+0GH0W5EM/Z9zGKyxRzEiS7yev HSFw== X-Gm-Message-State: AOAM531ZwrKAJ5LHUT//dBq2s7nzrcqvnCClwaPGVzysQ0Bi07ruPsu+ sgabpbaHFjyywXVVacdke/Y= X-Google-Smtp-Source: ABdhPJwC1DwKcoGWz6+j9lsx8mzgOPzq+ozMcgLqkSgO62+3fWeXeBhhScz2SGKU2OgJjUTXBHyT/A== X-Received: by 2002:a17:90a:9a92:: with SMTP id e18mr443853pjp.211.1599019381319; Tue, 01 Sep 2020 21:03:01 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:03:00 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 08/10] ASoC: txx9: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:19 +0530 Message-Id: <20200902040221.354941-9-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/soc/txx9/txx9aclc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c index 4b1cd4da3e36..939b33ec39f5 100644 --- a/sound/soc/txx9/txx9aclc.c +++ b/sound/soc/txx9/txx9aclc.c @@ -134,9 +134,9 @@ txx9aclc_dma_submit(struct txx9aclc_dmadata *dmadata, dma_addr_t buf_dma_addr) #define NR_DMA_CHAIN 2 -static void txx9aclc_dma_tasklet(unsigned long data) +static void txx9aclc_dma_tasklet(struct tasklet_struct *t) { - struct txx9aclc_dmadata *dmadata = (struct txx9aclc_dmadata *)data; + struct txx9aclc_dmadata *dmadata = from_tasklet(dmadata, t, tasklet); struct dma_chan *chan = dmadata->dma_chan; struct dma_async_tx_descriptor *desc; struct snd_pcm_substream *substream = dmadata->substream; @@ -352,8 +352,7 @@ static int txx9aclc_dma_init(struct txx9aclc_soc_device *dev, "playback" : "capture"); return -EBUSY; } - tasklet_init(&dmadata->tasklet, txx9aclc_dma_tasklet, - (unsigned long)dmadata); + tasklet_setup(&dmadata->tasklet, txx9aclc_dma_tasklet); return 0; } From patchwork Wed Sep 2 04:02:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 291887 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8712C433E6 for ; Wed, 2 Sep 2020 04:08:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 608CD2068E for ; Wed, 2 Sep 2020 04:08:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Bhcb9LJp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PjOlHgMd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 608CD2068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F32F91795; Wed, 2 Sep 2020 06:07:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F32F91795 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019715; bh=sB4NO32u3k0ksbHkvfEXfRVGTLjus4aikpZLdNJ4coc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Bhcb9LJpj4vgw0FczYWE6qj53/vRCTiPxord4ZNfEic2hYNfr//qLMGK5HdiDescT KDVR94b/V8Ds8qFv+22zP7Yx5pQYg0aJ1DueB8cafmm4jvvO0iQzjNbrSt25Ja/gwi iPov11BkvEs1tBLHFRM/m8LidoPhMi+vAc8A/bO0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 27C5AF80322; Wed, 2 Sep 2020 06:03:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0C7DDF80323; Wed, 2 Sep 2020 06:03:11 +0200 (CEST) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BB65BF802FD for ; Wed, 2 Sep 2020 06:03:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BB65BF802FD Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PjOlHgMd" Received: by mail-pl1-x644.google.com with SMTP id t11so1659880plr.5 for ; Tue, 01 Sep 2020 21:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=37ef/2uHWpmUjX7q9CvN/aYbv90bI+l+bajno0icC74=; b=PjOlHgMdqr5JnRZzQ8R2aSfPnemuiPgBJHcY83QXluFCNgFjwLcvwaFnNuF77bOjjg femft+gOb6Yg5hF4Cq9s5q8JZsKH7e6O82fVx9hXzU6vvqWcn7ivp1zZSm4mLXYzB9j0 Imh89aI6w4sNCGtswrDYRFkgWkdVktYzfgeuPtr6js5TtYFuIk5oulgL0nKejnIEi+kG gplnY/E8g9b1uqmoifHzCVKhTK4wgmch/uI5q1CUM8XQdCrz4GIuByL9ni83ffCLCcH3 e8F3x76eorp+Evo0dhHy0esJFCNKTu9S2VapSoX6KncA9RSxMAID4klrynUy5dVyYI8P gRkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=37ef/2uHWpmUjX7q9CvN/aYbv90bI+l+bajno0icC74=; b=HjK4JYdO+kAb8OrD4gTyu1lkYB3zpFrTDMHp3ycR5TE+s2vsoNL82a+qrmqUyvA+iH EHvdv9+ZuGBGSM2PqYj3Yob1B9VcQbz7HxaEgyNkEHtPBFIFm0aNjrR9ZFCfJhJ6Snd4 6A7EztpTahaaF3rYroEmlvkgrDg/TX91AVrcdlZ6uunio1jCsIXo4l+INiHdgcWrpsb5 TSeDUTn0ih5RthI6tCvw+NQR8wg6iFttVpCI7Mirn0BtxUTs68Qy9bCqTPAmpGMpKRVR Uqy+qpZHYXDyAlrc9DvAQ63daA4Jdjqg+iF7EhEdABbeuex+c4KU96ETFQMyDoagWbGa 2V7A== X-Gm-Message-State: AOAM5325hpPmG/tCPP2QHtw6uRk1I2emnL1eFrkWGckIqGzPtO14sWrG 2Vk6emXvTIuKXbt/pZqpoOE= X-Google-Smtp-Source: ABdhPJwAYV/167xS5B100VG67zPvENskXjTL72WyXmoJIo9on3Xu6AnqJTtaGISaatOt6deBM9R5pA== X-Received: by 2002:a17:90a:19d1:: with SMTP id 17mr454997pjj.93.1599019385261; Tue, 01 Sep 2020 21:03:05 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:03:04 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 09/10] ALSA: usb-audio: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:20 +0530 Message-Id: <20200902040221.354941-10-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/usb/midi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/usb/midi.c b/sound/usb/midi.c index df639fe03118..e8287a05e36b 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -344,10 +344,9 @@ static void snd_usbmidi_do_output(struct snd_usb_midi_out_endpoint *ep) spin_unlock_irqrestore(&ep->buffer_lock, flags); } -static void snd_usbmidi_out_tasklet(unsigned long data) +static void snd_usbmidi_out_tasklet(struct tasklet_struct *t) { - struct snd_usb_midi_out_endpoint *ep = - (struct snd_usb_midi_out_endpoint *) data; + struct snd_usb_midi_out_endpoint *ep = from_tasklet(ep, t, tasklet); snd_usbmidi_do_output(ep); } @@ -1441,7 +1440,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi *umidi, } spin_lock_init(&ep->buffer_lock); - tasklet_init(&ep->tasklet, snd_usbmidi_out_tasklet, (unsigned long)ep); + tasklet_setup(&ep->tasklet, snd_usbmidi_out_tasklet); init_waitqueue_head(&ep->drain_wait); for (i = 0; i < 0x10; ++i) From patchwork Wed Sep 2 04:02:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 291886 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898FCC433E2 for ; Wed, 2 Sep 2020 04:09:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 106FA2068E for ; Wed, 2 Sep 2020 04:09:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WgsZ09VT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="THZ95p1B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 106FA2068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9527D1795; Wed, 2 Sep 2020 06:08:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9527D1795 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599019774; bh=0LrA13Z6D3tRAXhxLQMEKRQfMerLWSkbtsdtl2pj+JA=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WgsZ09VTsiOC7AGaj4RR6ZLAiY1NJ3y1Ljpwm9T1yn1B5BIIyX+UhbkFqCR/Swroq ew/1J4a7J0/+8kqkAevDUGV9c3m77++7jcHt1bir/vFcHDq4ABbKMSgq0uopSIxmFR PUxFYQYoGJHeO8YW55HGOf5mv/+VkdR8bpOQYr98= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 50A6EF80334; Wed, 2 Sep 2020 06:03:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C0589F80335; Wed, 2 Sep 2020 06:03:21 +0200 (CEST) Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B47BFF8032A for ; Wed, 2 Sep 2020 06:03:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B47BFF8032A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="THZ95p1B" Received: by mail-pl1-x642.google.com with SMTP id y6so1648578plk.10 for ; Tue, 01 Sep 2020 21:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AOJMlWBC7Fo6+79XuvkGFq5GSjsDSAjFTpzZO2SYEwc=; b=THZ95p1BwgDmC3u7AqLFD9/UwdkbDRfadtwJf2kPikYI04v//MQLk7nzTCc8dsTBkM JwjkcJ/ZIhsDCBJufazxDXtYGTXHrNkBrM8sPvE+6jbDn2a4DOpC4nZwLM/bVFz9PxPz PMo53mtYOP1el/HZ46R6b4xr6HZXmt3utGaTHNmmLXjy8BGkAQARf9kspP6MJM2+zkdK /IbG+R+A7k8PFa+iv6QoEH53arCIgiCFxcyrkaTSE/qZPUqI13BpgyJZZUyaeUZP/8KT LZXz2lbPVrJ3YJhWjy1j9SJfcisHtIDOkJKN6UVBhGkNPlxrsfPuZ4n4lrqla6u1ttco ZN7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AOJMlWBC7Fo6+79XuvkGFq5GSjsDSAjFTpzZO2SYEwc=; b=QZ+bXzrrtKHZflpBnNEc5oITPl3WpAW6JtAKNPQnZiR6vQ23E9+MJ+yxcJJUj6ZYPF JXPYlgFnAxtSZYqEgIATYCHcLpSMbtXdzbvSFK7Hfr8nr/Nl9PeHoGCPUVnuIOMwIIqT vSm48FWfbshdem3xW/r6f+eWHst1YLHsIBsuCE81UYh1GYpOvlR3l9KiqCmD/6NLvw43 BPXX3o/eY8LY30GVU/aSrreCClqzjyVu9wgHNRAOrOp8sePc6+kvbQfBDQpYIb6oAGoY 3fpGDMvAgUlcRicDczUXbcxGWk6XM4LrdaavGbmKvqRejmJo6gFqWKKGXZVUjsJ0U6AG kngQ== X-Gm-Message-State: AOAM532z7v4/7GhfTSRZmI3XTdGlrl8OZPfDS1/Tnq49dilsizWQ3ZF/ rlUISxRPNxvpqM68olwt0Tk= X-Google-Smtp-Source: ABdhPJzxxbfPWUt/EUSMNVa84o6WVx4mR2bcH1WBUNt85OWbyUl8v6snpqdbxafiT6SdhJ21McP+kg== X-Received: by 2002:a17:902:ee0b:: with SMTP id z11mr438497plb.268.1599019389111; Tue, 01 Sep 2020 21:03:09 -0700 (PDT) Received: from localhost.localdomain ([49.207.196.170]) by smtp.gmail.com with ESMTPSA id q71sm3058350pjq.7.2020.09.01.21.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 21:03:08 -0700 (PDT) From: Allen Pais To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org Subject: [PATCH v2 10/10] ALSA: ua101: convert tasklets to use new tasklet_setup() API Date: Wed, 2 Sep 2020 09:32:21 +0530 Message-Id: <20200902040221.354941-11-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com> References: <20200902040221.354941-1-allen.lkml@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de, Allen Pais , nicoleotsuka@gmail.com, Romain Perier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- sound/usb/misc/ua101.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/usb/misc/ua101.c b/sound/usb/misc/ua101.c index 884e740a785c..3b2dce1043f5 100644 --- a/sound/usb/misc/ua101.c +++ b/sound/usb/misc/ua101.c @@ -247,9 +247,9 @@ static inline void add_with_wraparound(struct ua101 *ua, *value -= ua->playback.queue_length; } -static void playback_tasklet(unsigned long data) +static void playback_tasklet(struct tasklet_struct *t) { - struct ua101 *ua = (void *)data; + struct ua101 *ua = from_tasklet(ua, t, playback_tasklet); unsigned long flags; unsigned int frames; struct ua101_urb *urb; @@ -1218,8 +1218,7 @@ static int ua101_probe(struct usb_interface *interface, spin_lock_init(&ua->lock); mutex_init(&ua->mutex); INIT_LIST_HEAD(&ua->ready_playback_urbs); - tasklet_init(&ua->playback_tasklet, - playback_tasklet, (unsigned long)ua); + tasklet_setup(&ua->playback_tasklet, playback_tasklet); init_waitqueue_head(&ua->alsa_capture_wait); init_waitqueue_head(&ua->rate_feedback_wait); init_waitqueue_head(&ua->alsa_playback_wait);