From patchwork Fri Oct 13 14:04:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 115774 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp770285qgn; Fri, 13 Oct 2017 07:04:41 -0700 (PDT) X-Received: by 10.159.242.196 with SMTP id x4mr1469269plw.68.1507903481098; Fri, 13 Oct 2017 07:04:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507903481; cv=none; d=google.com; s=arc-20160816; b=q1kIUOGhVrAhImLJzzX8pZEv+8uTmh/OmZwIWTRBhftSRKf4+DSkkF2qFFV6lariuI Kc7agpZKrIUc2vaQHst9Uvb9sW4kLa7q0dYr4nzSPYr+HcojxKlzMfSrqfuHFs/9oKrx /FKe3a7w1pPsWMYCDc0ool2p7v1wSUmBlqxS22ZfaU3opeNl9pVcF+dXfcEEWugQzeGz 5RR1SU404o/QPRl+PVOyweL2afh+baXpAOElDETR5moYATZyzKlTiN19rkliY3/g9xcq qTqaKRpsSOUwe3Kj7Ck0SlFZevT0NGgeCtcIdCjvvJ7xAvMoOpASN/yjMfMHrws0LtKH qqlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:message-id:date:subject:mail-followup-to:to :from:delivered-to:sender:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=ElAFwSEXT2YLtsky4wKwt/xRkcqXjdLMp3HMxZBotts=; b=yOrFlEMRR1sxfrLhwx1PwBWoLb+raoIZjMVb1W5PRLJTYtqscD2J+2X1hSf80SRU2y a833rCFxhvUr6yMkB3Dak8oJ93xPxhmfISdOI9aHpXfbAw+95CuZfnk1cPlPA++cRlOK QOvquiDulS8ef964T+135DkLuJoN2SHc+AZTjsBJgpxFGAuKqLvxCeY/LLtEGOyLpS+i L1LoJfMnOaHE95pbUpKmwplx1UeZwW/jWvBJYR+oNSc2FUjAntEFDDdxMuhYxVVAXzuq z7kH7W/Hl+nXR3mUnwuRcWBaCnV0TAeKRO+sAdtC7GyucNOZ0M9IXCHAiMLNhzLmey01 0iCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=y1McXVW6; spf=pass (google.com: domain of gcc-patches-return-464140-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-464140-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 68si641014pfq.46.2017.10.13.07.04.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 07:04:41 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-464140-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=y1McXVW6; spf=pass (google.com: domain of gcc-patches-return-464140-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-464140-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=m55ny8J1aDPMMIFsLBPDpy8AzMAxJIUFIbCPNBC42orwiCOzwaQR7 tRzilSfb84UJrO/DkE18WFaLk0Lqp3EwpeTg7GqDH26XwYTWHiRI2I5/ENhQJKYJ 6yqVoKoUhBobtsApHQ998xYlciqK1tHCE/zf+9aHUs5fh25htYoHzs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=+V7wJf9/r49WdAAoTxzHt+E5ihs=; b=y1McXVW61bacVkpdjWS8 yph3tDUR3KZnOLkeQU+k8xgYQqdHpN4acFovHNSJe6AbEeT5EzT/0hUcAZZ/HyDV kMV5CEGjVeFawX60Jb5WkGvuavRpdEZt6mM7YBb20sA+tzbjAzOD8B9/GHquezRv bpvHEUeUuxc12mIb4y+lJFA= Received: (qmail 77506 invoked by alias); 13 Oct 2017 14:04:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 76898 invoked by uid 89); 13 Oct 2017 14:04:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_WEB, SPF_PASS autolearn=ham version=3.3.2 spammy=20170925, 2017-09-25, inch X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Oct 2017 14:04:24 +0000 Received: by mail-wr0-f182.google.com with SMTP id g90so122752wrd.6 for ; Fri, 13 Oct 2017 07:04:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:mail-followup-to:subject:date:message-id :user-agent:mime-version; bh=ElAFwSEXT2YLtsky4wKwt/xRkcqXjdLMp3HMxZBotts=; b=aTjqSw1QlzAo2ITmWwnx7y0Ojj2VCtd/DEkTjBJTD9B3hez/ePPr7q9IAML3QLeqJZ /6BWJ36EU3bmwCuUdoW8wp/nI5Tk4hKVb/kczCNb82kAyS+fTM/yd+FOeRcM7z5T6sP3 +kyH8dU4BTYNod21Fwee1bsiAG3w8lH5GX/bKoDv711D1pwTsk3rwgLJ08J5shR7tQJ/ WZIV/fPPiMuQgvsqliT7WL8tlLo7gxM6kgEFTKdcz93eFammG5R315bL8BZ364XO6K3n BvI2pTozDU1NbXxw4LqkMUoStQ0EpVXlgXmM4xF1CpKnRFh+hzyghOET++s2bgI//Qv3 fdgg== X-Gm-Message-State: AMCzsaU42XioBarr4ANgz5OfbAblsWI/LuO6RTVeIt8eWF/BNkYibQRc W0hr5EbVDw7SVSbfEAvdWyP8KyK99Ts= X-Google-Smtp-Source: AOwi7QDm3PcqpKNisw8cubUbnFkd+63MYxWemSP9fduNran6Pg9S0gyJ7Ig3FXObfEX7TvqpV+/3cQ== X-Received: by 10.223.136.170 with SMTP id f39mr1408030wrf.162.1507903461717; Fri, 13 Oct 2017 07:04:21 -0700 (PDT) Received: from localhost (94.197.120.215.threembb.co.uk. [94.197.120.215]) by smtp.gmail.com with ESMTPSA id d27sm2129086wrd.67.2017.10.13.07.04.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Oct 2017 07:04:20 -0700 (PDT) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Subject: Rename inchash::hash::add_wide_int Date: Fri, 13 Oct 2017 15:04:17 +0100 Message-ID: <874lr3ta8u.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 The name inchash::add_wide_int is a bit misleading, since it sounds like it's hashing a wide_int. This patch renames it to add_hwi instead. Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu. OK to install? Richard 2017-10-13 Richard Sandiford gcc/ * inchash.h (inchash::hash::add_wide_int): Rename to... (inchash::hash::add_hwi): ...this. * ipa-devirt.c (hash_odr_vtable): Update accordingly. (polymorphic_call_target_hasher::hash): Likewise. * ipa-icf.c (sem_function::get_hash, sem_function::init): Likewise. (sem_item::add_expr, sem_item::add_type, sem_variable::get_hash) (sem_item_optimizer::update_hash_by_addr_refs): Likewise. * lto-streamer-out.c (hash_tree): Likewise. * optc-save-gen.awk: Likewise. * tree.c (add_expr): Likewise. Index: gcc/inchash.h =================================================================== --- gcc/inchash.h 2017-02-23 19:54:20.000000000 +0000 +++ gcc/inchash.h 2017-10-13 14:59:35.120146199 +0100 @@ -58,7 +58,7 @@ hashval_t iterative_hash_hashval_t (hash } /* Add HOST_WIDE_INT value V. */ - void add_wide_int (HOST_WIDE_INT v) + void add_hwi (HOST_WIDE_INT v) { val = iterative_hash_host_wide_int (v, val); } Index: gcc/ipa-devirt.c =================================================================== --- gcc/ipa-devirt.c 2017-08-10 14:36:08.043471772 +0100 +++ gcc/ipa-devirt.c 2017-10-13 14:59:35.121062203 +0100 @@ -373,7 +373,7 @@ hash_odr_vtable (const_tree t) v = TREE_OPERAND (TREE_OPERAND (v, 0), 0); } - hstate.add_wide_int (IDENTIFIER_HASH_VALUE (DECL_ASSEMBLER_NAME (v))); + hstate.add_hwi (IDENTIFIER_HASH_VALUE (DECL_ASSEMBLER_NAME (v))); return hstate.end (); } @@ -2625,14 +2625,14 @@ polymorphic_call_target_hasher::hash (co { inchash::hash hstate (odr_query->otr_token); - hstate.add_wide_int (odr_query->type->id); + hstate.add_hwi (odr_query->type->id); hstate.merge_hash (TYPE_UID (odr_query->context.outer_type)); - hstate.add_wide_int (odr_query->context.offset); + hstate.add_hwi (odr_query->context.offset); if (odr_query->context.speculative_outer_type) { hstate.merge_hash (TYPE_UID (odr_query->context.speculative_outer_type)); - hstate.add_wide_int (odr_query->context.speculative_offset); + hstate.add_hwi (odr_query->context.speculative_offset); } hstate.add_flag (odr_query->speculative); hstate.add_flag (odr_query->context.maybe_in_construction); Index: gcc/ipa-icf.c =================================================================== --- gcc/ipa-icf.c 2017-09-25 13:33:39.989814299 +0100 +++ gcc/ipa-icf.c 2017-10-13 14:59:35.121062203 +0100 @@ -286,11 +286,11 @@ sem_function::get_hash (void) /* Add common features of declaration itself. */ if (DECL_FUNCTION_SPECIFIC_TARGET (decl)) - hstate.add_wide_int + hstate.add_hwi (cl_target_option_hash (TREE_TARGET_OPTION (DECL_FUNCTION_SPECIFIC_TARGET (decl)))); if (DECL_FUNCTION_SPECIFIC_OPTIMIZATION (decl)) - hstate.add_wide_int + hstate.add_hwi (cl_optimization_hash (TREE_OPTIMIZATION (DECL_FUNCTION_SPECIFIC_OPTIMIZATION (decl)))); hstate.add_flag (DECL_CXX_CONSTRUCTOR_P (decl)); @@ -1437,8 +1437,8 @@ sem_function::init (void) { cfg_checksum = 0; inchash::hash hstate; - hstate.add_wide_int (cnode->thunk.fixed_offset); - hstate.add_wide_int (cnode->thunk.virtual_value); + hstate.add_hwi (cnode->thunk.fixed_offset); + hstate.add_hwi (cnode->thunk.virtual_value); hstate.add_flag (cnode->thunk.this_adjusting); hstate.add_flag (cnode->thunk.virtual_offset_p); hstate.add_flag (cnode->thunk.add_pointer_bounds_args); @@ -1485,7 +1485,7 @@ sem_item::add_expr (const_tree exp, inch unsigned HOST_WIDE_INT idx; tree value; - hstate.add_wide_int (int_size_in_bytes (TREE_TYPE (exp))); + hstate.add_hwi (int_size_in_bytes (TREE_TYPE (exp))); FOR_EACH_CONSTRUCTOR_VALUE (CONSTRUCTOR_ELTS (exp), idx, value) if (value) @@ -1500,7 +1500,7 @@ sem_item::add_expr (const_tree exp, inch case VAR_DECL: case CONST_DECL: case PARM_DECL: - hstate.add_wide_int (int_size_in_bytes (TREE_TYPE (exp))); + hstate.add_hwi (int_size_in_bytes (TREE_TYPE (exp))); break; case MEM_REF: case POINTER_PLUS_EXPR: @@ -1518,7 +1518,7 @@ sem_item::add_expr (const_tree exp, inch } break; CASE_CONVERT: - hstate.add_wide_int (int_size_in_bytes (TREE_TYPE (exp))); + hstate.add_hwi (int_size_in_bytes (TREE_TYPE (exp))); return add_expr (TREE_OPERAND (exp, 0), hstate); default: break; @@ -1589,11 +1589,11 @@ sem_item::add_type (const_tree type, inc hstate2.add_int (nf); hash = hstate2.end (); - hstate.add_wide_int (hash); + hstate.add_hwi (hash); optimizer->m_type_hash_cache.put (type, hash); } else - hstate.add_wide_int (*val); + hstate.add_hwi (*val); } } @@ -2108,7 +2108,7 @@ sem_variable::get_hash (void) hstate.add_int (456346417); if (DECL_SIZE (decl) && tree_fits_shwi_p (DECL_SIZE (decl))) - hstate.add_wide_int (tree_to_shwi (DECL_SIZE (decl))); + hstate.add_hwi (tree_to_shwi (DECL_SIZE (decl))); add_expr (ctor, hstate); set_hash (hstate.end ()); @@ -2720,7 +2720,7 @@ sem_item_optimizer::update_hash_by_addr_ if (TYPE_NAME (class_type) && DECL_ASSEMBLER_NAME_SET_P (TYPE_NAME (class_type))) - hstate.add_wide_int + hstate.add_hwi (IDENTIFIER_HASH_VALUE (DECL_ASSEMBLER_NAME (TYPE_NAME (class_type)))); Index: gcc/lto-streamer-out.c =================================================================== --- gcc/lto-streamer-out.c 2017-08-21 12:14:39.683583730 +0100 +++ gcc/lto-streamer-out.c 2017-10-13 14:59:35.121978207 +0100 @@ -1030,10 +1030,10 @@ #define visit(SIBLING) \ if (CODE_CONTAINS_STRUCT (code, TS_INT_CST)) { int i; - hstate.add_wide_int (TREE_INT_CST_NUNITS (t)); - hstate.add_wide_int (TREE_INT_CST_EXT_NUNITS (t)); + hstate.add_hwi (TREE_INT_CST_NUNITS (t)); + hstate.add_hwi (TREE_INT_CST_EXT_NUNITS (t)); for (i = 0; i < TREE_INT_CST_NUNITS (t); i++) - hstate.add_wide_int (TREE_INT_CST_ELT (t, i)); + hstate.add_hwi (TREE_INT_CST_ELT (t, i)); } if (CODE_CONTAINS_STRUCT (code, TS_REAL_CST)) @@ -1058,7 +1058,7 @@ #define visit(SIBLING) \ if (CODE_CONTAINS_STRUCT (code, TS_DECL_COMMON)) { - hstate.add_wide_int (DECL_MODE (t)); + hstate.add_hwi (DECL_MODE (t)); hstate.add_flag (DECL_NONLOCAL (t)); hstate.add_flag (DECL_VIRTUAL_P (t)); hstate.add_flag (DECL_IGNORED_P (t)); @@ -1151,7 +1151,7 @@ #define visit(SIBLING) \ if (CODE_CONTAINS_STRUCT (code, TS_TYPE_COMMON)) { - hstate.add_wide_int (TYPE_MODE (t)); + hstate.add_hwi (TYPE_MODE (t)); hstate.add_flag (TYPE_STRING_FLAG (t)); /* TYPE_NO_FORCE_BLK is private to stor-layout and need no streaming. */ @@ -1181,10 +1181,10 @@ #define visit(SIBLING) \ if (CODE_CONTAINS_STRUCT (code, TS_TARGET_OPTION) /* We don't stream these when passing things to a different target. */ && !lto_stream_offload_p) - hstate.add_wide_int (cl_target_option_hash (TREE_TARGET_OPTION (t))); + hstate.add_hwi (cl_target_option_hash (TREE_TARGET_OPTION (t))); if (CODE_CONTAINS_STRUCT (code, TS_OPTIMIZATION)) - hstate.add_wide_int (cl_optimization_hash (TREE_OPTIMIZATION (t))); + hstate.add_hwi (cl_optimization_hash (TREE_OPTIMIZATION (t))); if (CODE_CONTAINS_STRUCT (code, TS_IDENTIFIER)) hstate.merge_hash (IDENTIFIER_HASH_VALUE (t)); @@ -1312,7 +1312,7 @@ #define visit(SIBLING) \ if (CODE_CONTAINS_STRUCT (code, TS_EXP)) { - hstate.add_wide_int (TREE_OPERAND_LENGTH (t)); + hstate.add_hwi (TREE_OPERAND_LENGTH (t)); for (int i = 0; i < TREE_OPERAND_LENGTH (t); ++i) visit (TREE_OPERAND (t, i)); } @@ -1336,7 +1336,7 @@ #define visit(SIBLING) \ { unsigned i; tree index, value; - hstate.add_wide_int (CONSTRUCTOR_NELTS (t)); + hstate.add_hwi (CONSTRUCTOR_NELTS (t)); FOR_EACH_CONSTRUCTOR_ELT (CONSTRUCTOR_ELTS (t), i, index, value) { visit (index); @@ -1349,7 +1349,7 @@ #define visit(SIBLING) \ int i; HOST_WIDE_INT val; - hstate.add_wide_int (OMP_CLAUSE_CODE (t)); + hstate.add_hwi (OMP_CLAUSE_CODE (t)); switch (OMP_CLAUSE_CODE (t)) { case OMP_CLAUSE_DEFAULT: @@ -1374,7 +1374,7 @@ #define visit(SIBLING) \ val = 0; break; } - hstate.add_wide_int (val); + hstate.add_hwi (val); for (i = 0; i < omp_clause_num_ops[OMP_CLAUSE_CODE (t)]; i++) visit (OMP_CLAUSE_OPERAND (t, i)); visit (OMP_CLAUSE_CHAIN (t)); Index: gcc/optc-save-gen.awk =================================================================== --- gcc/optc-save-gen.awk 2017-07-02 10:05:20.996539436 +0100 +++ gcc/optc-save-gen.awk 2017-10-13 14:59:35.121978207 +0100 @@ -678,7 +678,7 @@ for (i = 0; i < n_target_array; i++) { } for (i = 0; i < n_target_val; i++) { name = var_target_val[i] - print " hstate.add_wide_int (ptr->" name");"; + print " hstate.add_hwi (ptr->" name");"; } print " return hstate.end ();"; print "}"; @@ -766,7 +766,7 @@ for (i = 0; i < n_opt_val; i++) { if (!var_opt_hash[i]) continue; name = var_opt_val[i] - print " hstate.add_wide_int (ptr->" name");"; + print " hstate.add_hwi (ptr->" name");"; } print " return hstate.end ();"; print "}"; Index: gcc/tree.c =================================================================== --- gcc/tree.c 2017-10-13 10:23:38.959631964 +0100 +++ gcc/tree.c 2017-10-13 14:59:35.122894211 +0100 @@ -7058,7 +7058,7 @@ add_expr (const_tree t, inchash::hash &h case INTEGER_CST: gcc_checking_assert (!(flags & OEP_ADDRESS_OF)); for (i = 0; i < TREE_INT_CST_EXT_NUNITS (t); i++) - hstate.add_wide_int (TREE_INT_CST_ELT (t, i)); + hstate.add_hwi (TREE_INT_CST_ELT (t, i)); return; case REAL_CST: { @@ -7093,7 +7093,7 @@ add_expr (const_tree t, inchash::hash &h } case SSA_NAME: /* We can just compare by pointer. */ - hstate.add_wide_int (SSA_NAME_VERSION (t)); + hstate.add_hwi (SSA_NAME_VERSION (t)); return; case PLACEHOLDER_EXPR: /* The node itself doesn't matter. */ @@ -7151,7 +7151,7 @@ add_expr (const_tree t, inchash::hash &h if (tclass == tcc_declaration) { /* DECL's have a unique ID */ - hstate.add_wide_int (DECL_UID (t)); + hstate.add_hwi (DECL_UID (t)); } else if (tclass == tcc_comparison && !commutative_tree_code (code)) {