From patchwork Tue Oct 24 10:27:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dietmar Eggemann X-Patchwork-Id: 116937 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5635894qgn; Tue, 24 Oct 2017 03:27:35 -0700 (PDT) X-Google-Smtp-Source: ABhQp+QDaDgTN9/TphHTRbjkMY9ljH2q4/zSNw823N5a9TcEw0Ax2pVZYbSjcvc1/b6KfFsZpQi4 X-Received: by 10.84.175.3 with SMTP id s3mr12493600plb.440.1508840855694; Tue, 24 Oct 2017 03:27:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508840855; cv=none; d=google.com; s=arc-20160816; b=iafV+6CjEnegT38oh6pPISFq2DxtIViISLMzHAv3fewOY5anwnSB1vHe2Vn5/KT3wu M3rCS0nJgBfquChESvbxrVP4vaATxxtv/9OnssENWNbvYg2n6Ia5OhtguBo8/NNjx0Zt HBGOH9QOl4NckDRFkz5cRRLAOwNi8VzCsVe1ZyUwPOztImMx7h8EIkqi9R/MVw3pNkUX NKX9InuZRgXs/mv7RQrzWL0iIdHslNFT9+cyTPqFYiWo+1weKkceNwL3fb6ew40+AXpR 7oXsMhoAPqyc0Rb6t+3TZbc4Xie6wvQqnAu+hAD2ei6ZXcfqa9qlz+TbqjHFeuSFpwXa wLGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=O2Zm5MesZht1C+B56pubJ07AM4aj4EJG8u5p5MwFNPg=; b=M7gLPQ8g/hv5JCZ78pgQodLKKdi3hM2WW5rP4/Gb7eoZg2fhEGz4shkFh6ANFwSe9q Cu4VygG+1oBkcW9ElSyLUxACvNjHRDMtSU8YkVFB8MeNjjZs7EH2LLDyrLw+pZ9W4ZtZ OnnQWLRfzQL0HEI8SKWTQf0Fv84+niBWlCU2W/6h4ZYcVbTF/zo4Sisfe57KWIL5QDZI YteESvViEXbTa8m26XHnS+/R+8Mef/y3fRcH4w5amI44zRu4aeA+GlG4u+amN2m5WR8B BaYGF+nRAcXh/PlMZoJ4FNS69GEByJ3Ix6y25rg4igp2r1QMZz95uXtIWbNN/S2SqgIG hGMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si5198899plz.428.2017.10.24.03.27.35; Tue, 24 Oct 2017 03:27:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932657AbdJXK1d (ORCPT + 27 others); Tue, 24 Oct 2017 06:27:33 -0400 Received: from foss.arm.com ([217.140.101.70]:53134 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932524AbdJXK12 (ORCPT ); Tue, 24 Oct 2017 06:27:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E74251596; Tue, 24 Oct 2017 03:27:27 -0700 (PDT) Received: from e107985-lin.cambridge.arm.com (e107985-lin.cambridge.arm.com [10.1.210.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D90D13F25D; Tue, 24 Oct 2017 03:27:26 -0700 (PDT) From: Dietmar Eggemann To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Russell King , Vincent Guittot , Juri Lelli Subject: [PATCH v3 1/2] arm: topology: remove cpu_efficiency Date: Tue, 24 Oct 2017 11:27:17 +0100 Message-Id: <20171024102718.16113-2-dietmar.eggemann@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171024102718.16113-1-dietmar.eggemann@arm.com> References: <20171024102718.16113-1-dietmar.eggemann@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the 'cpu_efficiency/clock-frequency dt property' based solution to set cpu capacity which was only working for Cortex-A15/A7 arm big.LITTLE systems. I.e. the 'capacity-dmips-mhz' based solution is now the only one. It is shared between arm and arm64 and works for every big.LITTLE system no matter which core types it consists of. Cc: Russell King Cc: Vincent Guittot Cc: Juri Lelli Signed-off-by: Dietmar Eggemann --- arch/arm/kernel/topology.c | 132 ++------------------------------------------- 1 file changed, 4 insertions(+), 128 deletions(-) -- 2.11.0 diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c index 24ac3cab411d..15cc131ae387 100644 --- a/arch/arm/kernel/topology.c +++ b/arch/arm/kernel/topology.c @@ -30,69 +30,11 @@ #include #include -/* - * cpu capacity scale management - */ - -/* - * cpu capacity table - * This per cpu data structure describes the relative capacity of each core. - * On a heteregenous system, cores don't have the same computation capacity - * and we reflect that difference in the cpu_capacity field so the scheduler - * can take this difference into account during load balance. A per cpu - * structure is preferred because each CPU updates its own cpu_capacity field - * during the load balance except for idle cores. One idle core is selected - * to run the rebalance_domains for all idle cores and the cpu_capacity can be - * updated during this sequence. - */ - #ifdef CONFIG_OF -struct cpu_efficiency { - const char *compatible; - unsigned long efficiency; -}; - -/* - * Table of relative efficiency of each processors - * The efficiency value must fit in 20bit and the final - * cpu_scale value must be in the range - * 0 < cpu_scale < 3*SCHED_CAPACITY_SCALE/2 - * in order to return at most 1 when DIV_ROUND_CLOSEST - * is used to compute the capacity of a CPU. - * Processors that are not defined in the table, - * use the default SCHED_CAPACITY_SCALE value for cpu_scale. - */ -static const struct cpu_efficiency table_efficiency[] = { - {"arm,cortex-a15", 3891}, - {"arm,cortex-a7", 2048}, - {NULL, }, -}; - -static unsigned long *__cpu_capacity; -#define cpu_capacity(cpu) __cpu_capacity[cpu] - -static unsigned long middle_capacity = 1; -static bool cap_from_dt = true; - -/* - * Iterate all CPUs' descriptor in DT and compute the efficiency - * (as per table_efficiency). Also calculate a middle efficiency - * as close as possible to (max{eff_i} - min{eff_i}) / 2 - * This is later used to scale the cpu_capacity field such that an - * 'average' CPU is of middle capacity. Also see the comments near - * table_efficiency[] and update_cpu_capacity(). - */ static void __init parse_dt_topology(void) { - const struct cpu_efficiency *cpu_eff; - struct device_node *cn = NULL; - unsigned long min_capacity = ULONG_MAX; - unsigned long max_capacity = 0; - unsigned long capacity = 0; - int cpu = 0; - - __cpu_capacity = kcalloc(nr_cpu_ids, sizeof(*__cpu_capacity), - GFP_NOWAIT); + struct device_node *cn; + int cpu; cn = of_find_node_by_path("/cpus"); if (!cn) { @@ -101,9 +43,6 @@ static void __init parse_dt_topology(void) } for_each_possible_cpu(cpu) { - const u32 *rate; - int len; - /* too early to use cpu->of_node */ cn = of_get_cpu_node(cpu, NULL); if (!cn) { @@ -111,76 +50,15 @@ static void __init parse_dt_topology(void) continue; } - if (topology_parse_cpu_capacity(cn, cpu)) { + if (topology_parse_cpu_capacity(cn, cpu)) of_node_put(cn); - continue; - } - - cap_from_dt = false; - - for (cpu_eff = table_efficiency; cpu_eff->compatible; cpu_eff++) - if (of_device_is_compatible(cn, cpu_eff->compatible)) - break; - - if (cpu_eff->compatible == NULL) - continue; - - rate = of_get_property(cn, "clock-frequency", &len); - if (!rate || len != 4) { - pr_err("%pOF missing clock-frequency property\n", cn); - continue; - } - - capacity = ((be32_to_cpup(rate)) >> 20) * cpu_eff->efficiency; - - /* Save min capacity of the system */ - if (capacity < min_capacity) - min_capacity = capacity; - - /* Save max capacity of the system */ - if (capacity > max_capacity) - max_capacity = capacity; - - cpu_capacity(cpu) = capacity; } - /* If min and max capacities are equals, we bypass the update of the - * cpu_scale because all CPUs have the same capacity. Otherwise, we - * compute a middle_capacity factor that will ensure that the capacity - * of an 'average' CPU of the system will be as close as possible to - * SCHED_CAPACITY_SCALE, which is the default value, but with the - * constraint explained near table_efficiency[]. - */ - if (4*max_capacity < (3*(max_capacity + min_capacity))) - middle_capacity = (min_capacity + max_capacity) - >> (SCHED_CAPACITY_SHIFT+1); - else - middle_capacity = ((max_capacity / 3) - >> (SCHED_CAPACITY_SHIFT-1)) + 1; - - if (cap_from_dt) - topology_normalize_cpu_scale(); -} - -/* - * Look for a customed capacity of a CPU in the cpu_capacity table during the - * boot. The update of all CPUs is in O(n^2) for heteregeneous system but the - * function returns directly for SMP system. - */ -static void update_cpu_capacity(unsigned int cpu) -{ - if (!cpu_capacity(cpu) || cap_from_dt) - return; - - topology_set_cpu_scale(cpu, cpu_capacity(cpu) / middle_capacity); - - pr_info("CPU%u: update cpu_capacity %lu\n", - cpu, topology_get_cpu_scale(NULL, cpu)); + topology_normalize_cpu_scale(); } #else static inline void parse_dt_topology(void) {} -static inline void update_cpu_capacity(unsigned int cpuid) {} #endif /* @@ -276,8 +154,6 @@ void store_cpu_topology(unsigned int cpuid) update_siblings_masks(cpuid); - update_cpu_capacity(cpuid); - pr_info("CPU%u: thread %d, cpu %d, socket %d, mpidr %x\n", cpuid, cpu_topology[cpuid].thread_id, cpu_topology[cpuid].core_id, From patchwork Tue Oct 24 10:27:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dietmar Eggemann X-Patchwork-Id: 116938 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5635958qgn; Tue, 24 Oct 2017 03:27:39 -0700 (PDT) X-Google-Smtp-Source: ABhQp+S8pp23jV1nM78sOMkalnUuf6MHefDAU3zEcVA/K5uk9Mn5GlLntrrOeBfIoEiNGsI2oovr X-Received: by 10.99.94.198 with SMTP id s189mr14518371pgb.32.1508840859817; Tue, 24 Oct 2017 03:27:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508840859; cv=none; d=google.com; s=arc-20160816; b=VtwwI5/4VsAag9IshnQiHj3GBnBet7xXmvX+lrbDyqDihsOdHB+LOIU4+bjl0GU+w5 J7FLX1mJBkv6EkwrpEYb5WUf01tfUUkgiW+HwxTticNcq20YUk75ld/lAWUuuVAQsgpW DiAioNUKD28tN62IjtrHkWweWRka4q/wbx723wvE9ZdVl9dqjHCWPySkosckpvYbcP/w q5PguWJcGh12EEOSSobRBiRv53hQ4mJkHb7VaQg5I8F7vxYNF9yk9GVnz6IVRj3CFQZu RYAhSwO2ZPxTC3+/SGG0od/vZktTQodQIeDsct0oteVImiBTtoAabuo/9zTcB2e1/RO3 YwcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=qrUYQJDkKp5Xuj94Rkghd6gAqsKOGQa17pD3IqR9ATw=; b=Eifx1gCSvgP40IZG7MWCdHvULy2/sou/TqG78iCaKDh/eowUxX+h/QuW/O83If8N8p 0iUa8zLixq1t5pUeh4J7MFMVcy1HhECJAA67qJR6z5ytSvGbyzDaKKE4mkeyE8wLf2Ug AuCxhyqedQWxLpp54Zd/BV5QSXXTS6m1wc60EYWAALUJOi3fiZl3PhPGMEGMKOFu4xg1 mUfvln6so7eP+DEGcRf7sQY9efC7pkK//JipjYpz/0bHhkQWSO4R2Ly54+7q71OLPCJY lFwJf89jUpIpDwAsSLbFj/F+yKMOz3WMTn4TeqfjP8KTO94zOwyiVwWkGFe1vlyau9su 4GSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si6235265pgs.468.2017.10.24.03.27.39; Tue, 24 Oct 2017 03:27:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932690AbdJXK1h (ORCPT + 27 others); Tue, 24 Oct 2017 06:27:37 -0400 Received: from foss.arm.com ([217.140.101.70]:53150 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932573AbdJXK13 (ORCPT ); Tue, 24 Oct 2017 06:27:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 490A215BF; Tue, 24 Oct 2017 03:27:29 -0700 (PDT) Received: from e107985-lin.cambridge.arm.com (e107985-lin.cambridge.arm.com [10.1.210.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 30DE13F25D; Tue, 24 Oct 2017 03:27:28 -0700 (PDT) From: Dietmar Eggemann To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Russell King , Vincent Guittot , Juri Lelli Subject: [PATCH v3 2/2] arm: topology: add missing of_node_put() for cpu device node Date: Tue, 24 Oct 2017 11:27:18 +0100 Message-Id: <20171024102718.16113-3-dietmar.eggemann@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171024102718.16113-1-dietmar.eggemann@arm.com> References: <20171024102718.16113-1-dietmar.eggemann@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds the missing of_node_put() for of_find_node_by_path() and of_get_cpu_node() in parse_dt_topology(). Cc: Russell King Cc: Vincent Guittot Cc: Juri Lelli Signed-off-by: Dietmar Eggemann --- arch/arm/kernel/topology.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.11.0 diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c index 15cc131ae387..81ec42333489 100644 --- a/arch/arm/kernel/topology.c +++ b/arch/arm/kernel/topology.c @@ -41,6 +41,7 @@ static void __init parse_dt_topology(void) pr_err("No CPU information found in DT\n"); return; } + of_node_put(cn); for_each_possible_cpu(cpu) { /* too early to use cpu->of_node */ @@ -50,8 +51,8 @@ static void __init parse_dt_topology(void) continue; } - if (topology_parse_cpu_capacity(cn, cpu)) - of_node_put(cn); + topology_parse_cpu_capacity(cn, cpu); + of_node_put(cn); } topology_normalize_cpu_scale();