From patchwork Mon Oct 5 07:03:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Gibson X-Patchwork-Id: 285644 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5563BC4363A for ; Mon, 5 Oct 2020 07:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1362E2078E for ; Mon, 5 Oct 2020 07:03:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RD6CGEJ2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725910AbgJEHDz (ORCPT ); Mon, 5 Oct 2020 03:03:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHDz (ORCPT ); Mon, 5 Oct 2020 03:03:55 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E96CC0613CE; Mon, 5 Oct 2020 00:03:55 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id k8so6223606pfk.2; Mon, 05 Oct 2020 00:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TzuIsmk/L/4A//mgVBC3/bdUgRRfBHD9u/2Du7ePAjc=; b=RD6CGEJ2psr9vzvnWY1bBAcD5bmEsCOc3fWhB/TMc319eZdJTTFudSgaOquI4pnvn6 cGTAfvvyDUwK5bWRrgxNwfaaS9Fwlaub4jivt1fuWh/aFtPMVV67gxT81Oyw/Z7x1/bS zB2Vn+FAH/VJ51i57rEV/natiRYIr7QQxofEsbeoywYDqXjIY3CficBddIo8h81DPzqw Efm65kEcc6SPvwmGbO37l4E/7j9s3dqrQ1ZAECwoUiyl8uksQRAua5rjRWMcry1k4d/R BqStwyqpgbPnYkO3TjEva9C5Rd8TAqwF5NEluLVcWe75e7E4XmUIOifQdVe9EKWJf5Ji bbTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TzuIsmk/L/4A//mgVBC3/bdUgRRfBHD9u/2Du7ePAjc=; b=bHJYhWLYbvq5v/8n9K0Tac/VMECAHhrxHLI7xVD/7Kv+4RqejhVALkkfHPZxOKgEUC HIM3Gwts3+ySnx5677i5rnogA+gThaHnVCG3dNOIDUzqdQsFel2KzPoMqxzoveTBa9R4 TfmjucvWa4K0lO8n5QKEvXV9rPtqDXJ+L6sZRydQPW0KcEsym9NhyqkiWz67ghBmCk/3 WV4qSNMMwHkyoow7fGeuKgozAic7jD4mGKUV4TDDPtyis98cp1PauorKOAWiaPcLu6Ry pW6KruvuUbcRoxgbE+Znir5dfG+2Pk6HdgI6rMe3bTDEnI3U01icJG6fEG9vgTxOlj0L sDNA== X-Gm-Message-State: AOAM531dGzn05Fj5QLhiXMBnDbA6f8+UsH1IINrAUelHEmTQ2+Y8eNL3 aHT6x/566bCjVKJqn87yhXEewRsbWQ4DAw== X-Google-Smtp-Source: ABdhPJwLmIVJUT73biZ5KgTN5+P5LzbSpwrL+suhrTbnwWUu4fnvXbUoxmSToFaAwJ8Z4s//+hbRMw== X-Received: by 2002:a05:6a00:14d4:b029:152:8969:427b with SMTP id w20-20020a056a0014d4b02901528969427bmr3077479pfu.1.1601881434338; Mon, 05 Oct 2020 00:03:54 -0700 (PDT) Received: from sol.lan (106-69-166-86.dyn.iinet.net.au. [106.69.166.86]) by smtp.gmail.com with ESMTPSA id 78sm6868764pfz.211.2020.10.05.00.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 00:03:53 -0700 (PDT) From: Kent Gibson To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, linus.walleij@linaro.org Cc: Kent Gibson Subject: [PATCH 1/5] gpio: uapi: fix kernel-doc warnings Date: Mon, 5 Oct 2020 15:03:25 +0800 Message-Id: <20201005070329.21055-2-warthog618@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005070329.21055-1-warthog618@gmail.com> References: <20201005070329.21055-1-warthog618@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Fix kernel-doc warnings, specifically gpioline_info_changed.padding is not documented and 'GPIO event types' describes defines, which are not documented by kernel-doc. Signed-off-by: Kent Gibson --- include/uapi/linux/gpio.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h index 07865c601099..b0d5e7a1c693 100644 --- a/include/uapi/linux/gpio.h +++ b/include/uapi/linux/gpio.h @@ -346,6 +346,7 @@ enum { * @timestamp: estimate of time of status change occurrence, in nanoseconds * @event_type: one of GPIOLINE_CHANGED_REQUESTED, GPIOLINE_CHANGED_RELEASED * and GPIOLINE_CHANGED_CONFIG + * @padding: reserved for future use * * Note: struct gpioline_info embedded here has 32-bit alignment on its own, * but it works fine with 64-bit alignment too. With its 72 byte size, we can @@ -469,7 +470,7 @@ struct gpioevent_request { int fd; }; -/** +/* * GPIO event types */ #define GPIOEVENT_EVENT_RISING_EDGE 0x01 From patchwork Mon Oct 5 07:03:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Gibson X-Patchwork-Id: 267405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90123C4363A for ; Mon, 5 Oct 2020 07:04:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F5CD20795 for ; Mon, 5 Oct 2020 07:04:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bu7lMxD6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725930AbgJEHD7 (ORCPT ); Mon, 5 Oct 2020 03:03:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHD7 (ORCPT ); Mon, 5 Oct 2020 03:03:59 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 573CAC0613CE; Mon, 5 Oct 2020 00:03:59 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id 7so5395636pgm.11; Mon, 05 Oct 2020 00:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w+fSCxVpORJJHHoB6O1AfVgwd5DtflDeMSjLAWuo67w=; b=Bu7lMxD6X8EQEijEGiefHGkEZW83rPSMS8zMyIE1eYYbInEq8fimVOnvha1/70OirT tOZ+HGWLC1K/E7IMn2dXgfwBrSyKkB+w+6Oo9/CarxXmXeXXSYIpRMFCzFo/NO4GFxO7 7pZX27hcmtiBjCxGzFPAqe/aSpAr6mt7FzO5FGpKY/J7GXt3gxuQIbmRul4Ue6EhKYfZ NiMvkUI2ScouKTHo0go+sRRmoKeVcq2vANslPScAoiO/UDJhi7RqRUk9HUXD3yCqoK+n yhFbciiIJAFg6nWdA8rT7CAs5mPVWuaEpCXp/cuOT0E1UT80JSgDvdJALaIpbBQM80sb eqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w+fSCxVpORJJHHoB6O1AfVgwd5DtflDeMSjLAWuo67w=; b=DKfZkijaj5LxDew2DarycNlZfMMYvYDxY+LjMeUwU0JCfeKkRtTk5/2WqRAwud0sM6 56W984/kQIClxQLID7K92m0nT7q5rUqHiP36daFeNE7TrTUowyz++NvOLtkIbkFb+rl8 jg91dqKLdMZYF25B2GNqydQDduh0YyiRZm6FnXpkdcn38n2XHzKBDjUfHjCbUG1Oo4jV TddLFeMr4UUnEA9eWTmWzWKvVZ9l2u7tR0Xal2poujQoF0kJcSND2Jkmz7ZLXDWM/nra XXHunpVS75z3SSbbg1fyJtQyshAaHPaNB9XjqsyXpLLVxzF7WJJigl4eMPrEGxSfPpeV Wh1g== X-Gm-Message-State: AOAM533du8eWK7+YDNoJil0bFA+hBZKs2qNlp4zQlJMXjSwKE/e0orbr KPOznWXPW7UDe0Be3LT9mkNRoAfb4GV8GA== X-Google-Smtp-Source: ABdhPJy7GIMXOe5TPvYxhOlmVXHL6BIM5yXgJyvwFwZRYdyr/yeZ1PgthoJoytgoj+lZx9MF4W4PAQ== X-Received: by 2002:aa7:9048:0:b029:152:883a:9a94 with SMTP id n8-20020aa790480000b0290152883a9a94mr3286611pfo.24.1601881438541; Mon, 05 Oct 2020 00:03:58 -0700 (PDT) Received: from sol.lan (106-69-166-86.dyn.iinet.net.au. [106.69.166.86]) by smtp.gmail.com with ESMTPSA id 78sm6868764pfz.211.2020.10.05.00.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 00:03:57 -0700 (PDT) From: Kent Gibson To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, linus.walleij@linaro.org Cc: Kent Gibson Subject: [PATCH 2/5] gpio: uapi: comment consistency Date: Mon, 5 Oct 2020 15:03:26 +0800 Message-Id: <20201005070329.21055-3-warthog618@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005070329.21055-1-warthog618@gmail.com> References: <20201005070329.21055-1-warthog618@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Make debounce_period_us field documentation consistent with other fields in the union. Signed-off-by: Kent Gibson --- include/uapi/linux/gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h index b0d5e7a1c693..1fdb0e851f83 100644 --- a/include/uapi/linux/gpio.h +++ b/include/uapi/linux/gpio.h @@ -98,7 +98,7 @@ struct gpio_v2_line_values { * identifying which field of the attribute union is in use. * @GPIO_V2_LINE_ATTR_ID_FLAGS: flags field is in use * @GPIO_V2_LINE_ATTR_ID_OUTPUT_VALUES: values field is in use - * @GPIO_V2_LINE_ATTR_ID_DEBOUNCE: debounce_period_us is in use + * @GPIO_V2_LINE_ATTR_ID_DEBOUNCE: debounce_period_us field is in use */ enum gpio_v2_line_attr_id { GPIO_V2_LINE_ATTR_ID_FLAGS = 1, From patchwork Mon Oct 5 07:03:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Gibson X-Patchwork-Id: 285643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E99C4363A for ; Mon, 5 Oct 2020 07:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF02D20795 for ; Mon, 5 Oct 2020 07:04:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJVSAvOz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbgJEHEF (ORCPT ); Mon, 5 Oct 2020 03:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHEF (ORCPT ); Mon, 5 Oct 2020 03:04:05 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0A0C0613CE; Mon, 5 Oct 2020 00:04:03 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id g29so5421503pgl.2; Mon, 05 Oct 2020 00:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PQGTlJUFworxK3zjl/47Yk1dMPQiOEByLqsfnesnAPE=; b=JJVSAvOzNTuYbfSrbRi1x7jovZSl60GM6sU2GyNZm65Gmaskp/eRwkCkogsZcqKZDH Bm2o9AH2exqYwOuLvIRqLYRPLPSTpkcZS/OSDHmTOATSKu3qv3M89OC1JZ4YCaNXLzSe 9Wd554ZW3kGXfdHuVfeA/GpNq97MoIY25x4HBvk2n7JmsD0//x0TUWhn/HtqBS9s6HDi ThoiFVC/nnkpSqlhRuXo33Ud7v40IZpbPczMPCL1FuNCKvf6xHISHyaYTrOKm9lqL6Z/ 38KW4JckZ9rLsPAGtYwj7geI/alzbc7G/Bna2aYFIEt0k7HVkVfBYiyKRw7W851s/9dR jQVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PQGTlJUFworxK3zjl/47Yk1dMPQiOEByLqsfnesnAPE=; b=D4mByXkzAueZ3b9rUi2KjapZHkcZTevvGS6o/IUigZkszfpDXn9aQp7ME+2MEStayl TmjDwu4wBuou7lhckrMwccQ3rLX21L8d39HdiVsOLk/4jSzwmzg2c4SZAGOt/Hd+87VQ nxZ3eM/ONQdma+duJ9Cp/oHLbz0H/pMM+oFCbG6qO51SD91cJ8+zf5DRxdwqDtIQHGbk 7mTZWihilv4aLUXMfA/7aGVfNb0xnzlUZGQSzWH9aBKckvmhg8YIZIeg5rbTr4pktjSR 39WbQd3E3qJEkopb4WmtEaEjzA5vR6yETsdcqq6HObUoS+s3wofLxKPPsV0DWpDA8cJX Gukw== X-Gm-Message-State: AOAM533OT96EwrDEVXIKrGIAXTKNNvt1WcLq+relO323PcKk57Ajx3po SY8CIvIu08I61I13fKxDcuZgUQBAMGl6Xw== X-Google-Smtp-Source: ABdhPJyjr9oZnyhJlgZA08cGBTQ4MReveQqWZaD3czfkb5n/Pqdm0FpSzoRolW/KrGVSq4drib96ZQ== X-Received: by 2002:aa7:8e9a:0:b029:13e:d13d:a050 with SMTP id a26-20020aa78e9a0000b029013ed13da050mr15876397pfr.22.1601881442661; Mon, 05 Oct 2020 00:04:02 -0700 (PDT) Received: from sol.lan (106-69-166-86.dyn.iinet.net.au. [106.69.166.86]) by smtp.gmail.com with ESMTPSA id 78sm6868764pfz.211.2020.10.05.00.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 00:04:02 -0700 (PDT) From: Kent Gibson To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, linus.walleij@linaro.org Cc: Kent Gibson Subject: [PATCH 3/5] gpio: uapi: kernel-doc formatting improvements Date: Mon, 5 Oct 2020 15:03:27 +0800 Message-Id: <20201005070329.21055-4-warthog618@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005070329.21055-1-warthog618@gmail.com> References: <20201005070329.21055-1-warthog618@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add kernel-doc formatting to all references to structs, enums, fields and constants, and move deprecation warnings into the Note section of the deprecated struct. Replace 'OR:ed' with 'added', as the former looks odd. Signed-off-by: Kent Gibson --- The replacement of 'OR:ed' should strictly be in a separate patch, as it isn't a formatting change, but as the same lines containing them were being changed anyway it feels like overkill? include/uapi/linux/gpio.h | 93 ++++++++++++++++++++------------------- 1 file changed, 47 insertions(+), 46 deletions(-) diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h index 1fdb0e851f83..32dd18f238c3 100644 --- a/include/uapi/linux/gpio.h +++ b/include/uapi/linux/gpio.h @@ -110,17 +110,17 @@ enum gpio_v2_line_attr_id { * struct gpio_v2_line_attribute - a configurable attribute of a line * @id: attribute identifier with value from &enum gpio_v2_line_attr_id * @padding: reserved for future use and must be zero filled - * @flags: if id is GPIO_V2_LINE_ATTR_ID_FLAGS, the flags for the GPIO - * line, with values from enum gpio_v2_line_flag, such as - * GPIO_V2_LINE_FLAG_ACTIVE_LOW, GPIO_V2_LINE_FLAG_OUTPUT etc, OR:ed + * @flags: if id is %GPIO_V2_LINE_ATTR_ID_FLAGS, the flags for the GPIO + * line, with values from &enum gpio_v2_line_flag, such as + * %GPIO_V2_LINE_FLAG_ACTIVE_LOW, %GPIO_V2_LINE_FLAG_OUTPUT etc, added * together. This overrides the default flags contained in the &struct * gpio_v2_line_config for the associated line. - * @values: if id is GPIO_V2_LINE_ATTR_ID_OUTPUT_VALUES, a bitmap + * @values: if id is %GPIO_V2_LINE_ATTR_ID_OUTPUT_VALUES, a bitmap * containing the values to which the lines will be set, with each bit * number corresponding to the index into &struct * gpio_v2_line_request.offsets. - * @debounce_period_us: if id is GPIO_V2_LINE_ATTR_ID_DEBOUNCE, the desired - * debounce period, in microseconds + * @debounce_period_us: if id is %GPIO_V2_LINE_ATTR_ID_DEBOUNCE, the + * desired debounce period, in microseconds */ struct gpio_v2_line_attribute { __u32 id; @@ -147,12 +147,12 @@ struct gpio_v2_line_config_attribute { /** * struct gpio_v2_line_config - Configuration for GPIO lines - * @flags: flags for the GPIO lines, with values from enum - * gpio_v2_line_flag, such as GPIO_V2_LINE_FLAG_ACTIVE_LOW, - * GPIO_V2_LINE_FLAG_OUTPUT etc, OR:ed together. This is the default for + * @flags: flags for the GPIO lines, with values from &enum + * gpio_v2_line_flag, such as %GPIO_V2_LINE_FLAG_ACTIVE_LOW, + * %GPIO_V2_LINE_FLAG_OUTPUT etc, added together. This is the default for * all requested lines but may be overridden for particular lines using - * attrs. - * @num_attrs: the number of attributes in attrs + * @attrs. + * @num_attrs: the number of attributes in @attrs * @padding: reserved for future use and must be zero filled * @attrs: the configuration attributes associated with the requested * lines. Any attribute should only be associated with a particular line @@ -175,17 +175,17 @@ struct gpio_v2_line_config { * "my-bitbanged-relay" * @config: requested configuration for the lines. * @num_lines: number of lines requested in this request, i.e. the number - * of valid fields in the GPIO_V2_LINES_MAX sized arrays, set to 1 to + * of valid fields in the %GPIO_V2_LINES_MAX sized arrays, set to 1 to * request a single line * @event_buffer_size: a suggested minimum number of line events that the * kernel should buffer. This is only relevant if edge detection is * enabled in the configuration. Note that this is only a suggested value * and the kernel may allocate a larger buffer or cap the size of the * buffer. If this field is zero then the buffer size defaults to a minimum - * of num_lines*16. + * of @num_lines * 16. * @padding: reserved for future use and must be zero filled * @fd: if successful this field will contain a valid anonymous file handle - * after a GPIO_GET_LINE_IOCTL operation, zero or negative value means + * after a %GPIO_GET_LINE_IOCTL operation, zero or negative value means * error */ struct gpio_v2_line_request { @@ -207,11 +207,12 @@ struct gpio_v2_line_request { * @consumer: a functional name for the consumer of this GPIO line as set * by whatever is using it, will be empty if there is no current user but * may also be empty if the consumer doesn't set this up - * @flags: flags for the GPIO line, such as GPIO_V2_LINE_FLAG_ACTIVE_LOW, - * GPIO_V2_LINE_FLAG_OUTPUT etc, OR:ed together * @offset: the local offset on this GPIO chip, fill this in when * requesting the line information from the kernel - * @num_attrs: the number of attributes in attrs + * @num_attrs: the number of attributes in @attrs + * @flags: flags for the GPIO lines, with values from &enum + * gpio_v2_line_flag, such as %GPIO_V2_LINE_FLAG_ACTIVE_LOW, + * %GPIO_V2_LINE_FLAG_OUTPUT etc, added together. * @attrs: the configuration attributes associated with the line * @padding: reserved for future use */ @@ -244,7 +245,7 @@ enum gpio_v2_line_changed_type { * of a GPIO line * @info: updated line information * @timestamp_ns: estimate of time of status change occurrence, in nanoseconds - * @event_type: the type of change with a value from enum + * @event_type: the type of change with a value from &enum * gpio_v2_line_changed_type * @padding: reserved for future use */ @@ -269,10 +270,10 @@ enum gpio_v2_line_event_id { /** * struct gpio_v2_line_event - The actual event being pushed to userspace * @timestamp_ns: best estimate of time of event occurrence, in nanoseconds. - * The timestamp_ns is read from CLOCK_MONOTONIC and is intended to allow the - * accurate measurement of the time between events. It does not provide + * The @timestamp_ns is read from %CLOCK_MONOTONIC and is intended to allow + * the accurate measurement of the time between events. It does not provide * the wall-clock time. - * @id: event identifier with value from enum gpio_v2_line_event_id + * @id: event identifier with value from &enum gpio_v2_line_event_id * @offset: the offset of the line that triggered the event * @seqno: the sequence number for this event in the sequence of events for * all the lines in this line request @@ -319,8 +320,8 @@ struct gpio_v2_line_event { * whatever is using it, will be empty if there is no current user but may * also be empty if the consumer doesn't set this up * - * This struct is part of ABI v1 and is deprecated. - * Use struct gpio_v2_line_info instead. + * Note: This struct is part of ABI v1 and is deprecated. + * Use &struct gpio_v2_line_info instead. */ struct gpioline_info { __u32 line_offset; @@ -344,18 +345,18 @@ enum { * of a GPIO line * @info: updated line information * @timestamp: estimate of time of status change occurrence, in nanoseconds - * @event_type: one of GPIOLINE_CHANGED_REQUESTED, GPIOLINE_CHANGED_RELEASED - * and GPIOLINE_CHANGED_CONFIG + * @event_type: one of %GPIOLINE_CHANGED_REQUESTED, + * %GPIOLINE_CHANGED_RELEASED and %GPIOLINE_CHANGED_CONFIG * @padding: reserved for future use * - * Note: struct gpioline_info embedded here has 32-bit alignment on its own, + * The &struct gpioline_info embedded here has 32-bit alignment on its own, * but it works fine with 64-bit alignment too. With its 72 byte size, we can * guarantee there are no implicit holes between it and subsequent members. * The 20-byte padding at the end makes sure we don't add any implicit padding * at the end of the structure on 64-bit architectures. * - * This struct is part of ABI v1 and is deprecated. - * Use struct gpio_v2_line_info_changed instead. + * Note: This struct is part of ABI v1 and is deprecated. + * Use &struct gpio_v2_line_info_changed instead. */ struct gpioline_info_changed { struct gpioline_info info; @@ -379,13 +380,13 @@ struct gpioline_info_changed { * @lineoffsets: an array of desired lines, specified by offset index for the * associated GPIO device * @flags: desired flags for the desired GPIO lines, such as - * GPIOHANDLE_REQUEST_OUTPUT, GPIOHANDLE_REQUEST_ACTIVE_LOW etc, OR:ed + * %GPIOHANDLE_REQUEST_OUTPUT, %GPIOHANDLE_REQUEST_ACTIVE_LOW etc, added * together. Note that even if multiple lines are requested, the same flags * must be applicable to all of them, if you want lines with individual * flags set, request them one by one. It is possible to select * a batch of input or output lines, but they must all have the same * characteristics, i.e. all inputs or all outputs, all active low etc - * @default_values: if the GPIOHANDLE_REQUEST_OUTPUT is set for a requested + * @default_values: if the %GPIOHANDLE_REQUEST_OUTPUT is set for a requested * line, this specifies the default output value, should be 0 (low) or * 1 (high), anything else than 0 or 1 will be interpreted as 1 (high) * @consumer_label: a desired consumer label for the selected GPIO line(s) @@ -393,11 +394,11 @@ struct gpioline_info_changed { * @lines: number of lines requested in this request, i.e. the number of * valid fields in the above arrays, set to 1 to request a single line * @fd: if successful this field will contain a valid anonymous file handle - * after a GPIO_GET_LINEHANDLE_IOCTL operation, zero or negative value + * after a %GPIO_GET_LINEHANDLE_IOCTL operation, zero or negative value * means error * - * This struct is part of ABI v1 and is deprecated. - * Use struct gpio_v2_line_request instead. + * Note: This struct is part of ABI v1 and is deprecated. + * Use &struct gpio_v2_line_request instead. */ struct gpiohandle_request { __u32 lineoffsets[GPIOHANDLES_MAX]; @@ -411,15 +412,15 @@ struct gpiohandle_request { /** * struct gpiohandle_config - Configuration for a GPIO handle request * @flags: updated flags for the requested GPIO lines, such as - * GPIOHANDLE_REQUEST_OUTPUT, GPIOHANDLE_REQUEST_ACTIVE_LOW etc, OR:ed + * %GPIOHANDLE_REQUEST_OUTPUT, %GPIOHANDLE_REQUEST_ACTIVE_LOW etc, added * together - * @default_values: if the GPIOHANDLE_REQUEST_OUTPUT is set in flags, + * @default_values: if the %GPIOHANDLE_REQUEST_OUTPUT is set in flags, * this specifies the default output value, should be 0 (low) or * 1 (high), anything else than 0 or 1 will be interpreted as 1 (high) * @padding: reserved for future use and should be zero filled * - * This struct is part of ABI v1 and is deprecated. - * Use struct gpio_v2_line_config instead. + * Note: This struct is part of ABI v1 and is deprecated. + * Use &struct gpio_v2_line_config instead. */ struct gpiohandle_config { __u32 flags; @@ -433,8 +434,8 @@ struct gpiohandle_config { * state of a line, when setting the state of lines these should contain * the desired target state * - * This struct is part of ABI v1 and is deprecated. - * Use struct gpio_v2_line_values instead. + * Note: This struct is part of ABI v1 and is deprecated. + * Use &struct gpio_v2_line_values instead. */ struct gpiohandle_data { __u8 values[GPIOHANDLES_MAX]; @@ -450,17 +451,17 @@ struct gpiohandle_data { * @lineoffset: the desired line to subscribe to events from, specified by * offset index for the associated GPIO device * @handleflags: desired handle flags for the desired GPIO line, such as - * GPIOHANDLE_REQUEST_ACTIVE_LOW or GPIOHANDLE_REQUEST_OPEN_DRAIN + * %GPIOHANDLE_REQUEST_ACTIVE_LOW or %GPIOHANDLE_REQUEST_OPEN_DRAIN * @eventflags: desired flags for the desired GPIO event line, such as - * GPIOEVENT_REQUEST_RISING_EDGE or GPIOEVENT_REQUEST_FALLING_EDGE + * %GPIOEVENT_REQUEST_RISING_EDGE or %GPIOEVENT_REQUEST_FALLING_EDGE * @consumer_label: a desired consumer label for the selected GPIO line(s) * such as "my-listener" * @fd: if successful this field will contain a valid anonymous file handle - * after a GPIO_GET_LINEEVENT_IOCTL operation, zero or negative value + * after a %GPIO_GET_LINEEVENT_IOCTL operation, zero or negative value * means error * - * This struct is part of ABI v1 and is deprecated. - * Use struct gpio_v2_line_request instead. + * Note: This struct is part of ABI v1 and is deprecated. + * Use &struct gpio_v2_line_request instead. */ struct gpioevent_request { __u32 lineoffset; @@ -481,8 +482,8 @@ struct gpioevent_request { * @timestamp: best estimate of time of event occurrence, in nanoseconds * @id: event identifier * - * This struct is part of ABI v1 and is deprecated. - * Use struct gpio_v2_line_event instead. + * Note: This struct is part of ABI v1 and is deprecated. + * Use &struct gpio_v2_line_event instead. */ struct gpioevent_data { __u64 timestamp; From patchwork Mon Oct 5 07:03:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Gibson X-Patchwork-Id: 267404 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E10C4363A for ; Mon, 5 Oct 2020 07:04:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D8B820795 for ; Mon, 5 Oct 2020 07:04:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eUjcrIU9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbgJEHEK (ORCPT ); Mon, 5 Oct 2020 03:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHEH (ORCPT ); Mon, 5 Oct 2020 03:04:07 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A541BC0613CE; Mon, 5 Oct 2020 00:04:07 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id az3so1781874pjb.4; Mon, 05 Oct 2020 00:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kQB2CpbEwKXkoeu2vbRv7Gb4T73FH3iFlUmGjPpa5t4=; b=eUjcrIU9R+jLvn03NfuE/m1MSS+2jECwGtWjQpd9a0CE9NW87bvfzlTBcaRde/aaG3 JZHvX0KJ77gGTqzozDQcVCu3hH+mefovoCx8VLJ5kvfG0KkMdQaRCxJ0RVz0CNGMrO7v P7mzQ8+/m0dJOn9Zh2KVTSCFSphw/GQf+Xl3abh2a6eqwvldlSpAiPTEvxKyoMU+PcwU AU/IfrGYyxr+hjSqYV7PlW5JU9w76cJz1m8OCA2nv/SoQfsMITVtCMMNJM0zJWE8bWXk /ylXjekEuLveXxXQFtcumB+HsLnx+oI5kuiDNJJBcpItm7k+Eo0PJ1SyLqPUr+Nihv22 MEcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kQB2CpbEwKXkoeu2vbRv7Gb4T73FH3iFlUmGjPpa5t4=; b=jhMpz8FXOfsGvBSaaZUhgPBCXB1jI/Yen8ysUg/qRI/khWWZeh294S2dTDjfMEJZgP foZ4nhhxeyBNCGgmg+3HFe/ay7TUh0CQKOIqDlDvh1rE7rDsoH+j9QEXE1n8jDEVmRov xD0kXkKArlfYld51LtSHTWje5sQLAIPZehxLR5GxhTLtY2io32qy2EWWw52ZUW777D6E IpIuE0HGu00nXWwy2ZyDXJaj4a5+VkIB2zzwiQSy5SGWhl1DGuWU9y3go4ccJvHqYYYz cDHG6VitqFTBalSb8YswgBnpt6CRex1C1gPgCR1UMMeH/vx0a/GCmaCm6aYLH8eINOFu K9eQ== X-Gm-Message-State: AOAM532PP50xb42/rY3FY2LENqfwaw/N9u7L11UGv+LPWQmgu7jJpQnr oA9J8Fh7Bik8nVCIe0eF8jaoEDfk04r7Sg== X-Google-Smtp-Source: ABdhPJywvW8Cv6mx1JWYM8TW+C69Pi0G6nYTsL3fWBKKQ1OKtq9v3hWrkJQSTWnRoHBChtkxWT14dA== X-Received: by 2002:a17:90a:203:: with SMTP id c3mr15067444pjc.149.1601881446884; Mon, 05 Oct 2020 00:04:06 -0700 (PDT) Received: from sol.lan (106-69-166-86.dyn.iinet.net.au. [106.69.166.86]) by smtp.gmail.com with ESMTPSA id 78sm6868764pfz.211.2020.10.05.00.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 00:04:06 -0700 (PDT) From: Kent Gibson To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, linus.walleij@linaro.org Cc: Kent Gibson Subject: [PATCH 4/5] gpio: uapi: remove whitespace Date: Mon, 5 Oct 2020 15:03:28 +0800 Message-Id: <20201005070329.21055-5-warthog618@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005070329.21055-1-warthog618@gmail.com> References: <20201005070329.21055-1-warthog618@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Remove leading whitespace in ABI v1 comment. Signed-off-by: Kent Gibson --- include/uapi/linux/gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h index 32dd18f238c3..ad3f56dd87ec 100644 --- a/include/uapi/linux/gpio.h +++ b/include/uapi/linux/gpio.h @@ -292,7 +292,7 @@ struct gpio_v2_line_event { }; /* - * ABI v1 + * ABI v1 * * This version of the ABI is deprecated. * Use the latest version of the ABI, defined above, instead. From patchwork Mon Oct 5 07:03:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Gibson X-Patchwork-Id: 285642 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0EDC4363A for ; Mon, 5 Oct 2020 07:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87E8C20795 for ; Mon, 5 Oct 2020 07:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PVHMM8oV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725979AbgJEHEP (ORCPT ); Mon, 5 Oct 2020 03:04:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHEM (ORCPT ); Mon, 5 Oct 2020 03:04:12 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E717C0613CE; Mon, 5 Oct 2020 00:04:12 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id p21so5455961pju.0; Mon, 05 Oct 2020 00:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/AE011iD+7PG9u5ZyKUnlIsF0Arck6Q8xxYUX6SocF4=; b=PVHMM8oVjonCZdND4kvCHRW5Eg+OUZNyc+GVVmlTFrTEY6oRAIth3xxE0HUrkGF5C9 01yCMfKjFRvTIL3pl0aRnWcZOZ9weDWwieETUn/Le/UvcR9xQvoZbqWINM30lHoZHbzC jGCzsdS7HEoGOZpf0PDleVH9mxESOyTWhE0vpj+u+EaQGsuLuanFfrKvAfJfSXB/JFgL nRQF4fdo57J5tv6vbBwqPxoTdPZY4z+7H9iZgMEiidkkR0disdp4pWhjVP5r7XvI85oZ mF9OajYfcdkuOO1HphuYH8JZ06Qk9XUvgFtsBX7uvlrgo0X5qoE4S8AlayhSxRHsx5ov BG/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/AE011iD+7PG9u5ZyKUnlIsF0Arck6Q8xxYUX6SocF4=; b=TrGXhVJafCF+6tW+ws7R159dKzOT1ZcWfHi2VgOD5Rys3oEXakvCbn3+f0UNKgWlw+ VcRD9ACm+hRrW+olvRWJePKplxJSJF8vnOgM1AkAJl92NVKVJ/aGoBAQ0Ck685/z+rhn wqRyY9Wn18tIQnqFWX/ElqAsSTgNNY0VGJD/9bdOLs0h0FS7ihgXvLZW0mOHOQZl4XNX oZseQMmlQiMqYkz1Co13kGw//1TwUZb9AP9pyAIX/cxuDh8aaHITRGRimtTrj8LT6aVr ZHXaCmxLvcBv+nEzYaR9Yubh21h8ZlZU7P+3HVZVoSfk6UToWj5V6WcgQdzS6wWqKuwz 7cGQ== X-Gm-Message-State: AOAM533c2hvO9imsNYC7LfMmzH4n7K8NgC2aDyOJzPJ/6nsDrDDf1jU4 8sOAQICtU9PnTKQ/TbKwVfyCO6phh0dawg== X-Google-Smtp-Source: ABdhPJypECjbD8lZKiIdzEukIpWhP9x0L+odGm8H5xX050+Ma9cbmhBUPZalQqcL6MhWfLSXA3zzTA== X-Received: by 2002:a17:90a:94cc:: with SMTP id j12mr3916946pjw.106.1601881451246; Mon, 05 Oct 2020 00:04:11 -0700 (PDT) Received: from sol.lan (106-69-166-86.dyn.iinet.net.au. [106.69.166.86]) by smtp.gmail.com with ESMTPSA id 78sm6868764pfz.211.2020.10.05.00.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 00:04:10 -0700 (PDT) From: Kent Gibson To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, linus.walleij@linaro.org Cc: Kent Gibson Subject: [PATCH 5/5] gpio: uapi: clarify the meaning of 'empty' char arrays Date: Mon, 5 Oct 2020 15:03:29 +0800 Message-Id: <20201005070329.21055-6-warthog618@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005070329.21055-1-warthog618@gmail.com> References: <20201005070329.21055-1-warthog618@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Clarify that a char array containing a string is considered 'empty' if the first character is the null terminator. The remaining characters are not relevant to this determination. Signed-off-by: Kent Gibson --- include/uapi/linux/gpio.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h index ad3f56dd87ec..2072c260f5d0 100644 --- a/include/uapi/linux/gpio.h +++ b/include/uapi/linux/gpio.h @@ -26,7 +26,7 @@ * struct gpiochip_info - Information about a certain GPIO chip * @name: the Linux kernel name of this GPIO chip * @label: a functional name for this GPIO chip, such as a product - * number, may be empty + * number, may be empty (i.e. label[0] == '\0') * @lines: number of GPIO lines on this chip */ struct gpiochip_info { @@ -203,7 +203,7 @@ struct gpio_v2_line_request { * struct gpio_v2_line_info - Information about a certain GPIO line * @name: the name of this GPIO line, such as the output pin of the line on * the chip, a rail or a pin header name on a board, as specified by the - * GPIO chip, may be empty + * GPIO chip, may be empty (i.e. name[0] == '\0') * @consumer: a functional name for the consumer of this GPIO line as set * by whatever is using it, will be empty if there is no current user but * may also be empty if the consumer doesn't set this up @@ -315,7 +315,7 @@ struct gpio_v2_line_event { * @flags: various flags for this line * @name: the name of this GPIO line, such as the output pin of the line on the * chip, a rail or a pin header name on a board, as specified by the gpio - * chip, may be empty + * chip, may be empty (i.e. name[0] == '\0') * @consumer: a functional name for the consumer of this GPIO line as set by * whatever is using it, will be empty if there is no current user but may * also be empty if the consumer doesn't set this up