From patchwork Tue Oct 31 11:21:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 117580 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp3772463qgn; Tue, 31 Oct 2017 04:22:11 -0700 (PDT) X-Google-Smtp-Source: ABhQp+RnEO8RrejM6zj4vddiAupFs1+AxmgL98ILdHP0hELYZNzvcmg/DmIp7B0OtBDTAvkq+Ax5 X-Received: by 10.28.132.66 with SMTP id g63mr1501249wmd.22.1509448931489; Tue, 31 Oct 2017 04:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509448931; cv=none; d=google.com; s=arc-20160816; b=E2sJdT5X81IyHSDShVugZ81LAKJYOKEXhVPyoxhFX99k0+tXNy8NK6jFHMW/FkeyIe wuGur0Yiymo2YUnQ/xHF4HL/wXa+G/Hr2EuAbW5rXdl0VTdnGj2znLqQODASdbhvS6Jn Dua+cqE8TUXD9UFK720Oy2tV3SYMcKbR3FMcs1ldfKAWAucY4wnvSAa26osQga8sq6tK qXYukPDtnkjnuVGdGS9hT1RmKAm9it6/OfXnANBuIlG7HO2++q/Fn9RbWsnoe4vwIsjS RZQGwZXOxLxeFjlbW70qgD9khGsZ8su8JPO6f2z+AtqDxtL/6uHnJjd5cNW2yZiqgU1f NePA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=GDuL+ROTOznJypfb1HtxSBSNFrn8aFgGVgNwuMpz50M=; b=G7jKUFcPNGxw166ROtYONpv1QOeUZGRkv4Y/s0wmTMQG2uCSGl/QGTyHWH8XSlxJUH ds56btzKCW8R+573gkqDnJXscnBSkaTkuX/RGw2OhRvriTHOpalBtUo/ibLrAQJar97E 2VvfvtRiec39MQkoe4DH4o5iL3pR5qpPSXDhuCWZL5kyBMTFetPcOdJSw5rsTOFexb9i a2rXmLQIqJ3Et7vT1LLnEd0oJqtIS/W/rSZun3Zj37uYqJxk1cmTOKcPwYlgp/T7+KBH /IL4ACt59l0L3hFjivbKWFdtLv8AnvQQBoy8xFALPNApQblcKqMP9IRs0dNXWvo7gmLo EluQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=JdB3x3dB; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id j15si1513958wme.18.2017.10.31.04.22.11; Tue, 31 Oct 2017 04:22:11 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=JdB3x3dB; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 2F5F92672AC; Tue, 31 Oct 2017 12:21:29 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 38BFA2672A8; Tue, 31 Oct 2017 12:21:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 1FEDF26728A for ; Tue, 31 Oct 2017 12:21:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=G+G8YHKukLrRio7JnRFUteRvWUV+Ne4aQKEK8GLUp0c=; b=JdB3x3dBoruL k6q4P/AKPxVGhhT9JUYLOBT/2aQrQLfVOqV3/KkIRX9tT+ooV9/4e/Vq4d7DqjjqKZikwf7us4Vlg qNpXRfN5M80ZaqWegpO42FNMbyjybb/Hw6CA0juLtAJc+69L8p5veoLZMR1d9H90VZsfZrxAZCi00 dMlio=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1e9Ube-00015E-8t; Tue, 31 Oct 2017 11:21:18 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1e9Ubd-0002nC-RG; Tue, 31 Oct 2017 11:21:17 +0000 From: Mark Brown To: Kuninori Morimoto In-Reply-To: <87she0xim3.wl%kuninori.morimoto.gx@renesas.com> Message-Id: Date: Tue, 31 Oct 2017 11:21:17 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown , "Yokoyama \(Renesas\)" , Simon Subject: [alsa-devel] Applied "ASoC: rsnd: Don't check SSISR::DIRQ when Capture" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rsnd: Don't check SSISR::DIRQ when Capture has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From ce548931207c0d0059bd90171e2c458f897354d7 Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto Date: Tue, 31 Oct 2017 00:40:32 +0000 Subject: [PATCH] ASoC: rsnd: Don't check SSISR::DIRQ when Capture When stop case, it was Playback, it need to check all data were completely sent. But in Capture case, it might not receive data anymore. SSISR::DIRQ check is not need for Capture case. Reported-by: Hiroyuki Yokoyama Signed-off-by: Kuninori Morimoto Signed-off-by: Mark Brown --- sound/soc/sh/rcar/ssi.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- 2.15.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 61b4ce20ee2b..58e3420a1f05 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -598,15 +598,18 @@ static int rsnd_ssi_stop(struct rsnd_mod *mod, if (rsnd_ssi_is_parent(mod, io)) return 0; - /* - * disable all IRQ, - * and, wait all data was sent - */ cr = ssi->cr_own | ssi->cr_clk; - rsnd_mod_write(mod, SSICR, cr | EN); - rsnd_ssi_status_check(mod, DIRQ); + /* + * disable all IRQ, + * Playback: Wait all data was sent + * Capture: It might not receave data. Do nothing + */ + if (rsnd_io_is_play(io)) { + rsnd_mod_write(mod, SSICR, cr | EN); + rsnd_ssi_status_check(mod, DIRQ); + } /* * disable SSI,