From patchwork Wed Sep 16 00:46:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 305301 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910DEC43461 for ; Wed, 16 Sep 2020 00:48:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C59520770 for ; Wed, 16 Sep 2020 00:48:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yUB+GUJ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C59520770 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kILcr-0000Cj-3t for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 20:48:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kILav-0006CK-CC for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:45 -0400 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:55221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kILat-0001VM-CC for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:45 -0400 Received: by mail-pj1-x1041.google.com with SMTP id mm21so663495pjb.4 for ; Tue, 15 Sep 2020 17:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JlzqTM8MN4TgFiIIYSOlECE3VdxOaRIuKAB56KsJHUw=; b=yUB+GUJ48KcdLz4tskSlwvs/6KoJcFilBd4dSdNlrS0Z8UKcuNx/IkQBKYpMIF2pNt NTQrGJdfqkF5PvR8LIddUdIM12mJYtT2Gy5i704InoURar7a4V34BqhPLsHkTQbaDfeq wYIE1W4QPsZRwYDh5fdu40YD+s6tYv9PD15eyZ1JbtU9p/kf5WwLbY/qdqkH62DTxRrh GV/nAFMlDAijuPZlHOGzXgjEmqNHWIZAYkCgjYiN7JMsbcUe3b10vvJesx+JMNupL9Bi E47d++PfoCa5Anscv7sQHooAgd9XDQeuw5v4WW5MDwRJk49dMTyT0W+pXcpJThBPKlYi E7uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JlzqTM8MN4TgFiIIYSOlECE3VdxOaRIuKAB56KsJHUw=; b=rnO/mmTEv3k4GGC01liPvO0yzgl5YECvVS/UlxEaDdDfdBcmRnow2lSeHGbWu8LoPe gdmOPZFDHSZmnkhmkafWRj1Tv+5DSigNECmtP9+9cCRpo9ApuVay3YXKN70Dn52UCD/x ncV6GLrDhPBeNmb1f4p4O5hTixzxbdpX2P3NFHLtS5uBiCAXSI1MpCMqs8NfcU33oKey SimLKdggGaV/buvsqnHhz7TQ65AWI0EedmI2634O3zC6V7vwrKuZOonoxvJXUHnjj3v3 YJIYGkXL0nwngi7qgRE00TDg/ttrnwnmUHYVMkXFjsrtNTfpL5Hl2VwIEYMwclyoGxez e0qw== X-Gm-Message-State: AOAM533sJquGxF5M3SEM8rdLJk/nxDBxL1Fi2EGEq27J7gVtss6rhFbA d3jQaYo+A+nIuALJ4F57Y10JRzQdlk/04w== X-Google-Smtp-Source: ABdhPJy6VBIa0S05MzVu5YswlHGmEMaw4Q6wYDdfN/qb/tVPa0UbXpVDnJVvkKjv3J4CqcYTsr5VAw== X-Received: by 2002:a17:90a:ca82:: with SMTP id y2mr1648127pjt.233.1600217201728; Tue, 15 Sep 2020 17:46:41 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id kf10sm611723pjb.2.2020.09.15.17.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:46:41 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign Date: Tue, 15 Sep 2020 17:46:33 -0700 Message-Id: <20200916004638.2444147-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org> References: <20200916004638.2444147-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1041.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" We do not need or want to be allocating page sized quanta. Signed-off-by: Richard Henderson --- Cc: Stefan Weil --- util/oslib-win32.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/util/oslib-win32.c b/util/oslib-win32.c index c654dafd93..8d838bf342 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -56,10 +56,8 @@ void *qemu_try_memalign(size_t alignment, size_t size) { void *ptr; - if (!size) { - abort(); - } - ptr = VirtualAlloc(NULL, size, MEM_COMMIT, PAGE_READWRITE); + assert(size != 0); + ptr = _aligned_malloc(alignment, size); trace_qemu_memalign(alignment, size, ptr); return ptr; } @@ -93,9 +91,7 @@ void *qemu_anon_ram_alloc(size_t size, uint64_t *align, bool shared) void qemu_vfree(void *ptr) { trace_qemu_vfree(ptr); - if (ptr) { - VirtualFree(ptr, 0, MEM_RELEASE); - } + _aligned_free(ptr); } void qemu_anon_ram_free(void *ptr, size_t size) From patchwork Wed Sep 16 00:46:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 305300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B672EC43461 for ; Wed, 16 Sep 2020 00:50:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51EDC20738 for ; Wed, 16 Sep 2020 00:50:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mrAEDLWa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51EDC20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kILeq-0002so-GS for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 20:50:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kILax-0006HD-UQ for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:47 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:33394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kILau-0001Vd-LQ for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:47 -0400 Received: by mail-pf1-x444.google.com with SMTP id z18so413214pfg.0 for ; Tue, 15 Sep 2020 17:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+jDBZOfLiTrHQFNxHg77u5bGYtXjoCt88pLLuScea1s=; b=mrAEDLWaG0r6y4SrB4wKFW0RpKtBFvptgTnZrV0obPYX1D8UPQRcAHZlThDotJQL+v EPvaUkAX8MXvkmhcFUWiRkbTKgrm64Pyp0wMRe+EXytC4o+2fvpzhFpNRaUFIKfPrGQE 7Scz5okPjMt94y2zl/Ar3MUlrDVHLkmEoXzcwlVcDPO7HtUS6EqhVHu+5jK3QD7VvpQR 546j6RabTgu6ZbuErwgyFnSLqCNP1e0Cak22uZgcrNJel3tVv8AdJx3TxyjgP08FvEh+ v1H4vr4T02c4uKSlKBqSMCnHd5nuJMXg+mZCKpvP8PcMptP7c1NGASw0TtkJ/XKW/tB2 2R9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+jDBZOfLiTrHQFNxHg77u5bGYtXjoCt88pLLuScea1s=; b=CMg+e5s7kC5Mpxq1cbpG6nLFdQKBsBoxbkqfBme4/m/Zt2obu8JiXcVLipX6B9WcVN Zl2GO5gU/IqgLEWly17uaKa9p1G+mZ+JsMltky3SxHahh1vBU7/b/Z6NoqBIGas8Lwly NxDaRcx6k4NHHksTl9eXvsFTGfB3rS5f8kML9HvbhSM1AA3QN+ros7OBDP+n1Vew7aCq nfuky+PQzjXNuIFC9+9+e/WGtHVuz+KN4xM6FqNU13cSUcu0x1LFCKz+vsAuGM+Vmv1e 1lVICeEsXnHeWhDvtosTnpx3zoIUm4o2zr0kpVB9X7DHfB8YgZoLWu5EPtd3tc5m6UUB xs0g== X-Gm-Message-State: AOAM530anw78D81Fw3rDBAzQCbO5q2/hqGmf391Gvl7HnDNPlQ14NFuD hUGBdFls+QdcdWH+5YHJ6PiVHi9pkFCEfA== X-Google-Smtp-Source: ABdhPJwBKhgsIWz+hInQGSaNJP6ku4tXxczmI2H3qaPlpHhMk2WYbEtGPZ6VCpw9S28/s4tSTxi67Q== X-Received: by 2002:a63:c9:: with SMTP id 192mr16920983pga.37.1600217202984; Tue, 15 Sep 2020 17:46:42 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id kf10sm611723pjb.2.2020.09.15.17.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:46:42 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 2/6] qom: Allow objects to be allocated with increased alignment Date: Tue, 15 Sep 2020 17:46:34 -0700 Message-Id: <20200916004638.2444147-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org> References: <20200916004638.2444147-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang?= =?utf-8?b?w6k=?= , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" It turns out that some hosts have a default malloc alignment less than that required for vectors. We assume that, with compiler annotation on CPUArchState, that we can properly align the vector portion of the guest state. Fix the alignment of the allocation by using qemu_memalloc when required. Signed-off-by: Richard Henderson --- Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost --- include/qom/object.h | 5 +++++ qom/object.c | 36 +++++++++++++++++++++++++++++++++--- 2 files changed, 38 insertions(+), 3 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 056f67ab3b..5709c36859 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -691,6 +691,7 @@ struct Object .parent = TYPE_##PARENT_MODULE_OBJ_NAME, \ .name = TYPE_##MODULE_OBJ_NAME, \ .instance_size = sizeof(ModuleObjName), \ + .instance_align = __alignof__(ModuleObjName), \ .instance_init = module_obj_name##_init, \ .instance_finalize = module_obj_name##_finalize, \ .class_size = sizeof(ModuleObjName##Class), \ @@ -770,6 +771,9 @@ struct Object * @instance_size: The size of the object (derivative of #Object). If * @instance_size is 0, then the size of the object will be the size of the * parent object. + * @instance_align: The required alignment of the object. If @instance_align + * is 0, then normal malloc alignment is sufficient; if non-zero, then we + * must use qemu_memalign for allocation. * @instance_init: This function is called to initialize an object. The parent * class will have already been initialized so the type is only responsible * for initializing its own members. @@ -807,6 +811,7 @@ struct TypeInfo const char *parent; size_t instance_size; + size_t instance_align; void (*instance_init)(Object *obj); void (*instance_post_init)(Object *obj); void (*instance_finalize)(Object *obj); diff --git a/qom/object.c b/qom/object.c index 387efb25eb..fcc15f6d88 100644 --- a/qom/object.c +++ b/qom/object.c @@ -50,6 +50,7 @@ struct TypeImpl size_t class_size; size_t instance_size; + size_t instance_align; void (*class_init)(ObjectClass *klass, void *data); void (*class_base_init)(ObjectClass *klass, void *data); @@ -114,6 +115,7 @@ static TypeImpl *type_new(const TypeInfo *info) ti->class_size = info->class_size; ti->instance_size = info->instance_size; + ti->instance_align = info->instance_align; ti->class_init = info->class_init; ti->class_base_init = info->class_base_init; @@ -688,16 +690,44 @@ static void object_finalize(void *data) } } +/* Find the minimum alignment guaranteed by the system malloc. */ +#if __STDC_VERSION__ >= 201112L +typddef max_align_t qemu_max_align_t; +#else +typedef union { + long l; + void *p; + double d; + long double ld; +} qemu_max_align_t; +#endif + static Object *object_new_with_type(Type type) { Object *obj; + size_t size, align; + void (*obj_free)(void *); g_assert(type != NULL); type_initialize(type); - obj = g_malloc(type->instance_size); - object_initialize_with_type(obj, type->instance_size, type); - obj->free = g_free; + size = type->instance_size; + align = type->instance_align; + + /* + * Do not use qemu_memalign unless required. Depending on the + * implementation, extra alignment implies extra overhead. + */ + if (likely(align <= __alignof__(qemu_max_align_t))) { + obj = g_malloc(size); + obj_free = g_free; + } else { + obj = qemu_memalign(align, size); + obj_free = qemu_vfree; + } + + object_initialize_with_type(obj, size, type); + obj->free = obj_free; return obj; } From patchwork Wed Sep 16 00:46:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 273629 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0127C433E2 for ; Wed, 16 Sep 2020 00:48:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40E0120770 for ; Wed, 16 Sep 2020 00:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h3gEi3/s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40E0120770 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kILcm-0008RE-9K for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 20:48:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kILax-0006G3-En for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:47 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:43969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kILav-0001Vx-Rz for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:47 -0400 Received: by mail-pl1-x644.google.com with SMTP id e4so2238988pln.10 for ; Tue, 15 Sep 2020 17:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RffEK/rCiFhZmvHDae5MdJFHwlUbrlsn383XqLguch4=; b=h3gEi3/slhIcV2djfTfSFVwGQfUeVhbW29GKU+wNBAYZRYASifAYiwU2GhWCopKRrk L2cRJicJ2fWTVWiBNOcHYFAz4Qr/dcDtREvGcwoaxy8BN2MEl96W6+FOOlxL+etoCmmV vXOHiIIIkQGcTwAY7n/vW6A6O79WtP+H/k9ECczFOK86JyP5D+yF5qVmu0F3Pcz8xnN6 mrQNM9gkBYfRtKrSmvaYZ8I3tPv+F3t1TF6ejXJ+HAKyJuHDLHlh/eX0OKChTdzNY1gH hykkkHPW44bEvk/L/qE95/bsMGOS2aRLAsmVG684xbfTYTPUjRaG63/YNHjVq5w++TDU 0c5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RffEK/rCiFhZmvHDae5MdJFHwlUbrlsn383XqLguch4=; b=r0cUaQ1wTIyJZLc1BzNXzdTaKNaQNS8uqbesDhl/kiGKbIJNWkTq9VuYBms6Q7+GuX BPY98p1H+uawKkLO1+MjsQq83/udhwbPQheDGXvfDO2uNYhhoi1yajTvbsr63Yk+1knj EP9Vn3gupp7vaUAFlzOPktbdhsX5wzlPtuT3OQ4ZVk1jDhoa5AD5wo23MsHrsMetp2/z bdPzt88PtIGA5Srl46g1mEm7e7HDMM6EW4T8KOxlYMh0cxc0Lh3MzPW+q9kh9g0F/gsZ NxVrmXt7k3+jcG9HJn5gijBfY8Ski5+iqCKNKaLIHvoMDs+Nokgl8A2/GoznRmlDlLqN zXqg== X-Gm-Message-State: AOAM530ITku+g+HzySFpiYhJ//IFDtNj+XjJuIqUfr1zSpfy4T8vNTNG yMf5qjy4nWm+H3YvuonaABU6D9mdRedaog== X-Google-Smtp-Source: ABdhPJx+h+9xqaf8n1Ja6zNGxq0+GezVWStbgn6ST6XO8IRIoMO7Mxy1rvEsCg30nuIQea6aJltR9Q== X-Received: by 2002:a17:90a:ad8b:: with SMTP id s11mr1713407pjq.40.1600217204217; Tue, 15 Sep 2020 17:46:44 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id kf10sm611723pjb.2.2020.09.15.17.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:46:43 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 3/6] target/arm: Set instance_align on CPUARM TypeInfo Date: Tue, 15 Sep 2020 17:46:35 -0700 Message-Id: <20200916004638.2444147-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org> References: <20200916004638.2444147-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x644.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fix alignment of CPUARMState.vfp.zregs. Signed-off-by: Richard Henderson --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- target/arm/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 7b5ea65fab..a7643deab4 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -2290,6 +2290,7 @@ void arm_cpu_register(const ARMCPUInfo *info) TypeInfo type_info = { .parent = TYPE_ARM_CPU, .instance_size = sizeof(ARMCPU), + .instance_align = __alignof__(ARMCPU), .instance_init = arm_cpu_instance_init, .class_size = sizeof(ARMCPUClass), .class_init = info->class_init ?: cpu_register_class_init, @@ -2305,6 +2306,7 @@ static const TypeInfo arm_cpu_type_info = { .name = TYPE_ARM_CPU, .parent = TYPE_CPU, .instance_size = sizeof(ARMCPU), + .instance_align = __alignof__(ARMCPU), .instance_init = arm_cpu_initfn, .instance_finalize = arm_cpu_finalizefn, .abstract = true, From patchwork Wed Sep 16 00:46:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 273627 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B421C433E2 for ; Wed, 16 Sep 2020 00:51:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D108021973 for ; Wed, 16 Sep 2020 00:51:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h7L0pgKP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D108021973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kILf4-00032y-0G for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 20:51:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kILay-0006Ib-G7 for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:48 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:35767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kILaw-0001WT-R1 for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:48 -0400 Received: by mail-pf1-x442.google.com with SMTP id o68so2968042pfg.2 for ; Tue, 15 Sep 2020 17:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zb/g+Fvikq2LApYjpqfoFSuv71lvaud3AwPVH756moE=; b=h7L0pgKPC0W0oEwh5/ubrCmFUy2fLCRxqL/CLrRJ9TigHUTVKt1wHEKBqbQKSHUE7u vk5Lc2MSGnPxGOxWtgqPeQWEeO+DzSb0h6n0rzJ1IGjRNbCjiAPRVIcNHgvz5jdJyGPH Hj0Zv6TG8TRGZ9/aHUQGHnlr8x1tdUo3OQ9Tb7eJyay1NP03X9kRqOJLmOnKhHMe3xzG HX2Hexo9c4YOqOOIkuo4g1xfdSR1C78+iX4kJi8A4I55s3em3iPu3vJHsHJuu+PT9sss ebK2nzS0NtlpPV5lptyyjDxZ7wr3hwnprx3F1Q76bKgYXZUuT5TFmZxQrarny/x1fPQt w16w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zb/g+Fvikq2LApYjpqfoFSuv71lvaud3AwPVH756moE=; b=SvYwabpt+3dhp/9TMtKKRPj7AvlxguEsRgt36FtRkV+Llgc1hJJefRMzXkrv+jrGPJ Fe0ZJ3hlYKg+eXbLQ6x7Gspmc/3sxsrdC63g0v8V9mwhzgL+G5kFcnsboyYMkm3e3K53 6BWKGkQb8iRjf139obuWwTWyfWS5VjgZ6ix8pMas+w+YKgWdOBbgOvE5tcpgYxtuxZ8K NnuQqu6IsswUbO6f5IXmMUEWPsh8B/KpnmXx1K+Rx5LQQ1W3EhEksnbntBUeivJozRcv sj1OV7uSgufAziW6DD6HSXkz2MOl1zjUbMyc808XEeC35ugR26xzVvogayTWezEnsywx EQ+w== X-Gm-Message-State: AOAM531NzQ82NGXNBQG0eFxZqzh4+tFWWg7nZ11DzWNYd8SRujvlqB9K 8OEtdXNZGosWTKhnil47QMx6Foo8lONeHw== X-Google-Smtp-Source: ABdhPJznwfBpFEHmNAKipCJRgIBqFEmIs4WQKPT3KH8b9+GwSYJVPRtAbwzl3uI+L3IZT/I5OC+IQg== X-Received: by 2002:a63:fc04:: with SMTP id j4mr502866pgi.310.1600217205229; Tue, 15 Sep 2020 17:46:45 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id kf10sm611723pjb.2.2020.09.15.17.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:46:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo Date: Tue, 15 Sep 2020 17:46:36 -0700 Message-Id: <20200916004638.2444147-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org> References: <20200916004638.2444147-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fix alignment of CPUPPCState.vsr. Signed-off-by: Richard Henderson Acked-by: David Gibson --- Cc: David Gibson Cc: qemu-ppc@nongnu.org --- target/ppc/translate_init.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.inc index 230a062d29..accb4f2fae 100644 --- a/target/ppc/translate_init.c.inc +++ b/target/ppc/translate_init.c.inc @@ -10960,6 +10960,7 @@ static const TypeInfo ppc_cpu_type_info = { .name = TYPE_POWERPC_CPU, .parent = TYPE_CPU, .instance_size = sizeof(PowerPCCPU), + .instance_align = __alignof__(PowerPCCPU), .instance_init = ppc_cpu_instance_init, .instance_finalize = ppc_cpu_instance_finalize, .abstract = true, From patchwork Wed Sep 16 00:46:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 305302 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6EAAC43461 for ; Wed, 16 Sep 2020 00:48:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43B652076B for ; Wed, 16 Sep 2020 00:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V4SZ0rI5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43B652076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kILcQ-00083c-CZ for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 20:48:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kILaz-0006KY-DI for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:49 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:35395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kILax-0001Wt-Uv for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:49 -0400 Received: by mail-pj1-x102e.google.com with SMTP id jw11so651274pjb.0 for ; Tue, 15 Sep 2020 17:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dqbg1+YUD56oz0mEVRHEVZEpbEBWoWejpoX6YFZKEQU=; b=V4SZ0rI5iaEkHjBOYajV8wfP166DB7wHEjOLKMGwCBLD0HZlXs+HqwlB9dyXR6h5YD eXylJy52HH2bIJx+N6TbnJ/29tJ9gFGq+TfoZv3Zo2+eAfC4A7a94wqY2UrUFAmCVIsk tssV5c6rNM7E5S7A2Xq0EE11VI6ivpzcqMfOlSIY6tdyWZV+zij/ai1pArOZcUS4VMQA Ys+/kq37QgJeROu4ay8yPMki5IFXVOLKmaNvqRORf9YgSwIOkErvZ3AbjYV0zV4noqPT mdZ94XDQ/9wsFWBIaDHewPKZXN3RErshA+oPQcne0LwFzmcenkTneWQQJvyhlNjsNfHl 3XMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dqbg1+YUD56oz0mEVRHEVZEpbEBWoWejpoX6YFZKEQU=; b=CYrlQPUTUfd48AMQFlXHkZUpfrYs4WGX45zedxap6lm2LguE3NiU7dtLw0ZdXySy5y JhEqAg6AlEViW1T89Wr0LSqiDsYHKK5ARYRfG5XxmXHDA/fv8Vu+b+uzuO2cQkER8wxs jW+h3gLRgKBEY98i+8wvz22XnwM4p4ZVUYFY3qMtWDj8RvdervykTqTC/v2QogzPNJt8 Fm+dOmOwuxMAZ2n/+HeWYHJ1KUywSZ0Ee6qxlddonkXGQLYMuuEM0HllixBRYiYQlZ+5 SL/vJ6cV1L4N3ad/Pr4K9v7dkfRsow3OxY1qgnKItuSTAmE/ItG6O8y7vtEiqEmrszQ/ CTfw== X-Gm-Message-State: AOAM530DRsW5Eucvhlcwnnjf8GZucFhqPlAGXtQc8v7E+ntBkzWJDZT5 ESKWtLp7jsaGFkL40i+UtbmfG0lyylz8Kw== X-Google-Smtp-Source: ABdhPJyB0a6HD1odyvXgF/38HdPTjf6DkmeoNFdyBFVad/ZfeBolhbcsjiNw6CZ4BFbrhrH4EdL3bw== X-Received: by 2002:a17:90b:793:: with SMTP id l19mr1728901pjz.154.1600217206348; Tue, 15 Sep 2020 17:46:46 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id kf10sm611723pjb.2.2020.09.15.17.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:46:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 5/6] target/riscv: Set instance_align on RISCVCPU TypeInfo Date: Tue, 15 Sep 2020 17:46:37 -0700 Message-Id: <20200916004638.2444147-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org> References: <20200916004638.2444147-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-riscv@nongnu.org, Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fix alignment of CPURISCVState.vreg. Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis --- Cc: Alistair Francis Cc: qemu-riscv@nongnu.org --- target/riscv/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 57c006df5d..0bbfd7f457 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -628,6 +628,7 @@ static const TypeInfo riscv_cpu_type_infos[] = { .name = TYPE_RISCV_CPU, .parent = TYPE_CPU, .instance_size = sizeof(RISCVCPU), + .instance_align = __alignof__(RISCVCPU), .instance_init = riscv_cpu_init, .abstract = true, .class_size = sizeof(RISCVCPUClass), From patchwork Wed Sep 16 00:46:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 273628 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D88C433E2 for ; Wed, 16 Sep 2020 00:50:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E188D2076B for ; Wed, 16 Sep 2020 00:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WCvepBfR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E188D2076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kILee-0002c3-1k for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 20:50:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kILb0-0006NM-Gn for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:50 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:43753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kILaz-0001XI-0G for qemu-devel@nongnu.org; Tue, 15 Sep 2020 20:46:50 -0400 Received: by mail-pf1-x442.google.com with SMTP id f18so2931871pfa.10 for ; Tue, 15 Sep 2020 17:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JotyD3Qtuzk8QZcm87RVQJeRfD10PDp771HanSJw7Xg=; b=WCvepBfRMPAhNhxSYLySFjeWH23Gb/k9tSYZijeKnUJAm5d0DPCLx20bQfW5v5nf3H DznCfD03kdI8lR8Y+E5R+3wX9dJrot7KAryMuAbhAS54n0pNDDMjH1T1bUm+vL3T8iDl GzmqYwzbvf3jxTk9UH9b6DD7q6QKOJrNyS7jwwctgTBORK/b1pk/Grp/GI3h8IV8gYt1 l//xb/UEZIn1PONl5mlknEOM+u4IVzUb8vHrTfuW5c6vgiyAARgpJvaTK7qHYX0RdPP6 XnwFmTIkSOuv+e++AjYsCBZk7mu537tP/HMFdgGB0+l+CPCUxHvGEJ6/VYAX3x3/k8IU tPWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JotyD3Qtuzk8QZcm87RVQJeRfD10PDp771HanSJw7Xg=; b=KZdgVNjiRl3PsfalLY0Xi784ZkkcYC4wZSmgyZR9fSvE1bwNK91X/ECXB2WrhA9VdS 8lljx0jXCwOCYV/T/ALKQUfvUKOosWeQB7FN+KfWSUMLcuk1UEGbwEx4K2KyCqXof5Yr IGbDWsqQdOlMh3Qkatlt/wA08kcyZ4aRoFHsvUxwkfbncXWmrriGBHEwL3zJpzERQws7 Wgsgw0yCEg0F9PUFfO840mb5KhvhHDkymQ7B+CR56c71n20gUrS9/4W4ZxF+JhbJGBR3 3fQUyTAxhHdhypNZ3sfTZZ+W02boXUFLbc4cYQ3pfCon0kaxWyGZfZuEW9eE4R7PPgFE fC1g== X-Gm-Message-State: AOAM533eD6aFKAm5jKKBUMMggin/rzRRqEEiUWEFhKHM4+kKc+DueFgH mhp6DVNpjGqSLy/Wk9J0430c4Sr2X19nCA== X-Google-Smtp-Source: ABdhPJxtW12sqd7Nx8DbaNaAVpWw1KUhnfjuSStCia0lnsdFLWfQlBbPYZ8rY4BGfSJCwC1EWCpR8Q== X-Received: by 2002:aa7:971d:0:b029:13e:d13d:a08a with SMTP id a29-20020aa7971d0000b029013ed13da08amr19528878pfg.33.1600217207482; Tue, 15 Sep 2020 17:46:47 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id kf10sm611723pjb.2.2020.09.15.17.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:46:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 6/6] target/s390x: Set instance_align on S390CPU TypeInfo Date: Tue, 15 Sep 2020 17:46:38 -0700 Message-Id: <20200916004638.2444147-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org> References: <20200916004638.2444147-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , David Hildenbrand Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fix alignment of CPUS390XState.vregs. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Cornelia Huck Cc: qemu-s390x@nongnu.org --- target/s390x/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index 749cd548f0..e350edc9f5 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu.c @@ -517,6 +517,7 @@ static const TypeInfo s390_cpu_type_info = { .name = TYPE_S390_CPU, .parent = TYPE_CPU, .instance_size = sizeof(S390CPU), + .instance_align = __alignof__(S390CPU), .instance_init = s390_cpu_initfn, .instance_finalize = s390_cpu_finalize, .abstract = true,