From patchwork Wed Nov 8 21:32:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 118353 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5932503qgn; Wed, 8 Nov 2017 16:15:23 -0800 (PST) X-Google-Smtp-Source: ABhQp+Sclo5GmUwy2caqtBWYjF8MfpKBx4T8LegX5T+nZojHpq6qBu/haB73H1LR8xht1LeKcZI8 X-Received: by 10.223.144.227 with SMTP id i90mr1951822wri.190.1510186523053; Wed, 08 Nov 2017 16:15:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510186523; cv=none; d=google.com; s=arc-20160816; b=NKxnDuvaMcg81fQe/U04XsMUgo1Sspkz313p2A5lOrgJhOqaidNdWeiLF4+/LhtqkR HrJ7WN0J/J9LSnIUyxpKyl173g8D4sSv6lCf5qmMbFWErguC8SJ9H7dHa9ke6twmnI2l DnaDUroy7xb7IXqrsc+1fmS9d7B+DW7GaQCT68WYsAgJReq0SkCdzaj3k6gKR++ZTbmH wh//A7fkacLysuCL9I1hR4j7CWpNZefCJrtm9LFz66wvQKhIm/CDQx5uB3gejC3l+hyy EMhkfwBomaGfWyPi2yS9yr+luDy2swiwWvBnpuE560QWc/P+gr4QoP1fGtgwTlCrLev0 wjDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=8VP+FDShGxD9a3zs1vHZs4ang84qbRN4fX2l0mfn+Ms=; b=ymn0HIC/sOAYjsF3hpWGVqR1MEl2GKwgGw6s0DaX9ydzQvqDStEnlDMFuEvg6jhouK s7Xd/ct8n7yHT6RXgePX6q7mvPnnPA2ZE0/phUAXbXEgqCOrMuIRxSdT2ExwRg5RxZnb q6BeE3gVP9zXfHrXCo/doAj2DCnJqk96HSc2hLUJO9FsxitzAwJje62q3Qlu9CL8VWMh jmfY0r33vY3eaLUOP5Q+O5+qSPAQZJQoxGSBS/AT/liVTye0Y9wHi/Fe4YSeOvPNfuVY Y8mtAGElxeHemgU5aFy46ODW9LLz6OqEvkFGF+5z3ynb7JEIZ5AxV7V2qhrZouVKtbwf LlTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hCUEwOTS; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id e187si4489819wma.75.2017.11.08.16.15.22; Wed, 08 Nov 2017 16:15:23 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hCUEwOTS; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C4F0C2679C3; Thu, 9 Nov 2017 01:12:45 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 243F2267669; Wed, 8 Nov 2017 22:38:44 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id D738D2676A5 for ; Wed, 8 Nov 2017 22:33:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=MeUI8sDB8YW0e0e9MZ82xBRkro4e1A85fGIuR2Mtdmg=; b=hCUEwOTSj1Cb vI3LxzERXZCAsKHqpFgd8sWH3aydYcgPw3j3x/0BzlqrPpDNJPRrYx1GgBwxNI0Ce18Sv6kqGFiR+ nDQgd/squi7tvILB/woCsV79r4MTfVGcGeypNR4UYGC1wI2drcw6E4eG0Fmx7sviDqldqdek2QhNe ZOnhA=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eCXxx-0003h3-Kx; Wed, 08 Nov 2017 21:32:57 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1eCXxw-0005Uc-NZ; Wed, 08 Nov 2017 21:32:56 +0000 From: Mark Brown To: Sriram Periyasamy In-Reply-To: <20171107104626.25800-9-guneshwor.o.singh@intel.com> Message-Id: Date: Wed, 08 Nov 2017 21:32:56 +0000 Cc: alsa-devel@alsa-project.org, Takashi Iwai , Guneshwor Singh , Liam Girdwood , Patches Audio , Mark Brown , Vinod Koul Subject: [alsa-devel] Applied "ASoC: Intel: Skylake: Add dynamic module id support" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: Intel: Skylake: Add dynamic module id support has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From d956147473ec1843c2660a89ef0fba80b66c6657 Mon Sep 17 00:00:00 2001 From: Sriram Periyasamy Date: Tue, 7 Nov 2017 16:16:23 +0530 Subject: [PATCH] ASoC: Intel: Skylake: Add dynamic module id support Module id is a property of firmware manifest and can vary between platforms so use the uuid instead of module id for pins. Signed-off-by: Sriram Periyasamy Signed-off-by: Guneshwor Singh Acked-By: Vinod Koul Signed-off-by: Mark Brown --- sound/soc/intel/skylake/skl-topology.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) -- 2.15.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 90f8c839bcef..b590742c5a7a 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -2054,6 +2054,8 @@ static int skl_tplg_fill_pin(struct device *dev, struct skl_module_pin *m_pin, int pin_index) { + int ret; + switch (tkn_elem->token) { case SKL_TKN_U32_PIN_MOD_ID: m_pin[pin_index].id.module_id = tkn_elem->value; @@ -2063,6 +2065,14 @@ static int skl_tplg_fill_pin(struct device *dev, m_pin[pin_index].id.instance_id = tkn_elem->value; break; + case SKL_TKN_UUID: + ret = skl_tplg_get_uuid(dev, m_pin[pin_index].id.mod_uuid.b, + (struct snd_soc_tplg_vendor_uuid_elem *)tkn_elem); + if (ret < 0) + return ret; + + break; + default: dev_err(dev, "%d Not a pin token\n", tkn_elem->token); return -EINVAL; @@ -2487,6 +2497,7 @@ static int skl_tplg_get_token(struct device *dev, case SKL_TKN_U32_PIN_MOD_ID: case SKL_TKN_U32_PIN_INST_ID: + case SKL_TKN_UUID: ret = skl_tplg_fill_pins_info(dev, mconfig, tkn_elem, dir, pin_index); @@ -2549,6 +2560,7 @@ static int skl_tplg_get_tokens(struct device *dev, struct snd_soc_tplg_vendor_value_elem *tkn_elem; int tkn_count = 0, ret; int off = 0, tuple_size = 0; + bool is_module_guid = true; if (block_size <= 0) return -EINVAL; @@ -2564,8 +2576,15 @@ static int skl_tplg_get_tokens(struct device *dev, continue; case SND_SOC_TPLG_TUPLE_TYPE_UUID: - ret = skl_tplg_get_uuid(dev, mconfig->guid, - array->uuid); + if (is_module_guid) { + ret = skl_tplg_get_uuid(dev, mconfig->guid, + array->uuid); + is_module_guid = false; + } else { + ret = skl_tplg_get_token(dev, array->value, skl, + mconfig); + } + if (ret < 0) return ret;