From patchwork Mon Jun 8 16:00:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281163 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE38C433E0 for ; Mon, 8 Jun 2020 16:10:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59B622063A for ; Mon, 8 Jun 2020 16:10:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e8NN9Pp9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B622063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKLn-000069-Cg for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:10:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKDF-00068t-Sn for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26205 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDD-0007cS-RJ for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zOI5VHRwzcrGr66pZ7m4z1ZrN3YJ34eLW3YDU+fnGv0=; b=e8NN9Pp9FL6qNPJlJA+nTvNNKbAd0iIofbDtRX8XTSB4dql4SBLZ+Q5foHJF+VVcdn4mXC bphf0u7jfPDj2DwXZhYk9ut/0k4oYmHMctDVRuBuy6O4k9HJgeBNl6oJSFSnwcVOh15Zmu eUWZpFz4OgBjV/94ct++srHMKxguJhY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-phweewcPMsa0DZJK4HwEXA-1; Mon, 08 Jun 2020 12:01:07 -0400 X-MC-Unique: phweewcPMsa0DZJK4HwEXA-1 Received: by mail-wr1-f70.google.com with SMTP id w16so7325429wru.18 for ; Mon, 08 Jun 2020 09:01:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zOI5VHRwzcrGr66pZ7m4z1ZrN3YJ34eLW3YDU+fnGv0=; b=tA1EcLJ4QKX/6av9vvC/rZsMQzLqhTZBb6U2ViPbb3DVoQKIQbqkGWSxfiTSdoJeWV Gr/a0t20D0SzoxYjkQmzYmi3qrsuCNaRW0dE0lDmb6EytJNyhHIvUAXrcTQD2SteiDiX 5O4cYRNCEFdp9GU/YwUb+CvFuz/jil5PUlRmEmdD4uuuEJzqXg/F/16JaWndWkl3Ob9p IsDjwsr+IKV0HCf1HTXMA9jn7KeaO9cAc+hcrEgl90LDyK5o9JxEC/0qdEEezYkS+xoI LQi6/NlYDJAJhahkdZ23Y+LjKQtSBBIIp0QqkAOuFgJ+45b/k3Q9A9+PFn2cQksjURZT /asg== X-Gm-Message-State: AOAM532PnzsE79LhjjiE5dvLP4qHGQAMPqDNDS9hbAAEoJ/TWbECUivB hDQzsSWw1umnVkZZG60meRwEAvOKJIsPss/VfGjFSQiyyNMSKBOwnfnN0P6wN4ml3ejF/D9WKIZ HSzZY9NtxdMARz1M= X-Received: by 2002:a1c:c3d7:: with SMTP id t206mr32549wmf.69.1591632065215; Mon, 08 Jun 2020 09:01:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziXMXpu2PAmMIx7aoFkuYgVgPaKI7cmN6JuMa+/KlQ6vvO4eQND3agEj8WsVM887NYLfsrYQ== X-Received: by 2002:a1c:c3d7:: with SMTP id t206mr32465wmf.69.1591632064493; Mon, 08 Jun 2020 09:01:04 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id y5sm160041wrs.63.2020.06.08.09.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:01:03 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 03/35] hw/arm/omap: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:12 +0200 Message-Id: <20200608160044.15531-4-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/omap1.c | 6 ++++++ hw/char/omap_uart.c | 5 +++++ hw/misc/omap_gpmc.c | 3 +++ hw/misc/omap_l4.c | 3 +++ hw/misc/omap_sdrc.c | 3 +++ hw/sd/omap_mmc.c | 5 +++++ hw/ssi/omap_spi.c | 3 +++ hw/timer/omap_synctimer.c | 4 ++++ 8 files changed, 32 insertions(+) diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index 761cc17ea9..d7d6253be0 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/omap1.c @@ -40,6 +40,7 @@ #include "hw/sysbus.h" #include "qemu/cutils.h" #include "qemu/bcd.h" +#include "hw/qdev-deprecated.h" static inline void omap_log_badwidth(const char *funcname, hwaddr addr, int sz) { @@ -1451,6 +1452,7 @@ static struct dpll_ctl_s *omap_dpll_init(MemoryRegion *memory, hwaddr base, omap_clk clk) { struct dpll_ctl_s *s = g_malloc0(sizeof(*s)); + qdev_warn_deprecated_function_used(); memory_region_init_io(&s->iomem, NULL, &omap_dpll_ops, s, "omap-dpll", 0x100); s->dpll = clk; @@ -2427,6 +2429,8 @@ static struct omap_pwl_s *omap_pwl_init(MemoryRegion *system_memory, { struct omap_pwl_s *s = g_malloc0(sizeof(*s)); + qdev_warn_deprecated_function_used(); + omap_pwl_reset(s); memory_region_init_io(&s->iomem, NULL, &omap_pwl_ops, s, @@ -2534,6 +2538,8 @@ static struct omap_pwt_s *omap_pwt_init(MemoryRegion *system_memory, omap_clk clk) { struct omap_pwt_s *s = g_malloc0(sizeof(*s)); + + qdev_warn_deprecated_function_used(); s->clk = clk; omap_pwt_reset(s); diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c index e8da933378..7e106772ce 100644 --- a/hw/char/omap_uart.c +++ b/hw/char/omap_uart.c @@ -22,6 +22,7 @@ #include "hw/arm/omap.h" #include "hw/char/serial.h" #include "exec/address-spaces.h" +#include "hw/qdev-deprecated.h" /* UARTs */ struct omap_uart_s { @@ -57,6 +58,8 @@ struct omap_uart_s *omap_uart_init(hwaddr base, { struct omap_uart_s *s = g_new0(struct omap_uart_s, 1); + qdev_warn_deprecated_function_used(); + s->base = base; s->fclk = fclk; s->irq = irq; @@ -168,6 +171,8 @@ struct omap_uart_s *omap2_uart_init(MemoryRegion *sysmem, struct omap_uart_s *s = omap_uart_init(base, irq, fclk, iclk, txdma, rxdma, label, chr); + qdev_warn_deprecated_function_used(); + memory_region_init_io(&s->iomem, NULL, &omap_uart_ops, s, "omap.uart", 0x100); s->ta = ta; diff --git a/hw/misc/omap_gpmc.c b/hw/misc/omap_gpmc.c index 10de7a5523..9e29d7a8bd 100644 --- a/hw/misc/omap_gpmc.c +++ b/hw/misc/omap_gpmc.c @@ -25,6 +25,7 @@ #include "hw/arm/omap.h" #include "exec/memory.h" #include "exec/address-spaces.h" +#include "hw/qdev-deprecated.h" /* General-Purpose Memory Controller */ struct omap_gpmc_s { @@ -830,6 +831,8 @@ struct omap_gpmc_s *omap_gpmc_init(struct omap_mpu_state_s *mpu, int cs; struct omap_gpmc_s *s = g_new0(struct omap_gpmc_s, 1); + qdev_warn_deprecated_function_used(); + memory_region_init_io(&s->iomem, NULL, &omap_gpmc_ops, s, "omap-gpmc", 0x1000); memory_region_add_subregion(get_system_memory(), base, &s->iomem); diff --git a/hw/misc/omap_l4.c b/hw/misc/omap_l4.c index 54aeaecd69..b412790c19 100644 --- a/hw/misc/omap_l4.c +++ b/hw/misc/omap_l4.c @@ -19,6 +19,7 @@ */ #include "qemu/osdep.h" #include "hw/arm/omap.h" +#include "hw/qdev-deprecated.h" struct omap_l4_s { MemoryRegion *address_space; @@ -33,6 +34,8 @@ struct omap_l4_s *omap_l4_init(MemoryRegion *address_space, struct omap_l4_s *bus = g_malloc0( sizeof(*bus) + ta_num * sizeof(*bus->ta)); + qdev_warn_deprecated_function_used(); + bus->address_space = address_space; bus->ta_num = ta_num; bus->base = base; diff --git a/hw/misc/omap_sdrc.c b/hw/misc/omap_sdrc.c index f2f72f6810..4f8440ea56 100644 --- a/hw/misc/omap_sdrc.c +++ b/hw/misc/omap_sdrc.c @@ -19,6 +19,7 @@ */ #include "qemu/osdep.h" #include "hw/arm/omap.h" +#include "hw/qdev-deprecated.h" /* SDRAM Controller Subsystem */ struct omap_sdrc_s { @@ -159,6 +160,8 @@ struct omap_sdrc_s *omap_sdrc_init(MemoryRegion *sysmem, { struct omap_sdrc_s *s = g_new0(struct omap_sdrc_s, 1); + qdev_warn_deprecated_function_used(); + omap_sdrc_reset(s); memory_region_init_io(&s->iomem, NULL, &omap_sdrc_ops, s, "omap.sdrc", 0x1000); diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c index 4088a8a80b..88fd20e17a 100644 --- a/hw/sd/omap_mmc.c +++ b/hw/sd/omap_mmc.c @@ -24,6 +24,7 @@ #include "hw/irq.h" #include "hw/arm/omap.h" #include "hw/sd/sd.h" +#include "hw/qdev-deprecated.h" struct omap_mmc_s { qemu_irq irq; @@ -599,6 +600,8 @@ struct omap_mmc_s *omap_mmc_init(hwaddr base, { struct omap_mmc_s *s = g_new0(struct omap_mmc_s, 1); + qdev_warn_deprecated_function_used(); + s->irq = irq; s->dma = dma; s->clk = clk; @@ -625,6 +628,8 @@ struct omap_mmc_s *omap2_mmc_init(struct omap_target_agent_s *ta, { struct omap_mmc_s *s = g_new0(struct omap_mmc_s, 1); + qdev_warn_deprecated_function_used(); + s->irq = irq; s->dma = dma; s->clk = fclk; diff --git a/hw/ssi/omap_spi.c b/hw/ssi/omap_spi.c index 7c7e689707..276f963ae2 100644 --- a/hw/ssi/omap_spi.c +++ b/hw/ssi/omap_spi.c @@ -25,6 +25,7 @@ #include "hw/hw.h" #include "hw/irq.h" #include "hw/arm/omap.h" +#include "hw/qdev-deprecated.h" /* Multichannel SPI */ struct omap_mcspi_s { @@ -353,6 +354,8 @@ struct omap_mcspi_s *omap_mcspi_init(struct omap_target_agent_s *ta, int chnum, struct omap_mcspi_s *s = g_new0(struct omap_mcspi_s, 1); struct omap_mcspi_ch_s *ch = s->ch; + qdev_warn_deprecated_function_used(); + s->irq = irq; s->chnum = chnum; while (chnum --) { diff --git a/hw/timer/omap_synctimer.c b/hw/timer/omap_synctimer.c index 72b997939b..4be24e970e 100644 --- a/hw/timer/omap_synctimer.c +++ b/hw/timer/omap_synctimer.c @@ -20,6 +20,8 @@ #include "qemu/osdep.h" #include "qemu/timer.h" #include "hw/arm/omap.h" +#include "hw/qdev-deprecated.h" + struct omap_synctimer_s { MemoryRegion iomem; uint32_t val; @@ -101,6 +103,8 @@ struct omap_synctimer_s *omap_synctimer_init(struct omap_target_agent_s *ta, { struct omap_synctimer_s *s = g_malloc0(sizeof(*s)); + qdev_warn_deprecated_function_used(); + omap_synctimer_reset(s); memory_region_init_io(&s->iomem, NULL, &omap_synctimer_ops, s, "omap.synctimer", omap_l4_region_size(ta, 0)); From patchwork Mon Jun 8 16:00:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281162 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B82C433E0 for ; Mon, 8 Jun 2020 16:13:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 509AB2063A for ; Mon, 8 Jun 2020 16:13:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O2MGImje" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 509AB2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKOs-0004T2-Ij for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:13:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKDt-0006a3-Hp for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:06 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:46263 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDs-0007nk-LX for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O7Ly94SWL+SMdJ3uuRJWrIP/iOhgME/DwBVu03IUalo=; b=O2MGImjetCECL2wa5Ku6+hnAon5vqvZVJiWJtvQvQndbqtu1eve1uSgbc2YvuKeJ8QFLaZ eEYYHC8dEeeWYfqwrbwm2Q0Can2GKhL7CbN6BSc5mQ4m+qF08lFA5+JVD/HMNxFdujQFeX 7OUT0+aUM3dGPBSNzjqZInXW9lfQ1R4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-AMnnR6waPGu6eYyo5BR4YQ-1; Mon, 08 Jun 2020 12:01:13 -0400 X-MC-Unique: AMnnR6waPGu6eYyo5BR4YQ-1 Received: by mail-wm1-f70.google.com with SMTP id t145so10272wmt.2 for ; Mon, 08 Jun 2020 09:01:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O7Ly94SWL+SMdJ3uuRJWrIP/iOhgME/DwBVu03IUalo=; b=PBj+qbZu5LbUfs3cDa46aKuWChuVFyeDwlyGdOOaIpF9xFEMN16R7ZxNvivkP5+U4L Wet/ephx5qMtBKI5VujqmYs+GTbpvaEQIgydsJxMToYJ82qo0LcPMdawTzHLGTpapFDE 1Nrd+n6Z9WoSb/eRgi5gobqSU/AnEwoFYzCFhSXvh75MnDuC4PcD3hMrr+htT66Nv+Sg jU5hRloyxudlaGtZKBYFSXghvBTV7BydOuvVfWmfrrDbohthgZEkcoHvjwdxKhCVt5V6 8YYZLTkoMvbsdegQsqyYfEX8j4qJkHhBx2FZcrLaFqCPfn1S1jJrEt6aN+tHefua27kS gTmw== X-Gm-Message-State: AOAM530Wr3lxOkFWOjHVyXBIXAgVAixvY93ttGSw9/solm7U4/804oII A7A1fvCXViXHJ+R4oGKE9oJU7QySZdCKwDMqzmpKPSS7m/wHBRhbf+RngLMxxwDIgpuhCDrkzGH xBjRQ5SJouPHmrP0= X-Received: by 2002:a5d:6acf:: with SMTP id u15mr25749806wrw.277.1591632070235; Mon, 08 Jun 2020 09:01:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcPzEmUfH07HRp9H1Y3tf4BoKsOaXn7cpLkhpXaJ1S6O0iNu0DeeV5KKJL41RODtirsARieQ== X-Received: by 2002:a5d:6acf:: with SMTP id u15mr25749771wrw.277.1591632069976; Mon, 08 Jun 2020 09:01:09 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id e12sm163622wro.52.2020.06.08.09.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:01:09 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 04/35] hw/arm/pxa2xx: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:13 +0200 Message-Id: <20200608160044.15531-5-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 11:58:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/pxa2xx.c | 3 +++ hw/display/pxa2xx_lcd.c | 3 +++ hw/input/pxa2xx_keypad.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index e649f8930c..483003d161 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx.c @@ -27,6 +27,7 @@ #include "sysemu/qtest.h" #include "qemu/cutils.h" #include "qemu/log.h" +#include "hw/qdev-deprecated.h" static struct { hwaddr io_base; @@ -1768,6 +1769,8 @@ static PXA2xxI2SState *pxa2xx_i2s_init(MemoryRegion *sysmem, { PXA2xxI2SState *s = g_new0(PXA2xxI2SState, 1); + qdev_warn_deprecated_function_used(); + s->irq = irq; s->rx_dma = rx_dma; s->tx_dma = tx_dma; diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c index ff90104b80..cf6241ff21 100644 --- a/hw/display/pxa2xx_lcd.c +++ b/hw/display/pxa2xx_lcd.c @@ -20,6 +20,7 @@ /* FIXME: For graphic_rotate. Should probably be done in common code. */ #include "sysemu/sysemu.h" #include "framebuffer.h" +#include "hw/qdev-deprecated.h" struct DMAChannel { uint32_t branch; @@ -1011,6 +1012,8 @@ PXA2xxLCDState *pxa2xx_lcdc_init(MemoryRegion *sysmem, PXA2xxLCDState *s; DisplaySurface *surface; + qdev_warn_deprecated_function_used(); + s = (PXA2xxLCDState *) g_malloc0(sizeof(PXA2xxLCDState)); s->invalidated = 1; s->irq = irq; diff --git a/hw/input/pxa2xx_keypad.c b/hw/input/pxa2xx_keypad.c index 62aa6f6b15..6de1e9e4bb 100644 --- a/hw/input/pxa2xx_keypad.c +++ b/hw/input/pxa2xx_keypad.c @@ -17,6 +17,7 @@ #include "migration/vmstate.h" #include "hw/arm/pxa.h" #include "ui/console.h" +#include "hw/qdev-deprecated.h" /* * Keypad @@ -316,6 +317,8 @@ PXA2xxKeyPadState *pxa27x_keypad_init(MemoryRegion *sysmem, { PXA2xxKeyPadState *s; + qdev_warn_deprecated_function_used(); + s = (PXA2xxKeyPadState *) g_malloc0(sizeof(PXA2xxKeyPadState)); s->irq = irq; From patchwork Mon Jun 8 16:00:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281165 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2744BC433DF for ; Mon, 8 Jun 2020 16:08:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4F8F2063A for ; Mon, 8 Jun 2020 16:08:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VKIs+Ujf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4F8F2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKJe-0004Xb-45 for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:08:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKDK-0006AS-Tk for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:31 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:29488 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDK-0007gE-1P for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NJCGR9/510Qhv58TRWbd4o5i6q1ayDSJg7ikac3wKxM=; b=VKIs+UjfJm3kRNg9BA9niRSVHPEdIKa1+bwnKW5BjyDTboaKQ42ea+2FgNs020KzZVXf9w Btmz5toYaTDlsfFuIC6PqI0UF52hqtlKgeMm5e43dsG6b9cZKuO8VfsMBjSHeBY949MRb0 +ZT1zZQ+NbCZvbv2a3d6+oX/YnYs02Y= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-RSy3lLSiMqG56FXJb_XKvw-1; Mon, 08 Jun 2020 12:01:22 -0400 X-MC-Unique: RSy3lLSiMqG56FXJb_XKvw-1 Received: by mail-wr1-f69.google.com with SMTP id a4so7337980wrp.5 for ; Mon, 08 Jun 2020 09:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NJCGR9/510Qhv58TRWbd4o5i6q1ayDSJg7ikac3wKxM=; b=eoIpPl/755+305v+Jrl/2o7sy3eqL06002he4Bm4ERdvq+0RqCnx9gf7x5uB36DjdP +KQniuCaLkU7laHOpjeY/oD/lw6bPjP/w8i0qdiinLM7XGUSTAaarThAWOhxgpOfGkpz sDDnOXMVfSle6QcatzZne4xRGBTD8rQdwSuJS3QYXdGsj+fhLrbVQi4hgSx5HdG/G/tz ChrA8M4Mtt4ahtMiNACs6dzoMhGwds6OcQGs/J5+iRlWL5MMkpT4kayKjZFqz+kTVsWB xDap3Bt5ms0QcN+h7m1TzgljY1IMJ40XvsWA/bQudOMy8aIi2FY6yyUA9gSRj/cuX6s8 OpOg== X-Gm-Message-State: AOAM530xdZDlxZVSCc1ofhRsg0RtSOJBz+3nHwKHPoGExEAkzfRV8rDG sxGlFNgMapMqB/jAFr/9aIp7HNTV5pE3Geaq/9jbw3zsLEfCJQVhX01Rm2Zpf1H2GJAHuwR4Og3 aP1Evd2V5MDJ+Vfo= X-Received: by 2002:a1c:6884:: with SMTP id d126mr21811wmc.121.1591632081534; Mon, 08 Jun 2020 09:01:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOzP/TSo/GdCDA4q3fBC5fMN7fhQwZz7nfPzYVtVlA4zhoIpThGRIoQT2iemjQz07LOwJssw== X-Received: by 2002:a1c:6884:: with SMTP id d126mr21765wmc.121.1591632081336; Mon, 08 Jun 2020 09:01:21 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id g25sm25750wmh.18.2020.06.08.09.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:01:20 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 06/35] hw/timer/arm_timer: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:15 +0200 Message-Id: <20200608160044.15531-7-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/arm_timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c index 9607366d78..e23e6b4b31 100644 --- a/hw/timer/arm_timer.c +++ b/hw/timer/arm_timer.c @@ -16,6 +16,7 @@ #include "hw/qdev-properties.h" #include "qemu/module.h" #include "qemu/log.h" +#include "hw/qdev-deprecated.h" /* Common timer implementation. */ @@ -175,6 +176,8 @@ static arm_timer_state *arm_timer_init(uint32_t freq) { arm_timer_state *s; + qdev_warn_deprecated_function_used(); + s = (arm_timer_state *)g_malloc0(sizeof(arm_timer_state)); s->freq = freq; s->control = TIMER_CTRL_IE; From patchwork Mon Jun 8 16:00:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281164 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC61C433E0 for ; Mon, 8 Jun 2020 16:10:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 098472063A for ; Mon, 8 Jun 2020 16:10:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KuLTfay+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 098472063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKLa-0008Lo-67 for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:10:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKDM-0006BW-Oh for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:33 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:51270 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDK-0007gU-OI for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P++PpnzVmXXtn3Xqf4XIHbmL4uqsh2R3Dd1pfn2k/GY=; b=KuLTfay+BjUA9tm25il0dVm1obY2X+WoFOeRz4dL/tw/N+nLrrfdHiWh0+RHp5r+xgIJIt zdtGAp8UaVSWVevhmHB3N3V21ASJGWIo2xTXpmmGljkthpWIra3S/Wvh34rygklxtq2hS3 MmbgampXCMaaOT/W60SmlaHJTIwg9HY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-Ra9YO6-CPda8hilkVXDkaw-1; Mon, 08 Jun 2020 12:01:28 -0400 X-MC-Unique: Ra9YO6-CPda8hilkVXDkaw-1 Received: by mail-wr1-f72.google.com with SMTP id l18so7395750wrm.0 for ; Mon, 08 Jun 2020 09:01:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P++PpnzVmXXtn3Xqf4XIHbmL4uqsh2R3Dd1pfn2k/GY=; b=IAjNr0lSOOA3hs4Ek1UKHqcaXUml7/xOmq5RYWKLJXdqRpChE+2YyIJkeJuH9OPKlr G/R5oxqNntJ469a9lvJ1lxJmfe97yRNfAXKbv+xE9K2DlfWyJ8ekpeuk9mGSH9mS+Mmx gFWsCPPYrA3FIfasoyTWoFhOlUaI/Ygm7XKstlf66IeCb22ibsfHtWnfIwzcj4MNHJNU wiGfDy5/FzKDv5Nj73dLpS5F74Gaq9KHG7ls4S/PKhhiofbCQfnZqb1NZ859epYtbkqn D1QOy2In3GVLXy36EsJ1WbfGLfkvfXAFjOTRJByGMC2snR5zuvGmAEBFXiUfurUp7reZ f4+Q== X-Gm-Message-State: AOAM531as60Nj6cuPFXkW3R+pbXuWQf+8IoA1YUNYQ5U/+PTrlvA2RQC JRAiv/vCf62kFirXbaK5E2jdFRfDR7b2d1FQHnnUGVSYWNHM8Qd+CJP19P+KshjnF9cQx0AABhh BSvr+Alg01qEImYw= X-Received: by 2002:a1c:f007:: with SMTP id a7mr27131wmb.103.1591632087257; Mon, 08 Jun 2020 09:01:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzi6QGEqKJNT1xfJrXVN1hFb5ZVsGqmEk2sV/P9tBTDLMUlN7hRgEWpk7m+66ilMFrnYarGkA== X-Received: by 2002:a1c:f007:: with SMTP id a7mr27088wmb.103.1591632086930; Mon, 08 Jun 2020 09:01:26 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id o9sm7066wmh.37.2020.06.08.09.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:01:26 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 07/35] hw/char/parallel: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:16 +0200 Message-Id: <20200608160044.15531-8-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/parallel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index 8dd67d1375..0ee577d420 100644 --- a/hw/char/parallel.c +++ b/hw/char/parallel.c @@ -35,6 +35,7 @@ #include "hw/char/parallel.h" #include "sysemu/reset.h" #include "sysemu/sysemu.h" +#include "hw/qdev-deprecated.h" #include "trace.h" //#define DEBUG_PARALLEL @@ -601,6 +602,8 @@ bool parallel_mm_init(MemoryRegion *address_space, { ParallelState *s; + qdev_warn_deprecated_function_used(); + s = g_malloc0(sizeof(ParallelState)); s->irq = irq; qemu_chr_fe_init(&s->chr, chr, &error_abort); From patchwork Mon Jun 8 16:00:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281161 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1685C433DF for ; Mon, 8 Jun 2020 16:14:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70C9E2063A for ; Mon, 8 Jun 2020 16:14:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZkgYPioN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70C9E2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKQB-0006s6-Mm for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:14:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKDe-0006S3-LP for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:50 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:59293 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDd-0007kD-JU for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:01:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wevOFGWECaRJOmLpbzON6N0ynWLO2tBiVdtI/WyaADw=; b=ZkgYPioNqbB2H3q9BclTdSGCuapWWTIvuRvce2hNM9VzXK3CSzBw9oZfBEFcBIJyA651sG QOzkdpTp1s64cq+5k2A0b/PeEW4rR965c65qETD47P55JDLzdiAq9DZY/m4SeOTJUAYHWU fHxOjhxf28+LFdcrywXEKfqfJN01Ei0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-l53goxRrOLiIZvflQ7qcwA-1; Mon, 08 Jun 2020 12:01:44 -0400 X-MC-Unique: l53goxRrOLiIZvflQ7qcwA-1 Received: by mail-wr1-f71.google.com with SMTP id a4so7338568wrp.5 for ; Mon, 08 Jun 2020 09:01:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wevOFGWECaRJOmLpbzON6N0ynWLO2tBiVdtI/WyaADw=; b=fdTgTYD/Eq/KwykbmZhnGT9dmMOQqDKUGt9Gp/zSiy6N/L5fO6HoM75YuNouxInciv SdfgrmxmIgKGiyBsCWWDEO8tuWrKEkY2FWRS+yl/0ynqCo39uEAh5+yT1FDRSuAchf+Y ugbStClFisTRcvF3Av7aR4yX8rQaL1eNJBRacDonijpW/gbdckkggWEpanH3xa6OxUaN 6aWa6QfHagpOaJTs+blj/8j8CzCtFGfoyZcR1QcQPSznYQ4/ng0EKrxdx0Y8Kwo8OQP7 aq98LAlW9dKRtwy4BIMNo5NSLXdUwgNcoeUg/+T0gdl+pKoQpMtBWHXfup5MsZ4T38wq GiUw== X-Gm-Message-State: AOAM531LZ8HCHgWnDzRGPagcGyy0u4Y1kDQKLihPIwGCVNXIE0oCa7dy AlyfuD2M6jGFbG9peXxmGijy8CorWc6HaXMZM+abyBiqepstRJdO8fMigPt4xvDPCSKhXhFTqY7 qXyHlHkNjlpeUgn4= X-Received: by 2002:adf:fd81:: with SMTP id d1mr24815733wrr.96.1591632103560; Mon, 08 Jun 2020 09:01:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgYI93lvZ2rTNUf8uc34cwDYk4WA9pXLtkl6aiMXyXdGzMVgF1rzOkVGZM3nz7yDUz0VO1vA== X-Received: by 2002:adf:fd81:: with SMTP id d1mr24815694wrr.96.1591632103352; Mon, 08 Jun 2020 09:01:43 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id b185sm342940wmd.3.2020.06.08.09.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:01:42 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 10/35] hw/display/tc6393xb: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:19 +0200 Message-Id: <20200608160044.15531-11-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 11:58:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/tc6393xb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/tc6393xb.c b/hw/display/tc6393xb.c index 49a676d1b0..e4900e9502 100644 --- a/hw/display/tc6393xb.c +++ b/hw/display/tc6393xb.c @@ -21,6 +21,7 @@ #include "ui/console.h" #include "ui/pixel_ops.h" #include "sysemu/blockdev.h" +#include "hw/qdev-deprecated.h" #define IRQ_TC6393_NAND 0 #define IRQ_TC6393_MMC 1 @@ -556,6 +557,8 @@ TC6393xbState *tc6393xb_init(MemoryRegion *sysmem, uint32_t base, qemu_irq irq) }, }; + qdev_warn_deprecated_function_used(); + s = (TC6393xbState *) g_malloc0(sizeof(TC6393xbState)); s->irq = irq; s->gpio_in = qemu_allocate_irqs(tc6393xb_gpio_set, s, TC6393XB_GPIOS); From patchwork Mon Jun 8 16:00:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281159 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32C3C433E0 for ; Mon, 8 Jun 2020 16:17:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D1A12076C for ; Mon, 8 Jun 2020 16:17:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h6LQ3rgf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D1A12076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKT1-0002lG-HK for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:17:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKDr-0006Zk-NZ for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:06 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:24390 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDq-0007nR-Gh for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHbfMTMnP0pPoIUOMaNBIF3qcn8JPSW/pdevUa2NjDA=; b=h6LQ3rgftXK74UFOcbctEct2xp5FNtSv/KnVUtVSEGcvV5XNl2Y6Q6CYbdTXRookAQqCj+ 3LGLtSZgfyBntliMakhrX2I+P1b3+adr+HeRc2QF1kdYfin3lsOMczbFk6kIhqLepvCRDX ygEqM83SjI9i9UKYhVmzwWNid7+2SLU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-9mLKbO7oPKmiHd33ImqHBg-1; Mon, 08 Jun 2020 12:01:56 -0400 X-MC-Unique: 9mLKbO7oPKmiHd33ImqHBg-1 Received: by mail-wm1-f72.google.com with SMTP id a7so10823wmf.1 for ; Mon, 08 Jun 2020 09:01:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uHbfMTMnP0pPoIUOMaNBIF3qcn8JPSW/pdevUa2NjDA=; b=nLngPK9DLgWiRNGv/qJUlVld6Z3WHLShNpyWVBAu4Bohg6oZUZ7HEwmdC+id5msQFQ HFrT9rkBGkF61QRALiZJhvzU5f1SRngnJgukXxis+M8EpI6a08gAhODvkwickklrn4tL xeUSqT1qxgsVyzTmVBFr5y90Yy8TjcJwmR3YUL1KdpZMI/PmUX3slyEL7v+mXSXNj9KV ANO8KKM6UhpZ3DwXdidBXRPLlB/uDaXpiVL7l/TuBmkJ4zGINTXSKJZV0BmcadK0UIP5 +znGUBYcHz3AEw25KNyhZ9yNWF30agUdqWEpWtdNSQqMg7G0qmHzR1ywSM5a34xCV6kA h90Q== X-Gm-Message-State: AOAM532icxvRYcwkkkt1l766mGEhWOmbtcm1u67t65N3dHoqtO4LDdx9 dEGqWkAa9/fJc23FbUL4Ekha6fzXHVrbWvPyFYx6wzoEjrZopIfApbYNNwk2H7rGNlhs8e6moHg xu0c1/7mMJssiF5E= X-Received: by 2002:a05:6000:4c:: with SMTP id k12mr23864567wrx.215.1591632114952; Mon, 08 Jun 2020 09:01:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjnqOGBWofUhF/g/CPg0SMkJ8njA1iKr2pcTJ7xpwajdAOHpMg7tlHe1H6wlLAySWDO/5VvQ== X-Received: by 2002:a05:6000:4c:: with SMTP id k12mr23864524wrx.215.1591632114766; Mon, 08 Jun 2020 09:01:54 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id y17sm194731wrn.12.2020.06.08.09.01.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:01:54 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 12/35] hw/dma/etraxfs_dma: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:21 +0200 Message-Id: <20200608160044.15531-13-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 11:58:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/etraxfs_dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c index c4334e87bf..d2f7e7ca9d 100644 --- a/hw/dma/etraxfs_dma.c +++ b/hw/dma/etraxfs_dma.c @@ -28,7 +28,7 @@ #include "qemu/main-loop.h" #include "sysemu/runstate.h" #include "exec/address-spaces.h" - +#include "hw/qdev-deprecated.h" #include "hw/cris/etraxfs_dma.h" #define D(x) @@ -765,6 +765,8 @@ void *etraxfs_dmac_init(hwaddr base, int nr_channels) { struct fs_dma_ctrl *ctrl = NULL; + qdev_warn_deprecated_function_used(); + ctrl = g_malloc0(sizeof *ctrl); ctrl->bh = qemu_bh_new(DMA_run, ctrl); From patchwork Mon Jun 8 16:00:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281160 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F128C433DF for ; Mon, 8 Jun 2020 16:16:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9B30206D5 for ; Mon, 8 Jun 2020 16:16:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I9Bg3SGt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9B30206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKRl-0000RH-0t for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:16:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKE1-0006eZ-DJ for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:13 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:59468 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDz-0007pp-5i for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=swd27F6/1+WGmnfSzwg22l5POZg58LkwHV81fIkNGaQ=; b=I9Bg3SGt6fJjBznCJnmuebKOkfIsY+xlTIuinUP+CFUiZCoimp3HLWGwCowrVMhwRjYP4+ P4k/BUr3gzilwB8U0T/ALs5lFgCqzsFN8qPpWhQnu+uD8d7p+TDBc7YqUP5NFoJQbqPFMT siLHs1ld5R9z1vY/Nc2gWiJfZum9Ekg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-wuIVBMqsOeyjKpz0UZ2BPA-1; Mon, 08 Jun 2020 12:02:08 -0400 X-MC-Unique: wuIVBMqsOeyjKpz0UZ2BPA-1 Received: by mail-wr1-f72.google.com with SMTP id p10so7360003wrn.19 for ; Mon, 08 Jun 2020 09:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=swd27F6/1+WGmnfSzwg22l5POZg58LkwHV81fIkNGaQ=; b=slIgrvmEY1ZlbOMTG6fp4DMYXNUfDebd8TpviELhGesxjTXUFy90SzqYM6/jM4zjnD 0/i0Yo498U6290jm8+U0TYLOVRf/DGCwWrXWOofHU0n5ByNC4qHqTXavIZU/u6R7joFF eKrxAT4pb2cJ5JGMyvxi5TEf2EWHz8IgIBlv9ZErZUWmhBEXFMEhhghoOcZkhXBhOmfz PAmRjENC2SioDdvUYiJo8YlxWF8dFEsBI6UJ9nfDaYNlMNpIbzQ8Z+BW3JpfSMbV+dL3 5cshYJ8AoA3Ckl6Iw/WaDdfqXkR4p5lvLyaYG1GJDAUJJBfZagw7mlzbsnfMi8Up51UJ lKSA== X-Gm-Message-State: AOAM533J1nxRhAuMcKNIOtHN9mPHMdAJ+dT4kN1wkDvN2wPtspyBGstb pjHOUTK2wyLZ4JQ904XUgelAX2JaYo97QnHlEX9LfvybzZhlkcwt8QCUQ3Cr1HxxaputLH1Is+q 35r/Cdd2TNNnNhgo= X-Received: by 2002:a1c:cc0d:: with SMTP id h13mr58677wmb.168.1591632126779; Mon, 08 Jun 2020 09:02:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD9AlGEl1YrzMFzzhVE1vb4kbCf4YFVdSir7m67DLKARx2zMO0OlXdHqSCrgQOgDPIF6US1w== X-Received: by 2002:a1c:cc0d:: with SMTP id h13mr58578wmb.168.1591632126013; Mon, 08 Jun 2020 09:02:06 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id z206sm13115wmg.30.2020.06.08.09.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:02:05 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:23 +0200 Message-Id: <20200608160044.15531-15-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2128f3d6fe..c71809fd28 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -94,6 +94,7 @@ #include "vmport.h" #include "fw_cfg.h" #include "trace.h" +#include "hw/qdev-deprecated.h" GlobalProperty pc_compat_5_0[] = {}; const size_t pc_compat_5_0_len = G_N_ELEMENTS(pc_compat_5_0); @@ -348,6 +349,8 @@ GSIState *pc_gsi_create(qemu_irq **irqs, bool pci_enabled) { GSIState *s; + qdev_warn_deprecated_function_used(); + s = g_new0(GSIState, 1); if (kvm_ioapic_in_kernel()) { kvm_pc_setup_irq_routing(pci_enabled); From patchwork Mon Jun 8 16:00:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D7AC433DF for ; Mon, 8 Jun 2020 16:24:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEEEA206C3 for ; Mon, 8 Jun 2020 16:24:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fefb/B0s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEEEA206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKZT-0002zR-Ug for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:24:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKEL-0006w1-A3 for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:34 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:36927 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKE5-0007qh-T6 for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOyQYXnEE/P1L9M062K4OG7LDuRa+UfsKXeI8IczatQ=; b=fefb/B0sEevutDY78MH/2UWOO1i+K3MTugRIojbNgaC0LB3ka6Od5kXlv2cFhVWzBordYC eAm5dOgPRh237pcCnOZMDQeM0dkczuLjQDMKXws10lrLJp31LXmSOhbVNmZM8LSWXBZy7Q ShFTX6ewNBX5+gNJpFhxAGvcnhBJ+Ho= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-CcIC-PgXP22I27Rq6q2scA-1; Mon, 08 Jun 2020 12:02:13 -0400 X-MC-Unique: CcIC-PgXP22I27Rq6q2scA-1 Received: by mail-wr1-f71.google.com with SMTP id s7so7360307wrm.16 for ; Mon, 08 Jun 2020 09:02:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jOyQYXnEE/P1L9M062K4OG7LDuRa+UfsKXeI8IczatQ=; b=pf2LwqBEndtHQoM9qUNIURk8XwYU8Or9FkAeR0a5WzV+1llADlFXdM3cgrzY6xecIN clWEZcu0/Z2pyBeDQ3iwlM5pXgaUdjR0f+bOYdwREpaBrNzsdbXwzonoKFOpLbWDFFdc XMDxZSvEmERYvANUf71E29vlMKU4L6/pL2SGEoothWCZJ2Evh3G2crLGHO3zMI5A3aIH qMfFcwvF1XxLRE55+EhDNO05GLZ7sbi/5Re8Sijn5/l20WtyLiAHGuuDtX9uG8K8VLa/ MWb95aveXRj4C6l795eiHhZ7Arw8aZ5SbGEZ7LHNXsmyOR7JNZh+dPu8F2j62s+nuWdr 6XUg== X-Gm-Message-State: AOAM531+L+PrsRiStmL8dq3F6QRB5jRfz0J77TJQDHLS01bdLyHAHjuJ P9mmXAb0f7PhGTii2voSGTtU8aM6wMsQ4AZUz7jgtSX/q4MEoaP+n55he4LWLlwcwGpgQcE0zgs aS/QYiBi1VrLPHkw= X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr82490wmm.18.1591632132283; Mon, 08 Jun 2020 09:02:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvLE6gRX7XM83bmbZu8lLW6Zr2jKGWG6aII1A2AXMFr5e4D5cYkpsPFEEPHv3ro5n12uF+eA== X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr82438wmm.18.1591632132052; Mon, 08 Jun 2020 09:02:12 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id z25sm31297wmf.10.2020.06.08.09.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:02:11 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:24 +0200 Message-Id: <20200608160044.15531-16-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/xen/xen-hvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 82ece6b9e7..a1163b1529 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -31,7 +31,7 @@ #include "sysemu/xen-mapcache.h" #include "trace.h" #include "exec/address-spaces.h" - +#include "hw/qdev-deprecated.h" #include #include @@ -1401,6 +1401,8 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) xen_pfn_t ioreq_pfn; XenIOState *state; + qdev_warn_deprecated_function_used(); + state = g_malloc0(sizeof (XenIOState)); state->xce_handle = xenevtchn_open(NULL, 0); From patchwork Mon Jun 8 16:00:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281157 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993E1C433E0 for ; Mon, 8 Jun 2020 16:21:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EFFD206C3 for ; Mon, 8 Jun 2020 16:21:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hzzu0cCg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EFFD206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKWN-00072w-DV for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:21:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKEA-0006ma-Oh for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:22 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:28558 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKE9-0007rV-Vl for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g5ly0fcUXOf9qpye/9fR2nyQtN4aqsUxjucs8EhlOCo=; b=Hzzu0cCgoF/w4uG0tXT374zYmOj8VqoISaXtRQx6han4YxS3p5IVqB02JsKJtYLp3PV6Eh jCzJdSMXMHSViecaKcjWiuv0J0IzHdo4lJTsRRcVFCPavSI9p0988T4rwwNxmtqe4hx2YM hgSTKgVzRJe+HJpW7rQWQwmt16Z36/M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246--WcrLx1xOo6Ztsj87HqAmg-1; Mon, 08 Jun 2020 12:02:19 -0400 X-MC-Unique: -WcrLx1xOo6Ztsj87HqAmg-1 Received: by mail-wm1-f71.google.com with SMTP id x6so4102wmj.9 for ; Mon, 08 Jun 2020 09:02:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g5ly0fcUXOf9qpye/9fR2nyQtN4aqsUxjucs8EhlOCo=; b=rInzN7FJUCbz2YUPLfv9ajZ2/Spl20DNdmi/DCpjLLozMiuhJ3VMQZQdD31TRO1e9j vJPt5D5Xj/P2+QpwLab3LGazCghakpSrJonDqJjdvGOG5aLwYlD2s2+JXCT6fDv+1aa+ aRSrtjGJXeCyEK54accBIpkDWDI4O4Ah7MYbOmI8LEMzruUkmpsl49DPDTMmQyWsZYTv 8U4BNB47R2kNZUljdvWtOWnTpzJfDKbZTXhU7lcXliof+uU0WJwL9FI8so6fNL3R/jOI YSKfPnoMuoGezRlXKubd1P6stc8KYHcF7MX2LU92q6obimJvbbH/xv1Y0GLEv1yRFFrZ 4pUg== X-Gm-Message-State: AOAM531jI373m8iFV8GVsL8PP87m8lMNqRPBaXmVlQ5korACEWPcBOu7 9C/Ufu16y/qWdrcfF2troqducd/ExmcUKCoC+pqJguMNy3ZHYSnO/TWRJkcIGN/+Qkh/HvoVjYK EDzJPgzOTWiIqKRY= X-Received: by 2002:a5d:6944:: with SMTP id r4mr23775356wrw.169.1591632138154; Mon, 08 Jun 2020 09:02:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoiY9HH6DYEAYHN6rucdTjohElJ6XD9T5NIDyn78LYZQIrFIp9Ryvcx8eKgENNoeOnl+u4SA== X-Received: by 2002:a5d:6944:: with SMTP id r4mr23775315wrw.169.1591632137954; Mon, 08 Jun 2020 09:02:17 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id u130sm12527wmg.32.2020.06.08.09.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:02:17 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 16/35] hw/input/lasips2: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:25 +0200 Message-Id: <20200608160044.15531-17-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 01:05:50 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/lasips2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c index 0786e57338..452244f037 100644 --- a/hw/input/lasips2.c +++ b/hw/input/lasips2.c @@ -34,7 +34,7 @@ #include "exec/address-spaces.h" #include "migration/vmstate.h" #include "hw/irq.h" - +#include "hw/qdev-deprecated.h" struct LASIPS2State; typedef struct LASIPS2Port { @@ -269,6 +269,8 @@ void lasips2_init(MemoryRegion *address_space, { LASIPS2State *s; + qdev_warn_deprecated_function_used(); + s = g_malloc0(sizeof(LASIPS2State)); s->irq = irq; From patchwork Mon Jun 8 16:00:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB66EC433DF for ; Mon, 8 Jun 2020 16:19:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 336D1206C3 for ; Mon, 8 Jun 2020 16:19:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OrH1ySDQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 336D1206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKV8-0005D1-8t for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:19:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKEW-00070B-2G for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57210 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKEU-0007u1-Ek for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:02:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WzkinKDRWpQmIIO97X+MugaJnDZKw0ffp1ti6/ctwc=; b=OrH1ySDQhciBHAMMlCFm4kH3NnMfKOW6Rrsn+MN8vBqGsSCBE9D5Rkubnl8cVNVI+pYciS PxSH95EG9F0aP/B8p0tSKjDwShOa6YG4edWj4FIUZmvz4E+UY6QyiCmmfgXVYaLrJT9ZLo h/Lf5yhDu7Lgg0/6i4onVc9OIEbQVz0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-sdsWZHBdMmmnuQP3QvT9IQ-1; Mon, 08 Jun 2020 12:02:37 -0400 X-MC-Unique: sdsWZHBdMmmnuQP3QvT9IQ-1 Received: by mail-wm1-f69.google.com with SMTP id s15so5329wmc.8 for ; Mon, 08 Jun 2020 09:02:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3WzkinKDRWpQmIIO97X+MugaJnDZKw0ffp1ti6/ctwc=; b=PA0/7P3+tSaSuZuZvO0T5OfHYg8LtA2vE1NyjtuTn8n9dOoqRbwJRrCyjmYRUcflS9 ShU2EDdY7MSoJsuBrGIyzYibF75V2cK3Ykc89mKBNfIA76EI+XwQAu6PCe/aY/uMpkIc dvsRHssu5pWqRQ7U6Dw9EYh7fIk7eF34vuuWOenHSn2EAnKZnpWyE2zLKd2DVGmffIma 6dpLwLiJOWC+3PfbKK/YpCfR9LHmnQiWpyNVwBQqdNetyijOAXjRa7215e6TQKTQIyfV 1yWq1Fbjthp/JMlW8ywDOc9p6R8LCZijB7ZPzC6gcGe+sgNq3asVr6o7i3GlF7lFcHdB /56g== X-Gm-Message-State: AOAM5300/W9Dd//L39iVBMQ9LF186MTVfK82LfrPHUFPasj/6yicwmQ+ IsaDDDpvGc6fRm/4zxq1WiH3bt7NCTQf0oRQwu2jxFrmbsSjW0+1f2u9yVg1eln8i+KaX+Q7jdU Gw8DZxe8+YDxYIq0= X-Received: by 2002:a5d:6391:: with SMTP id p17mr25853422wru.118.1591632155838; Mon, 08 Jun 2020 09:02:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDmwNfyaecxfbcj81e+/jUBcU6vumJ01a4QLGsVfaCgs3E8cqqhTSmTr88Achkag+c/jFzSw== X-Received: by 2002:a5d:6391:: with SMTP id p17mr25853379wru.118.1591632155624; Mon, 08 Jun 2020 09:02:35 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id o10sm183753wrj.37.2020.06.08.09.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:02:34 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 19/35] hw/input/tsc2005: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:28 +0200 Message-Id: <20200608160044.15531-20-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/tsc2005.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c index 55d61cc843..1f97b82379 100644 --- a/hw/input/tsc2005.c +++ b/hw/input/tsc2005.c @@ -27,6 +27,7 @@ #include "hw/irq.h" #include "migration/vmstate.h" #include "trace.h" +#include "hw/qdev-deprecated.h" #define TSC_CUT_RESOLUTION(value, p) ((value) >> (16 - (p ? 12 : 10))) @@ -489,6 +490,8 @@ void *tsc2005_init(qemu_irq pintdav) { TSC2005State *s; + qdev_warn_deprecated_function_used(); + s = (TSC2005State *) g_malloc0(sizeof(TSC2005State)); s->x = 400; From patchwork Mon Jun 8 16:00:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281156 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC69CC433DF for ; Mon, 8 Jun 2020 16:23:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 773E3206C3 for ; Mon, 8 Jun 2020 16:23:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bf5ZFLPD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 773E3206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKYj-0001bl-Mw for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:23:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKF2-0007Nv-Aa for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:03:20 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:49395 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKF0-00088N-6V for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:03:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bGDaAMWSjpprqA7Io3dm7QCtlFgafERZCyah8ISMES0=; b=bf5ZFLPDxjE6uiQntaPwYH/JDEJnO2OnpzJmRieVnXA5g817BBjWqKROH+Ubd6CUCgp6eC u3T0y4xfwQmFNhEmDf4Jf0uyNvwIgZEtAMvNzLRfBi5UDLrMJbjmSMsnHUHCdCpI+WzQ/Q nOeO5+ilEZkg0lXck7CJioQbHk450e4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-KrLVzbA5MzuLBYdWGxBEOg-1; Mon, 08 Jun 2020 12:03:01 -0400 X-MC-Unique: KrLVzbA5MzuLBYdWGxBEOg-1 Received: by mail-wm1-f70.google.com with SMTP id b65so8804wmb.5 for ; Mon, 08 Jun 2020 09:03:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bGDaAMWSjpprqA7Io3dm7QCtlFgafERZCyah8ISMES0=; b=itrBYCdCX4TjJk8OTqHi/blsWG9wqbNEoieGT9A/Gcu5Ev0AnOzBsL1g0Q2fK/Nutr AQmp3EApRGFZZ5cxilCpGu9gEcfkdJLecrXyYPSIMo9JglNONAG+wB2xdQsdy5fFHyan qUHqKyfeNvQlCkCmagSEO/M2PxGPspFzkojxyHVU7SSgloxr3kub01dPak4J++EoC9SL g2LbJE+10kz0X3rkoySDSVKy4X/GDi8ZqyS9YWG67JhSkFRDY1TTbGT+0LRpHtCxusIJ W0Zk8vRnkfFODEJ9OtCWNVvrjzkE6vr01QpvmKzj3hUwKiGtnXKFf1ZbJVCClmttqzzw Dsqg== X-Gm-Message-State: AOAM53150tBbMpVnUojbF3MLJSY1hzveDbE2uXz0P6QJu96g8AfdVKBM lUeXO1aae1ltuGbA4tYhBrYzksN/EPOK/MCJUOcPjDbaNVJAh6vIBHs/eBILSqH9dzOfZeuWEk5 /krR4AwLPlg1Awlw= X-Received: by 2002:a7b:c201:: with SMTP id x1mr78854wmi.58.1591632180062; Mon, 08 Jun 2020 09:03:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyF5+TIjMo5Pv/JZUc9oRpRqa5yr/ufMOXB39AL2QL+RAu+P6Qy6euM0Zs2QNe7FGM5NNcPJw== X-Received: by 2002:a7b:c201:: with SMTP id x1mr78842wmi.58.1591632179907; Mon, 08 Jun 2020 09:02:59 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id q1sm34631wmc.12.2020.06.08.09.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:02:59 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:32 +0200 Message-Id: <20200608160044.15531-24-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/applesmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 1c4addb201..d63f19038d 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -36,6 +36,7 @@ #include "ui/console.h" #include "qemu/module.h" #include "qemu/timer.h" +#include "hw/qdev-deprecated.h" /* #define DEBUG_SMC */ @@ -253,6 +254,8 @@ static void applesmc_add_key(AppleSMCState *s, const char *key, { struct AppleSMCData *def; + qdev_warn_deprecated_function_used(); + def = g_malloc0(sizeof(struct AppleSMCData)); def->key = key; def->len = len; From patchwork Mon Jun 8 16:00:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281154 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840D5C433E1 for ; Mon, 8 Jun 2020 16:26:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51A61206C3 for ; Mon, 8 Jun 2020 16:26:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O+2xDPsP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51A61206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKb5-0005sF-Gi for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:26:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKFJ-0007SB-2E for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:03:33 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:53610 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKFG-0008AO-Gf for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:03:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J738BQqBvhpMt3eJFPP/lmrii93ELO7mMMfmrV28FMw=; b=O+2xDPsPJH1jiXin8V8D0SXVvB/V0YB5Tyh/FbitQfqIr9Y+KMe6lcW0pwpKcteAPVonF9 qGOuMcRtZ/AzgkUi1C8StCUvlusTtGqkHBGffu1yZQf9EKrIlPFm4jjQCn3VQgvPMOK7X4 nvWazC4pCzVgcrXCLSZF2rp0hQ6Cmvg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-g7CCi_N7NGSTYj8JEToMxQ-1; Mon, 08 Jun 2020 12:03:19 -0400 X-MC-Unique: g7CCi_N7NGSTYj8JEToMxQ-1 Received: by mail-wm1-f72.google.com with SMTP id y15so13925wmi.0 for ; Mon, 08 Jun 2020 09:03:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J738BQqBvhpMt3eJFPP/lmrii93ELO7mMMfmrV28FMw=; b=T41OFDKKJKnCpmjZYe4WlHbehetqxPRhNxj556uSGIaju3Tb79oxcQPPMwEVeohweM QC+JWyofHNpSXCieKLTqv1wcyP56Izw0T4U0aRcrP6U9ZV0DQaaLEd2/kGw3PN59/kRe tewFRksbezymFuRhvvJ4Ck+AuVPVqSWgDl4bscD5WSyAobtBtMmRqnDCoS3qIBV7zzUn gc9E0Wh+65OitZVbi8ZZf6/FXL+HozQCr7oCGiTg1Etzs505IU4hO4prb0xjnfQgfAo1 WG5NzKOtgCKZmWp/40o5z6sZ6BKbY08f+4wBrIA5cO35GAzpefNEm9ToGawO4qcMPGiQ TjiQ== X-Gm-Message-State: AOAM5322GzqAao1Eq0afzgZUfz2a2Lg/DxaU1UJEmrCFluPi+fB2ovVU H0HxzJfafYqANYWkplJWtWwMwcE8AFwTRNkS950V950gFxxnX1c7ZJB5nPK8rWwVkiyqG8JLEg8 6tdRWYnljVeFkvLw= X-Received: by 2002:a05:600c:4410:: with SMTP id u16mr73274wmn.88.1591632196837; Mon, 08 Jun 2020 09:03:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3xkvh2Vk+4PYCBSKCv2fZwGK7MNY+4FcnyFPW+oUbVotWO8gdASoKL+nfN+0YxJIIGJ7I2g== X-Received: by 2002:a05:600c:4410:: with SMTP id u16mr73234wmn.88.1591632196640; Mon, 08 Jun 2020 09:03:16 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id l17sm32396wmi.16.2020.06.08.09.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:03:16 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:35 +0200 Message-Id: <20200608160044.15531-27-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/openrisc/cputimer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 93268815d8..60f2c9667f 100644 --- a/hw/openrisc/cputimer.c +++ b/hw/openrisc/cputimer.c @@ -22,6 +22,7 @@ #include "cpu.h" #include "migration/vmstate.h" #include "qemu/timer.h" +#include "hw/qdev-deprecated.h" #define TIMER_PERIOD 50 /* 50 ns period for 20 MHz timer */ @@ -135,6 +136,8 @@ static const VMStateDescription vmstate_or1k_timer = { void cpu_openrisc_clock_init(OpenRISCCPU *cpu) { + qdev_warn_deprecated_function_used(); + cpu->env.timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, &openrisc_timer_cb, cpu); cpu->env.ttmr = 0x00000000; From patchwork Mon Jun 8 16:00:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC16C433DF for ; Mon, 8 Jun 2020 16:27:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D5C1206C3 for ; Mon, 8 Jun 2020 16:27:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i0gWMupY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D5C1206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKcB-00089F-Lg for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:27:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKFi-0007sh-4y for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:03:58 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:38935 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKFg-0008Ep-Tp for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:03:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qfeQjgHHg6Ez9waCGJmOrJzAr/zUBGXbuFUiyuF/Rfo=; b=i0gWMupYQnQaFUEqTKaVJBfEe2HNXu7+J/baMmXCmjt4r32d3aYvlLPLRjroSb/5hxImAc uC3PbyJL9Znc/AfU8nlK8C59RGAgTKM1qMcX+L4K9FxhXkQhXrh66avYo1etStY+pgnPup Oq+k1H8cr0en46mXrLNzlbEfZfcry30= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-omOvy007O2mnpedbBdcMAg-1; Mon, 08 Jun 2020 12:03:54 -0400 X-MC-Unique: omOvy007O2mnpedbBdcMAg-1 Received: by mail-wr1-f70.google.com with SMTP id z10so7393026wrs.2 for ; Mon, 08 Jun 2020 09:03:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qfeQjgHHg6Ez9waCGJmOrJzAr/zUBGXbuFUiyuF/Rfo=; b=mBq3gTe1K0Hz6TRMBWU4RVNbzjGzThk7CgjG/ugivCiXFXNMUmkXYY+M8URh625rJS gin6nx5I5hw4TEbxTX02AGTry4OzOCsffqkyKPQePB5CoCEY/iFaExR8hBINTlFNhp9g MlMpMkkkcB5Hihp76EjH0KKXFvG71o4QNtghPfFARWZsrBwC/ev55VmCNcnBgfLj5MXc q/HsSBAwKV0uIZubagf1Q5dfwTfhDfgTL7wmZerlXZXIkfoa7CYfJHParbOPUO6aiDK0 m5rvYCY0E5oZnFLXNsfkFvenXVOy+PVeS9hFZb6h/AfHmISx627tDcfmgg1H85rEe6Ir 7hng== X-Gm-Message-State: AOAM533AlRsIlmbYjd51KTN85WdSEm5C4PEFx6PRWHGPdknzFLTGO4sW INw0JNoEij/zfFVFzX06LSmWy55gvumxP05uu80kiJfCn0RZ7xL9JXJv3z4MZV1PvJuNWsB7zF+ FRfqf/8A7PX57JyM= X-Received: by 2002:a7b:cd04:: with SMTP id f4mr54318wmj.3.1591632232864; Mon, 08 Jun 2020 09:03:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLcq9fw++IqBSfctMa2VnenePzSclzDPUX9srn5OE/PiQtrx427TCsmbU35rGSbrlanE52/A== X-Received: by 2002:a7b:cd04:: with SMTP id f4mr54282wmj.3.1591632232663; Mon, 08 Jun 2020 09:03:52 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id q4sm4466wma.47.2020.06.08.09.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:03:52 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 32/35] hw/riscv: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:41 +0200 Message-Id: <20200608160044.15531-33-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 11:58:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/riscv/riscv_htif.c | 4 ++++ hw/riscv/sifive_uart.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index ca87a5cf9f..bd080dbefb 100644 --- a/hw/riscv/riscv_htif.c +++ b/hw/riscv/riscv_htif.c @@ -30,6 +30,7 @@ #include "hw/riscv/riscv_htif.h" #include "qemu/timer.h" #include "qemu/error-report.h" +#include "hw/qdev-deprecated.h" #define RISCV_DEBUG_HTIF 0 #define HTIF_DEBUG(fmt, ...) \ @@ -238,6 +239,9 @@ HTIFState *htif_mm_init(MemoryRegion *address_space, MemoryRegion *main_mem, uint64_t fromhost_offset = fromhost_addr - base; HTIFState *s = g_malloc0(sizeof(HTIFState)); + + qdev_warn_deprecated_function_used(); + s->address_space = address_space; s->main_mem = main_mem; s->main_mem_ram_ptr = memory_region_get_ram_ptr(main_mem); diff --git a/hw/riscv/sifive_uart.c b/hw/riscv/sifive_uart.c index 9350482662..1a5890d5f7 100644 --- a/hw/riscv/sifive_uart.c +++ b/hw/riscv/sifive_uart.c @@ -25,6 +25,7 @@ #include "hw/hw.h" #include "hw/irq.h" #include "hw/riscv/sifive_uart.h" +#include "hw/qdev-deprecated.h" /* * Not yet implemented: @@ -183,6 +184,9 @@ SiFiveUARTState *sifive_uart_create(MemoryRegion *address_space, hwaddr base, Chardev *chr, qemu_irq irq) { SiFiveUARTState *s = g_malloc0(sizeof(SiFiveUARTState)); + + qdev_warn_deprecated_function_used(); + s->irq = irq; qemu_chr_fe_init(&s->chr, chr, &error_abort); qemu_chr_fe_set_handlers(&s->chr, uart_can_rx, uart_rx, uart_event, From patchwork Mon Jun 8 16:00:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281152 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF7FC433DF for ; Mon, 8 Jun 2020 16:28:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E165206C3 for ; Mon, 8 Jun 2020 16:28:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gyRNygOP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E165206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKcz-0001B5-Br for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:28:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKFn-00081w-Pz for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:04:03 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:40669 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKFm-0008Ge-Vk for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNDlXKA4V05uqH+zGvitoUZAatp4aCkSuEKALsyTQs8=; b=gyRNygOPKTodhkBJ6A5D56U74zKqRJS5rE+wNZ5Y7FeOwFX6LfCpUJQQKBaOhxnYRQV/sd 17/dsHy5HZLYFZbKNXQ6Ea8VBlpoFrMkzFNNtDjp7FykHaIkOvWeI3L03OEWrKArd8kz6a QE/222skRmADh6QDSvJPpL/QCTon8j0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-NENkx7-mOtCQH2OX2bhVPQ-1; Mon, 08 Jun 2020 12:04:00 -0400 X-MC-Unique: NENkx7-mOtCQH2OX2bhVPQ-1 Received: by mail-wm1-f70.google.com with SMTP id p24so9470wma.4 for ; Mon, 08 Jun 2020 09:04:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sNDlXKA4V05uqH+zGvitoUZAatp4aCkSuEKALsyTQs8=; b=QeDU6EIYjhgEhRfYUR+ZJ2IEG1Xkrb/pwRTITqZkAI7C1bvK7+HTmyvJZGm848Z1xM dLR8d2VKluq/GZBgnLyCUuXSy3fkS1QxooMezcvE9bOjqB3gs+CHppp141L5RbOslYqc ZBr8XIH5Z5TIaYV6mb805oDgix8TFaJRgyhy7WOfwVMM0E4aEs0by+vgNwHkm2qLCuTT HShQzlX8ACSEe/fsJGeoCEoswMPC7KeMFHD52LL2Pw1FYNZHC4mAbMEgtjfUELMxijL9 QE6qP4XIqtANj+VhWjeThP6WjNHlRjp6QT+rJNGzzKsZvDbp7w959SmgidlJ8cqvHsAK vYLw== X-Gm-Message-State: AOAM532g6ar6fVOOk4iEc69iJ1MC1iFnbT4u4sB7nOlNmGCwaaU/wB+h 5YM00smwzMQShwD5mAwHtqi3843xAIDXI2CHjjRbtRN1QPEeiqHDAoMzD+KXNncZL9KbzOkIyc/ WG3bxKQoJcef7z/Y= X-Received: by 2002:a1c:2082:: with SMTP id g124mr55794wmg.21.1591632239016; Mon, 08 Jun 2020 09:03:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6Ea3200SCtYHheH/UK2Mas0Wr6/SnNtzGrclQZuKXFOcXxL+qpSERI07OhtEH9rZ1aPQhvQ== X-Received: by 2002:a1c:2082:: with SMTP id g124mr55753wmg.21.1591632238819; Mon, 08 Jun 2020 09:03:58 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id h188sm48452wmh.2.2020.06.08.09.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:03:58 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:42 +0200 Message-Id: <20200608160044.15531-34-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 11:58:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/slavio_timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/slavio_timer.c b/hw/timer/slavio_timer.c index 4c5d65e391..16f21669bf 100644 --- a/hw/timer/slavio_timer.c +++ b/hw/timer/slavio_timer.c @@ -31,6 +31,7 @@ #include "migration/vmstate.h" #include "trace.h" #include "qemu/module.h" +#include "hw/qdev-deprecated.h" /* * Registers of hardware timer in sun4m. @@ -392,6 +393,8 @@ static void slavio_timer_init(Object *obj) unsigned int i; TimerContext *tc; + qdev_warn_deprecated_function_used(); + for (i = 0; i <= MAX_CPUS; i++) { uint64_t size; char timer_name[20]; From patchwork Mon Jun 8 16:00:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE72C433E0 for ; Mon, 8 Jun 2020 16:30:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAD2F2053B for ; Mon, 8 Jun 2020 16:30:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="azhV8+nq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAD2F2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKf1-0004LZ-Sj for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKFx-00089T-Gm for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:04:14 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40496 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKFv-0008HS-I5 for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:04:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1YHmjQuhKrVQhVboVAQhCqKWsJQjJvIRsihRuyQB5QA=; b=azhV8+nqZYNRIe//txgnsYcjhvqFe0DrKoRN3XRLcd4Bu7j+iY1CuUiPAi3iYPirOu5/K9 N9SD1gAVlfUPYR4xzCASlWjQk+c6NQjJ0Q8KvzrELdABD8pppSvxt+hQx2zy/WGtGkGoKG 2QMnMBz5eCm0z/v3z4UTp4XrmEaSSGs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-wnrGQVfTNj6WDQDpS-M9ig-1; Mon, 08 Jun 2020 12:04:06 -0400 X-MC-Unique: wnrGQVfTNj6WDQDpS-M9ig-1 Received: by mail-wm1-f70.google.com with SMTP id j128so8670wmj.6 for ; Mon, 08 Jun 2020 09:04:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1YHmjQuhKrVQhVboVAQhCqKWsJQjJvIRsihRuyQB5QA=; b=EURwtq6qyTvg4EIGOeW0sBnaHPlcvRGCc7Ir3MUR8s5cELj/kLPTnSCVL+QFw1zAKl j1f2Vk7kmw28x4vQf+l6z8gyB+WgJMg4MLDbe70MnKzMohQka/RsZ8BaOeovsYGDAXho MlA18r3kbeFAdX3EVa9y/icKvEsAqQggBZiOtH8RlxSKb9IPuQ+k/zKK/PPXMNDqT7cf Vzx/+UIvbNq9sw94mG9e7dV4N0DCV9Qh9rtJNGCWhmBk2TiLhgqrpUet0kqfagV5OEb0 dGQSUkLNQDP3MWKgy+B6W+FF2+s9EvWsrc1z1TT3SlhabLXZYraXdlNlS5PLYErLh3n5 70mQ== X-Gm-Message-State: AOAM530fT0iQ7Y/G/verma058gxWUPv1Z7WLeYjGL0DO4eWndkdiQAf5 5faz7d7h/7ncufGCpjza9MUOxCyquAexqNdPboR4FDjG8ABZZ3mjh+OIwqgINB687g8dKtL4yM7 oxoLaOtmV8Cmzz88= X-Received: by 2002:adf:e68a:: with SMTP id r10mr23902508wrm.384.1591632244560; Mon, 08 Jun 2020 09:04:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU7/QCokRt2M0EtovQUdkQHNPZYj9jN1RqUTvUD0f6M2vtgvgHtmb2W1P0W/noN9Fx2nTHYQ== X-Received: by 2002:adf:e68a:: with SMTP id r10mr23902460wrm.384.1591632244335; Mon, 08 Jun 2020 09:04:04 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id k17sm177411wrl.54.2020.06.08.09.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:04:03 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 34/35] hw/usb/hcd-musb: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:43 +0200 Message-Id: <20200608160044.15531-35-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-musb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/hcd-musb.c b/hw/usb/hcd-musb.c index c29fbef6fc..9b3cf1ca8f 100644 --- a/hw/usb/hcd-musb.c +++ b/hw/usb/hcd-musb.c @@ -25,6 +25,7 @@ #include "hw/usb.h" #include "hw/irq.h" #include "hw/hw.h" +#include "hw/qdev-deprecated.h" /* Common USB registers */ #define MUSB_HDRC_FADDR 0x00 /* 8-bit */ @@ -377,6 +378,8 @@ struct MUSBState *musb_init(DeviceState *parent_device, int gpio_base) MUSBState *s = g_malloc0(sizeof(*s)); int i; + qdev_warn_deprecated_function_used(); + for (i = 0; i < musb_irq_max; i++) { s->irqs[i] = qdev_get_gpio_in(parent_device, gpio_base + i); } From patchwork Mon Jun 8 16:00:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281150 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C78AC433E0 for ; Mon, 8 Jun 2020 16:31:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24C532053B for ; Mon, 8 Jun 2020 16:31:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YnH0xSE1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C532053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKfs-0005EY-78 for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKG8-0008FG-Kl for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:04:24 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24265 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKG7-0008JD-NN for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:04:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6eEd/TZ2fHyvBWvIJ4C8+kCwxjhDxL4elOTIEe035mA=; b=YnH0xSE1dlj3foedbN47Wu/S7008E6Zt0Pfq7GJMjOF/unBG9L1oLkA5ow7kUSCLig7Imq Je/V7Fs166NbMGu70YTJUkyf5qRIuiUxPXboR40E9o7j638sS1U3cN7naey+SVbKNazrpW aO1MB33X2qAK4XdsRvdAgXz3x/eiA60= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-3B4hgxiDMpW1P8Giea8Kow-1; Mon, 08 Jun 2020 12:04:11 -0400 X-MC-Unique: 3B4hgxiDMpW1P8Giea8Kow-1 Received: by mail-wr1-f70.google.com with SMTP id w16so7329168wru.18 for ; Mon, 08 Jun 2020 09:04:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6eEd/TZ2fHyvBWvIJ4C8+kCwxjhDxL4elOTIEe035mA=; b=uF1klyEcpOP+daQqg6PuU0nys3Kcy6cYiiBGfQeAMNaGDxBpvFnj3q+34v6ZKTGumS cIObZ7Y9u1hH4mJ+Sa7zOFan1TExc/jrR8XpsCxZhYAdva8dibkMUyyPX8xwGLOyFTSo HBRdTSJJOd+B9n4hQkbko3E4KxK9wdEQTCak96YGlSbfoo2mRDyXUrsl833JmEu+55GZ lDx6YJlVQz8Tlk5i8fy2bG598MqnPwaXe5PyWpyAP7PjE7Q6v1h2S0u+yf/uf8AnQ2Wb ULxHnygH70MuHXiT9FSQGIKcngWGVpt/D0w27m+BvmfFkpA+rm1SHcE77QIhFQanM2bZ N5zw== X-Gm-Message-State: AOAM5320eoYeZrNXPQ+J1kzBdDsfB/H5SxRX3P12LJQ3OC0JXYd2sAHl 0+cThAV4axQW/U197rfh0M6FsxDozoNzmvtMYn0NMRcwrq/svdCc/jy5rceyY1aHPBXhmwRkS7P o+viJyKt4nlgXTgc= X-Received: by 2002:a1c:bb05:: with SMTP id l5mr29002wmf.141.1591632250055; Mon, 08 Jun 2020 09:04:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwleTjEs6m/0F9WTXFTKcyesoS9BhM/fhVRhaP0ZaaZMgPHfTC+huUmGRS6bDSqa1xeeej4Q== X-Received: by 2002:a1c:bb05:: with SMTP id l5mr28952wmf.141.1591632249790; Mon, 08 Jun 2020 09:04:09 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id j16sm243025wre.21.2020.06.08.09.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:04:09 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 35/35] hw/xtensa/xtfpga: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:44 +0200 Message-Id: <20200608160044.15531-36-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , David Gibson , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 60ccc74f5f..a3c82dc81a 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -50,6 +50,7 @@ #include "xtensa_memory.h" #include "hw/xtensa/mx_pic.h" #include "migration/vmstate.h" +#include "hw/qdev-deprecated.h" typedef struct XtfpgaFlashDesc { hwaddr base; @@ -129,6 +130,8 @@ static XtfpgaFpgaState *xtfpga_fpga_init(MemoryRegion *address_space, { XtfpgaFpgaState *s = g_malloc(sizeof(XtfpgaFpgaState)); + qdev_warn_deprecated_function_used(); + memory_region_init_io(&s->iomem, NULL, &xtfpga_fpga_ops, s, "xtfpga.fpga", 0x10000); memory_region_add_subregion(address_space, base, &s->iomem);