From patchwork Mon Nov 13 21:39:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 118823 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2283181qgn; Mon, 13 Nov 2017 13:41:11 -0800 (PST) X-Google-Smtp-Source: AGs4zMZz/VYqkDPY64TWHezTmXUcXHufe+XLtwyaHXIE8+ywGYcb7nOo0akA5jg01K0rbZsl5yew X-Received: by 10.159.252.131 with SMTP id bb3mr232125plb.68.1510609271646; Mon, 13 Nov 2017 13:41:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510609271; cv=none; d=google.com; s=arc-20160816; b=EieRIFUZ/wyaCPhimLUHSn/5UPQBeihslfAinmwO4x2m/oUJopJ0bcfh7AWzMcrkOb zudD8ETrdssIwSAirPYnXqw78B20HJv5b34aSi0dircndKgPeD2rvdPtZuos6fNbMt7o vf3Go5NoZtlVw8Sfpq06P8lm94JajbWlbyFx1OIyB+zaJu0XVhuHxBTq9iWaIwlAoO4Z YFcByOtjhVRoMhaLx9OvUH9Lvu+1x5yvXUxBSFmG5XA76zsv2bDwXyPXhpt83xV/bq6L fHcCrR2Dtn79+heh3/roKFvDMH9XL1BWzCvpVcxGEJAzC1MwmmBsSOffZx1E2kMphejG O7oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=/zGvq+6p4CRlTCtnjU/qeIpZ7Fo4gJXQwMjy7sKv+9M=; b=GSFUd7ITTMzxK1DlchnQR5JCrgVnvozsa0DIGtTtoE6/2FhfpZkKvLz5D8lErToVG3 4afRyJGtI3wroh/exXwp6Qaxz3xpupqLBbD/rIY+sWMcZlCbU7JthpvG/N/3puQi9F48 KOPHdmDCP2AUYuEYchcmZwtVUnlPneknwjZgsVS/Sk9UmX4SWXBJwYeDUJ18N4qYL5F9 58um+Jq36/EcwO7qxUEITZFxwrF3v1cNe4XEMlMm9tNkWo4QwKWUhI+3Us0b8DG8oOOs uleOzsX66eXxsr5SJ16QMVZNXZnYb6EwR8zF4msKKkFyCmEuWNYfn08/BKN6w97XUAL6 5DRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Mr27fvnL; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si668445pgc.800.2017.11.13.13.41.11; Mon, 13 Nov 2017 13:41:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Mr27fvnL; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751705AbdKMVlL (ORCPT + 6 others); Mon, 13 Nov 2017 16:41:11 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:53603 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdKMVlK (ORCPT ); Mon, 13 Nov 2017 16:41:10 -0500 Received: by mail-lf0-f65.google.com with SMTP id 73so5674596lfu.10 for ; Mon, 13 Nov 2017 13:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=HAS2oPtsq5K6hP+yFa5DOvkyNe3wt+HivfADwtRiZ64=; b=Mr27fvnL34cD55TTvT3ISHEEMxe7SuEO4FAMBdjCQUpbsbVrso2K7ApjzVMowrHygC xkfDTT8xNcm25hCfl/3en3T1xyPCiUTvoaE7xPHzaNxQdl3bQBhWE2YQCtTwSwItTVOK sMTxiB1U40KspmXkCu9seXmv32ba/X8d894us= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HAS2oPtsq5K6hP+yFa5DOvkyNe3wt+HivfADwtRiZ64=; b=tK5bEcFxczmmcn5UtYhD/jhefFAC8ih5sq2cniiAo3KofsgvGdoLDKUPT3FW9gNenw H+kkWbW73XvPNcFdmAZxe5jROq9v/LXKry9CIqfc/F+z/Yr7C8A2V71tGC7LjE4P65vS 2luLWQbSsjq0EuQ7C+ENs1RnxoeQr1w9vyrt1hPj+WxHqUNWqaFn9QvAH4sDLIb4wK3P 3jfwvof3rNDAL38MIBIJXdW+Vbf2YLrInRkWy1FGnejyqecgs91nIWud3cuN+wppwV4i VoS2fuY5Uh1FXcYaVcDzDTAb/N3QieyPXrFtrZqIZRWdyjKPcFOdWm0qsmKtLb5OmvAa Svwg== X-Gm-Message-State: AJaThX67z52ZqXYw+CPTjY8BkHRE/+pGKu3D8Iqe3wX1q4jaFjGIhUoH MysjwqfNC8XvnfZL+syD8gP7hQHqwOI= X-Received: by 10.46.64.200 with SMTP id r69mr3227739lje.57.1510609268706; Mon, 13 Nov 2017 13:41:08 -0800 (PST) Received: from localhost.localdomain (c-567171d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.113.86]) by smtp.gmail.com with ESMTPSA id u19sm3026842lfc.89.2017.11.13.13.41.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Nov 2017 13:41:07 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Linus Walleij Subject: [PATCH] pinctrl: gemini: Fix missing pad descriptions Date: Mon, 13 Nov 2017 22:39:05 +0100 Message-Id: <20171113213905.8923-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.13.6 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org A pretty clever static checker found a bug in my patch: I added more bits to a bitmask but didn't extend the array indexed to the same bitmask. Fixes: 756a024f3983 ("pinctrl: gemini: Fix GMAC groups") Reported-by: Dan Carpenter Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-gemini.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.13.6 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/pinctrl-gemini.c b/drivers/pinctrl/pinctrl-gemini.c index ecfc9733db7e..e9b83e291edf 100644 --- a/drivers/pinctrl/pinctrl-gemini.c +++ b/drivers/pinctrl/pinctrl-gemini.c @@ -136,6 +136,8 @@ static const char * const gemini_padgroups[] = { "PCI CLK", NULL, NULL, "TVC CLK", + NULL, NULL, NULL, NULL, NULL, + "GMAC1", }; static const struct pinctrl_pin_desc gemini_3512_pins[] = {