From patchwork Wed Nov 15 19:30:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 118991 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp3880910edl; Wed, 15 Nov 2017 11:31:18 -0800 (PST) X-Google-Smtp-Source: AGs4zMYvBnKxI1MP8Qv+e/ds78tMSRrD9eWkE9v358cM5zvL6i7l334DPp+6HZu2prbrhxTS+xoB X-Received: by 10.159.229.136 with SMTP id az8mr17022403plb.423.1510774278632; Wed, 15 Nov 2017 11:31:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510774278; cv=none; d=google.com; s=arc-20160816; b=xIIqasjVm8RhhmMBeBSyTgACf/lzU2S5i2feip/IHkw5Bbsx0ctWqEEDYg+EVxnE1W TF01KyLUiQ7g/WSavq9Rsu8cWu/Qs/I2BK4GHRLnj1TPuSw7jDWhgQ4AQjIVGzkai2ZA XC5/kRXt6UcHkRKuMtSSLT8Li1uth6ITGOOVoNYB5cNura3kUqRq1gx6K2tLDQxc7DSl mSapxbvlFy6Ygk+cqB3nCdvQPfrIg+J98fFNQdYBPanbfbgUYWlFHX8xScvnF/iUoJ1J DisGLmV4WKre2AsbN7EBhvYNMYmc3WxnnWInopcC/grD+zJSWbkNyCUkSwcZwwZP/Xf2 QqCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature:arc-authentication-results; bh=KdENSivzGrfcE1XbZQS1n568f8EyQFLz6eF2XpdEbmU=; b=0RJEcRZP7kUOGUiOXbF99FYuLJqxLYbibkKcIjd3ngFl1Y2TR1BncVLAYPNuVCxG7l 7ghEFE40QtW1OXHTntNh/lgGD3afYETYr6Pb3MtxjV9OKrUK1DZe7+OO5yTSf6s2L7Zy 3Xekmv9Bb06DwfmUsX1d7RcixkhKOLL8A20kKAt9UuNesd0uDjVkAVjrUFOibh2YAXL4 SjTAwHzuFCvjvgHNoSBOWWZ+I5R2TMybyqg24S+0mxNVyLL2X16e68KWYhfXf9zjbZyP 4CvKCY1ro+v22DbMfT9jBS9ad8tMff5j6sITz4Ew8yQY81GKeCpqakkpdp3IEPUSOk2X VmwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Z5Y5Ux1m; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b89si18739912plb.556.2017.11.15.11.31.18 for ; Wed, 15 Nov 2017 11:31:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Z5Y5Ux1m; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933205AbdKOTbR (ORCPT ); Wed, 15 Nov 2017 14:31:17 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:41047 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933071AbdKOTbM (ORCPT ); Wed, 15 Nov 2017 14:31:12 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id vAFJUstl023961; Wed, 15 Nov 2017 13:30:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1510774254; bh=vAXKYl9Awk/rIOJQrh38qn3a+ZCaX5bXNfmCLYx5z0k=; h=From:To:CC:Subject:Date; b=Z5Y5Ux1m+n3yvbdiIwZXV3y3hqI9h/TOWE5vnJPISt+VK1D2me1ftq9WsYxy1CrA+ LAF8irVPoY7Rru7FqcKnbWjfVGW1LoGnCJlGQSicZX+RXI2jmIZe4vwsjWmk8t3b9B pVczXqb8nj9LXUmUpMlONsIzTgqkYFUXJHKYpxCY= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id vAFJUsNV027060; Wed, 15 Nov 2017 13:30:54 -0600 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Wed, 15 Nov 2017 13:30:53 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Wed, 15 Nov 2017 13:30:54 -0600 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id vAFJUrAX026909; Wed, 15 Nov 2017 13:30:53 -0600 Received: from localhost (a0272616local-lt.dhcp.ti.com [172.22.167.247]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id vAFJUr328423; Wed, 15 Nov 2017 13:30:53 -0600 (CST) From: Dan Murphy To: , , , , CC: , , , Dan Murphy Subject: [PATCH v2 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Wed, 15 Nov 2017 13:30:30 -0600 Message-ID: <20171115193031.28781-1-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This adds the devicetree bindings for the LM3692x I2C LED string driver. Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- v2 - No changes - https://patchwork.kernel.org/patch/10056677/ .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt -- 2.15.0.124.g7668cbc60 diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt new file mode 100644 index 000000000000..cfef67bd4100 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt @@ -0,0 +1,28 @@ +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver + +The LM36922 is an ultra-compact, highly efficient, +two string white-LED driver designed for LCD display +backlighting. + +Required properties: + - compatible: + "ti,lm3692x" + - reg - I2C slave address + +Optional properties: + - label - Used for naming LEDs + - enable-gpio - gpio pin to enable/disable the device. + - supply - "vled" - LED supply + +Example: + +leds: leds@6 { + compatible = "ti,lm3692x"; + reg = <0x36>; + label = "backlight_cluster"; + enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; + vled-supply = <&vbatt>; +} + +For more product information please see the link below: +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf From patchwork Wed Nov 15 19:30:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 118990 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp3880825edl; Wed, 15 Nov 2017 11:31:14 -0800 (PST) X-Google-Smtp-Source: AGs4zMbMEmEGsHwmCrXDZAu0kEAHcV4su2K/dx8LjWQD1CHWb9Zd4JtbSqXwxEuMs881uR7ZEJ4s X-Received: by 10.101.80.10 with SMTP id f10mr7179544pgo.408.1510774274688; Wed, 15 Nov 2017 11:31:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510774274; cv=none; d=google.com; s=arc-20160816; b=BhsNRCB69v97F7YxkRv51o7OHBsuqcqP+CHhfZkKGQ3+97+k7SVRXej2u9aMEqnJ2u wGmvaxYjmLs6DUiDIKRUWiSCMX03N+TjSJkA6H1mPMCwDzUwl0bkxrf4PUGTU8DM7gWd jka3qOOS0S8FQI8zUiyquJ3zJEU47Cnm7lw43aiQXz1kdUWJ2Xcu1eQOOsJraTbL2ThJ VykDzw1NYaG4bI+E3mezsECFYNRQKAzEUCdyNsMUKC6KSTuz3c/WUL//eXuyIRbqHXkb D3HZ4SGBraG5yChyxc2xB4dfXWnlXoCgga7v5k0ZEmSCNf/tJ8Q6jGbRYZci94OFKWY0 v/hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Q0Q0iNz6dLCmHPZM4C1EedBLL2WYnzYNN61Km4Ni0rQ=; b=ub9uEOwRC+aU0Tv2Y9YqwrdatZORSo9R00WbgwkvZNupS1DBU9mi0hTt6MpUbi56MW rMqpXA7p5AilNO5KxQa6wU1sveR4T6vXMrw0nQWn2oN1EuOUMEUewLSe2DaDK6TSWZni xcX8s6KKV9422T0bvbtcLVLKCNMyEjf/B+UsFGEorORroeVljd6rOWpyLohBO2K6kFEu wXEmfLezdNGprKYzklKfx3/di9+TX+nHCc7OTAt/SImEj0sqMwaDNyls3alTadE8byVn uylbYT7u6L5Aoo0zqPuCi9amt6YXoH4P7f1TPKUqi0gS+ZiIbNoVdCQQ3upeO/K2yj6w gUVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=nRQBEXOu; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b89si18739912plb.556.2017.11.15.11.31.14 for ; Wed, 15 Nov 2017 11:31:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=nRQBEXOu; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933072AbdKOTbN (ORCPT ); Wed, 15 Nov 2017 14:31:13 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:41046 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932183AbdKOTbM (ORCPT ); Wed, 15 Nov 2017 14:31:12 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id vAFJUslI023965; Wed, 15 Nov 2017 13:30:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1510774254; bh=zWWjfUhKs/IBl9IirL/CCvTLFvGO7WaYaStOG7HDVhw=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=nRQBEXOuZrbNvEwrpG+vILQisrdHC6XQDcTA5rJjxFMSBwZuD3qOTh/Vm++ZH0WPc IzsKN0vZt6b8U9ouVvlaRTVaoURAhkKDd+mVhtra2brWIJ9ZMWJ/5lk5nF5YM+btUe +80n1WG/9DAr7ekAlsXWRvGuHsNfJT8dxEl4JBv4= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id vAFJUsH8027066; Wed, 15 Nov 2017 13:30:54 -0600 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Wed, 15 Nov 2017 13:30:54 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Wed, 15 Nov 2017 13:30:54 -0600 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id vAFJUsLV026922; Wed, 15 Nov 2017 13:30:54 -0600 Received: from localhost (a0272616local-lt.dhcp.ti.com [172.22.167.247]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id vAFJUs328432; Wed, 15 Nov 2017 13:30:54 -0600 (CST) From: Dan Murphy To: , , , , CC: , , , Dan Murphy Subject: [PATCH v2 2/2] leds: lm3692x: Introduce LM3692x dual string driver Date: Wed, 15 Nov 2017 13:30:31 -0600 Message-ID: <20171115193031.28781-2-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20171115193031.28781-1-dmurphy@ti.com> References: <20171115193031.28781-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Introducing the LM3692x Dual-String white LED driver. Data sheet is located http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf Signed-off-by: Dan Murphy --- v2 - Added data sheet link, fixed linuxdoc format, returned on failure in init routine, return on fault_check failure, updated brightness calculation and fixed capitalization issue - https://patchwork.kernel.org/patch/10056675/ drivers/leds/leds-lm3692x.c | 390 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 390 insertions(+) create mode 100644 drivers/leds/leds-lm3692x.c -- 2.15.0.124.g7668cbc60 diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c new file mode 100644 index 000000000000..9fa7f5a20466 --- /dev/null +++ b/drivers/leds/leds-lm3692x.c @@ -0,0 +1,390 @@ +/* + * TI lm3692x LED Driver + * + * Copyright (C) 2017 Texas Instruments + * + * Author: Dan Murphy + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * Data sheet is located + * http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define LM3692X_LED_NAME "lm3692x_led" + +#define LM3692X_REV 0x0 +#define LM3692X_RESET 0x1 +#define LM3692X_EN 0x10 +#define LM3692X_BRT_CTRL 0x11 +#define LM3692X_PWM_CTRL 0x12 +#define LM3692X_BOOST_CTRL 0x13 +#define LM3692X_AUTO_FREQ_HI 0x15 +#define LM3692X_AUTO_FREQ_LO 0x16 +#define LM3692X_BL_ADJ_THRESH 0x17 +#define LM3692X_BRT_LSB 0x18 +#define LM3692X_BRT_MSB 0x19 +#define LM3692X_FAULT_CTRL 0x1e +#define LM3692X_FAULT_FLAGS 0x1f + +#define LM3692X_SW_RESET BIT(0) +#define LM3692X_DEVICE_EN BIT(0) +#define LM3692X_LED1_EN BIT(1) +#define LM3692X_LED2_EN BIT(2) + +/* Brightness Control Bits */ +#define LM3692X_BL_ADJ_POL BIT(0) +#define LM3692X_RAMP_RATE_125us 0x00 +#define LM3692X_RAMP_RATE_250us BIT(1) +#define LM3692X_RAMP_RATE_500us BIT(2) +#define LM3692X_RAMP_RATE_1ms (BIT(1) | BIT(2)) +#define LM3692X_RAMP_RATE_2ms BIT(3) +#define LM3692X_RAMP_RATE_4ms (BIT(3) | BIT(1)) +#define LM3692X_RAMP_RATE_8ms (BIT(2) | BIT(3)) +#define LM3692X_RAMP_RATE_16ms (BIT(1) | BIT(2) | BIT(3)) +#define LM3692X_RAMP_EN BIT(4) +#define LM3692X_BRHT_MODE_REG 0x00 +#define LM3692X_BRHT_MODE_PWM BIT(5) +#define LM3692X_BRHT_MODE_MULTI_RAMP BIT(6) +#define LM3692X_BRHT_MODE_RAMP_MULTI (BIT(5) | BIT(6)) +#define LM3692X_MAP_MODE_EXP BIT(7) + +/* PWM Register Bits */ +#define LM3692X_PWM_FILTER_100 BIT(0) +#define LM3692X_PWM_FILTER_150 BIT(1) +#define LM3692X_PWM_FILTER_200 (BIT(0) | BIT(1)) +#define LM3692X_PWM_HYSTER_1LSB BIT(2) +#define LM3692X_PWM_HYSTER_2LSB BIT(3) +#define LM3692X_PWM_HYSTER_3LSB (BIT(3) | BIT(2)) +#define LM3692X_PWM_HYSTER_4LSB BIT(4) +#define LM3692X_PWM_HYSTER_5LSB (BIT(4) | BIT(2)) +#define LM3692X_PWM_HYSTER_6LSB (BIT(4) | BIT(3)) +#define LM3692X_PWM_POLARITY BIT(5) +#define LM3692X_PWM_SAMP_4MHZ BIT(6) +#define LM3692X_PWM_SAMP_24MHZ BIT(7) + +/* Boost Control Bits */ +#define LM3692X_OCP_PROT_1A BIT(0) +#define LM3692X_OCP_PROT_1_25A BIT(1) +#define LM3692X_OCP_PROT_1_5A (BIT(0) | BIT(1)) +#define LM3692X_OVP_21V BIT(2) +#define LM3692X_OVP_25V BIT(3) +#define LM3692X_OVP_29V (BIT(2) | BIT(3)) +#define LM3692X_MIN_IND_22UH BIT(4) +#define LM3692X_BOOST_SW_1MHZ BIT(5) +#define LM3692X_BOOST_SW_NO_SHIFT BIT(6) + +/* Fault Control Bits */ +#define LM3692X_FAULT_CTRL_OVP BIT(0) +#define LM3692X_FAULT_CTRL_OCP BIT(1) +#define LM3692X_FAULT_CTRL_TSD BIT(2) +#define LM3692X_FAULT_CTRL_OPEN BIT(3) + +/* Fault Flag Bits */ +#define LM3692X_FAULT_FLAG_OVP BIT(0) +#define LM3692X_FAULT_FLAG_OCP BIT(1) +#define LM3692X_FAULT_FLAG_TSD BIT(2) +#define LM3692X_FAULT_FLAG_SHRT BIT(3) +#define LM3692X_FAULT_FLAG_OPEN BIT(4) + +/** + * struct lm3692x_led - + * @lock - Lock for reading/writing the device + * @client - Pointer to the I2C client + * @led_dev - led class device pointer + * @regmap - Devices register map + * @enable_gpio - VDDIO/EN gpio to enable communication interface + * @regulator - LED supply regulator pointer + * @label - LED label + */ +struct lm3692x_led { + struct mutex lock; + struct i2c_client *client; + struct led_classdev led_dev; + struct regmap *regmap; + struct gpio_desc *enable_gpio; + struct regulator *regulator; + const char *label; +}; + +static const struct reg_default lm3692x_reg_defs[] = { + {LM3692X_EN, 0xf}, + {LM3692X_BRT_CTRL, 0x61}, + {LM3692X_PWM_CTRL, 0x73}, + {LM3692X_BOOST_CTRL, 0x6f}, + {LM3692X_AUTO_FREQ_HI, 0x0}, + {LM3692X_AUTO_FREQ_LO, 0x0}, + {LM3692X_BL_ADJ_THRESH, 0x0}, + {LM3692X_BRT_LSB, 0x7}, + {LM3692X_BRT_MSB, 0xff}, + {LM3692X_FAULT_CTRL, 0x7}, +}; + +static const struct regmap_config lm3692x_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + + .max_register = LM3692X_FAULT_FLAGS, + .reg_defaults = lm3692x_reg_defs, + .num_reg_defaults = ARRAY_SIZE(lm3692x_reg_defs), + .cache_type = REGCACHE_RBTREE, +}; + +static int lm3692x_fault_check(struct lm3692x_led *led) +{ + int ret, fault; + unsigned int read_buf; + + ret = regmap_read(led->regmap, LM3692X_FAULT_FLAGS, &read_buf); + if (ret) + return ret; + + fault = read_buf; + + if (fault) + dev_err(&led->client->dev, "Detected a fault 0x%X\n", + fault); + + return ret; +} + +static int lm3692x_brightness_set(struct led_classdev *led_cdev, + enum led_brightness brt_val) +{ + struct lm3692x_led *led = + container_of(led_cdev, struct lm3692x_led, led_dev); + int ret; + int led_brightness_lsb = (brt_val >> 5); + + mutex_lock(&led->lock); + + ret = lm3692x_fault_check(led); + if (ret) { + dev_err(&led->client->dev, "Cannot read/clear faults\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_BRT_MSB, brt_val); + if (ret) { + dev_err(&led->client->dev, "Cannot write MSB\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_BRT_LSB, led_brightness_lsb); + if (ret) { + dev_err(&led->client->dev, "Cannot write LSB\n"); + goto out; + } +out: + mutex_unlock(&led->lock); + return ret; +} + +static int lm3692x_init(struct lm3692x_led *led) +{ + int ret; + + if (led->regulator) { + ret = regulator_enable(led->regulator); + if (ret) + dev_err(&led->client->dev, + "Failed to enable regulator\n"); + goto out; + } + + if (led->enable_gpio) + gpiod_direction_output(led->enable_gpio, 1); + + ret = lm3692x_fault_check(led); + if (ret) { + dev_err(&led->client->dev, "Cannot read/clear faults\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_BRT_CTRL, 0x00); + if (ret) { + dev_err(&led->client->dev, "Fail writing BRT CTRL\n"); + goto out; + } + + /* + * For glitch free operation, the following data should + * only be written while device enable bit is 0 + * per Section 7.5.14 of the data sheet + */ + ret = regmap_write(led->regmap, LM3692X_PWM_CTRL, + LM3692X_PWM_FILTER_100 | LM3692X_PWM_SAMP_24MHZ); + if (ret) { + dev_err(&led->client->dev, "Failed programming PWM CTRL\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_BOOST_CTRL, + LM3692X_BRHT_MODE_RAMP_MULTI | + LM3692X_BL_ADJ_POL | + LM3692X_RAMP_RATE_250us); + if (ret) { + dev_err(&led->client->dev, "Failed programming BOOST CTRL\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_AUTO_FREQ_HI, 0x00); + if (ret) { + dev_err(&led->client->dev, "Failed programming AUTO HI FREQ\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_AUTO_FREQ_LO, 0x00); + if (ret) { + dev_err(&led->client->dev, "Failed programming AUTO LO FREQ\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_BL_ADJ_THRESH, 0x00); + if (ret) { + dev_err(&led->client->dev, "Failed programming BL Threshold\n"); + goto out; + } + + ret = regmap_write(led->regmap, LM3692X_BRT_CTRL, + LM3692X_BL_ADJ_POL | LM3692X_PWM_HYSTER_4LSB); + if (ret) + dev_err(&led->client->dev, "Failed programming BRT CTRL\n"); + + return ret; +out: + + if (led->enable_gpio) + gpiod_direction_output(led->enable_gpio, 0); + + if (led->regulator) { + ret = regulator_disable(led->regulator); + if (ret) + dev_err(&led->client->dev, + "Failed to disable regulator\n"); + } + + return ret; +} + +static int lm3692x_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + int ret; + struct lm3692x_led *led; + struct device_node *np = client->dev.of_node; + + led = devm_kzalloc(&client->dev, sizeof(*led), GFP_KERNEL); + if (!led) + return -ENOMEM; + + if (client->dev.of_node) { + ret = of_property_read_string(np, "label", &led->label); + if (ret) + led->label = LM3692X_LED_NAME; + } + + led->enable_gpio = devm_gpiod_get_optional(&client->dev, + "enable", GPIOD_OUT_LOW); + if (IS_ERR(led->enable_gpio)) { + ret = PTR_ERR(led->enable_gpio); + dev_err(&client->dev, "Failed to get enable gpio: %d\n", ret); + return ret; + } + + led->regulator = devm_regulator_get(&client->dev, "vled"); + if (IS_ERR(led->regulator)) + led->regulator = NULL; + + led->client = client; + led->led_dev.name = led->label; + led->led_dev.max_brightness = LED_FULL; + led->led_dev.brightness_set_blocking = lm3692x_brightness_set; + + mutex_init(&led->lock); + + i2c_set_clientdata(client, led); + + led->regmap = devm_regmap_init_i2c(client, &lm3692x_regmap_config); + if (IS_ERR(led->regmap)) { + ret = PTR_ERR(led->regmap); + dev_err(&client->dev, "Failed to allocate register map: %d\n", + ret); + return ret; + } + + ret = lm3692x_init(led); + if (ret) + return ret; + + ret = led_classdev_register(&client->dev, &led->led_dev); + if (ret) { + dev_err(&client->dev, "led register err: %d\n", ret); + return ret; + } + + return 0; +} + +static int lm3692x_remove(struct i2c_client *client) +{ + struct lm3692x_led *led = i2c_get_clientdata(client); + int ret; + + led_classdev_unregister(&led->led_dev); + + if (led->enable_gpio) + gpiod_direction_output(led->enable_gpio, 0); + + if (led->regulator) { + ret = regulator_disable(led->regulator); + if (ret) + dev_err(&led->client->dev, + "Failed to disable regulator\n"); + } + + return 0; +} + +static const struct i2c_device_id lm3692x_id[] = { + { "lm3692x", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, lm3692x_id); + +#ifdef CONFIG_OF +static const struct of_device_id of_lm3692x_leds_match[] = { + { .compatible = "ti,lm3692x", }, + {}, +}; +MODULE_DEVICE_TABLE(of, of_lm3692x_leds_match); +#endif + +static struct i2c_driver lm3692x_driver = { + .driver = { + .name = "lm3692x", + .of_match_table = of_match_ptr(of_lm3692x_leds_match), + }, + .probe = lm3692x_probe, + .remove = lm3692x_remove, + .id_table = lm3692x_id, +}; +module_i2c_driver(lm3692x_driver); + +MODULE_DESCRIPTION("Texas Instruments LM3692X LED driver"); +MODULE_AUTHOR("Dan Murphy "); +MODULE_LICENSE("GPL");