From patchwork Tue Oct 6 14:13:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 284828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F2BC4363D for ; Tue, 6 Oct 2020 14:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72E3620782 for ; Tue, 6 Oct 2020 14:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601993591; bh=AzW2h7m1+8+R+eXyNgkeytCbOkzLE5LkNMgglOpNI3I=; h=From:To:Cc:Subject:Date:List-ID:From; b=oShrJ4ydFGqvJYsTKGMpq/fzdZWeOHR8ffdypL2hCUC4IZpJMm2CTVZ81lZoU3iRQ fC757GawtFPJVEoPXRXST55svg91w35yOOnObNCMb164A7uL5kN0pwYgNK81R0zVON FGs8si3Q1iXo/WpivDC6Byn9strHyCAi9S8KMdSE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725962AbgJFONK (ORCPT ); Tue, 6 Oct 2020 10:13:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:41684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbgJFONK (ORCPT ); Tue, 6 Oct 2020 10:13:10 -0400 Received: from tleilax.com (68-20-15-154.lightspeed.rlghnc.sbcglobal.net [68.20.15.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F36420760; Tue, 6 Oct 2020 14:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601993589; bh=AzW2h7m1+8+R+eXyNgkeytCbOkzLE5LkNMgglOpNI3I=; h=From:To:Cc:Subject:Date:From; b=gJcDtzfnfI01Q1pVvad0TQSAhJ6++Plnztr+aRvh+wXNUW90q/DkRL5nTh1TEbpjg EGwXmvZYJCINAHirfX+ZHUjlsqV0FWPWIw28bYeGnvwq5jkvYQY2dcyMQn7wI9M+dR AWhtbCjc2M516MHkIIKsAnx65R7C7PmAQHWVLP5Q= From: Jeff Layton To: ceph-devel@vger.kernel.org Cc: willy@infradead.org, idryomov@gmail.com, ukernel@gmail.com Subject: [PATCH] ceph: don't SetPageError on readpage errors Date: Tue, 6 Oct 2020 10:13:07 -0400 Message-Id: <20201006141307.309650-1-jlayton@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org PageError really only has meaning within a particular subsystem. Nothing looks at this bit in the core kernel code, and ceph itself doesn't care about it. Don't bother setting the PageError bit on error. Cc: Matthew Wilcox Signed-off-by: Jeff Layton Reviewed-by: Matthew Wilcox (Oracle) --- fs/ceph/addr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 97827f68a3e7..137c0a5a2a0d 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -241,7 +241,6 @@ static int ceph_do_readpage(struct file *filp, struct page *page) if (err == -ENOENT) err = 0; if (err < 0) { - SetPageError(page); ceph_fscache_readpage_cancel(inode, page); if (err == -EBLOCKLISTED) fsc->blocklisted = true;