From patchwork Thu Nov 23 13:18:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 119517 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp806842qgn; Thu, 23 Nov 2017 05:19:54 -0800 (PST) X-Google-Smtp-Source: AGs4zMa5cM3Ray3cMdEDkQQKy0sMnE+hgsVcyblqNaYSEEG3FPKWLNjOwl4nYzEWilqJdABkvIdy X-Received: by 10.98.247.4 with SMTP id h4mr22850132pfi.16.1511443193981; Thu, 23 Nov 2017 05:19:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511443193; cv=none; d=google.com; s=arc-20160816; b=pepuZhcXDONu97S0GIwKhLDgD8OsZB+hXvnDq+oJzBix1t3y3tbEpQ+CFdTKTokb/F 6hzpUyORlUL96MDqIsFyhgrKzvIGgRRKu/mqX4tLOPeNd3TM9hL0r/mnD7uAn1fL+hvB fxUdpMhfQ17Js6clEGWKBNsPUimwLjs4pcj9hZReWEAqF0BFeeG0H9zX2bMSK9xe9OAJ /uM0JzVF3YUrP19FXppH8q9CVyf8qUpGfN2p7ZMrsi/80cSuHAjS0GtJ6QESUPO4WOnR Zr5EhOpsGAEm7DaH/3fi8AtKmWE87/LdW74tkvVQ9ZbHo0vjA4pNAN15hQTc8CAOk80L ntdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:dkim-signature :dkim-filter:dkim-signature:arc-authentication-results; bh=OSE/8GeRleLOItlkQxIqkPTVSVjiEeu/6rxOXOJNE9w=; b=eDhPy9Qoj7iruZZnEkxyRD9UCtef+0SDLEZ+VrSHRETXVknKrrpg3IIc4kq//DnR1M uHVQ6cPvzFXXCzQ89pNig7yjZA5OMyKQxHMoE4oTe8JARJDnosQaQi1dNZCn+FJQ3ayd LwaHu4SdimDx5x97OfQerS3To6kvDuW+jpuNP3siT1pA/fpnqM1hZncKD2X8rkWwcsbn sjAUNRr659wC2Xvz51chgAwtLwFRT6K3ku4X/ozENYYNeYwmsx1q3G4VT0hSA0mkjapb Ui5J9QEe06o2eb7GBafjLZpGfbhWvU9jC3X29uRY7UmqlDiQ95o4Xo8GVcsfEUXnZbzc p/+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=IUH8PiNx; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=xwrZbcVz; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=linux-mtd-bounces+patch=linaro.org@lists.infradead.org Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [65.50.211.133]) by mx.google.com with ESMTPS id r39si5847238pld.235.2017.11.23.05.19.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2017 05:19:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) client-ip=65.50.211.133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=IUH8PiNx; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=xwrZbcVz; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=linux-mtd-bounces+patch=linaro.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=OSE/8GeRleLOItlkQxIqkPTVSVjiEeu/6rxOXOJNE9w=; b=IUH 8PiNxG4rdnSHttvMQsHroAuJjBVs86868l0Seoq8eQdblRY80Wub3UYElFXlQdXwdtyhCwpqBaVA4 y32srApi0GvH3ghQ9fZcNW2VszOsb06O0kNxP1OcpHJnglNC8KXYUZ4fweWFzoKJE4kY0A9GN/iaY RdmH5fdx9O8FSKzY4a+O1VeTEn6eUOTLcdpyYQaTJO8hqVlll+rUU5dio4bZm8r8eGgYcBRLpRZvj /nZgWMIqwYKl472aITXVbzaJQwayh/v+TgbIBWUDu8cHmfE5Nz9OguBLKKXJkMtlKOEDG38JspZzQ o7Ve6UyCOfpJ8Ewxy4Liv/LcbCBDljw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eHrPs-0002nW-Dd; Thu, 23 Nov 2017 13:19:44 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eHrPo-0002me-34 for linux-mtd@lists.infradead.org; Thu, 23 Nov 2017 13:19:42 +0000 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-07.nifty.com with ESMTP id vANDItMc014281; Thu, 23 Nov 2017 22:18:55 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com vANDItMc014281 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1511443136; bh=cvNmrxNTBVkrmqHW3wb3slur02iE5E4DsVgSypjac0g=; h=From:To:Cc:Subject:Date:From; b=xwrZbcVzfine1g0w7J9X2LAKCONejw1z4hMz2BgveO09ZqgWge21+qF9ZD6Rv6ifs yBB+S5yeKLLHxTn6kOsvL8NepWdeXgkcwI6b3b07NDb6970szssGcIVjB9mLjBZ/IJ mUV6U3rxyXgawU45IURnIX402bvaeZUz3vUhyJIYLt42AakyJVEQVXWRlJuE1LL6PS LJ1XYUOFUXtMKlDiEUPw69IWn7XoqQWNGiIYIsmPPsoRECxZ8NEUxLGY2La11febmd PvY9RVlTLU3+XQ74vPvzxSJEZFI++sAIgNCAKVHIr02hG08lUv8GwQmu4/dT6xW4FD cMYmG89Wa+9vw== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Boris Brezillon Subject: [PATCH] mtd: nand: remove unnecessary extern from driver headers Date: Thu, 23 Nov 2017 22:18:43 +0900 Message-Id: <1511443123-30525-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171123_051940_483198_6A2A6407 X-CRM114-Status: UNSURE ( 9.02 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Richard Weinberger , linux-kernel@vger.kernel.org, Masahiro Yamada , Cyrille Pitchen , Han Xu , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org 'extern' is not necessary for function declarations. scripts/checkpatch.pl with --strict option reports the following: CHECK: extern prototypes should be avoided in .h files Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/denali.h | 4 +-- drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 46 +++++++++++++++++----------------- drivers/mtd/nand/sm_common.h | 2 +- 3 files changed, 26 insertions(+), 26 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h index 2911066..9ad33d2 100644 --- a/drivers/mtd/nand/denali.h +++ b/drivers/mtd/nand/denali.h @@ -329,7 +329,7 @@ struct denali_nand_info { #define DENALI_CAP_DMA_64BIT BIT(1) int denali_calc_ecc_bytes(int step_size, int strength); -extern int denali_init(struct denali_nand_info *denali); -extern void denali_remove(struct denali_nand_info *denali); +int denali_init(struct denali_nand_info *denali); +void denali_remove(struct denali_nand_info *denali); #endif /* __DENALI_H__ */ diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.h b/drivers/mtd/nand/gpmi-nand/gpmi-nand.h index a45e4ce..06c1f99 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.h +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.h @@ -268,31 +268,31 @@ struct timing_threshold { }; /* Common Services */ -extern int common_nfc_set_geometry(struct gpmi_nand_data *); -extern struct dma_chan *get_dma_chan(struct gpmi_nand_data *); -extern void prepare_data_dma(struct gpmi_nand_data *, - enum dma_data_direction dr); -extern int start_dma_without_bch_irq(struct gpmi_nand_data *, - struct dma_async_tx_descriptor *); -extern int start_dma_with_bch_irq(struct gpmi_nand_data *, - struct dma_async_tx_descriptor *); +int common_nfc_set_geometry(struct gpmi_nand_data *); +struct dma_chan *get_dma_chan(struct gpmi_nand_data *); +void prepare_data_dma(struct gpmi_nand_data *, + enum dma_data_direction dr); +int start_dma_without_bch_irq(struct gpmi_nand_data *, + struct dma_async_tx_descriptor *); +int start_dma_with_bch_irq(struct gpmi_nand_data *, + struct dma_async_tx_descriptor *); /* GPMI-NAND helper function library */ -extern int gpmi_init(struct gpmi_nand_data *); -extern int gpmi_extra_init(struct gpmi_nand_data *); -extern void gpmi_clear_bch(struct gpmi_nand_data *); -extern void gpmi_dump_info(struct gpmi_nand_data *); -extern int bch_set_geometry(struct gpmi_nand_data *); -extern int gpmi_is_ready(struct gpmi_nand_data *, unsigned chip); -extern int gpmi_send_command(struct gpmi_nand_data *); -extern void gpmi_begin(struct gpmi_nand_data *); -extern void gpmi_end(struct gpmi_nand_data *); -extern int gpmi_read_data(struct gpmi_nand_data *); -extern int gpmi_send_data(struct gpmi_nand_data *); -extern int gpmi_send_page(struct gpmi_nand_data *, - dma_addr_t payload, dma_addr_t auxiliary); -extern int gpmi_read_page(struct gpmi_nand_data *, - dma_addr_t payload, dma_addr_t auxiliary); +int gpmi_init(struct gpmi_nand_data *); +int gpmi_extra_init(struct gpmi_nand_data *); +void gpmi_clear_bch(struct gpmi_nand_data *); +void gpmi_dump_info(struct gpmi_nand_data *); +int bch_set_geometry(struct gpmi_nand_data *); +int gpmi_is_ready(struct gpmi_nand_data *, unsigned chip); +int gpmi_send_command(struct gpmi_nand_data *); +void gpmi_begin(struct gpmi_nand_data *); +void gpmi_end(struct gpmi_nand_data *); +int gpmi_read_data(struct gpmi_nand_data *); +int gpmi_send_data(struct gpmi_nand_data *); +int gpmi_send_page(struct gpmi_nand_data *, + dma_addr_t payload, dma_addr_t auxiliary); +int gpmi_read_page(struct gpmi_nand_data *, + dma_addr_t payload, dma_addr_t auxiliary); void gpmi_copy_bits(u8 *dst, size_t dst_bit_off, const u8 *src, size_t src_bit_off, diff --git a/drivers/mtd/nand/sm_common.h b/drivers/mtd/nand/sm_common.h index d3e028e..1581671 100644 --- a/drivers/mtd/nand/sm_common.h +++ b/drivers/mtd/nand/sm_common.h @@ -36,7 +36,7 @@ struct sm_oob { #define SM_SMALL_OOB_SIZE 8 -extern int sm_register_device(struct mtd_info *mtd, int smartmedia); +int sm_register_device(struct mtd_info *mtd, int smartmedia); static inline int sm_sector_valid(struct sm_oob *oob)