From patchwork Mon Nov 27 18:53:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 119780 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp2104985edl; Mon, 27 Nov 2017 10:59:04 -0800 (PST) X-Google-Smtp-Source: AGs4zMYZV0SmN+jfPT7EJDMqEj7TIj5C+/4STFrOiGxyDMkqeU0NGtsElQCGWpbGFABr65scZysG X-Received: by 10.223.191.13 with SMTP id p13mr35546857wrh.69.1511809144713; Mon, 27 Nov 2017 10:59:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511809144; cv=none; d=google.com; s=arc-20160816; b=vKB9WSfXjP5g8r6RCM+8vownEP7H/Tp/HHA1Ojkj3WcjwssK2UJoeMyPPveCK2KvxH S5HTlt9Y2v4tp1LOOL2B4S0Ano/gbjOD8x7dF9Ki//tH5Md3Lt6ilcrlB4tqRV5HcUDN sMFFT8kqHw21/CK1hJn+jZNi01S6IRuIIcHclbodTG2IcEY7ET0IjyHWXb7Bvt/XGngT u9eLoQZgH7siKe4o8mKZansRT9VzaOTwqKDz4KgWdHHomRpH9T82lfZ+NEdQkJTDkPre YKyLPuVQWfXN3HMET1BBuGmgZEo5Jq+6MFZN18qnf95fH4VEj68/Ct1QfuC1gx0xw4Hd 7QkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=5QsoWjM+ByWwJ6c3Nhd82RmVjdVDIbFLu7yeyQP3nr0=; b=ix62RZS5LvMf2+0rKV8XAS83ghxdMsTa1Ia/9/8aMFLpc838/pVCmB4O2OMidb96tF 4g1u8u8mZhBUAyPozGE7WXARo9LZMzKTsZZFbMu9UhmoyPWdmoR3onsh7foETqtn8K3n PDtz/bLAkuI9dNTFJjg4XLRRCLtsd9RgDknc0KQa0lwbx+HmCZzNfaSHXYAQqZl25ndX LzNJq5nD5aJHaEpai/ZLDCpAN104Bdvgg9CfkMpAMi/heo6di8WW2egBjW+6u+ATgPRT kbZbFnVXs3H9pa3urO0oG/zs6AGxC3p5y5EINtn3hfFfNfMNkBKv9jfmLd/o1E3fIzU7 Qavg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BrYR2aFH; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id z72si12026125wmz.39.2017.11.27.10.59.04; Mon, 27 Nov 2017 10:59:04 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BrYR2aFH; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D86402676FD; Mon, 27 Nov 2017 19:54:47 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3FE97267700; Mon, 27 Nov 2017 19:54:46 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 2B148267632 for ; Mon, 27 Nov 2017 19:53:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=iKIALAneUs88yTjen0Se2llTRmB4inuIdpxW7uw7f3k=; b=BrYR2aFHTp0P OsS6UXthItpnd8mQnyZ3CuEZBDiM9SMDBPrMacBT3VrLvmPlL9NTx0wp9iaiqQs7SdjRJSJt2vJ0C wIN+sS6KBw+3nPsHpnbgv9/lx3c3yhwg4GNkTmrbdHG2y6NBeTlbClkIp854THgW/WqewDPIVTwto O5kaU=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eJOX6-00073k-Mq; Mon, 27 Nov 2017 18:53:32 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1eJOX6-0007KI-A3; Mon, 27 Nov 2017 18:53:32 +0000 From: Mark Brown To: Benson Leung In-Reply-To: Message-Id: Date: Mon, 27 Nov 2017 18:53:32 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: ts3a227e: Map BTN_0 to KEY_PLAYPAUSE" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: ts3a227e: Map BTN_0 to KEY_PLAYPAUSE has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From af0f6c5820845b66c76296f281da5cf916d7e094 Mon Sep 17 00:00:00 2001 From: Benson Leung Date: Wed, 22 Nov 2017 12:56:41 -0800 Subject: [PATCH] ASoC: ts3a227e: Map BTN_0 to KEY_PLAYPAUSE The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support. For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle play/pause of videos and audio, but does not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung Signed-off-by: Mark Brown --- sound/soc/codecs/ts3a227e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c index 738e04b09116..1271e7e1fc78 100644 --- a/sound/soc/codecs/ts3a227e.c +++ b/sound/soc/codecs/ts3a227e.c @@ -241,7 +241,7 @@ int ts3a227e_enable_jack_detect(struct snd_soc_component *component, { struct ts3a227e *ts3a227e = snd_soc_component_get_drvdata(component); - snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA); + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);