From patchwork Thu Nov 30 21:17:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 120278 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp310534qgn; Thu, 30 Nov 2017 13:19:25 -0800 (PST) X-Google-Smtp-Source: AGs4zMbh+H703jNjxkdkWGQE+Ga4cKtpjSqDQONqcgVPVZ3Lr5rlNRAAnRB3MwoG/BjyGQltLO45 X-Received: by 10.84.218.72 with SMTP id f8mr4026286plm.143.1512076765620; Thu, 30 Nov 2017 13:19:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512076765; cv=none; d=google.com; s=arc-20160816; b=RGaSwOOC2vTk3GQqIwMdd2MruJZWy10qyJesDjl5Z7MC7osJcmc6XDoFmvexKimfE3 O8vpeyy7T25Upfcz9G76UDE5oxvpQf7KtJKb8Sb9zqjNwfSN7tKZCAEnlaAuGhFMXwUz XzSFJYFVD4kzqp4faDuw1djqZKENTscFYIoa8BYNqv4FpNcygE6vebYIhom22g7WwDOJ 9tyhASMINMkQcqTG+fA7kbUkYnw1AQNWiN3W2UlNspvda8kf0M6Pes5uVnEHy9jH7GzR R9E8b4oALEfP9GI0rWLI2Tmto/R99hMEZ4IhSNJofgChIIgLG/1DiAxiwENWj7n0H/lK MbPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=SjEMjFPQgpUPpzCALZqsDbkqtKwwK4DaV7s6tlO/Umk=; b=X/Z8KuXqoFokq99QSjvcpB0dabuEbEa6XJ4nYN8oOPX6IUq4Bhm7GqHqMRjiiDDog1 9eT1Wf1GYnd6CrUQRhmAcqDXtZUFz1n5DDsHWyA6Ul5GrBEAbIX2pu4bdG5y4RWGJXbd 6whkhe91Wo8zc5fAhJJ/DpwEAXd5u7HjMGL6Ou/wqZ2quX5w/r/jOyqRew5QeOksX7dI aB6I1jYx4G3NosdoT+gDLjGD5upNhGmDqpXQs0SN4ojJSNBEdJl6Z2DCqmTGbCj8bvqA /nIPlAhJkTrNMj/vQpeEqGiMYWrMgJEU6eS5483BAP2sNnY/fRya5RqspL5+PS7f0CgM 8pEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=OxTwvGbK; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p22si3572353pgn.634.2017.11.30.13.19.25; Thu, 30 Nov 2017 13:19:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=OxTwvGbK; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750898AbdK3VTY (ORCPT + 6 others); Thu, 30 Nov 2017 16:19:24 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:44063 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbdK3VTY (ORCPT ); Thu, 30 Nov 2017 16:19:24 -0500 Received: by mail-lf0-f66.google.com with SMTP id x204so9458111lfa.11 for ; Thu, 30 Nov 2017 13:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Btdf2e0HegdNYMY5ammufeVOa5UR0mggaLXlSXhowSk=; b=OxTwvGbKHSIu5y0pF+50NiCd2n5RRacQxpoZiWvyKYwdrAX16/3XwbS8NIMp25Naje 9BmZeXtVcNkUTWOlaAI4JxFCKzd7VJJuFdR0Qz2Vt7wdHO53RvBVyTDqogJsHc9SijDn 7+cxZLs8oExk5qzABwvBLdCUkILmqBRLNf8hg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Btdf2e0HegdNYMY5ammufeVOa5UR0mggaLXlSXhowSk=; b=mJUhHJARXqtWASTilkvLaSJfg4yso23VwDvgX0lLKnP4gpFsGscNITVF5D3hBLM8yz 5yRQJTVF2h5sxGusFeiYaOlQkmP+gmYVrSALABx8u7aYweNbT0txp7rEdYX4WINWTaUn Bd2iLeIEISpSVtb3dBGxPDm5ZF+uwaga0HGMlLmes2Tcg14RqD00PmyATfAedTeacjeG DtX7jkakby8ihD3u0fObs7nRPY01cWE28UMusXT+lzYIG8gW6tGnaQ6VyNRawgooGW/D 3GRllb8eGUr57QtfpfEzO1i9LJ0rOtQEInpPoZ6HFlUczvmquo+R87XxrGNZAEq6OT4s 1HqQ== X-Gm-Message-State: AJaThX4XdKs0yQtOLNkoArrwF8ycUg8EdPYRm+hlB3C7dA37Dq0W4H9k nwyTRjfycEQMDWqPyhQ5tnNPswkWzvk= X-Received: by 10.46.56.8 with SMTP id f8mr4078668lja.46.1512076762606; Thu, 30 Nov 2017 13:19:22 -0800 (PST) Received: from localhost.localdomain (c-567171d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.113.86]) by smtp.gmail.com with ESMTPSA id z81sm883469lff.80.2017.11.30.13.19.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 13:19:21 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org, Alexandre Courbot Cc: Linus Walleij Subject: [PATCH] gpio: ftgpio010: Fix some more registers Date: Thu, 30 Nov 2017 22:17:18 +0100 Message-Id: <20171130211718.8074-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.14.3 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There is a register for "bypass" which seems to not be used for anything in some silicon designs, but may be used in others, and there is both a raw and masked interrupt status register. Define them all for clarity, no semantic changes. Signed-off-by: Linus Walleij --- drivers/gpio/gpio-ftgpio010.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c index 7b3394fdc624..aa825925db52 100644 --- a/drivers/gpio/gpio-ftgpio010.c +++ b/drivers/gpio/gpio-ftgpio010.c @@ -21,12 +21,14 @@ #define GPIO_DATA_OUT 0x00 #define GPIO_DATA_IN 0x04 #define GPIO_DIR 0x08 +#define GPIO_BYPASS_IN 0x0C #define GPIO_DATA_SET 0x10 #define GPIO_DATA_CLR 0x14 #define GPIO_PULL_EN 0x18 #define GPIO_PULL_TYPE 0x1C #define GPIO_INT_EN 0x20 -#define GPIO_INT_STAT 0x24 +#define GPIO_INT_STAT_RAW 0x24 +#define GPIO_INT_STAT_MASKED 0x28 #define GPIO_INT_MASK 0x2C #define GPIO_INT_CLR 0x30 #define GPIO_INT_TYPE 0x34 @@ -147,7 +149,7 @@ static void ftgpio_gpio_irq_handler(struct irq_desc *desc) chained_irq_enter(irqchip, desc); - stat = readl(g->base + GPIO_INT_STAT); + stat = readl(g->base + GPIO_INT_STAT_RAW); if (stat) for_each_set_bit(offset, &stat, gc->ngpio) generic_handle_irq(irq_find_mapping(gc->irq.domain,