From patchwork Mon Dec 18 09:44:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 122199 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2614039qgn; Mon, 18 Dec 2017 01:48:24 -0800 (PST) X-Google-Smtp-Source: ACJfBovLYoVX7RX9mIcjtS0MALOdLFu0ZPBeEKAGJEpRU6sn/Rz1UTBGAvafvg9AbDDe0gLJMWbg X-Received: by 10.84.129.7 with SMTP id 7mr6477672plb.104.1513590504089; Mon, 18 Dec 2017 01:48:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513590504; cv=none; d=google.com; s=arc-20160816; b=ZyOmPY9D3NwMDRUbWQY8TNMuPlGHCiVg38rxU9Bgje1N9AaN0vFKJIgBG0Ec9/ZakV qzs6Xmu57E3Z9Cec+6wbiBhAAvV6W11LZ/JfhxUi1sbBWlcT8yT3lXgmWOa5Ps4ZcDlp VS+YIFJak+ibSC+AG6FFeLnx8wjORf90736gBk7kCv/vU25NYO7IBKJ7+cVsJ2M5blDj 5VrzQlDM9XiV169K76/DNh5Bj6IIRNSkQWxcLtC4A+wmW+u7++urTBa/TWD1aECaRrg0 KY/r4zh43xDePhk7/Af8I44r7e7PCBWOxqPYTrSxys7GLlAQDeTEFKmn3QFknY36NFmz 6bQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=69M9Tk3sFtCpyNWDmoteGESV5/X+JnhQXIYqKSnGztU=; b=Za8D096vZWp+fKHl+tgasw51Hkh89nBDyBQxR2UHZcJ6fTvruo12P5+1AXCF6o8gDq VQqMzRYxJFQeprmUpUI4K+VCF3+0z45mYKebJDfL1uCNq7uv2rmzDKV7HPMU5zL7oYkK MLDBc9hdyqz5rBQ11d2XFEmeJBGlPDlY/P2Wg865daPCzFrh44WfBm11k+cHq7ZiqFqT e+Mje3SvMHh+vk9svSp/7Qs6ce/RJwwnEN7u+t2b0ZwzkZjuaGy9upS08ivkaYWrCCDg yCJNKaz2bZ0WaWL8Uv8+vHFEx11M23crx1lvAvvSvjGcUfdNdEm8N2cNWpEz5h1Orxd9 Z3Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=DC99hJIR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc11si8990898plb.84.2017.12.18.01.48.23; Mon, 18 Dec 2017 01:48:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=DC99hJIR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933751AbdLRJsR (ORCPT + 28 others); Mon, 18 Dec 2017 04:48:17 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37997 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758384AbdLRJoy (ORCPT ); Mon, 18 Dec 2017 04:44:54 -0500 Received: by mail-wm0-f65.google.com with SMTP id 64so28048784wme.3 for ; Mon, 18 Dec 2017 01:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=69M9Tk3sFtCpyNWDmoteGESV5/X+JnhQXIYqKSnGztU=; b=DC99hJIRuj/R5QwZQfzwJIq7FKEOlxXQx871nUKdT2pk5PMZPqIfJk1qmQccKZWCGn 6DQDPFEvzJOpghs28NNEhqp296R5+j9ZtHZruVZQ/yAx5sOXWFhYJodiQRcF+BAPnScJ 6wdkDmnvjyNCU4ZW/gvUmgx79rK2lMBlQE/9b1n07JkxEpGO+EWWw9ac88njsIwZZOmc x+vm8EvuLyJikBBxoBX/gnkgglkr3nrGKqHVWS+8Zf0oWzG+hwErJ9Sm0dquJ8YIFez2 IbrKIopXmfb7tbPzX2FqUsPQZN8QXJf+DwR50Y7M4/shfi8bImbNjJl8zR0im+Vimwh2 jrFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=69M9Tk3sFtCpyNWDmoteGESV5/X+JnhQXIYqKSnGztU=; b=l10+ohNZBJ/bwQ6oixgZv2k1oA6Ju53YSkQ45nkp/k10EvDyJzIMTZEit//ZkCkz21 YlYh2WT0evb2qL3XzDIHpzqUp7dAIYCH8E2+tdQpM7e2EzHyly8k/QvC0SHD76Az4aN+ jYbvENv1FFTts4iPf11PP1GODjiFhdleTsnMhtSn+PQ14T5VaDdYfLYa0Lj03sOKA3IG uDreL76NGQqxRujHv0xmKKg0ncAlNi3KFgcIatpNj6YRIysuJ/B3CIIGlC0lt+TTWImH voMOJ7HLcwKlDiWAJL/ftaVtYiDwKjDR4fY4wqE/KGs15N0bDqjwASWFqZu0iNSSuBxA QAcQ== X-Gm-Message-State: AKGB3mIvNlw5xSwDeKOnXBvGhzeUJFGtzgs0mbning/v0XEvxklxryIm R9YIHFXmY7FYyK1XdmmI74gxEA== X-Received: by 10.28.170.75 with SMTP id t72mr10772808wme.15.1513590293402; Mon, 18 Dec 2017 01:44:53 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:52 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 1/7] net: phy: meson-gxl: check phy_write return value Date: Mon, 18 Dec 2017 10:44:40 +0100 Message-Id: <20171218094446.31912-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Always check phy_write return values. Better to be safe than sorry Reviewed-by: Andrew Lunn Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 50 ++++++++++++++++++++++++++++++++++----------- 1 file changed, 38 insertions(+), 12 deletions(-) -- 2.14.3 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 4ee630afe43a..900606204c0a 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -26,27 +26,53 @@ static int meson_gxl_config_init(struct phy_device *phydev) { + int ret; + /* Enable Analog and DSP register Bank access by */ - phy_write(phydev, 0x14, 0x0000); - phy_write(phydev, 0x14, 0x0400); - phy_write(phydev, 0x14, 0x0000); - phy_write(phydev, 0x14, 0x0400); + ret = phy_write(phydev, 0x14, 0x0000); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0400); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0000); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0400); + if (ret) + return ret; /* Write Analog register 23 */ - phy_write(phydev, 0x17, 0x8E0D); - phy_write(phydev, 0x14, 0x4417); + ret = phy_write(phydev, 0x17, 0x8E0D); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x4417); + if (ret) + return ret; /* Enable fractional PLL */ - phy_write(phydev, 0x17, 0x0005); - phy_write(phydev, 0x14, 0x5C1B); + ret = phy_write(phydev, 0x17, 0x0005); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1B); + if (ret) + return ret; /* Program fraction FR_PLL_DIV1 */ - phy_write(phydev, 0x17, 0x029A); - phy_write(phydev, 0x14, 0x5C1D); + ret = phy_write(phydev, 0x17, 0x029A); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1D); + if (ret) + return ret; /* Program fraction FR_PLL_DIV1 */ - phy_write(phydev, 0x17, 0xAAAA); - phy_write(phydev, 0x14, 0x5C1C); + ret = phy_write(phydev, 0x17, 0xAAAA); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1C); + if (ret) + return ret; return 0; } From patchwork Mon Dec 18 09:44:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 122197 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2612754qgn; Mon, 18 Dec 2017 01:46:42 -0800 (PST) X-Google-Smtp-Source: ACJfBosRJUR/BkfV1mUIz/t8AcmIsdvHNL+xnsNiWo+ttuIdtlBaPEj9/WM7deFU1XmWh/TRmBDd X-Received: by 10.101.98.1 with SMTP id d1mr7383115pgv.18.1513590402568; Mon, 18 Dec 2017 01:46:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513590402; cv=none; d=google.com; s=arc-20160816; b=tbh5vVLALRixZHsH8kUFxaWO2uAB8R8/edX7MzKF/Vm5Ik58Tdae/3mJKGvWt5PNo/ q/QljmJjj27DzbcLXFiNvqjxsGNJQfgwqsW+UBtxbHMwEkrazod3HrMoIHAM1WZjxDmG w+aZnsREmI7gcWzlQGZJEssOGsZQyeejKrWBVOiVwpqKkdYMxfGTcgOa4xZsnTuM+gx+ evTLT4hoS6mqNUCrctTEtM7UGJJfaDQEa7BF6kLTZu7Obut2Hp4ARKMWqmK8hShElN2d zA18mXzfkgfKd0BQ4sTF3Ib5h8odEzTehlm0ckM6xmWQThzq4qzoVyDIg2fkm6UtSDrn LAfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=OLwJmgeUD3P0dRekE26KfH4G/1faj8pe7pF1iavmTnM=; b=yZV7RFSGHvctOMAqdz1foEFBySEL/X5ifbf9MVIw4hobQw+7/yQEfpC5UsMX7NFzN5 ZOlu+EWv0fi0q35RRqj3VGWLxbgG9iwIDQONbs4p8w+C2KSUB2DMDXfGp0RBuTWbPpMI lI4d4SPDeWAJcoSaXseJD4tUKLkIWBF2BXo62B5wh7909HHqI15sK/Tiu551+102ryix GzlzwOdSwxlYpMiS5M9lA37VVBeE5jSV4nQxEGC+5ic4aaLDmWbQFRiuINJvLln/HcVy rK9DBaIwDwZ7rlVBa8yG4yGu9Ob/Iod0vtMgH5ATjgYG4UGiiS/yKFxTFV08ORp9I5OK sL4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=bp5Qh+vt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si8285170pgr.341.2017.12.18.01.46.42; Mon, 18 Dec 2017 01:46:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=bp5Qh+vt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933701AbdLRJqh (ORCPT + 28 others); Mon, 18 Dec 2017 04:46:37 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:44718 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758468AbdLRJoz (ORCPT ); Mon, 18 Dec 2017 04:44:55 -0500 Received: by mail-wm0-f66.google.com with SMTP id t8so27872257wmc.3 for ; Mon, 18 Dec 2017 01:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OLwJmgeUD3P0dRekE26KfH4G/1faj8pe7pF1iavmTnM=; b=bp5Qh+vtraz6gFkARC2xlkB3XZBffoPRg6A5GhcSQCgx1Auf3iUqTGRoIsJ70XKmpb pmsMYVN3PPaUM3lmior9JWUre/oZcoL6O47giNV859/MNF0+SeRXok5QnTRPHtxUhUZU gzQVG2XHbAcV4v2lyxxtSedEYneB9+wCJUTIXr6kqRxdvAFReuXFfXZjqRdmn2YZzXOj MS1+RIa749md4eRxsfAfGU5NYLa0j2jyqqsXwh7AO8R1YTNbsd7fKQsUZ2gPf8SV0swu 2lSKk/0RnLIUBYZ3qLNOD5C3LXu66aU/LqnuLTqlyr+maRuahWf9oQvFY1nIIg1Hn0bt x90A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OLwJmgeUD3P0dRekE26KfH4G/1faj8pe7pF1iavmTnM=; b=PPcvtypJqhwZ+I82j7Qos6m4sdWeqtA0f/+Crtr0GTkMq3EH2dgn3brScHBgzShlEE Ce3HLBXeRZgFHK02VMp5TvDHw0DHZwVtaE44yH8U5IobOBmhlhSgYXyg9QbLLoXVjN0H 8XU+Qy+RhFDvG92jPOzJ9eLUOyc21S6r4f0nWX/un7qEds9OnNrnG2U2Uj+r0X9/SB4M 2sTtx9hZhN1En37bZ4NHi/fQHvNgy0u+zSgfzoLVlMK8ctHOiwFkivinfbdgoEhY2oZR ii34P+FMMvnXa+vs2rVv6MtiXCmeJjUdcIi7SFiBi7d2DRduygT3xkB2YMP0XTm4xhaz 3ZrQ== X-Gm-Message-State: AKGB3mKUNJsJvcszsLPSRE47d83iVdiKrYdG1SCvvTRY4o4QeGNXd7YM nFf3a2U0B+xlD/Is6MvN42AeZg== X-Received: by 10.28.72.138 with SMTP id v132mr12537933wma.36.1513590294401; Mon, 18 Dec 2017 01:44:54 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:53 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: [PATCH net-next v3 2/7] net: phy: meson-gxl: define control registers Date: Mon, 18 Dec 2017 10:44:41 +0100 Message-Id: <20171218094446.31912-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Define registers and bits in meson-gxl PHY driver to make a bit more human friendly. No functional change. Signed-off-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 86 ++++++++++++++++++++++++++++++++++----------- 1 file changed, 66 insertions(+), 20 deletions(-) -- 2.14.3 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 900606204c0a..61bcc17098d7 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -24,53 +24,95 @@ #include #include +#define TSTCNTL 20 +#define TSTCNTL_READ BIT(15) +#define TSTCNTL_WRITE BIT(14) +#define TSTCNTL_REG_BANK_SEL GENMASK(12, 11) +#define TSTCNTL_TEST_MODE BIT(10) +#define TSTCNTL_READ_ADDRESS GENMASK(9, 5) +#define TSTCNTL_WRITE_ADDRESS GENMASK(4, 0) +#define TSTREAD1 21 +#define TSTWRITE 23 + +#define BANK_ANALOG_DSP 0 +#define BANK_WOL 1 +#define BANK_BIST 3 + +/* Analog/DSP Registers */ +#define A6_CONFIG_REG 0x17 + +/* WOL Registers */ +#define LPI_STATUS 0xc +#define LPI_STATUS_RSV12 BIT(12) + +/* BIST Registers */ +#define FR_PLL_CONTROL 0x1b +#define FR_PLL_DIV0 0x1c +#define FR_PLL_DIV1 0x1d + static int meson_gxl_config_init(struct phy_device *phydev) { int ret; /* Enable Analog and DSP register Bank access by */ - ret = phy_write(phydev, 0x14, 0x0000); + ret = phy_write(phydev, TSTCNTL, 0); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x0400); + ret = phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x0000); + ret = phy_write(phydev, TSTCNTL, 0); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x0400); + ret = phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); if (ret) return ret; - /* Write Analog register 23 */ - ret = phy_write(phydev, 0x17, 0x8E0D); + /* Write CONFIG_A6*/ + ret = phy_write(phydev, TSTWRITE, 0x8e0d); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x4417); + ret = phy_write(phydev, TSTCNTL, + TSTCNTL_WRITE + | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_ANALOG_DSP) + | TSTCNTL_TEST_MODE + | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, A6_CONFIG_REG)); if (ret) return ret; /* Enable fractional PLL */ - ret = phy_write(phydev, 0x17, 0x0005); + ret = phy_write(phydev, TSTWRITE, 0x0005); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x5C1B); + ret = phy_write(phydev, TSTCNTL, + TSTCNTL_WRITE + | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_BIST) + | TSTCNTL_TEST_MODE + | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, FR_PLL_CONTROL)); if (ret) return ret; /* Program fraction FR_PLL_DIV1 */ - ret = phy_write(phydev, 0x17, 0x029A); + ret = phy_write(phydev, TSTWRITE, 0x029a); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x5C1D); + ret = phy_write(phydev, TSTCNTL, + TSTCNTL_WRITE + | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_BIST) + | TSTCNTL_TEST_MODE + | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, FR_PLL_DIV1)); if (ret) return ret; /* Program fraction FR_PLL_DIV1 */ - ret = phy_write(phydev, 0x17, 0xAAAA); + ret = phy_write(phydev, TSTWRITE, 0xaaaa); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x5C1C); + ret = phy_write(phydev, TSTCNTL, + TSTCNTL_WRITE + | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_BIST) + | TSTCNTL_TEST_MODE + | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, FR_PLL_DIV0)); if (ret) return ret; @@ -105,26 +147,30 @@ static int meson_gxl_read_status(struct phy_device *phydev) goto read_status_continue; /* Need to access WOL bank, make sure the access is open */ - ret = phy_write(phydev, 0x14, 0x0000); + ret = phy_write(phydev, TSTCNTL, 0); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x0400); + ret = phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x0000); + ret = phy_write(phydev, TSTCNTL, 0); if (ret) return ret; - ret = phy_write(phydev, 0x14, 0x0400); + ret = phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); if (ret) return ret; /* Request LPI_STATUS WOL register */ - ret = phy_write(phydev, 0x14, 0x8D80); + ret = phy_write(phydev, TSTCNTL, + TSTCNTL_READ + | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_WOL) + | TSTCNTL_TEST_MODE + | FIELD_PREP(TSTCNTL_READ_ADDRESS, LPI_STATUS)); if (ret) return ret; /* Read LPI_STATUS value */ - wol = phy_read(phydev, 0x15); + wol = phy_read(phydev, TSTREAD1); if (wol < 0) return wol; @@ -136,7 +182,7 @@ static int meson_gxl_read_status(struct phy_device *phydev) if (exp < 0) return exp; - if (!(wol & BIT(12)) || + if (!(wol & LPI_STATUS_RSV12) || ((exp & EXPANSION_NWAY) && !(lpa & LPA_LPACK))) { /* Looks like aneg failed after all */ phydev_dbg(phydev, "LPA corruption - aneg restart\n"); From patchwork Mon Dec 18 09:44:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 122193 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2611693qgn; Mon, 18 Dec 2017 01:45:20 -0800 (PST) X-Google-Smtp-Source: ACJfBotE2Fkka/aVQVlRuwCc6RItFT0x7PYg9OEoYTYyUXzVDQz+zbOIaTM9UsLaBlBQdIUBQLze X-Received: by 10.159.240.134 with SMTP id p6mr21630250plr.344.1513590319964; Mon, 18 Dec 2017 01:45:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513590319; cv=none; d=google.com; s=arc-20160816; b=dpdbEDZJDwvjgSlL+rGm7F9R7ZMNvpCrZXbovZe76seK4gUDnaJCJgE7o4c/t3L9br MkYyBGrYYJjnhHwiEl0qkp1kHHiMRqF4l1Ql9KLIimlwGIP835D8GzcWGC9Tl9MtnwKd lZNBp+A3m1o5Ys7rOww+49O1ID/0G+hOlkf9TUJm0fyY9534sdrdwPhgqRfX1qhEykQj MqYgbU6UKS+jP9LTp1CEZZBC/YcpskDfdbFN0w3+ZbZFKq3hfbqXvX7rtiBlJWAaMSNy 3aSchgmd7LcUOR7dXi/+k7ahxCGOHxBNqKF6VR7uXH1FwbATX4XGaiLpxfQUMvDYx5Dp R5VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=/FdlsecwsEBO3yyJ2yhu5u+FLBZfK1UInun/BGjaoDY=; b=lAyI6FwQx6LEiPM8+ObzXBjGG6zVs8epJJyMYBU1EbdsKZkT/ZMPiSHOS/C0bZxoXS VYNLTcL/Ij+tpITqhJH2paovu8ICk7j57YKtTq7rnDgOsl47OyETac2qgkBNotGe5rSV xoG5Mbee6fo1jbN0qQ2Y/xar4++BeZ029RZdCK23Jabid1plibZs26G8jq6kiFS9x6ll 3wyvrIcyG0/gfAnzy5baFrhA9tRFsM3IvH03kepNhVn05M/NW9zeDkG3xK7s8WGBnF90 KKW6swzgGOm0H6XQnKXyFq1uUlbs9fZbmValEbGEoXYJ4UecbP8CDTcv62T0ZlEWLwik LQAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=dnaSoGN/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b91si9084265plb.559.2017.12.18.01.45.19; Mon, 18 Dec 2017 01:45:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=dnaSoGN/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933612AbdLRJpB (ORCPT + 28 others); Mon, 18 Dec 2017 04:45:01 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:44722 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758549AbdLRJo4 (ORCPT ); Mon, 18 Dec 2017 04:44:56 -0500 Received: by mail-wm0-f66.google.com with SMTP id t8so27872371wmc.3 for ; Mon, 18 Dec 2017 01:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/FdlsecwsEBO3yyJ2yhu5u+FLBZfK1UInun/BGjaoDY=; b=dnaSoGN/yHuII+0L5XBteSzO50cjX18swzSm6tRfVkazZYhqclRA0QX+h1u5+Ika0q x/JISMt8B47IZuySxfZvW/kzw10EtyrNjSs5qZt6mJEQ5m3WSIOPkHT80osNhb8G9MWq 1IqrJ6ZT27j521YeQ0RoMi6jPuPmux7nS+m4Kh4u6HwHum/ybYrXw3VdM13uTwTBCsuw cYINdPVxBDjg0cV2xTKA3TiVSuzJx0qDOO06xlxBxMBfFx7zMqo1HrT35Mb99f8OS8P8 ImpcD3I0PNYILu17bss469vZLbGA2RZ98CQHWK1dI8hv6PJbON3/xXoVwQ6NEXMh/RUE /RFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/FdlsecwsEBO3yyJ2yhu5u+FLBZfK1UInun/BGjaoDY=; b=dtRNnwYEF7uOObYdRthXfYyE9KqGPPk5/9B0DZRNBsiR1Mi3I4fMa4P4RK+aJby5Ha 0NsoycyUVfVqEgOzTp/RPZkbYd6yfB9UXDcsh+HkpDdE8RZPEo5zF2DJEfkk0Dg09J+l N1TqHHwHUxNxweSiBqet7kCUhCWobiWl/Oce8A1/rnd3no7gMHeS4CTjob3yqB7mZDaq /9NBhpgva5W5XuSvNIKTur4mqTD9MdGk+JzRMQgegSd+7xAlIKTnlVxhloCK8Mlec9Uz Lah6w73ONIUHLzR5w4DJepU3m+UdLPu5bubz8oxhuWtxsSGrJZ4gOMK4tJ73FrZBT6Ou P0dA== X-Gm-Message-State: AKGB3mKMJkHEIK1t1mAk0NKD0ds0xgl+Acf5Ct8oF6SCxHAnImoT6Tcb +Jrc+9tcnWYgnqQUNh6Klv4GaA== X-Received: by 10.28.147.84 with SMTP id v81mr12068588wmd.133.1513590295424; Mon, 18 Dec 2017 01:44:55 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:54 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: [PATCH net-next v3 3/7] net: phy: meson-gxl: add read and write helpers for banked registers Date: Mon, 18 Dec 2017 10:44:42 +0100 Message-Id: <20171218094446.31912-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add read and write helpers to manipulate banked registers on this PHY This helps clarify the settings applied to these registers and what the driver actually does Signed-off-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 130 +++++++++++++++++++++++--------------------- 1 file changed, 69 insertions(+), 61 deletions(-) -- 2.14.3 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 61bcc17098d7..a52645566d0d 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -50,11 +50,13 @@ #define FR_PLL_DIV0 0x1c #define FR_PLL_DIV1 0x1d -static int meson_gxl_config_init(struct phy_device *phydev) +static int meson_gxl_open_banks(struct phy_device *phydev) { int ret; - /* Enable Analog and DSP register Bank access by */ + /* Enable Analog and DSP register Bank access by + * toggling TSTCNTL_TEST_MODE bit in the TSTCNTL register + */ ret = phy_write(phydev, TSTCNTL, 0); if (ret) return ret; @@ -64,55 +66,84 @@ static int meson_gxl_config_init(struct phy_device *phydev) ret = phy_write(phydev, TSTCNTL, 0); if (ret) return ret; - ret = phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); - if (ret) - return ret; + return phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); +} - /* Write CONFIG_A6*/ - ret = phy_write(phydev, TSTWRITE, 0x8e0d); +static void meson_gxl_close_banks(struct phy_device *phydev) +{ + phy_write(phydev, TSTCNTL, 0); +} + +static int meson_gxl_read_reg(struct phy_device *phydev, + unsigned int bank, unsigned int reg) +{ + int ret; + + ret = meson_gxl_open_banks(phydev); if (ret) - return ret; - ret = phy_write(phydev, TSTCNTL, - TSTCNTL_WRITE - | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_ANALOG_DSP) - | TSTCNTL_TEST_MODE - | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, A6_CONFIG_REG)); + goto out; + + ret = phy_write(phydev, TSTCNTL, TSTCNTL_READ | + FIELD_PREP(TSTCNTL_REG_BANK_SEL, bank) | + TSTCNTL_TEST_MODE | + FIELD_PREP(TSTCNTL_READ_ADDRESS, reg)); if (ret) - return ret; + goto out; - /* Enable fractional PLL */ - ret = phy_write(phydev, TSTWRITE, 0x0005); + ret = phy_read(phydev, TSTREAD1); +out: + /* Close the bank access on our way out */ + meson_gxl_close_banks(phydev); + return ret; +} + +static int meson_gxl_write_reg(struct phy_device *phydev, + unsigned int bank, unsigned int reg, + uint16_t value) +{ + int ret; + + ret = meson_gxl_open_banks(phydev); if (ret) - return ret; - ret = phy_write(phydev, TSTCNTL, - TSTCNTL_WRITE - | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_BIST) - | TSTCNTL_TEST_MODE - | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, FR_PLL_CONTROL)); + goto out; + + ret = phy_write(phydev, TSTWRITE, value); if (ret) - return ret; + goto out; - /* Program fraction FR_PLL_DIV1 */ - ret = phy_write(phydev, TSTWRITE, 0x029a); + ret = phy_write(phydev, TSTCNTL, TSTCNTL_WRITE | + FIELD_PREP(TSTCNTL_REG_BANK_SEL, bank) | + TSTCNTL_TEST_MODE | + FIELD_PREP(TSTCNTL_WRITE_ADDRESS, reg)); + +out: + /* Close the bank access on our way out */ + meson_gxl_close_banks(phydev); + return ret; +} + +static int meson_gxl_config_init(struct phy_device *phydev) +{ + int ret; + + /* Write CONFIG_A6*/ + ret = meson_gxl_write_reg(phydev, BANK_ANALOG_DSP, A6_CONFIG_REG, + 0x8e0d); if (ret) return ret; - ret = phy_write(phydev, TSTCNTL, - TSTCNTL_WRITE - | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_BIST) - | TSTCNTL_TEST_MODE - | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, FR_PLL_DIV1)); + + /* Enable fractional PLL */ + ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_CONTROL, 0x5); if (ret) return ret; /* Program fraction FR_PLL_DIV1 */ - ret = phy_write(phydev, TSTWRITE, 0xaaaa); + ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_DIV1, 0x029a); if (ret) return ret; - ret = phy_write(phydev, TSTCNTL, - TSTCNTL_WRITE - | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_BIST) - | TSTCNTL_TEST_MODE - | FIELD_PREP(TSTCNTL_WRITE_ADDRESS, FR_PLL_DIV0)); + + /* Program fraction FR_PLL_DIV1 */ + ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_DIV0, 0xaaaa); if (ret) return ret; @@ -146,31 +177,8 @@ static int meson_gxl_read_status(struct phy_device *phydev) else if (!ret) goto read_status_continue; - /* Need to access WOL bank, make sure the access is open */ - ret = phy_write(phydev, TSTCNTL, 0); - if (ret) - return ret; - ret = phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); - if (ret) - return ret; - ret = phy_write(phydev, TSTCNTL, 0); - if (ret) - return ret; - ret = phy_write(phydev, TSTCNTL, TSTCNTL_TEST_MODE); - if (ret) - return ret; - - /* Request LPI_STATUS WOL register */ - ret = phy_write(phydev, TSTCNTL, - TSTCNTL_READ - | FIELD_PREP(TSTCNTL_REG_BANK_SEL, BANK_WOL) - | TSTCNTL_TEST_MODE - | FIELD_PREP(TSTCNTL_READ_ADDRESS, LPI_STATUS)); - if (ret) - return ret; - - /* Read LPI_STATUS value */ - wol = phy_read(phydev, TSTREAD1); + /* Aneg is done, let's check everything is fine */ + wol = meson_gxl_read_reg(phydev, BANK_WOL, LPI_STATUS); if (wol < 0) return wol; From patchwork Mon Dec 18 09:44:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 122192 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2611532qgn; Mon, 18 Dec 2017 01:45:08 -0800 (PST) X-Google-Smtp-Source: ACJfBotYzi2Cgxk/XPbT7Q7SRITqq0eu3uOCtxw/07od3RC84mdtF4NXP6AXyNme0f5U/IRKPc1C X-Received: by 10.159.218.143 with SMTP id w15mr22547505plp.38.1513590308029; Mon, 18 Dec 2017 01:45:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513590308; cv=none; d=google.com; s=arc-20160816; b=caBNm3mExCTYnSLRKMF7EzR65beo7rFoeGLtXlGDiaaoy2DWA3NfDBlDblrlm6Sj4n WldjQlVHAytGYVWG/YkLp5KZ+C5MZw5n/lj1gbf484caFvJRHGo9MpPTWa8AEAArHF5d cMYv8KQQ3UcrzVckKkw6gjSsLer+WuZqJ7HS4gi74c1tkhYyvVmr2nEoxWlJD19BuXe1 gYv0GQc4tt2gY/osCECGcX932fLZu8VPelmEshJGtQkMNoQpfmDyOd3y1fR9L0Hx+Ja7 wW3IN/PZlZXdo6yn48tAZWLEcbFhtCWdfG1hEUgRMACi/oa8so0nGdySLORLRhw0ZhfS hKnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=8VFGU2SRz5rTk/WJol+kiU97NkMvheqraHG7vLP+ZXM=; b=d9+6v22ECGpu42bURto5eHr9fAGlV2XawqqLIN/VV7jIByGCtyvoO9OzTY+WIJoJJG THKF84QO7SFsMyg1cwGE8gp+s1hJdfoh3kWVa5IAcBzbV8lvEOsmP0/aRJbq9bFmzO+B iKdMP2XyKEC9FTnxU8kLFiAonIcEXpf0hBnKkJXlD5OEFTGsMaeisX0KdDReO8jwstYk Xvm4zUFIQi57pGnB/ZgSfPEaX4dOV6qDFyAo/XM3bKfMTluodZ7NnDuCtWD71ohVhDPp n0T0oYzhvCVCs6Gor9SgF3g2OAc576aEJvOgVLOYQkSsynkUzSOtTgioev+5zdZpYeOZ fr/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=lVuJrkaV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 94si8712514ple.413.2017.12.18.01.45.07; Mon, 18 Dec 2017 01:45:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=lVuJrkaV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758575AbdLRJpE (ORCPT + 28 others); Mon, 18 Dec 2017 04:45:04 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:42571 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758311AbdLRJo5 (ORCPT ); Mon, 18 Dec 2017 04:44:57 -0500 Received: by mail-wm0-f68.google.com with SMTP id b199so28056237wme.1 for ; Mon, 18 Dec 2017 01:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8VFGU2SRz5rTk/WJol+kiU97NkMvheqraHG7vLP+ZXM=; b=lVuJrkaVSXhKPGXB6IqRF3YFVdJt79zEZ0VpvRJjVTbaPJjxf6MjE3/w19rYstNtFf giUf2eqw49bBhUY823KKEyt7oj3id++7RlRW5oGfl857H8+A/nSAH7gA5AVLXVBPwkli 4yUuIXsmQtPU5l5mCGck8qZZnNhJJ6RMV3xOW9iKjRQAca5TfH2JPUDuBsi3u6TeHceJ gheaIDKfsZtoUTHrJFa2TNDR7sYEDHFDzz8jtJ2VR2+6i4l/wnq1JD+3dTAmpT/hJ3PD Yz5o62UZ1fXJS5Hyzha25WHT746Drx1hexZ7iWm1hxULGpeEh5q60tAxZrVmqXqFGbFY ryEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8VFGU2SRz5rTk/WJol+kiU97NkMvheqraHG7vLP+ZXM=; b=OebhD5I3nL1ad3TmJprYrC1uqLjbnONw6R5tN3RYxMl9iHoDWqvGFDgLTl+hA8ZQUE tT23mHr9wpvKvwjdxPvLadwa5umFGxdZZDWaoAl+5W/tgo0QDnLt2VcF3yprp2/Nu8nV KWvSe4GPPiH/2vwyzINx0drGP+J3SIxtetehtC5SRtJ9DQq/0cfYBJm4nTvgnewrRjOT ARAkT9fndzVKScVmnqoh1TeCwbok4KrAqNeTY9HJl3+Ui2Z6N3ZuyTOqWN8VxyPaO+2Q srtdrzKGcn4DMaN53V7/xAlz9dMfYIZ8gxeN9I0HIJ0JQ0FLdYikt1WWyUD7G2z+2cwt DOpw== X-Gm-Message-State: AKGB3mI3aGJz/cRwZCo6SA8XJZXTTbafFKTKShmMCW9uzkc6WywTajeX Ge6kz4509M7WzTTtnA9Lxlp5CA== X-Received: by 10.28.170.137 with SMTP id t131mr10758257wme.137.1513590296338; Mon, 18 Dec 2017 01:44:56 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:55 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 4/7] net: phy: meson-gxl: use genphy_config_init Date: Mon, 18 Dec 2017 10:44:43 +0100 Message-Id: <20171218094446.31912-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the generic init function to populate some of the phydev structure fields Reviewed-by: Andrew Lunn Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index a52645566d0d..0a34656a2086 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -147,7 +147,7 @@ static int meson_gxl_config_init(struct phy_device *phydev) if (ret) return ret; - return 0; + return genphy_config_init(phydev); } /* This function is provided to cope with the possible failures of this phy From patchwork Mon Dec 18 09:44:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 122198 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2612927qgn; Mon, 18 Dec 2017 01:46:56 -0800 (PST) X-Google-Smtp-Source: ACJfBotUqp0TRQTtqe9LozG+DIUS3WhX4xFFbQfCYQ88utNYWo+r6xMa1mRMDHhzlahXu+5NR708 X-Received: by 10.84.179.193 with SMTP id b59mr21920546plc.12.1513590416877; Mon, 18 Dec 2017 01:46:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513590416; cv=none; d=google.com; s=arc-20160816; b=a7nI2Hp/iw4IDkAtutVWGhKkovKoftzYV/JhdzsAe9qwDDKcIXvogLvI9i4dquSckH GN9/WGt7LQXTINu0zYW15F0beXlhKAocfS59UrlyyktmiJH9/J4XzgWk4yNKglNqZir6 Pobt85rpOs5u1gseIQsnJELyvXDlobHhGJ4mExOLDCZ1xOtc0x+6IBqvIaZ6tnv4EYOG WTVcE6n75rGG3JcgLBPRjcZm4xnCWNPPW/ksrqVemXHs08BHwsEv/v7Zh5txNMVVtzu2 843ViMqn5geS6CXnVcmVj1gNYYWnSSmy9fAnqlk90L+RdABlOwYJqmE6C93E1XrI0iqM 5BNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=GtweTir+f4z1Z60UugjOzgbytYOQ0oWOM6id0Zorle4=; b=Mnn0fgySe4OT8+78gzDoyU4meSCNvVtTzm1yeIKRs09IOQ1k/DGbwXvrYs/ZhPlsP3 WDA6JUDIbj3qlLGLpVCdgi5BsrbRGs+GFPZfWMrGOnYgX4nZq5m4XbozbcYDN09TPcDO rmogEy+cND/n7sh50BaWG2Chn1Tg11ZZ2XaerMfWKK3L/LqDp1zUMtpiBV+fq9x22anY XDGoUCBr++jbrwwtNBndjG6hBZdDxq8lp3rV/2oplFnLzW1n1ucM9yfHoDXNLW63jpsL HR57Q6OSL3XMRqZb8Qm2qIVBMZbcMwnqo3w4/eyrYF3SzB8Qe9fWBYmQFpJPD/OW7nEK W8gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=lxdsCVME; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q25si8345106pge.487.2017.12.18.01.46.56; Mon, 18 Dec 2017 01:46:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=lxdsCVME; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933682AbdLRJqg (ORCPT + 28 others); Mon, 18 Dec 2017 04:46:36 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33467 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758554AbdLRJo6 (ORCPT ); Mon, 18 Dec 2017 04:44:58 -0500 Received: by mail-wr0-f195.google.com with SMTP id v21so2742559wrc.0 for ; Mon, 18 Dec 2017 01:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GtweTir+f4z1Z60UugjOzgbytYOQ0oWOM6id0Zorle4=; b=lxdsCVMEffPtjoOttRVGck53LkylDmhwDfEidspO/9Tb24brdxUygbrHSodr6ISDvO 1i7CcWKb3F1AgTf4gIWFKrwKQ28kKXNMzREFuTNtqeMgJZfPFUkaH0PXMdGJMUrgbVIF eyGGHKjeL4KKZ2GtesFIN91QsYf44V5QUWRzSadF0HEX/YIrQSRM0U6SUg9GZI7MxIAB YkXx5cvegmfnIlLkcSXQLH/XIh8Y68iyg2zjZa1yoofDjJQXZLyiSh72zQrP52NzB8aD DKdVupQW3FPBy9C9n7k+UsttceTOy/bRH8ORo+fRTEsMUlcCp5mPjvXwMItNNse6SIYm ty+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GtweTir+f4z1Z60UugjOzgbytYOQ0oWOM6id0Zorle4=; b=j0SpTuQe+3LbQigWzDqZ/nIdqxdo4ooeLmrFCE10vU7dfJfGpDtOKEx8yKKbMvk1JT E0NvrNajxl6H8/U65vvzV3Y7lOuZfSqR3Bf9DpDTAW4Oy0NB8gQW3q/9wWiPMS3EM3Hw HgyOgCx+ssBdDihOIlXbvxo95Zf0R6zhTDZlheyERLPUDUBVqkRj76T6IXJ8XVQ30sWn K1c+/aOyMjHWHKBcEmZtWZgzpJjr/9AJJAV1fxhUcet1yUdd7+1vMLBsLLH2OsWgyVsc 1QgaPKGcgHaJjAM0aMGQCoU8BqWFtYZTTQQAdUN5qHZjVfDJmZiFln0W3cQJmTaxFZ1z DBaA== X-Gm-Message-State: AKGB3mIlCZN4n3bM3f9l92P2mn2kNAYqjJV/Q/qIg4R0zMx6tPG3DY2b viE3JMOpvEfH30V9RVZjZYfP2A== X-Received: by 10.223.136.56 with SMTP id d53mr5776814wrd.36.1513590297277; Mon, 18 Dec 2017 01:44:57 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:56 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 5/7] net: phy: meson-gxl: leave CONFIG_A6 untouched Date: Mon, 18 Dec 2017 10:44:44 +0100 Message-Id: <20171218094446.31912-6-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PHY performs just as well when left in its default configuration and it makes senses because this poke gets reset just after init. According to the documentation, all registers in the Analog/DSP bank are reset when there is a mode switch from 10BT to 100BT. The bank is also reset on power down and soft reset, so we will never see the value which may have been set by the bootloader. In the end, we have used the default configuration so far and there is no reason to change now. Remove CONFIG_A6 poke to make this clear. Reviewed-by: Andrew Lunn Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.14.3 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 0a34656a2086..ddc92424e8de 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -38,9 +38,6 @@ #define BANK_WOL 1 #define BANK_BIST 3 -/* Analog/DSP Registers */ -#define A6_CONFIG_REG 0x17 - /* WOL Registers */ #define LPI_STATUS 0xc #define LPI_STATUS_RSV12 BIT(12) @@ -126,12 +123,6 @@ static int meson_gxl_config_init(struct phy_device *phydev) { int ret; - /* Write CONFIG_A6*/ - ret = meson_gxl_write_reg(phydev, BANK_ANALOG_DSP, A6_CONFIG_REG, - 0x8e0d); - if (ret) - return ret; - /* Enable fractional PLL */ ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_CONTROL, 0x5); if (ret) From patchwork Mon Dec 18 09:44:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 122196 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2612250qgn; Mon, 18 Dec 2017 01:46:03 -0800 (PST) X-Google-Smtp-Source: ACJfBotHMIL2LiZoHwusRKonmiDNYWmeQ3bbGXrOujH9LB2bjZ01VArfI1UrljKd1W1gb3GNj2Yz X-Received: by 10.84.134.132 with SMTP id 4mr17941594plh.32.1513590363892; Mon, 18 Dec 2017 01:46:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513590363; cv=none; d=google.com; s=arc-20160816; b=xpIezT81F4qrSOuBBmrqUvmn+3NKjGxbnuI4vahFWjH6kpTybxZpiFfTNTRKaz7HPa ixb4wWzF3KiPa/aADtS/2ZbuLDNrYX2qYmhULJoYU8xaywI0IwBOfPYz1JrZMRkn7dld FVyDx5Q0sy/oSR5cKIZ4YdiA1qoe5+rXV/JmQ6CWtTw7KZPXTPeARsGzPnaOqIHLoPnr Oc5KtegEwx34Q/vfKQnSf0ouF9By5XkY8pj82BusTMHJD2UauO6DpksldFJSrHpHj4ba 4HFiEoU7yIS428uLlT28s7m5kphUmHmiKLIk4m+0ROmMrfblQHGG4s0OsOtjNMAYucRC ONHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=MwgOy5ouDeWkMjOIuKaxU1MbIjtU2l5PRJV3MWSAueg=; b=v2X1Xzu3fY79hm2fWvZdx5wa0y2KbLzWnywF6C8a53gxz5WrPB5rZwQz5A5TKldu2V 5wTtPFkl55rRnGCziHaPbqnCFzw0HJWk+snDnCW7y8SbqAvoaDIdy1/h5WX0kqAIuEO8 XpveiGMHi90VlE667ZnUmUF1iB3edvHpeEO60CxwYURgv1z5MpB5hCWL7exxEEVlKbUg J6+M+rL1cnxjDEoOiq5f4dGODmAijwU754cOavB6cvW4uUSCQOPvjmRENoyP2erqQE5k ry+F/F5wyj8QSqRaCZrQrlT5wmj4EeWvvwMQi+JDli27F/KdHQBZsJgYHu05s3+jQNvY 4ZSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=salgbuLG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si9062570plp.234.2017.12.18.01.46.03; Mon, 18 Dec 2017 01:46:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=salgbuLG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933656AbdLRJp7 (ORCPT + 28 others); Mon, 18 Dec 2017 04:45:59 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:38020 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758559AbdLRJo7 (ORCPT ); Mon, 18 Dec 2017 04:44:59 -0500 Received: by mail-wm0-f66.google.com with SMTP id 64so28049337wme.3 for ; Mon, 18 Dec 2017 01:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MwgOy5ouDeWkMjOIuKaxU1MbIjtU2l5PRJV3MWSAueg=; b=salgbuLGNwt9Uw4s/Jx1aSDEBRnn4+Eoqkj3ovq69JZFuFITyRwlHVPoKAJswN7TQs dxgf6omtINcQbCrr5Ag1sNTQyOCUHdRyCm8aaUukw5q2dHhjUAjVHYWMHNySkTfEvmJL mxGbQHLSn9t7jw30xhayWqKIZLFAE1N8IbEEopdI4w+C94LY95Jzb2sRkbE8Ru0O5nvs wo6IKq0iVGPs2clj2YT2mjFoJxtFWTk8OGSX99aRfedPJTYFwZn1TrujkkLJU6HofGPk k6QYDd3QjVHo5OHszxUbnSKsDu6U+/572iLywiscKcold5ngZjcQeUih8oGLuf5RNzMV B7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MwgOy5ouDeWkMjOIuKaxU1MbIjtU2l5PRJV3MWSAueg=; b=h7vvSPuGJtAWRaerEMWrOx9DiPU8hc6Dc2EFlViIxggPjCyr49xEf2g4PqFsRImnUL jAfDLmoHdJF52bYSAkuE4W2XJRPq9D7nQ6Fi2SvOnwUuAJrggsi5aJlDjiy9PRb0aArn 1s1DA7lNRVym0i4ph6pR4KJzbqHM9K8ZY1v2WpigOsqNz1f+VFmpoaBx0/VbCcTH2hz7 D5IfnfyYKUn9kBXCAkEu6F4HJPT+Ent/ulpDxXQpsPx8naUDlVXtiZVybS6Epg/sEdbN HakuqS1/saiieS5zGQDSeTD1iNyBO6tw1RYiecUx71VyAj8hH1RR62z74/OOR87vhQh9 YYug== X-Gm-Message-State: AKGB3mJBgl8vhce2KnOTxGCefHzDYYsQl/mTSRUti0Yr4CkW9m+EBUXT +hMDbiaWf6OMy5ufxZpHP1hAmg== X-Received: by 10.28.218.132 with SMTP id r126mr10963926wmg.59.1513590298236; Mon, 18 Dec 2017 01:44:58 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:57 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 6/7] net: phy: meson-gxl: add interrupt support Date: Mon, 18 Dec 2017 10:44:45 +0100 Message-Id: <20171218094446.31912-7-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Enable interrupt support in meson-gxl PHY driver Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) -- 2.14.3 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index ddc92424e8de..ee0aa18af631 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -33,6 +33,14 @@ #define TSTCNTL_WRITE_ADDRESS GENMASK(4, 0) #define TSTREAD1 21 #define TSTWRITE 23 +#define INTSRC_FLAG 29 +#define INTSRC_ANEG_PR BIT(1) +#define INTSRC_PARALLEL_FAULT BIT(2) +#define INTSRC_ANEG_LP_ACK BIT(3) +#define INTSRC_LINK_DOWN BIT(4) +#define INTSRC_REMOTE_FAULT BIT(5) +#define INTSRC_ANEG_COMPLETE BIT(6) +#define INTSRC_MASK 30 #define BANK_ANALOG_DSP 0 #define BANK_WOL 1 @@ -193,16 +201,43 @@ static int meson_gxl_read_status(struct phy_device *phydev) return genphy_read_status(phydev); } +static int meson_gxl_ack_interrupt(struct phy_device *phydev) +{ + int ret = phy_read(phydev, INTSRC_FLAG); + + return ret < 0 ? ret : 0; +} + +static int meson_gxl_config_intr(struct phy_device *phydev) +{ + u16 val; + + if (phydev->interrupts == PHY_INTERRUPT_ENABLED) { + val = INTSRC_ANEG_PR + | INTSRC_PARALLEL_FAULT + | INTSRC_ANEG_LP_ACK + | INTSRC_LINK_DOWN + | INTSRC_REMOTE_FAULT + | INTSRC_ANEG_COMPLETE; + } else { + val = 0; + } + + return phy_write(phydev, INTSRC_MASK, val); +} + static struct phy_driver meson_gxl_phy[] = { { .phy_id = 0x01814400, .phy_id_mask = 0xfffffff0, .name = "Meson GXL Internal PHY", .features = PHY_BASIC_FEATURES, - .flags = PHY_IS_INTERNAL, + .flags = PHY_IS_INTERNAL | PHY_HAS_INTERRUPT, .config_init = meson_gxl_config_init, .aneg_done = genphy_aneg_done, .read_status = meson_gxl_read_status, + .ack_interrupt = meson_gxl_ack_interrupt, + .config_intr = meson_gxl_config_intr, .suspend = genphy_suspend, .resume = genphy_resume, }, From patchwork Mon Dec 18 09:44:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 122194 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2611877qgn; Mon, 18 Dec 2017 01:45:32 -0800 (PST) X-Google-Smtp-Source: ACJfBovys3pC85y8rNE214ClLkab47FO6Jtk2N1wua5iR8R7w7URMNrJIpXPC1cIeynevjE85lX7 X-Received: by 10.99.96.69 with SMTP id u66mr3330625pgb.355.1513590332698; Mon, 18 Dec 2017 01:45:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513590332; cv=none; d=google.com; s=arc-20160816; b=jiQg43TUHi4lHt8vm10GFZ3GMo3ASiYFWavLsUax1W85aPh0bdvbs6Cld45iwP0c8I HA6LoMdkRPX9QoPKd9fKpOjpZe7oFFd25rZCuQJvACJT1fLyIHckNIorAMBqPaeEyElj 58qQPJmFWTd05f5afTvHmedykUNtecxuP4ttNzr7dYZxKZMAjnZFR6AGbzISagLnHojD WBAgT2pqAisy9F+uoDVlgo2pzd6SYE693NHNlYBU4mzbHGBciIoe18rwJdLXU/KLW61Y dkSyDU7jnqvrZATl4Femxm1x7t5Dkxp+N6aRmK7gMWa9dI6f9l98KxjHNzJv1wmStbvk W5xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=u+rEPk74daaN1wX5l/Ut5rwzrDeT/W+/Ffl3T60PsZc=; b=DVAO2svLo2fK+YRyBZ9TRj7jffVFGQmPfvKqC8B/Ci8RUjbsGlTFkF4J0SvtcuxxEB TQ4OrjbR74bq6m7dU/J8ZeL5iWtc9o7drYpYctcJkhCWXrZLUqIOyEP6imFKwYiy5FDN +tn7L/aaP4YI2gHNgseGdnkyLqDEUZfRwU4I+IO9bg6wh8j7lYNF/IiQSY/BRwbuyi9+ sgvttd+f3U4xxLrUQwhM5whRnvpETAALQltwucpLNVO2dKtFJV6MUjm6BQNNV/Qw9cd2 P0WHO5cbco/fopCMX62Gayt7q9cGUSS2xCfNlo8SLrfdadv9IPPKjkp7Q6dBBe//qfO3 dsUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ANF390S6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24si8958609plq.341.2017.12.18.01.45.32; Mon, 18 Dec 2017 01:45:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ANF390S6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933630AbdLRJp2 (ORCPT + 28 others); Mon, 18 Dec 2017 04:45:28 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:39715 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933591AbdLRJpA (ORCPT ); Mon, 18 Dec 2017 04:45:00 -0500 Received: by mail-wm0-f65.google.com with SMTP id i11so28000894wmf.4 for ; Mon, 18 Dec 2017 01:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u+rEPk74daaN1wX5l/Ut5rwzrDeT/W+/Ffl3T60PsZc=; b=ANF390S6dPCabGVWC6p2tbIpGB8QKe3nx/WrvWASxncpbEvIlyPmAbkqJH/eH8Euj6 GNf6CYzOU3uGvrwjyDHAAjnZVvAGeX97EoRL9tjLEiBnLW8aAGa9l5AK0TrdyDuFH7rP kg66OXKVQNHuOXmfjneBg1ELu+3CE90gUjmoQkLF56diR9Xqzx/Dva0kiz59bTY0IdJo h5Pvzfs4IGwLIG/279RT2MTnfqll+3CqBOn/3yQAc9y0ZNspkIzXfKJzwWISXOTB8+BB 1x/pIt8SYaFgTLzU0i9/hDo2R9NnhsjsxPzMAm7jrNf5XYrQaeYaVMKeP8sqYgv7ECd+ KSXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u+rEPk74daaN1wX5l/Ut5rwzrDeT/W+/Ffl3T60PsZc=; b=RDk6sxZq3I8x6uwDwUsfLCtZHAxaKCey5uPnJetKKAhC6PAjgzexegXR0GMJEDyxUz O7Uhcm0lNmUzApth6khudnlA3XeadPdi94LivTXp68a6+P7sWFCE8gfUXNCPnexYGXW3 QacAZNhSDxzpKkJ/PKKjzI/ZQQTQ4AZJalddBuqpxkUURfPjhZvIrf4f8H2GllGhUj0K IQSn8mPhOBqk61bontJEgdN7GvjkH/HzLLVcDfBjE8D8d2kzB489yxCLm1TDiXsaeoom tFLrz0IxDPcjcy/utLv7vd5EsdxCrAQ5r9nw2JZgutlvS6s4c3mHjSYsiL7okhU1ygem RLFg== X-Gm-Message-State: AKGB3mJXjVw3rvzkKsiShRQKDXFoPlO+dZG8nZ69wxSvW/+AgyEUUuAM OxgipBR3TCu4QTB7zlfMQMwEuA== X-Received: by 10.28.46.136 with SMTP id u130mr12624073wmu.127.1513590299311; Mon, 18 Dec 2017 01:44:59 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:58 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 7/7] net: phy: meson-gxl: join the authors Date: Mon, 18 Dec 2017 10:44:46 +0100 Message-Id: <20171218094446.31912-8-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Following previous changes, join the other authors of this driver and take the blame with them Reviewed-by: Andrew Lunn Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 1 + 1 file changed, 1 insertion(+) -- 2.14.3 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index ee0aa18af631..ddc2c5ea3787 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -255,4 +255,5 @@ MODULE_DEVICE_TABLE(mdio, meson_gxl_tbl); MODULE_DESCRIPTION("Amlogic Meson GXL Internal PHY driver"); MODULE_AUTHOR("Baoqi wang"); MODULE_AUTHOR("Neil Armstrong "); +MODULE_AUTHOR("Jerome Brunet "); MODULE_LICENSE("GPL");