From patchwork Mon Nov 2 11:23:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6EAC388F2 for ; Mon, 2 Nov 2020 11:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7715422275 for ; Mon, 2 Nov 2020 11:29:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x2UW17qR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728814AbgKBL3Z (ORCPT ); Mon, 2 Nov 2020 06:29:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728564AbgKBLYW (ORCPT ); Mon, 2 Nov 2020 06:24:22 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD29DC061A47 for ; Mon, 2 Nov 2020 03:24:20 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id i16so8723999wrv.1 for ; Mon, 02 Nov 2020 03:24:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rWq4EIZLBdjUFDSSQaVD1PvQUVhVWlX38rMGrIxZmlM=; b=x2UW17qR4c0kvXf/+l7qSJedHq1o8V2vl+ISBbFylFtvk2vUKWFFpdTfou1B8He+Q0 c+EyGOB8XIf0ZxnaJhpyHhEd7SQSHc9aQMv4SMKIg/qaImxtSbTN6yHfSvo32N3zZtMk hHi62B9axAABq+Q0CPfoGb/WgA5XJaLhXqCdkiIKH25TgmhbwN9Dw+6Sxd4+QQlBdM1T PA2IqSCyqLG7ebal/2RFDCJe+6tyKItzL5qw9Yz70AjrsRf0DmARk71ZPY06Png1aycE /HyfpVe2jMrIWISBydC5ez8ffVW0P5z9PiFIqkhYIxziqjqKTD72SZTffs8zm4WgVA0G Jq5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rWq4EIZLBdjUFDSSQaVD1PvQUVhVWlX38rMGrIxZmlM=; b=YTM22cvg0cpJA+XtyB1cTiG3oJhbiuAKuopCSsc90FOMb1OW+Wr+ToLPczlyjDz0fg /ohrY9wnARGUZfKDTWfR4b76Ah/9uTbARu7oPk1lmBYybqVGLZe4TeKVBL6pcpOvrP6K 0Wkayczwstb+xy8cy30mBfzPdKJmsi9BstJCwzGDaoo2US/bzV1BIasG47opjnADZrSH staZA+iFG7inlWw7qzoTTRUzAMa7BGVq+8+eAzVoDXo9lrZeqmrqAGasqaqXzLV+VLZb pV4yZpaPaKMB26EWQakXHzCi9hWnpQFyZLTW+LBgCki2UwBDoxxp6D28AEBsbtB4zf6W m0jw== X-Gm-Message-State: AOAM533sGQD1Lj/5C/hu3mbROYz3WkG+HcQglKYcaaSY7r1bA74eUVwH VQrqpF+SdNJk6JCkQ180BFvbFQ== X-Google-Smtp-Source: ABdhPJzTs3Su8jafA1/QFINA6CLlvpL8pFXQ+/MTGhpyj+hXg91Kpda51zuYKkZ+k1gKCcylqLCg+g== X-Received: by 2002:adf:82a7:: with SMTP id 36mr19854627wrc.1.1604316259365; Mon, 02 Nov 2020 03:24:19 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:18 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Maya Erez , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, netdev@vger.kernel.org Subject: [PATCH 01/41] wil6210: wmi: Correct misnamed function parameter 'ptr_' Date: Mon, 2 Nov 2020 11:23:30 +0000 Message-Id: <20201102112410.1049272-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c index 421aebbb49e54..8699f8279a8be 100644 --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -262,7 +262,7 @@ struct fw_map *wil_find_fw_mapping(const char *section) /** * Check address validity for WMI buffer; remap if needed * @wil: driver data - * @ptr: internal (linker) fw/ucode address + * @ptr_: internal (linker) fw/ucode address * @size: if non zero, validate the block does not * exceed the device memory (bar) * From patchwork Mon Nov 2 11:23:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320201 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp3643156ilc; Mon, 2 Nov 2020 03:24:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQI151/u3w6Utbsj7qEZyX/Hqa6S8iqbA1++9LqjyLqdsfzyXjcRQW1S3VIoOkJccUrjgq X-Received: by 2002:a17:906:3089:: with SMTP id 9mr2370725ejv.535.1604316269383; Mon, 02 Nov 2020 03:24:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604316269; cv=none; d=google.com; s=arc-20160816; b=y1Owbw/MCekDqEZa2mHfpjy263t+g46I/vnxN9uVeaxtOTj3B5ONCIy7IjbCwY3gPt vU3BrC2dI2HSRciZqCr0Q01uf2Jrexn4y9/gmYNP2NP5dPnKDy33F+IAe/T/7eDc7iYZ 1gpumpjQBs5gBwB+3UeX8ioDDgN0WUJ+y9kO+OPo+R78Jj9jfuYEoAiJU4W63f0tFAfV rhrqLqcSsnI+Bl6w0VpRIVkpW8YwX+6F66Isrhm8d+/OZYFAmT0xn+dx16bKsuo7ReAm wfwDaRL1U+GKfCR51dNeCej4udaYBSOvfUgQP09U8pS8GzpoS+aic8d+PpRS8teKwiIX /Gxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qoHya8gK4WxyN5m7VBMHjfaE3l8Bb6XYk+L0IrwzimU=; b=QXUkErMZ6onQnIePIOpi59qGSZSEF2mRrxRXCN6v0xCIdiqnzye8reFx7ZVRpdu2b6 +CstEHbPnV77B130RQq5TLNe9s1bsEl9xPqENndC8oiDK9eym+yKafvogzbCjihacVFh MmaiCkmSvDJoj7fkb1WR+alvqgBwSyqzsvt71Ky44bt5wvlV7GD5Zb5tPnPEU2LSCwp3 CYDFTnethtT37WeumkQLhRvzHgYHmIiKDzs4mVt6l7n6L76bv2MhQ51wwisKt3AxBhLv sUWa/Bwa2fZuNcFMQLytdgH8sVSZntlI15tyS7H6ta+zKIBxYwZ7vV2vHhnURpQmu5HU IdWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vN7FgK7A; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc1si3436610edb.495.2020.11.02.03.24.29; Mon, 02 Nov 2020 03:24:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vN7FgK7A; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728605AbgKBLY0 (ORCPT + 2 others); Mon, 2 Nov 2020 06:24:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728595AbgKBLYY (ORCPT ); Mon, 2 Nov 2020 06:24:24 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 265E9C061A4A for ; Mon, 2 Nov 2020 03:24:24 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id v5so9015353wmh.1 for ; Mon, 02 Nov 2020 03:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qoHya8gK4WxyN5m7VBMHjfaE3l8Bb6XYk+L0IrwzimU=; b=vN7FgK7AgZxvJn6YeBi+P0ktCCfAvqWEQCoVJbdaEPsNdE13QY7S6BlEfbaS0fEltG f+r45txAK9RrlAbrSqby3atEOPYqHElzC+0c3YgCRrRmZOXCdFHHzyxCtOcclBAZwMqP PaObsX5RsPWYbe2Ak5ToZl2uAH1vIjFasEvv+2ka4Pby17tNAr8WbwZC0AC1Oy+wKLX0 lwl2TZ/J/0JTNLJlsgcnOdryqmKt1uiqsxCddZdhmhzFJAXtlvYgynCmy/ekRkpl7Wdo aaGV538zdcV0sJUcP25b63XiLtpuomauPIXBNf+bDnnYTnPLEdKuleRdnDag9ChGih7/ spKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qoHya8gK4WxyN5m7VBMHjfaE3l8Bb6XYk+L0IrwzimU=; b=aKhC2rFT3u5318uD1N6fAnae7r1lG47fWjtYf/cpjFxHFphO7J3c7wTnz48N1Pamw2 S3Zv1vH8nLI7m6OZWBjKZa2mpJ/25tTTB7nP+ATqaktGBc57/bhbN1LbGOKTYcKG7hS2 g0uX7azqXWJzTQfv/SPoUW6L1yLqtbNb/Q3IPx4jLiTt+sxeVl9obJo6UOirasA5fQBD RtwdN58Ye/ScUofZ5oSO+5cPlY2hrsYea8pEnrJEmeXaNdn/9smMO1mDdcHVP3cLkmvU ejvguFrDm4zGCi0egHjVzqv2Dg9h10IaNL3uolCV88gEOtJmgP+8BaeotzPN5qPWeRc0 d0Ig== X-Gm-Message-State: AOAM5334evo4bDcx9rmHGS3B6zWS+eflDH2eyeYCc4j9EjcDmdZAKKh6 TvRuNm1RUOxQhdjqRlRW0xAm6A== X-Received: by 2002:a1c:3503:: with SMTP id c3mr16872354wma.43.1604316262903; Mon, 02 Nov 2020 03:24:22 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:22 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Amitkumar Karwar , Siva Rebbagondla , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 04/41] rsi_91x_usb_ops: Source file headers are not good candidates for kernel-doc Date: Mon, 2 Nov 2020 11:23:33 +0000 Message-Id: <20201102112410.1049272-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_usb_ops.c:22: warning: Incorrect use of kernel-doc format: * rsi_usb_rx_thread() - This is a kernel thread to receive the packets from drivers/net/wireless/rsi/rsi_91x_usb_ops.c:29: warning: Function parameter or member 'common' not described in 'rsi_usb_rx_thread' Cc: Amitkumar Karwar Cc: Siva Rebbagondla Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/rsi/rsi_91x_usb_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/wireless/rsi/rsi_91x_usb_ops.c b/drivers/net/wireless/rsi/rsi_91x_usb_ops.c index b1687d22f73f5..4ffcdde1acb1e 100644 --- a/drivers/net/wireless/rsi/rsi_91x_usb_ops.c +++ b/drivers/net/wireless/rsi/rsi_91x_usb_ops.c @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2014 Redpine Signals Inc. * * Permission to use, copy, modify, and/or distribute this software for any From patchwork Mon Nov 2 11:23:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315598 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C70C55179 for ; Mon, 2 Nov 2020 11:24:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48499223C7 for ; Mon, 2 Nov 2020 11:24:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EjP7BP5M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728627AbgKBLY2 (ORCPT ); Mon, 2 Nov 2020 06:24:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728600AbgKBLY0 (ORCPT ); Mon, 2 Nov 2020 06:24:26 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DF36C061A4D for ; Mon, 2 Nov 2020 03:24:25 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id 13so9030636wmf.0 for ; Mon, 02 Nov 2020 03:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9FRe1RWMH+Ylu+O6C7UB+7j1JllgJXWWCHgzKpeBizs=; b=EjP7BP5M3C9ozo3OlCBonJ+/+JAmTwyGg5DBL+fEJxyatzDpAE1mGujCx4j1CTSiaX 1cGrEaWSm7RiD5emw5QEsnwVzcqy9bFe+a6aUxjwK1cxg6XStfW7PTU1U9peU3uwn5J1 T5RuZZhxJOSfZKfobxmGg4+obtpV+2k9z3fChJiazNd9NzuLWyCQivC8VBlcIlY5+qxm nlAeOLU4o5aaSh1zvT1oYLSnYw/270827twrimYoyLTeuMILHchjT7hmEb7ounnF7YL5 i31414KP446eCiZ6oqXyyieceiob/yYrjt/jO6hko0XzLgrG07AplOC6FDkUVeI8HBv5 zY4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9FRe1RWMH+Ylu+O6C7UB+7j1JllgJXWWCHgzKpeBizs=; b=kJ2zUMMtU0EaTtZ/usGQAozpxlSvqaXX3cTvCa+auPh3XCEi6DXdQrbZJ7I6Eajb6E nd/lQAHaCVq/UWaKprRFgIroduLjVOOrvw48jZPpUmeCpJwUeaTuwuhilR93rioFY0ba pTHvSoABqtdAn0jUx35gWxs8jPd7/mUOPj+pFQGo6jDW4w8ph5lDbsQWC/1gJJybZ7ku TYXZRBDtPMwcCdGUpC/aj6lYeLqpEBwewp5jjOQ9nR3/fJS0HBkrWDiru5K8sEICG+Wm fYTaev8pwTv4k1GGSQt9ppyPMi0zRbvkReFGzzfyXDv926/SY1DtQyGw3Mlmal1jiubG Db/A== X-Gm-Message-State: AOAM532McGTBQkjyNXDKTFJQgh2Xk+sd6FtGeDPXWbPdyVF8z1DMW/FC S3AiupwlFUiIKfA4TBuFRlOcFQ== X-Google-Smtp-Source: ABdhPJzc4a5EERRtVUSuIyyhH7uEsVHTARaRs1aPr519ZyLWI5eoxokOiWIe9CFFu7KT3ISPBjgmpQ== X-Received: by 2002:a1c:3846:: with SMTP id f67mr17643769wma.33.1604316264008; Mon, 02 Nov 2020 03:24:24 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:23 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format Date: Mon, 2 Nov 2020 11:23:34 +0000 Message-Id: <20201102112410.1049272-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:455: warning: Function parameter or member 'txdesc' not described in '_rtl_tx_desc_checksum' Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c index 1ad0cf37f60bb..87f959d5d861d 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c @@ -448,7 +448,7 @@ static void _rtl_fill_usb_tx_desc(__le32 *txdesc) set_tx_desc_first_seg(txdesc, 1); } -/** +/* * For HW recovery information */ static void _rtl_tx_desc_checksum(__le32 *txdesc) From patchwork Mon Nov 2 11:23:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315581 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE75FC2D0A3 for ; Mon, 2 Nov 2020 11:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 871B822275 for ; Mon, 2 Nov 2020 11:28:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="krJnLtc6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728639AbgKBLYa (ORCPT ); Mon, 2 Nov 2020 06:24:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728601AbgKBLY0 (ORCPT ); Mon, 2 Nov 2020 06:24:26 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C9DDC0617A6 for ; Mon, 2 Nov 2020 03:24:26 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id n15so14179858wrq.2 for ; Mon, 02 Nov 2020 03:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2b8n7EMzvBy3k4mEAO2az4D8TS4174dppxeZhXUMuLk=; b=krJnLtc6N+2WBI9zVToa7VVhYxDgv43kZTu2i3mSv8ZTng2O4ydc8z9Sr/myiclZ53 siYeQfgUBEFUge7+bwqSsiJ16l+BB2MBYw9N3+dhVgAOq/q7Fwak+X1rfticLy8rDLRV PBDb8oddR4Accl/4XmaO1d4uEiy4oidROTe0ikOwQxe3u4k6zub7hwpulDY62QaSHZdO MijeI/X6VFwss1zybgeqbVY9PxHD4/+C0hPVPl0mwyUqyOcsOW1xhBysZCNm39jb9Qnx qPH/KZ1rvk7ILqNyg/M3gVzvpi+nuMPXjT6ppTEnjv8geNO4od40Fw/Z4wqL2A3c7Ln/ 0BXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2b8n7EMzvBy3k4mEAO2az4D8TS4174dppxeZhXUMuLk=; b=PLgILs5TXZxCW4sZJUhcSIDHw2Uii8gr2c/xSnYLsZB3DnZ3OVC8rEzrFBcPjFFWZ9 3LxHbK9eSDbMRudK4zpBZq6LeSZf7FEEvnJHGQohQIoORTIuceklnH0MBW5gxOpLseaq SfS6oI+EugUUtHs8IfLN3mODHSpDVMcdsKdxd1hOR7QM/tOiuTTvDbWjpJr3oE6ggg1g UVd95pTiw1h9UV4hvxt6KxtR7DR3bXyQoa1WPx0SjWh15yJ4+9czRpCOCl4WzvpZXL3Y +oN3FGKL4m6yG3GwmQU6JQAdpQHmJB1eYTcSme6iMYbs3K1s0xgXxXFEPfO/YLAMHuI0 THFg== X-Gm-Message-State: AOAM531AC05zdHsI5oFEIDYPKhJuo7/LZPnxntnbtNTIqYI3T42Zn/Tc IAfHVdj7HuRu+w34Vio/humzTz7z2jHVkA== X-Google-Smtp-Source: ABdhPJxdJ5ukETt1lUKOYKlpB7LAtUQfWZ5zkazKTiN1pjYEiL7xs962dlK8ZtSzPM1TeAFLDLlc9g== X-Received: by 2002:a5d:44c8:: with SMTP id z8mr9705045wrr.405.1604316265225; Mon, 02 Nov 2020 03:24:25 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:24 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org Subject: [PATCH 06/41] brcmfmac: bcmsdh: Fix description for function parameter 'pktlist' Date: Mon, 2 Nov 2020 11:23:35 +0000 Message-Id: <20201102112410.1049272-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:380: warning: Function parameter or member 'pktlist' not described in 'brcmf_sdiod_sglist_rw' drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:380: warning: Excess function parameter 'pkt' description in 'brcmf_sdiod_sglist_rw' Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c index f9ebb98b0e3c7..ce8c102df7b3e 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c @@ -367,7 +367,7 @@ static int mmc_submit_one(struct mmc_data *md, struct mmc_request *mr, * @func: SDIO function * @write: direction flag * @addr: dongle memory address as source/destination - * @pkt: skb pointer + * @pktlist: skb buffer head pointer * * This function takes the respbonsibility as the interface function to MMC * stack for block data access. It assumes that the skb passed down by the From patchwork Mon Nov 2 11:23:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315580 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF30FC00A89 for ; Mon, 2 Nov 2020 11:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8236C22275 for ; Mon, 2 Nov 2020 11:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="udOd7bGB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728846AbgKBL2y (ORCPT ); Mon, 2 Nov 2020 06:28:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728636AbgKBLY3 (ORCPT ); Mon, 2 Nov 2020 06:24:29 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 136DDC0617A6 for ; Mon, 2 Nov 2020 03:24:29 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id 13so9030876wmf.0 for ; Mon, 02 Nov 2020 03:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AFvxbCSBD0dyE27qjUGJ2Xb0Ms2F6Ys3MDSISyE2R+M=; b=udOd7bGBOYKR4UprYlENO30OIAdWtb7NI3dl14b2U5dwS3lMoFi3AylTynoEmHqv7z rG1pcwZcA2GODT7vbsuT6GQ8pbldsq6Jeod8EM2YQfV5uxNSuAArsgJRMP1vm76MzIcx QI+9+mvC7fJZoInVjIf8AGVT0tpYx6YOdDl+EezDJ4VWJ/VUGjP3WIJRNERcZh4C0JzO 87/q9MWt02/X9b0Sw1/SQtXKR6aWpxDdZPKLH45i9Qnorx7B4H5dqUFd9GBvrhMz5Fgr ELKdmNunluybHaK6LEIFgCm72LSkMDgX3+gOehmagAtZaHgml1cIAegkCqkA9dKakvGP GeyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AFvxbCSBD0dyE27qjUGJ2Xb0Ms2F6Ys3MDSISyE2R+M=; b=VX1jG3QMduyfHrLuJKAhLsRCBlAK5fKWEipOvUrrQjisw4Y6nmQXIJjrtNHd+9IBZJ 15Biu8TflXqTPp1JcpNiqb223pnYM9XPaLMe/tXjsuXqSTFcRued8I9pez9XM5l4fV7Y vybIZZPgb5L7QF3CtXksYnysgGlz3K6C+ajJ/y4KBN6T1Lr4urJ3XRK04IdCWsht0d7b 9yxvbPDGcV1XS5Z2zoMZVbtCDDeRw6HjTwFPLLOK5UyQZMm9Ahg62DzrHbL07BbzpEiw hZX//U36lO74KVvE5jmticQ/m0AB6p259yJACk9nNlGge0EDFPw2Kfkv9RLDAkrkYMpa VQHg== X-Gm-Message-State: AOAM530hYrYQNjgsCc+ydr/w5aYizVOwk9jyRjnSP58rkV+dcC9XqNFS 7KUGdlcNfN8I53bkopU81Uhu8A== X-Google-Smtp-Source: ABdhPJxV5TIbJuJEaGgVUX4DCaO0rJIH/Q2FlVRkiX97D+yCvj5LLTK0kFVE53PSH8kYpjObYrvtsA== X-Received: by 2002:a7b:c7c3:: with SMTP id z3mr16926849wmk.43.1604316267805; Mon, 02 Nov 2020 03:24:27 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:27 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 08/41] iwlwifi: mvm: rs: Demote non-conformant function documentation headers Date: Mon, 2 Nov 2020 11:23:37 +0000 Message-Id: <20201102112410.1049272-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Also add documentation for 'mvm'. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/mvm/rs.c:400: warning: cannot understand function prototype: 'const u16 expected_tpt_legacy[IWL_RATE_COUNT] = ' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'mvm' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'tbl' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'scale_index' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'attempts' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'successes' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'window' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2677: warning: duplicate section name 'NOTE' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'mvm' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'sta' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'lq_sta' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'band' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'mvm' not described in 'rs_program_fix_rate' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'lq_sta' not described in 'rs_program_fix_rate' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:4213: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_tx_protection' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index ed7382e7ea177..91b6541d579f5 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c @@ -386,7 +386,7 @@ static void rs_fill_lq_cmd(struct iwl_mvm *mvm, const struct rs_rate *initial_rate); static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search); -/** +/* * The following tables contain the expected throughput metrics for all rates * * 1, 2, 5.5, 11, 6, 9, 12, 18, 24, 36, 48, 54, 60 MBits @@ -396,7 +396,6 @@ static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search); * CCK rates are only valid in legacy table and will only be used in G * (2.4 GHz) band. */ - static const u16 expected_tpt_legacy[IWL_RATE_COUNT] = { 7, 13, 35, 58, 40, 57, 72, 98, 121, 154, 177, 186, 0, 0, 0 }; @@ -670,7 +669,7 @@ static s32 get_expected_tpt(struct iwl_scale_tbl_info *tbl, int rs_index) return 0; } -/** +/* * rs_collect_tx_data - Update the success/failure sliding window * * We keep a sliding window of the last 62 packets transmitted @@ -2667,7 +2666,7 @@ void rs_update_last_rssi(struct iwl_mvm *mvm, } } -/** +/* * rs_initialize_lq - Initialize a station's hardware rate table * * The uCode's station table contains a table of fallback rates @@ -3756,7 +3755,7 @@ int rs_pretty_print_rate(char *buf, int bufsz, const u32 rate) } #ifdef CONFIG_MAC80211_DEBUGFS -/** +/* * Program the device to use fixed rate for frame transmit * This is for debugging/testing only * once the device start use fixed rate, we need to reload the module @@ -4211,6 +4210,7 @@ static int rs_drv_tx_protection(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta, /** * iwl_mvm_tx_protection - ask FW to enable RTS/CTS protection + * @mvm: The mvm component * @mvmsta: The station * @enable: Enable Tx protection? */ From patchwork Mon Nov 2 11:23:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315582 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EB0C2D0A3 for ; Mon, 2 Nov 2020 11:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5540A223B0 for ; Mon, 2 Nov 2020 11:28:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U01TdZA4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728930AbgKBL2a (ORCPT ); Mon, 2 Nov 2020 06:28:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728671AbgKBLYd (ORCPT ); Mon, 2 Nov 2020 06:24:33 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D76F9C0617A6 for ; Mon, 2 Nov 2020 03:24:32 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id n18so14132687wrs.5 for ; Mon, 02 Nov 2020 03:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L4fJoUFxGOk+wlfr5ygIh+H6VB2oPqLC6DAqdYBw8oE=; b=U01TdZA4ou+Nb33YQqS94KykKTScklcdisoNL0DDDIpnD65IVWVqxdDzAzh7Tg44nt jUhxnIHWA0PU5JsKht+nwohtNUzIJIJe+6CWAW4CHXGOQsMWnq42abCCxAUGK7DuNuHw PSxa44W40vAb6gRH7hv9ZxIjtEu+GQSdatDckaluWZ53w+SG/y9jBe0GyAW9DjN0ySU7 X4ibisX6nxc48HcX8Bg+oo5VfU0OXAlJISmDWoM5SEju+RFWI8ezbbcUZF2GrJH85LXW TE1Gom/dqJW2TnEUzqWftY+oPyuHTzr+/G++eRgIOnSAVrjOMwjS6JEPjwVRR4iTdDom nfqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L4fJoUFxGOk+wlfr5ygIh+H6VB2oPqLC6DAqdYBw8oE=; b=A3al2EThQ1wLtLVs9kGXHBhGST2lNp8Ju5pVcI/kC/7B+kIH6N0QO+YdoqNLXbIsyY nuWfYb7SRAKm2uzhk+lhL72FyDcY9faso1eeGVd2Dw/nEXVEAQRGCme2kdBc8cc1U+3z EXUZos4b/eOA0Q3gHIdSxZBqy1fMCdwmOxRrvdviXepXEiKUD7z2i7W91ZQK9OovjzTR PWKIP3u4P7u7xbsWun9r4yGxxvAxhV+YpG1niwqWVGye/XX8+igK/j1YLkNu01jtMnLH +DX8NgAwQ5FhpAA3779EOdLgUNt7Igxaxyl4hs27+cpXLYs5r/cYTHiiuBcqbwyOqbK+ KQJg== X-Gm-Message-State: AOAM5310wlTWWunKWZcflsgx5rssZia1H40eyZzVP9w9h99GANk1Fhib RuLNIU8PtxHJlIFQEe/ZAfg7kQ== X-Google-Smtp-Source: ABdhPJzpHltc56zkt1lE0UmaN5fxaSG/K6DQJ9K+LHHIPVp1QiY+GlC3nuPqsKT4skW3MzFmzobCqA== X-Received: by 2002:adf:b19c:: with SMTP id q28mr19225949wra.119.1604316271566; Mon, 02 Nov 2020 03:24:31 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:31 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 11/41] ath9k: ar9340_initvals: Remove unused const variable 'ar9340Modes_ub124_tx_gain_table_1p0' Date: Mon, 2 Nov 2020 11:23:40 +0000 Message-Id: <20201102112410.1049272-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9340_initvals.h:624:18: warning: ‘ar9340Modes_ub124_tx_gain_table_1p0’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar9340_initvals.h | 101 ------------------ 1 file changed, 101 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9340_initvals.h b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h index 2eb163fc1c18f..3da4ea564148c 100644 --- a/drivers/net/wireless/ath/ath9k/ar9340_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h @@ -621,107 +621,6 @@ static const u32 ar9340Modes_high_ob_db_tx_gain_table_1p0[][5] = { {0x00016448, 0x8e481666, 0x8e481666, 0x8e481266, 0x8e481266}, }; -static const u32 ar9340Modes_ub124_tx_gain_table_1p0[][5] = { - /* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */ - {0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8005, 0xd00a8005}, - {0x00009820, 0x206a022e, 0x206a022e, 0x206a00ae, 0x206a00ae}, - {0x00009830, 0x0000059c, 0x0000059c, 0x0000059c, 0x0000059c}, - {0x00009e10, 0x7ec88d2e, 0x7ec88d2e, 0x7ec82d2e, 0x7ec82d2e}, - {0x0000a2dc, 0xfef5d402, 0xfef5d402, 0xfdab5b52, 0xfdab5b52}, - {0x0000a2e0, 0xfe896600, 0xfe896600, 0xfd339c84, 0xfd339c84}, - {0x0000a2e4, 0xff01f800, 0xff01f800, 0xfec3e000, 0xfec3e000}, - {0x0000a2e8, 0xfffe0000, 0xfffe0000, 0xfffc0000, 0xfffc0000}, - {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9}, - {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000}, - {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002}, - {0x0000a508, 0x09002421, 0x09002421, 0x08000004, 0x08000004}, - {0x0000a50c, 0x0d002621, 0x0d002621, 0x0b000200, 0x0b000200}, - {0x0000a510, 0x13004620, 0x13004620, 0x0f000202, 0x0f000202}, - {0x0000a514, 0x19004a20, 0x19004a20, 0x11000400, 0x11000400}, - {0x0000a518, 0x1d004e20, 0x1d004e20, 0x15000402, 0x15000402}, - {0x0000a51c, 0x21005420, 0x21005420, 0x19000404, 0x19000404}, - {0x0000a520, 0x26005e20, 0x26005e20, 0x1b000603, 0x1b000603}, - {0x0000a524, 0x2b005e40, 0x2b005e40, 0x1f000a02, 0x1f000a02}, - {0x0000a528, 0x2f005e42, 0x2f005e42, 0x23000a04, 0x23000a04}, - {0x0000a52c, 0x33005e44, 0x33005e44, 0x26000a20, 0x26000a20}, - {0x0000a530, 0x38005e65, 0x38005e65, 0x2a000e20, 0x2a000e20}, - {0x0000a534, 0x3c005e69, 0x3c005e69, 0x2e000e22, 0x2e000e22}, - {0x0000a538, 0x40005e6b, 0x40005e6b, 0x31000e24, 0x31000e24}, - {0x0000a53c, 0x44005e6d, 0x44005e6d, 0x34001640, 0x34001640}, - {0x0000a540, 0x49005e72, 0x49005e72, 0x38001660, 0x38001660}, - {0x0000a544, 0x4e005eb2, 0x4e005eb2, 0x3b001861, 0x3b001861}, - {0x0000a548, 0x53005f12, 0x53005f12, 0x3e001a81, 0x3e001a81}, - {0x0000a54c, 0x59025eb5, 0x59025eb5, 0x42001a83, 0x42001a83}, - {0x0000a550, 0x5e025f12, 0x5e025f12, 0x44001c84, 0x44001c84}, - {0x0000a554, 0x61027f12, 0x61027f12, 0x48001ce3, 0x48001ce3}, - {0x0000a558, 0x6702bf12, 0x6702bf12, 0x4c001ce5, 0x4c001ce5}, - {0x0000a55c, 0x6b02bf14, 0x6b02bf14, 0x50001ce9, 0x50001ce9}, - {0x0000a560, 0x6f02bf16, 0x6f02bf16, 0x54001ceb, 0x54001ceb}, - {0x0000a564, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a568, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a56c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a570, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a574, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a578, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a57c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a580, 0x00802220, 0x00802220, 0x00800000, 0x00800000}, - {0x0000a584, 0x04802222, 0x04802222, 0x04800002, 0x04800002}, - {0x0000a588, 0x09802421, 0x09802421, 0x08800004, 0x08800004}, - {0x0000a58c, 0x0d802621, 0x0d802621, 0x0b800200, 0x0b800200}, - {0x0000a590, 0x13804620, 0x13804620, 0x0f800202, 0x0f800202}, - {0x0000a594, 0x19804a20, 0x19804a20, 0x11800400, 0x11800400}, - {0x0000a598, 0x1d804e20, 0x1d804e20, 0x15800402, 0x15800402}, - {0x0000a59c, 0x21805420, 0x21805420, 0x19800404, 0x19800404}, - {0x0000a5a0, 0x26805e20, 0x26805e20, 0x1b800603, 0x1b800603}, - {0x0000a5a4, 0x2b805e40, 0x2b805e40, 0x1f800a02, 0x1f800a02}, - {0x0000a5a8, 0x2f805e42, 0x2f805e42, 0x23800a04, 0x23800a04}, - {0x0000a5ac, 0x33805e44, 0x33805e44, 0x26800a20, 0x26800a20}, - {0x0000a5b0, 0x38805e65, 0x38805e65, 0x2a800e20, 0x2a800e20}, - {0x0000a5b4, 0x3c805e69, 0x3c805e69, 0x2e800e22, 0x2e800e22}, - {0x0000a5b8, 0x40805e6b, 0x40805e6b, 0x31800e24, 0x31800e24}, - {0x0000a5bc, 0x44805e6d, 0x44805e6d, 0x34801640, 0x34801640}, - {0x0000a5c0, 0x49805e72, 0x49805e72, 0x38801660, 0x38801660}, - {0x0000a5c4, 0x4e805eb2, 0x4e805eb2, 0x3b801861, 0x3b801861}, - {0x0000a5c8, 0x53805f12, 0x53805f12, 0x3e801a81, 0x3e801a81}, - {0x0000a5cc, 0x59825eb2, 0x59825eb2, 0x42801a83, 0x42801a83}, - {0x0000a5d0, 0x5e825f12, 0x5e825f12, 0x44801c84, 0x44801c84}, - {0x0000a5d4, 0x61827f12, 0x61827f12, 0x48801ce3, 0x48801ce3}, - {0x0000a5d8, 0x6782bf12, 0x6782bf12, 0x4c801ce5, 0x4c801ce5}, - {0x0000a5dc, 0x6b82bf14, 0x6b82bf14, 0x50801ce9, 0x50801ce9}, - {0x0000a5e0, 0x6f82bf16, 0x6f82bf16, 0x54801ceb, 0x54801ceb}, - {0x0000a5e4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5e8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5ec, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5f0, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5f4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5f8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5fc, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x00016044, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4}, - {0x00016048, 0x8e480086, 0x8e480086, 0x8e480086, 0x8e480086}, - {0x00016444, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4}, - {0x00016448, 0x8e480086, 0x8e480086, 0x8e480086, 0x8e480086}, - {0x0000a600, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a604, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a608, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a60c, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a610, 0x00804000, 0x00804000, 0x00000000, 0x00000000}, - {0x0000a614, 0x00804201, 0x00804201, 0x01404000, 0x01404000}, - {0x0000a618, 0x0280c802, 0x0280c802, 0x01404501, 0x01404501}, - {0x0000a61c, 0x0280ca03, 0x0280ca03, 0x02008501, 0x02008501}, - {0x0000a620, 0x04c15104, 0x04c15104, 0x0280ca03, 0x0280ca03}, - {0x0000a624, 0x04c15305, 0x04c15305, 0x03010c04, 0x03010c04}, - {0x0000a628, 0x04c15305, 0x04c15305, 0x04014c04, 0x04014c04}, - {0x0000a62c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a630, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a634, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a638, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a63c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000b2dc, 0xfef5d402, 0xfef5d402, 0xfdab5b52, 0xfdab5b52}, - {0x0000b2e0, 0xfe896600, 0xfe896600, 0xfd339c84, 0xfd339c84}, - {0x0000b2e4, 0xff01f800, 0xff01f800, 0xfec3e000, 0xfec3e000}, - {0x0000b2e8, 0xfffe0000, 0xfffe0000, 0xfffc0000, 0xfffc0000}, -}; - static const u32 ar9340Modes_low_ob_db_tx_gain_table_1p0[][5] = { /* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */ {0x0000a2dc, 0x0380c7fc, 0x0380c7fc, 0x03aaa352, 0x03aaa352}, From patchwork Mon Nov 2 11:23:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC8DC00A89 for ; Mon, 2 Nov 2020 11:28:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A0ED223C7 for ; Mon, 2 Nov 2020 11:28:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dtKvQLdk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728907AbgKBL2O (ORCPT ); Mon, 2 Nov 2020 06:28:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728680AbgKBLYf (ORCPT ); Mon, 2 Nov 2020 06:24:35 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EAEDC061A4B for ; Mon, 2 Nov 2020 03:24:35 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id p22so9018823wmg.3 for ; Mon, 02 Nov 2020 03:24:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=64CEfunw0Swc50bQt2+cwn7fqQh5uT3oHRs6EoyWU9E=; b=dtKvQLdkRazg4ZqZJN35vFHJcRcz7KG5R3YrIIrk1BqWZG52ptG3jTXh9dwINAFFaW jHMJxG3L01KDxZGM8DiRvM0pXhW1sifQQUg3+uI/mTs/IheMZhk9XOu3hEmKj6vFuzTJ J9HtYTh6XGVey5//Z1waQ0U8NaqUDbCX3Ens6q/oVSlUeNI78zF7s/c1dtNNf6jXGElV NKUX+Z3SVyP0aQjr4FH8l9Rvkx2lXRhmqV+xpB8LcmMUSr8WF9Q0nOvVq+hO3cNf4uoF 69/hIIpY/oLAeAvtyQN68f9iPiFqnxPT11Og6kmJu+ARVbxQvjH44yzYyuJlh5LfUgK3 mO9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=64CEfunw0Swc50bQt2+cwn7fqQh5uT3oHRs6EoyWU9E=; b=JhA4yC7oh78V1vgAbioyS5+7iHw4FRbwMk6U8o7dPjoj1jqvEhu44Y1FtcozG6aVfU TFaWa6tNHGsTMRdQn2hjTu1NykNhUq+krVO1OWkR8dgG4FKqGd2LqnNpmKgvo4bc6nBZ Trxx9AK6wClscp0BuIUJai5j7BpVFBiGD7/7o26rZxMMMdeWjIWGJ5WTOWbeWcOe3+yw hQzz+7zwTUQfsnkTZJ1YdjceJH3dQiGBvHVakWvDaxMz76NL0Yc1QHqPd3J1pUADnfE6 WQXGyrFa00QRy1f24C5mwKyw8RfGDveiYz2KQjDUZjzQvNFHnTN/2Iy/y1++l6k0QYLZ GU7w== X-Gm-Message-State: AOAM533sgJU60obFAA7LkIykgz5aaI/0Nvtt/ppYRVDdR8as6Q5ftQce 9LaFTQxhT7ABpC68fddpPNeUSg== X-Google-Smtp-Source: ABdhPJydIfAMGSt1CRrgd5Gr42T55jwHJBn2q8i6Ptcgr3b3uPbIhbh0BRsEugQbufM1iD3B5t8XbA== X-Received: by 2002:a7b:cd10:: with SMTP id f16mr11032536wmj.69.1604316274037; Mon, 02 Nov 2020 03:24:34 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:33 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 13/41] ath9k: ar9003_2p2_initvals: Remove unused const variables Date: Mon, 2 Nov 2020 11:23:42 +0000 Message-Id: <20201102112410.1049272-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1734:18: warning: ‘ar9300PciePhy_clkreq_disable_L1_2p2’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1727:18: warning: ‘ar9300PciePhy_clkreq_enable_L1_2p2’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar9003_2p2_initvals.h | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h index c07866a2fdf96..16d5c0c5e2a8d 100644 --- a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h @@ -1724,20 +1724,6 @@ static const u32 ar9300PciePhy_pll_on_clkreq_disable_L1_2p2[][2] = { {0x00004044, 0x00000000}, }; -static const u32 ar9300PciePhy_clkreq_enable_L1_2p2[][2] = { - /* Addr allmodes */ - {0x00004040, 0x0825365e}, - {0x00004040, 0x0008003b}, - {0x00004044, 0x00000000}, -}; - -static const u32 ar9300PciePhy_clkreq_disable_L1_2p2[][2] = { - /* Addr allmodes */ - {0x00004040, 0x0821365e}, - {0x00004040, 0x0008003b}, - {0x00004044, 0x00000000}, -}; - static const u32 ar9300_2p2_baseband_core_txfir_coeff_japan_2484[][2] = { /* Addr allmodes */ {0x0000a398, 0x00000000}, From patchwork Mon Nov 2 11:23:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320233 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp3645276ilc; Mon, 2 Nov 2020 03:27:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXM2c4efyxSB2BhlnGLdtarMu5E2vpiAjufrldjry6B41hXFQeWr+tmLEk6vwIvlII5F50 X-Received: by 2002:a17:906:ad8c:: with SMTP id la12mr14314734ejb.521.1604316473865; Mon, 02 Nov 2020 03:27:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604316473; cv=none; d=google.com; s=arc-20160816; b=S6A0yiIcHpM8Tf252Q3U8isZHOTMwgJd6T4ftE7FXmrOjc9YuScXO8uHjROxfG9TPV ilHF7054znX3rDN2KVnBZqWkSXuwXY0TxhqJYPSoqMbPzwggVKyG9NmKS7ol5RXwIiJw nmfDpEBRpGFbWuNVIWqtWIJfiBTZj74KC/vvjuflp35hXtsdANFCWr9QG0q/gixlq8PQ U9gdjbrWoBo3+jbBx7pYy+dBb6cVgS259kctIMmPH5KuG1ErvEposvvYmXaYm0BlOmtj ZQveybcm8esJSPoBLaY6WifCuDDFOhe1z1HilKDkEyB3KWm/b1ptP706eEqCU72ZZB4F 2oTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xuBtucNK6orquLtJMKORaW0tLzjtm6vr9NLgmkKGSZ4=; b=Rjk1IbVdFHPrRm7KuJUc1ssSMLuMM5WsmoghcFh3MpJKQwQ8g5EoVeXKFI/F05bCF+ 5Jbpb9zQTimBDO3+MiZ5/nEbTgcwGNZeccVJZO6lYiWpDOeE6WVuWVjchFT9ndJ9NBgx NwMHhQ4uGrnE4DhRoRU5CPVxQXthSk7koZYhPVvOTmi98ixMWVj9DQM3fftpJsUsf776 x8YS+AxgbbfXa+nRc4wgeHiUFMJCr/ws2atzBemjxreSH2UdPUTJYVUCNYZ4qaaIr9o7 slNpus/e3Yn8oepKyKBRbmlu+AO1wX7n3LdDhCvg3RvpVixsUsru8zln5XSPS1MGzqxT ZEnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QvlkOlDa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i20si9854004ejh.16.2020.11.02.03.27.53; Mon, 02 Nov 2020 03:27:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QvlkOlDa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbgKBLYm (ORCPT + 2 others); Mon, 2 Nov 2020 06:24:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbgKBLYh (ORCPT ); Mon, 2 Nov 2020 06:24:37 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94CEEC061A52 for ; Mon, 2 Nov 2020 03:24:37 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id h22so9150906wmb.0 for ; Mon, 02 Nov 2020 03:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xuBtucNK6orquLtJMKORaW0tLzjtm6vr9NLgmkKGSZ4=; b=QvlkOlDalMkDg3/bMvwge5T0Ii+8IuTEkO83EKlfjVa/CW7cw8OD3+zV7urVzsZ2MY GMsyeneq3/3u+RRHGTUUXtGbQdJYVU5v7TaLQW4D9sWNFLRbbe4pAwoNWKQR/nD/RG35 ARq5Hy8NdBltEOOHwcy9cRPwm7KhLeKN/i+CBN8MAzuaUk8b++WerxEB6TO4AKomC+Y1 wDAUtexWJPUD0pJQMpvF3bX2BVnPCGZL5SKXeK9Gy9R5bjbNlvtOPDblxwD34XZ77+xP c9hq/5Sml0YI5zxIIgCXApi6TBTnEX9m/skqJNrV1SjcfzUF76ZozMAfv1UH0uyBf4Wg EICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xuBtucNK6orquLtJMKORaW0tLzjtm6vr9NLgmkKGSZ4=; b=ZaV+yzrlWf+IdQ4vLsf0NIBYsa32nwj45etEVmwt78cWeR6EnZHVJki8jDpKoGhYYm 4tTVg2PzpEYePzFIKaSrnRdSDJjU8KrAYVkITl6sj8X5KKXwxAGkRu25sUVR2LHUKsdi omUVsdwqEuKUwc5pEzlxatcl6Ev60M2WXD3OQXzVswyCKlSwyxgFGqeysYF+FaDxZdzp kKIhT0Hm5RoDU3cqfZujgZTfgeNlUPKok8yZIgMzUe69EwaQXUogBdYVMThjniIP4uc4 Z+QLd3svVHWIxJzFLu51GlQ01PBGO0fokRPVu99vJ732mBBfVtrGDg8uX+J5im83F8i4 MUWA== X-Gm-Message-State: AOAM532eFvUDRhXI/KpBcFGueLBBelbhDmIwzY/aX6OCsh8gAjO9P5c3 aN4pu0OqQ9BzVuNQNHwcliPG/Q== X-Received: by 2002:a1c:3503:: with SMTP id c3mr16873385wma.43.1604316276365; Mon, 02 Nov 2020 03:24:36 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:35 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 15/41] iwlwifi: iwl-eeprom-read: Demote one nonconformant function header Date: Mon, 2 Nov 2020 11:23:44 +0000 Message-Id: <20201102112410.1049272-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'trans' not described in 'iwl_read_eeprom' drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'eeprom' not described in 'iwl_read_eeprom' drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'eeprom_size' not described in 'iwl_read_eeprom' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c index ad6dc4497437e..1b2d9fd82a3de 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c @@ -335,7 +335,7 @@ static int iwl_find_otp_image(struct iwl_trans *trans, return -EINVAL; } -/** +/* * iwl_read_eeprom - read EEPROM contents * * Load the EEPROM contents from adapter and return it From patchwork Mon Nov 2 11:23:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFC1C2D0A3 for ; Mon, 2 Nov 2020 11:24:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31EBE207C3 for ; Mon, 2 Nov 2020 11:24:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i3uJLVTT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728715AbgKBLYn (ORCPT ); Mon, 2 Nov 2020 06:24:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728701AbgKBLYk (ORCPT ); Mon, 2 Nov 2020 06:24:40 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0F0EC0617A6 for ; Mon, 2 Nov 2020 03:24:38 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id c18so9019163wme.2 for ; Mon, 02 Nov 2020 03:24:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LgKtNmQfGnZeeFNwZJm+JSbHcTG8sEx1i9uktjmVfHw=; b=i3uJLVTT+f1uHk778AEbxWbp76ef0Zolzm5KhEUJI9JMCrAutQejRy3I8vLNlEeQMa 7QsPuO7mYdtDdQPy5te+frEyNqP4eOg9FSoB1FxNCQwIu/5SMAFrABvUWPXVMPdw+tM6 IIByy21e8J0g+HlK1QLEppXXgKNueApiZGeVkQXQ249AvgfuLGTd8wEKwL+ynaX6/Bfl vKaIQQB33RZhn28DxarVzKPBnF7qRhG/6oSaLMeV/bpkUGonKIbcZgJ5SVF2/TM9/lNv ogtDfWzmSUa2V7A9IC4dcbfww2TZ8o7UR8tJhfohL8kuIxfnngeDbCewvWl12nI1MwQN qbcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LgKtNmQfGnZeeFNwZJm+JSbHcTG8sEx1i9uktjmVfHw=; b=qkUvIG+StQK5zwKW7ccZzQm9Wbbj1K/CqxoKzvzej4SGigYBhISS74CQsP7wrAadSj bfzbVIsOXByKqUvAgA9T7axGnyNLhLsgV6H1JwtGPdVna2pXue0RnzMjpZtGIPHCJEBA IMPtZ/j2eKLTFX6hSYgnqGDs8Vcer1t7ldTB0W2Cm+SykhXgw3FiqDAWIHzhkcxszMQC 80k79VCDh7PLpxMZPTCjUPRWoTI10Z4QzXMSQfD/FY29a9Tmk5K/AUDA13Up59bC8qEH f7agEW0gQHgx0E/k/cUcqxOGAvUx7bofqE4PXDkOOegyzFR1bbW34faKWU1miHXJoYq/ 6/bQ== X-Gm-Message-State: AOAM53291omUVmScRuy6D+9KYFC308ogE8vF6a9FbLH8WcC1EnM1oTHj HvBzjgWPzv09MlpTa7/2w9jTow== X-Google-Smtp-Source: ABdhPJyAOYg9hMZPlI3j1Yh7cVoiGhT7yXwb4qjsxPf/PAekthok34p1zg7w7Ge5Mj8+HqUqIhCyLw== X-Received: by 2002:a1c:2c43:: with SMTP id s64mr17006821wms.130.1604316277548; Mon, 02 Nov 2020 03:24:37 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:36 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 16/41] iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's header Date: Mon, 2 Nov 2020 11:23:45 +0000 Message-Id: <20201102112410.1049272-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c:340: warning: cannot understand function prototype: 'struct iwl_eeprom_enhanced_txpwr ' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/intel/iwlwifi/iwl-eeprom-parse.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c index cf7e2a9232e52..f29d5758c8dff 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c @@ -324,15 +324,15 @@ enum iwl_eeprom_enhanced_txpwr_flags { }; /** - * iwl_eeprom_enhanced_txpwr structure + * struct iwl_eeprom_enhanced_txpwr * @flags: entry flags * @channel: channel number - * @chain_a_max_pwr: chain a max power in 1/2 dBm - * @chain_b_max_pwr: chain b max power in 1/2 dBm - * @chain_c_max_pwr: chain c max power in 1/2 dBm + * @chain_a_max: chain a max power in 1/2 dBm + * @chain_b_max: chain b max power in 1/2 dBm + * @chain_c_max: chain c max power in 1/2 dBm * @delta_20_in_40: 20-in-40 deltas (hi/lo) - * @mimo2_max_pwr: mimo2 max power in 1/2 dBm - * @mimo3_max_pwr: mimo3 max power in 1/2 dBm + * @mimo2_max: mimo2 max power in 1/2 dBm + * @mimo3_max: mimo3 max power in 1/2 dBm * * This structure presents the enhanced regulatory tx power limit layout * in an EEPROM image. From patchwork Mon Nov 2 11:23:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315584 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04CE4C00A89 for ; Mon, 2 Nov 2020 11:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D16322275 for ; Mon, 2 Nov 2020 11:28:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QStDp87E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728740AbgKBL1z (ORCPT ); Mon, 2 Nov 2020 06:27:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728702AbgKBLYm (ORCPT ); Mon, 2 Nov 2020 06:24:42 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47B3AC061A48 for ; Mon, 2 Nov 2020 03:24:41 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id a9so14113026wrg.12 for ; Mon, 02 Nov 2020 03:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qpDdLuf0XmFXhoeCc8tXmAL5epac8Q54EhVeHTK2ADw=; b=QStDp87EefLAQ0xGJp3v1XG9HoP6I2H/6oI26lKpv0EUN4GRH2LcnNrukE05yCl0jp WRCbr02WX3ag4/XpO5So+3kxDEXlavNHMcaCVzy1xxT9isEburuXPrJw4fSCbuqJx+m6 BFJbVQgtoYKKs8EYPOxauS4uCH6Xwxh3rnHz4XDOkjUWXGl00sxJTQtIrxSBuL/j61zY FmsZlE8JC6H4CSOUfkFpCgNpJ8fQG1rVBiRwGlYlCLiSS2iDMD0vILqn44ZJEF0JcF6Y S8pz+FOjpFn8lVkphoFj1R27oN+YghlqDmQNRq9ewmXDpXogxFWgB/1p3pUKgDvuP0li J8FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qpDdLuf0XmFXhoeCc8tXmAL5epac8Q54EhVeHTK2ADw=; b=q/BuM1K4TU38JCCdenLY8sE2xZSvjU1MZvXXSDlyhFWvFKP/bG6jb2y5Z7v6xOTX+F pVwDvBTzLOFVZ6GlPyCHZpOAD2vhPBLl9jxTtCBbcsTjSfogTkNWRZEhNAg4tzoGIgEt UbO+p75BhCZW5yWKfs/SwQVnmcI6/GefXyfj7+AdgMCbjucCArFTGj2jTp4hMFIWwgw/ 8d2plfK49P/jSDnKOKmDzHVA5oFnNLKcteZh8HxDSVJm/EZEDEcLkJgc5qtRkWSGLWOL hVMgNC1BYBD3KOankYbqWv5OWi3kaBWM3m6DVFeOswWlK8ZrUoo1I7OA0s29AWKHINhl EzCA== X-Gm-Message-State: AOAM5323mkSqJrXC2bbQGuQeqRVpiow4K3fwu5yycb1e52AmcOVn5ths GHEsW40dB411X7l9G6GCBleoWQ== X-Google-Smtp-Source: ABdhPJw3NvquUovDiM9NpuyGkN81PEgqbBFf/hSnyh+5ZVhWq0aZtZb3MOCJzu17flNBgogtpH4Tzw== X-Received: by 2002:adf:e64e:: with SMTP id b14mr19582007wrn.68.1604316279996; Mon, 02 Nov 2020 03:24:39 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:39 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Jouni Malinen , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 17/41] intersil: hostap_hw: Prevent incompatible function type cast Date: Mon, 2 Nov 2020 11:23:46 +0000 Message-Id: <20201102112410.1049272-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_init_local_data’: drivers/net/wireless/intersil/hostap/hostap_hw.c:3173:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type] drivers/net/wireless/intersil/hostap/hostap_hw.c:3175:2: note: in expansion of macro ‘HOSTAP_TASKLET_INIT’ NB: Repeats lots of times - snipped for brevity Cc: Jouni Malinen Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/intersil/hostap/hostap_hw.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/intersil/hostap/hostap_hw.c b/drivers/net/wireless/intersil/hostap/hostap_hw.c index 22cfb64526448..c877b677505ed 100644 --- a/drivers/net/wireless/intersil/hostap/hostap_hw.c +++ b/drivers/net/wireless/intersil/hostap/hostap_hw.c @@ -36,6 +36,7 @@ #include #include #include +#include #include #include #include @@ -3169,22 +3170,16 @@ prism2_init_local_data(struct prism2_helper_functions *funcs, int card_idx, /* Initialize tasklets for handling hardware IRQ related operations * outside hw IRQ handler */ -#define HOSTAP_TASKLET_INIT(q, f, d) \ -do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \ -while (0) - HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet, - (unsigned long) local); - - HOSTAP_TASKLET_INIT(&local->info_tasklet, hostap_info_tasklet, - (unsigned long) local); + + tasklet_setup(&local->bap_tasklet, hostap_bap_tasklet); + + tasklet_setup(&local->info_tasklet, hostap_info_tasklet); hostap_info_init(local); - HOSTAP_TASKLET_INIT(&local->rx_tasklet, - hostap_rx_tasklet, (unsigned long) local); + tasklet_setup(&local->rx_tasklet, hostap_rx_tasklet); skb_queue_head_init(&local->rx_list); - HOSTAP_TASKLET_INIT(&local->sta_tx_exc_tasklet, - hostap_sta_tx_exc_tasklet, (unsigned long) local); + tasklet_setup(&local->sta_tx_exc_tasklet, hostap_sta_tx_exc_tasklet); skb_queue_head_init(&local->sta_tx_exc_list); INIT_LIST_HEAD(&local->cmd_queue); From patchwork Mon Nov 2 11:23:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320209 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp3643386ilc; Mon, 2 Nov 2020 03:24:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7KqxY/lQFbug9Yr+mVtuNinbfCfjH8ed/+Tjn9BK3xhK1IGFCAJDtlzFheE+7QoquGopo X-Received: by 2002:a17:906:804:: with SMTP id e4mr14409535ejd.420.1604316290481; Mon, 02 Nov 2020 03:24:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604316290; cv=none; d=google.com; s=arc-20160816; b=v7ibxRKqatwPyN4ZX60MQbZNWf66mP3CtHuI2A153Mm8DXrX7dXjvNY9+B+yPeqbLY DK3XQQ/oQeDgyG08ELek66X3RPmxb6DpC9aZw2tLzqbxHl4QlGMVdJ52mcCkxpT1z8Ca JX9SfZ6xopR5VsdvXjNQmhymqWg1EqRH/LHlIB1wjKtWJaNK95GCclWoojuvuXPfy4N2 5ImNkQzLTfzan2KqGai0oWKxwRrziv1bW1U24bE0iy3SToG2aboIeWGkYWUQVhxKCF8Y 3NN5MZmvPMQIR06mUHda21JCQw8W1gUYqLJihSHX3pHnWixBf+xtHflxm5Dp1+y1gN/w wcMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D3cuHd2jEUylto64ny3My89MZqKNpm0uIQ6VIWr/6yc=; b=U2hxGMB9/nqNDpUm1m++Y6/JvSjXmqvnKGm12DPRx9jQDQ+pBYO55SyD9p1b2nIm7L qfL+x2oFjaxOybLDAreLxOm3/bFG47UkTRC8nYf27uU4uimYsUftdA0MixXxOYNeqcI0 6w1PVHvXPGO3yOmv2th28t+8ZDvMd58Ajm/o2pbvRaZ37lylJjSks06QwJAcJ1c+mn1d EPyHlgHi0us5Mue6ko+YLCdcz98BJ4b1I8VnXxAlIOocuipaOt1jr+7WenbN4iC1+Tpk qMwWYquheJQX7qhd8nY3Q21PZrJD9c0sLO53nfFvp+LuZBpRwbzKhEbVvIIuZJeRb+/5 7Bng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dnwc/0wc"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si10976046ejd.641.2020.11.02.03.24.50; Mon, 02 Nov 2020 03:24:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dnwc/0wc"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728732AbgKBLYr (ORCPT + 2 others); Mon, 2 Nov 2020 06:24:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728724AbgKBLYp (ORCPT ); Mon, 2 Nov 2020 06:24:45 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642DEC0617A6 for ; Mon, 2 Nov 2020 03:24:45 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id w1so14164841wrm.4 for ; Mon, 02 Nov 2020 03:24:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D3cuHd2jEUylto64ny3My89MZqKNpm0uIQ6VIWr/6yc=; b=dnwc/0wcVwBYP3pEeQaNCoPL1Qzo0Oep6UPa2V7evv+cCkyMgSryELcMxMSWPupDD5 NEGtO0y3TBTdq1EelpQn/cRj+lZXhBudOBeGyVz1Kd3AiETmflhUA1LNhvoIkDbHEpFW G9CZ/o5FGS+gx2UtgtoJWOwtBxJWnqMgmql/aM4SyXhMoTAYua2VA9SI70nkOPSv21DN R6sr6qTihcaw4XxI137BWr+lVQ2HXNITZ/Q/e18vfb8nH8XqdVcq4sQtftbyX6hflRB1 iysFNqf5927Q16p321KS1SYsv/QhXotxvqEwbJwBRG+gQxlL7WQAmHrjLajjfwUeTClM mvHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D3cuHd2jEUylto64ny3My89MZqKNpm0uIQ6VIWr/6yc=; b=oQ9CoGLpofCMzaqcoQLhL92hcJQCQFNQgnqdjAKBxvGotYkrIzB1czOiBV40TsBrqF cBcExRTXo7kCB+w/bwqclcuSbeFlKKtQbL+9vC13Md2IVdKCiVOO+DxiX2fcTf6SJ0f+ SKO8FjJ9DWrop2YGD755BdzSOKWdmG3bz8E8buafLi21G0mVuC7p5oqDANThJaxkW9X1 9lrzxViXm20WLMf7BE8M30ZkuFIVKMEoImaB+HLj4AT+JPkjjPLyLHd2aBQIjcx2fUxp qZJi8IrHNQKy3NQ8lFBUlybeazFA161VHTI52gDNw7a/1HwtDvWKOb7GtXaXrHcpZ7qg PhGg== X-Gm-Message-State: AOAM530I9hzgn39659swjwtA7qMep8HdOmeaVTqLVCOSCpQt+OZ/lJrZ 3qDT6HEioem/dhuKcNXMFcmkrA== X-Received: by 2002:a5d:4443:: with SMTP id x3mr18862767wrr.190.1604316284171; Mon, 02 Nov 2020 03:24:44 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:43 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org Subject: [PATCH 18/41] brcm80211: fweh: Add missing description for 'gfp' Date: Mon, 2 Nov 2020 11:23:47 +0000 Message-Id: <20201102112410.1049272-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:394: warning: Function parameter or member 'gfp' not described in 'brcmf_fweh_process_event' Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c index 430d2cca98b33..bc3f4e4edcdf9 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c @@ -384,6 +384,7 @@ int brcmf_fweh_activate_events(struct brcmf_if *ifp) * @drvr: driver information object. * @event_packet: event packet to process. * @packet_len: length of the packet + * @gfp: memory allocation flags. * * If the packet buffer contains a firmware event message it will * dispatch the event to a registered handler (using worker). From patchwork Mon Nov 2 11:23:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A36DC2D0A3 for ; Mon, 2 Nov 2020 11:24:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF4D6223AB for ; Mon, 2 Nov 2020 11:24:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ez8EvAVT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728743AbgKBLYs (ORCPT ); Mon, 2 Nov 2020 06:24:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728729AbgKBLYr (ORCPT ); Mon, 2 Nov 2020 06:24:47 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADA95C061A48 for ; Mon, 2 Nov 2020 03:24:46 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id p22so9019282wmg.3 for ; Mon, 02 Nov 2020 03:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NkVHgZnw6Lei6IsVvRK9pUiVE1+hhckfR+9Br4cSPrE=; b=ez8EvAVTfpRWg2qZDGdhqb/Q5VPr+2CBWNYKefZgSKiRQdlbzFY5DBhRXdmI82cUaA 2czwr+KpxFVOjtVHTRFZgXcAsnrPwyB3rJLw4HgbQz5dg92LmGZf15kaL9q3giZU6UFw HrgplcJXd4XvX4dhc90Z574Ub5yVhFSMv0WzQWAiCVhBTX0sSieje52/UjU06zDJ/FDR eLABOmzs7OPq4xW/MwkA+62zbGUmkouD/4eDdPhpERK7B2ZWg9GUe2ZU+NSBaMpPrK+g y5qGtgwWP19jLcIpZfes4VfbXSo9ej37waV/ydOxGttqe+e+QNEb3+cg77RINw/PhDtp zd3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NkVHgZnw6Lei6IsVvRK9pUiVE1+hhckfR+9Br4cSPrE=; b=S2JDQBCaeuBp5AHdxmy2xy237TPhU1f5Vlp1oxPb4QZXrUtDwRLXAh3y5VRhX1z9G9 AILYOsVfXQ+1CFNEEYOUPQS3HVDG0clkL0a1ORlCAUuiGmqkQOswhag7dK6YEeUzbpG7 HAWfUcllN779wBAR+wGo0bcH9Y1ZqSNePfS39y31Cqzm6v1NdjgVymQKR51E4S6ybR+m MJMfVUWGY7UTj28kbkeXYb2CMaZHXSWP9f8TshrqZrnLdpVst/r29K3bJL9tUAUNOvop rm0s5w794bw8cJ4Y7+iDnpd0PucM+wlI0MX3iZC0ZXVp29NKip5IIbDukv8T4DZX1XEj mpNg== X-Gm-Message-State: AOAM532odQS9BYKqMyosCAat4mSMI98Z1V6UQzAryYmFjSO70LKeN+Jl VfkUGY3T/GdI4hjGxxLkPK3aPA== X-Google-Smtp-Source: ABdhPJy7cfrla+KZZUDcnIsAf21G3KKaAzT3Zj90a4wTrKPjr9zmiJQA4cos7MCxYFjuhOaNdLYJCg== X-Received: by 2002:a1c:383:: with SMTP id 125mr17957165wmd.175.1604316285441; Mon, 02 Nov 2020 03:24:45 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:44 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 19/41] ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param Date: Mon, 2 Nov 2020 11:23:48 +0000 Message-Id: <20201102112410.1049272-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/regd.c:378: warning: Function parameter or member 'reg' not described in 'ath_reg_apply_ir_flags' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/regd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c index bee9110b91f38..b2400e2417a55 100644 --- a/drivers/net/wireless/ath/regd.c +++ b/drivers/net/wireless/ath/regd.c @@ -360,6 +360,7 @@ ath_reg_apply_beaconing_flags(struct wiphy *wiphy, /** * ath_reg_apply_ir_flags() * @wiphy: the wiphy to use + * @reg: regulatory structure - used for country selection * @initiator: the regulatory hint initiator * * If no country IE has been received always enable passive scan From patchwork Mon Nov 2 11:23:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8AAC2D0A3 for ; Mon, 2 Nov 2020 11:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9A43207C3 for ; Mon, 2 Nov 2020 11:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D6UrFCbN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728783AbgKBL1h (ORCPT ); Mon, 2 Nov 2020 06:27:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728741AbgKBLYs (ORCPT ); Mon, 2 Nov 2020 06:24:48 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D498FC061A04 for ; Mon, 2 Nov 2020 03:24:47 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id n18so14133610wrs.5 for ; Mon, 02 Nov 2020 03:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OAyFBnkzLiaZhl/JnY/CqxtoMQBIM48e3o5HHcfQRSE=; b=D6UrFCbNnbIMKjVgRasS/TVPF0VFgetQBPCgu22jy/5xPEaU/MeB37127gXhnJ2Q/v 9B8Dc/D11Iuhl9l0wkkX0tPQE/JYuxjYpSYoGoy7jy2VuYHuxGBU+JKVU3ezNh0d6F5L XQRJruZlUj2caVSprleh4QEvkGtsM4Bbz4qxkpPkQYLZzrkOPep5NdtrCCyNb68pNkk0 v/3Guv2tYwpyktPn0vilkm7u2eird8Zcx91kYjKNWNXW8efOmE9dlBCs97tfxwpsbZqm XR2EeJuKuB/yGHZiYgjMnQD14vwlRc9Z8sv/+5xPM2o6nUznn/MjCgolB3+x/LB5UcHM 4tSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OAyFBnkzLiaZhl/JnY/CqxtoMQBIM48e3o5HHcfQRSE=; b=gujotsu+MUBdyOB36Pz6kxZ6RZ7JrIOjDCWXVxqNQilbafODy+wA1y1QzhCmZtIch/ uhgA07rGfbBnwRRgSye6X3JGogYEigS7dvsnWEv7KOUebg8ye3ofRWaCnjdADLUqYRzD Omcns0Fu3iAVcRQi8vac10x4WrehsaqqmnJm1h1pIfYWJsTJG7xIWtwT0SFoZ3SAJT/a KdS44P49rI+0w7DsVSSuzVz/PXkxanW12dTFyWcyfFJvKIIlPm3BjDIuEMO2v4oe/Ckr eYv7BJDEfLdZ+MWroiuG6UokeXorwmuG40/Ug+vG8Xq5xMcogbyUem+HLyFMLlAx3WL7 jL1g== X-Gm-Message-State: AOAM532ANtelW0vsGt5LWSIVX55bE69n86Q3j076rwUqbtmYoy2+ORta 08svqAtWEUbidUonxVEwaoCbaA== X-Google-Smtp-Source: ABdhPJz9zMcwVD2AX9EtfnH8vy23WmMsvpYeEmhm18hnzkcD7bKocVRmvzyBo2IqrL3PWlu2YTNv9w== X-Received: by 2002:adf:aad0:: with SMTP id i16mr19166015wrc.270.1604316286561; Mon, 02 Nov 2020 03:24:46 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:46 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 20/41] ath9k: ar5008_phy: Demote half completed function headers Date: Mon, 2 Nov 2020 11:23:49 +0000 Message-Id: <20201102112410.1049272-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'rfBuf' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'reg32' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'numBits' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'firstBit' not described in 'ar5008_hw_phy_modify_rx_buffer' Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c index 2fa30834a88db..6610d76131fa8 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c @@ -102,13 +102,8 @@ static void ar5008_write_bank6(struct ath_hw *ah, unsigned int *writecnt) REGWRITE_BUFFER_FLUSH(ah); } -/** +/* * ar5008_hw_phy_modify_rx_buffer() - perform analog swizzling of parameters - * @rfbuf: - * @reg32: - * @numBits: - * @firstBit: - * @column: * * Performs analog "swizzling" of parameters into their location. * Used on external AR2133/AR5133 radios. @@ -198,10 +193,8 @@ static void ar5008_hw_force_bias(struct ath_hw *ah, u16 synth_freq) ar5008_write_bank6(ah, ®_writes); } -/** +/* * ar5008_hw_set_channel - tune to a channel on the external AR2133/AR5133 radios - * @ah: atheros hardware structure - * @chan: * * For the external AR2133/AR5133 radios, takes the MHz channel value and set * the channel value. Assumes writes enabled to analog bus and bank6 register @@ -430,10 +423,8 @@ void ar5008_hw_cmn_spur_mitigate(struct ath_hw *ah, REG_WRITE(ah, AR_PHY_MASK2_P_61_45, tmp_mask); } -/** +/* * ar5008_hw_spur_mitigate - convert baseband spur frequency for external radios - * @ah: atheros hardware structure - * @chan: * * For non single-chip solutions. Converts to baseband spur frequency given the * input channel frequency and compute register settings below. From patchwork Mon Nov 2 11:23:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315586 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D8AC2D0A3 for ; Mon, 2 Nov 2020 11:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77C102084C for ; Mon, 2 Nov 2020 11:27:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y/qfMlkx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729012AbgKBL1X (ORCPT ); Mon, 2 Nov 2020 06:27:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728753AbgKBLYu (ORCPT ); Mon, 2 Nov 2020 06:24:50 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48FA6C0617A6 for ; Mon, 2 Nov 2020 03:24:50 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id v5so9016558wmh.1 for ; Mon, 02 Nov 2020 03:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E25/s2pmN1jYHUWPVit1bHGpEi6jEbn1M/6HbkBpU14=; b=y/qfMlkxdFYqOzWrUJ9QNcoitDW3Ls+4vf94dQSMqWvfn4wwGRR2L5xdB8usA2XhFk 3Wdhz6lNJyMizJWRaGYVClmom69SbhI1us6nc569hYPZ/PJrJXcmnAqKISI9ptls9mu3 iXXLb0yD2oeeopOC02ORCoa06LltZ0znjUZCC2iZSlq6I3DwdYwxcHzLVkWh2RRrAq5n 5QPuMNOuSNtDdd8cMDWj33wYmuQAnsMdRBkRQA9YsS2iH5+vjobysZA7syT11w0KLlGe eZ/keguqXtxten2A0rmJwXzbe27eVjeIJv7k12JWAhphViJ6ctJOFHZvJyUcL/wW3TvC 0/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E25/s2pmN1jYHUWPVit1bHGpEi6jEbn1M/6HbkBpU14=; b=RL1fmIUThHNaUrYg8EVZjzqptWiqCHdn3T+Cc1JMBh3EXL264+FUu5lASbHjpfRLrp mj5qsDDC7HBihfX1z69PyUDxH0nRnsIz+9xhA6WnlLcNDOHJSLkJeqV9zPthZ1UV7bA4 qHlAORrfTQVjA6VLl8r5nQTIWfEM40rjWhz6b2ww/jc+zcWYeRpRW/3gt1a3jokHxcgH V8yffBK+rGbM+CnuDMISNcyxcMQWBHyiEdT6gwucFDHQoiUmpfcqQaYH8s7jA68S4Oso q8f+HIZ6o6tzYE4OiD2dBnK0X3Kt5yT2/DDD1/4eB8bLV4KN2wMtqUZw2Y5VAGMDZfsR A/iQ== X-Gm-Message-State: AOAM532wx0IkiDBVI9Z1QHQfXkuToqseFpczKo7s7BrgjAy86HU4Llxk WuJo65MvJeu0y7N6hoPKxMBXAg== X-Google-Smtp-Source: ABdhPJxHeWN46kV3sURaqPANCEeiA/IS+Ig/W6m/olDUAvHUcPjp3HuGNwBjIBRHRhFI34Q+V5TZDA== X-Received: by 2002:a1c:6856:: with SMTP id d83mr18118799wmc.13.1604316289023; Mon, 02 Nov 2020 03:24:49 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:48 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 22/41] ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers Date: Mon, 2 Nov 2020 11:23:51 +0000 Message-Id: <20201102112410.1049272-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There are only a couple of these and none of them are conformant. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/dfs_pri_detector.c:39: warning: Function parameter or member 'head' not described in 'pulse_elem' drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'val' not described in 'pde_get_multiple' drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'fraction' not described in 'pde_get_multiple' drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'tolerance' not described in 'pde_get_multiple' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/dfs_pri_detector.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/dfs_pri_detector.c b/drivers/net/wireless/ath/dfs_pri_detector.c index 05b0464c6b92c..d07c454c9c00d 100644 --- a/drivers/net/wireless/ath/dfs_pri_detector.c +++ b/drivers/net/wireless/ath/dfs_pri_detector.c @@ -29,18 +29,17 @@ struct ath_dfs_pool_stats global_dfs_pool_stats = {}; (MIN + PRI_TOLERANCE == MAX - PRI_TOLERANCE ? \ MIN + PRI_TOLERANCE : RUNTIME) -/** +/* * struct pulse_elem - elements in pulse queue - * @ts: time stamp in usecs */ struct pulse_elem { struct list_head head; u64 ts; }; -/** +/* * pde_get_multiple() - get number of multiples considering a given tolerance - * @return factor if abs(val - factor*fraction) <= tolerance, 0 otherwise + * Return value: factor if abs(val - factor*fraction) <= tolerance, 0 otherwise */ static u32 pde_get_multiple(u32 val, u32 fraction, u32 tolerance) { @@ -70,7 +69,7 @@ static u32 pde_get_multiple(u32 val, u32 fraction, u32 tolerance) return factor; } -/** +/* * DOC: Singleton Pulse and Sequence Pools * * Instances of pri_sequence and pulse_elem are kept in singleton pools to From patchwork Mon Nov 2 11:23:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320212 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp3643451ilc; Mon, 2 Nov 2020 03:24:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuQR6klA5e/GrT5kxBeDrB5VQzAbkXsSlVThusX59NBMd7bGFMt+kP/LktClHWKil0BT6z X-Received: by 2002:a05:6402:4cd:: with SMTP id n13mr11221880edw.127.1604316296676; Mon, 02 Nov 2020 03:24:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604316296; cv=none; d=google.com; s=arc-20160816; b=DiagGviQzNB1mMBsfHw/meHjl+P5PusV8uMc3mJMmf4P+rk9SRq3lOTer7s9GU6mzY /gqXRwr8IJlQw1WXOC9tKNFaT1VzBxrERc3vefN2TO+eNf38zNumCWerhZEdD+Q3baLu 2WtaiKBO2Tu3mHaKVXKyGNe+F19UZxMcblq+PFORaC8MtvgIycq4Hitp+lYk0zc1lcnw azHlAlGpZRnH0AAaCOWKaQUm65gUwMiXZo/WdvCCkJQKUtOQLs3RW2J+0QWpW+Tje2px zx/m0SdNF6c8dV0DO19jW26PVOtYw4qdIAyPyYt6soWUR5tQ/EJ1PqOYpC44+8I4aYff Km4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=O00sHeoq7zqB2CJlcbUNyhU2GOaz7UJ685HbihqjKQM=; b=O0cuzKWT5bcMqCsywx1Lce2jJjo5iphCRS5EnQr34qvOdC1N8/qVCQ0QHpzBs/qo1K Hj/97HchaUsczCgQVNJnvr/bRNupvge6tMAdK9QTB5gb2Vlt4C6lqIr50q7nSErHjQBG UdEkamcmu3kXlw+rXiLl12Zv06JRZTfJbYAvM2HTAwzlL6dM9QNoXtaJqDguVayEt/6T 4lOjHrE1mqCQpOdg36QyM0mcpLgHx32WuKVdUqI3TAC//GCbjDacYXRqdHZg1SiDDkZ2 AVG9AbVLY5L9dodJ/j9YcYS1VemnAml/b0npcciOFDVaKU/eeLmOLV4EYuQKcaxR/OK2 C3Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FxCRoUbj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si9932931ejr.323.2020.11.02.03.24.56; Mon, 02 Nov 2020 03:24:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FxCRoUbj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728785AbgKBLYy (ORCPT + 2 others); Mon, 2 Nov 2020 06:24:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728770AbgKBLYx (ORCPT ); Mon, 2 Nov 2020 06:24:53 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3EEDC061A47 for ; Mon, 2 Nov 2020 03:24:52 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id c18so9019753wme.2 for ; Mon, 02 Nov 2020 03:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O00sHeoq7zqB2CJlcbUNyhU2GOaz7UJ685HbihqjKQM=; b=FxCRoUbjgVNKk7HNy0zfK7Ysq7fk/pGHTzojrVEkM6DLmw3ICYot6hqkuW9TacfsS7 C1JitGKDV7nsumoh2YZSgBmp8X0Pbhtqo1bcQEHkwWjEDqef70DDjyndMdNy3lv8L8Lv CoivpKFBRslyMBL1Ae1LhHyziMeAPQkfdDVoN3iKlIZ/nOat4K8npipMSv6xug2OjzJC BoRviZDr/B42KExznjrNo3szFW3PcHnRK553HPrEwFHCh4LZRpO8bODHTJDyDaChy1R1 ZIwqwnbSJmlup0QvMKaJBM3kKI7rkB0RsVdgF6Dz5Fc/kCoSDGafT72YM6xOf/eiDOze yHFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O00sHeoq7zqB2CJlcbUNyhU2GOaz7UJ685HbihqjKQM=; b=OBj+IEJ/RzJWaOL/if3TSyCxAyxMaAaso/LJFH7hTJ1PPiWc7x9F8RL+0V3LWFy97N anPCo0joYi8FGzowIE00JthSwRhZba8X5hcMz54RAGByoAyvFatjBW9Ib1LUJPYAxk0A FyPU77gwgksKYKhRgP8p29BhA+Nl4zicifGASdnIaOvvvP3sc7Uo0gDNyNgbVGjiKJPQ NRtbHc72FpfXV0sfm1EaAb4qyjEUc2uyfdYrWK1+JpRb4PD6QUJql4eXQV5sI5FGjxD7 lHSNgGjVCggVqPaUneGZprY2xofDrX451cAgyH+jDutOBRFaBSkT99JAY8a7VjNI7M9D cfOQ== X-Gm-Message-State: AOAM533uE/+ZKOS6VweLVoeWmZdeKLgcY5ui+q7RGFOtIxuPq3/vui2y xO9XztsHe+DCkgSNXXeqhXlxjw== X-Received: by 2002:a1c:103:: with SMTP id 3mr16981441wmb.81.1604316291370; Mon, 02 Nov 2020 03:24:51 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:50 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , "David S. Miller" , Jakub Kicinski , Fox Chen , de Melo , Gustavo Niemeyer , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 24/41] wl3501_cs: Fix misspelling and provide missing documentation Date: Mon, 2 Nov 2020 11:23:53 +0000 Message-Id: <20201102112410.1049272-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/wl3501_cs.c:57: drivers/net/wireless/wl3501_cs.c:143: warning: Function parameter or member 'reg_domain' not described in 'iw_valid_channel' drivers/net/wireless/wl3501_cs.c:143: warning: Excess function parameter 'reg_comain' description in 'iw_valid_channel' drivers/net/wireless/wl3501_cs.c:469: warning: Function parameter or member 'data' not described in 'wl3501_send_pkt' drivers/net/wireless/wl3501_cs.c:469: warning: Function parameter or member 'len' not described in 'wl3501_send_pkt' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Fox Chen Cc: de Melo Cc: Gustavo Niemeyer Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/wl3501_cs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c index 026e88b80bfc4..8ca5789c7b378 100644 --- a/drivers/net/wireless/wl3501_cs.c +++ b/drivers/net/wireless/wl3501_cs.c @@ -134,7 +134,7 @@ static const struct { /** * iw_valid_channel - validate channel in regulatory domain - * @reg_comain: regulatory domain + * @reg_domain: regulatory domain * @channel: channel to validate * * Returns 0 if invalid in the specified regulatory domain, non-zero if valid. @@ -458,11 +458,9 @@ static int wl3501_pwr_mgmt(struct wl3501_card *this, int suspend) /** * wl3501_send_pkt - Send a packet. * @this: Card - * - * Send a packet. - * - * data = Ethernet raw frame. (e.g. data[0] - data[5] is Dest MAC Addr, + * @data: Ethernet raw frame. (e.g. data[0] - data[5] is Dest MAC Addr, * data[6] - data[11] is Src MAC Addr) + * @len: Packet length * Ref: IEEE 802.11 */ static int wl3501_send_pkt(struct wl3501_card *this, u8 *data, u16 len) From patchwork Mon Nov 2 11:23:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315595 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795E5C2D0A3 for ; Mon, 2 Nov 2020 11:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18A7B207C3 for ; Mon, 2 Nov 2020 11:24:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BHv1+3So" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728795AbgKBLYz (ORCPT ); Mon, 2 Nov 2020 06:24:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728781AbgKBLYy (ORCPT ); Mon, 2 Nov 2020 06:24:54 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5CFFC061A4B for ; Mon, 2 Nov 2020 03:24:53 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id e2so9132682wme.1 for ; Mon, 02 Nov 2020 03:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gMQuO0TF59EhdWIenxAilBMJX+Rp4fB3DjjI99oSCiw=; b=BHv1+3SomxmuPswX/ZGrW1AXpziJDvex16QbzeRf/DRoK+AH6DXYdXPMdd6umh+R5I 4Qf+/Wz0veGBXlVbhhBueHReG4KVgjg3nM0Gt2buLDoOCI1me92W9rdpAoPI/1zKCm1q cOemdk8wDVdoPeQrx5sxjV4z8VwIvDjwYsm7V8mx32WCIXE5mlp+fZNm6KWRI0J5qgtc ZRn/e71vqC1vc0SvjIKz31s0CjKnI9k+WTunGOOVa/r5287XZti+UiaqH9d4JDtCrA8K HepVguCGrex+KQ3YbEZTuXMIsAxmEpJGM80uZFCTuNtN3/Yh0WLjB4GuE3KC0jkGZNFP x3dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gMQuO0TF59EhdWIenxAilBMJX+Rp4fB3DjjI99oSCiw=; b=kK7Q7dW2/wZ/w+3D5Y6SlSh1bK9N2zrvcDXDCFmKBFt0ZU3rYISpZLwsHUGCQCkBip hKWYc8b0tuDy20tOv+951LMVMRVqax/JsbxEL6JUtc0G/wIh95Hg0GCMg0M25qeLKWC+ kbl8Qlnx6S5tANk42Wnkt7e30vzSQZhfB9KfZ/1qmaLaYVtvSc+Sw8fk2D0qsXqFspYQ /PkCA/NRBcOp60hlBNYQaGoo0G6MMtimi/O7/4E3cWBffyHbHT/SWpTofpdLPXt2ObT2 O6VnZK1ftvgskRqqMj4+1Nao2OkkZDX61P/9RFp7yHM2QadvEgojt3tjC0h8KD9Tpzpb MYcg== X-Gm-Message-State: AOAM5314mvacNWol2OZGw1E+tVTSEHP15w7t0Nj9w0IQSY+DEYv7LOOA ASDo5MiJx8+kNp9fkbCAfqw4Aw== X-Google-Smtp-Source: ABdhPJwMDhnzvBexMyPHGfiCbnnbtTXRuLVR3F3xGz5sejFZlWKqHkSci2Q/45LmneOlsj19L/5t5Q== X-Received: by 2002:a1c:e006:: with SMTP id x6mr17661455wmg.107.1604316292584; Mon, 02 Nov 2020 03:24:52 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:51 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 25/41] rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables Date: Mon, 2 Nov 2020 11:23:54 +0000 Message-Id: <20201102112410.1049272-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_wifi_idle_process’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:1631:40: warning: variable ‘bt_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:1631:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_sco’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2767:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_hid’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2810:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_a2dp’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2855:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_a2dp_pan_hs’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2929:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_edr’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2976:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_hs’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3028:22: warning: variable ‘wifi_rssi_state1’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3028:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_edr_a2dp’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3066:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_edr_hid’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3121:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_hid_a2dp_pan_edr’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3185:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_hid_a2dp’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3244:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../rtlwifi/btcoexist/halbtc8723b2ant.c | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c index fb57cc8b2e471..7a71f063015ab 100644 --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c @@ -1628,17 +1628,17 @@ static void btc8723b2ant_action_wifi_link_process(struct btc_coexist static bool btc8723b2ant_action_wifi_idle_process(struct btc_coexist *btcoexist) { struct rtl_priv *rtlpriv = btcoexist->adapter; - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1; u8 ap_num = 0; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset - coex_dm->switch_thres_offset; - bt_rssi_state = btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0); + btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0); btcoexist->btc_get(btcoexist, BTC_GET_U1_AP_NUM, &ap_num); @@ -2764,10 +2764,10 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist, /* SCO only or SCO+PAN(HS) */ static void btc8723b2ant_action_sco(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, bt_rssi_state; + u8 bt_rssi_state; u32 wifi_bw; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); bt_rssi_state = btc8723b2ant_bt_rssi_state( btcoexist, 2, BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset, @@ -2807,12 +2807,12 @@ static void btc8723b2ant_action_sco(struct btc_coexist *btcoexist) static void btc8723b2ant_action_hid(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, bt_rssi_state; + u8 bt_rssi_state; u32 wifi_bw; u8 tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); bt_rssi_state = btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0); btcoexist->btc_set_rf_reg(btcoexist, BTC_RF_A, 0x1, 0xfffff, 0x0); @@ -2852,13 +2852,13 @@ static void btc8723b2ant_action_hid(struct btc_coexist *btcoexist) /* A2DP only / PAN(EDR) only/ A2DP+PAN(HS) */ static void btc8723b2ant_action_a2dp(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1, bt_rssi_state; u32 wifi_bw; u8 ap_num = 0; u8 tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, 40, 0); bt_rssi_state = btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0); @@ -2926,12 +2926,12 @@ static void btc8723b2ant_action_a2dp(struct btc_coexist *btcoexist) static void btc8723b2ant_action_a2dp_pan_hs(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1, bt_rssi_state; u32 wifi_bw; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - @@ -2973,12 +2973,12 @@ static void btc8723b2ant_action_a2dp_pan_hs(struct btc_coexist *btcoexist) static void btc8723b2ant_action_pan_edr(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1, bt_rssi_state; u32 wifi_bw; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - @@ -3025,13 +3025,13 @@ static void btc8723b2ant_action_pan_edr(struct btc_coexist *btcoexist) /* PAN(HS) only */ static void btc8723b2ant_action_pan_hs(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 bt_rssi_state; u32 wifi_bw; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); - wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; @@ -3063,12 +3063,12 @@ static void btc8723b2ant_action_pan_hs(struct btc_coexist *btcoexist) /* PAN(EDR) + A2DP */ static void btc8723b2ant_action_pan_edr_a2dp(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1, bt_rssi_state; u32 wifi_bw; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - @@ -3118,12 +3118,12 @@ static void btc8723b2ant_action_pan_edr_a2dp(struct btc_coexist *btcoexist) static void btc8723b2ant_action_pan_edr_hid(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1, bt_rssi_state; u32 wifi_bw; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - @@ -3182,12 +3182,12 @@ static void btc8723b2ant_action_pan_edr_hid(struct btc_coexist *btcoexist) /* HID + A2DP + PAN(EDR) */ static void btc8723b2ant_action_hid_a2dp_pan_edr(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1, bt_rssi_state; u32 wifi_bw; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - @@ -3241,13 +3241,13 @@ static void btc8723b2ant_action_hid_a2dp_pan_edr(struct btc_coexist *btcoexist) static void btc8723b2ant_action_hid_a2dp(struct btc_coexist *btcoexist) { - u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state; + u8 wifi_rssi_state1, bt_rssi_state; u32 wifi_bw; u8 ap_num = 0; u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES - coex_dm->switch_thres_offset; - wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); + btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0); wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, tmp, 0); tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES - From patchwork Mon Nov 2 11:23:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07577C2D0A3 for ; Mon, 2 Nov 2020 11:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A40F8207C3 for ; Mon, 2 Nov 2020 11:26:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QfadVdOy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728799AbgKBLY4 (ORCPT ); Mon, 2 Nov 2020 06:24:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728793AbgKBLYz (ORCPT ); Mon, 2 Nov 2020 06:24:55 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A5BEC0617A6 for ; Mon, 2 Nov 2020 03:24:55 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id x7so14162237wrl.3 for ; Mon, 02 Nov 2020 03:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=phz21+N6URi4CcT/YO1+niu4iFcUjLLHLqxB18E2o5Y=; b=QfadVdOy9Fl9zbkh80hfIPvPz3gNyuDG3E8PgTyr3iJ6FgsbshhFOmkBOLkPJRM+cS EbKUFWAfKl+jS9COFsJZ8VEzm3Ljt/H3BTbFUiAEX8SpXLdLujSUmWNlOOaR996bjO5X ZpwGzWoAYJQNQF4ErEXvUD0iJGRGMHnvrO7wF6dkvOHyfE7kMjCF4zK+LHNuOkOZxpep pPxsA2NYaA/RjVWsM1+QVNNr25GTO1iv0QHGgOO31mXvatibCudIkTu4BBuclSsU5BKh oncw3u9nBbEhDE2UaEnT5Z4Da0r6mOP0590VFKMAGPFGegyvCA0O5p0uOGggx6X0A8k4 BN1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=phz21+N6URi4CcT/YO1+niu4iFcUjLLHLqxB18E2o5Y=; b=mYvrr2J1yiY2janNJFslgdPIjqRc3eIuAEosC+g34SWfiRCAyOWOrrp+pctrQREO50 09aAZGzs9zJqjj6MSLHre1gREq+3IlNia4rs6SFGC7u7bEqWCKoXExvxc8UskxexKPM2 EOiojtczrA6bkN9zLyzz973gU7zl5+h81gbZ1GMM4eHCiT1324oMME12wPnPnWi+095r A/OsgxwLzAtvOI92mdHzWUo/0Zpp3/UdmookeyygacHxyO3iaxYW1PjpHAycJLjZyQi9 diH42pnZgQTf8288+OVcipbbUVJm1VU2eqHfhLWV+3SH/L1Ce+2BTwVh2D1yGFC7wuR5 Cszw== X-Gm-Message-State: AOAM531unNdAOeKOHL30LQNTYr6TrttWO6VlTa/9Pb7RbMiAE1Tbv2v8 1M0ftlFKiuRv+sonjdfsSgyf6A== X-Google-Smtp-Source: ABdhPJzNF5spMxVcMYFSeCHg8D9zRR3jAaylmqt+JUIJZ1DX9Vnz69yq3266Tb3tLFRcshxVfdp2yg== X-Received: by 2002:adf:9361:: with SMTP id 88mr18815974wro.37.1604316293800; Mon, 02 Nov 2020 03:24:53 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:53 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 26/41] rtlwifi: phy: Remove set but unused variable 'bbvalue' Date: Mon, 2 Nov 2020 11:23:55 +0000 Message-Id: <20201102112410.1049272-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c: In function ‘_rtl8723e_phy_iq_calibrate’: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c:1150:6: warning: variable ‘bbvalue’ set but not used [-Wunused-but-set-variable] Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c index fa0eed434d4f6..fe9b407dc2aff 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c @@ -1147,10 +1147,8 @@ static void _rtl8723e_phy_iq_calibrate(struct ieee80211_hw *hw, const u32 retrycount = 2; - u32 bbvalue; - if (t == 0) { - bbvalue = rtl_get_bbreg(hw, 0x800, MASKDWORD); + rtl_get_bbreg(hw, 0x800, MASKDWORD); rtl8723_save_adda_registers(hw, adda_reg, rtlphy->adda_backup, 16); From patchwork Mon Nov 2 11:23:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315588 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1174C00A89 for ; Mon, 2 Nov 2020 11:26:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9405C207C3 for ; Mon, 2 Nov 2020 11:26:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NJb6VXLp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728821AbgKBLY7 (ORCPT ); Mon, 2 Nov 2020 06:24:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728800AbgKBLY4 (ORCPT ); Mon, 2 Nov 2020 06:24:56 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C417C0617A6 for ; Mon, 2 Nov 2020 03:24:56 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id k10so12798905wrw.13 for ; Mon, 02 Nov 2020 03:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dhSrR79FyygS4wEvpIyMBNaB75El+5Mndl0QUlH0AUM=; b=NJb6VXLpkWuPnTQ4+UycYj+B1c+ONbaWFp74UgM0CB0WqOvAzldj0/guywBSKWXoKS 8me2HxL6mUzrYQiGl/xyEp0x8t/ycDUXWYncoInbxuFr+xmnHcVy7eKqth48j2ETPqM1 SQxmEOfh4Q0VBgdaMHzacM1TWPK8uuQpSksG+7rH2y2erLPiTyVHKjgYjBYzbt0oE2+X TQb9OS6ELzWRNky7i9m8FJuKL09ncRfVZh5vV63cBnKPR4YWgXDi4Xq5I3a7iphcBCyi vB29oD3JaePhFjCjMYy2lWvrM/T1gEy3FooLkjHoeIdQ00itbqU2tgzk0qPB511t/ArA ifyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dhSrR79FyygS4wEvpIyMBNaB75El+5Mndl0QUlH0AUM=; b=Be6XhUkroPPAwaZRKgp5nWLKP+4fpsYYbvunlmv2Y4dWSGTFcq9QHQF4BgJojSANPD iQ/EbTPSOkF6/Ujm3to2fkODrl0AwAP/b7FBQXM/lVBf4SrHx9EIiwjVbhVB+uSQ5+W0 r3uyHPu5hY4DfXQtZuFk6lP+nsxOE5GV1guz7Z5ZzfCOExDNTAE8cOgrbbqlQ1pSSZps yqTIP9uxU2r1Ng7+VnJdv3KbaludbRlogDJ1oBn+pvA1zMrShIdvMY6hGXG9sUbn8ODu eoHXbGM7zntT2EvrPCVuyj0dmzgVRo06omzKqahMQYilH5ueagLwjVVNKfStQvqLDL9f gIXQ== X-Gm-Message-State: AOAM531CZhn9jjEMZ2j85NMohKn7f8hBtSWVpcnLQ52TemN9r+vLx0NY L9zGqOdMlUd45W/tT1DixTS2eA== X-Google-Smtp-Source: ABdhPJzy27H0hX4X1t1prlT213CF+H+Qry0kng3PzoW9ZHnDDqjdTPpo+3Yetpoe6XTqKo6+1Cgrzw== X-Received: by 2002:adf:f1c1:: with SMTP id z1mr19888340wro.331.1604316294901; Mon, 02 Nov 2020 03:24:54 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:54 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 27/41] rtlwifi: halbtc8821a1ant: Remove set but unused variable 'wifi_rssi_state' Date: Mon, 2 Nov 2020 11:23:56 +0000 Message-Id: <20201102112410.1049272-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c: In function ‘btc8821a1ant_run_coexist_mechanism’: drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1904:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable] Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c index 9f5e85be97645..a18dffc8753a9 100644 --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c @@ -1901,7 +1901,6 @@ static void btc8821a1ant_run_coexist_mechanism(struct btc_coexist *btcoexist) bool increase_scan_dev_num = false; bool bt_ctrl_agg_buf_size = false; u8 agg_buf_size = 5; - u8 wifi_rssi_state = BTC_RSSI_STATE_HIGH; u32 wifi_link_status = 0; u32 num_of_wifi_link = 0; bool wifi_under_5g = false; @@ -1962,8 +1961,7 @@ static void btc8821a1ant_run_coexist_mechanism(struct btc_coexist *btcoexist) btc8821a1ant_limited_tx(btcoexist, NORMAL_EXEC, 0, 0, 0, 0); } else { if (wifi_connected) { - wifi_rssi_state = - btc8821a1ant_wifi_rssi_state(btcoexist, 1, 2, + btc8821a1ant_wifi_rssi_state(btcoexist, 1, 2, 30, 0); btc8821a1ant_limited_tx(btcoexist, NORMAL_EXEC, 1, 1, From patchwork Mon Nov 2 11:23:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F99C00A89 for ; Mon, 2 Nov 2020 11:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5E03207C3 for ; Mon, 2 Nov 2020 11:26:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MPOo7oFM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728833AbgKBLZB (ORCPT ); Mon, 2 Nov 2020 06:25:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728815AbgKBLY5 (ORCPT ); Mon, 2 Nov 2020 06:24:57 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 918AEC0617A6 for ; Mon, 2 Nov 2020 03:24:57 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id w1so14165596wrm.4 for ; Mon, 02 Nov 2020 03:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dC1HY3295RvOHBr8DWnLhRLYKV4wb0SqtT4zdtIpm24=; b=MPOo7oFMsJRFYLXnm/bFDJdP2kpvPc2ioROvNmvc60Sdy+TTBecmDAtP8zK9lsd//A 55Y5jq38ujkRuZDcK7PkYlQmnC9OxYTHddgio2w82EBBAtw1J9eaBdYqXANsvWHDjp2G w6W28QUgfhB1NI4P1noH1xZFhtd+Xi1BRlJpQn8c8xB4uIEMcNuVbxPk4zWABkykyZrB Uq3hejnrR/w4Ci3Emed7V6gyvUi47+s6TIpNUeShTeLygvrabpTauqFt0J5MDiy5j0PP BThA+1l9inNjnj7Yqpz7BXEGOdmP944EoO+5kmyjvxiXTJEU2DdY7ivzXZRIAVVdEwb1 6hNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dC1HY3295RvOHBr8DWnLhRLYKV4wb0SqtT4zdtIpm24=; b=cMno9JxW+2Q9o7uP0UvmtmOzl3ZeHhUx+sGytL52ae1w6zUxmqobXd55apIxRwzelz onX1p3ZiiXWmbIsq1O5I00amI6NXEj4feKBNr8p1kvcacO/nzaPl9oWEjGS7+sXE2ZGl K3ygvXRvnM0wzioFZNHhYh0FL/iNo35HWCaCEVxPaEHD8LP7piRXi8zk9TFhOwnXoDza yc8tkl5Z/Izsth3uArqsVVU1n8Ho0FkiPM2vzxzOu6qj5FWoYautc2w/FaiI0Q41Tmxf dEsW4E5oI9TB+tbre2eHJgBhg9E/XM02oS97Yg95hiQp1E5OObRANujmymjuYtyD8xEs EjVg== X-Gm-Message-State: AOAM531Rso1DxhUx4Ff2UPDAmaB6Xw6SU6JPjDWNftmhjGEV4Bhqud6X DUoV9T2MYF/LLEuGFBV8G3Exuw== X-Google-Smtp-Source: ABdhPJx0zmNhrM4E9BGxq1guyT1+xmUrcrR3J/bI5Rpar14jhZoBxvxNLD5dLF25N5hj0eSL/CJu8g== X-Received: by 2002:a05:6000:12c2:: with SMTP id l2mr20975973wrx.249.1604316296305; Mon, 02 Nov 2020 03:24:56 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:55 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 28/41] rtl8723be: phy: Remove set but unused variable 'lc_cal' Date: Mon, 2 Nov 2020 11:23:57 +0000 Message-Id: <20201102112410.1049272-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c: In function ‘_rtl8723be_phy_lc_calibrate’: drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2181:36: warning: variable ‘lc_cal’ set but not used [-Wunused-but-set-variable] Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c index f09f55b0468a4..2b9313cb93dbd 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c @@ -2178,7 +2178,7 @@ static u8 _get_right_chnl_place_for_iqk(u8 chnl) static void _rtl8723be_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t) { u8 tmpreg; - u32 rf_a_mode = 0, rf_b_mode = 0, lc_cal; + u32 rf_a_mode = 0, rf_b_mode = 0; struct rtl_priv *rtlpriv = rtl_priv(hw); tmpreg = rtl_read_byte(rtlpriv, 0xd03); @@ -2202,7 +2202,7 @@ static void _rtl8723be_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t) rtl_set_rfreg(hw, RF90_PATH_B, 0x00, MASK12BITS, (rf_b_mode & 0x8FFFF) | 0x10000); } - lc_cal = rtl_get_rfreg(hw, RF90_PATH_A, 0x18, MASK12BITS); + rtl_get_rfreg(hw, RF90_PATH_A, 0x18, MASK12BITS); rtl_set_rfreg(hw, RF90_PATH_A, 0xb0, RFREG_OFFSET_MASK, 0xdfbe0); rtl_set_rfreg(hw, RF90_PATH_A, 0x18, MASK12BITS, 0x8c0a); From patchwork Mon Nov 2 11:24:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320215 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp3643546ilc; Mon, 2 Nov 2020 03:25:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8myZUbjmLujOSO8P+doSVubdSRmGj73PI8o7gz2Mu8J7RRzvhbZsmFafeamRA8wap/GhK X-Received: by 2002:a17:906:158e:: with SMTP id k14mr14379859ejd.496.1604316305513; Mon, 02 Nov 2020 03:25:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604316305; cv=none; d=google.com; s=arc-20160816; b=HGpBKI7PMasDSMkwhXdb7hnybPSJf1+0tUXui/VmU85QLKFgmtBG/nBOsvo1JjVanj jFyEi4JxSbOMDknfwFCulgugSLDxXQU2Y+etUX4S8+LuqAXaYIkoxmOxsTsMryfOriMF MKDfNOKa5ACHnpr6zzHIooBPlgtFf0N+x/UOlQgfBWnFAiMNF0LIvrzycPPzfH3ALkMl IOe2cco+dgsbQyKXwvvnAkvmSDQ8s97Kc6EdgwD/sidOEC3rTccPXK/CHed7t4h0rUKO lLhxSaCqjOkfp1RvzUecpmtfusevGxZ0FhV+HsZApCal/TbDFcFVBVUYleC/U/YPyDye jfkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gRH/26yT2dAaI3IpvhAVivatnrNzkpcErFlaxyXb8UQ=; b=NVUBdUr50CECLRNRjwGPxrC+o9udaIuW2nceeS+vu+mpHi+gBinFvWJGwA2ZrMCZw8 Ytmidmtmwr+bsXjUv+BzepHOyvdjlAFO+fcZ3QMC5uFwaZ2DFeHeD4iK0eukozLM/tro ZqBXcG6ir0Z5s9coLgJLsXDlk7e+nxSbDNNa9ofUXzsRMDaKGAev4hbT1EMwEAQnsOAe I4FZa6onZcarVg/S6ZGQYvpLpqfs9Z4gH7LLJuGQvdJTF9NJKB8LFEqfF/hiDrR4mBZ0 rAOOaq8Y9hUBs2ejrM0GWk2iUc4Q8yaknB2A0G7x+izwBP3ybrSEzg+lyva+yJP81SzS QV7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ltQ789qF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a5si10151697ejk.741.2020.11.02.03.25.05; Mon, 02 Nov 2020 03:25:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ltQ789qF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgKBLZC (ORCPT + 2 others); Mon, 2 Nov 2020 06:25:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728813AbgKBLZB (ORCPT ); Mon, 2 Nov 2020 06:25:01 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1849FC0617A6 for ; Mon, 2 Nov 2020 03:25:01 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id b8so14175370wrn.0 for ; Mon, 02 Nov 2020 03:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gRH/26yT2dAaI3IpvhAVivatnrNzkpcErFlaxyXb8UQ=; b=ltQ789qFyVUG0DnMpeIBcHyp11aLEjc0FGrAhnTv1HyvyDlz68ox27lpz56pRgP5dr GN24aKpcLw9GxLT5KfWn5X3E+MFEN5tC3rcIHc0HNIDR4+EfpVmTtLbhllceTVp63poY Dqra9dlmKW2qmU58r9knHxsIC3Y94KZYdfy5KdOpIj5y9x/a9Aa1kAEcKLlteVa+vaSC 3NsmBenF7kWNadUuFK5ZCy5lkzBA4qf/aM6Y4LfQaCsQ5OwkFKgjsvwPFYxro/5B+K+5 N+KcSjtJgHhF470t1KKy6b4S/WpsuH0o2UnpNtg/kZXZufZehfcd5F4dTCqKfuEzlAua XiRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gRH/26yT2dAaI3IpvhAVivatnrNzkpcErFlaxyXb8UQ=; b=V79qPv+L1U+sOVgzG6oXIWG4MDp65w/v7w1y5y5sm++/cqs0Cqad6MqUxjt1P6QfOa jyW37Nm9PjPNQMWmzlZVcOj5k/pvPQpLZDyISCKMt7df2poX/qGVRTW0IiisLbH7w5HT Se4+LZCt86SHmlKnh+liaBWhRugQnFSvc86j/eNm9p8HmQWg+ukjt4GPHHcTYX7lxwKD jVu2JMj/av0XZEqD+47wRYcYZ/H8aGwcE8jycHzLZgpn7QEVJ6H4cCAviBMUKPh6YetV wKmt1GWNiORkkCoJH0nOGPex/WB3/4GALtn9HoYbcglDv5xtNb1F+bsIvUZ5w9EL42q7 141w== X-Gm-Message-State: AOAM532hxQzWFxUsyr5i58lvElkqchhD1oTOhCcBlrbTwXdCjkS8mbgl ks5FPmuB62ZUbDXDZJdXsrep14o1z0vDpw== X-Received: by 2002:a5d:534d:: with SMTP id t13mr18886940wrv.69.1604316299868; Mon, 02 Nov 2020 03:24:59 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:59 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 31/41] mwifiex: pcie: Remove a couple of unchecked 'ret's Date: Mon, 2 Nov 2020 11:24:00 +0000 Message-Id: <20201102112410.1049272-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_pcie_remove’: drivers/net/wireless/marvell/mwifiex/pcie.c:432:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_cleanup_pcie’: drivers/net/wireless/marvell/mwifiex/pcie.c:3142:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Amitkumar Karwar Cc: Ganapathi Bhat Cc: Xinming Hu Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 6a10ff0377a24..67e0247ebaa65 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -429,7 +429,6 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev) struct mwifiex_private *priv; const struct mwifiex_pcie_card_reg *reg; u32 fw_status; - int ret; card = pci_get_drvdata(pdev); @@ -441,7 +440,7 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev) reg = card->pcie.reg; if (reg) - ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status); + mwifiex_read_reg(adapter, reg->fw_status, &fw_status); else fw_status = -1; @@ -3139,12 +3138,11 @@ static void mwifiex_cleanup_pcie(struct mwifiex_adapter *adapter) struct pcie_service_card *card = adapter->card; struct pci_dev *pdev = card->dev; const struct mwifiex_pcie_card_reg *reg = card->pcie.reg; - int ret; u32 fw_status; cancel_work_sync(&card->work); - ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status); + mwifiex_read_reg(adapter, reg->fw_status, &fw_status); if (fw_status == FIRMWARE_READY_PCIE) { mwifiex_dbg(adapter, INFO, "Clearing driver ready signature\n"); From patchwork Mon Nov 2 11:24:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A86C00A89 for ; Mon, 2 Nov 2020 11:26:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02465223AB for ; Mon, 2 Nov 2020 11:26:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LbLnLJ7s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728732AbgKBL0I (ORCPT ); Mon, 2 Nov 2020 06:26:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728862AbgKBLZD (ORCPT ); Mon, 2 Nov 2020 06:25:03 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74800C0617A6 for ; Mon, 2 Nov 2020 03:25:03 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id g12so14113853wrp.10 for ; Mon, 02 Nov 2020 03:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V56hUx4Ik29TQLj2+CSFLe9SRW9C8bcqnq7xkJaiUmI=; b=LbLnLJ7sYZ0Y4ts2ejFZSO6VFjct/fqvAsi66WGbmbjiWxrlKP23awk5AoxWovYtQq ANyWpgdkbExKHSc4LRTxA3Wm0sLoiUn/xeYK7K8YxzBckH70djdbeTaZ7sVmCcyxLH/7 LbV8udT93qwScqZSTKAcQ+sj80osPAff/t4/43FDsEHUxBY+thIUAqd6YjLvT4roAwnx vL8mI2Vq5xzw5DESN0m3QKTKHsOBwDfAYAo/1nGEjKG7vuM02DvSM6IJXUhqFCgPi6i+ QBZHISS14SQLp1xJ1BSdY058i5GfkClF7p6g1xsGJbL7YxzUX2H7j+aKltf7vdTzROyX vZHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V56hUx4Ik29TQLj2+CSFLe9SRW9C8bcqnq7xkJaiUmI=; b=UNND0L01ioB0MXWbQPOU/A6WDFhTdbbffJpwJ4oYrZB2wUSCGPgNlcKkvIL0ufPTv+ H5SHGzDkFONOfye0Z6l5ue3kIeLSsJwilkjERyRA+iiMkTjWW6OUUf3+ScjJdEsMctP2 bios9dLzacSGNqx0Mf0+eeQ59+l/YxQVkvBfmkKxa0hTi//L0m6No5bOQjPf1K/xkqyJ tnvmdBYVMc+AczRfDuJvmiThBdzcfPa4adNntVRuHm8CzQBbSm9AOBpUK9rQp/mDhvpw CTaqmIlTfO9FlIBA5ZSfifNPikkShkzHO/7pseC3rHz3c2HQ9xwxxF/RifjnuV0lw0V+ VMFw== X-Gm-Message-State: AOAM533bhYtjDY4VtHS/hWeCYlncxPQ0HgCUctjkzzGzp5tSGvJRJjac Jiq2fXWrkbGwh9iUzw6mS9PttA== X-Google-Smtp-Source: ABdhPJzTyFAeigdIzuKUqE+E8GyCEp2hfljOIkpyNn8sJbCdvxcGFGLf34+xtIbYZk3zUTIk7raa1Q== X-Received: by 2002:adf:e8d0:: with SMTP id k16mr19559451wrn.362.1604316302226; Mon, 02 Nov 2020 03:25:02 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:25:01 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 33/41] rtlwifi: rtl8821ae: phy: Remove a couple of unused variables Date: Mon, 2 Nov 2020 11:24:02 +0000 Message-Id: <20201102112410.1049272-34-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c: In function ‘rtl8821ae_phy_switch_wirelessband’: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:597:14: warning: variable ‘rxpath’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:597:6: warning: variable ‘txpath’ set but not used [-Wunused-but-set-variable] Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c index f41a7643b9c42..72ee0700a5497 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c @@ -594,11 +594,10 @@ void rtl8821ae_phy_switch_wirelessband(struct ieee80211_hw *hw, u8 band) struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); struct rtl_dm *rtldm = rtl_dm(rtlpriv); u8 current_band = rtlhal->current_bandtype; - u32 txpath, rxpath; s8 bb_diff_between_band; - txpath = rtl8821ae_phy_query_bb_reg(hw, RTXPATH, 0xf0); - rxpath = rtl8821ae_phy_query_bb_reg(hw, RCCK_RX, 0x0f000000); + rtl8821ae_phy_query_bb_reg(hw, RTXPATH, 0xf0); + rtl8821ae_phy_query_bb_reg(hw, RCCK_RX, 0x0f000000); rtlhal->current_bandtype = (enum band_type) band; /* reconfig BB/RF according to wireless mode */ if (rtlhal->current_bandtype == BAND_ON_2_4G) { From patchwork Mon Nov 2 11:24:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315590 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F7BC00A89 for ; Mon, 2 Nov 2020 11:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD56B207C3 for ; Mon, 2 Nov 2020 11:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JlhFoJuM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728619AbgKBL0H (ORCPT ); Mon, 2 Nov 2020 06:26:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728868AbgKBLZH (ORCPT ); Mon, 2 Nov 2020 06:25:07 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD6EC061A48 for ; Mon, 2 Nov 2020 03:25:05 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id n15so14182322wrq.2 for ; Mon, 02 Nov 2020 03:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CShQQ12PBsg4lhgdWNuYQU+7cmtXNk/NI77thbS/j9M=; b=JlhFoJuMAj9F/e61O3Mhvl/I2ScHj1PNuWyCQK3xSUVNOZxJDsPtA72x9vNeMaNvtV xatTQqTIiNB/CR9h9jS2FMe9ZJflyKbuXb4laQiuFtVx60jyT/Bs30RKUahJeIJyNVFt XrRhLSSEPFI6KVksCWt7K+vt7J5jZTHjffUJoYyYxU0DSfrjgBXpggFwOzwudIq4yK2i +YfH1kV+6gil38pjYtWr4ibLTbFNPVbhAB9B+Gk2dSp0JtueRe1sxE6C2hmrO13Y9OPO ujFzdc0YIP3oJo8Ck3HNP/e6tktwNT8Bn4ZEnRmCghtwB5coRT9Xu8uH15bAEWhHW82s qplQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CShQQ12PBsg4lhgdWNuYQU+7cmtXNk/NI77thbS/j9M=; b=W7ZxeHwD0Jm6D25M8L/TCE7KfMJtY+xv1fxvMFwMsceI24wWNWPDRTanC3AYm5qflG qPdv9nxt3Gh/5zhP4J5OU8/cVHnsSd51/cVCyXvKtB5FHlMUy5QRcgBaSZjJOwrBVP32 DqSXBk9mMADwP3t+WAaUEM7YTs9DKiWeXo6FksGpkuHm+wC84nfGRzDf+BJPEl94RcGJ Hb5SdSFRc6CRfifu5pD8ckJ7ZgPIl3Y/UzNCxwFKhrXulTTaa1H8haeOO5APe2u2kz9Q b/5s6jWyBLPJNtqlagqChbYFfWnPX7sUK7rQ4NNwoDjbWFyXxIg3WNaKR+DESLf9CPLv UyCQ== X-Gm-Message-State: AOAM530O1CQkhjJwlLrGY1YjhJX4atHWaU2FQLRnT/dA8h69OXyz986T Xg2CIY4AMA1OY4M95BSCmx9LYw== X-Google-Smtp-Source: ABdhPJxBYj5usmi4qGlUfaqjEb9+wgXLgztUDnuNady/I5Qdqzo4kKXtcfwR2Bj62eeSOzRpXaj8bw== X-Received: by 2002:a5d:60c4:: with SMTP id x4mr20763543wrt.175.1604316304609; Mon, 02 Nov 2020 03:25:04 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:25:04 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , "David S. Miller" , Jakub Kicinski , Geert Uytterhoeven , Luciano Coelho , Juuso Oikarinen , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 35/41] wlcore: spi: Demote a non-compliant function header, fix another Date: Mon, 2 Nov 2020 11:24:04 +0000 Message-Id: <20201102112410.1049272-36-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ti/wlcore/spi.c:403: warning: Function parameter or member 'child' not described in 'wl12xx_spi_set_block_size' drivers/net/wireless/ti/wlcore/spi.c:403: warning: Function parameter or member 'blksz' not described in 'wl12xx_spi_set_block_size' drivers/net/wireless/ti/wlcore/spi.c:440: warning: Excess function parameter 'res' description in 'wlcore_probe_of' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Geert Uytterhoeven Cc: Luciano Coelho Cc: Juuso Oikarinen Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ti/wlcore/spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c index 18c4d998ce4b9..f26fc150ecd01 100644 --- a/drivers/net/wireless/ti/wlcore/spi.c +++ b/drivers/net/wireless/ti/wlcore/spi.c @@ -391,7 +391,7 @@ static int wl12xx_spi_set_power(struct device *child, bool enable) return ret; } -/** +/* * wl12xx_spi_set_block_size * * This function is not needed for spi mode, but need to be present. @@ -431,7 +431,6 @@ MODULE_DEVICE_TABLE(of, wlcore_spi_of_match_table); /** * wlcore_probe_of - DT node parsing. * @spi: SPI slave device parameters. - * @res: resource parameters. * @glue: wl12xx SPI bus to slave device glue parameters. * @pdev_data: wlcore device parameters */ From patchwork Mon Nov 2 11:24:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315592 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B95C2D0A3 for ; Mon, 2 Nov 2020 11:26:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A3DA2084C for ; Mon, 2 Nov 2020 11:26:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jBHePhYn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728970AbgKBLZz (ORCPT ); Mon, 2 Nov 2020 06:25:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728875AbgKBLZI (ORCPT ); Mon, 2 Nov 2020 06:25:08 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 447B3C061A53 for ; Mon, 2 Nov 2020 03:25:08 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id x7so14163055wrl.3 for ; Mon, 02 Nov 2020 03:25:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oATorMQPiNVEoXmBjgNPIPCMhMKpxL92yv6qxOrQmpk=; b=jBHePhYnnP0xuAetGt9Eo3pFc8xqQtQuTC0DcIYmXn9WdkpaTDkYVo1KTjcx1txQK3 w/BBQ6r4xyCakZNyMSelnh8f0ItIvYAGjnZMJzr+h1ZQtGwIwH7xTLH3rBWqj89rFQfg kbhq2qpIuYR88WmpwwNYxo8aa0uoEz0moj7E2Anr1zixnF0HkGvl1lMvYF2q8hAztolE 9Uc32jXWJraeUHQ4YwinYPw4ZbEGo5n//b4TejRX3Cf9YI1ZpamiWdvQMUJBodh/E8c+ fbjKnA8xz2H1KFAta1L29egvBdc7bQ9bk6NcK9yMtAkHa75OGm+e8Jf6pSLvcftIC/jE 7Wbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oATorMQPiNVEoXmBjgNPIPCMhMKpxL92yv6qxOrQmpk=; b=kyt3FY3gkFmPaljhxROsML3MKrzGZqwE6LC4JAH3ZaXokHzsLvaV71jqDKrrXSX520 pOj/Fjfati4BEvh3JJVdWr8yCmlyE2E2HvjzWu51nrl/0StmdWTpniFes8QkCWNys1ha grOcK/8obhlPKSGtYoHSDMHzaDujH2Kr7fX99CQ0TWKp9q/dim4A+1gB1ErsifaVyOD9 VkILmT8UcYQYeTqUpwhkUMUptARyJtS8bsfgxIZFhJbamDyEZEKGXC4WvJ888cVpL3Vq bVGDN0Ve9L/q1iFL2Y+uP5JSX0CPCY08A2LSAf4z1jW8cwxz9DY2HsQm8pNaLTnLfCMV HAOg== X-Gm-Message-State: AOAM533qHEgSXuSJtlgwsqG8YbQQmYIFHfkc4VRXmeb2lRdb+kK/FSQU 24/e3keeOD/rHZZRLi4XTGi46Q== X-Google-Smtp-Source: ABdhPJxxJwdd/oQ+fNMOlnIz3kGJlqYpSor60fsw/OcUNRw6rXY3p++l54wc+a28IKDS/2qEvOdhPQ== X-Received: by 2002:adf:dd09:: with SMTP id a9mr19802904wrm.208.1604316306994; Mon, 02 Nov 2020 03:25:06 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:25:06 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , Shahar S Matityahu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 37/41] iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header Date: Mon, 2 Nov 2020 11:24:06 +0000 Message-Id: <20201102112410.1049272-38-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/fw/dbg.c:1932: warning: Function parameter or member 'reg_data' not described in 'iwl_dump_ini_mem' drivers/net/wireless/intel/iwlwifi/fw/dbg.c:1932: warning: Excess function parameter 'reg' description in 'iwl_dump_ini_mem' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Shahar S Matityahu Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index ab4a8b942c81d..c0a180b496988 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -1923,7 +1923,7 @@ struct iwl_dump_ini_mem_ops { * * @fwrt: fw runtime struct * @list: list to add the dump tlv to - * @reg: memory region + * @reg_data: memory region * @ops: memory dump operations */ static u32 iwl_dump_ini_mem(struct iwl_fw_runtime *fwrt, struct list_head *list, From patchwork Mon Nov 2 11:24:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262B8C388F2 for ; Mon, 2 Nov 2020 11:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C143A223B0 for ; Mon, 2 Nov 2020 11:25:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xukb2MhF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728888AbgKBLZK (ORCPT ); Mon, 2 Nov 2020 06:25:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728880AbgKBLZJ (ORCPT ); Mon, 2 Nov 2020 06:25:09 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64395C061A04 for ; Mon, 2 Nov 2020 03:25:09 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id p22so9020321wmg.3 for ; Mon, 02 Nov 2020 03:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UT5EgnUvoHP+GjgilFxQnCqaL6JOwHOcMs3W1ZOmRXU=; b=xukb2MhFxJbVUdsWilattJVsGg0OAs77+oLW3aMTLk/EF/Ai4AANnWiI3wmBS5XwRf zi7tVBPSLiEoKSaopsSuC8MTjW7bGWgXFnsXe5GenkjXYAZ3XF+6Yc/v6MIMR2jYGiEA JccZN775WqcJLqdINDeWs5q/CcQ80igoAj4GphmiroGQwXn4EVHTg2tP0s0nBUTxWM2L Iiy3ylxRXTxxErZbkKpC3QUymQbzduX1rJycnCa03pcZ20vbdAiKvEkmk7c7wQ5Lkf5y vMwRN5JIToSpejVIkfvae9Gc+n2c/GQjELhxciFLObO1W62xiJ9tmDWdsqrJ74MpM93K k/KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UT5EgnUvoHP+GjgilFxQnCqaL6JOwHOcMs3W1ZOmRXU=; b=IMhQVdqnEzsPUBZ///94Lh25272NvQ9DQ31wFzq2CFoOp5hCnuWRw9rR1509Sfz4kG 5jjPQ1vvXxL/bRaXqP8fgn9pzANu2FY6LTIG1h31Zy3QVhfMlGSXroWKfkbijjzH15Bf 8ugJZxbr78SBHBf185FQFTiahlisAdciUKXzXUrM1LVXl7BjqDdguL/NPCmqVRzL93Gc ZChQLuXD5hvP3z0yrv8hAUhv1ilmpOX3iItQ5KqbBZnnr93tuM/x+gp79klnPGmdBge7 cnmL64g3am2AvwM7d9oIJBvuDfIO0TdNo4ndZjhH2o8cBz2K7Yz8ngLRZVejcuyU2fei 3wxw== X-Gm-Message-State: AOAM530JKI+vGQeU1NBwKLIGJcfRDUggUlGV+dxcxuVLKgIknWD/18UT IfK3nOjqHYHYOLszH5oI4MrQQl2YuB8r9g== X-Google-Smtp-Source: ABdhPJzxaJagDnvgeH2HbXfAEJ2LYyd+wNu8tVtlIN4gwozyl0vvjVt8g0xrZK5de9DGHD5UPb/VJA== X-Received: by 2002:a1c:99d3:: with SMTP id b202mr17030497wme.0.1604316308191; Mon, 02 Nov 2020 03:25:08 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:25:07 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Yan-Hsuan Chuang , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 38/41] realtek: rtw8822c: Remove unused variable 'corr_val' Date: Mon, 2 Nov 2020 11:24:07 +0000 Message-Id: <20201102112410.1049272-39-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function ‘rtw8822c_dpk_dc_corr_check’: drivers/net/wireless/realtek/rtw88/rtw8822c.c:2445:5: warning: variable ‘corr_val’ set but not used [-Wunused-but-set-variable] Cc: Yan-Hsuan Chuang Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtw88/rtw8822c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c index e37300e98517b..b129a10707573 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c @@ -2442,7 +2442,7 @@ static void rtw8822c_dpk_rxbb_dc_cal(struct rtw_dev *rtwdev, u8 path) static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path) { u16 dc_i, dc_q; - u8 corr_val, corr_idx; + u8 corr_idx; rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000900f0); dc_i = (u16)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(27, 16)); @@ -2455,7 +2455,7 @@ static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path) rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000000f0); corr_idx = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(7, 0)); - corr_val = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8)); + rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8)); if (dc_i > 200 || dc_q > 200 || corr_idx < 40 || corr_idx > 65) return 1; From patchwork Mon Nov 2 11:24:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B7CC00A89 for ; Mon, 2 Nov 2020 11:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EADDF2084C for ; Mon, 2 Nov 2020 11:25:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G2xG8jSv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728906AbgKBLZN (ORCPT ); Mon, 2 Nov 2020 06:25:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728900AbgKBLZM (ORCPT ); Mon, 2 Nov 2020 06:25:12 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFBDDC061A04 for ; Mon, 2 Nov 2020 03:25:11 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id v5so9017530wmh.1 for ; Mon, 02 Nov 2020 03:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SxQ9eC4olAQ/BaWiTM/LMUE/iibApHADASIQRVEODWI=; b=G2xG8jSv78TeztV0Grp4aYLVnL8EIsekTK4PQNaFJ1PD/Bifzw1BgiGoBfIh46sd2i 5VxhGqVoywhAUUCsAoHS4ucLYq4s29MqwGT/N2tqi9HdMcQ+t0PxJ+igTiU2vgkufphn xxjyHEfsQyXNnRxZ15IIaz+H+uwshzutFWUiV7w8SaonWKX+N0pesrNbpMxFxemGtttC jEjerT7AJzXVzj3kFU/gIH7WgEwhQIQS5y5PUlEmOGj8w2BCdLIUPugrDwnBo46+mC7h j3/c+cvgNPhz0RhhiW9ECeZ6KxE1j0wj+Ay5ndLTHN/yCOu133IXh3s7Y6ofzn+VRtJf q7wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SxQ9eC4olAQ/BaWiTM/LMUE/iibApHADASIQRVEODWI=; b=p6aBpS5ienlFrpJWiN9E7Gv6xoUJMnIUi61liaFHxFRss5iSjeOR7SNsm42IsU4cxV aMpRmYBGB6ZqjTmqI1SidSDAhq4dHyL8El19WMVKmfc7rwIQ38kN2prFYiE+vj6UBVlH UqOC9uhtv/czb5iEfikSPmEFlpIdtKTs18jO3Dbhr2b732vDx/jVQLpbMhD8K+/Ysrrt ALalHkn4bmTMBLBtlo9EwQ+CpGxAUDJO26tLsNpEC+fz0z7NF4VYJT9MRRJNxnDv3RMT rxexBzoNjg8p5/Eg1/duPELTRdo6vo89hdqVXp5ipGRv2qEp8/08Z/x0WEdRuWJzqPwe 3Puw== X-Gm-Message-State: AOAM533vXy7g/O5iNn2ir5Jkpr0kGlBsFS3IE/7+lXRyqrF9cbD55rGT 44Sd8/lZcqoLrJj2KM1jc4mQGw== X-Google-Smtp-Source: ABdhPJwCMJuP6iKz7748GTQUi0E7GtJTNFdsQVnJ0o1+bq2XEggp9w4IThdvwBXsL/BUzRQPQrSaEg== X-Received: by 2002:a7b:c109:: with SMTP id w9mr11271953wmi.34.1604316310489; Mon, 02 Nov 2020 03:25:10 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:25:09 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 40/41] iwlwifi: fw: acpi: Demote non-conformant function headers Date: Mon, 2 Nov 2020 11:24:09 +0000 Message-Id: <20201102112410.1049272-41-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'args' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_u8' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_u8' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_u8' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c index 3e5a35e26ad34..ab1d8b18d9976 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c @@ -113,11 +113,11 @@ void *iwl_acpi_get_object(struct device *dev, acpi_string method) } IWL_EXPORT_SYMBOL(iwl_acpi_get_object); -/** -* Generic function for evaluating a method defined in the device specific -* method (DSM) interface. The returned acpi object must be freed by calling -* function. -*/ +/* + * Generic function for evaluating a method defined in the device specific + * method (DSM) interface. The returned acpi object must be freed by calling + * function. + */ static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func, union acpi_object *args) { @@ -134,7 +134,7 @@ static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func, return obj; } -/** +/* * Evaluate a DSM with no arguments and a single u8 return value (inside a * buffer object), verify and return that value. */