From patchwork Wed Jan 3 12:12:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 123296 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp10098617qgn; Wed, 3 Jan 2018 04:14:22 -0800 (PST) X-Google-Smtp-Source: ACJfBov+bjRdCBk+Cq9NL1NfJuMdadBd8x0WBqgTnNeY8SotwZyNk0ECJ9kAjOf/EqQyhrYEo+NS X-Received: by 10.223.186.202 with SMTP id w10mr1244584wrg.201.1514981662091; Wed, 03 Jan 2018 04:14:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514981662; cv=none; d=google.com; s=arc-20160816; b=qCuQ1cAYz3R6m9NIWu+Q0amFuf4vhkmZuQIn05rb8yJUp2T0P1hJH5Q1hZqdAtPfEl aqGWsC+2/jtxD7AIEWcEboSPxJJaF6EYWmBrOhdBVVJ7K3HmZf+czeKCVwm8E3y6f3T4 FXxQ78+vj9ffRL5W/XFbCIadiMmTNDI++ohJuUwxqjtWv26UY71U8+e7O5YMG49LbMaa BZ0mqyFzBm6FoDTC6mFYRxePbgqtKvLqs1kI1AxJ1W4ukEstS90tuTMINx7cWBbsq9kz LzUCt8xcuqZMaayNqow6U6R7+urYwBInuPtLFEisITu8s37VXacqqItCYG98Y/sC2HYT pyNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=sFQwxsXZ4iV96VjOoCVrRv0axrLnAmSWm1pN8/HJqhI=; b=dE5b9bXm4of1kApj82S9tQiHa1hqR26LDJhVdYuQnOK9h+/t5MLMPZihiLUMhHnLJM LBvXwLD1AWLapV2bfenEIExKCf2ktvd6cUAO/UAFlHXZhgIbISOLjpwrkI5V1Y2tWCGd J0tWiISYzyRY2yoSdEEWHOpezZD4jeh0kQ1BT0yLjdH8eQvgXuwZ2Hu6OErLjUb4TOfj DXEBDH7PXH9We+SgNLSjZBx2M69RSCh8IL/7ebEmdeYBqdHiTDThkAHq35wb/FCcMgyi 4VtMtBOBx0POvebp1eppRHxQbwUAWLpR9rExsGpxvdx/OxHeHCiGexoOc9DvHl0KvaJH Qvuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NNn/MNST; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id y5si737200wrc.315.2018.01.03.04.14.21; Wed, 03 Jan 2018 04:14:22 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NNn/MNST; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id ACFE12675FA; Wed, 3 Jan 2018 13:13:11 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0FEAA267617; Wed, 3 Jan 2018 13:13:08 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id DA63E2675F5 for ; Wed, 3 Jan 2018 13:13:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Lfo1STW3BPRB9DkBo87CzkNB7a6hZ8F2ZqaJ9Ae+WHE=; b=NNn/MNSTUrKv Bj7oHEjxxbTKrdQNwnk3oIiCnUC7dS8N9rwdXLKLQ1wDuvtH8WCfePOVc4GOQCv6MicA+GQwymKPX ZbFBPFHKe+kH+fyXu2SHL9Q9B6Ydimqgj1pfLasiOrVT7ZT3epAnHbkoxZrfbVmOUz+5yrxhJalpK 2eADU=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eWhua-0004f1-C6; Wed, 03 Jan 2018 12:12:48 +0000 Received: from broonie by debutante with local (Exim 4.90) (envelope-from ) id 1eWhuZ-0001Zy-TN; Wed, 03 Jan 2018 12:12:47 +0000 From: Mark Brown To: Pardha Saradhi K In-Reply-To: <20180102092957.14091-1-guneshwor.o.singh@intel.com> Message-Id: Date: Wed, 03 Jan 2018 12:12:47 +0000 Cc: alsa-devel@alsa-project.org, Takashi Iwai , Guneshwor Singh , Liam Girdwood , Patches Audio , Mark Brown , Sanyog Kale , Vinod Koul Subject: [alsa-devel] Applied "ASoC: Intel: Skylake: Disable clock gating during firmware and library download" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: Intel: Skylake: Disable clock gating during firmware and library download has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From d5cc0a1fcbb5ddbef9fdd4c4a978da3254ddbf37 Mon Sep 17 00:00:00 2001 From: Pardha Saradhi K Date: Tue, 2 Jan 2018 14:59:57 +0530 Subject: [PATCH] ASoC: Intel: Skylake: Disable clock gating during firmware and library download During firmware and library download, sometimes it is observed that firmware and library download is timed-out resulting into probe failure. This patch disables dynamic clock gating while firmware and library download. Signed-off-by: Pardha Saradhi K Signed-off-by: Sanyog Kale Signed-off-by: Guneshwor Singh Acked-By: Vinod Koul Signed-off-by: Mark Brown --- sound/soc/intel/skylake/skl-messages.c | 4 ++++ sound/soc/intel/skylake/skl-pcm.c | 4 ++++ 2 files changed, 8 insertions(+) -- 2.15.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c index 4e63213a8d55..933c1fbb222f 100644 --- a/sound/soc/intel/skylake/skl-messages.c +++ b/sound/soc/intel/skylake/skl-messages.c @@ -417,7 +417,11 @@ int skl_resume_dsp(struct skl *skl) if (skl->skl_sst->is_first_boot == true) return 0; + /* disable dynamic clock gating during fw and lib download */ + ctx->enable_miscbdcge(ctx->dev, false); + ret = skl_dsp_wake(ctx->dsp); + ctx->enable_miscbdcge(ctx->dev, true); if (ret < 0) return ret; diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index cc6535ab84d1..b45a9cd5f058 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -1342,7 +1342,11 @@ static int skl_platform_soc_probe(struct snd_soc_platform *platform) return -EIO; } + /* disable dynamic clock gating during fw and lib download */ + skl->skl_sst->enable_miscbdcge(platform->dev, false); + ret = ops->init_fw(platform->dev, skl->skl_sst); + skl->skl_sst->enable_miscbdcge(platform->dev, true); if (ret < 0) { dev_err(platform->dev, "Failed to boot first fw: %d\n", ret); return ret;