From patchwork Mon Oct 26 21:48:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 319007 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1023325ilc; Mon, 26 Oct 2020 14:48:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrarDQ9kUQ4ppXqtT9dLnpBp0LJ+yX8lHq0lSGHhpmFw2imi1dQr9QxBusR+79+XEPqfuM X-Received: by 2002:a17:906:68c4:: with SMTP id y4mr18130439ejr.197.1603748930395; Mon, 26 Oct 2020 14:48:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603748930; cv=none; d=google.com; s=arc-20160816; b=DHvIe0B1RkMQs75A8F7ekYksD2S/rCoqBTJ/d92WRwrUM8j9K74oY4JUeEbYStKpws 4rXS4mqDv4zM/4OHSICr2QhOJ2ZXTnEs3weDJJTAVlFysxEZH8fDNp4xzC+tDP+uUWOy zHNBRwwh3nX94O4SNN6eve39y95vfPHkwn2etkUdP8x3KYi1ZNixNj0oD2DllDNpJC0d h6qkbJ6Lef9TQNdshg8g9iFm/TwILM9JTDvvLY838PCwYAGX6q/VImdSQiMHOotL9ccs ByzOJQwcwV32qdjZVXIcesDAfPw/WZAbKTA1A8yTXhCy2LBcxBAgN0Phd0JQWbHHeku0 aLAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Oqn2ilimCjDLHfBgA8URLsOh5hvTb2Mx7qVMkAnPsn8=; b=wR1K5UL3oJXcs7dxuKOKN0F+bKDTIvx6A99ZgNsnpHa2yNgsqCWAmzVnKnH4mqkohw fJP4gEjebP4vN58XuKFay8t7d6RuV/V9J5BcFhqCsI5lukmtQS4s0rXWDuQOhLdD/0z6 LvrBvP+vIXJLzcswqncBBA4nolc+2nD/SooPPYgcAwTJrmdqPkoNdH8gW9GBWn0bDpkG 4tCdIdZRcQ5KuyjcLPUMk35yj5jtd+3elUba6RB1s7B/gOHDuxVfSaxblvr5G7EdEVKe NuKuULAeRkGceYaf0GRmqfITzokRDNWA9JZ7oMCD4Np4OWzL6/63dNfjmyqW6ulYF0F9 KCvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=M1NDeXoK; spf=pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si7444136edj.168.2020.10.26.14.48.49; Mon, 26 Oct 2020 14:48:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=M1NDeXoK; spf=pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390342AbgJZVsp (ORCPT + 7 others); Mon, 26 Oct 2020 17:48:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:50172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390340AbgJZVsp (ORCPT ); Mon, 26 Oct 2020 17:48:45 -0400 Received: from localhost.localdomain (unknown [192.30.34.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B123B207E8; Mon, 26 Oct 2020 21:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603748924; bh=R7zMDymsvhTfopdeoblEJpa47TFpLO5lTLpTKm/lObU=; h=From:To:Cc:Subject:Date:From; b=M1NDeXoK7s+A7e/qV2TipTvaMbyCdFn9rmPhQfFtkGEE+WLsz6dUA5bBa9eq4cGQi 7NisPujAUpEBgQPdKNI6+2Iw841e9J/v6CDtRcvVi5XviiscjH10RBB54UB+tXIoNH TJ9BzYliB8YVx5TbF48VMknMIbvtKwtxbb2ZE7rQ= From: Arnd Bergmann To: "Rafael J. Wysocki" , Len Brown , Yinghai Lu Cc: Arnd Bergmann , "Gustavo A. R. Silva" , Hanjun Guo , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ACPI: dock: fix enum-conversion warning Date: Mon, 26 Oct 2020 22:48:34 +0100 Message-Id: <20201026214838.3892471-1-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Arnd Bergmann gcc points out a type mismatch: drivers/acpi/dock.c: In function 'hot_remove_dock_devices': drivers/acpi/dock.c:234:53: warning: implicit conversion from 'enum ' to 'enum dock_callback_type' [-Wenum-conversion] 234 | dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, false); This is harmless because 'false' still has the correct numeric value, but passing DOCK_CALL_HANDLER documents better what is going on and avoids the warning. Fixes: 37f908778f20 ("ACPI / dock: Walk list in reverse order during removal of devices") Fixes: f09ce741a03a ("ACPI / dock / PCI: Drop ACPI dock notifier chain") Signed-off-by: Arnd Bergmann --- drivers/acpi/dock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.27.0 Reviewed-by: Hanjun Guo diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c index 45d4b7b69de8..24e076f44d23 100644 --- a/drivers/acpi/dock.c +++ b/drivers/acpi/dock.c @@ -231,7 +231,8 @@ static void hot_remove_dock_devices(struct dock_station *ds) * between them). */ list_for_each_entry_reverse(dd, &ds->dependent_devices, list) - dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, false); + dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, + DOCK_CALL_HANDLER); list_for_each_entry_reverse(dd, &ds->dependent_devices, list) acpi_bus_trim(dd->adev);