From patchwork Thu Jan 4 12:37:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 123407 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp11376785qgn; Thu, 4 Jan 2018 04:37:50 -0800 (PST) X-Google-Smtp-Source: ACJfBotixZQybYp7wVvIqBQX5JKXlkM2bBZi4PulKB5uHalli4yxryE6TDxZMkarJ1EYKqSIIUbN X-Received: by 10.223.143.12 with SMTP id p12mr4184238wrb.99.1515069470343; Thu, 04 Jan 2018 04:37:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515069470; cv=none; d=google.com; s=arc-20160816; b=AwS87yx/K6HGSWNbFHdBKNGu5KRXLVMYjdL2o6su1/CxP5qvDvcBD1yWnCJiHT5QRa NQ/iPzflS9tk3WBPcCDMiF1vxCxcHNMu20SWnlgQk/sKdPR91Lt1vF141z3xiKlV9/du AzAzzcOpJjuPkMc+vffCcVijlQf5xmPoM8slGakw2vKQUim9xDuYVEhwz5dh7wtqh+Bp 8kt3kBNRAEqpQwAzpYlJDoO50FQCwBAVoW2mDPuhlVFxCXbNuKc0VJ+vZfXvtxrFFpfM IkQ7gmVDcRTaC1ITVivj9hfHZXo2bcikUpE2sw87Y5xqrIoyUzM5UwHO8IpQHyG5a9S2 qB6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=alFmuLH75XLrqgBsrCP+85CgDNIyfvaK6EXIu/mb1nE=; b=STtogLl87QU2TUJaLNlXUjHWG3LZCjYkETP5ffntcQvaJGFcwyFXFuW6n/KAj6jn7p MFl6koktF/Q7O+7we776m2/XSp3KmfUyA7tXOLpMpAj3W4Rlk5MbVdI/Ng3qKmkKRS5j OXLMdVJynIURMqxTRcV7BhHdblR4cXBUDopzj2XbWiir/GBpcQl+smfIrhP1UXsjY5Nz Wr02GMZ4MPWeFc5RBeKZVdyIp9eEXu/r2LBPlJym1fKgYy1e9xo9R4FbJ0hc7bWNO+Lp cnmsVigu8O3nW5HgYwD6wXnffSGnFd7PAtTyYSQ1LzqCV+faPSRktzUcPbFReoGg2bzH a/ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=oGXyVAau; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id c75si2174197wme.91.2018.01.04.04.37.50; Thu, 04 Jan 2018 04:37:50 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=oGXyVAau; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A7F2D267860; Thu, 4 Jan 2018 13:37:38 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B098226785C; Thu, 4 Jan 2018 13:37:35 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id DC7AA26785A for ; Thu, 4 Jan 2018 13:37:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=00BXZwjheU3fRC8npfXPIDihluaBR9vzzOm5MiT0dTU=; b=oGXyVAauK3Pp 1t55tut4C2K9BHdpOIBZOMis0sGGXz/85DR1eikuAG6hz+BRsReqGUISg5ypHTm+Dt20hA2KOxG65 8tKOTy0YJbZ6lGSwiZSeRY7blqATDpI1b+hdqgiwBReMcqOpIuQwc7zbmJ3xcrQxNV17BuDezoK2k heGA8=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eX4lw-0007Fq-HR; Thu, 04 Jan 2018 12:37:24 +0000 Received: from broonie by debutante with local (Exim 4.90) (envelope-from ) id 1eX4lw-00061F-2b; Thu, 04 Jan 2018 12:37:24 +0000 From: Mark Brown To: Bard Liao In-Reply-To: <1514461296-16236-1-git-send-email-bardliao@realtek.com> Message-Id: Date: Thu, 04 Jan 2018 12:37:24 +0000 Cc: oder_chiou@realtek.com, jack.yu@realtek.com, alsa-devel@alsa-project.org, lars@metafoo.de, lgirdwood@gmail.com, hdegoede@redhat.com, broonie@kernel.org, shumingf@realtek.com, flove@realtek.com Subject: [alsa-devel] Applied "ASoC: rt5645: change micbias widget type to supply." to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rt5645: change micbias widget type to supply. has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From bd70b19e9e7e87ad330d820386774f304e74d112 Mon Sep 17 00:00:00 2001 From: Bard Liao Date: Wed, 3 Jan 2018 13:39:01 +0100 Subject: [PATCH] ASoC: rt5645: change micbias widget type to supply. Register "micbias1" and "micbias2" to supply widgets as modern drivers do. This should not cause any (new) issues for existing users of the codec, since micbias support is broken anyways. Micbias support needs the RT5645_MICBIAS?_POW_CTRL_SEL bits in the RT5645_GEN_CTRL2 register to be updated when enabled/disabled which we currently do not do. The updating of these bits will be fixed in a follow-up commit. Signed-off-by: Bard Liao Signed-off-by: Hans de Goede Signed-off-by: Mark Brown --- sound/soc/codecs/rt5645.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.15.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index daf7b73ba415..6f6da0abe220 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -1980,10 +1980,10 @@ static const struct snd_soc_dapm_widget rt5645_dapm_widgets[] = { /* Input Side */ /* micbias */ - SND_SOC_DAPM_MICBIAS("micbias1", RT5645_PWR_ANLG2, - RT5645_PWR_MB1_BIT, 0), - SND_SOC_DAPM_MICBIAS("micbias2", RT5645_PWR_ANLG2, - RT5645_PWR_MB2_BIT, 0), + SND_SOC_DAPM_SUPPLY("micbias1", RT5645_PWR_ANLG2, + RT5645_PWR_MB1_BIT, 0, NULL, 0), + SND_SOC_DAPM_SUPPLY("micbias2", RT5645_PWR_ANLG2, + RT5645_PWR_MB2_BIT, 0, NULL, 0), /* Input Lines */ SND_SOC_DAPM_INPUT("DMIC L1"), SND_SOC_DAPM_INPUT("DMIC R1"),