From patchwork Tue Jan 9 04:32:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 123805 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3562229qgn; Mon, 8 Jan 2018 20:33:10 -0800 (PST) X-Google-Smtp-Source: ACJfBov6SnRniDkAK3gsHz5rOHP1WDhXKb7sW/8kZx5mbiGDwmR16mx7UP7LLtFiZfDrgTY2TfaO X-Received: by 10.159.194.136 with SMTP id y8mr6742232pln.212.1515472390290; Mon, 08 Jan 2018 20:33:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515472390; cv=none; d=google.com; s=arc-20160816; b=qztnenZAGncI53FjmTcIqfe8QtdJCEP4ObRo6mUHFdano7UrnwJIK8uAtgD3URgmEK eqAUW1j2NiSfpaCVhm+F9rgxAJGitCe0xs22Ep+SoojLc5lHwKDWIhIWK52AEKZCc32E J6pAgYLtc26vDX5HdOSRIeAl5qltUatI+ymhChjJiGG9bFXT/kRhtZHYHjqDxhROBBaZ y6h8FZoyQCHyvCLlXLRVRH3SFVQov9HLS6CHxJvDDQ4U8dSt62MqT6vlZr6Ew8ZYFT0Z 3T/oceVnSLCckpYTysYrBuApfTeGZbigQDPHuj3D7xAJMhqUFLImofB5i4G52AWFzIun rj6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=Nbv8H4wtGL92osj+zrBy3HsGlf6UQwDAgxAFgx4+edM=; b=E1yqTWkGgBvAHWoAFhTcqHFj4xVweURtJe8/04+Eh0yG7vk8c2GtqLlZgKE+li+C9v vF88dj4m/1tPHoS5Yl0Xx4ClkxuNWqfmeCf0jRaGoz7xcdVZ/iZqCDxspSy4xHva3uhJ QPQfi0fitJ3VjNPMoygX8HpBWB/sLpmXMnio83KO+yCJVDWVkOsoaFOxr/Y54a0GPb3h 2X7H2+yfqP8tbZe411OIDmuzHUhMhbqr8nJyWCsb4DctSxnBmbtpB6CF+oWLgrwNR9E6 V7urnVVCAh2ivFuf4z/Et5ND+9BSDJHRY381f/lZBdKSKQ5rB7193u8YIAS5oPakQDfk 7Fzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UPKHt9wG; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 88si9712333pla.827.2018.01.08.20.33.10; Mon, 08 Jan 2018 20:33:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UPKHt9wG; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754552AbeAIEdG (ORCPT + 6 others); Mon, 8 Jan 2018 23:33:06 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:45460 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754238AbeAIEdG (ORCPT ); Mon, 8 Jan 2018 23:33:06 -0500 Received: by mail-wr0-f195.google.com with SMTP id 16so341551wry.12 for ; Mon, 08 Jan 2018 20:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=1sA+EBRZJFT7zKo8U8AXe18HJJxkjH9KdTZ9eBtedKg=; b=UPKHt9wGPS2VEwe3zlFLfS/rIxIXOQbaF3Uguu84db8FVV0lx+4I0CK3SpyZa0/Y7g I075Ea/IHvn5mr/kG3EDlXPyqjYs/LqT3gALKsAWULxzqpylqvbOHB36ru+uWXWY6Sq1 zXJFerhYjBqVdGqwzkDzf9ijpd2GSihqe/I48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1sA+EBRZJFT7zKo8U8AXe18HJJxkjH9KdTZ9eBtedKg=; b=M+JhTzbAJwwykH6yI8z3XwCWLFdDsHHv80ubo7zzsY5dd+2rBjL7lxGYHiDEdRtaUS Yi8mCnG6OfQYRQ8Hc7GonOMkGlcsPrNe165ulctojpUUVMrzrOvhlI4XE+f0JVvw4zpO MLI41Qvjp7AC2noOJaC0JaHVzdh96T5Qjl+nbbs7HEWzVxcVwYIlr1bjW6OQXem7508b y4wx6MCuMNH0saRFCLBWdnbUXyy4VS2o0+G2W89gYFTHKvMI0dg4XtkffnsX5oUgxUW3 qj95UiQYad9WdzfRIZDTWv43AqBI3ACNsPxVw0WC8EL7DuERW01NGsO41QW0LMPI4xzV Vnkg== X-Gm-Message-State: AKGB3mLDsshoOlujrRjtnBJtUbpJTByrmfln7MQICzYPC+SVKmf3yHSp iXNVvPch069DjosVZCybTc3s6Q== X-Received: by 10.223.141.206 with SMTP id o72mr3458863wrb.0.1515472384817; Mon, 08 Jan 2018 20:33:04 -0800 (PST) Received: from localhost.localdomain (li560-169.members.linode.com. [151.236.216.169]) by smtp.gmail.com with ESMTPSA id d8sm12564032wrf.88.2018.01.08.20.32.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 08 Jan 2018 20:33:03 -0800 (PST) From: Leo Yan To: Wei Xu , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan , Daniel Lezcano , Kevin Wang , Vincent Guittot Subject: [PATCH] arm64: dts: Hi3660: Remove 'CPU_NAP' idle state Date: Tue, 9 Jan 2018 12:32:42 +0800 Message-Id: <1515472362-19979-1-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks a lot for Vincent Guittot careful work to find bug for 'CPU_NAP' idle state. At early time, the CPU CA73 CPU_NAP idle state has been supported on Hikey960. Later we found the system has the hang issue and for resolving this issue Hisilicon released new MCU firmware, but unfortunately the new MCU firmware has side effect and results in the CA73 CPU cannot really enter CPU_NAP state and roll back to WFI state. After discussion we cannot see the possibility to enable CA73 CPU_NAP state anymore on Hikey960, based on this conclusion we should remove this state from DT binding. Cc: Daniel Lezcano Cc: Kevin Wang Cc: Vincent Guittot Signed-off-by: Leo Yan --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 32 ++++--------------------------- 1 file changed, 4 insertions(+), 28 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Tested-by: Vincent Guittot diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi index ab0b95b..8fddf0d 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi @@ -96,11 +96,7 @@ reg = <0x0 0x100>; enable-method = "psci"; next-level-cache = <&A73_L2>; - cpu-idle-states = < - &CPU_NAP - &CPU_SLEEP - &CLUSTER_SLEEP_1 - >; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>; }; cpu5: cpu@101 { @@ -109,11 +105,7 @@ reg = <0x0 0x101>; enable-method = "psci"; next-level-cache = <&A73_L2>; - cpu-idle-states = < - &CPU_NAP - &CPU_SLEEP - &CLUSTER_SLEEP_1 - >; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>; }; cpu6: cpu@102 { @@ -122,11 +114,7 @@ reg = <0x0 0x102>; enable-method = "psci"; next-level-cache = <&A73_L2>; - cpu-idle-states = < - &CPU_NAP - &CPU_SLEEP - &CLUSTER_SLEEP_1 - >; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>; }; cpu7: cpu@103 { @@ -135,24 +123,12 @@ reg = <0x0 0x103>; enable-method = "psci"; next-level-cache = <&A73_L2>; - cpu-idle-states = < - &CPU_NAP - &CPU_SLEEP - &CLUSTER_SLEEP_1 - >; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>; }; idle-states { entry-method = "psci"; - CPU_NAP: cpu-nap { - compatible = "arm,idle-state"; - arm,psci-suspend-param = <0x0000001>; - entry-latency-us = <7>; - exit-latency-us = <2>; - min-residency-us = <15>; - }; - CPU_SLEEP: cpu-sleep { compatible = "arm,idle-state"; local-timer-stop;