From patchwork Fri Nov 13 12:42:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 324281 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp1164618ils; Fri, 13 Nov 2020 04:42:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8T/BvlYY0eKQAdrAaw/5nYudJru4ifn56qAR3enH6mBL5ObIn2FsF5uGA+NBkCKhLhIjH X-Received: by 2002:a17:906:ca83:: with SMTP id js3mr1796085ejb.42.1605271372246; Fri, 13 Nov 2020 04:42:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605271372; cv=none; d=google.com; s=arc-20160816; b=U5Y1JGJTKyo59DyR8w5I8m1RVaB8E+JK8z5NoVWkU5cwndAFK0bWVrXn1yA4Q+wniC L9i8nZpQtjgEDFAp8segtKvUYka7hCea4LnRmrZ9IjyCeW7oQSQxAOvSU9n3rAvCTDhu gajWna1ozqOH1NlDtVXql+TiuZZhlhWqAfeJoHGSAe+MRx3XQhSfJ1ry5hxNgYzsmRQ5 GaUZkK6y48DWdzuWbpPTLWVx+v4uTP/3N6U5NCozjXFU7vogrFuUngch1mmS8qmtfIEe 4IxlfhYRQMUEiXGhRU75C66F/k/Ft4vOe2WjGOqexCVcbL3Jyz0Ehi3dX0L0tKcJs7u+ 4nSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=q+8Hrzon9gesumLfOBGrHFfOxhLMmIMscN3ufv1mMIk=; b=FYeELDmnQL01Fc3s5R+Y/fD+t/V0gEFz/8A+s8oUgInYveN/P2agk0wvzmYYHfTSKu WU2XnJ8zQrIqW2xQqwhCZiu7UqSDcddSVvGrb365F1bnvm4thARBTPV94uU3eLHAwEUh h/MdlCf9HjW9eo6KLeliXqiBAObktCssFjNHmT1EYhFmhcesZpYvnKiM5qqwOm3LUncB QYKgHFKTxsnS29jiQmTh6qCWQlKIAeeKB8t6kr6WCKiPzt0PO4QzIHVidK1yvruiaKLt cKmaqKy34awteNNt470DFRQruWWNjYda/n2XkfY5f137MW1TM0jfLCRBYWDZzD+lBjVP w0QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o20RNJa6; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt15si5828672ejc.661.2020.11.13.04.42.52; Fri, 13 Nov 2020 04:42:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o20RNJa6; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726392AbgKMMms (ORCPT + 4 others); Fri, 13 Nov 2020 07:42:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgKMMmr (ORCPT ); Fri, 13 Nov 2020 07:42:47 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D50BC0617A7 for ; Fri, 13 Nov 2020 04:42:44 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id z21so13572809lfe.12 for ; Fri, 13 Nov 2020 04:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q+8Hrzon9gesumLfOBGrHFfOxhLMmIMscN3ufv1mMIk=; b=o20RNJa6gK0J4ZDdRnpd60Mtk3r3Pr6RCtn2LpeDEbx8HJXFL/R22fVzuP1ZhgiD4x ryFG/DFVPAyTm1fV5+OUTYAunz8LhoViSdJviPFvMfqP43tKEo6mdXOK5ZwmR6mS1H1B fVl2iYCgNklxVqWjI1UP4mF/ngkBHfyCJ6ZQwGnYPbd9YgVkn+D3j7ozvw+rcsutTDlr ZwaLj2wYPpmkQX9tdTMEUbuh3h1KUTTveI6qtSmOHfk7sCtQCQOVovjNAnvf0FD0Axxc Ur1uMnT+8pV6bHuMRdHkJ5Tb6ORmnUGFjQ1ily8Nz1me8Izuh6fLDAZmTtbXru+r10bq S52A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q+8Hrzon9gesumLfOBGrHFfOxhLMmIMscN3ufv1mMIk=; b=F8ihNj8mtJVTN6s1w9LVZXkCpt1UTVWueOobCcz5gr0UBt17ni2L29HBQvPkPCme91 YE/lE8bxdfWgJFqKQdXFOPeNKp7jdain/4rkTw2ngAyuUNseCVPXIVs3/Hcu7zpIA2av cGdQerU6oOOLB+aFkTLHiYrs3eEEQ8iHxzvQqzJP94b7xsO7hDCKri4E6YJDsqu/hO42 afS0g8Lfp/g5bJydJ9okBNCq3F4qmUv+9FF6yf/drNyJBKooXOvunLyTdddTKXGSXO8A 5hCkSgXn+oxN1PCViYpovTPFtoB0O8xUQBd/Jgb6OA5HWmUCITMycne6sPmruuqDhMBp Masw== X-Gm-Message-State: AOAM530d5271E3rlNJpry7GeZP3gPo1OSixgg2qw6gCl1HGkPH7yNnrr HWQ/sp9D9mlyWsTwPw/meJi4DA== X-Received: by 2002:ac2:46ce:: with SMTP id p14mr752605lfo.590.1605271361582; Fri, 13 Nov 2020 04:42:41 -0800 (PST) Received: from localhost.bredbandsbolaget (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id j127sm1537599lfd.34.2020.11.13.04.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 04:42:40 -0800 (PST) From: Linus Walleij To: Jacek Anaszewski , Pavel Machek , Dan Murphy Cc: linux-leds@vger.kernel.org, Linus Walleij , Sakari Ailus , newbytee@protonmail.com, Stephan Gerhold , phone-devel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/2 v5] dt-bindings: leds: Add DT binding for Richtek RT8515 Date: Fri, 13 Nov 2020 13:42:38 +0100 Message-Id: <20201113124239.2667502-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Add a YAML devicetree binding for the Richtek RT8515 dual channel flash/torch LED driver. Cc: Sakari Ailus Cc: newbytee@protonmail.com Cc: Stephan Gerhold Cc: phone-devel@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v4->v5: - Fix the RFS/RTS resistors to reference the u32 schema. - Fix resisitor speling error. ChangeLog v3->v4: - Add DT attributes for the RFS and RTS resistors, so that the hardware-defined maximum current can be determined. - Add torch-max-microamp to the common bindings so we can set an attribute for the max microamp in torch mode. - Add flash-max-microamp and torch-max-microamp as optional to the LED node. - Slot in some elabortative descriptions of the new properties and describe what the hardware is doing. - Cc phone-devel@vger.kernel.org ChangeLog v2->v3: - Add Sakari to CC - Resend ChangeLog v1->v2: - Explicitly inherit function, color and flash-max-timeout-us from common.yaml - Add "led" node as required. --- .../devicetree/bindings/leds/common.yaml | 6 + .../bindings/leds/richtek,rt8515.yaml | 111 ++++++++++++++++++ 2 files changed, 117 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/richtek,rt8515.yaml -- 2.26.2 diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index f1211e7045f1..92fa90b4a671 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -151,6 +151,12 @@ properties: Maximum flash LED supply current in microamperes. Required for flash LED nodes with configurable current. + torch-max-microamp: + description: + Maximum flash LED supply current in microamperes, when the flash LED is + used as a torch (flashlight). This is usually lower than the flash mode + maximum current, if the LED supports torch mode. + flash-max-timeout-us: description: Maximum timeout in microseconds after which the flash LED is turned off. diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml new file mode 100644 index 000000000000..b1f69277c5d3 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml @@ -0,0 +1,111 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/richtek,rt8515.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Richtek RT8515 1.5A dual channel LED driver + +maintainers: + - Linus Walleij + +description: | + The Richtek RT8515 is a dual channel (two mode) LED driver that + supports driving a white LED in flash or torch mode. The maximum + current for each mode is defined in hardware using two resistors + RFS and RTS. + +properties: + compatible: + const: richtek,rt8515 + + enf-gpios: + maxItems: 1 + description: A connection to the 'ENF' (enable flash) pin. + + ent-gpios: + maxItems: 1 + description: A connection to the 'ENT' (enable torch) pin. + + richtek,rfs: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 7680 + maximum: 367000 + description: The resistance value of the RFS resistor. This + resistors limits the maximum flash current. This must be set + for the property flash-max-microamp to work, the RFS resistor + defines the range of the dimmer setting (brightness) of the + flash LED. + + richtek,rts: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 7680 + maximum: 367000 + description: The resistance value of the RTS resistor. This + resistors limits the maximum torch current. This must be set + for the property torch-max-microamp to work, the RTS resistor + defines the range of the dimmer setting (brightness) of the + torch LED. + + led: + type: object + $ref: common.yaml# + properties: + function: true + color: true + flash-max-timeout-us: true + + flash-max-microamp: + maximum: 700000 + description: The maximum current for flash mode + is hardwired to the component using the RFS resistor to + ground. The maximum hardware current setting is calculated + according to the formula Imax = 5500 / RFS. The lowest + allowed resistance value is 7.86 kOhm giving an absolute + maximum current of 700mA. By setting this attribute in + the device tree, you can further restrict the maximum + current below the hardware limit. This requires the RFS + to be defined as it defines the maximum range. + + torch-max-microamp: + maximum: 700000 + description: The maximum current for torch mode + is hardwired to the component using the RTS resistor to + ground. The maximum hardware current setting is calculated + according to the formula Imax = 5500 / RTS. The lowest + allowed resistance value is 7.86 kOhm giving an absolute + maximum current of 700mA. By setting this attribute in + the device tree, you can further restrict the maximum + current below the hardware limit. This requires the RTS + to be defined as it defines the maximum range. + +required: + - compatible + - ent-gpios + - enf-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + led-controller { + compatible = "richtek,rt8515"; + enf-gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>; + ent-gpios = <&gpio4 13 GPIO_ACTIVE_HIGH>; + richtek,rfs = <16000>; + richtek,rts = <100000>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + torch-max-microamp = <25000>; + }; + }; + +... From patchwork Fri Nov 13 12:42:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 324282 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp1164632ils; Fri, 13 Nov 2020 04:42:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnITsvsXfPLR/wPg2DvTu0GH6fyno4mvZsb9v7Zi6lhHFGKItKgq4NMcTuRDSSI/8glepz X-Received: by 2002:aa7:df81:: with SMTP id b1mr2158307edy.365.1605271373341; Fri, 13 Nov 2020 04:42:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605271373; cv=none; d=google.com; s=arc-20160816; b=MdETgY3xvBJEP8u225kf+PqoxgAgw04ksSd3mvFS+nSc5VIIYtYFIC6ifJVmfGIfs7 pMatBpQ3chMO4RIlDi8904BvUX2lkNUVTRwdnaUJjapvyRLHmZ2KKSF+ua4u4moEXpyG gUTEc/zaHBrIh2X/wauSfdt6L63yCnhMENr06IjcWiObZz8Ytp86elu3ZjiawU6DVcli CkyWHpBkQW0Y4B2L25WX1GGRv/i/lp0NlZsOcwbOVY5MgrKaeOCTWo4DFG3UThaDnd9+ Ie+7hD49exQ3cIOy8Qdag0IxyQGeYAEZS8xDGH2bJj9VtEb1WJZCbeU8sVWOc33iviuf cbhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AcF7xvIslOQoIpEI1UcHbIcZaurB1emI17BkRjclp+o=; b=WVMTVKsB6J70890bCNs3z/JQIrY95YrY8e/1z2XJAbPlGgBD8VE2D1xKGlJ4IVGLSt plJG/F9TnjzFlFsFHMy/ptLJ7m+zZPkPd6yFpQwZ/mI9aH39DFU2wJ6fDYZtLX3ch/5v rC8Ndn7l/kQ2zjZFNKpev73L0j7cprodnuDRLh5spCmgwzp8X8XVQwiwtGFEu1y3ruwB oQNOo06tzewQ7RMJMBYnNc6PY8bU0R3zn96JQHaweyHjek5Z84TK1qciXiUZFX2+wUdf R7/IIfnreGcatxo7SEbH+T+AWcbi44bnD3ge267MwqaSzvkZY7Sp4SEz8hjirfIZhPb+ +wDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xqyLaF3D; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt15si5828672ejc.661.2020.11.13.04.42.53; Fri, 13 Nov 2020 04:42:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xqyLaF3D; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbgKMMmt (ORCPT + 4 others); Fri, 13 Nov 2020 07:42:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726237AbgKMMms (ORCPT ); Fri, 13 Nov 2020 07:42:48 -0500 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AEF0C061A49 for ; Fri, 13 Nov 2020 04:42:46 -0800 (PST) Received: by mail-lf1-x141.google.com with SMTP id l11so1520759lfg.0 for ; Fri, 13 Nov 2020 04:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AcF7xvIslOQoIpEI1UcHbIcZaurB1emI17BkRjclp+o=; b=xqyLaF3D3gYh99gN8r6pgNcPuXNxKwyM86CXbX4TW2yvH12VQL5Xwi21lJvr0bSUrz XsoqjiDChmAabdlAr8lkBE3VE6zm4Luyc99Ep00laaJDgll8nuLP4CLS76Ny9fRO5MBn Taod/pNnCIMNZdJrnz+tjpm2fZfdZcHTBTAqWGcpUawcdwPYBjxUzEhVnSh6xtATFgRq GFQOClkvDdzGnek9PyYE2RBwhOudmw+VDUWAXpvoLniihgQpBA88tqklzpZTWJDy7gfD +dAfkjHpKZWmRMWxPSXtPqUdAPNXn1HeEItXDDqXQ+ER/CV0BdcJE9HswAGV0tWFbclb LhrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AcF7xvIslOQoIpEI1UcHbIcZaurB1emI17BkRjclp+o=; b=dgqFOq4nN9Jjw/UHPWdNAqNPMzOLuTtTdNw+C1kODhUmdm/uAJMYyHjP/CTQLygHaw pM9sjwblEVUuNScaLFWn7bdwbUbBVQGkuELBPJ0CI/MQBVMbJBk2xtiaMfl+a9aZC4wY whET/6ojOnaybJHSycDCgRLF4EUe7d4mIW8hQwuyQPdwrWwGm3zF9AHfHE5/SoxwBQkK pqUnq7tKMQwXJtfxvayYAyRtam0yODR20PuVstez3mzZVDFbL0LNNEnlCzoXJWhIixpf /PCvETlNX0SXD9G2Q/JLdDAIxJXTl0XuPo2Z9/CiB1sf8+6/h8a/gGJCA9hgKIR4ynnY bkFA== X-Gm-Message-State: AOAM530YHzmmfILcI6Ro6FcR1YUOuihHDHuEGBHDnj5dmuLsN0bDmIvw tmWTT+r+PbNLOtx1ym29ZDrz5Q== X-Received: by 2002:a19:686:: with SMTP id 128mr760767lfg.198.1605271364397; Fri, 13 Nov 2020 04:42:44 -0800 (PST) Received: from localhost.bredbandsbolaget (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id j127sm1537599lfd.34.2020.11.13.04.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 04:42:43 -0800 (PST) From: Linus Walleij To: Jacek Anaszewski , Pavel Machek , Dan Murphy Cc: linux-leds@vger.kernel.org, Linus Walleij , Sakari Ailus , newbytee@protonmail.com, Stephan Gerhold , linux-media@vger.kernel.org, phone-devel@vger.kernel.org Subject: [PATCH 2/2 v5] leds: rt8515: Add Richtek RT8515 LED driver Date: Fri, 13 Nov 2020 13:42:39 +0100 Message-Id: <20201113124239.2667502-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201113124239.2667502-1-linus.walleij@linaro.org> References: <20201113124239.2667502-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This adds a driver for the Richtek RT8515 dual channel torch/flash white LED driver. This LED driver is found in some mobile phones from Samsung such as the GT-S7710 and GT-I8190. A V4L interface is added. We do not have a proper datasheet for the RT8515 but it turns out that RT9387A has a public datasheet and is essentially the same chip. We designed the driver in accordance with this datasheet. The day someone needs to drive a RT9387A this driver can probably easily be augmented to handle that chip too. Cc: Sakari Ailus Cc: newbytee@protonmail.com Cc: Stephan Gerhold Cc: linux-media@vger.kernel.org Cc: phone-devel@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v4->v5: - Fix a missing static keyword, complaint from the kernel autobuilder robot. ChangeLog v3->v4: - Create a new subdirectory for flash LEDs under drivers/leds/flash as requested by Pavel, move the driver there and set up a kbuild structure for pure flash LEDs. (Others can follow the established pattern.) - Handle the new richtek,rfs and richtek,rts resistor values that make it possible to determine the current range configured in the hardware. - Handle the new flash-max-microamp and torch-max-microamp if present and optionally further restrict the current range using these. Otherwise fall back on the hardware defaults as specified by the RFS and RTS resistors. - Cc phone-devel@vger.kernel.org - License as GPL-2.0-or-later - Renable ent and enf gpio descriptors to enable_torch and enable_flash Changelog v2->v3: - Expand commit message. - Add Sakari to Cc. - Resend. ChangeLog v1->v2: - Break out routine to bitbang the brightness on a GPIO pin. - Do not hardcode the LED name so that the framework can name it from DT properties. --- drivers/leds/Kconfig | 3 + drivers/leds/Makefile | 3 + drivers/leds/flash/Kconfig | 15 ++ drivers/leds/flash/Makefile | 3 + drivers/leds/flash/leds-rt8515.c | 373 +++++++++++++++++++++++++++++++ 5 files changed, 397 insertions(+) create mode 100644 drivers/leds/flash/Kconfig create mode 100644 drivers/leds/flash/Makefile create mode 100644 drivers/leds/flash/leds-rt8515.c -- 2.26.2 diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 849d3c5f908e..6c1d8b69a465 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -928,6 +928,9 @@ config LEDS_ACER_A500 This option enables support for the Power Button LED of Acer Iconia Tab A500. +comment "Flash and Torch LED drivers" +source "drivers/leds/flash/Kconfig" + comment "LED Triggers" source "drivers/leds/trigger/Kconfig" diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 73e603e1727e..156c0b4e60d9 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -103,5 +103,8 @@ obj-$(CONFIG_LEDS_SPI_BYTE) += leds-spi-byte.o # LED Userspace Drivers obj-$(CONFIG_LEDS_USER) += uleds.o +# Flash and Torch LED Drivers +obj-$(CONFIG_LEDS_CLASS_FLASH) += flash/ + # LED Triggers obj-$(CONFIG_LEDS_TRIGGERS) += trigger/ diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig new file mode 100644 index 000000000000..d21d273ef3da --- /dev/null +++ b/drivers/leds/flash/Kconfig @@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0 + +if LEDS_CLASS_FLASH + +config LEDS_RT8515 + tristate "LED support for Richtek RT8515 flash/torch LED" + depends on GPIOLIB + help + This option enables support for the Richtek RT8515 flash + and torch LEDs found on some mobile phones. + + To compile this driver as a module, choose M here: the module + will be called leds-rt8515. + +endif # LEDS_CLASS_FLASH diff --git a/drivers/leds/flash/Makefile b/drivers/leds/flash/Makefile new file mode 100644 index 000000000000..e990e257f4d7 --- /dev/null +++ b/drivers/leds/flash/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0 + +obj-$(CONFIG_LEDS_RT8515) += leds-rt8515.o diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8515.c new file mode 100644 index 000000000000..f092a661480d --- /dev/null +++ b/drivers/leds/flash/leds-rt8515.c @@ -0,0 +1,373 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * LED driver for Richtek RT8515 flash/torch white LEDs + * found on some Samsung mobile phones. + * This is a 1.5A Boost dual channel driver produced around 2011. + * + * Linus Walleij + */ +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +/* We can provide 15-700 mA out to the LED */ +#define RT8515_MIN_IOUT_MA 15 +#define RT8515_MAX_IOUT_MA 700 +/* The maximum intensity is 1-16 for flash and 1-100 for torch */ +#define RT8515_FLASH_MAX 16 +#define RT8515_TORCH_MAX 100 + +#define RT8515_TIMEOUT_DEFAULT 250000U /* 250ms */ +#define RT8515_MAX_TIMEOUT_DEFAULT 300000U /* 300ms */ + +struct rt8515 { + struct device *dev; + struct led_classdev_flash fled; + struct v4l2_flash *v4l2_flash; + struct mutex lock; + struct regulator *reg; + struct gpio_desc *enable_torch; + struct gpio_desc *enable_flash; + struct timer_list powerdown_timer; + u32 max_timeout; /* Flash max timeout */ + int flash_max_intensity; + int torch_max_intensity; +}; + +static struct rt8515 *to_rt8515(struct led_classdev_flash *fled) +{ + return container_of(fled, struct rt8515, fled); +} + +static void rt8515_gpio_brightness_commit(struct gpio_desc *gpiod, + int brightness) +{ + int i; + + /* + * Toggling a GPIO line with a small delay increases the + * brightness one step at a time. + */ + for (i = 0; i < brightness; i++) { + gpiod_set_value(gpiod, 0); + udelay(1); + gpiod_set_value(gpiod, 1); + udelay(1); + } +} + +/* This is setting the torch light level */ +static int rt8515_led_brightness_set(struct led_classdev *led, + enum led_brightness brightness) +{ + struct led_classdev_flash *fled = lcdev_to_flcdev(led); + struct rt8515 *rt = to_rt8515(fled); + + mutex_lock(&rt->lock); + + if (brightness == LED_OFF) { + /* Off */ + gpiod_set_value(rt->enable_flash, 0); + gpiod_set_value(rt->enable_torch, 0); + } else if (brightness < RT8515_TORCH_MAX) { + /* Step it up to movie mode brightness using the flash pin */ + rt8515_gpio_brightness_commit(rt->enable_torch, brightness); + } else { + /* Max torch brightness requested */ + gpiod_set_value(rt->enable_torch, 1); + } + + mutex_unlock(&rt->lock); + + return 0; +} + +static int rt8515_led_flash_strobe_set(struct led_classdev_flash *fled, + bool state) +{ + struct rt8515 *rt = to_rt8515(fled); + struct led_flash_setting *timeout = &fled->timeout; + int brightness = 4; /* max 16 */ + + mutex_lock(&rt->lock); + + if (state) { + /* Enable LED flash mode and set brightness */ + rt8515_gpio_brightness_commit(rt->enable_flash, brightness); + /* Set timeout */ + mod_timer(&rt->powerdown_timer, + jiffies + usecs_to_jiffies(timeout->val)); + } else { + del_timer_sync(&rt->powerdown_timer); + /* Turn the LED off */ + gpiod_set_value(rt->enable_flash, 0); + gpiod_set_value(rt->enable_torch, 0); + } + + fled->led_cdev.brightness = LED_OFF; + /* After this the torch LED will be disabled */ + + mutex_unlock(&rt->lock); + + return 0; +} + +static int rt8515_led_flash_strobe_get(struct led_classdev_flash *fled, + bool *state) +{ + struct rt8515 *rt = to_rt8515(fled); + + *state = timer_pending(&rt->powerdown_timer); + + return 0; +} + +static int rt8515_led_flash_timeout_set(struct led_classdev_flash *fled, + u32 timeout) +{ + /* The timeout is stored in the led-class-flash core */ + return 0; +} + +static const struct led_flash_ops rt8515_flash_ops = { + .strobe_set = rt8515_led_flash_strobe_set, + .strobe_get = rt8515_led_flash_strobe_get, + .timeout_set = rt8515_led_flash_timeout_set, +}; + +static void rt8515_powerdown_timer(struct timer_list *t) +{ + struct rt8515 *rt = from_timer(rt, t, powerdown_timer); + + /* Turn the LED off */ + gpiod_set_value(rt->enable_flash, 0); + gpiod_set_value(rt->enable_torch, 0); +} + +static void rt8515_init_flash_timeout(struct rt8515 *rt) +{ + struct led_classdev_flash *fled = &rt->fled; + struct led_flash_setting *s; + + /* Init flash timeout setting */ + s = &fled->timeout; + s->min = 1; + s->max = rt->max_timeout; + s->step = 1; + /* + * Set default timeout to RT8515_DEFAULT_TIMEOUT except if + * max_timeout from DT is lower. + */ + s->val = min(rt->max_timeout, RT8515_TIMEOUT_DEFAULT); +} + +#if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS) +/* Configure the V2L2 flash subdevice */ +static void rt8515_init_v4l2_flash_config(struct rt8515 *rt, + struct v4l2_flash_config *v4l2_sd_cfg) +{ + struct led_classdev *led = &rt->fled.led_cdev; + struct led_flash_setting *s; + + strscpy(v4l2_sd_cfg->dev_name, led->dev->kobj.name, + sizeof(v4l2_sd_cfg->dev_name)); + + /* + * Init flash intensity setting: this is a linear scale + * capped from the device tree max intensity setting + * 1..flash_max_intensity + */ + s = &v4l2_sd_cfg->intensity; + s->min = 1; + s->max = rt->flash_max_intensity; + s->step = 1; + s->val = s->max; +} + +#else +static void rt8515_init_v4l2_flash_config(struct rt8515 *rt, + struct v4l2_flash_config *v4l2_sd_cfg) +{ +} +#endif + +static void rt8515_determine_max_intensity(struct rt8515 *rt, + struct fwnode_handle *led, + const char *resistance, + const char *max_ua_prop, int hw_max, + int *max_intensity_setting) +{ + u32 res; + u32 ua; + u32 max_ma; + int max_intensity; + int ret1, ret2; + + + ret1 = fwnode_property_read_u32(rt->dev->fwnode, resistance, &res); + ret2 = fwnode_property_read_u32(led, max_ua_prop, &ua); + + /* No info in DT, OK go with hardware maxima */ + if (ret1 && ret2) { + max_ma = RT8515_MAX_IOUT_MA; + max_intensity = hw_max; + goto out_assign_max; + } + + if (ret1 || ret2) { + dev_err(rt->dev, + "either %s or %s missing from DT, using HW max\n", + resistance, max_ua_prop); + max_ma = RT8515_MAX_IOUT_MA; + max_intensity = hw_max; + goto out_assign_max; + } + + /* + * Formula from datasheet, this is the maximum current + * defined by the hardware. + */ + max_ma = (5500 * 1000) / res; + /* + * Calculate max intensity (linear scaling) + * Formula is ((ua / 1000) / max_ma) * 100, then simplified + */ + max_intensity = (ua / 10) / max_ma; + + dev_info(rt->dev, + "current restricted from %u to %u mA, max intensity %d/100\n", + max_ma, (ua / 1000), max_intensity); + +out_assign_max: + dev_info(rt->dev, "max intensity %d/%d = %d mA\n", + max_intensity, hw_max, max_ma); + *max_intensity_setting = max_intensity; +} + +static int rt8515_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct fwnode_handle *child; + struct rt8515 *rt; + struct led_classdev *led; + struct led_classdev_flash *fled; + struct led_init_data init_data = {}; + struct v4l2_flash_config v4l2_sd_cfg = {}; + int ret; + + rt = devm_kzalloc(dev, sizeof(*rt), GFP_KERNEL); + if (!rt) + return -ENOMEM; + + rt->dev = dev; + fled = &rt->fled; + led = &fled->led_cdev; + + /* ENF - Enable Flash line */ + rt->enable_flash = devm_gpiod_get(dev, "enf", GPIOD_OUT_LOW); + if (IS_ERR(rt->enable_flash)) { + dev_err(dev, "cannot get ENF (enable flash) GPIO\n"); + return PTR_ERR(rt->enable_flash); + } + + /* ENT - Enable Torch line */ + rt->enable_torch = devm_gpiod_get(dev, "ent", GPIOD_OUT_LOW); + if (IS_ERR(rt->enable_torch)) { + dev_err(dev, "cannot get ENT (enable torch) GPIO\n"); + return PTR_ERR(rt->enable_torch); + } + + child = fwnode_get_next_available_child_node(dev->fwnode, NULL); + if (!child) { + dev_err(dev, + "No fwnode child node found for connected LED.\n"); + return -EINVAL; + } + init_data.fwnode = child; + + rt8515_determine_max_intensity(rt, child, "richtek,rfs", "flash-max-microamp", + RT8515_FLASH_MAX, &rt->flash_max_intensity); + rt8515_determine_max_intensity(rt, child, "richtek,rts", "torch-max-microamp", + RT8515_TORCH_MAX, &rt->torch_max_intensity); + + ret = fwnode_property_read_u32(child, "flash-max-timeout-us", + &rt->max_timeout); + if (ret) { + rt->max_timeout = RT8515_MAX_TIMEOUT_DEFAULT; + dev_warn(dev, + "flash-max-timeout-us property missing\n"); + } + timer_setup(&rt->powerdown_timer, rt8515_powerdown_timer, 0); + rt8515_init_flash_timeout(rt); + + fled->ops = &rt8515_flash_ops; + + led->max_brightness = rt->torch_max_intensity; + led->brightness_set_blocking = rt8515_led_brightness_set; + led->flags |= LED_CORE_SUSPENDRESUME | LED_DEV_CAP_FLASH; + + mutex_init(&rt->lock); + + platform_set_drvdata(pdev, rt); + + ret = devm_led_classdev_flash_register_ext(dev, fled, &init_data); + if (ret) { + dev_err(dev, "can't register LED %s\n", led->name); + mutex_destroy(&rt->lock); + return ret; + } + + rt8515_init_v4l2_flash_config(rt, &v4l2_sd_cfg); + + /* Create a V4L2 Flash device if V4L2 flash is enabled */ + rt->v4l2_flash = v4l2_flash_init(dev, child, fled, NULL, &v4l2_sd_cfg); + if (IS_ERR(rt->v4l2_flash)) { + ret = PTR_ERR(rt->v4l2_flash); + dev_err(dev, "failed to register V4L2 flash device (%d)\n", + ret); + /* + * Continue without the V4L2 flash + * (we still have the classdev) + */ + } + + return 0; +} + +static int rt8515_remove(struct platform_device *pdev) +{ + struct rt8515 *rt = platform_get_drvdata(pdev); + + v4l2_flash_release(rt->v4l2_flash); + del_timer_sync(&rt->powerdown_timer); + mutex_destroy(&rt->lock); + + return 0; +} + +static const struct of_device_id rt8515_match[] = { + { .compatible = "richtek,rt8515", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, rt8515_match); + +static struct platform_driver rt8515_driver = { + .driver = { + .name = "rt8515", + .of_match_table = rt8515_match, + }, + .probe = rt8515_probe, + .remove = rt8515_remove, +}; +module_platform_driver(rt8515_driver); + +MODULE_AUTHOR("Linus Walleij "); +MODULE_DESCRIPTION("Richtek RT8515 LED driver"); +MODULE_LICENSE("GPL v2");