From patchwork Tue Jan 16 00:57:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124574 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp844451lje; Mon, 15 Jan 2018 17:00:59 -0800 (PST) X-Google-Smtp-Source: ACJfBovL/zRtOQZhO35KZ6YQVTpC8Uzqa2WoELCpieie5I5MneuvDwvN5k/GFIiQtpDY3fIIB+hO X-Received: by 10.37.104.141 with SMTP id d135mr5770534ybc.380.1516064459148; Mon, 15 Jan 2018 17:00:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064459; cv=none; d=google.com; s=arc-20160816; b=RsG4jk56JAojjCBCLVo+5W/xLt7ISWR4w2mb8GeJ2Ec2GMVfNJ6gVpj9aE05vvy6ai A6gp+BtFQfBJZekKlbfkDKBzO4KfCfUCeZbFEKmiuTmrtATj+GtSrUvToKQa81vIzd4K vMzG++KNRFAP3v5vOv/r8SQnBPOQ0HMV42TT4p1c5KoxOxn6k82bf07xZZHnIfwsiuD1 8wVRsHZA/vEfEO3udckP0rG4+ETfMaQN+HJxbv0r4A/5isu2BEHbIiwYeVezdbjcbbng pykfOkvarCLgWYnmswMirfRwhctfQXI3yPk6ca4clWV2XkWFXHU35nANvHRHTpsT5GGi JGxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=ltqSnojKsFqwcSlGi1u9+jF1f8ndi6nC2pCEe/N7tDU=; b=k/TvS4vjjjJIuTrTL6dTgtN5JwB6BD9rOqM2/ATYZGuhZaU+W9R6B/LjfNeRPd4IJG oSBkg/qmWXPDweE2/WWWeupfIS8/l+xHHikj3SjPpg+nczQj9rYgPNRZLWfUVW/enuIX GDIUJ0uv9Bk8eIUsyxCQxSMVt/Ny/dzEkVBOKX9k2DOTte6Ocz6YEuiP6bK0YmGroXHE uwkxl+bfje2ujA9KovPB6pKHvXZEeKMe2GuWZni3RBO0LqjSpCZLNMCFwPe3WlZofIhJ VmfzaeNNuUAli0CkdjBtV6dFrqQ465w5zXvK/KAUAOkldhC1zSoTJNcTWfoplvfCqn2J TOMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=AvcKlvFQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id t126si204023yba.229.2018.01.15.17.00.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:00:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=AvcKlvFQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49572 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFcY-0001Kq-Io for patch@linaro.org; Mon, 15 Jan 2018 20:00:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZu-0007s5-8s for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZr-0000kF-63 for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: from mail-ot0-x241.google.com ([2607:f8b0:4003:c0f::241]:33987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZr-0000hi-1W for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:11 -0500 Received: by mail-ot0-x241.google.com with SMTP id p16so12206616otf.1 for ; Mon, 15 Jan 2018 16:58:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ltqSnojKsFqwcSlGi1u9+jF1f8ndi6nC2pCEe/N7tDU=; b=AvcKlvFQytWWLV9zn32sqBFIzLnTwp+npYKO6aIw26/jzPse8WwMm1Wo5mgiZpBD2e is79Uxa9nHJblJC3TskrRYtLr5eciL+pR45fwnWBwSSd/ao6hUKm4VGIKUi/Q7je5NTd l9L1J0vrLQ2DkXhXxLkiwBtBZ01eMdh1Pdt41CBtoNTqydtZA3vkpVYtaUn/Eck8wwg8 A/MfbIZ9Eba8uIhsm6FGq8esLB5Cl1wA/QSRZK1Sr1lPKXRX0IIekKZkbfUmjWypz8XO 2UlBjcy9itsPOqoDVJotGCEO6CZJzKURd0GYB53NY0lFxU4M+7Dbj/zZ9V2JpJOpAK/D JKvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ltqSnojKsFqwcSlGi1u9+jF1f8ndi6nC2pCEe/N7tDU=; b=MUVfQTM6wecZwgiOKyKuostdZH5tgvACfhTWqRlcPppIml3CXeNT/SF9MBh9aq0qdS fwzynyoOWe/ufP9q14mXoBxmu/ESfyrcD3sHZisS9OM5NOyfS9v3hPjsXuXbobTvy8KK xiImdZi4tDImWN4CrFta0jaO3idv2+p90aBVL9txUHcQw9FqB5zg3Et/A7syOmE5C0yb RRFf7aoao4gnTrOZgupL2JnpCcBHBcMZ9DKT5Kp1nkZ0gJz72FmDNVlcxpyQJ5cGfldW 6l/54puitdGFc4IaKT6ffY4MvRC754gMwoBPfcr+VhNyYmIUp/Naj4AmERN9R+JZ8vU4 Q7pA== X-Gm-Message-State: AKwxytdp+DaTtUtDQ+OgoeZeUaN7S2zxFyvUTat9sVtdR0Mf8k3rTOph HY1kxNvpq5Yk8PDsZTPBBw== X-Received: by 10.157.32.82 with SMTP id n76mr3548204ota.301.1516064288555; Mon, 15 Jan 2018 16:58:08 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id u45sm479435otd.75.2018.01.15.16.58.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:07 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 3D3F13A9; Mon, 15 Jan 2018 18:58:06 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id C0A633000AA; Mon, 15 Jan 2018 18:58:03 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:53 -0600 Message-Id: <1516064279-14816-2-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::241 Subject: [Qemu-devel] [PATCH 1/7] Add maintainer for the IPMI code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Signed-off-by: Corey Minyard Acked-by: Marc-André Lureau --- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.7.4 diff --git a/MAINTAINERS b/MAINTAINERS index 73a5555..66a258b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -932,6 +932,15 @@ F: tests/ahci-test.c F: tests/libqos/ahci* T: git git://github.com/jnsnow/qemu.git ide +IPMI +M: Corey Minyard +S: Maintained +F: include/hw/ipmi/* +F: hw/ipmi/* +F: hw/smbios/smbios_type_38.c +F: tests/ipmi* +T: git git://github.com/cminyard/qemu.git master-ipmi-rebase + Floppy M: John Snow L: qemu-block@nongnu.org From patchwork Tue Jan 16 00:57:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124571 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp844349lje; Mon, 15 Jan 2018 17:00:35 -0800 (PST) X-Google-Smtp-Source: ACJfBotoeuOQs4/FvdBUBVAgwjtmOIgkZRGPZLGyAxYImZCo+rGe00kS/5mOmwRp99XfjaMebI+O X-Received: by 10.129.70.193 with SMTP id t184mr14022323ywa.246.1516064435830; Mon, 15 Jan 2018 17:00:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064435; cv=none; d=google.com; s=arc-20160816; b=QI2Adn0XdymjaGV2vnatDsTXsERLcRvVD/x+qmb2+mxAsMInWI/ZG5l1/QSUp/AIRl p233g4CjXQIEgStNpSqER79uEhKvokHJ6mjuwBIgLPKKcF1r0ZJbfKVhiyIWC035ttBB fNjJ8IABKYry403VYASot8Lt2ArqFcbFtN/9ZIVJuhyUXppB0WDZuxa4eT/7aqiYQOsC JdyeZ+qQeu61+E66IsgBwaZuzVSNPudxmYBwuLl1VtG68EWzOUHUXMo/Dv4ZBMeuCUB2 go+L1tAv2GgIF74zXoNTl2vnINi2ZQixEupFWXg5CT9iQGQQnENRA+6N/40MgPy3t2kn CrWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=MLnDMEiGXNLnJ8nY3azyjqRx81CXcJgMOa0TSSywrj0=; b=wGmgkY7wjOaAgOjmnx3jBcWZjZQMvt4vTF04iF74L0MMwOxrScjkMeVz4dmDBFnpJ3 7CKPslLh3JJC9ut+JrQAEtvyuvIYn13T2ZFWaiajRuoHlwU8VTnP1mjo7bWGrn406Hvj XYfJQxrqK1aHOUnnQ/wjX3zXhGzyOEr3asXi5/OxgPiCU98atSLouTcGkwtMiEJwidmq chm9LjMImKk1Y61hPhA7dehZMJgNU5+2ditRHaIZAyvaiHOgY8+BmbQr5qAx1Oi42eFY FU4xE2yXOyE6L/+Zlpjl12ZL7NqcdfOflb5E3t+HJBVNsmX6LwVREacmCQXoU80mB7eN 5piw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=m7G609S4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id l1si191815ywm.596.2018.01.15.17.00.35 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:00:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=m7G609S4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFcB-0000LI-9i for patch@linaro.org; Mon, 15 Jan 2018 20:00:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZu-0007s6-9D for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZr-0000kT-Au for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: from mail-ot0-x244.google.com ([2607:f8b0:4003:c0f::244]:33241) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZr-0000iy-61 for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:11 -0500 Received: by mail-ot0-x244.google.com with SMTP id x15so12201199ote.0 for ; Mon, 15 Jan 2018 16:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MLnDMEiGXNLnJ8nY3azyjqRx81CXcJgMOa0TSSywrj0=; b=m7G609S4gpBeL0RRfoRMGZOeo0A1J6fA0Tptyv6abSRlFpV9ddqGI4sw62hw7N5f8G Oqo3/rK+6z6s3tvd7Stjr/qBqQ62jRuvsqep2/7+IDFWtvia2gcyCavRoBTVGQyrC83E +UHQ4lFnFh4Jt+rTSvGtWafj73wJYIcv405Gg6eKCNZ8Zef3+3arn3uhJnjGO1oztLWh RiTouqYdgY8U1SkhPlP+Dv957Gvl2ElRSlfbYARgwW3aD2S5mOu31d+Yp42sU7UUY41X B0HtdVQ7g31idBAdwKnXbtDNnmn7k+yvHj6g19zy3qcLY77VX1p6WSx3J4Lh/AnUohPG BheQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MLnDMEiGXNLnJ8nY3azyjqRx81CXcJgMOa0TSSywrj0=; b=CFE2EKdYkQgaMorslcylOd8N0Wr1uYSBzIMKKbU6Es/kN6EjUZrv++2r3OOHuz0awz RVaG0J0zKdM1DB6fAlFtkhsZeB8q8NtQGAyM5QszUjpXEcblnruYc165xBn1pz64WdlU otCJECg4JUDrBH1iW63xUsVyAOLgKWuZk38gyl3z8qn4NalTwJxj+aGwokOsPtnBU/zc ++TIGoWmXUjci5AjAOEvuFR6F93s6hEixZhRUXZAe6dW1zUd/HFEou3sDp26KbuDOuya e86Hio/tnGc3ZW/BMc4BqC5Zby4DeATHAehWZ0WkXDEevQ8+pa0PVLdahmSrRNdgtoid CTEA== X-Gm-Message-State: AKwxyte52aYmZxKGtJsx/9cAbaEqBLqxEU4Worn78h709u7k54B0RkMo MuTBbxmj6BeZYSok4aoo5Q== X-Received: by 10.157.64.195 with SMTP id t3mr3263881oti.28.1516064290004; Mon, 15 Jan 2018 16:58:10 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id x139sm455154oia.10.2018.01.15.16.58.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:09 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 0DCDF8F8; Mon, 15 Jan 2018 18:58:07 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 7EDA33000A9; Mon, 15 Jan 2018 18:58:03 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:54 -0600 Message-Id: <1516064279-14816-3-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::244 Subject: [Qemu-devel] [PATCH 2/7] ipmi: Fix SEL get/set time commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard The minimum message size was on the wrong commands, for getting the time it's zero and for setting the time it's 6. Signed-off-by: Corey Minyard Reviewed-by: Cédric Le Goater Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 277c28c..cc068f2 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -1802,8 +1802,8 @@ static const IPMICmdHandler storage_cmds[] = { [IPMI_CMD_GET_SEL_ENTRY] = { get_sel_entry, 8 }, [IPMI_CMD_ADD_SEL_ENTRY] = { add_sel_entry, 18 }, [IPMI_CMD_CLEAR_SEL] = { clear_sel, 8 }, - [IPMI_CMD_GET_SEL_TIME] = { get_sel_time, 6 }, - [IPMI_CMD_SET_SEL_TIME] = { set_sel_time }, + [IPMI_CMD_GET_SEL_TIME] = { get_sel_time }, + [IPMI_CMD_SET_SEL_TIME] = { set_sel_time, 6 }, }; static const IPMINetfn storage_netfn = { From patchwork Tue Jan 16 00:57:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124573 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp844380lje; Mon, 15 Jan 2018 17:00:42 -0800 (PST) X-Google-Smtp-Source: ACJfBosYXCgdYN3/zKXd9YpQVfK87+7ZZrCIgUI0acu/bqAoTY8cN30r5uJO7jQ0vUdTpkDypV+T X-Received: by 10.37.94.6 with SMTP id s6mr7478025ybb.323.1516064442039; Mon, 15 Jan 2018 17:00:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064442; cv=none; d=google.com; s=arc-20160816; b=K2EElWiYUlfzHvb+OBuadH1UmaYRptW6UrLmUMOBqKTLXB1AHmTxvzzQQrfmH60cpC Yr94MPyh4TP2aJ42Jl2rSvbjxj60zGuVz5IuSPx9hS4wOS0Uea8Z6kNhohk5NxMevwiw dKTg1247oCPccpRFpKYsWvk/4cdQFNOw65JO/HQxIgK3GfCCQlTkK8ZRsx6re1S1EHhq dCDpkrFCQnuVfV75hLVXEQ/UBfch0zW8VIZ4cqS4L4OJECYgwuPkEuYgZYLxnsqvtmbS xKmNZ8JvBWJXSKuMHC4ocvoj1Q8wD2LyzitiJuJ3x7fmnd7wZ4KCDv4unP5onzKtUFsb SbtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=xEV6SmV/vklWlR0FbWcQCRcVYfv2IMVPXqrDvll5yxI=; b=fvUUS/K5Si7YY3aLe/nQaxtRScm9AZyyuviDeoMQvFIpZMSIFjQ3GOSiMwXu9r7EDj CecbrIoWiT/PhuZF5Da05ficxarjRhoZKYzGRfaUDGUIO2BBoMtd03Ps+bPNiIOkb++v YK81pdylHcKWRta0EcozYS/6ec+RYf9TWyBGlnGYccSgSLPYXf3SDwU838Scosu/wMf9 6HuGmOGDYn9f47+WpDraSxNkwzHxwtddvhAU0I2lBOXkEP0N6unNDCiaJDHthx2oXkRj JYcjh9HdroG08t6V94qu3Kkc0Vf9Cma46HRQmnKHkX8nJJ3GYU4kz3c46WCdamsdSIOq oNdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Eu5y3rx6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id d7si204112ywb.86.2018.01.15.17.00.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:00:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Eu5y3rx6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFcH-0000Oi-F0 for patch@linaro.org; Mon, 15 Jan 2018 20:00:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZu-0007sD-Kr for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZt-0000lz-Hn for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:33988) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZt-0000ls-Dl for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:13 -0500 Received: by mail-ot0-x242.google.com with SMTP id p16so12206718otf.1 for ; Mon, 15 Jan 2018 16:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xEV6SmV/vklWlR0FbWcQCRcVYfv2IMVPXqrDvll5yxI=; b=Eu5y3rx6G4ZVUFhwBfOieSNVqqDsjH82Ysg08sWfGJ5T2IOgJqb46BzuYvVjy7PKkq 65FKvBWk9ndLIrR+Mj5Dtf0q5f+JQHDERxbQAZXRtfdHeiUHIzayqFYCL7jfVo/hbTP7 nANslp7r7IE6lmgWPbDmm0BASs9MP5DbJ+BJRsrcS9wqHytWKPLMLmTZK11bIc+LzHak i3ik9jvKH12cCKNyNST9ynD0djZ0XsU3jxGqFA0QIn6xo52gTyrV6CTCLNAXIuJUgYZj VF0uZjHOR8dZsx+V6BJgkD/1MDuv1csmyoNL063l5JjKinrdhSGRdkj53dDhqfUvx9Pj 5IxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xEV6SmV/vklWlR0FbWcQCRcVYfv2IMVPXqrDvll5yxI=; b=pZHla/b4L5BCdID9ALGO12RLQsQeGxTIxZ/og5GPOapem9z0FOBfH82abuzYze55LP xTuB0rCopMh0vqaqUkCx8BkVuFWgdNtehmCeMvjBFU0bxcbkPDnC/1b+iq7SUHd2G8r9 fSaJzey8zZ+oqL3F/IBj56ihrScOj41sQU9T8U61ZPAGmuG8xXiefhzpUv+f1+vw2ION Ge3UiH4uMI7mUjlcDeHiRUrLvZ9txO/R+x3wjMt5Bw0Cnj5FBE4+9UezaCkHwDSmUC5N co+Op4uAxBrIC1GVnwnTKbG6av9JjWFzy9drBhmGXJUqbaUJiwnA2M6ei1NqG6/P8Ao4 eHxA== X-Gm-Message-State: AKwxytd0OHuoHGqrandsD+B9utR2lhyfbkvo8RY7wvQ2ZhgskJ0R5dcX 63+PZDXEItLAge9f3+oFCw== X-Received: by 10.157.11.234 with SMTP id 97mr11196749oth.40.1516064292596; Mon, 15 Jan 2018 16:58:12 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id f193sm466134oih.28.2018.01.15.16.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:09 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 4FF918FC; Mon, 15 Jan 2018 18:58:07 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id E06C130006F; Mon, 15 Jan 2018 18:58:04 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:55 -0600 Message-Id: <1516064279-14816-4-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::242 Subject: [Qemu-devel] [PATCH 3/7] ipmi: Don't set the timestamp on add events that don't have it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard According to the spec, from section "32.3 OEM SEL Record - Type E0h-FFh", event types from 0x0e to 0xff do not have a timestamp. So don't set it when adding those types. This required putting the timestamp in a temporary buffer, since it's still required to set the last addition time. Signed-off-by: Corey Minyard Reviewed-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index cc068f2..a0bbfd5 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -443,16 +443,21 @@ static void sel_inc_reservation(IPMISel *sel) /* Returns 1 if the SEL is full and can't hold the event. */ static int sel_add_event(IPMIBmcSim *ibs, uint8_t *event) { + uint8_t ts[4]; + event[0] = 0xff; event[1] = 0xff; - set_timestamp(ibs, event + 3); + set_timestamp(ibs, ts); + if (event[2] < 0xe0) { /* Don't set timestamps for type 0xe0-0xff. */ + memcpy(event + 3, ts, 4); + } if (ibs->sel.next_free == MAX_SEL_SIZE) { ibs->sel.overflow = 1; return 1; } event[0] = ibs->sel.next_free & 0xff; event[1] = (ibs->sel.next_free >> 8) & 0xff; - memcpy(ibs->sel.last_addition, event + 3, 4); + memcpy(ibs->sel.last_addition, ts, 4); memcpy(ibs->sel.sel[ibs->sel.next_free], event, 16); ibs->sel.next_free++; sel_inc_reservation(&ibs->sel); From patchwork Tue Jan 16 00:57:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124572 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp844360lje; Mon, 15 Jan 2018 17:00:37 -0800 (PST) X-Google-Smtp-Source: ACJfBovUE1meiLkvvgx3N1l6C/xg/Ajk8azDWcDFFxZ13/FdUG+MwDGI+Hd357fpW635vW9AkViS X-Received: by 10.37.78.131 with SMTP id c125mr6355538ybb.58.1516064436996; Mon, 15 Jan 2018 17:00:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064436; cv=none; d=google.com; s=arc-20160816; b=AGzep1J4EgSxb5r7tjqezOrQuqW6WO7TnTL/mHTEIDGDa8xOcLV9FEziusXb/snwzy zmf7yGQaTBylYRVwhN9plj+L/sjSSqtfXDLYypjS+VE62UXnLliBcM58d5WPQR3CsPeB dB9ttZnzrE3pm/j53VN3sqt8eG3GsQVbmLYhWwx0x2ld/g/2VNqvi+5JRum2HurP11eb onfagSPV97riwFjw7/cM4s2BYcgdqyiAyJP6eCnatSIEsY40PITiZdhbRv4k2POOwDc/ bCZOzqldA53rp9NefBB8cik8oUjt93LpuJewzJvL9qquluZZoKm7W9Rdyo1m0TkUU0iM WYlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=789edMDauOWZHbsNILLacYVL9cPRbrYiExCSkLdLCNY=; b=AM5zRnAN5QuTyawWVFnYklpRDLE2CtLCPlmlExNWVUB74eEBe7U4Jio62Ul6XScx7t d7nO3LCbTAHpvP8mh6cksUSvQ06KwXUpgs1aD/USFjEI57LdjQtvyMhaosmoXX55BjF1 Su9SJshuwTuHGX3C0CH9a9shnG3pbJrUpUZV+PzGXos3htPaB5ZX1Zm3ezZW0fKrHGgP KKcx3ASNUMcF+cWWkWUOOUFgq1cIFjGsK/W2C/RTupdNMx3IQIQ+f5wAFIRuMKYUqiwr /bGW/cOmGEPPaMd0Sn0QwlBAGqLP07uIsV3m3GPuwwoBFn5WyW5a3xQvtMvYtyMXpZPz hqDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ll8l8LNY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id o127si206829ywd.336.2018.01.15.17.00.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:00:36 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ll8l8LNY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFcC-0000Kk-A0 for patch@linaro.org; Mon, 15 Jan 2018 20:00:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZs-0007rq-Rg for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZr-0000ke-Lp for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:12 -0500 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]:34855) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZr-0000kK-Go for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:11 -0500 Received: by mail-oi0-x243.google.com with SMTP id j139so6479824oih.2 for ; Mon, 15 Jan 2018 16:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=789edMDauOWZHbsNILLacYVL9cPRbrYiExCSkLdLCNY=; b=ll8l8LNYZ0Yc+h0iiWs55qiCWhGZU4G/ofmfAoPQzKdyjhllN9tGk/MhFPfm8sm6QY g+o3Z9MmhsSyMGvOyNWhOgGY06QGOEv3+oeQIRdFDMNVoNXZBPckZxGs8K0DQIUlb2kp 6BmhHLxIw21NRebudWkuW874Vzae4XlwGMNjgtgwfLu5BnjpdYhNHomTAGYAWLdj79Zs WnE5fSObJCg+WsJSa9SppTrB/ba93/lzUsYM09B40NGMFj2hTc5hUeq9OxZGCXRRVxkA Ce0ovgHmu6vqsAO8J3GHeAQ7TYJw54nYpDR27fqgXUnrbWuIsYva+NN02PaY/kREV0nf ZAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=789edMDauOWZHbsNILLacYVL9cPRbrYiExCSkLdLCNY=; b=KTuGzR1RLt3s+g0CO96Cfms2fAmMAVRE0EaAoeDVIIf91/QS3C/ClqaoaG2nJmgGjO f6mY8EOT8BnNBhR0MYwjIOjaZ427iv7PziAgW9NqEUVnPv91QVmKK1sjPzMSBHPQDPXj A+tEdscEdC2C4d+fhz7yhug9DI3l8/CZ2vFtSdV17DC31s/gfy6bcOx3gsWYaQmVQk6H aRhBpyYR44McwOzbi7FjxyrfQnk5lo8HMQzxWlrkeZs2tNr/pFWZ4de2+Y/EL9TlWetS Y7UK9bLt8xkybyAnmVRTAEliqAhVreRHy1Igk04q6pdAMDyjOqkTWbepz/kI0FPGV6n/ FXmw== X-Gm-Message-State: AKwxytczNs8s0AeEj5SeSvt8VbNEADukCB9rWJIjCacvPN8b6RpCQT8I Y/kV8KNModdvHUGHfwZ7Zg== X-Received: by 10.202.216.136 with SMTP id p130mr7569818oig.6.1516064290614; Mon, 15 Jan 2018 16:58:10 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id r7sm519531otr.24.2018.01.15.16.58.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:09 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 860C96AD; Mon, 15 Jan 2018 18:58:06 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 6CB1230001C; Mon, 15 Jan 2018 18:58:04 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:56 -0600 Message-Id: <1516064279-14816-5-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::243 Subject: [Qemu-devel] [PATCH 4/7] ipmi: Add the platform event message command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard This lets an event be added to the SEL as if a sensor had generated it. The OpenIPMI driver uses it for storing panic event information. Signed-off-by: Corey Minyard Reviewed-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index a0bbfd5..e84d710 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -38,6 +38,7 @@ #define IPMI_NETFN_SENSOR_EVENT 0x04 +#define IPMI_CMD_PLATFORM_EVENT_MSG 0x02 #define IPMI_CMD_SET_SENSOR_EVT_ENABLE 0x28 #define IPMI_CMD_GET_SENSOR_EVT_ENABLE 0x29 #define IPMI_CMD_REARM_SENSOR_EVTS 0x2a @@ -1581,6 +1582,28 @@ static void set_sel_time(IPMIBmcSim *ibs, ibs->sel.time_offset = now.tv_sec - ((long) val); } +static void platform_event_msg(IPMIBmcSim *ibs, + uint8_t *cmd, unsigned int cmd_len, + RspBuffer *rsp) +{ + uint8_t event[16]; + + event[2] = 2; /* System event record */ + event[7] = cmd[2]; /* Generator ID */ + event[8] = 0; + event[9] = cmd[3]; /* EvMRev */ + event[10] = cmd[4]; /* Sensor type */ + event[11] = cmd[5]; /* Sensor number */ + event[12] = cmd[6]; /* Event dir / Event type */ + event[13] = cmd[7]; /* Event data 1 */ + event[14] = cmd[8]; /* Event data 2 */ + event[15] = cmd[9]; /* Event data 3 */ + + if (sel_add_event(ibs, event)) { + rsp_buffer_set_error(rsp, IPMI_CC_OUT_OF_SPACE); + } +} + static void set_sensor_evt_enable(IPMIBmcSim *ibs, uint8_t *cmd, unsigned int cmd_len, RspBuffer *rsp) @@ -1757,6 +1780,7 @@ static const IPMINetfn chassis_netfn = { }; static const IPMICmdHandler sensor_event_cmds[] = { + [IPMI_CMD_PLATFORM_EVENT_MSG] = { platform_event_msg, 10 }, [IPMI_CMD_SET_SENSOR_EVT_ENABLE] = { set_sensor_evt_enable, 4 }, [IPMI_CMD_GET_SENSOR_EVT_ENABLE] = { get_sensor_evt_enable, 3 }, [IPMI_CMD_REARM_SENSOR_EVTS] = { rearm_sensor_evts, 4 }, From patchwork Tue Jan 16 00:57:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124575 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp845223lje; Mon, 15 Jan 2018 17:04:28 -0800 (PST) X-Google-Smtp-Source: ACJfBovFKTtBT5pDSiZQi6XlKa7uabHs6Yokp4ulYBD5vuKgt4Xjgxfc+mow1mzHxvM5vAMCj75q X-Received: by 10.37.132.142 with SMTP id v14mr4200942ybk.25.1516064668116; Mon, 15 Jan 2018 17:04:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064668; cv=none; d=google.com; s=arc-20160816; b=qtNOT7gfypJy5yF8TJMqQzUZy9p8UVan277uOXMV20ljEzLUUgZ9e1DfBkSkz39GIu z+C8bMfp58xfiQ5DQYQ+mLD2sA1YusvnLMDXjJLWUXL55bEVUy5OgTeIDKMmlwjjv2Is kpntu22kxHy1eDYh97jcfZH7w2K9p50nKV4HdL1Jg6+iVwTea73I8SLULmmJmFxc5iqr ysRNo20gYsdxq2g0criVYfJ9uFJUPmaOC2NzwVSyKOmOi+bW6L5nn+8fI4c8uwLjsB7K SCvBOrWtvljyEp+llXxnkwtzGqQw9Du+qSctdsYXZi/37Mg1zaziUYyB/aCbRILGijOe FOYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=LU1UnDBlgDqdo3POn9u4mRX5++9AzN/b7apq1erDnOc=; b=ndywooamgOd517vOhAA7GNJlYZHYIDNlD+AUJ7gj3MXHhtDdJxoAMdP8FWkOzA2KIy 5NfQZHbPuLBiCKNwFA8NeVW/EUkiBX+ggUJlgELkze5n4JOLjtN9H1TN1yVhXVFv3ygG kSFbPar+A+EXGW9/BIxXZlPZEaHFrswDM1xz01QRCi8tKe/OUn/HMdfMGc48rJVkyhGH URBILKV7MbuJV8X787krRoDaoWFnsyBtmx8bKNkZ01x9GpU5MQP7pw5+MfkNqGBaN9S1 6UdM3v2Mx0RDb9XvPRvNTMUhuKK3SMvqjaJ0ChNTge9e+wcq5Ao60Knf4sZlgMLcupYb 1vlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=iIcsJREU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b85si214919ybg.376.2018.01.15.17.04.27 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:04:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=iIcsJREU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49784 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFfv-0003Pb-Kl for patch@linaro.org; Mon, 15 Jan 2018 20:04:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZu-0007s9-AE for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZs-0000lS-Bq for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:36511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZs-0000kr-7V for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:12 -0500 Received: by mail-ot0-x242.google.com with SMTP id w4so12197116otg.3 for ; Mon, 15 Jan 2018 16:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=LU1UnDBlgDqdo3POn9u4mRX5++9AzN/b7apq1erDnOc=; b=iIcsJREUNoTr2AKdMItSMM3N+G8vYWsUT6ClcK8QL8BOSpY8FPVbDiGj3Vgrr+neE9 MQamIVcexbsA1kYtVGYF7/Y6mnf/I7BuT46Aml4CEWLMhaMqslJmGZaAWeB9S4doNXUG YR4RTOVUefzSg/tfok/7lBgPz9/TtrnBK8FC+uzj7K7bE8+774WTcR2Jc5i/CcGXt8N8 pQHD4myy3DtJyFPF3/Rezozdf2RcrDmzlpDE6GBXzhXPd6sEH3Nh3GIaqgtqthm7x3S0 S+0S6AyBK+hYdQlZkKKpGuoIrPY3ooog10gwPMkyCjpNgDMce+5z7CZTOV371JyxC9OF mGtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=LU1UnDBlgDqdo3POn9u4mRX5++9AzN/b7apq1erDnOc=; b=olEHYzu40OnqqbZmf9dasZPYNSwAsYWGV9PGRFvxqs7XhCngWX653dwW9SoQyLBD1w ryfN2u8HZW+kFiOwIF5EuhnpKjH3q8c03xwQFddPY4NGjRbpKRxXEXoX6w8KKh5slQnF Bx+bBySKeztFjRlbLY/gdf2TDsQF6kN7xuVpi5Xe7PR8C/p6u3jr65OH4aZXU3wsLBCv Se/JDx43jrzvRTHzeUBeVHL+yQX7aVdH8BGhv+i2teL9dl49qDAjpiYV7FamU7+bz+9O KzcUPXDWIJbP1WFX/QGnxGEPQAYJuGlHid4aIkgWLMFrn+vgT1Qbnbuds4hZvZMtgPH4 7jbA== X-Gm-Message-State: AKwxyteXtiLJ3W7+Gz6QISqpev07Ymj8VJocmRoGAZFBnH+y7arCbNfO y3okUodmeQH2bdPsD95cZQ== X-Received: by 10.157.9.2 with SMTP id 2mr19813040otp.159.1516064291324; Mon, 15 Jan 2018 16:58:11 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id o83sm428512oif.56.2018.01.15.16.58.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:09 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id E12228F4; Mon, 15 Jan 2018 18:58:06 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id A1A5F30008E; Mon, 15 Jan 2018 18:58:04 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:57 -0600 Message-Id: <1516064279-14816-6-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::242 Subject: [Qemu-devel] [PATCH 5/7] ipmi: Fix macro issues X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the entire macros with assignments in case they are used in an expression. The macros were doing ((v) & 1) for a binary input, but that only works if v == 0 or if v & 1. Changed to !!(v) so they work for all values. Remove some unused macros. Reported in https://bugs.launchpad.net/bugs/1651167 An audit of these changes found no semantic changes; this is just cleanups for proper style and to avoid a compiler warning. Signed-off-by: Corey Minyard Reviewed-by: Eric Blake --- hw/ipmi/isa_ipmi_bt.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.7.4 diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index e098fd5..e946030 100644 --- a/hw/ipmi/isa_ipmi_bt.c +++ b/hw/ipmi/isa_ipmi_bt.c @@ -45,21 +45,21 @@ #define IPMI_BT_B2H_ATN_MASK (1 << IPMI_BT_B2H_ATN_BIT) #define IPMI_BT_GET_B2H_ATN(d) (((d) >> IPMI_BT_B2H_ATN_BIT) & 0x1) #define IPMI_BT_SET_B2H_ATN(d, v) ((d) = (((d) & ~IPMI_BT_B2H_ATN_MASK) | \ - (((v) & 1) << IPMI_BT_B2H_ATN_BIT))) + (!!(v) << IPMI_BT_B2H_ATN_BIT))) #define IPMI_BT_SMS_ATN_MASK (1 << IPMI_BT_SMS_ATN_BIT) #define IPMI_BT_GET_SMS_ATN(d) (((d) >> IPMI_BT_SMS_ATN_BIT) & 0x1) #define IPMI_BT_SET_SMS_ATN(d, v) ((d) = (((d) & ~IPMI_BT_SMS_ATN_MASK) | \ - (((v) & 1) << IPMI_BT_SMS_ATN_BIT))) + (!!(v) << IPMI_BT_SMS_ATN_BIT))) #define IPMI_BT_HBUSY_MASK (1 << IPMI_BT_HBUSY_BIT) #define IPMI_BT_GET_HBUSY(d) (((d) >> IPMI_BT_HBUSY_BIT) & 0x1) #define IPMI_BT_SET_HBUSY(d, v) ((d) = (((d) & ~IPMI_BT_HBUSY_MASK) | \ - (((v) & 1) << IPMI_BT_HBUSY_BIT))) + (!!(v) << IPMI_BT_HBUSY_BIT))) #define IPMI_BT_BBUSY_MASK (1 << IPMI_BT_BBUSY_BIT) #define IPMI_BT_SET_BBUSY(d, v) ((d) = (((d) & ~IPMI_BT_BBUSY_MASK) | \ - (((v) & 1) << IPMI_BT_BBUSY_BIT))) + (!!(v) << IPMI_BT_BBUSY_BIT))) /* Mask register */ @@ -69,12 +69,12 @@ #define IPMI_BT_B2H_IRQ_EN_MASK (1 << IPMI_BT_B2H_IRQ_EN_BIT) #define IPMI_BT_GET_B2H_IRQ_EN(d) (((d) >> IPMI_BT_B2H_IRQ_EN_BIT) & 0x1) #define IPMI_BT_SET_B2H_IRQ_EN(d, v) ((d) = (((d) & ~IPMI_BT_B2H_IRQ_EN_MASK) |\ - (((v) & 1) << IPMI_BT_B2H_IRQ_EN_BIT))) + (!!(v) << IPMI_BT_B2H_IRQ_EN_BIT))) #define IPMI_BT_B2H_IRQ_MASK (1 << IPMI_BT_B2H_IRQ_BIT) #define IPMI_BT_GET_B2H_IRQ(d) (((d) >> IPMI_BT_B2H_IRQ_BIT) & 0x1) #define IPMI_BT_SET_B2H_IRQ(d, v) ((d) = (((d) & ~IPMI_BT_B2H_IRQ_MASK) | \ - (((v) & 1) << IPMI_BT_B2H_IRQ_BIT))) + (!!(v) << IPMI_BT_B2H_IRQ_BIT))) typedef struct IPMIBT { IPMIBmc *bmc; From patchwork Tue Jan 16 00:57:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124577 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp845494lje; Mon, 15 Jan 2018 17:06:02 -0800 (PST) X-Google-Smtp-Source: ACJfBovogEOSfieKl/OA1JDceQNFTeB6zHatjLDhI633bYj0letRbjnU9ftIPLCo9AFA9f8B5OrM X-Received: by 10.37.28.9 with SMTP id c9mr32688998ybc.65.1516064762596; Mon, 15 Jan 2018 17:06:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064762; cv=none; d=google.com; s=arc-20160816; b=quQIPp3SEigzl4wj1R/hkIv7xngDq++9noroOetefKu5NR6XjpbM7a3sqhMMF+EneR bCih0jpUQxeX7RE2DSLzA3GapNnVpSg8cGTZoogpJDWtkPXKZ3uQX64if9q+VznTtCax 6lpUVuMyEMoMhgv2vKISTDLIBExh12DLSTnCqkHivh+yJAz/rcXcjIcJNbEzGwzewOZW WGayoRAVqeN7SlTJ2u4a2mfgL4MdhcKOXBZtzZJQwV7Cv01i6hbwnB/0q16YPhixiPiU qbexGljab4JV7QxCgdbMkPu5bEc8Qul98Eqyd44pNkgCUSQejSijYrRLrug5pO8J10Ud L5LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=JKGjFahE63i0CqDjQId6oqIjdMsHoVjf0b+bLb+wkdihaVX5tyXLIIk06U10370wA3 9FQDJosLLjO8wwR+pm+3qtcEvYrzIdo8hD+ncX4SqhUqm3A7505yllAzNo9dpmWA+mMr EJ4ZCnEZkHsmxI/cAev/vmSbWzwOTguZIZLle4YcPLoP6ikaPHSvoKewCzAoQA7FLkAe e7Kr4g01tWgHvk1HxkvT7ut91GvWVe3C6jE8F+Raku0MD5wWQAsrvcISxW3P9S3oOudp t0kbbxOT3uMWuOEIxfTKQ0RsPzEEMn8w07agsJXkt0CatHmpS0Nh4WyVjLA8vNmm34l9 nP6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ZAH4YVsk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id u185si196675ywc.486.2018.01.15.17.06.02 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:06:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ZAH4YVsk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFhR-0004gN-V6 for patch@linaro.org; Mon, 15 Jan 2018 20:06:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZv-0007sW-E2 for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZu-0000mg-Hz for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:15 -0500 Received: from mail-ot0-x244.google.com ([2607:f8b0:4003:c0f::244]:36513) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZu-0000mE-CP for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: by mail-ot0-x244.google.com with SMTP id w4so12197186otg.3 for ; Mon, 15 Jan 2018 16:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=ZAH4YVsk/Nj//7iNwJ4wP5UGjVYx9S3M/UlQy+hdKKoinZ3tx2193K6DoQhv5d7Yuq U+ThGo/B1S1SN6SXR1vOP/CevyPub0opzFH3BSeFrWm3xgBOISHr7nJMGpw7V60MQG0P 9CFs+KLyD7icj3wAaOo64eZ+ulQihFvsbT0Fk4DWKwBF2lKrKEeUF66P0CPCiR2lw83e kFq4WmX5WcgMblLBqawJYS1I9/cg/1Ktepkdu6TRzww/zUwrxZJWu29qjEyvBnxqlbTy KAECBIQ9q+bakbN6evIeOQUV3waFxu25yPDod4P8Capic62MdZR94RPs9Q6MnS9odXfd KpFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=0F2xaRV+PnCJvXVpI6Att709KDACjJNoF2TNpF2bBMQ=; b=PCsMd56ft3c63SAREDtiOKrWS1leoj5qusHLW83cxyonm4cTGsFTvla90kqA998Dc8 pUNVQ9ELRwEVjI1lM5oSSn0PLh22Vc4JI5/0naf8r9HFecp4/ZYLrfKhjo8XGFEa4Qxz 7ivgYWqCWoag4yOk2rHmBHAoK4D62TdUY+GHXD35bJTQ9/jdraOf0SaQjkLbdcZt3wfp bXiGITC2Ig/Z8vJaHqwvipIvfiTGYUdXehtz1xArnFtBYADaptG8h+Ejethrw5HG3VYt ozfUfTduGo/JhQTvLuhpguRw9YnXOiSTIQm8eUXNck0j7EYoF/RNlRm2df0pg2YNUMBF 6Rhw== X-Gm-Message-State: AKwxytcEGbE1eaQ4pu4I9xKl3j68toQ83u18GExr8EAmiUJSabcJlynw ClvyXPBH5Mq9taVYmerOaw== X-Received: by 10.157.44.101 with SMTP id f92mr16006924otb.205.1516064293594; Mon, 15 Jan 2018 16:58:13 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id j16sm483742oth.42.2018.01.15.16.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:12 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 6D43AB9B; Mon, 15 Jan 2018 18:58:07 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 309AC300968; Mon, 15 Jan 2018 18:58:04 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:58 -0600 Message-Id: <1516064279-14816-7-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::244 Subject: [Qemu-devel] [PATCH 6/7] ipmi: disable IRQ and ATN on an external disconnect X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Otherwise there's no way to clear them without an external command, and it could lock the OS in the VM if they were stuck. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index abab3bb..58ade79 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -424,6 +424,11 @@ static void chr_event(void *opaque, int event) return; } ibe->connected = false; + /* + * Don't hang the OS trying to handle the ATN bit, other end will + * resend on a reconnect. + */ + k->set_atn(s, 0, 0); if (ibe->waiting_rsp) { ibe->waiting_rsp = false; ibe->inbuf[1] = ibe->outbuf[1] | 0x04; From patchwork Tue Jan 16 00:57:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 124576 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp845258lje; Mon, 15 Jan 2018 17:04:41 -0800 (PST) X-Google-Smtp-Source: ACJfBotxDZvrJ7GLRCidrmbwnVJas2jAXvmqlpbJCzpmoOIWmY+5qmwFFylNw3eBX1kTkH69xBUr X-Received: by 10.37.217.144 with SMTP id q138mr30716784ybg.519.1516064681797; Mon, 15 Jan 2018 17:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516064681; cv=none; d=google.com; s=arc-20160816; b=wX/22UOILZ4OcZQN9vUKGFSvmWLLde9f8PumHErRjkFkOgjp3mDBlo6zKVW284Bu8A 3vlTT7d7zOo5JVIdE+28omzfn3dhagtYQjRJn4x/g9qKQoHyhcOuNVWaKyTK6abju3JC HALXD3cJkB83UYLIVtil/YpYr7wL4e6k80mDgPZqWJyLPLZm7BakqAh/dVU+3xeVR9iR bsaXefxawLumIoWjSOuiRGTgsPtGd8SfUrr4wxzwUBril9KdfQHOnS+srd4iCWkwvtq1 dm0rCnKotMp342kvwWv8/t0wmLNj+ujJOiSbLWcVQ00CNJmwPtddyFQjY33/eta1K3LX UYAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=hk71D2cKmjGEt9+hv0BtowJB2yGT305RFq6k2wxJ06U=; b=PtqyzQo+3TKU/nE7A8d3H7B/+8sqVtU7u+Hgx4NIqMy/GPeM/+zLU5ool7rKIAs5je 6vb81HpR8qaOgSUcNmKiKZkw+s2fvC5CrhC3ai9vU23cYWpSYrdUEIk6cK90iWTMTtCa bFp+WWb3KhdQGt0Gy7SoB0+SI7exu8HfpsuVPfNnRl4a/W7XZKrBdlsrz1xqRdSu7IDp 0dZyoQ//uJGBhjp6sKRfHX+czVN0J+eMOCrw5jLh/x6Yw+5RvKU1KUGqwNumCGeV7WSE 4vRvpcUet2oBMeP5sVpNwEVKUOencUqpoDtEiUKnyK+iLLIdxYHlh6r8Ih7c2z+LkjqO PX/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=HfmK2u1O; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id f6si225270ybk.807.2018.01.15.17.04.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 17:04:41 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=HfmK2u1O; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:49819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFg9-0003pj-7a for patch@linaro.org; Mon, 15 Jan 2018 20:04:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFZu-0007s7-9R for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFZs-0000lh-W3 for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:14 -0500 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:35505) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFZs-0000lY-Qx for qemu-devel@nongnu.org; Mon, 15 Jan 2018 19:58:12 -0500 Received: by mail-ot0-x242.google.com with SMTP id 53so12200695otj.2 for ; Mon, 15 Jan 2018 16:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hk71D2cKmjGEt9+hv0BtowJB2yGT305RFq6k2wxJ06U=; b=HfmK2u1OX7Od4FCuJAZgmKvZIj3nYBvz44397ErN7a36zlATqvPMyoBhVhLfKGAkZC AYwek0/RKaatG4luoOH6UrewXtdx0zT/VPK7n/mi1GCDBnQ8/0c4QngNheOaPwq3CA/H L+N8sNBtgtxA5SbmpaBzrdjIqIiF7hrxq7h4mE9y4bu7KU2ZC1CYrLD2on91o4Av8PkC hkIPLMsuDFwLjg9TBvz54pDo/+Y7WvnFez7L+9pdB7ywmkagBTqSSijLF2iLozyH7twk 1BslVJiTruTAt7anDM1xapNhU2c+cqzk2sDdQcQmCWDdKUQ6Cp3aM9FCt01YLsY0Uwg5 +m9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=hk71D2cKmjGEt9+hv0BtowJB2yGT305RFq6k2wxJ06U=; b=OnKj9mfd32mHRZxQetrrgSNaY6BvuDgy38bDNdmeaajGKltinhbk/UGsqodJIEuC7Q 0CYkItOR0/XhAzXzwjFfKCoBWdevTPNfJPQG7QqgrBdVassr9NBfeF4lzXaSYb2i3JsO +WAXCIwtfY4jLFT6tHo04YDbcPZ+5g3TZ9jPd7BYSjEc6UJhMWA7MBgnQJnwSpNk1Cyo 6Xti+4SIpgKgcJdnNC6UT7fj1Zn6EednMji3azWTPDVXPlGoF3IKGbiqhxbIFJHX5vXH pgzkdK3WzYL08zYshtrj0w5pvI/xn8xa6rtUCj3fT4RocoLstwetY+mTBTmXTN+bUEzr qOeQ== X-Gm-Message-State: AKwxytf1Bs5Fec7jnHJmaP35OOZVbA3hkn6dpz5wz54KZHt7fNmzdijb Mic75CED1W9gz1DDB8TEC58ecbQ= X-Received: by 10.157.8.21 with SMTP id 21mr9896230oty.42.1516064292036; Mon, 15 Jan 2018 16:58:12 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id q13sm480808ota.56.2018.01.15.16.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 16:58:09 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 6185097E; Mon, 15 Jan 2018 18:58:07 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 0E1823000A8; Mon, 15 Jan 2018 18:58:04 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 18:57:59 -0600 Message-Id: <1516064279-14816-8-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516064279-14816-1-git-send-email-minyard@acm.org> References: <1516064279-14816-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::242 Subject: [Qemu-devel] [PATCH 7/7] ipmi: Allow BMC device properties to be set X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Corey Minyard Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_sim.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) -- 2.7.4 diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index e84d710..9b509f8 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -214,8 +214,8 @@ struct IPMIBmcSim { uint8_t device_rev; uint8_t fwrev1; uint8_t fwrev2; - uint8_t mfg_id[3]; - uint8_t product_id[2]; + uint32_t mfg_id; + uint16_t product_id; uint8_t restart_cause; @@ -867,11 +867,11 @@ static void get_device_id(IPMIBmcSim *ibs, rsp_buffer_push(rsp, ibs->fwrev2); rsp_buffer_push(rsp, ibs->ipmi_version); rsp_buffer_push(rsp, 0x07); /* sensor, SDR, and SEL. */ - rsp_buffer_push(rsp, ibs->mfg_id[0]); - rsp_buffer_push(rsp, ibs->mfg_id[1]); - rsp_buffer_push(rsp, ibs->mfg_id[2]); - rsp_buffer_push(rsp, ibs->product_id[0]); - rsp_buffer_push(rsp, ibs->product_id[1]); + rsp_buffer_push(rsp, ibs->mfg_id & 0xff); + rsp_buffer_push(rsp, (ibs->mfg_id >> 8) & 0xff); + rsp_buffer_push(rsp, (ibs->mfg_id >> 16) & 0xff); + rsp_buffer_push(rsp, ibs->product_id & 0xff); + rsp_buffer_push(rsp, (ibs->product_id >> 8) & 0xff); } static void set_global_enables(IPMIBmcSim *ibs, uint8_t val) @@ -1997,6 +1997,13 @@ static Property ipmi_sim_properties[] = { DEFINE_PROP_UINT16("fruareasize", IPMIBmcSim, fru.areasize, 1024), DEFINE_PROP_STRING("frudatafile", IPMIBmcSim, fru.filename), DEFINE_PROP_STRING("sdrfile", IPMIBmcSim, sdr_filename), + DEFINE_PROP_UINT8("device_id", IPMIBmcSim, device_id, 0x20), + DEFINE_PROP_UINT8("ipmi_version", IPMIBmcSim, ipmi_version, 0x02), + DEFINE_PROP_UINT8("device_rev", IPMIBmcSim, device_rev, 0), + DEFINE_PROP_UINT8("fwrev1", IPMIBmcSim, fwrev1, 0), + DEFINE_PROP_UINT8("fwrev2", IPMIBmcSim, fwrev2, 0), + DEFINE_PROP_UINT32("mfg_id", IPMIBmcSim, mfg_id, 0), + DEFINE_PROP_UINT16("product_id", IPMIBmcSim, product_id, 0), DEFINE_PROP_END_OF_LIST(), };