From patchwork Tue Jan 16 09:38:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 124647 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp950334lje; Tue, 16 Jan 2018 01:32:15 -0800 (PST) X-Google-Smtp-Source: ACJfBosx6n5s7IUkG7TUYWJgrImGmuAOL3ugGc3pYbHAzGn2HKuILWycw0xIIeMXs4fqmJ0yJoc2 X-Received: by 10.159.218.4 with SMTP id v4mr14493359plp.252.1516095135817; Tue, 16 Jan 2018 01:32:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516095135; cv=none; d=google.com; s=arc-20160816; b=FMUtNq1PMf4B5ptuxxR45zERjGNRisv90CPB+D4DadoHgJxndtoI8lcnwetVddH9pA ZF+qF+4Y8dVc4dt9t0+xSX1ejai9VZBgwv8HAIiFXKnIBudamnqHqpIhOwHcSpV+uaTT GUBBXEIGpwIEJj7WZo2Vxr8izbMnd7dPnhzCM6nEAmcg4QUVqzui8Ohp13aszOrfXOHY AtTrkN2IFNtSNn4OvriRZ0dD0YjfP8j2cufwbtyXOAMIanxO9Ksnktw1shTB6xRzsKU2 pq0zoeNaAj64fLGlatoLlSjRDozN6Txk30mHMgUaLmB3XjD2IJg+PUch35ldJiKcZbeZ YUsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=3+KxmVW/xi0NGls8p50tFW1iPdFVY99/R19NJxEXvoc=; b=MxM5rHluI9BCvQN6Q+bDAWNgBUsQM3TkeWRNM8x0d7XFNUEMS4CcHAz/6co8dWwLNK vxza16wtlaGA+NNbIlXz3K+ZeM/x56gC9bwYdceUSEavwGEuGLUfzzc88DMkdTG0MxEQ NhoZtDRLl6R4WVDCQS/qgGpKcnCkSrNlrEpJVJu0bvLbhMZ/urCveSMJquEY6dpdQUSI fdMJqSFaHdR2Z6l53CzhgUntim42/1omZ4hKQuTCv+mIiZlGJjFPx+MGViOJA5W596Zm zZK4mGrbM0etd+a9+ICvckbrlVLa5ByxW3SsylGnPex+6i0XQfl2N4X8vU+cIIizvhit 7lwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p184si1465680pfp.296.2018.01.16.01.32.15; Tue, 16 Jan 2018 01:32:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbeAPJcN (ORCPT + 28 others); Tue, 16 Jan 2018 04:32:13 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:32987 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750846AbeAPJcL (ORCPT ); Tue, 16 Jan 2018 04:32:11 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E733EAB627B81; Tue, 16 Jan 2018 17:32:07 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.361.1; Tue, 16 Jan 2018 17:32:00 +0800 From: Xiongfeng Wang To: CC: , , , Subject: [PATCH V2] auxdisplay: use correct string length Date: Tue, 16 Jan 2018 17:38:10 +0800 Message-ID: <1516095490-83827-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/auxdisplay/panel.c: In function 'panel_attach': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 12 equals destination size [-Wstringop-truncation] We need one less byte or call strlcpy() to make it a nul-terminated string. Signed-off-by: Xiongfeng Wang --- drivers/auxdisplay/panel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.8.3.1 diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c index ea7869c..d288900 100644 --- a/drivers/auxdisplay/panel.c +++ b/drivers/auxdisplay/panel.c @@ -1506,10 +1506,10 @@ static struct logical_input *panel_bind_key(const char *name, const char *press, key->rise_time = 1; key->fall_time = 1; - strncpy(key->u.kbd.press_str, press, sizeof(key->u.kbd.press_str)); - strncpy(key->u.kbd.repeat_str, repeat, sizeof(key->u.kbd.repeat_str)); + strncpy(key->u.kbd.press_str, press, sizeof(key->u.kbd.press_str) - 1); + strncpy(key->u.kbd.repeat_str, repeat, sizeof(key->u.kbd.repeat_str) - 1); strncpy(key->u.kbd.release_str, release, - sizeof(key->u.kbd.release_str)); + sizeof(key->u.kbd.release_str) - 1); list_add(&key->list, &logical_inputs); return key; }