From patchwork Tue Jan 16 16:29:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 124740 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp1070561lje; Tue, 16 Jan 2018 08:30:01 -0800 (PST) X-Google-Smtp-Source: ACJfBotCxZ4bfdBrVPd8AMaMS6LRVEYkkCovfNv+5fulaeKNY8LM0ltEDj+b1cSUFOVc5WnwQXuB X-Received: by 10.99.175.66 with SMTP id s2mr30725424pgo.168.1516120201100; Tue, 16 Jan 2018 08:30:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516120201; cv=none; d=google.com; s=arc-20160816; b=VcacS5lhfJqnS6vneOA0U4j8sLZm6z4WDzOlqOnjEcIIcox6ijvRBGyLoav8rW96C/ 70ih/pxCorNWfPqFf+1YdsXQ+Vkm0CPcuzs99dQc2q9j3c0ff/HTinnWQ6MaQRNXse1K Q/U0tlKNWzluwZhhc4wq4YVpUCarv3MNL0aut+Dx6V2OIOLGDn5jkzLI482Xrvmha7gE Gdg6V7bsBkgReYlh4Z3eCkckhw2FlHF7BrO1I0GM5NzUew1YHWSKWpt2EDZFsNjT6qlN ngrgB3EFfB8R5/yFhPrIDbadD3xWxWATzb1KBeC2XNY2BGJaSErgJYJ4+3DcuzRGBlhu jZBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=DVhZUGPLp3d7z60M074KpyI/hALvTweaGIaeYmc+/A4=; b=zMpmNKjnnpkOXBdKOadWYRiH1tHdrXiHTtkLEDxxMif10mxjpmmFbAwLcOjG2u00C6 wVhFec7J1ZZ8CBhM7AHi946aIRA/jS8h5xPoh1cxygjY+di0KgOjLCzKY4ut8eO3q9IZ zahk/KTtQRTO1w5U8da9xYpTzmAOjA54ss5T+B2CkE9AVE42p8R0+oZKCyhNCablnLft XoU7HgWmGIMOMoFJbEtdeVF5dKKbY6z47rvQos8NrSSizDFsx0TyTCAlI+Jb1G5BbxZY DAJXY+PjabI4OxeaAn9EMOxg9dbFSX6XWBeI0P1ebHhGxexZQoV41Kwy+nyEXZ/1bMM7 6SXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=y/7RJXwn; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16si2148430pfk.394.2018.01.16.08.30.00; Tue, 16 Jan 2018 08:30:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=y/7RJXwn; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbeAPQ37 (ORCPT + 6 others); Tue, 16 Jan 2018 11:29:59 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:37612 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbeAPQ36 (ORCPT ); Tue, 16 Jan 2018 11:29:58 -0500 Received: by mail-wr0-f193.google.com with SMTP id f11so5359796wre.4 for ; Tue, 16 Jan 2018 08:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=T2InMLGG31ldfwQyzVgYdbXGT8HTj70DeBHqUu3oSKQ=; b=y/7RJXwnopR7bPnbkxn2TLHApRSGf9eHRTJDGDInaaXkfA+4FbM0qeSohw/t7j348t OIE8PIPp73bO3rC9AOQBxD+emBqXo0KgyhlbYbSoN54JyIQWHYADNod0R8nCvn1C/u+y LEb8rKDsAV09zLvtMzQDLVNlgXh+um8nS5kw+n9L7irLo+iOfXVW9gHr+Ld8XV9Bsdkh oAz67+1oDFB0Qzgiuf9CamfLEsBZ+E3/E51pTl+7aCRmGBF44MtWn7/vk1ZtVNRgYnGi 9FSoMT16gMZ1NuAabfxCu5dvXtHS/94BN3VxathLQla+YAJ2FpwehlIRR7NZfKTMQfhe NjdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=T2InMLGG31ldfwQyzVgYdbXGT8HTj70DeBHqUu3oSKQ=; b=mnu4NpqzpZhgETfunkxbwCvvRcns0vTNKTbUe2mP0N4hwSv8mrc5OeK5aSfz8UIzUp Bg0UMdbxaX7x1i8pdzTIPUNOx7nwLzYuyuTPIlQT6rbPmtxpZ/6+yk+6VYCTMyElohWO f2gCaWaRS/7p5fQhmlpB6R5GyXpBTbtSi5zYMGCM3IRsEMVGFE0zpeqTmh7RGE+oeNKE O2/Lj2GSqthhOifOQRLe924PyrbBPSTUUdoXaPz+N27UYtUy4Z19yltj0ORN79IZkuVS VPzZOFBgxM0E34cvJZUD2zHOpqBQ4HmOq+kEVEBaQOF05mm4XmlEW5RUBaGWuSVdV9xT sDZQ== X-Gm-Message-State: AKwxyteQuf14WCT6vrPxPytnEFOWE1wqsY7aDShcnE88/JhlNKWOaUog SQuZXkUdE9xLoqxIoCs+jYVHYA== X-Received: by 10.223.160.120 with SMTP id l53mr19431913wrl.59.1516120197647; Tue, 16 Jan 2018 08:29:57 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i21sm2877714wmd.21.2018.01.16.08.29.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 08:29:57 -0800 (PST) From: Jerome Brunet To: Linus Walleij Cc: Jerome Brunet , Carlo Caione , Kevin Hilman , linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: meson: axg: fix gpio_ao bank stop pin Date: Tue, 16 Jan 2018 17:29:54 +0100 Message-Id: <20180116162954.4945-1-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org GPIO bank mistakenly stops at GPIOAO_9 while it should stop at GPIOAO_13. This gives -EINVAL if one tries to set/get anything on GPIOAO_10 to GPIOAO_13 (pull, direction, value) Correcting the bank last pin fixes this problem Fixes: e072b0f1b03a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC") Signed-off-by: Jerome Brunet --- Hi Linus, This changes fixes code which was added during this cycle, so it intended for your "for-next" branch, not the "fixes" one. Thanks Jerome drivers/pinctrl/meson/pinctrl-meson-axg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c index a1a7d42afd42..6431d77a4704 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c @@ -897,8 +897,8 @@ static struct meson_bank meson_axg_periphs_banks[] = { }; static struct meson_bank meson_axg_aobus_banks[] = { - /* name first last irq pullen pull dir out in */ - BANK("AO", GPIOAO_0, GPIOAO_9, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), + /* name first last irq pullen pull dir out in */ + BANK("AO", GPIOAO_0, GPIOAO_13, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), }; static struct meson_pmx_bank meson_axg_periphs_pmx_banks[] = {