From patchwork Fri Nov 27 19:57:58 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334269
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 63E56C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:30:47 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 146BC20809
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:30:47 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="nbyG5HWv"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730366AbgK1C3y (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:29:54 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56544 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1730990AbgK0T6i (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:58:38 -0500
Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com
 [IPv6:2a00:1450:4864:20::142])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C22CC0617A7
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:38 -0800 (PST)
Received: by mail-lf1-x142.google.com with SMTP id d8so8583486lfa.1
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Mlrk2a7fx8lHdZe7HNocdybelF9nJ2xwpzGpya7/neM=;
 b=nbyG5HWv8PYaV2MYSK/V9y026abFr5qp19r6Mx+qPclojBrt+pbh0WG2/n1piQOA3P
 uiimF504mugGaPERuOR019mjir/88EOl6cR5iCAfGJTPcIV/2G+i+ESDivkT2zpess2j
 1zVJKOceqHS6J/oZQFCYH6/3zFxVW9iPqVljmIiQSu3iKYWtG1vTsRSoW9MjLNOTxidQ
 wncSiavaru70qkQme1ffLM4DzwQTHZpSpnNLSekMRwjhEuJKCVX9e8Hjqh4OpS5gIN1G
 yUBhSTjZ85t0S4j2PKLTjbd7Dk/oAsAN77B0d4QfWUSLXQslevnjmXOg7FipUasZZZj+
 Ub+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=Mlrk2a7fx8lHdZe7HNocdybelF9nJ2xwpzGpya7/neM=;
 b=KS01arImDUwZyPvIvzSkUhvwa2SCW3ilgi3l83tx2Mao25cOEhYgC1IVGHOKnMCfFd
 8LHnT80UPPNk4lBCSiTh16IGhs8JMeYwMqHJIqDz3RqpCGQ3pH+qrotugPWfblqqCU0i
 Z8pZHx0MImJnDugVvgsQjIheusuYgjYxzI1owDbg8LANE+DSIpxXBdOCJ6G/TkY5plEG
 uuigAWIwkqmw39y+6kYSQUmv+BrVHicPgyHYq3ThI6h9dWtmzOcSDyjvj1qObvsG+xu/
 ILR1AQzhz/TXX80i1jzNwMXN00ututFq25Kdiee6Y76VKWh6YmFPr5Yvp8qrmLAk3O8N
 AlFA==
X-Gm-Message-State: AOAM530GSCzwNkIaBrn98AsC05pxKA2kXadppCOIguD8B8Gxt0liE5qc
 tGwrUEDvTim/9BPzJKn746ZF6m7f0se2ao55
X-Google-Smtp-Source: ABdhPJy1IKpFfgA/xgo2/hiiEZA4+34JhNpEV0cwiEJVzRGd+sjjU7oUZDTPsmHJEcur9GoPNNk63w==
X-Received: by 2002:a19:f243:: with SMTP id d3mr3981629lfk.534.1606507116602; 
 Fri, 27 Nov 2020 11:58:36 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:36 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 01/28] video: Fix W=1 warnings in of_videomode +
 of_display_timing
Date: Fri, 27 Nov 2020 20:57:58 +0100
Message-Id: <20201127195825.858960-2-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix trivial W=1 warnings.
Update kernel-doc to avoid the warnings.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/of_display_timing.c | 1 +
 drivers/video/of_videomode.c      | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index abc9ada798ee..f93b6abbe258 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -52,6 +52,7 @@ static int parse_timing_property(const struct device_node *np, const char *name,
 /**
  * of_parse_display_timing - parse display_timing entry from device_node
  * @np: device_node with the properties
+ * @dt: display_timing that contains the result. I may be partially written in case of errors
  **/
 static int of_parse_display_timing(const struct device_node *np,
 		struct display_timing *dt)
diff --git a/drivers/video/of_videomode.c b/drivers/video/of_videomode.c
index 67aff2421c29..a5bb02f02b44 100644
--- a/drivers/video/of_videomode.c
+++ b/drivers/video/of_videomode.c
@@ -13,10 +13,10 @@
 #include <video/videomode.h>
 
 /**
- * of_get_videomode - get the videomode #<index> from devicetree
- * @np - devicenode with the display_timings
- * @vm - set to return value
- * @index - index into list of display_timings
+ * of_get_videomode: get the videomode #<index> from devicetree
+ * @np: devicenode with the display_timings
+ * @vm: set to return value
+ * @index: index into list of display_timings
  *	    (Set this to OF_USE_NATIVE_MODE to use whatever mode is
  *	     specified as native mode in the DT.)
  *

From patchwork Fri Nov 27 19:57:59 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334282
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 8C68AC3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:01:05 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 44F3F21534
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:01:05 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="OwYLqsrQ"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1731143AbgK0T73 (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 14:59:29 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56552 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1730903AbgK0T6o (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:58:44 -0500
Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com
 [IPv6:2a00:1450:4864:20::143])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA5AAC061A04
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:40 -0800 (PST)
Received: by mail-lf1-x143.google.com with SMTP id s27so8558693lfp.5
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=da1A3vPp/gSfs8uQBFTqVywhFC5di/xPXEUcczCTk0g=;
 b=OwYLqsrQMpPVt+ChWeSPEvd1NbyN39kT9QgmMexvDbvKZzxVnAwlLyDVRQXb+G1rnL
 /ucb0C5ndckRbVUSYtwh/nUcnPVHej9oHsdAPqX7HZBrS2o4yFZuL8gqW0iO7Rnw+RGp
 BOdTXa9LoGy6KWFz+70GzDU88IzQGWHSzET0qaVaW8FqEE2uSANZi68YS6jMU77KEcEZ
 /dbrJTXqWAlYs8e0rRuNKw3lPCje5DbyzN/R0S/3n9oBVPW9QjmM4QGmCPp6c94I3ocJ
 nYbkmEAT7umptMLc2DtxqEh5D6JYGKqa3zu+D2BqmuhD7qMvaUefYUU4ZZQq58ZmRfKi
 MSBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=da1A3vPp/gSfs8uQBFTqVywhFC5di/xPXEUcczCTk0g=;
 b=QUbN2Xh2ZD6uQhLmigg6zRDV5zi3yC9MBMFLqAOoNWvGkw+jd1q7kjmpTB9E9uHgFl
 8SgAIW/jhxjGFRBkdAtIrrhEcwwiolNtev4/s3beFg6XvisKesIjbmuw75fzZUbaMxJM
 tGiHa3zCDvoYL6utFjQRQgjlGm7TXboF55Gzs44ZN2umNoUvI10HNiY0AJmK+ATd0AW4
 6fH8yKxqUqkpsM5CR8ENDMfv67OG9krDUdASFju/RkPHZSFQc7f2qXXj0U2+BAeYrBSG
 YdP7iD6ByyIXak0v6HB5WhFy5wUnUegVPqrgnILaPj1TzXopW4MaLn1aQPxYW17ky4gG
 nOvg==
X-Gm-Message-State: AOAM533DFWIpCAz9u3qNCbunJ/MCYbthGeYLqXwEDBmfpdbVNMarL2Ni
 wwX/Cw0s/pb56o4zdj8SetuM8YInWd+Zv99u
X-Google-Smtp-Source: ABdhPJxeusx1caPeHdHB09plu8ypFBaVCpeZX2OYdt+vTNBu3WWgW/FB/EuDCLXCO8WH0av2bFYc7A==
X-Received: by 2002:a05:6512:15e:: with SMTP id
 m30mr3937440lfo.213.1606507119250; 
 Fri, 27 Nov 2020 11:58:39 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:38 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 02/28] video: fbcon: Use pr_debug() in fbcon
Date: Fri, 27 Nov 2020 20:57:59 +0100
Message-Id: <20201127195825.858960-3-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Replacing DPRINTK() statements with pr_debug fixes
W=1 warnings.
And moves to a more standard logging setup at the same time.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Peilin Ye <yepeilin.cs@gmail.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: George Kennedy <george.kennedy@oracle.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Cc: Peter Rosin <peda@axentia.se>
---
 drivers/video/fbdev/core/fbcon.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index bf61598bf1c3..2edf90f638f3 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -56,8 +56,6 @@
  *  more details.
  */
 
-#undef FBCONDEBUG
-
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/fs.h>
@@ -82,12 +80,6 @@
 
 #include "fbcon.h"
 
-#ifdef FBCONDEBUG
-#  define DPRINTK(fmt, args...) printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
-#else
-#  define DPRINTK(fmt, args...)
-#endif
-
 /*
  * FIXME: Locking
  *
@@ -1015,9 +1007,9 @@ static const char *fbcon_startup(void)
 	rows /= vc->vc_font.height;
 	vc_resize(vc, cols, rows);
 
-	DPRINTK("mode:   %s\n", info->fix.id);
-	DPRINTK("visual: %d\n", info->fix.visual);
-	DPRINTK("res:    %dx%d-%d\n", info->var.xres,
+	pr_debug("mode:   %s\n", info->fix.id);
+	pr_debug("visual: %d\n", info->fix.visual);
+	pr_debug("res:    %dx%d-%d\n", info->var.xres,
 		info->var.yres,
 		info->var.bits_per_pixel);
 
@@ -2013,7 +2005,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width,
 	    y_diff < 0 || y_diff > virt_fh) {
 		const struct fb_videomode *mode;
 
-		DPRINTK("attempting resize %ix%i\n", var.xres, var.yres);
+		pr_debug("attempting resize %ix%i\n", var.xres, var.yres);
 		mode = fb_find_best_mode(&var, &info->modelist);
 		if (mode == NULL)
 			return -EINVAL;
@@ -2023,7 +2015,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width,
 		if (virt_w > var.xres/virt_fw || virt_h > var.yres/virt_fh)
 			return -EINVAL;
 
-		DPRINTK("resize now %ix%i\n", var.xres, var.yres);
+		pr_debug("resize now %ix%i\n", var.xres, var.yres);
 		if (con_is_visible(vc)) {
 			var.activate = FB_ACTIVATE_NOW |
 				FB_ACTIVATE_FORCE;
@@ -3299,7 +3291,7 @@ static void fbcon_exit(void)
 
 		if (info->queue.func)
 			pending = cancel_work_sync(&info->queue);
-		DPRINTK("fbcon: %s pending work\n", (pending ? "canceled" :
+		pr_debug("fbcon: %s pending work\n", (pending ? "canceled" :
 			"no"));
 
 		for (j = first_fb_vc; j <= last_fb_vc; j++) {

From patchwork Fri Nov 27 19:58:00 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334556
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 7123DC3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:29:50 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 2E18120809
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:29:50 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="pNd5jXk9"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730858AbgK1C3Z (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:29:25 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56562 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1729672AbgK0T6o (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:58:44 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A79FC0613D4
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:43 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id z1so7129307ljn.4
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=EVfT86QX+ZDTrJRF8dQQHF/3gUwiFpKsxjnoB2Y1zu0=;
 b=pNd5jXk94PdmMLkBuGrzXr5VZIBW1q4/xg/xvm8uzlWcYxvNlIoog29ix8O5eeFt69
 tDiNvMPfY65I0w27OPdUQpExtBaF1oC03M6/njKb87rLyTOAqe9X3s8YvSpmrZK7GSTy
 pN4AHHdFO0/+yVCNc/xawLRkTrtjdIfnFkQKwAta5zkNKDrkhdcd4UgR+yOOKyZ5rRQA
 zNaj3P+Aa3W4vi6QSkptOCD7yJDl/nzgZnCOd3103/rTMcaYvblNF42qdxGTSZIWGwTl
 KO5iUJB3JAh/gbw1Hco1syS42CJWlYzO4rvzedDiIdjlxoHecchXXRIF+i1fVfLvQTXk
 lrfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=EVfT86QX+ZDTrJRF8dQQHF/3gUwiFpKsxjnoB2Y1zu0=;
 b=Ggqx2Wo0fZbXgKDjBhQaxTBKX7hOwJazgoltuYzZx387Q83irQ1wtB5M3BpE8h9QTP
 1eC14g+fL1CNofE6TcIF5K/5oqaSHChSZzbumKF3H8BPokjnBAc/7XjhXDEHvgTlGZMF
 zpxLfEU6kZdqbBARCL0WqTnTsLUiHemdwkWt/Trm9391AaVvvV+IQCexK5vOKNv7QcY6
 Jflhj/dlnZY90khkFDcviNYuMyLFiq473kd+eriusXceAPTaMBZFVRt1nAWozG1kceFS
 5px0ivwLttj7AzUnbJCxuBhVL4uByETeuYqRFAYiAsniL4BiCjWMQY6kBGqTsFzFGnz3
 HfEQ==
X-Gm-Message-State: AOAM530+hoC1Aj5WtgpkUrW3BbLIQLVSx/3NKpy58HdmBJnhL+1zU7wJ
 Olf6TeUrHmm8C23KXx5bPkekyeGAqV4xgy2A
X-Google-Smtp-Source: ABdhPJzXp9uTUQQnInL9K0DV22npUNTpOloTCcvJ9aj3htoMz9+JJ2m34eR+Chve2GRiCw8Q4sNScw==
X-Received: by 2002:a2e:b529:: with SMTP id z9mr4499212ljm.307.1606507121906; 
 Fri, 27 Nov 2020 11:58:41 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:41 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 03/28] video: fbdev: core: Fix W=1 warnings in fbmon +
 fb_notify
Date: Fri, 27 Nov 2020 20:58:00 +0100
Message-Id: <20201127195825.858960-4-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings by updating kernel-doc to follow the correct syntax.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Alexander A. Klimov" <grandmaster@al2klimov.de>
---
 drivers/video/fbdev/core/fb_notify.c | 3 ++-
 drivers/video/fbdev/core/fbmon.c     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/core/fb_notify.c b/drivers/video/fbdev/core/fb_notify.c
index 74c2da528884..d85717b6e14a 100644
--- a/drivers/video/fbdev/core/fb_notify.c
+++ b/drivers/video/fbdev/core/fb_notify.c
@@ -38,7 +38,8 @@ EXPORT_SYMBOL(fb_unregister_client);
 
 /**
  * fb_notifier_call_chain - notify clients of fb_events
- *
+ * @val: value passed to callback
+ * @v: pointer passed to callback
  */
 int fb_notifier_call_chain(unsigned long val, void *v)
 {
diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index 1bf82dbc9e3c..b0e690f41025 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c
@@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block,
  * fb_create_modedb - create video mode database
  * @edid: EDID data
  * @dbsize: database size
+ * @specs: monitor specifications, may be NULL
  *
  * RETURNS: struct fb_videomode, @dbsize contains length of database
  *
@@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres)
  *                                    2 * M
  *        M = 300;
  *        C = 30;
-
  */
 static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres)
 {

From patchwork Fri Nov 27 19:58:01 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334270
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 31880C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:30:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id EE82221D46
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:30:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="jQJJ5C2S"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729672AbgK1C3i (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:29:38 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731052AbgK0T66 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:58:58 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A05CC0617A7
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:46 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id j205so8556555lfj.6
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=elXwDkZqCWbwars/a4PGxe80QnxYqSvOiXbjb845R9M=;
 b=jQJJ5C2S7D8szVUR25mbQT5RmCZpktF7FWL3p0OS57iRBuna6+UiSzqrn5Pv3gOO5A
 2oILbhokAeBdbYfI3Zw+b1ya+RZ8KfyrTKG2dlmHl14lPej6x8/ZHQAEmXnhZDd9XI2b
 mjTFmyM/x5arLTXOpOJPImA/G99hdnc3fEderAiqRBNil5gdBOfzZ1UFUglTGLe8pBKV
 E7IUwNmbMUh0hVJWdqbomvCxozev0ljukOfKl2EdMhenNN7hnv83Pj/c3/qHSE2cATIu
 UuJbfK+LNozQUhL3a7jVRGNqgDpXbw8QBT6qEagMw51lQHDQMkERakZHJNbCWEO8moOi
 /Eng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=elXwDkZqCWbwars/a4PGxe80QnxYqSvOiXbjb845R9M=;
 b=QCI5hL6kzuMfCut25O3edDEQRjAnDg9No+dQVSVm1NqXv3a25GrKGE9PchqhDzXy0H
 17IGe3409DZkOmP9S85D1U2x7+Bdm2Et+0h+c7FO0K9Z/hWcF9SB2JErQKQUeQ92htYb
 sWx/3l1CzFq3wOkUwVuCIhaojvjv2SgfmpC/1M6OvDRGTW2F+wg/A/DsJ1c5P9b4SMhf
 CAsBNCz6WfHof4XkOIFsArRZswpJlvCQKWQ+428ytqLODuMRfm528lJokOpye9BJ1fz1
 xybSQjQ7H4LpZEZ+2rHo/dW0AhrTeHv+5kv/GLpxCoDcVAeij73sItiQ8FDDTLmvHv55
 b/SQ==
X-Gm-Message-State: AOAM533dtq1GXKkqp0abOS7neih+IXBk0cHsCtv2926zLEui5CKgS2Y1
 QP98ZQnng+eck6UUbFpfRDkm4zZ8TztOq7sE
X-Google-Smtp-Source: ABdhPJyEvODl2X9feO2V1e8aOwadRfjN8fIygmoqxMNyeCNcXtYuBfiDpc2mv8qb3JKasYlmoB391A==
X-Received: by 2002:ac2:4559:: with SMTP id j25mr2183950lfm.511.1606507124592; 
 Fri, 27 Nov 2020 11:58:44 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:44 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 04/28] video: fbdev: aty: Delete unused variable in
 radeon_monitor
Date: Fri, 27 Nov 2020 20:58:01 +0100
Message-Id: <20201127195825.858960-5-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 about variable that is asssigned a value but never used.
The variable was indeed never used so delete it.

Keep the call to radeon_probe_i2c_connector() as it may have
side-effects. It is unlikely but I could not verify that is was safe to
drop the call.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/aty/radeon_monitor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c
index 9966c58aa26c..df55e23b7a5a 100644
--- a/drivers/video/fbdev/aty/radeon_monitor.c
+++ b/drivers/video/fbdev/aty/radeon_monitor.c
@@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo,
 #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C)
 		{
 			u8 *EDIDs[4] = { NULL, NULL, NULL, NULL };
-			int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE};
 			int i;
 
 			for (i = 0; i < 4; i++)
-				mon_types[i] = radeon_probe_i2c_connector(rinfo,
-									  i+1, &EDIDs[i]);
+				radeon_probe_i2c_connector(rinfo, i + 1, &EDIDs[i]);
 		}
 #endif /* DEBUG */
 		/*

From patchwork Fri Nov 27 19:58:02 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334555
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,
 URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no
 version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 11EFDC63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:30:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id C76F222210
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:30:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="rtFG8lhg"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730624AbgK1C3Q (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:29:16 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56562 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731056AbgK0T66 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:58:58 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3946C0613D4
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:48 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id d20so8514001lfe.11
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=n7AUSPOHxh+ROspnXmAGmt29lw2/92P6Xx7q8Q73sVQ=;
 b=rtFG8lhgrSILnbwb3Lrt+6OpeHbZNZZZ0Hk1Pq3EWdYR4I2S5LnrPrBzUfYZdnhLbD
 NvK9RUJ9xGorG4tNxoKdBJ82XL2i8RQ04daPP5LdoFpZ5lZhxqs6KOh1eSj0w9JDaEWs
 kxhsYH47ImmndKEPH6OoKLEcPH0Ei1WHeekziKNNKCbiBTWrB4dPDNM659FywgbWkLjL
 syfH61UpKOOV4ilWc+dl+pdPB9hiUwUvphw+JRZZbGoS1fet27fx8K5LZezyUNZWqGpH
 oKkfek3UuGGeZo3m4GxX3ZegpL4xG8XJIvJLoC53LI2iYHIw0aLB76MnGLTcyklWZdf6
 Ig2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=n7AUSPOHxh+ROspnXmAGmt29lw2/92P6Xx7q8Q73sVQ=;
 b=saBBhJjyf6UY5g5+mArpD0EJUQP7dcwJhRo7eqE3QTRG3BNWYHbAFKQu3ir1+6WyaY
 8hpddTunqOrZEoaZ9rvIzYbvi2HhZqG3K6ftapGe9LYmCpV8slZgSW/rcXYUFdrB+doO
 ch/ZKP+xIY56L+NWlnXKovRqW+BoVaYZCn7BqtqoyX1e6J6NDNXe7sukexNYah0CbwB7
 wpg9JdW5kOGamWctgI0NIPzLwjeDQWiD3F+IC5A9BTnuHwtLIl7MJ0hq+omAC0pz8GgO
 zhC9oVH1GZwaCI3GCufxyfVw25oqpw5t4chQzq3drv9rpm6hI5cppLEO0+HjUmzpylQm
 7Odg==
X-Gm-Message-State: AOAM5307c0MQqQDXp5/7A4w5Am0YnWEdhGH5ES9X4qt/vTFlcmnX3GBn
 0+NPUD9HLjlaJ1vJLI0VlaIhpkFSkUrosao0
X-Google-Smtp-Source: ABdhPJwT6Vp8ufL83Vnm7rhaXWMBXozvqUMkmLlmRs0l1JHZOollRcQVcjhC7wW8zOiKw6exXOpPFA==
X-Received: by 2002:a05:6512:358d:: with SMTP id
 m13mr4193587lfr.435.1606507127242; 
 Fri, 27 Nov 2020 11:58:47 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:46 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 05/28] video: fbdev: aty: Fix W=1 warnings in atyfb_base
Date: Fri, 27 Nov 2020 20:58:02 +0100
Message-Id: <20201127195825.858960-6-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings about variables assigned but never used.

- Drop variables that was never used
- Avoid using a local variable by moving the expression to an if
  condition

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Joe Perches <joe@perches.com>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Jason Yan <yanaijie@huawei.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Jani Nikula <jani.nikula@intel.com>
---
 drivers/video/fbdev/aty/atyfb_base.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index c8feff0ee8da..d1eb9218debb 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -2360,22 +2360,20 @@ static int aty_init(struct fb_info *info)
 #ifdef CONFIG_FB_ATY_GX
 	if (!M64_HAS(INTEGRATED)) {
 		u32 stat0;
-		u8 dac_type, dac_subtype, clk_type;
+		u8 dac_subtype, clk_type;
 		stat0 = aty_ld_le32(CNFG_STAT0, par);
 		par->bus_type = (stat0 >> 0) & 0x07;
 		par->ram_type = (stat0 >> 3) & 0x07;
 		ramname = aty_gx_ram[par->ram_type];
 		/* FIXME: clockchip/RAMDAC probing? */
-		dac_type = (aty_ld_le32(DAC_CNTL, par) >> 16) & 0x07;
+		aty_ld_le32(DAC_CNTL, par);
 #ifdef CONFIG_ATARI
 		clk_type = CLK_ATI18818_1;
-		dac_type = (stat0 >> 9) & 0x07;
-		if (dac_type == 0x07)
+		if (((stat0 >> 9) & 0x07) == 0x07)
 			dac_subtype = DAC_ATT20C408;
 		else
 			dac_subtype = (aty_ld_8(SCRATCH_REG1 + 1, par) & 0xF0) | dac_type;
 #else
-		dac_type = DAC_IBMRGB514;
 		dac_subtype = DAC_IBMRGB514;
 		clk_type = CLK_IBMRGB514;
 #endif
@@ -3062,7 +3060,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
 	if (dp == of_console_device) {
 		struct fb_var_screeninfo *var = &default_var;
 		unsigned int N, P, Q, M, T, R;
-		u32 v_total, h_total;
 		struct crtc crtc;
 		u8 pll_regs[16];
 		u8 clock_cntl;
@@ -3078,9 +3075,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
 		crtc.gen_cntl = aty_ld_le32(CRTC_GEN_CNTL, par);
 		aty_crtc_to_var(&crtc, var);
 
-		h_total = var->xres + var->right_margin + var->hsync_len + var->left_margin;
-		v_total = var->yres + var->lower_margin + var->vsync_len + var->upper_margin;
-
 		/*
 		 * Read the PLL to figure actual Refresh Rate.
 		 */

From patchwork Fri Nov 27 19:58:03 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334563
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 8A333C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:27:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 486222224C
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:27:37 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="Ko3vuo/C"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730018AbgK0UAz (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 15:00:55 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56582 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731059AbgK0T7C (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:02 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B5DCC061A48
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:51 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id t22so7142893ljk.0
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=/znDw06zFdh3Au85v8bQXn1l/SWiG3rqtYog18OgpP0=;
 b=Ko3vuo/CkINDtMby612nix2mMnEfnh1/yge7yOuFBmqaxTz4vqSVCRZfsDRQ2icjG9
 DMW/AY92frRlDN8st+P+UB8p1cOq7yx4/1vy67JClUGRQSi0Z42QttbRMIO8XAL7DLEj
 YeAc0Bijvcd2cna3RONHjpYkdRyZb+7xbxZMYcPD1628/DfTeaMwmDicQUkMQ9yzI3Q1
 VB5asklArK8o3s+R8dNYIVJko1jnksafX1OI2PSXgp1pXNgdw5bEt+q7ac25VhjnEYA9
 iEcWUDrH9cUe4lSCTfkfLYD000OMDCJ5rpPHF8lRZf1ihE85tIdvhLZE7h31TeCPQrhg
 0E3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=/znDw06zFdh3Au85v8bQXn1l/SWiG3rqtYog18OgpP0=;
 b=nrIZ96N/6RJ3+YMWxVgJtL5DkIWNPESORgtp2SmCh1h6xdveIfk8WXXcrso+v2seP4
 mAUH6yGIiGOQbTXuFSs9oiS6V4mA+ufVqeugRXVdUUaqXJ/xiN+lQjgh/KrPCAVuFMFJ
 Z6eedPpD911ORuwrR8TlCfxcrbXycHmUqZkDUOVw3LYorExVrKI+KPgxzc8BLZ4C+RR0
 JrZmUw8FtriQ2jeOWlN4IzRcmvhP4owtzYjBP+d4YCcxe5ZEQe75AJEVYnoRLaEZ867+
 FEd71XbROmAW1YbYB8Z3XZI2KVFqyVMP7QlJ69EnFzZqAo9nsrpSR2obLLHjccYMpL9y
 yM3Q==
X-Gm-Message-State: AOAM533egdR/9rYV15dW+fIMV2lTIlh26uoNVXTulLtrcsTTlR9NROhk
 D5KcZ0qVTZbqwKmUJD4pDtDPZQFW+eyqKPOA
X-Google-Smtp-Source: ABdhPJxJJrsSyrEycBj6HJRNco5cA49HBb6Xw5g+OEZnzHuIEFNhlHoXUIBL26kqzIT6LvYFOGW9zQ==
X-Received: by 2002:a2e:9118:: with SMTP id m24mr439285ljg.363.1606507129848; 
 Fri, 27 Nov 2020 11:58:49 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:49 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 06/28] video: fbdev: aty: Fix W=1 warnings in mach64_ct
Date: Fri, 27 Nov 2020 20:58:03 +0100
Message-Id: <20201127195825.858960-7-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 about variables assigned but never used.
- One variable is only used when CONFIG_FB_ATY_GENERIC_LCD is defined
  Fix so variable is only defined with CONFIG_FB_ATY_GENERIC_LCD
- Several variables was only assigned by a call to aty_ld_le32().
  Drop the variables but keep the call to aty_ld_le32() as it may
  have unexpected side-effects.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/video/fbdev/aty/mach64_ct.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/aty/mach64_ct.c b/drivers/video/fbdev/aty/mach64_ct.c
index f87cc81f4fa2..011b07e44e0d 100644
--- a/drivers/video/fbdev/aty/mach64_ct.c
+++ b/drivers/video/fbdev/aty/mach64_ct.c
@@ -281,10 +281,13 @@ static u32 aty_pll_to_var_ct(const struct fb_info *info, const union aty_pll *pl
 void aty_set_pll_ct(const struct fb_info *info, const union aty_pll *pll)
 {
 	struct atyfb_par *par = (struct atyfb_par *) info->par;
-	u32 crtc_gen_cntl, lcd_gen_cntrl;
+	u32 crtc_gen_cntl;
 	u8 tmp, tmp2;
 
-	lcd_gen_cntrl = 0;
+#ifdef CONFIG_FB_ATY_GENERIC_LCD
+	u32 lcd_gen_cntrl = 0;
+#endif
+
 #ifdef DEBUG
 	printk("atyfb(%s): about to program:\n"
 		"pll_ext_cntl=0x%02x pll_gen_cntl=0x%02x pll_vclk_cntl=0x%02x\n",
@@ -402,7 +405,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 	struct atyfb_par *par = (struct atyfb_par *) info->par;
 	u8 mpost_div, xpost_div, sclk_post_div_real;
 	u32 q, memcntl, trp;
-	u32 dsp_config, dsp_on_off, vga_dsp_config, vga_dsp_on_off;
+	u32 dsp_config;
 #ifdef DEBUG
 	int pllmclk, pllsclk;
 #endif
@@ -488,9 +491,9 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 
 	/* Allow BIOS to override */
 	dsp_config = aty_ld_le32(DSP_CONFIG, par);
-	dsp_on_off = aty_ld_le32(DSP_ON_OFF, par);
-	vga_dsp_config = aty_ld_le32(VGA_DSP_CONFIG, par);
-	vga_dsp_on_off = aty_ld_le32(VGA_DSP_ON_OFF, par);
+	aty_ld_le32(DSP_ON_OFF, par);
+	aty_ld_le32(VGA_DSP_CONFIG, par);
+	aty_ld_le32(VGA_DSP_ON_OFF, par);
 
 	if (dsp_config)
 		pll->ct.dsp_loop_latency = (dsp_config & DSP_LOOP_LATENCY) >> 16;

From patchwork Fri Nov 27 19:58:04 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334275
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 378DEC63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:16 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id EF08F22245
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:15 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="LoQV/HRo"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729708AbgK1BgY (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:36:24 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56594 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731069AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31767C061A49
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:54 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id o24so7122012ljj.6
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=hlmg0QXcyBXkSQsSrsHccJseYumWnCfsbqf3yovwsZQ=;
 b=LoQV/HRoqkupk060ExH+xj6uc2BOYCLe+/fhhXr+djyJrScexTnQiICqX2SijJ5CUX
 sx5Ye76d3HMLlLvA7Kf1y7OzeABMF+DUkMOcrgoS28hcPIaCWKe7M40Eeq/FXGxh82+n
 pHihwnrBdOe8HURp8U9Xy1lh6JW2MeWSw9XBOSAy190vGHjdAuYb0pw7WR6hoxKLdFCj
 O42Rf9Cq4OpSxJejPEixC4sl0teW/2CrwQor6MQUWalB2M5js/5w0L6rPgPz/qLgL04O
 iK9jeSH9y4e9ZE1JFRAQB5Qr5nFOSxiGwLmV9h6wxY5714YuWeAd3KS8GSyO+db1Ud9c
 aCKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=hlmg0QXcyBXkSQsSrsHccJseYumWnCfsbqf3yovwsZQ=;
 b=XTUx58uxLea0TekE5NGLxT6kTOziaMOMm/X8Rl04nhkiHagkKFAslLv91QGywg84gv
 hExZdch+/Vniw3JlwFmHZsOQL6LLgPJY1N87rYyy2K43lYh0BJOGtbRu0/dqgnWgxXfC
 SHbmNjbGKGVqqiKEWcwHcrg72YQq2zf/eMsIDB5KsrnYblpl8aGOrCIwLTN/KLB2Tqw4
 UiD/1hdkALlZUDv5g9AEtkoamCiSV3CCS/lfxIXGeGaDhp9769QKSTwifXyIW9gPPYoh
 /r8LvPHmueUTVCHWI+BXPt0GNyYlhzeTGsgjlX0doVqpWvS9kDCMalX6lDMSl7A/Kxq6
 O72A==
X-Gm-Message-State: AOAM531Dra3BcmdvIxtQ1vtp7wo+TEgfHG1bEjONErMPigKBlzXebF78
 n1Fum5D9B3sQsY/rD9X3aXhl5YIkRgr8VuVw
X-Google-Smtp-Source: ABdhPJzRLomTEf1vvIm/1TdbxkZYDb34ZllLyKUDbE4zhUrgFXPDrbjJCxhX1h0uR2r7RcekIwtaLg==
X-Received: by 2002:a2e:9cd4:: with SMTP id g20mr4110075ljj.174.1606507132537; 
 Fri, 27 Nov 2020 11:58:52 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:52 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 07/28] video: fbdev: sis: Fix W=1 warnings about static
 symbols
Date: Fri, 27 Nov 2020 20:58:04 +0100
Message-Id: <20201127195825.858960-8-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

init.h define static symbols, so should only be included
once. Drop the include from sis.h as it is not needed.
This fixes a lot of warnings seen with a W=1 build.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
---
 drivers/video/fbdev/sis/sis.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/sis.h
index 9f4c3093ccb3..d632f096083b 100644
--- a/drivers/video/fbdev/sis/sis.h
+++ b/drivers/video/fbdev/sis/sis.h
@@ -15,7 +15,6 @@
 
 #include "vgatypes.h"
 #include "vstruct.h"
-#include "init.h"
 
 #define VER_MAJOR		1
 #define VER_MINOR		8

From patchwork Fri Nov 27 19:58:05 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334273
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 13564C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:10 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id C225B20809
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:09 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="P+RaYsbO"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729422AbgK1BgG (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:36:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56602 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731071AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E525DC061A4F
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:56 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id o24so7122222ljj.6
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=3DqPrwDONktOgwN/CoiXWyViY/Qg5UYX+rJPHgpGJjk=;
 b=P+RaYsbOnx2acYAr3uSsgohDNBxSOaEg2p+n2du3Hw9r2lHgqBPN6uoIYzal4dnKPO
 n/72hIZvM5k86IY6eUYZovHeKZjX8JZedbxZF+MsFbRByjtZiO31SwXk1TPL3UVit0j0
 XwTFPFIRGyVaDUSN1Fb3dA2p4y873sq2IrEEXCE2XKc/d9nhLphkUfWi/jAEkPSt377I
 COlmuA9oHxtWkMNQ/Gk8lG3Vt98mr+BIAzo1LdBSNDc75umBhEMDphDOH3C71v2RCwEJ
 xfKSnfq/CwSw3GT8qMAzvJ6qxcGCwergB6dRle+04X1r1S0U/UrOaOelkmujE7c5c+AM
 Vdlg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=3DqPrwDONktOgwN/CoiXWyViY/Qg5UYX+rJPHgpGJjk=;
 b=aQwuFZTxC1UUZNrIXsZZ41qsRVetF9CMeXhRQqOxvVJWHlfWzu9V8R+J3LzQr0hcgV
 uPR/ZOJ47H3sXn8YaMRyEca21Mity78PIdavSdydcQXQX29W18Kghc5skT5/GxhykGUV
 12qxCVf5PaQpX359DgVGx57eadAhJAsHRQ/zT0b2YzTCyez+DQfWL6tq/sCQJqJehG5/
 OZDKk3MpOCUW5OIR9FsGQZVtCGgeMaw+SdgfthW2obqH9Rcjagb8ShAcHlRP9P3ycD6b
 gEVgToepMqjv3mQPCU9GrnxRs54qM5u7K0S3lVXAi6h574ORjHcyRTM7Fusf6SAK1fg7
 Jeow==
X-Gm-Message-State: AOAM533jetp1M32ybjqLhwafndgYAxHZhB3lqdKdOedOZNprIab8Lw3m
 VteSOZWi3L+zkSFGBWCqNY9FSSI2yAdb3opV
X-Google-Smtp-Source: ABdhPJzuQ2Prv1GUopct6yqHR86fQNHT0/F1E6ioU4/Kz0f0Fap2yxzWa6Upc/90vmj8G3YzFJJBsg==
X-Received: by 2002:a2e:164b:: with SMTP id 11mr2781307ljw.34.1606507135224; 
 Fri, 27 Nov 2020 11:58:55 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:54 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 08/28] video: fbdev: sis: Fix W=1 warning about SiS_TVDelay
Date: Fri, 27 Nov 2020 20:58:05 +0100
Message-Id: <20201127195825.858960-9-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warning by commenting unused SiS_TVDelay* variables.

The SiS_TVDelay* variables seem to contain some magic numbers
so looks like data worth keeping around but not as code we build.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
---
 drivers/video/fbdev/sis/oem310.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h
index 8fce56e4482c..ed28755715ce 100644
--- a/drivers/video/fbdev/sis/oem310.h
+++ b/drivers/video/fbdev/sis/oem310.h
@@ -200,6 +200,7 @@ static const unsigned char SiS310_TVDelayCompensation_651302LV[] =	/* M650, 651,
 	0x33,0x33
 };
 
+#if 0 /* Not used */
 static const unsigned char SiS_TVDelay661_301[] =			/* 661, 301 */
 {
 	0x44,0x44,
@@ -219,6 +220,7 @@ static const unsigned char SiS_TVDelay661_301B[] =			/* 661, 301B et al */
 	0x44,0x44,
 	0x44,0x44
 };
+#endif
 
 static const unsigned char SiS310_TVDelayCompensation_LVDS[] =		/* LVDS */
 {

From patchwork Fri Nov 27 19:58:06 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334272
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 1A52FC3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id D2A8220809
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:36 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="DuI8PFRu"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1728995AbgK1C2T (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:28:19 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56608 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731037AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE16C061A04
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:59 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id s27so8559701lfp.5
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:58:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=UH09h1yaTBjOi1rndtqeEtocB9Ydxx+E8RryiPhl80I=;
 b=DuI8PFRuFcBEsab+erd77IHuvnY8X2uavYqsppgZq2LhEVglNoLcdL2BBbegGr/ffA
 jqV6CGbool+G7prxO3WrStTbRpUgua91b8UoI3yTSErWryrT1eoP5cy9djZbHSmMpwA3
 Il1crCMOXNVjF0avCjJ0dY0mqZGOR2XnLRuNLKlAiuknGJuSScTo4aEW/I6coBAiPsk9
 032Rl39gk2bLbb1zLfjE1hPfun2hzuUFZj7ko8/KuZ7DF1TYVxCJXBM31PkFilNyTWH1
 ICqt/hxIKKB2Hvf2rcb63Y8scqnddxVFCSoFlfPV9hkU1vmGRXYzb6GXvtmvqaFjyH8w
 jMEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=UH09h1yaTBjOi1rndtqeEtocB9Ydxx+E8RryiPhl80I=;
 b=mshMvtAaB568sszdIQgAmECY1qj1JxJTNWruVDf0tgG+rCStioE9Xg+cOELLVn8uq/
 m9+U3AUre2blH9QFLNcB3hmR5zyNxDje8o0pNNJhXYpZuIYMw+EepHK5zaTvdeadS9nk
 706K5DV2Z/nLfweFAwCV9odgBvUYrpSh5pao+gX38T0ci+nU+QMW7rDkBQdDHooQ2fRM
 P/CQANdrFXkUGAbF2abtkrfQ0T2d2q8QvZBd+UZ/p4vGIwZAa3zTjI31r7IRhKf5WLZk
 rxJaU3IIi+YVS8M/MBe0aZlX54eTkLMzvQX8e1ix1VGWzjfUvsN0ETYwg5v5qrtaDYqZ
 ZpIQ==
X-Gm-Message-State: AOAM532/nFLaMJdn0NCq1PJHlmv4jMg1uDAiyso00nvB/vA6EHa3l1DD
 uFIfjkcFnBp7HCeAn6jMK+jTpto/ZAYJ59sh
X-Google-Smtp-Source: ABdhPJxv8ewp8sQd6Y48H9pROFlcKOQZd2NriGhQnvxkdr/vjO74fh63W/MTIpiiLYtQco3gQo3/7A==
X-Received: by 2002:a19:c1c4:: with SMTP id
 r187mr4910882lff.518.1606507137770; 
 Fri, 27 Nov 2020 11:58:57 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:57 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 09/28] video: fbdev: sis: Fix W=1 warnings in init.c
Date: Fri, 27 Nov 2020 20:58:06 +0100
Message-Id: <20201127195825.858960-10-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix several W=1 warnings.
This removes a lot of unused code - which is always a good thing to do.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
---
 drivers/video/fbdev/sis/init.c | 34 ++++++----------------------------
 1 file changed, 6 insertions(+), 28 deletions(-)

diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
index fde27feae5d0..b77ea1a8825a 100644
--- a/drivers/video/fbdev/sis/init.c
+++ b/drivers/video/fbdev/sis/init.c
@@ -2648,7 +2648,7 @@ static void
 SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
 		unsigned short ModeIdIndex, unsigned short RRTI)
 {
-   unsigned short data, infoflag = 0, modeflag, resindex;
+   unsigned short data, infoflag = 0, modeflag;
 #ifdef CONFIG_FB_SIS_315
    unsigned char  *ROMAddr  = SiS_Pr->VirtualRomBase;
    unsigned short data2, data3;
@@ -2659,7 +2659,7 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
    if(SiS_Pr->UseCustomMode) {
       infoflag = SiS_Pr->CInfoFlag;
    } else {
-      resindex = SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
+      SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
       if(ModeNo > 0x13) {
 	 infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag;
       }
@@ -3538,17 +3538,13 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
 			struct fb_var_screeninfo *var, bool writeres
 )
 {
-   unsigned short HRE, HBE, HRS, HBS, HDE, HT;
-   unsigned short VRE, VBE, VRS, VBS, VDE, VT;
-   unsigned char  sr_data, cr_data, cr_data2;
-   int            A, B, C, D, E, F, temp;
+   unsigned short HRE, HBE, HRS, HDE;
+   unsigned short VRE, VBE, VRS, VDE;
+   unsigned char  sr_data, cr_data;
+   int            B, C, D, E, F, temp;
 
    sr_data = crdata[14];
 
-   /* Horizontal total */
-   HT =  crdata[0] | ((unsigned short)(sr_data & 0x03) << 8);
-   A = HT + 5;
-
    /* Horizontal display enable end */
    HDE = crdata[1] | ((unsigned short)(sr_data & 0x0C) << 6);
    E = HDE + 1;
@@ -3557,9 +3553,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
    HRS = crdata[4] | ((unsigned short)(sr_data & 0xC0) << 2);
    F = HRS - E - 3;
 
-   /* Horizontal blank start */
-   HBS = crdata[2] | ((unsigned short)(sr_data & 0x30) << 4);
-
    sr_data = crdata[15];
    cr_data = crdata[5];
 
@@ -3588,13 +3581,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
    sr_data = crdata[13];
    cr_data = crdata[7];
 
-   /* Vertical total */
-   VT  = crdata[6] |
-	 ((unsigned short)(cr_data & 0x01) << 8) |
-	 ((unsigned short)(cr_data & 0x20) << 4) |
-	 ((unsigned short)(sr_data & 0x01) << 10);
-   A = VT + 2;
-
    /* Vertical display enable end */
    VDE = crdata[10] |
 	 ((unsigned short)(cr_data & 0x02) << 7) |
@@ -3609,14 +3595,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
 	 ((unsigned short)(sr_data & 0x08) << 7);
    F = VRS + 1 - E;
 
-   cr_data2 = (crdata[16] & 0x01) << 5;
-
-   /* Vertical blank start */
-   VBS = crdata[11] |
-	 ((unsigned short)(cr_data  & 0x08) << 5) |
-	 ((unsigned short)(cr_data2 & 0x20) << 4) |
-	 ((unsigned short)(sr_data  & 0x04) << 8);
-
    /* Vertical blank end */
    VBE = crdata[12] | ((unsigned short)(sr_data & 0x10) << 4);
    temp = VBE - ((E - 1) & 511);

From patchwork Fri Nov 27 19:58:07 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334560
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,
 URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 049F4C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:41 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id B0EA822245
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:40 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="doK4lBFv"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730018AbgK1BhG (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:37:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56620 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731057AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23646C061A51
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:02 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id d20so8514756lfe.11
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=tAy2L6+yHjKuwgbD1GtBSbwZUtZR3+FgaFh+jK71xjw=;
 b=doK4lBFvnmTZcgYL/PjjUuQB8ZoUk+PEo0qU+uLpJMsr2En+IwyOb047noqpqiE4E7
 ns0ENbBkflLflMCTngF9seeipp8CMx1/WoAsTEf3iihARCetdENCniJzzfGCZplRbTtO
 UhusRpw2RGQLTMQ6zQuwpyeGjMzQz8ujlGRIKZJUiPT4+fRc8pQOWenhI6DaMxh3fTbM
 LPN+7GLLpoK+QEDfotRTyJ926oA0If7zdHpHKjTZXY3GKaDo3G8cfFpeRQQQmTQAZaZo
 OJUHeRPgDRH4JFWSYvBdCxT3x5oX5bfIRaMQJCUGx1Goh9AVJhbvcsTWq7YpDC6CW3iv
 b8gg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=tAy2L6+yHjKuwgbD1GtBSbwZUtZR3+FgaFh+jK71xjw=;
 b=JS2zxaR7K7Cnk6RfOSiRznqahf7JQRlErRQ5yPq71XIylT0DwP7Co1wKXAxuNq7tKl
 9lxCY3jP2Vb0qJqTUBhvEXhD1XKZ0xTrcFZ3xGnQRFQBNLxb80XSv2jO6LlFbj31lRa/
 RGkAsR8AnkStbKhmhD6x3F8B1rlQc1TbOkTgrQtfi/Nlf9C3izCf5rRHN691IBGKKOQ+
 ayPoi/OkR/rSC6y/QiPjql60rN3DgwyTgK1KMoNmmt3aMxsBaHOIvsJoIS6LRiNPl/kT
 pdhCB8fTraBGlVqmIW8jkCuhQwOcNsH5cUH75WjernD24CkXaGY4lZKERjxxl3leHb+p
 Kemg==
X-Gm-Message-State: AOAM53359jSbDTX0mZUn/FfCK23BcfmKm7b3jqjfccz2zvFTdFb6WzQW
 8OETCOLmw2DweeaeZN+KT1JBIBej3vN23Zuq
X-Google-Smtp-Source: ABdhPJzA9tlt5/v8JE6nDmhPGEGXRsyRJmv4B2nwWuL72K6hMPQ+4HMvJ4sQQ3zrl6l0SjVCnZ1fkg==
X-Received: by 2002:a19:ec07:: with SMTP id b7mr4326715lfa.114.1606507140403; 
 Fri, 27 Nov 2020 11:59:00 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.58.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:58:59 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 10/28] video: fbdev: sis: Fix W=1 warnings in sis_main
Date: Fri, 27 Nov 2020 20:58:07 +0100
Message-Id: <20201127195825.858960-11-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warning by dropping unused variable

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
---
 drivers/video/fbdev/sis/sis_main.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 03c736f6f3d0..266a5582f94d 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -5029,7 +5029,6 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb)
 	static const u8 cs168[8] = {
 		0x48, 0x78, 0x88, 0x00, 0x00, 0x00, 0x00, 0x00
 	};
-	u8 reg;
 	u8 v1;
 	u8 v2;
 	u8 v3;
@@ -5037,9 +5036,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb)
 	SiS_SetReg(SISCR, 0xb0, 0x80); /* DDR2 dual frequency mode */
 	SiS_SetReg(SISCR, 0x82, 0x77);
 	SiS_SetReg(SISCR, 0x86, 0x00);
-	reg = SiS_GetReg(SISCR, 0x86);
+	SiS_GetReg(SISCR, 0x86);
 	SiS_SetReg(SISCR, 0x86, 0x88);
-	reg = SiS_GetReg(SISCR, 0x86);
+	SiS_GetReg(SISCR, 0x86);
 	v1 = cs168[regb]; v2 = cs160[regb]; v3 = cs158[regb];
 	if (ivideo->haveXGIROM) {
 		v1 = bios[regb + 0x168];
@@ -5049,9 +5048,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb)
 	SiS_SetReg(SISCR, 0x86, v1);
 	SiS_SetReg(SISCR, 0x82, 0x77);
 	SiS_SetReg(SISCR, 0x85, 0x00);
-	reg = SiS_GetReg(SISCR, 0x85);
+	SiS_GetReg(SISCR, 0x85);
 	SiS_SetReg(SISCR, 0x85, 0x88);
-	reg = SiS_GetReg(SISCR, 0x85);
+	SiS_GetReg(SISCR, 0x85);
 	SiS_SetReg(SISCR, 0x85, v2);
 	SiS_SetReg(SISCR, 0x82, v3);
 	SiS_SetReg(SISCR, 0x98, 0x01);

From patchwork Fri Nov 27 19:58:08 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334558
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 672CEC3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:29 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 295E220809
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:29 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="nIf6uBH2"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1727988AbgK1C2K (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:28:10 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56628 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731072AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94601C061A52
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:04 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id q13so7865527lfr.10
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=2z/dAT9naUmXE5qac+rK/70T5U7GBI/v+WhPmjvxr84=;
 b=nIf6uBH2ZKJjbyqV2d6fX1XuIPpHe14PCos51II/MmmX9UsTUjGWVLOj+XDbj6IH1j
 j8/sL1YQxZwFnx2Y3tpYvSe+iP7Q+1wGxsJ+yD4vkWHzQmSKxGjWR4+X0/5cnSJ9+E+U
 WU8L7VOqbnPDUiBgbuP1o8nKteYr8nUlMfIakz/XVdAJ6l6kAnJH338CdZnjgiCZ5DUD
 XOUI/EVS71x2AdQ/J+ls/NiRVVOmAiRLBTmVDFdOl0GQV6p5dRPdWOhIZ08Guhys9T6U
 JyMe7MXSkIUSlmCj3gncIzFiqAnQGd5mTmpCJ4wtyjkSqo3ODvAKCw2IRPkz4yJEK8PJ
 fFdg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=2z/dAT9naUmXE5qac+rK/70T5U7GBI/v+WhPmjvxr84=;
 b=tX81BXp/tsq6d2ZL5KE2hbUZFIet1nMBw2GZFhvcDEQpdo4YgkRPZhohOdYOH/idmA
 xNs3mOVxqai0YoIVuS6P5cXW47jtZTVPAE3rE+6Kr65MfCcGzm2fwLLeqlJrVBOxJWOi
 boQvaZ0VCVzdjMkBIWCphnmWG2xUKmRXF+Bb5BijOJM7KAHDOkyq5n9pc8W6F0zFPQ0s
 wvcPaGkbeKPjfmBbcvv87njNRsUmhqa2S4Rmqr2QYODwd/gzLv1LBkQcmq66Dd7sP4xb
 jfX0DZN32OUNS61yI8GNitIa3UaUMb1BqYQVwNEf+dc7sVs+weaKF6YgS37/bPsk6pHo
 elRg==
X-Gm-Message-State: AOAM530VWAjAE+9l9Tqed+YYCdgJp66jjA6HAvgFNqMPnc64uEP5HRYW
 sE1AYSE8cixHnyPxjZn57ZZetVn+P7BRpL1U
X-Google-Smtp-Source: ABdhPJxMUz94BHFF6rybfliMhdsF+17CnCkrgs8rTH0atREiGZy+JMiTw0e9sauLh8NOkSqqUM0QRg==
X-Received: by 2002:a05:6512:6c6:: with SMTP id
 u6mr4036455lff.174.1606507142897; 
 Fri, 27 Nov 2020 11:59:02 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:02 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 11/28] video: fbdev: via: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:08 +0100
Message-Id: <20201127195825.858960-12-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings about unused assignment.
Fixed by dropping the assignment and deleting the local variable.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/via/lcd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c
index 4a869402d120..088b962076b5 100644
--- a/drivers/video/fbdev/via/lcd.c
+++ b/drivers/video/fbdev/via/lcd.c
@@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres,
 	u32 clock;
 	struct via_display_timing timing;
 	struct fb_var_screeninfo panel_var;
-	const struct fb_videomode *mode_crt_table, *panel_crt_table;
+	const struct fb_videomode *panel_crt_table;
 
 	DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n");
-	/* Get mode table */
-	mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60);
 	/* Get panel table Pointer */
 	panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60);
 	viafb_fill_var_timing_info(&panel_var, panel_crt_table);

From patchwork Fri Nov 27 19:58:09 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334557
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 723F2C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:56 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 370B920809
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:28:56 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="MPkJdyjn"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729330AbgK1C2h (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:28:37 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56634 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731077AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 303CBC061A53
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:07 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id 142so7094636ljj.10
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=UXPr2PFUFWtOrSiCc92D4zReH+aBrw7KABxE1MmXvi0=;
 b=MPkJdyjnuRSSFVuV23mC35hdVygag39YRqbpZT90vWELA3QzBsTFq5Yj9kSg+3cQNc
 ehjZjlOlpghvpSYf8mUACbykYk+t4mdLMypoZ3CkNsjJV5/cjbDoKpa/zgbdOZqcICmI
 WeobA167yuRyuQvK0HL0M5KbICRjhmxNrEAj+IDE+gAs8fkt16WXbP8/cB3y6BsxWn2a
 epRXQAtIusQjKM//TwjYCGvNTt1cW/Ar46c8TsUJrGKIRs0W9kLClsN2mpRr8GpoDOvU
 LHeTKRTPtcLetlVpF6WgFtVfLZX4kUksh0X7OdA83X1QAzzuq5DDKqBKdnLKhj/aCyrA
 +FTA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=UXPr2PFUFWtOrSiCc92D4zReH+aBrw7KABxE1MmXvi0=;
 b=CxeEwPsXmgbc6vCloyZCS1pZVobQpI5bsfVMpcDtP20Amifs2gDrktJUTLHnj1bLL/
 s/uXFuxeuQZXRxElew2k8RoZAoNs5Yqt2kgJgei/IIdXafrotmhcNwazpqsrvTuAR+6L
 7T8qWxL3g/t8sO1khY9v3tB8Jez9mlo3j2hURBmB3oTIHb9mjKa4eX+mbcGV3pj+ngnv
 ULvLnOu17btcndAapno2Q1bsq81brvgHfJJo2VcJUBTqmBbF2kDpameMs/rBg84ouVtl
 SyZlLKQg1ZLx+vkVo0YGP/osoEzIXMx8xq4WxIHZMz8a5g9hbdrte3BxPHDgTmQhHrwo
 4tBQ==
X-Gm-Message-State: AOAM533qHxvL0gAL9JWYhdQ+DykI6V80/D/XK/bWvmc+XbQCmpQNBWVQ
 rrMe9LrS49WVnDQWMwrAm+EcYkMH3ZCw+3uV
X-Google-Smtp-Source: ABdhPJzRp6Ac5f6uTM6zm36JYhmvj2mN3ZcYz0U/kr++s/q2VudV3yV5yPzJI8O3dXqZ1ktxoeYNYg==
X-Received: by 2002:a2e:9cd8:: with SMTP id g24mr4537919ljj.32.1606507145500; 
 Fri, 27 Nov 2020 11:59:05 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:05 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 12/28] video: fbdev: tdfx: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:09 +0100
Message-Id: <20201127195825.858960-13-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warning about unused assignment.
Fix by dropping the local variable.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/video/fbdev/tdfxfb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
index f056d80f6359..67e37a62b07c 100644
--- a/drivers/video/fbdev/tdfxfb.c
+++ b/drivers/video/fbdev/tdfxfb.c
@@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx)
 
 static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val)
 {
-	unsigned char tmp;
-
-	tmp = vga_inb(par, IS1_R);
+	vga_inb(par, IS1_R);
 	vga_outb(par, ATT_IW, idx);
 	vga_outb(par, ATT_IW, val);
 }

From patchwork Fri Nov 27 19:58:10 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334559
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id F05FCC3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:23:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id A63A021D46
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:23:14 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="vCNLiQfe"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729330AbgK1BhR (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:37:17 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731129AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com
 [IPv6:2a00:1450:4864:20::142])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BE76C061A54
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:10 -0800 (PST)
Received: by mail-lf1-x142.google.com with SMTP id s27so8560253lfp.5
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=DHnHNejv7AhApH+VUvGdbMBEjvsQK7oM4lZgYgyuVAY=;
 b=vCNLiQfeEvpoIJt7SkD1g+b4b3Ux90ZWyPNnAZRBnotTZmnTAUWU24s2YoBHrsdvZD
 HxCRM7514OVQW17o980p5GXoRkXivoEpKQ+Mbn1TsTqssE0/ETcE4LevBAFVQYCf3fxw
 8PDMHFg7CPWi6zn3b8FQAiFWakurLLmFHcHT4Iu5+Ly0rVqLJnOvvt63qr90NUTDZI0w
 3jU04Ie3q4YJyF+uyVwbgnBr45gi2ciRZhmOWquwHel6eJD8KH3teklR9iVM0UIH719O
 DtM7VwC1rO120zJbdy6NnmM65ymFjDpfT/hdbp9TLDP0uZAdNkfBZ/HoyN6o9Sq23tve
 w4cA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=DHnHNejv7AhApH+VUvGdbMBEjvsQK7oM4lZgYgyuVAY=;
 b=JN6ol0oc4zCUC9t3lZcvYxQ0KqzuyLFH9kEs+Q22eh5eI60ULudD0v21pB28gsWu1D
 gvAR966h5aUI+fLECOczMY0Twq04CfGjVnY5uNGwAwL2wlT+HYEco6at4Kd6D8WJUmPw
 fwADVfxqXFT16LhTui4JAdza5O5Iab/MWTx3ZCLyEHlDHK+AYwfvtymCo2gAJ+4/6beO
 UOfjbCCFsNXVOwY6uUDtJmCCh5App4+4GzJaNhKWRCFFB7eJUpk8v3YRc55okQraiwxJ
 OfpE6HxzWCO2h8VmHwRuv00B8T9ooY7XriBJB4LhPvBiebl12Rp9l/7eYzA0CSFHihh/
 USWg==
X-Gm-Message-State: AOAM5320dZfMbB8SqLCNqPaqevA2IQv0SSnrwf/EF6J9P/oATlxlda8l
 Vlp7a+uERO1oy89KlCUsUhUbLuHCi67XLWbY
X-Google-Smtp-Source: ABdhPJzmN19Ex+rToaLJQVEF+FVjbO2OJIoM/NZahowAyuob0kZlMAKXt1B+fW7Gczozaeltl7O2fA==
X-Received: by 2002:ac2:4acd:: with SMTP id m13mr4323957lfp.69.1606507148319; 
 Fri, 27 Nov 2020 11:59:08 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:07 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 13/28] video: fbdev: riva: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:10 +0100
Message-Id: <20201127195825.858960-14-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings:
- Fix kernel-doc
- Drop unused variables/code

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/riva/fbdev.c   |  9 ++++-----
 drivers/video/fbdev/riva/riva_hw.c | 28 ++++++++--------------------
 2 files changed, 12 insertions(+), 25 deletions(-)

diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index ce55b9d2e862..55554b0433cb 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c
@@ -464,7 +464,7 @@ static inline void reverse_order(u32 *l)
 
 /**
  * rivafb_load_cursor_image - load cursor image to hardware
- * @data: address to monochrome bitmap (1 = foreground color, 0 = background)
+ * @data8: address to monochrome bitmap (1 = foreground color, 0 = background)
  * @par:  pointer to private data
  * @w:    width of cursor image in pixels
  * @h:    height of cursor image in scanlines
@@ -843,9 +843,9 @@ static void riva_update_var(struct fb_var_screeninfo *var,
 /**
  * rivafb_do_maximize - 
  * @info: pointer to fb_info object containing info for current riva board
- * @var:
- * @nom:
- * @den:
+ * @var: standard kernel fb changeable data
+ * @nom: nom
+ * @den: den
  *
  * DESCRIPTION:
  * .
@@ -1214,7 +1214,6 @@ static int rivafb_set_par(struct fb_info *info)
 /**
  * rivafb_pan_display
  * @var: standard kernel fb changeable data
- * @con: TODO
  * @info: pointer to fb_info object containing info for current riva board
  *
  * DESCRIPTION:
diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c
index bcf9c4b4de31..8b829b720064 100644
--- a/drivers/video/fbdev/riva/riva_hw.c
+++ b/drivers/video/fbdev/riva/riva_hw.c
@@ -836,17 +836,17 @@ static void nv10CalcArbitration
     nv10_sim_state *arb
 )
 {
-    int data, pagemiss, cas,width, video_enable, bpp;
-    int nvclks, mclks, pclks, vpagemiss, crtpagemiss, vbs;
-    int nvclk_fill, us_extra;
+    int data, pagemiss, width, video_enable, bpp;
+    int nvclks, mclks, pclks, vpagemiss, crtpagemiss;
+    int nvclk_fill;
     int found, mclk_extra, mclk_loop, cbs, m1;
     int mclk_freq, pclk_freq, nvclk_freq, mp_enable;
-    int us_m, us_m_min, us_n, us_p, video_drain_rate, crtc_drain_rate;
-    int vus_m, vus_n, vus_p;
-    int vpm_us, us_video, vlwm, cpm_us, us_crt,clwm;
+    int us_m, us_m_min, us_n, us_p, crtc_drain_rate;
+    int vus_m;
+    int vpm_us, us_video, cpm_us, us_crt,clwm;
     int clwm_rnd_down;
-    int craw, m2us, us_pipe, us_pipe_min, vus_pipe, p1clk, p2;
-    int pclks_2_top_fifo, min_mclk_extra;
+    int m2us, us_pipe_min, p1clk, p2;
+    int min_mclk_extra;
     int us_min_mclk_extra;
 
     fifo->valid = 1;
@@ -854,16 +854,13 @@ static void nv10CalcArbitration
     mclk_freq = arb->mclk_khz;
     nvclk_freq = arb->nvclk_khz;
     pagemiss = arb->mem_page_miss;
-    cas = arb->mem_latency;
     width = arb->memory_width/64;
     video_enable = arb->enable_video;
     bpp = arb->pix_bpp;
     mp_enable = arb->enable_mp;
     clwm = 0;
-    vlwm = 1024;
 
     cbs = 512;
-    vbs = 512;
 
     pclks = 4; /* lwm detect. */
 
@@ -924,17 +921,11 @@ static void nv10CalcArbitration
       us_min_mclk_extra = min_mclk_extra *1000*1000 / mclk_freq;
       us_n = nvclks*1000*1000 / nvclk_freq;/* nvclk latency in us */
       us_p = pclks*1000*1000 / pclk_freq;/* nvclk latency in us */
-      us_pipe = us_m + us_n + us_p;
       us_pipe_min = us_m_min + us_n + us_p;
-      us_extra = 0;
 
       vus_m = mclk_loop *1000*1000 / mclk_freq; /* Mclk latency in us */
-      vus_n = (4)*1000*1000 / nvclk_freq;/* nvclk latency in us */
-      vus_p = 0*1000*1000 / pclk_freq;/* pclk latency in us */
-      vus_pipe = vus_m + vus_n + vus_p;
 
       if(video_enable) {
-        video_drain_rate = pclk_freq * 4; /* MB/s */
         crtc_drain_rate = pclk_freq * bpp/8; /* MB/s */
 
         vpagemiss = 1; /* self generating page miss */
@@ -993,7 +984,6 @@ static void nv10CalcArbitration
               else if(crtc_drain_rate * 100  >= nvclk_fill * 98) {
                   clwm = 1024;
                   cbs = 512;
-                  us_extra = (cbs * 1000 * 1000)/ (8*width)/mclk_freq ;
               }
           }
       }
@@ -1010,7 +1000,6 @@ static void nv10CalcArbitration
 
       m1 = clwm + cbs -  1024; /* Amount of overfill */
       m2us = us_pipe_min + us_min_mclk_extra;
-      pclks_2_top_fifo = (1024-clwm)/(8*width);
 
       /* pclk cycles to drain */
       p1clk = m2us * pclk_freq/(1000*1000); 
@@ -1038,7 +1027,6 @@ static void nv10CalcArbitration
               min_mclk_extra--;
         }
       }
-      craw = clwm;
 
       if(clwm < (1024-cbs+8)) clwm = 1024-cbs+8;
       data = (int)(clwm);

From patchwork Fri Nov 27 19:58:11 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334561
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 81535C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 34D00221EB
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="R58XIdGE"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1727149AbgK1BgJ (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:36:09 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56562 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731127AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D9C5C061A55
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:12 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id j10so7135799lja.5
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=dgiE3cPN0UhMAdrlJWfRmuc0aOS7JyS2T35N0ifDz8w=;
 b=R58XIdGE58Q9Aqsn5XSsimwgH605ifHUH233P5OBuNNPP/RYguS8aO5o3GlEgZt581
 spr/LRdVgVkbi1AhiYsfC98VaQ3JqvMaoBzBhZ4flEJST452YUwa9iU93QtLCCrczo3e
 5cj9BzzHIAPRW5R/tWshMPWP5b4aWah2WsZPbTharCUvcAoIo77TXv4iEblCxXgm+QNh
 m/vcUOofhBOYXTHjdheU9gMIhM37Sd67xTqxYEjjpfdxZvhz69VQQ4G9dwRMBBYSkS+g
 uIAzMJJ1kqWn6ChaKymZa7rRNHDvTBbTPWH88HuvvjZOqQku8AY2DvaN6D25/XODOKZR
 8SpQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=dgiE3cPN0UhMAdrlJWfRmuc0aOS7JyS2T35N0ifDz8w=;
 b=D/lf65md5xcstJXg/he9j3ttV/4TxDs0ZgpEarKnXyM6NjpR5/1avbaO/nZR0PcWrA
 ttgUbquOeum+r+dTuPFCsYRG9ZPxKfwFonEWJKYvgDKacqTrckJH/aFx72jfhnvhaZib
 w69EV2QInQ2Z7ZS6Cp6coRAxEMhtzoMnCTqNNFrqy5fu51QrzfPQnubgCJ2pD3jfJ3Yk
 4pybxP/tpu7oVj/Dhhg22mkRs50SzIlGYP7MK6ua2h0fuhlaiF+g+iXCzkBvDg8FXy/e
 eErpPjtY3gbLFuQmuaX2TkniwzbWQdQMt1yCGBNKukIf1HxHNhZ04vHxvKUXhUGi1enm
 hsfg==
X-Gm-Message-State: AOAM532C5R2tsY6q2ucddJYQiy5A4TpWhMAp7/8O6poCHWFAMmq5hxTF
 PS4TOBECEzTBwbIv8OOvDbaLrzjC2x5ShtFL
X-Google-Smtp-Source: ABdhPJx/A+ivNr8kMaMUsxMdcnxwLhpbFPdQSjML9Bzel1DEIBHBsJjnBMP5knP9/Ca+mACkvp9t9w==
X-Received: by 2002:a2e:95c7:: with SMTP id y7mr1233763ljh.115.1606507150978; 
 Fri, 27 Nov 2020 11:59:10 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:10 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 14/28] video: fbdev: pm2fb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:11 +0100
Message-Id: <20201127195825.858960-15-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fixed a few kernel-doc issues to fix the warnings.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Jani Nikula <jani.nikula@intel.com>
---
 drivers/video/fbdev/pm2fb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c
index 27893fa139b0..c68725eebee3 100644
--- a/drivers/video/fbdev/pm2fb.c
+++ b/drivers/video/fbdev/pm2fb.c
@@ -1508,8 +1508,8 @@ static const struct fb_ops pm2fb_ops = {
  *
  * Initialise and allocate resource for PCI device.
  *
- * @param	pdev	PCI device.
- * @param	id	PCI device ID.
+ * @pdev:	PCI device.
+ * @id:		PCI device ID.
  */
 static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
@@ -1715,7 +1715,7 @@ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
  *
  * Release all device resources.
  *
- * @param	pdev	PCI device to clean up.
+ * @pdev:	PCI device to clean up.
  */
 static void pm2fb_remove(struct pci_dev *pdev)
 {
@@ -1756,7 +1756,7 @@ MODULE_DEVICE_TABLE(pci, pm2fb_id_table);
 
 
 #ifndef MODULE
-/**
+/*
  * Parse user specified options.
  *
  * This is, comma-separated options following `video=pm2fb:'.

From patchwork Fri Nov 27 19:58:12 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334274
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id A5236C63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 6B61D22245
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:37:52 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="XrtZdKGu"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730166AbgK1Bh2 (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:37:28 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56676 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731114AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com
 [IPv6:2a00:1450:4864:20::244])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7947EC061A56
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:15 -0800 (PST)
Received: by mail-lj1-x244.google.com with SMTP id 142so7095055ljj.10
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=bZVUjqZPvk9JmE5Zg9zhFjt8GTdbfi/4bsMjlewJUWk=;
 b=XrtZdKGu5/hNrxeMcY7JQje+7wV52fu30Ck/RUr5wsZpyQJcANFJZ39N0KWddETdEX
 fOPkmhKTz1DW+fwvSOBvpDKgWwNZ91XoVSfOPIDK33hQY0hcdC9JHsjlQdYjok5aakxe
 1lDcFQ05uuljUZIeMgpbYUPatcYhMAqNE6jakOSRD6eCrf/VCMhQPcWqVxtIQEk6WaS7
 /EuO9akDGzU266dv9OuffMUYSiox7QhVCEhyN3qTkL+CAKWNhEeQKfxGHd6uqH2Hz+EP
 T4PIJQr2oREk9yV+SGzpgGoKrWxRkM5vR9tVIniIgYrgPTHJ8/gR4vcb+WJm7nPWuFIT
 Jk3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=bZVUjqZPvk9JmE5Zg9zhFjt8GTdbfi/4bsMjlewJUWk=;
 b=BLWQKacQfxayCXiZmstOvozXYaSaljYXmE8ma3i/+HsxwLSSA/H6OotEZ72p6P/44S
 IN42H9o0MyOwJ6VTdzZQi1GL/+GEbJL4Oj10jne4+icqXpPRDkKPJDkqqlHO+eam4KHq
 aQ0We3E5RkQAV4xqpkNDxajV4zCkhXe2sjP7jRU+oSotsU+Niz2rQ/8oqLxHwwggurSu
 07ZJvlxq4eFSqoAqJJLDJJicuI1ivasZ21/TDC1nJ6M6iLIE7tXdYdj+44mqHEz7+FF8
 x6fFZAPw21IjGYHYovTZG3wk408HQqeiUL8y4EDkeLez0yVRtTIB5SGDwk0o+/mqzs1c
 wqkw==
X-Gm-Message-State: AOAM532quIdkILaIs/6YAT1+ixlG+JZcSemBr/B6tYuXOij2nTGYmivP
 JYKlFlbhixkjPhqD33QgY8PlG3yEyPze/G7O
X-Google-Smtp-Source: ABdhPJzIf2J8nBqop7fmYzkcGAkj+y2xNYn0qrO6QCTJJblj1YqU+JBYf2vFEz2ZVBbbWeDXxgiKVw==
X-Received: by 2002:a2e:9510:: with SMTP id f16mr4618994ljh.408.1606507153729; 
 Fri, 27 Nov 2020 11:59:13 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:13 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>,
 Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v1 15/28] video: fbdev: neofb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:12 +0100
Message-Id: <20201127195825.858960-16-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnigns by removing unused code

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Evgeny Novikov <novikov@ispras.ru>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Mike Rapoport <rppt@kernel.org>
---
 drivers/video/fbdev/neofb.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c
index 09a20d4ab35f..c0f4f402da3f 100644
--- a/drivers/video/fbdev/neofb.c
+++ b/drivers/video/fbdev/neofb.c
@@ -1843,7 +1843,6 @@ static int neo_init_hw(struct fb_info *info)
 	struct neofb_par *par = info->par;
 	int videoRam = 896;
 	int maxClock = 65000;
-	int CursorMem = 1024;
 	int CursorOff = 0x100;
 
 	DBG("neo_init_hw");
@@ -1895,19 +1894,16 @@ static int neo_init_hw(struct fb_info *info)
 	case FB_ACCEL_NEOMAGIC_NM2070:
 	case FB_ACCEL_NEOMAGIC_NM2090:
 	case FB_ACCEL_NEOMAGIC_NM2093:
-		CursorMem = 2048;
 		CursorOff = 0x100;
 		break;
 	case FB_ACCEL_NEOMAGIC_NM2097:
 	case FB_ACCEL_NEOMAGIC_NM2160:
-		CursorMem = 1024;
 		CursorOff = 0x100;
 		break;
 	case FB_ACCEL_NEOMAGIC_NM2200:
 	case FB_ACCEL_NEOMAGIC_NM2230:
 	case FB_ACCEL_NEOMAGIC_NM2360:
 	case FB_ACCEL_NEOMAGIC_NM2380:
-		CursorMem = 1024;
 		CursorOff = 0x1000;
 
 		par->neo2200 = (Neo2200 __iomem *) par->mmio_vbase;

From patchwork Fri Nov 27 19:58:13 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334276
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 311A0C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:33:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id E192722250
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:33:05 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="F5kbqnNA"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730018AbgK1BcP (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:32:15 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56678 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731126AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com
 [IPv6:2a00:1450:4864:20::244])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F12A0C08C5F2
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:17 -0800 (PST)
Received: by mail-lj1-x244.google.com with SMTP id y16so7155185ljk.1
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=mRaQzSKHKEuFE/qSNI079F7TkEGyaY0pXgqjdW2jv1k=;
 b=F5kbqnNAjMLimvM6NUli0+DihWCFYsBD33fOr3p163gxIURDv8B6jteJoEoQ+geGjs
 MaShloEU1MtW6yhoNx/S2FtEUiP/7S0bg73YNb68VLyN+2NS/JHHXYq/MRDrl+j7d7Qs
 apXomIG4x8rmWcntA311Xv5TtIvKNpWMQ+cb2zkPlxhYuHglLRxZ+Xvh3yVfhmM9lD9W
 JllBNk9cOxuFLM2zmwQc8VfnmQYPwmQqBFcMfBMPTcNa7qxUor4JsVKfnWzCHQvP1QKT
 lb6tD8ZSHCEjGsUQXad9S939PolnZeDXHL8rxy8QaDpTsTyRy/dZxjqXXBF2+Bk4rC8g
 LuVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=mRaQzSKHKEuFE/qSNI079F7TkEGyaY0pXgqjdW2jv1k=;
 b=BvICOvb7XVHPvM+KuXXl0AfpqtKfyqF3mZ/w2Ct8/K2E7NSYhSLp6Kal83JqHouQkt
 bAFR1PYgNIzUU5FlHMjgYbP7a9HwuxEZNCQ1dz5/zN1rwrE8Ce18Bov5E58P5vWuQzUg
 8jZrCM844v7/Vagx9qW9GbbvsJ27rzrAyyRZrqkRbT/FX0zMOarsuFNfJhLKKAqU7D0o
 PSSb0hY5uf4zl6aoslmhenYSQyim9g/+XrQ7ZHI+/tLc9NcPK8h2GRp9IwV1ramcdvfu
 5nO3RosT4d71b2TqPzW6LXHyxAwFdru187ricrGxkFLHITkv3mqT77ki42RrPefm8br7
 LauA==
X-Gm-Message-State: AOAM530cn+nRIyYhpjw3WbL0uOT1AQNRYOCtyV2u3wFhffE4pgl7gBfz
 xK7e5NZfnsqobegnV0dUSbB0/wdAerzOwQke
X-Google-Smtp-Source: ABdhPJxny0VqK6KTdW128+jhrnmUhcAiAPM8ah698YeRpDAV9+q/qAnWBVSKNtaRbwkos5sr5AZ61Q==
X-Received: by 2002:a2e:8796:: with SMTP id n22mr4325949lji.345.1606507156297; 
 Fri, 27 Nov 2020 11:59:16 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.13
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:15 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 16/28] video: fbdev: hgafb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:13 +0100
Message-Id: <20201127195825.858960-17-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix kernel-doc comments.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
Cc: linux-nvidia@lists.surfsouth.com
---
 drivers/video/fbdev/hgafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index a45fcff1461f..69af72937844 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -358,7 +358,7 @@ static int hga_card_detect(void)
 /**
  *	hgafb_open - open the framebuffer device
  *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	@init:open by console system or userland.
  */
 
 static int hgafb_open(struct fb_info *info, int init)
@@ -372,7 +372,7 @@ static int hgafb_open(struct fb_info *info, int init)
 /**
  *	hgafb_open - open the framebuffer device
  *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	@init:open by console system or userland.
  */
 
 static int hgafb_release(struct fb_info *info, int init)

From patchwork Fri Nov 27 19:58:14 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334562
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 40698C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:32:29 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id E075A21D7A
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:32:28 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="jbH3C6iD"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1727725AbgK1Bav (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:30:51 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56582 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731062AbgK0T72 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:28 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F24AC08E85E
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:20 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id 142so7095265ljj.10
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=xCWN7JDF/GtG5ZT98j8MKTwxgU6VMyLEQn0BdCwiEZg=;
 b=jbH3C6iDq7RWgytVy0NqJ9b8P5K30Cm7OdBwf8Ji9IkOVEjaGTEXkzXn/jjyXzr7kY
 sjLBjzNEg9oFpHLY24Tn7gC2A8ZCORXoCpF9YpsgdLCokn6acUS/J3u73rJxgj6AbLzU
 h8WHUVdRQHAjkyXkxkZ9lkE7tICAm32EGZ/EjMKh5YvrGhcx226zT2Utcb5FqPbogvRY
 4nQynzKQAQk1J30F6wuA2tl7s+4Odrj08KY7ptk0YZ0WgZaJ8bV2yEAxaFmrlwu3ROhJ
 7mIgPTjRQ94jK57rwZOIOYml+tAcX2ezQ9a7rIzmhCA7E1k1Cs4NCE8bzquqiB2US41P
 322g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=xCWN7JDF/GtG5ZT98j8MKTwxgU6VMyLEQn0BdCwiEZg=;
 b=pZQh6A+C0i6PbqWWDuqb9oND5NLcyMgbtUWFB1S4/ZJ+EjPSNTgjuCpJvxcoVD2I9D
 izrZoeOWKs/r6JCfyITLDcrW92V+ct1TFsiK1oZ9JFhxOh31flIQfybTF1BcZfX22jTF
 b4nu/OF5UFZ96aY28TtUACghJz95mtwKBaZmEsNZHzi0/wNCozfPrDhVtpbQobR8ehwo
 iuMgNCkxg2OD7J7l4NuEMd7laCaSKhrQZsJgaR3a29pAldGW8v4UFdJUqBD9zhzuyLLE
 8R2yuAkz/HbQJTkI6udArXwU5txEUqFS1lTgc2YC1bICTN1/jJrBG9ZwapAzqkVq+FMi
 KNUQ==
X-Gm-Message-State: AOAM533e/5l5leoVlXxVAUCcULD+AUQZW3riGITSU0B3PEP9jtRCIoj4
 v/pwikCeTBhpN7T5oJSkj5tRVNInQs8Cl/Nx
X-Google-Smtp-Source: ABdhPJwfQQRY1xyFWQCeqxGmr8x+xQ8Y8oFVP5doJc1VCIcNMxQvxTGPTEVTuqS/GyeZgySJ4zyVnA==
X-Received: by 2002:a2e:a54f:: with SMTP id e15mr1958143ljn.461.1606507158904; 
 Fri, 27 Nov 2020 11:59:18 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.16
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:18 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 17/28] video: fbdev: tgafb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:14 +0100
Message-Id: <20201127195825.858960-18-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings:
- Fix kernel-doc
- Drop unused code

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joe Perches <joe@perches.com>
---
 drivers/video/fbdev/tgafb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/tgafb.c b/drivers/video/fbdev/tgafb.c
index 666fbe2f671c..ae0cf5540636 100644
--- a/drivers/video/fbdev/tgafb.c
+++ b/drivers/video/fbdev/tgafb.c
@@ -555,7 +555,7 @@ tgafb_setcolreg(unsigned regno, unsigned red, unsigned green, unsigned blue,
 
 /**
  *      tgafb_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
  *      @info: frame buffer structure that represents a single frame buffer
  */
 static int
@@ -837,7 +837,7 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
 	u32 *palette = ((u32 *)info->pseudo_palette);
 	unsigned long pos, line_length, i, j;
 	const unsigned char *data;
-	void __iomem *regs_base, *fb_base;
+	void __iomem *fb_base;
 
 	dx = image->dx;
 	dy = image->dy;
@@ -855,7 +855,6 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
 	if (dy + height > vyres)
 		height = vyres - dy;
 
-	regs_base = par->tga_regs_base;
 	fb_base = par->tga_fb_base;
 
 	pos = dy * line_length + (dx * 4);
@@ -1034,7 +1033,7 @@ tgafb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
 		     regs_base + TGA_MODE_REG);
 }
 
-/**
+/*
  *      tgafb_copyarea - REQUIRED function. Can use generic routines if
  *                       non acclerated hardware and packed pixel based.
  *                       Copies on area of the screen to another area.

From patchwork Fri Nov 27 19:58:15 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334271
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 29044C63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:29:16 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id E0F0220809
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 02:29:15 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="abL3wWcv"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729872AbgK1C2q (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 21:28:46 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56690 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731135AbgK0T71 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 14:59:27 -0500
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [IPv6:2a00:1450:4864:20::241])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 262DBC0613D4
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:23 -0800 (PST)
Received: by mail-lj1-x241.google.com with SMTP id z1so7131170ljn.4
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=ekXPc5E7Fh5wD/Vc411Zf73OtfZn7TTfUSuqDZSxDOI=;
 b=abL3wWcvsvIz2CzO/LLQDCf6XcLh3onTjaMFDbGE74/YxhdMd5qgru9TxPx1XN+iwj
 uvlGQppWRm4tryk0y+YoqhT1zyKdQHFNHWdbwFnhNiLbPBWzLDb2Q4lL5/fNiKgNuGK3
 qieT5nqi1qzBx9lSmNch74YLkmKW1LSxDX3omn3t33/G7J+bEEoNXDod3xPQOoffnTlC
 UOs2GrcWE2DMYOkzM6z5qM0FmTWCvRFzHnn/yP/XWrevQjm19rxNz5m5bh3rApNBsDTS
 UFW+++W0JdwSqoLqjua+cPbmHpauD1O2T5YtvRC7PECiKQkPylu3MlvlSjPYnA+FjUq2
 qUHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=ekXPc5E7Fh5wD/Vc411Zf73OtfZn7TTfUSuqDZSxDOI=;
 b=B8tfqr22z07Tb9+2Q6lVJcL6thOirqLGACP9IULURp92FRy/6kDzewTjiQy7jXLikk
 CP1Fq3GR+xsg+UeyylafXySHP/WkooFSoefLAxQWaXT9uavmupAxVDCSJ9ILAHhC3cSv
 FFA9+nfRF3xR4EvKQgT8tofvFCMowbpbUaww4yl0AIz9oVYNFjKMqZqwJPiXQpaeFk5+
 ANPW99DAxPttlZ5xzNyh+2o3j6wVyhpNT5aOy3oDtYvKrH2X/RZ7bNK0myugks3LYSmE
 EJB6zY5LFk8vrZPOyZp0P/DSDCpu1MYxxuKv7f5gV8uBaRkEOLsYQy7Gbd17ILUWEDE6
 GHiw==
X-Gm-Message-State: AOAM532G+rIZatxJ4ET85gB1+1mInMk7+kNreGZ2N+irecpEgd9azcr0
 2SiDxClX14EBxrLKH1mqWi4+CuFxaNySE8rA
X-Google-Smtp-Source: ABdhPJyOyRLSvkVpVR1HEUfAKSuZ5ePdfs+N0TGYeMdvRv4fmzf7VQ4BrA1YQM7s6/4t3ORr021/gQ==
X-Received: by 2002:a2e:80c4:: with SMTP id r4mr4469451ljg.284.1606507161441; 
 Fri, 27 Nov 2020 11:59:21 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.19
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:20 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 18/28] video: fbdev: mx3fb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:15 +0100
Message-Id: <20201127195825.858960-19-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings:
- Fix kernel-doc
- Drop unused code/variables

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Xiaofei Tan <tanxiaofei@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/video/fbdev/mx3fb.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
index 894617ddabcb..fabb271337ed 100644
--- a/drivers/video/fbdev/mx3fb.c
+++ b/drivers/video/fbdev/mx3fb.c
@@ -445,7 +445,6 @@ static void sdc_enable_channel(struct mx3fb_info *mx3_fbi)
 static void sdc_disable_channel(struct mx3fb_info *mx3_fbi)
 {
 	struct mx3fb_data *mx3fb = mx3_fbi->mx3fb;
-	uint32_t enabled;
 	unsigned long flags;
 
 	if (mx3_fbi->txd == NULL)
@@ -453,7 +452,7 @@ static void sdc_disable_channel(struct mx3fb_info *mx3_fbi)
 
 	spin_lock_irqsave(&mx3fb->lock, flags);
 
-	enabled = sdc_fb_uninit(mx3_fbi);
+	sdc_fb_uninit(mx3_fbi);
 
 	spin_unlock_irqrestore(&mx3fb->lock, flags);
 
@@ -732,7 +731,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi);
 
 /**
  * mx3fb_set_fix() - set fixed framebuffer parameters from variable settings.
- * @info:	framebuffer information pointer
+ * @fbi:	framebuffer information pointer
  * @return:	0 on success or negative error code on failure.
  */
 static int mx3fb_set_fix(struct fb_info *fbi)
@@ -740,7 +739,7 @@ static int mx3fb_set_fix(struct fb_info *fbi)
 	struct fb_fix_screeninfo *fix = &fbi->fix;
 	struct fb_var_screeninfo *var = &fbi->var;
 
-	strncpy(fix->id, "DISP3 BG", 8);
+	memcpy(fix->id, "DISP3 BG", 8);
 
 	fix->line_length = var->xres_virtual * var->bits_per_pixel / 8;
 
@@ -1105,6 +1104,8 @@ static void __blank(int blank, struct fb_info *fbi)
 
 /**
  * mx3fb_blank() - blank the display.
+ * @blank:	blank value for the panel
+ * @fbi:	framebuffer information pointer
  */
 static int mx3fb_blank(int blank, struct fb_info *fbi)
 {
@@ -1126,7 +1127,7 @@ static int mx3fb_blank(int blank, struct fb_info *fbi)
 /**
  * mx3fb_pan_display() - pan or wrap the display
  * @var:	variable screen buffer information.
- * @info:	framebuffer information pointer.
+ * @fbi:	framebuffer information pointer.
  *
  * We look only at xoffset, yoffset and the FB_VMODE_YWRAP flag
  */
@@ -1387,6 +1388,8 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi)
 
 /**
  * mx3fb_init_fbinfo() - initialize framebuffer information object.
+ * @dev: the device
+ * @ops:	framebuffer device operations
  * @return:	initialized framebuffer structure.
  */
 static struct fb_info *mx3fb_init_fbinfo(struct device *dev,

From patchwork Fri Nov 27 19:58:16 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 333829
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0F6C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:02:27 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 3B17020B80
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:02:27 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="XL9dM0QX"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730817AbgK0UB7 (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 15:01:59 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56690 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731213AbgK0UAz (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:00:55 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBCB7C0617A7
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:25 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id t6so8512666lfl.13
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=HJCCs701PuH94ttSnntK7aHGLX4n+uQaWh7rvZc4+5Q=;
 b=XL9dM0QX7eZv3hWcOJkyWShIDYFHGB5p6irIlZjigyIw419igo35AjyGfLQqAEOLxD
 Y29Vq3/y99v858NZeFa5Bf/kzx/WzccNpEAfg87SsnOxwFbV/Rl8WsDSnRBlsupsdtrT
 Rqv6Mm7W9Y+fCHyVe0jEsEng0Eqs2rjSVvcLP3XqYlgCv8MWe9pmIJAV+RkFW2Zklfxl
 qjUV3x9lu4KLkcw6yVeKhtJz0T3+DYFnUYK7do+Ral39li6kU5xeeQiVX5fGj5SpHOj9
 DwwyX3xP41+mI96xwf3oG9xNwyrFYEW1ZrpBx1rlS9Nghj4S2HUEffR6yhTwBZxewAlW
 JLfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=HJCCs701PuH94ttSnntK7aHGLX4n+uQaWh7rvZc4+5Q=;
 b=cBKVISfEHXIDQZB32S3uH7zSkFWzCjxVAG24bZiwcH3eZkXFZlpJetnc1p/2/4B/IR
 q4Zk8xTxaeS1OQnthc4rOmVQMbkNWSCGowaCh80O4Zdw/LwgdR7RTFdifUfq7TdC+SII
 RsAKWv3x2n+pW98HTkDqSPPwIlk7Tn9bBcBChbiB0TWs7mxFqa9ufKMpBFvy8O+Ht1+u
 MBebhUSOtLC+MxcQPEdGDPSGQodkHCi5JLTFSflMq41pRyY7S8pFIhsT8FTT9KYg/og3
 KiF/c3g8jUadmcU6lF8HdxC8AcAElv+FHl3tYA/TB/1kfgA37IKXOBWEiw31vlSlXw4D
 TBFw==
X-Gm-Message-State: AOAM530mFySJfxkTZgGayud1w0E60ZOGzIQcVKMO+JIdwpUjtThRegrB
 Yp/GBk3GoTu6bXOgIWtHcg4uJzbBOBjjF86f
X-Google-Smtp-Source: ABdhPJwcJUOl3IK06p2KacexTdtmQMu4TmgBVRIEsQFXz2LTtqcUCQU49x1lagy1jQZE0TiE5VjMuA==
X-Received: by 2002:a19:f809:: with SMTP id a9mr4026574lff.314.1606507164062; 
 Fri, 27 Nov 2020 11:59:24 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:23 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 19/28] video: fbdev: sstfb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:16 +0100
Message-Id: <20201127195825.858960-20-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings by introducing no_printk variants for the
internal logging system for this driver.

Fix a new warning that popped up now that logging was checked for
correct printf format strings.

A more invasive fix had been to replace all the internal logging with
standard logging primitives - thats for another day.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alex Dewar <alex.dewar90@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/sstfb.c | 2 +-
 include/video/sstfb.h       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c
index c05cdabeb11c..27d4b0ace2d6 100644
--- a/drivers/video/fbdev/sstfb.c
+++ b/drivers/video/fbdev/sstfb.c
@@ -1390,7 +1390,7 @@ static int sstfb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	        fix->smem_start, info->screen_base,
 	        fix->smem_len >> 20);
 
-	f_ddprintk("regbase_virt: %#lx\n", par->mmio_vbase);
+	f_ddprintk("regbase_virt: %p\n", par->mmio_vbase);
 	f_ddprintk("membase_phys: %#lx\n", fix->smem_start);
 	f_ddprintk("fbbase_virt: %p\n", info->screen_base);
 
diff --git a/include/video/sstfb.h b/include/video/sstfb.h
index 28384f354773..d4a5e41d1173 100644
--- a/include/video/sstfb.h
+++ b/include/video/sstfb.h
@@ -23,7 +23,7 @@
 #  define SST_DEBUG_FUNC 1
 #  define SST_DEBUG_VAR  1
 #else
-#  define dprintk(X...)
+#  define dprintk(X...)		no_printk(X)
 #  define SST_DEBUG_REG  0
 #  define SST_DEBUG_FUNC 0
 #  define SST_DEBUG_VAR  0
@@ -48,7 +48,7 @@
 #if (SST_DEBUG_FUNC > 1)
 #  define f_ddprintk(X...)	dprintk(" " X)
 #else
-#  define f_ddprintk(X...)
+#  define f_ddprintk(X...)	no_printk(X)
 #endif
 #if (SST_DEBUG_FUNC > 2)
 #  define f_dddprintk(X...)	dprintk(" " X)

From patchwork Fri Nov 27 19:58:17 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334277
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 81CC0C63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:27:58 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 3C9042224E
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:27:58 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="qF9fwez/"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729486AbgK1B1U (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:27:20 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56818 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731215AbgK0UAz (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:00:55 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96808C061A48
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:28 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id i17so7139167ljd.3
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=9kSOTWA+7s6AOb+69TSTraRrpPzvQt0NSKodoDw/MKE=;
 b=qF9fwez/8eaHyKOX5BvHZDGWBo8OtRqL2a/PzPIQyIbhyLEOO7waJR7Z0THGhHMceD
 RckmI4o1wQh67jeR6LjecdUPPo5kDcu117113Z9ni218DuH6CkR8YoQtniRJbgO7Eu5p
 BD/aCCHWbEkkxq2ZRld7/VYfPoeEA5KAieFBVOWJSyZnwDMV9Qx0kAGGXW2d6ORuxaFV
 ng7b0pFUuDPJyq0J2aGoG4aHLBIk6yh4PL8gax6RSGwlyAYQk1H3+mj3cC77H9I4TI43
 YS5lOmapuee8ceUM8hT+sW2koepygnS6aJwBOs3blDtAmFM0q/Iud2UzmOkzjbOq0TYQ
 1eAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=9kSOTWA+7s6AOb+69TSTraRrpPzvQt0NSKodoDw/MKE=;
 b=EhRT4O1AjLBTeg7tQtpy5xl+XmbXY31loILHj/LxcGfiwBji83d5SU6rbmBBObhhmt
 uljr4BzvPWETTdha9uu7Cpu+efQ5vBI2JAxEUoBP99OWLDLADd0wOduACZ5ikzYV1f+O
 GLEBl89+hYiUp+ANhq8X+sB2zcmdHwKRoS59tyhMvx5d9fhvCxOjzYz03vi8XN4gXClN
 EWcKXh8fDBJkkRifE7qrPzq4elGAPqED7+hR7GdJQCzPSRaQXyMuefAPWGQLG1inKTmS
 n55CCul6o417iXZL8fKxW/2rpMXVZ88Ti7TZ9B3ztpoAfFlSq+haSjAOI+p9zTZVfuAl
 bnTA==
X-Gm-Message-State: AOAM532u5eu0zUce4CL3CqlaZNCfJet8L9BmHCvt8lNA7bikcFZJS1+Q
 /J08qHGu1cc4DYZnIZveB7HJySXIuQM2elmO
X-Google-Smtp-Source: ABdhPJyiPskz8/EA3qnZwsG8Wc64GE4af1+UWpYPCXIfNajx7wDDAG0cU5XuIvRrf/LNtcypwTCcqQ==
X-Received: by 2002:a2e:7803:: with SMTP id t3mr4447881ljc.176.1606507166788; 
 Fri, 27 Nov 2020 11:59:26 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:26 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 20/28] video: fbdev: nvidia: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:17 +0100
Message-Id: <20201127195825.858960-21-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix warnings by deleting unused code

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/nvidia/nv_setup.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c
index 2fa68669613a..5404017e6957 100644
--- a/drivers/video/fbdev/nvidia/nv_setup.c
+++ b/drivers/video/fbdev/nvidia/nv_setup.c
@@ -89,9 +89,8 @@ u8 NVReadSeq(struct nvidia_par *par, u8 index)
 }
 void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value)
 {
-	volatile u8 tmp;
 
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
+	VGA_RD08(par->PCIO, par->IOBase + 0x0a);
 	if (par->paletteEnabled)
 		index &= ~0x20;
 	else
@@ -101,9 +100,7 @@ void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value)
 }
 u8 NVReadAttr(struct nvidia_par *par, u8 index)
 {
-	volatile u8 tmp;
-
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
+	VGA_RD08(par->PCIO, par->IOBase + 0x0a);
 	if (par->paletteEnabled)
 		index &= ~0x20;
 	else

From patchwork Fri Nov 27 19:58:18 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334281
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id B1856C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:02:59 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 507AE20B80
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:02:59 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="DhdxkWmu"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730815AbgK0UC1 (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 15:02:27 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56678 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731156AbgK0UBR (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:17 -0500
Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com
 [IPv6:2a00:1450:4864:20::244])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C105C08E85F
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:31 -0800 (PST)
Received: by mail-lj1-x244.google.com with SMTP id s9so7094203ljo.11
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jVb7kx4jWo/2x//FtaTHCinUwYboF6da4/HiQYT27Ks=;
 b=DhdxkWmu2HCF3oKhPnt7WYf+9MAgkg+Km+yd6SRatM/3r3is1dT+DaXrkQ8rSgFavv
 DX0i0f31hM7FQ2N0ALQPr0hFERsaJ+qPKdtrsAi5GOfnpzfWwJ8iDj6pJDCQ/kAyP7y7
 00kUBE1g2M3nNXwSq1iIx1JI1Pd8r1NO5SVAh/w4G89+4CCAIjgo1CD22Zc0uRf4ZZEo
 ITozi7jwnM0WKuQxKdMhk1YVPMW+yDWru7kH8vDhTbLFcDGYbi4+0+oTiqj5DNjt2cVw
 IclvTUdidm7N/DOPgjPidmbwVGZtVtweZWVsgcli+KBB8il6oVWpueUCX1m8goMAocr6
 mXRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=jVb7kx4jWo/2x//FtaTHCinUwYboF6da4/HiQYT27Ks=;
 b=jCjmYMh58PHmA4JOMfqHKNVgxuUpBSImEsZ3qwKlYYVEaWtJhr9XaHVnrOH/DwdIuE
 yzUkp5nfZt7lO/Aju0ROXbTw8mEUf8chec4yVdOzUSullNqQmpe/YRv/v2YzoGwAeY1j
 O095TeCrhoWroEmysVdKMdH22VAtjKglh0vcvhe56x5ind1xiACmBBknUqFyxtT+wMaG
 S4Exlc3MTm1rZu5Dvv6vqMkAYnr1RBoRGJjwV+kWRBpIB8z0wIWKCpp6VXx228x9qgqA
 ufH+glT7TwvLMs/9jj08urIeV9g547E56zE8ZitEouNvQyiiAz6MJHlqfl3F2zkSq8hr
 SjQw==
X-Gm-Message-State: AOAM531eFG0sBCtXACq++Kcdj798e8IonqFRbSuAQivMSu6m0BPkN4Y1
 x+0JHuxEjQLx2IoWzh7q7ig8BPahOPYrBgb7
X-Google-Smtp-Source: ABdhPJyvGuhMzkR8UpVgq1X9d5l4d3Sk5qK0Lj6aoZPnFFRd6TL29IQGgk3UvpTPgVbijIdATGYAmg==
X-Received: by 2002:a2e:9a95:: with SMTP id p21mr4547132lji.245.1606507169401; 
 Fri, 27 Nov 2020 11:59:29 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:28 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 21/28] video: fbdev: tmiofb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:18 +0100
Message-Id: <20201127195825.858960-22-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings by avoiding local variables and use direct references.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
---
 drivers/video/fbdev/tmiofb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/tmiofb.c b/drivers/video/fbdev/tmiofb.c
index 50111966c981..b70faa3850f2 100644
--- a/drivers/video/fbdev/tmiofb.c
+++ b/drivers/video/fbdev/tmiofb.c
@@ -802,10 +802,8 @@ static int tmiofb_remove(struct platform_device *dev)
 	const struct mfd_cell *cell = mfd_get_cell(dev);
 	struct fb_info *info = platform_get_drvdata(dev);
 	int irq = platform_get_irq(dev, 0);
-	struct tmiofb_par *par;
 
 	if (info) {
-		par = info->par;
 		unregister_framebuffer(info);
 
 		tmiofb_hw_stop(dev);
@@ -816,8 +814,8 @@ static int tmiofb_remove(struct platform_device *dev)
 		free_irq(irq, info);
 
 		iounmap(info->screen_base);
-		iounmap(par->lcr);
-		iounmap(par->ccr);
+		iounmap(((struct tmiofb_par *)info->par)->lcr);
+		iounmap(((struct tmiofb_par *)info->par)->ccr);
 
 		framebuffer_release(info);
 	}

From patchwork Fri Nov 27 19:58:19 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334279
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 409D6C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:21:54 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id EF18422255
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:21:53 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="TCBYH4Mo"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729604AbgK1BVV (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:21:21 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56608 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731162AbgK0UBR (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:17 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF97DC08E860
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:33 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id z21so8531261lfe.12
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=rJy8+vjkzYcV3XZ9Y+7Fhqd4Ih76XwRBzaJbmXxDMAw=;
 b=TCBYH4MoDC4EkijExZlsZmuW7pCHINO8ItDGIOhZpNfusWNsUwsPFSjpOj3DV1FYfq
 U7rEdu3HkuAAtAPqhoC9k9YNFAdbYPSWUHxs8zNG6Wkd4BfEwYRxYzZReMO8HsrT96UA
 TIXsjv6vxzOlkQK8X4r168/DpCnKzqBaLxYag3qdIwFpLzGNDSbDNTaLjNT/RS9MFNzK
 GuxEHrhefBzz4opGqJsXeV1LE28StIAkEBTZLqF1vfe4UXaI2cKfqOE8wPRCw2IqU+Jh
 9sVtCEx725p2FYiEAlCLIfbbYsklFvoCjAbnmD8RbDnN6lKr7NGHecqvHhfsCCr6+2ho
 p2xA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=rJy8+vjkzYcV3XZ9Y+7Fhqd4Ih76XwRBzaJbmXxDMAw=;
 b=bZFP1jRQGtxtt7sTURw95haJbR9QzhHdai2a0OIN65C79HY5p/sYmkYXK4mMu+TMZN
 DeknhtPLUbFJABUrzS8stsxezwSqII85sE5+zI54WMForfSWqwvFSNqUb5cYRGAt1zR4
 sJlEOplWz5xUg6nBxL7bak/u2ix+grPUmY4KfxnvwVG5hv8rcrxxFQE6S8FMnGV3YFyh
 87SEXBNdgtynNsGt0eYYudesyxRb0ICG8l5bU+lVFwBXu5eUgMEVYEI6BkhH/BStzJZs
 R3f0eH39qU35eQd8R80xycX//Dujrpdso6owXbL3pWbCcyg776ZtZF25UlSqCA/Gs1xV
 6Vng==
X-Gm-Message-State: AOAM5316NbLVTHX/eRRGAy/W2CIWJWk8Id6gPSA3vLgKo+aEOCSmCfcr
 zQ+GwFxwv4V60mjexwSmCv5CwwCctJi0135i
X-Google-Smtp-Source: ABdhPJyOgA2kVm8O0iBLEqcMx9FEwMgL+93MG+gzwXYrmJwqzkMgjoJP3OWnlBdNp/YB6uBjS4Hc3g==
X-Received: by 2002:ac2:562a:: with SMTP id b10mr4250758lff.227.1606507172012; 
 Fri, 27 Nov 2020 11:59:32 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:31 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 22/28] video: fbdev: omapfb: Fix W=1 warnings in dsi
Date: Fri, 27 Nov 2020 20:58:19 +0100
Message-Id: <20201127195825.858960-23-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix several W=1 warnings.
This removes a little unused code and avoids an assignment by moving
the use inside the conditional block.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Aditya Pakki <pakki001@umn.edu>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
index 6f9c25fec994..72d45a02c3ac 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
@@ -1178,13 +1178,12 @@ static int dsi_regulator_init(struct platform_device *dsidev)
 
 static void _dsi_print_reset_status(struct platform_device *dsidev)
 {
-	u32 l;
 	int b0, b1, b2;
 
 	/* A dummy read using the SCP interface to any DSIPHY register is
 	 * required after DSIPHY reset to complete the reset of the DSI complex
 	 * I/O. */
-	l = dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
+	dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
 
 	if (dss_has_feature(FEAT_DSI_REVERSE_TXCLKESC)) {
 		b0 = 28;
@@ -3627,7 +3626,7 @@ static int dsi_proto_config(struct platform_device *dsidev)
 static void dsi_proto_timings(struct platform_device *dsidev)
 {
 	struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
-	unsigned tlpx, tclk_zero, tclk_prepare, tclk_trail;
+	unsigned tlpx, tclk_zero, tclk_prepare;
 	unsigned tclk_pre, tclk_post;
 	unsigned ths_prepare, ths_prepare_ths_zero, ths_zero;
 	unsigned ths_trail, ths_exit;
@@ -3646,7 +3645,6 @@ static void dsi_proto_timings(struct platform_device *dsidev)
 
 	r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG1);
 	tlpx = FLD_GET(r, 20, 16) * 2;
-	tclk_trail = FLD_GET(r, 15, 8);
 	tclk_zero = FLD_GET(r, 7, 0);
 
 	r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG2);
@@ -4040,7 +4038,6 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
 {
 	struct platform_device *dsidev = dsi_get_dsidev_from_dssdev(dssdev);
 	struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
-	u16 dw, dh;
 
 	dsi_perf_mark_setup(dsidev);
 
@@ -4049,11 +4046,8 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
 	dsi->framedone_callback = callback;
 	dsi->framedone_data = data;
 
-	dw = dsi->timings.x_res;
-	dh = dsi->timings.y_res;
-
 #ifdef DSI_PERF_MEASURE
-	dsi->update_bytes = dw * dh *
+	dsi->update_bytes = dsi->timings.x_res * dsi->timings.y_res *
 		dsi_get_pixel_size(dsi->pix_fmt) / 8;
 #endif
 	dsi_update_screen_dispc(dsidev);

From patchwork Fri Nov 27 19:58:20 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334566
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id E62D5C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 00:30:18 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 8B1AF22242
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 00:30:18 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="ctjpvSvX"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730858AbgK0UDF (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 15:03:05 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56628 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731305AbgK0UBR (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:17 -0500
Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com
 [IPv6:2a00:1450:4864:20::143])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614A8C08E861
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:36 -0800 (PST)
Received: by mail-lf1-x143.google.com with SMTP id l11so8590692lfg.0
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=MQ7x12uggS1hOxK6f7aoLRuOChXNZlZXJg/tbIyd2NE=;
 b=ctjpvSvXytDB/DKOBAaGeJq6N+6ajZhDwwURDOm1a77ewn2epdHf91lKJmKsmV9Ntc
 Wk7XOINOThuZoiwWZIwCNjvbaF28djxwFm9wYet8glHpvm53BKYrCKMwJYauCUMjmOmq
 NxdjwfIK2Jnz4h/ah7pTKLyOLkSBMEdvoU3ifR3hRUcWGd/975WKCDBtdInczsSnIEg+
 JeWR62v/ubFBf3s/ap4vXK2Ta0ZR6TBHKp7ez3oY7QFQLKm5WH6wK479iEQq3KwVKZU2
 uw7IyT5qTtjFrWVxADiTkvkAYzbAuJ4tla5i6bd5kK5ffGxj2H1VYYZQbAFYeabjtXdB
 jSsQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=MQ7x12uggS1hOxK6f7aoLRuOChXNZlZXJg/tbIyd2NE=;
 b=sgJprSN1OkR3HEgXfiwUK89KDGD8W4RDlT4BOqhQmcNWZ1a7FzeNaqt+x6JGDuBS8z
 dJph10djgC/LRQ8CBuR/w94ydd/5NyNaUJ9PhPZ82Qs0xd0dRCdWHKdaOiGyVq+YSm+y
 jW0I97ahDrtPlHdLjLmGW0kGHR/G/Iz+1YRaT/ILrlwe37wu+464H5S43coVnP0z6Z8I
 YYh4GqQp0Lc1lh9GvvmdB3IQP4bOv90fxpUyrGRcz/eesM3xNkcdq0pySgIrxYUmZvhr
 E3GZCOSw0rJCvAFXmKiPsH3RSM/FT60da4a4ysCnqhEuXZPhsd3kpRL92u3A3i7sIHov
 C3qQ==
X-Gm-Message-State: AOAM53116fL61Us4dZPutvdDJbd0ENUjFB/dSgWSnAYeaD1gdiZFp2p3
 hgpbpd0HaoleQuyAOf+V0UrI2hM/uZ3LtyGF
X-Google-Smtp-Source: ABdhPJwsswLBNRVwQvuTIB+FN9iriKOhhkmrAHLnDO+ZnWN0hmlyW5YbmkqfB7BJvDh/ZXx/oMQYeg==
X-Received: by 2002:a05:6512:481:: with SMTP id
 v1mr4168850lfq.132.1606507174690; 
 Fri, 27 Nov 2020 11:59:34 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:34 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 23/28] video: fbdev: omapfb: Fix W=1 warnings in hdmi*_core
Date: Fri, 27 Nov 2020 20:58:20 +0100
Message-Id: <20201127195825.858960-24-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix a few W=1 warnings about unused assignments.
Drop the unused error code.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Qilong Zhang <zhangqilong3@huawei.com>
Cc: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++--
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
index 726c190862d4..e6363a420933 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
@@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 	struct hdmi_audio_format audio_format;
 	struct hdmi_audio_dma audio_dma;
 	struct hdmi_core_audio_config acore;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
 	unsigned int fs_nr;
 	bool word_length_16b = false;
 
@@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 		return -EINVAL;
 	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
 
 	/* Audio clock regeneration settings */
 	acore.n = n;
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
index eda29d3032e1..cb63bc0e92ca 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
@@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 	struct hdmi_audio_format audio_format;
 	struct hdmi_audio_dma audio_dma;
 	struct hdmi_core_audio_config core_cfg;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
 	unsigned int fs_nr;
 	bool word_length_16b = false;
 
@@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 		return -EINVAL;
 	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
 	core_cfg.n = n;
 	core_cfg.cts = cts;
 

From patchwork Fri Nov 27 19:58:21 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334564
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 67B8CC3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:23:21 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 2203822255
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:23:21 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="YVPokDiH"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729425AbgK1BWx (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:22:53 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56594 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731324AbgK0UBR (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:17 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16F0CC08E862
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:39 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id d8so8586998lfa.1
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=b0Ju2b6VwP0rGTkHcCSaLjeBzsLdorcbkSm8ycWNFi8=;
 b=YVPokDiHGMOA9sbLmSAHlS5XU0a5XJHcHYLM/96x34Sb9JnoZklVkiVZFvgVRY2O8D
 aA1OqTdOfDklYRW9I7wUVCqlQ0/4GrkcCf41U9FMlKD+xy7gbgDYUUwIGVWxtsqFrhG2
 nqbnO9ryw5FC3dTTqfjBrXCQcB0EgzrMJeljIt3r87SKtBfGvrDaMrj40u65HM3CCX8j
 i4msTSZCAF2DtP7W/gqypD+z93w+e7DmqQjndJmsNb9jx5jYr/NLrkVBVTCi1VByfytN
 9j44D4ggrk7zVgtZVCnPZVhSh+72mRIGxciTQnYfHWKKajkkcxnTW/evGXe33n1hYGDi
 //sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=b0Ju2b6VwP0rGTkHcCSaLjeBzsLdorcbkSm8ycWNFi8=;
 b=fJH2UDI/s4fkpjTAShU/vIHVyXfARarLVHst19C/cjoSlpSk/BaTlxYnAt+FydheAe
 /rJoAKAxqMjhm9Bbwwh0OmFpmm+WwTBR9lHBzjNUf+aN6S9ovYNWCbC182D2zzV9+yn2
 SL6QJeDD1drwg4wSjeofr9UsrC2h8gADfSQLTzic6cJlqZrRn550st4E9IJgbbtTnlmh
 LP9EkfVTqrJdPS237fFCU+PVuPKQwPUOaE3hx53bMf44+a/OKVQXiZo2sYX0ecZ9cJp7
 15MDn9MN12Ym+/KXYf4K9W1qSM+IkrL2pN/goRgmuh0SJHuvSaEvOJSmyQmAAGUWSoEF
 O/8A==
X-Gm-Message-State: AOAM530erehX5/JnUJMq0Mq9cPd+ta2KP49uavAns1y/XgcOQvwU06Og
 I1tufyTCKKje56dbni7MhfcdhpVgryFSZwEU
X-Google-Smtp-Source: ABdhPJw6mJwSIHR8X58y/nVsjR7+pYbL7xkqTpsYLQAhnaUTmtEaj/ktaFglnB3Ot6ORxhYINSCP/Q==
X-Received: by 2002:a19:5602:: with SMTP id k2mr3959293lfb.359.1606507177274; 
 Fri, 27 Nov 2020 11:59:37 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:36 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 24/28] video: fbdev: s3c-fb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:21 +0100
Message-Id: <20201127195825.858960-25-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix several W=1 warnings
- Updated kernel-doc as needed
- Deleted unused local variable, it was assigned but never used

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/s3c-fb.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index ba316bd56efd..3b134e1bbc38 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -75,6 +75,7 @@ struct s3c_fb;
  * @buf_size: Offset of buffer size registers.
  * @buf_end: Offset of buffer end registers.
  * @osd: The base for the OSD registers.
+ * @osd_stride: stride of osd
  * @palette: Address of palette memory, or 0 if none.
  * @has_prtcon: Set if has PRTCON register.
  * @has_shadowcon: Set if has SHADOWCON register.
@@ -155,7 +156,7 @@ struct s3c_fb_palette {
  * @windata: The platform data supplied for the window configuration.
  * @parent: The hardware that this window is part of.
  * @fbinfo: Pointer pack to the framebuffer info for this window.
- * @varint: The variant information for this window.
+ * @variant: The variant information for this window.
  * @palette_buffer: Buffer/cache to hold palette entries.
  * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/
  * @index: The window number of this window.
@@ -336,7 +337,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
 /**
  * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock.
  * @sfb: The hardware state.
- * @pixclock: The pixel clock wanted, in picoseconds.
+ * @pixclk: The pixel clock wanted, in picoseconds.
  *
  * Given the specified pixel clock, work out the necessary divider to get
  * close to the output frequency.
@@ -733,7 +734,7 @@ static inline unsigned int chan_to_field(unsigned int chan,
  * @red: The red field for the palette data.
  * @green: The green field for the palette data.
  * @blue: The blue field for the palette data.
- * @trans: The transparency (alpha) field for the palette data.
+ * @transp: The transparency (alpha) field for the palette data.
  * @info: The framebuffer being changed.
  */
 static int s3c_fb_setcolreg(unsigned regno,
@@ -1133,6 +1134,7 @@ static void s3c_fb_free_memory(struct s3c_fb *sfb, struct s3c_fb_win *win)
 
 /**
  * s3c_fb_release_win() - release resources for a framebuffer window.
+ * @sfb: The base resources for the hardware.
  * @win: The window to cleanup the resources for.
  *
  * Release the resources that where claimed for the hardware window,
@@ -1160,6 +1162,7 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, struct s3c_fb_win *win)
 /**
  * s3c_fb_probe_win() - register an hardware window
  * @sfb: The base resources for the hardware
+ * @win_no: The window number
  * @variant: The variant information for this window.
  * @res: Pointer to where to place the resultant window.
  *
@@ -1170,7 +1173,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no,
 			    struct s3c_fb_win_variant *variant,
 			    struct s3c_fb_win **res)
 {
-	struct fb_var_screeninfo *var;
 	struct fb_videomode initmode;
 	struct s3c_fb_pd_win *windata;
 	struct s3c_fb_win *win;
@@ -1198,7 +1200,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no,
 
 	win = fbinfo->par;
 	*res = win;
-	var = &fbinfo->var;
 	win->variant = *variant;
 	win->fbinfo = fbinfo;
 	win->parent = sfb;

From patchwork Fri Nov 27 19:58:22 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334278
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 438A3C3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:23:36 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id EF30E22255
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:23:35 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="MjuKWshb"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729796AbgK1BXB (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:23:01 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56582 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731245AbgK0UBJ (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:09 -0500
Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com
 [IPv6:2a00:1450:4864:20::142])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97193C08E863
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:41 -0800 (PST)
Received: by mail-lf1-x142.google.com with SMTP id s27so8562150lfp.5
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=0dUZy5AyOXYDj2k6s63lZ9ADEngOOXb1VvoVlRiIbSA=;
 b=MjuKWshbXzpQxhEMy1+a7PgY3BUmh4NKhTLvba9JMkrPSZAUulqFr2FQHBqGVk9Cgc
 Jsue6qrqGil2Huy/DKFQ8LjxZ/TGXPJUG/4d172uj1o/ffbZjypW7fMNlskOPL8R82Qb
 4jSwKbPC+Ec+57sXNmOzpM1PUlydBVZuRD2+aeSJT8yGM1xbZQ/PZwva2SUtdLdjdhqq
 stBM+vQgRx44O7SxwewScrN8T4iqOymIm8aKr+9g8wAI9X93wrxdlNkK5QN/VMok5pB6
 kUOcpS5nDqX8JlWdiAQ+VTORorBfMhjM91S/c2qf2uIrjnfgrJogZfUWj6mtVz6X12Vb
 2DiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=0dUZy5AyOXYDj2k6s63lZ9ADEngOOXb1VvoVlRiIbSA=;
 b=en0oJDejw5VNrF6uYxLhupb62oXzM+fnj0WXSmZXWDH0u3khNEZZoT9sZgHQE5Lnxz
 slKeM0mQpS+2+j8wqAiCIastiTro4ceXln+6W7gKAbCJgLaI0LgqKLatL/8h1mas22Xb
 uAPPNVg3Qa38NSkSvXslSYRl9Sw/soJfY4ffOwKxDPdK7XFBgYKTWDz+WG0kC5vMCCjj
 NEC0VlG/uNsP+7pwu8anZfyGBUZ0aQAGUPzciYYdprOklAWDLFW08cnZj8+g9SNqNts8
 ZxBL9z4Y8A12YMipmvTV/dc7zBhAKIDpblxyotANPP3M+WUBKQMUpSH4SBUfhunHzU3a
 E2Jw==
X-Gm-Message-State: AOAM533mfk/zf/DD0Aov2PfV7d/nFDwksDPPahnqWL1RlezQHzUG3J/f
 xNBgToX7OD6cNeq6tYwIKmqGT3Jr0BlONL9p
X-Google-Smtp-Source: ABdhPJy2ZKM89RK3vlOw0vIIpP/pIYwaQgPn9/q3zJF7dVDoEGUxmqssdj4WEHCuxoR1HWo+YV/lHQ==
X-Received: by 2002:ac2:550d:: with SMTP id j13mr4446626lfk.301.1606507179931; 
 Fri, 27 Nov 2020 11:59:39 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.37
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:39 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 25/28] video: fbdev: uvesafb: Fix W=1 warning
Date: Fri, 27 Nov 2020 20:58:22 +0100
Message-Id: <20201127195825.858960-26-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warning by deleting unused local variable.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Januszewski <spock@gentoo.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/uvesafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index def14ac0ebe1..8ee0fc9c63cf 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -554,12 +554,12 @@ static int uvesafb_vbe_getmodes(struct uvesafb_ktask *task,
 static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
 			      struct uvesafb_par *par)
 {
-	int i, err;
+	int i;
 
 	uvesafb_reset(task);
 	task->t.regs.eax = 0x4f0a;
 	task->t.regs.ebx = 0x0;
-	err = uvesafb_exec(task);
+	uvesafb_exec(task);
 
 	if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
 		par->pmi_setpal = par->ypan = 0;

From patchwork Fri Nov 27 19:58:23 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334280
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 161C0C63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 00:31:08 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id CB5842223F
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 00:31:07 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="dRT/DaQu"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1731213AbgK0UCS (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 15:02:18 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731293AbgK0UBR (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:17 -0500
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [IPv6:2a00:1450:4864:20::241])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A79C08E864
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:44 -0800 (PST)
Received: by mail-lj1-x241.google.com with SMTP id y16so7156225ljk.1
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=cTz8UNZSB2sQnZVOY7U0wdeJbPp7ZoKiq9hM9XyTjD8=;
 b=dRT/DaQuxup56pjO/gXvCOHAFRuO1qWDIs0CBnqhSXDTtr/bSWQu2Ap+yUyq+B44+A
 neG0M7I0sJitoqxpbq2Yv0USUFFjoo6QhS/EEYu4HvbE8XHA+xb3ABCMI55iyfqUQdna
 yb0QgRDle+80a4z1OJrF3nyORqFTCGwJYztA3HK+rMcLIgnrNrLdcU0rtjUdmKBHKuLb
 vvInFX+bp4OkZ/2EEZ9lwNd07cypaYMY/o49aMZTVQQMGBaNI3fiK4OyR8I9tos2WUp6
 PnMnXcVo9CxblX4AV3NR0hsMeaf5lyqTZPMM24rlzSTWJHH3vMFitAk61/zxQnCnCFQr
 tJOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=cTz8UNZSB2sQnZVOY7U0wdeJbPp7ZoKiq9hM9XyTjD8=;
 b=RuCaH+NpY3iucQfhC3cq14w37paSNqejw2OUBS9p1/rTnD2UeG+JIWACZzzrurq86O
 Fm6voDdyojWw2SZ3IAlthY7xjqJwtDIJcG7RyDJtpqW80RWqjhH7DddR+3Y1F1yjEVk7
 +ebdbp2beI0g6T/4HIfV2SjQFZcwSkJ3yRZvS9MXxsvRazLXFMKr5sZQnIpSBYGQR/25
 bEqtXcdS4Knw2z0W1HxlgjExkQOFm2Manls8YOhDp6YqhJ8uRfbCa2q8oiLlakBJP6r9
 bwf84GsHOog5bt9qt0lhnc7uVMRFNwqsFNTauVzjVhh++2Sf2Ct27Q5WPmZXD0rRk0Wq
 aqEQ==
X-Gm-Message-State: AOAM530KarX48OWkfhqNGr/7rTf32DOvmtwXAyly54On3H72u3OM4cFt
 wiBPK1bSGQGHI5xxndNv59Zfso9izcY1SyCz
X-Google-Smtp-Source: ABdhPJw+juNp86cxlqMgAnqmJUMMNTIlemg5zHcEmGRNGhL2jyUtf2DC8PEqnsNHMepTLTQNwgzflA==
X-Received: by 2002:a2e:9951:: with SMTP id r17mr602111ljj.113.1606507182492; 
 Fri, 27 Nov 2020 11:59:42 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:42 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 26/28] video: fbdev: uvesafb: Fix W=1 string related
 warnings
Date: Fri, 27 Nov 2020 20:58:23 +0100
Message-Id: <20201127195825.858960-27-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Two W=1 string related warnings.
- Using strncpy to copy string wihtout null-termination is not good.
  Use memcpy to copy only the relevant chars

- Fix a potential bug with a very long string, subtract one from the
  length to make room for the termination null.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Januszewski <spock@gentoo.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/uvesafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index 8ee0fc9c63cf..45dc8da191e4 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -423,7 +423,7 @@ static int uvesafb_vbe_getinfo(struct uvesafb_ktask *task,
 	task->t.flags = TF_VBEIB;
 	task->t.buf_len = sizeof(struct vbe_ib);
 	task->buf = &par->vbe_ib;
-	strncpy(par->vbe_ib.vbe_signature, "VBE2", 4);
+	memcpy(par->vbe_ib.vbe_signature, "VBE2", 4);
 
 	err = uvesafb_exec(task);
 	if (err || (task->t.regs.eax & 0xffff) != 0x004f) {
@@ -1871,7 +1871,7 @@ static ssize_t v86d_show(struct device_driver *dev, char *buf)
 static ssize_t v86d_store(struct device_driver *dev, const char *buf,
 		size_t count)
 {
-	strncpy(v86d_path, buf, PATH_MAX);
+	strncpy(v86d_path, buf, PATH_MAX - 1);
 	return count;
 }
 static DRIVER_ATTR_RW(v86d);

From patchwork Fri Nov 27 19:58:24 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334565
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 174EDC3E8C5
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:21:22 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id C62F220857
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 01:21:21 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="uCchEecM"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729695AbgK1BTT (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 20:19:19 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56602 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731337AbgK0UBX (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:23 -0500
Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com
 [IPv6:2a00:1450:4864:20::142])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4A33C08E9AA
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:46 -0800 (PST)
Received: by mail-lf1-x142.google.com with SMTP id t6so8513948lfl.13
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Y8wtXUawbSNHT6itVp9PKOsqounZ7r/XQRvyXGYV8s4=;
 b=uCchEecMQO/c968kGrHMi75DxnjAfug0UW+aYItCxW4i6Iwimiy9pksY5eUBYQwl4O
 r8N9m1kaX8yO9kzMiUW421bnoXfJr7otEBXhAuYXIryg8whiIzfAUYBqIWws/ZaF7Db6
 pUR8dvReqH2RzmOh2Ij82rZii5ClfkmrJcGUNcXSnm47I6Sx8veOKecG4zFG+TEV6VOx
 GpLoAwvsDjFcGew/J71nPkwrXZuP327XdXLBE5wnMp2Lx8H2ZTUaglXR7eTKkIO+I9oV
 huxDVJpCSoAeXhc6pxQuhKPDdR7CWYLz91ohFMgNqaRuE5RVnekpel+nxaAE+kFwn6Ji
 xQgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=Y8wtXUawbSNHT6itVp9PKOsqounZ7r/XQRvyXGYV8s4=;
 b=pwS/6YtQEUqd7f+8K79ew/ryFkjzHASCSd/LzNRkt4pPBGFs4EpMmS8LOicm6WnV0o
 GPW/ORF/Wo0cw/S2gBdIw6ym371Pcauvu2cjCkz/Y1xAiE4gQhR+6ldpYTyc7r6Bn8xa
 jJNY+N/gKqc4c+lspuTRgN58/x/fGXCTnlOouYcI4bBOoaTP+y8EbxAbkw2CWYrdJsOO
 QHsVWBZk1lmuDb7ygJ46+UQ7w0JTTzEqoL3o4ZUPxJ+4gh7dcUnbgz+WB5vdyUk9tfLx
 1rVvNTUbKR8Y6KxUBzctaP+g0yJ8Q9DC/C39q5ltLTMq3RIwpWIy22Z5aXviVOL17xB6
 BQkw==
X-Gm-Message-State: AOAM532txQLsC8Dell3UbUwVdaJVwbFXCqMI9KHdJ9dtemBQ/hzKfBzJ
 5CErU29V/Y9f/nj4awILyZFhXECeTNXD/XSb
X-Google-Smtp-Source: ABdhPJwgFjbWLJCd/wY65mHVlJvS4se9f+t/fvMNSUof1QOLLwqOeklo9SNHoshiG83N34pr1A6+7w==
X-Received: by 2002:a19:4bd2:: with SMTP id
 y201mr4378293lfa.330.1606507185047; 
 Fri, 27 Nov 2020 11:59:45 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:44 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 27/28] video: fbdev: cirrusfb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:24 +0100
Message-Id: <20201127195825.858960-28-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix warnings:
- fix kernel-doc
- delete unused code

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimemrmann <tzimmermann@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Mike Rapoport <rppt@kernel.org>
---
 drivers/video/fbdev/cirrusfb.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c
index e9027172c0f5..93802abbbc72 100644
--- a/drivers/video/fbdev/cirrusfb.c
+++ b/drivers/video/fbdev/cirrusfb.c
@@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo)
  */
 static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
 {
-	unsigned char dummy;
-
 	if (is_laguna(cinfo))
 		return;
 	if (cinfo->btype == BT_PICASSO) {
@@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
 		WGen(cinfo, VGA_PEL_MSK, 0x00);
 		udelay(200);
 		/* next read dummy from pixel address (3c8) */
-		dummy = RGen(cinfo, VGA_PEL_IW);
+		RGen(cinfo, VGA_PEL_IW);
 		udelay(200);
 	}
 	/* now do the usual stuff to access the HDR */
 
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
 
 	WGen(cinfo, VGA_PEL_MSK, val);
@@ -2492,7 +2490,7 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
 
 	if (cinfo->btype == BT_PICASSO) {
 		/* now first reset HDR access counter */
-		dummy = RGen(cinfo, VGA_PEL_IW);
+		RGen(cinfo, VGA_PEL_IW);
 		udelay(200);
 
 		/* and at the end, restore the mask value */
@@ -2800,9 +2798,9 @@ static void bestclock(long freq, int *nom, int *den, int *div)
 
 #ifdef CIRRUSFB_DEBUG
 
-/**
+/*
  * cirrusfb_dbg_print_regs
- * @base: If using newmmio, the newmmio base address, otherwise %NULL
+ * @regbase: If using newmmio, the newmmio base address, otherwise %NULL
  * @reg_class: type of registers to read: %CRT, or %SEQ
  *
  * DESCRIPTION:
@@ -2847,7 +2845,7 @@ static void cirrusfb_dbg_print_regs(struct fb_info *info,
 	va_end(list);
 }
 
-/**
+/*
  * cirrusfb_dbg_reg_dump
  * @base: If using newmmio, the newmmio base address, otherwise %NULL
  *

From patchwork Fri Nov 27 19:58:25 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 333828
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB9FC5519F
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:03:05 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 00BCB20B80
 for <linux-fbdev@archiver.kernel.org>;
 Fri, 27 Nov 2020 20:03:04 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="Kc+1a4MS"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1731156AbgK0UCr (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Fri, 27 Nov 2020 15:02:47 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56620 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1731297AbgK0UBR (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Fri, 27 Nov 2020 15:01:17 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48EA2C08ED7E
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:49 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id r18so7137674ljc.2
 for <linux-fbdev@vger.kernel.org>;
 Fri, 27 Nov 2020 11:59:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Hn1HA37yirdAV/UjfmF48pGZwDbporw/jjkHdVOHiV8=;
 b=Kc+1a4MS9x48X+CFz9W2lhSniC6B+kSQ7Y2VOn2DxjY9IskQPu0QtRF7074l+zzQ0o
 FC6vBfaX/wqSVzFgf0m9/2XUepVxAUvFjD0zVIQuEDxi41hoqGTYDvMy7P3LNpY1GTwu
 CW+zKFMNLRM4b1ebwIqOWq2jmpIJCJATB+kidIJ8ahXHatH3z/isgMdvMK7c7cAngZpe
 b70bVLyrD0tt7U1tn5CmZH1qM7pVe+YmCpbZCJmwZl2QJCsqLUtrgCV3wSjTiB3g/jCe
 kt4Lk5IoxUtOHxdVWc0fI6S507woMnhnVElZmBvTcZKJiyE0zyca9xXxU/UHNh2/UP8S
 KXdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=Hn1HA37yirdAV/UjfmF48pGZwDbporw/jjkHdVOHiV8=;
 b=e2Q2gbEKAG4YhZDr4rHHwdjxbwXb1CuC//mtzrAxCCYKwxBptyizlIIghoHlDPGGAA
 9TI/GOlnF4zn5cGpeh/Tu5OPMtRLtoGOST6FU9bZzIknFIilHwWNp7n07WhnsFAk6x0z
 Mo6DlZ1Zgl1ygNB9A+S6lFbzqx20wwobbabxzO8mUcSQHG7xmIstTUnnw6hsGJsYad/r
 vQnxARCdDdiSp5RLELTZi4PL9wkBiIg2U7MeHL7ZmkJKqDV8swjGFzP39G05R9HPz5kB
 R9PSNBaFtWPTQ3CL32Q8aMxjeXKAkRyZEqMAtaQ/ydp2Q5mqvEHSrQkvJ51CgUimH+aZ
 IVzw==
X-Gm-Message-State: AOAM533nee8BrW8kDM791NiZeGPnV+gSsOxdl972MnZLuYPIOE8dNxk2
 A6S8cDUlRDS77Wev2m/8YtMyWiFnB/XTz+JL
X-Google-Smtp-Source: ABdhPJyzKPfjBJ5WwV+z5m3Tu11O89a2OWEhNjm0qFsqqtcN5Z3T2NeQjCb+HQfsRR8Vvz2tIYOo+Q==
X-Received: by 2002:a2e:b047:: with SMTP id d7mr4294964ljl.63.1606507187607; 
 Fri, 27 Nov 2020 11:59:47 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451])
 by smtp.gmail.com with ESMTPSA id
 c6sm1070415ljj.140.2020.11.27.11.59.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Nov 2020 11:59:47 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 linux-nvidia@lists.surfsouth.com, Michal Januszewski <spock@gentoo.org>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 28/28] video: fbdev: s1d13xxxfb: Fix W=1 warnings
Date: Fri, 27 Nov 2020 20:58:25 +0100
Message-Id: <20201127195825.858960-29-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org>
References: <20201127195825.858960-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix following W=1 warnings:
- Fix unused variables for variables used only for logging.
  Fixed by introducing no_printk() to trick compiler to think variables
  are used
- Fix kernel-doc warning by deleting an empty comment line

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
---
 drivers/video/fbdev/s1d13xxxfb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
index 4541afcf9386..d1b5f965bc96 100644
--- a/drivers/video/fbdev/s1d13xxxfb.c
+++ b/drivers/video/fbdev/s1d13xxxfb.c
@@ -45,7 +45,7 @@
 #if 0
 #define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } while(0)
 #else
-#define dbg(fmt, args...) do { } while (0)
+#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } while (0)
 #endif
 
 /*
@@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area)
 }
 
 /**
- *
  *	s1d13xxxfb_bitblt_solidfill - accelerated solidfill function
  *	@info : framebuffer structure
  *	@rect : fb_fillrect structure