From patchwork Thu Dec 3 18:24:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337991 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EA0C4361A for ; Thu, 3 Dec 2020 18:27:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79604208A9 for ; Thu, 3 Dec 2020 18:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728858AbgLCS1B (ORCPT ); Thu, 3 Dec 2020 13:27:01 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:48593 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727099AbgLCS1B (ORCPT ); Thu, 3 Dec 2020 13:27:01 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M42fG-1kktHE2PNQ-00035r; Thu, 03 Dec 2020 19:24:24 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, m@bues.ch, linux-gpio@vger.kernel.org Subject: [PATCH 1/3] drivers: gpio: bt8xx: prefer dev_err()/dev_warn() over of raw printk Date: Thu, 3 Dec 2020 19:24:21 +0100 Message-Id: <20201203182423.5499-1-info@metux.net> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K1:ork4hdHpaaosunrFdJfmk8/tL63KrIVOMkn2G2YULcn042vLnu2 e8QR8CzEbnfieHb1AY0q4DamOuMQydQ69EvnNMEaPCUf2+Rtjtzh6xY6FnhGrgfvUChA1D/ +d1u+s9KjMap/lyWDNdFOIFccTjeXnj5woSv6LZSONgFfZHRzP/ZdDmn6azMeBEARXwO24L yQBcXiff9A4AKsSNKyxUw== X-UI-Out-Filterresults: notjunk:1; V03:K0:ZShIZ9xpTqo=:TuUGsPdW/aTRv2/HfKukZw zPX72Cpv7RpyXOOFP2AnAovZwAPoKPPk43CLz6gExatx8aJt5J7+oMzuRd17O6XqbCvH1WS/B oPTg1bGXgmsT+JXAm4tjqeFfWc8TBqGeuy20jXyw7GQXkKXupe1+/bne9yNpvxsKNjFVgjNjT R7TJx92sQJbGkI/QR5Rq4TURITYfw4sO9gpgbMNhQTp2oRNGZvnMmN8la1kd7yipLg1D89r1H AT0Nl5CDdyt8WHyQbeN623Pqr1mjhfE7NWjiRyR7B+/iLmpH01kUNdto5JLdjlpxp+qnrAEBJ YLEMHEhbV6Dda1oAu/627n+FAFoLO3cNwI+HeuU+4kQ3IcY4bXoXTQAR+PjfW924BAvTVSsfm M9OnBXOQCNZU8UnUGpeIlJjRi/JbaEOjX8xL+DMA25zPyj4pR6RSwebS/+Vpf Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org For logging in device contexts, dev_*() functions are preferred over raw printk(), which also print out device name. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-bt8xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c index a6f30ad6750f..7920cf256798 100644 --- a/drivers/gpio/gpio-bt8xx.c +++ b/drivers/gpio/gpio-bt8xx.c @@ -175,13 +175,13 @@ static int bt8xxgpio_probe(struct pci_dev *dev, err = pci_enable_device(dev); if (err) { - printk(KERN_ERR "bt8xxgpio: Can't enable device.\n"); + dev_err(&dev->dev, "can't enable device.\n"); return err; } if (!devm_request_mem_region(&dev->dev, pci_resource_start(dev, 0), pci_resource_len(dev, 0), "bt8xxgpio")) { - printk(KERN_WARNING "bt8xxgpio: Can't request iomem (0x%llx).\n", + dev_warn(&dev->dev, "can't request iomem (0x%llx).\n", (unsigned long long)pci_resource_start(dev, 0)); err = -EBUSY; goto err_disable; @@ -191,7 +191,7 @@ static int bt8xxgpio_probe(struct pci_dev *dev, bg->mmio = devm_ioremap(&dev->dev, pci_resource_start(dev, 0), 0x1000); if (!bg->mmio) { - printk(KERN_ERR "bt8xxgpio: ioremap() failed\n"); + dev_err(&dev->dev, "ioremap() failed\n"); err = -EIO; goto err_disable; } @@ -207,7 +207,7 @@ static int bt8xxgpio_probe(struct pci_dev *dev, bt8xxgpio_gpio_setup(bg); err = gpiochip_add_data(&bg->gpio, bg); if (err) { - printk(KERN_ERR "bt8xxgpio: Failed to register GPIOs\n"); + dev_err(&dev->dev, "failed to register GPIOs\n"); goto err_disable; } From patchwork Thu Dec 3 18:24:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B736C0007A for ; Thu, 3 Dec 2020 18:27:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F548221EF for ; Thu, 3 Dec 2020 18:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729982AbgLCS1D (ORCPT ); Thu, 3 Dec 2020 13:27:03 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:45311 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727483AbgLCS1C (ORCPT ); Thu, 3 Dec 2020 13:27:02 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N63NW-1k5H3A3mUC-016QPv; Thu, 03 Dec 2020 19:24:25 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, m@bues.ch, linux-gpio@vger.kernel.org Subject: [PATCH 2/3] drivers: gpio: amd8111: prefer dev_err()/dev_info() over raw printk Date: Thu, 3 Dec 2020 19:24:22 +0100 Message-Id: <20201203182423.5499-2-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201203182423.5499-1-info@metux.net> References: <20201203182423.5499-1-info@metux.net> X-Provags-ID: V03:K1:NPQYOay/O7xWfZswY6hsysAxuOGoo3irixtnjIU4Q0p8Mv/Vjo+ X7TtAMFtkiJypubtvOtkkw+JBTT2m4zA2g70R0oDjuLXU2fwHTcTcDLCcr8NAgW21TVQ4b4 PEeT+jAlAVRXBh4NNWIpEgmqp6dqJIHYQ1HrqVrQg3+C+jp28kPHPqDOwmt00PTQsiGdkHX Q3kiTlq4GPb1P9+QryG5Q== X-UI-Out-Filterresults: notjunk:1; V03:K0:xaEchQnbeUM=:RyJ4VSBt+MeAVIv0i8BtHj IDOPF+oWEc9x/T1UV8fVoEUG6K7dqrfunTXtA40jtjW7h66dvMsw0+e66Sto00gYGgmKlyEgR M24++lIw38azruN9PEb9sTrvwZDzapg1tRid/gh3unMZnlmnoxAekyjjkiszCDGUYWYp1nvhW qGYUEJLpctxYXcZPWyMdb6tyeeFrvTJNJ8c95Xk9gyfc6Gqmy8cNsTJYWySwhEgMHRZC0gygj vOoSLi0KD+3eAdDWhciuttnf4inP+0XmiW9ax2nEv/yV095G3g/jxmb02FAb1zUi64Zb46Ncx co24Mjf974AQFIXTQx1DiNIu5BEhkoZ2h09fZ1QfkX+EB2m8qxa/q30m8vnu4W4lFe9mm7deL IGULEHo0D8C+8CKF+Yq4yj3Hje/Vnu+gsceUzAS/Nm50X/YzUr1W/64+g6ZW/ Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org For logging in device contexts, dev_*() functions are preferred over raw printk(), which also print out device name. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-amd8111.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c index fdcebe59510d..0e260950992d 100644 --- a/drivers/gpio/gpio-amd8111.c +++ b/drivers/gpio/gpio-amd8111.c @@ -179,7 +179,6 @@ static int __init amd_gpio_init(void) struct pci_dev *pdev = NULL; const struct pci_device_id *ent; - /* We look for our device - AMD South Bridge * I don't know about a system with two such bridges, * so we can assume that there is max. one device. @@ -223,11 +222,10 @@ static int __init amd_gpio_init(void) spin_lock_init(&gp.lock); - printk(KERN_INFO "AMD-8111 GPIO detected\n"); + dev_info(&pdev->dev, "AMD-8111 GPIO detected\n"); err = gpiochip_add_data(&gp.chip, &gp); if (err) { - printk(KERN_ERR "GPIO registering failed (%d)\n", - err); + dev_err(&pdev->dev, "GPIO registering failed (%d)\n", err); ioport_unmap(gp.pm); goto out; } From patchwork Thu Dec 3 18:24:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 337990 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4319C18E57 for ; Thu, 3 Dec 2020 18:27:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F251208A9 for ; Thu, 3 Dec 2020 18:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729227AbgLCS1C (ORCPT ); Thu, 3 Dec 2020 13:27:02 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:60139 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbgLCS1B (ORCPT ); Thu, 3 Dec 2020 13:27:01 -0500 Received: from orion.localdomain ([95.118.71.13]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M597q-1klzCv0zXI-00191P; Thu, 03 Dec 2020 19:24:25 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, m@bues.ch, linux-gpio@vger.kernel.org Subject: [PATCH 3/3] drivers: gpio: amd8111: use SPDX-License-Identifier Date: Thu, 3 Dec 2020 19:24:23 +0100 Message-Id: <20201203182423.5499-3-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201203182423.5499-1-info@metux.net> References: <20201203182423.5499-1-info@metux.net> X-Provags-ID: V03:K1:K6rguvECz7albWgihc5SpVddtWHUKDYK1w304F8q96OZlg3LuEs maz2qVgYcn/nfVZ1lxunxfjzBOUhN3dpHypiNvj8NXhkkeb1KU2EoCZleDdl/B+sH9J+9MC SyH1t4xupsuf3OBeBJ9rOZNEzJlnDA3RUGzjxOQI6MJ7eatWHdjpxwnUzEBveCX15GnI3pi KMutGdWrna+46bnA8tADw== X-UI-Out-Filterresults: notjunk:1; V03:K0:9SFYdtNulQs=:hqqxdRQEQQQ/A0OAXbvfg1 BM7tlRkVpImlerK5pgUC0PLUk2NDi4ape4GW6Zt9C81dUqVY4Ph3nptWaYxIYxApS8xX2xgZs /eA2Zk3hEtWWH6UeB1h1g1my4Mv91xGXZ2sZcCbkAvnzues6HjS1IVSCQ2d2pN74K4EBrslmc e2cleYdYkPFezfPLeGNHCuxhLXvdB9By6ifZrk0PIxS0fqYtGHZ2SbhyDYJJa5IRCxgnVSue4 LTojlkpPbuEOuK+Lym7iXplP9ml09+sKjIu/0R/vaPdHg5CLAZiteyQU1JFli/BJGCm1RXUc8 JVyakhtCROYszW1KEzAORyH2di3vbBWCVs2vVSGyxXvl1t8V82G/IQ0/Iw3L4dCDJvcu7cFx+ /HQzlo+dmHX8igNtzpLVIs3T6pFT5PUQBda8vMZJUf9vvikUIyobkp/u5zwVU Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Prefer SPDX-License-Identifier over hand-written texts. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-amd8111.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c index 0e260950992d..14e6b3e64add 100644 --- a/drivers/gpio/gpio-amd8111.c +++ b/drivers/gpio/gpio-amd8111.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * GPIO driver for AMD 8111 south bridges * @@ -20,10 +21,6 @@ * Hardware driver for Intel i810 Random Number Generator (RNG) * Copyright 2000,2001 Jeff Garzik * Copyright 2000,2001 Philipp Rumpf - * - * This file is licensed under the terms of the GNU General Public - * License version 2. This program is licensed "as is" without any - * warranty of any kind, whether express or implied. */ #include #include