From patchwork Fri Feb 2 08:03:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 126617 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp405967ljc; Fri, 2 Feb 2018 00:04:49 -0800 (PST) X-Google-Smtp-Source: AH8x227ECO+Np39q1POhuIX52nYq5ut52kLERyTicPLIs8mn9SOlDjizSfGAA7Cm/TSXBpc0by8o X-Received: by 10.223.152.130 with SMTP id w2mr2463369wrb.12.1517558689246; Fri, 02 Feb 2018 00:04:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517558689; cv=none; d=google.com; s=arc-20160816; b=qeWM/rwkmeFF+B3bBN6306SORQlwJPkiCpsGsCaoEjbhoLW7/lQk1cpWkQE4vPCMc0 3bUXU32BMB2tfoEAxQgRXUn0+FFLaNkHAK1Ue9v1Oa13HdWi16ewKSJo6pzoGyzajne0 ZuUNzqcP+Ezkqjx4ROCp+Is6I2B2DwOyNjUtkyONQIm3Vn91bqQBTtCuN0wDmaB17m4S ijK2JGq1lZ/rFYNq0JMAuK0uBvfPoWN6tkKhjEODV5WYG/yKS/Ywtw1YOQQ7YzAxlGqR n8etZA7po0ZO/KNAcfALxvaFGt4rrN5OyoWKQ8L/z315GG76DBOdjfA1UX7A0S9wQVDA sJUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=f7wm7YrfZFahJXnFcgC299VbE5/Pevzc2aw2WjDXAVc=; b=rrqOytjomMmDkp0omqlayEJ+l4BxCmulCFNhcythBq2iUfNzgu7zqoK3YelMGbLqV8 7+ZOg9Q32Mrjfmm+cSghrcSeQzimFKeQTCVQNE47rSO2epUJ5Q91opCX0SZoh0xO48eE WISLi/2ppR6VhE2HFOjIMYFsjixNkVmMfQj1gFISU3nSyOG8eszpN6+buXHbJVC7eEvV 1z8Q27rqy+jhMdi9B4P3jE4eUhtXmAWWP81Yq6T+mtUpqzPEScm1LO+NsmFfykQjPbL8 2LxeQ6itbROiFa+zUkhS8Jdj/lUn5WOaa1xUpjGLBVxz42ZLYYQfdTp/79iyGFQLh8fu ofOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=p0TYO0xS; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id w76si792354wme.167.2018.02.02.00.04.48; Fri, 02 Feb 2018 00:04:49 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=p0TYO0xS; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ED05A84F; Fri, 2 Feb 2018 09:04:47 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0062.outbound.protection.outlook.com [104.47.2.62]) by dpdk.org (Postfix) with ESMTP id 6786FA48D for ; Fri, 2 Feb 2018 09:04:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=f7wm7YrfZFahJXnFcgC299VbE5/Pevzc2aw2WjDXAVc=; b=p0TYO0xS3Fy94APjzZthUrs5++IM0eEMPLOk2qNb/nukg8Pjel7MidCw2WEuw8DGxrYAV5qxF4XyysvU6h4Pcu/zkjPbs3iLYFE0ZqQsC1n6Q/h3K6HZLbcTYygy/yVPcHrHmqrKrbRFfuVoP4OY4RRWNrDV4RJP5yHn+MCBKBc= Received: from bf-netperf1.ap.freescale.net (192.88.169.1) by DB4PR04MB0768.eurprd04.prod.outlook.com (2a01:111:e400:984d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 2 Feb 2018 08:04:33 +0000 From: Hemant Agrawal To: olivier.matz@6wind.com, thomas@monjalon.net, pbhagavatula@caviumnetworks.com Cc: nipun.gupta@nxp.com, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org, Hemant Agrawal Date: Fri, 2 Feb 2018 13:33:00 +0530 Message-Id: <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: SG2PR06CA0087.apcprd06.prod.outlook.com (2603:1096:3:14::13) To DB4PR04MB0768.eurprd04.prod.outlook.com (2a01:111:e400:984d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b9d464f0-a2b0-4976-2c50-08d56a139a0e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB4PR04MB0768; X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0768; 3:Akvyd33Z71I1/JwefnO4OeQ0H0Eq3hwjE8e3IvqrMviAr7DEyRWqaqMpoO5GDNQZJ4VcP0Tr9ZM7SHQs6KPa05SSHagKXbOJBH5NRPIQ/T4wM9wuzNlBnTLuXoX6x5FdMDof6KgGk5oaZsmEP8f2J5IYR1sKyRBMp6Ra+iXV/cYJ/QYGWpZQTIFk2xo1Z+/MaylbnN38zfLYEfg1vI1lJPL+UXQQULpOaTUTtZY3srRT+OOEf0DA9f4SvupjYW8w; 25:vUIfibLah9kgZxtVNRc0JxnVFE8KCMmxvB5ZVJQmKz/yuHb/HvtZO5ROEFm3v8aYyPSB7W2Je8j+1km21pDVwhpOGT3o8XjONux1iQLkHH1QbnbgKR2/3B4864jcVpTLU+TNEsd/jaz0noiOmlE5QcYMldE2XZ82HgpFXvlz0eMtnU9tiH+WNuj7/jZ6xPrh8UCB6Eb/X2fA4m5RmAJsvufBR8fgT/GYSgTve3vTSGOfGZ6SYFOcAgoyJXWvWoPZRgtAUzSoi0BwbZG5/ocA8jcr2xAUzH3ANYp4SEdGIdtznumQ1vlwnr8mKdoyH/df1x4pdRYr2WxhzKay4Kou8w==; 31:I/2DKFL0rUNwd5Q1J3Sq8IJG00z/TKsec/eMKZPG0y3cS0dPmc1IGPEl41suLX+GQg8lmEPakkjxdA1IstnHEYr9jvJ4ktOqMFHhPiv74cR7YAHBF21oiMaWlvAf0/jUvbohpbzLGqzfDkA9gpfR2GhlTnObcwVhhMNiMDQUY56ecLpMZWCeD0DTLYIyONKS6GYPmeBWFlxDfY5hNeWi4hrMDVETo9RZ1texecgRsbA= X-MS-TrafficTypeDiagnostic: DB4PR04MB0768: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0768; 20:D93FhJh/mEa2d/m6pRpZAiD/8Pntuy94/ELcBJ5s13sR6fP/ERcTQmFauS0gA1yrMlywedDjrkYlslAxC0ksU45eDkf5nErB+dSjbADtva6tXR/DhD4p+lmfNH8u45FVnxw/79S2UyFxug8LrQS+taEcGVwLEJiFUO50n/ESkTNL+tsTSZ2ClAwcKzeMiNSxtLBgwzzuySAkMIiWDGP45KgJi5J2ooAO27EFDhZeCAt9va70VXbUycC+C4L8EQNJjVHDrnkhyAi7Ts8gVaPlUj8qvRKbfC8lwyRbH1QBJXRbbF+ygk1lxcehVNVqxEck3S+jrIiUpLxlzPB5/Sb314rKKsEfimA+usTCalHHVM2Rdj/EHyg5FhZ4gP9Z/RLnCJZnE7qpWCzgRnqaDGInVFSxSpuPTiuD3r1P2L97lfrb13tSa4i8cU+oe7ocqmgg3NTQhZg7fokL4q8bf9eELD1/DySe/tCqmXyoXGzT2+IeV79fx3RBn2wF9GWcfDqE; 4:UfYVb2uEV2R8kSPymzMEkR9rTbw+i+O13HQkVpHD2JayAwEZ5eBU8nYgn/59b2TIjvVwClVNheOZsQmbghUheokx2A0LP6G+hpp+HpeYh03PLXhE3+pFfOcrOt+DQdZq8UmvJf6Hxfi0FMqT8FVoy0n/j2tmRLgUQMi1XPIR4wEzpDGY15PHfOvwyY2B+T1fuuk5SVbAz0cL5lXXlp2H3tpfkjXjH9HC8wrbSlUVdLlV2Nj+cEVIx+IsMAPQkxJqThdlaMET/sPWM4EYdNLyZ31uef5fkdUxFLykvgGtHZCbXN2exWzlsFguxVPH7WNj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231101)(2400082)(944501161)(10201501046)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:DB4PR04MB0768; BCL:0; PCL:0; RULEID:; SRVR:DB4PR04MB0768; X-Forefront-PRVS: 05715BE7FD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(39860400002)(346002)(366004)(396003)(189003)(199004)(6512007)(6486002)(53936002)(478600001)(305945005)(316002)(16586007)(50226002)(25786009)(386003)(106356001)(6506007)(8676002)(51416003)(81156014)(52116002)(81166006)(105586002)(6116002)(3846002)(5660300001)(4326008)(2950100002)(76176011)(2906002)(8936002)(6666003)(36756003)(66066001)(48376002)(68736007)(86362001)(97736004)(47776003)(186003)(16526019)(7736002)(26005)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR04MB0768; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR04MB0768; 23:W36BNapejL+NenmkznT8UxLtBf28TQkc0g2IxQJhH?= gDp+de+xJx9Bm/yDfuDP9ssCIh29tysNTL0kzciLqpjiWs6FA42XyglTFevhbG+9atcNWr9IiCL65K5mbaFnjxJhpxk39m1dQ5SfH7q3Sz9Rb+9xq7UllfKMC+KNuTXigvovHyJbG4paS6sso1Feiux8/R5KutMAIZ0eBYF8GekKzmWJrGn8fkO5EDbu5yFZu60BPphcrpxFV6S1W5MGlc68QUY5+gCjRkRlXhnCBjld4loNLVtrY8p5KFN1uOJncHWb7Lq01JYPPjc/KxPGWG9PKA4RYJmxUF9QLnddwpmlq6pdjgoIbUgBTTY5/XO4cD3ioRCG84GD/Rou9jl5+ydYZuL4P7CazSMBtkwHXOV6VyvfYNGqu7oxSf1+/cdAHyozZHM1Jm8rv/PmXdrxRhpS9WKv41Tu3cNdAKecGLGX7qxcN5MkxOysqO1QFnnd0gDM896NmUepK2lJ3m87QK0+HvnSAgR9fdjdTKUfYeq9BxLnf9XfgrVGn/53pWY625YHIyv1oE7xRAgASwe1UiYaiLhATqsWi+4FuyHQNJcisBkOhEOKxGV3Pk/ZZipPGhgDWsvZvFgqxjksbjTaOJmcmrqfHD1j1XOILPLI/G66O4TZg2r6Q1MmDs5nWrb/9EgV904lO1Xw8qnlRn7jIss7NAVIqFleTAQUw/V2jX9+miwEMIrDsfOgyQHCsn31lQOaaI5k7IFjfi2IFjiKlkh14zoqXMoIyqtzRpAIV/E/FvDDkqwt9F/GXq3wYoXLbvubAweQdtHoN9Y/m6Ol0JVOJZ/sxkp2W4+J3d513MPd7P9+EnZT8OL6pQH/QDiDDD+mV6TO3Md95NGf3ASGgeUpcV29WfO5NOBgSVpg5jI7FcnxqxTkgYeYn6VIHyDYeqLvrM0Hi7kezxZPnonDQfSLsAM7eTjkpH3xHoWAQ2T/9vc8fcmzyjjqi9V0NTHuGkbVd3+sxPElSReQ90vPzFui8pqjZ6aqfvxdrYOFXsOX2Vj70nyoBP0HuSZ6pL6D/RqVUFsFmFnHB1OKMHz5uwv X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0768; 6:W/BgkP9IQjXwYoIQLf7iYa1GXRr8LYsaqHAYPhvjg4f2H3yKXyB217OySKElwkrwpLWZGyJrsT0nq0dk4RL2NTPEYOAN/KvDmaOLCE/+ckRhC5uUmQN97LAOWHJ/YR6rcJwmzZqEUhjFG5DEdxcOreb6vK0AtW+MbUCDpqH/573JM9y/I3JUK+t9QmmRJdHK9EJf+x0+Ge6Qsi0MjnxpelIhrOrWs/6So6a2wva7QHiPd+GMsC3tP6U4XFpMVl8BtV6yGOSuNcSLtWyyOMLNIATLnH3+pFAVGC/o94zI5vlHj3Sckr3+ckcQJuBFkPLu3w1xGPhYwVKwGSpOTyS77XI6iQ3MkS1GhjjK21vcXH4=; 5:2KJm4oPBD6sv02PCCyocBsHmKxzUZZWV1omVjk1o2ODDd+ScjHypmKvzGTgF3U5bB+0Qza7X2+oToIzi8eW8ejw2lmGKoX+58+oU66NMeCplkMHWeXt3J8H9IuVsauZOoJ0Yux5Mi/yvJL8fPWDgrgC53b/ccsXmmMRqrbgJlqE=; 24:Fmom9PCGFvH+ofgTDfvVCohZygd9r5Wfo1jjjZN4Hm51hr/3LAgWnABvxTOVQgtoWqXs1uQCAJANabKyjQx46cZMYKJ91XF7A5MY2hutCWQ=; 7:Ygp36kkTVoSx54jgyIEGDYXTJNH1PHV1/QJcThuY6K84cUiaCcmAll1FfqpXuIB1LeR7YD3Am9j3CA7CvxwdfadPwZmb4riY5kg2akpK25lJCsrPEbWlBxaLf48w8am5j0RnHIPyVB2UhRbLZbvcLn2L8iunoBJ4k9gBV8YZdx9nHR9n7vaPl7NetMc6ve8bg8yy9h5wwIa+hmd1fU0xqFS291cChYQbb9s6iXTAVmzKGVNx4qVymios01oxhORI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2018 08:04:33.5898 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9d464f0-a2b0-4976-2c50-08d56a139a0e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0768 Subject: [dpdk-dev] [PATCH FIX-OPTION-2 1/2] eal: use named memzone to store user mempool ops name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The new mbuf pool ops name API uses the named memzone to store different types of configured mempool ops name. It is better to also save the user configured mempool ops name in named memzone. This way the best mempool ops name can easily get the user configured mempool ops name for it's decisions. This will also avoid the need to maintain a eal api for default mempool ops name. Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal.c | 5 +++ lib/librte_eal/common/eal_common_mempool.c | 50 ++++++++++++++++++++++++++++++ lib/librte_eal/common/eal_private.h | 12 +++++++ lib/librte_eal/common/meson.build | 1 + lib/librte_eal/linuxapp/eal/Makefile | 1 + lib/librte_eal/linuxapp/eal/eal.c | 5 +++ 7 files changed, 75 insertions(+) create mode 100644 lib/librte_eal/common/eal_common_mempool.c -- 2.7.4 diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile index dd455e6..f07dace 100644 --- a/lib/librte_eal/bsdapp/eal/Makefile +++ b/lib/librte_eal/bsdapp/eal/Makefile @@ -38,6 +38,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_alarm.c SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_lcore.c SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_timer.c SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_memzone.c +SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_mempool.c SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_log.c SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_launch.c SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_memory.c diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 1622a41..2c33a60 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c @@ -621,6 +621,11 @@ rte_eal_init(int argc, char **argv) return -1; } + if (rte_eal_mempool_ops_config() < 0) { + rte_eal_init_alert("Cannot config user Mempool Ops\n"); + return -1; + } + eal_check_mem_on_local_socket(); eal_thread_init_master(rte_config.master_lcore); diff --git a/lib/librte_eal/common/eal_common_mempool.c b/lib/librte_eal/common/eal_common_mempool.c new file mode 100644 index 0000000..1d10a75 --- /dev/null +++ b/lib/librte_eal/common/eal_common_mempool.c @@ -0,0 +1,50 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright 2018 NXP + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#include "eal_private.h" +#include "eal_internal_cfg.h" + +/* init mempool ops */ +int +rte_eal_mempool_ops_config(void) +{ + RTE_LOG(DEBUG, EAL, "Configuring user mempool ops name...\n"); + + /* secondary processes don't need to initialise anything */ + if (rte_eal_process_type() == RTE_PROC_SECONDARY) + return 0; + + if (internal_config.user_mbuf_pool_ops_name) { + const struct rte_memzone *mz; + + mz = rte_memzone_lookup("mbuf_user_pool_ops"); + if (mz == NULL) { + mz = rte_memzone_reserve("mbuf_user_pool_ops", + 32, SOCKET_ID_ANY, 0); + if (mz == NULL) + return -rte_errno; + } + + strncpy(mz->addr, internal_config.user_mbuf_pool_ops_name, + strlen(internal_config.user_mbuf_pool_ops_name)); + } + + return 0; +} diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 0b28770..76beaff 100644 --- a/lib/librte_eal/common/eal_private.h +++ b/lib/librte_eal/common/eal_private.h @@ -205,4 +205,16 @@ struct rte_bus *rte_bus_find_by_device_name(const char *str); int rte_mp_channel_init(void); +/** + * Mempool ops configuration + * + * This function is private to EAL. + * + * Set the user defined mempool ops in the named memzone area. + * + * @return + * 0 on success, negative on error + */ +int rte_eal_mempool_ops_config(void); + #endif /* _EAL_PRIVATE_H_ */ diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index 82b8910..3c6125b 100644 --- a/lib/librte_eal/common/meson.build +++ b/lib/librte_eal/common/meson.build @@ -16,6 +16,7 @@ common_sources = files( 'eal_common_lcore.c', 'eal_common_log.c', 'eal_common_memory.c', + 'eal_common_mempool.c', 'eal_common_memzone.c', 'eal_common_options.c', 'eal_common_proc.c', diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile index 7e5bbe8..83a08b0 100644 --- a/lib/librte_eal/linuxapp/eal/Makefile +++ b/lib/librte_eal/linuxapp/eal/Makefile @@ -46,6 +46,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_alarm.c SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_common_lcore.c SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_common_timer.c SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_common_memzone.c +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_common_mempool.c SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_common_log.c SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_common_launch.c SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal_common_memory.c diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 451fdaf..42a79d1 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -877,6 +877,11 @@ rte_eal_init(int argc, char **argv) return -1; } + if (rte_eal_mempool_ops_config() < 0) { + rte_eal_init_alert("Cannot config user Mempool Ops\n"); + return -1; + } + eal_check_mem_on_local_socket(); eal_thread_init_master(rte_config.master_lcore); From patchwork Fri Feb 2 08:03:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 126619 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp406191ljc; Fri, 2 Feb 2018 00:05:09 -0800 (PST) X-Google-Smtp-Source: AH8x227DAnSLvrK8N3Vtlw+mFkWQhbWp3i4Ty0/Ov8pZxWVsZIosmRNWTYfLS7q4RaqcdRo4s+vM X-Received: by 10.28.138.85 with SMTP id m82mr18196046wmd.56.1517558709880; Fri, 02 Feb 2018 00:05:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517558709; cv=none; d=google.com; s=arc-20160816; b=dfxFkEicpR1cY5E7s6dW3ue0OKCGLoiUyz7eG8XqZ1OlUaskSS7uxFxSjSruCplB+5 ki7mk2xJ1sqxpHinLUAABQcoZRwnvJ1aW5F2nolj6/N9wSCguj3++H07SlULdh+eFNZh dE9BAJG2LoLAGWpBjF5yE0hi0qforx4RIYGffxYEWQiPYLQxTZkgNETtLxwU+l6Xi+eH TfmBFwHhUZtTJATgx2bpevWsl/uxa111lwrtzU6CLYf+UiMPhvMe6XJMAsNaLOpIBCe9 bzWDcXQf4X8V0MDA3dTSW0mQpLoECW9zOEpF1rzcOr1mQwQ1xkTFgLGXYUH1Oc6+5JJC pTVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=JXkrfdoL9LXM77ACXKo+SYNAn7tWf1l6EOM/QlQDi1M=; b=OEPTbFLCSzySPXLjN8BoMiMVMFzeGUUGiBsBJMa2+OGDtFPYPQR5/xon3W0APZOHrW T/9AmhigUqSCtnm1RdHqnIYP09gbXVjeRrOFKwHCoEj6vZr0NjIsP0mVUMRMjPsPY0Ay JBenXEQMxv0yTBdJSKdLCW3IxnkpMh8efh0q8dpSA4dCXjYdpTPnR9Q4jTERIyXJI8bb tlQWF79TSXRfUdYrVijQuC5ROa3J7++LzYykzcZGmo16X/7qSkGObaQA0uKOSqAKeLqH Nre/2znAQS+IXXWQkRHRXzQj+rc42Ww2jHgISI4kpBlTQg94+pUYEQDEn2BgO6jsq/g9 YB1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=OafISt5Q; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id e128si757267wmg.160.2018.02.02.00.05.09; Fri, 02 Feb 2018 00:05:09 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=OafISt5Q; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 569081B171; Fri, 2 Feb 2018 09:04:49 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0062.outbound.protection.outlook.com [104.47.2.62]) by dpdk.org (Postfix) with ESMTP id A8F29A48D for ; Fri, 2 Feb 2018 09:04:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JXkrfdoL9LXM77ACXKo+SYNAn7tWf1l6EOM/QlQDi1M=; b=OafISt5Q49y4hgBI01ft5UM8pbwPLNDupsBFS3oImptm1VTI4ZLUpwznblIwbsXjaGgq2+ya4K1L+ZEUMNzOCCjn4DIJFh0T4fJXUJhDyy/1cQxrgZ5TmVDw1XJyWFtVx6DOJeJYS503IfCJly2faCcyZe5jAo9NwWTX9PwmVjc= Received: from bf-netperf1.ap.freescale.net (192.88.169.1) by DB4PR04MB0768.eurprd04.prod.outlook.com (2a01:111:e400:984d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 2 Feb 2018 08:04:41 +0000 From: Hemant Agrawal To: olivier.matz@6wind.com, thomas@monjalon.net, pbhagavatula@caviumnetworks.com Cc: nipun.gupta@nxp.com, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org, Hemant Agrawal Date: Fri, 2 Feb 2018 13:33:02 +0530 Message-Id: <1517558582-27108-3-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com> References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: SG2PR06CA0087.apcprd06.prod.outlook.com (2603:1096:3:14::13) To DB4PR04MB0768.eurprd04.prod.outlook.com (2a01:111:e400:984d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2dbcb2c2-ca9b-40e1-5f47-08d56a139e8b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB4PR04MB0768; X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0768; 3:pdtm/Qye9JvHIkiVmSWCtMjiQyBvNHkSW6rF2rSrkF0LlrhGOF6fNEXb9ncKzwJIrNeOVGMSM0gGT0ijaCK2Ano9fv78K9zUqzZNtWhfdXlLrRdXBISFYHUP52u/wq2nmfSqCvp1jJPbt5vHLwbsN7dHqIG92SnSzGFerd10TdxUZEAABMSvVe7jg6knfu0q4wkAs3ZIyvmjRKEYtlEhkqDpP9ozgLIzISDgmMEKulTfOmmNA7QEwf3e+/2/dM3a; 25:fP6vDZKMeknPkSBf0qq08QGpAnmKQ2kERjAWR6nsFl01+RDUaMGKvuB+mUH8dOxkkFQAKuev3rXGrDjLa6gTJCcUevh8gASxBg8h2SphxRNF6jlCLeWg4rN0LzWZVkF07poHyN2cSfYkWGsZ6pMhZgHLOjHVnlthOpGL5IqYw6Aq+dKNEcA4uxs0HpRa6FLSzZd/qC8A/DKl5tQOlEuFQH8A0Spt8QGaW3BYk01ihq4lG23hybvVuiTy+SKTvvxQ1jr6ufI0xWiCAQMHOApk4WXdwDCInUJ9WXEvZiKoycuIFKz+ioFzejR/2AMtsw4MvgjoQzLbXtkE2MQkiRuEMg==; 31:aXHR+GCd47ksz41Rg4RKqQez84G8YK6M1CYuiuWU7WhFK3o3woshXCEWQlkjKGozqpcZKme5Y7x/JaziTeWjtaRNiUOczleIe+8K3XbudWiRCJoW4m+fjjgca0p3lv4FfQkNXfCOMDAsJ1o9hKAJVzUlhDsrVSj8hdT2810LpsjIHQwLOanI28bLeBCdpdE5dgkENlhD2wiRa4Q43NGwquUtmpqnCIIvc1WRhVUSDrQ= X-MS-TrafficTypeDiagnostic: DB4PR04MB0768: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0768; 20:HKH4How2fvpVsFZYs3vdQVBr6u8U17ShbpbZleifsko2RkZn5WD7+V+5oZq3MINWsUWCNhZOyfnSYT7LbOOBi7ZyTbJuG9NC2LMkHf7QLbwnUnNjDis3J9eKXK48eEiwFx0mtSw8dR5ihUHD7ShnY9d7D7luGZqJfZYEbFRZL8XVoccJPUnhfQ07duqwBXiXh2YtH/Mf2QYFidxjB8le1XkDRR0b1OoITyOzSjz7myEUscuUhNQd+mf1hgVuYVzZVt8bxBLuu+Xwi2fbCKlIeEqIonXWNgofdKeHxY/Ps//Gv+J0+V4eIcl8sDdD4e+oGCkMp8lxB3bMSfjw6u1dWtY2gPFrQjg7vRKUkABldrIKjl7HLPVJElnHmaM5ity0QUheeerPN3FiwARUogrGtH/cbbcCAaziVKeNjDLD0/z/GaKnO8UKIBSWqwXvs+RAsG4n76lWVgJrmbmEun/3q9jR6+Ab8mDiiol5ti3sJsXRQ6+R7AT1xJAQtV78yBCj; 4:DsNseaKMzQcBA5D4GkEezVkUjZRD4/UqGyr9f0CieaQHsRNjQ7zKxp4n/RqoqNvcwafEe5hlM8KKkhcJlJtcQYFrKYVugbOrnUPCNiWKvD+iwWzCXIHVreoV2ZSk83IMPYnMfewypkQlK1CQSvEQk+VhxsL8wHN+OM1gf+4AIgcIJ6+cFKDCilc1q67kIqc1qF/TJLBgyCDO/a9Fq/exLDHzrka4cg4A8v1JjZX1la7+68iiEWhBH143cieKLlzFGFZV7Kd6E35Kuqruk6rkIphHHWqIgBiPfsjhrAZvW838KQhkYJ/Dd/L2Um+wxlER X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231101)(2400082)(944501161)(10201501046)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:DB4PR04MB0768; BCL:0; PCL:0; RULEID:; SRVR:DB4PR04MB0768; X-Forefront-PRVS: 05715BE7FD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(39860400002)(346002)(366004)(396003)(189003)(199004)(6512007)(6486002)(53936002)(478600001)(305945005)(316002)(16586007)(50226002)(25786009)(386003)(59450400001)(106356001)(6506007)(8676002)(51416003)(81156014)(52116002)(81166006)(105586002)(6116002)(3846002)(5660300001)(4326008)(2950100002)(76176011)(2906002)(8936002)(6666003)(36756003)(66066001)(48376002)(68736007)(86362001)(97736004)(47776003)(186003)(16526019)(7736002)(26005)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR04MB0768; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR04MB0768; 23:1tkyGLYJHGGEbXxAZOas00bOQBiK8f1Md1/24rDi/?= SaWOLO9yCvwA1kyPwHLEL1KE4+lQZZhcTuqpUQYxi+L7YcyK5j36JY0PFp1aSWDFKf+n61WSqyhnNwKuqhJiPEAJnXDG2g1Qcxr2Lh7sQMXPWcKPKU31Pc5cBcyxxLJjy5W1ZmQXsdH2B12OXda3c7m0oBUI6X+WTiE73GE6iLiCb2rkAYLWbg3MjCWRR+B3DMMKBCIIg3gSfX8yZVHANR+ibx26TVcnmBwXOyveGPY3iRB91Cb9oVYrFiKGB4ZnXwe//p3ujvn1fuAwGmRFZLhvHF4DgkaBnfoD3ihH9wRpZKvgvCjP4dympKIKZbCq1MceR17IiCSV+8w71BJvWjsl0Ody6HrbmRhucFPgoduQwnpRiMPpm4fCE7ugV9ZG7zJc/EmqWiUXfvfQzUz+GdobNbJQ2Zq90LZmCe+5QGzs12cHEsC+CiTE5vSXGxMadoJXi3D14LBz1P9s3oY/9F0+uRlq+harOnVfct11Wk0KmeAwq8J/WRddOPtF0bULtv57dUJH/cBFvAX5HxWXcA73dSiFOcw2ou/qP68VXztoSrnt51WrpQlXjRZwMDCLb5PEijbQqUegN1Hqu3/zSA5xVW9GH/G/zCHbqFQquPJnDBew2lecu+56LUHb08fBZHHNtmpU1vgUQ9ByqZ0XzZ/jVF6e7NLSIAi0mEM4lD5H506Od4Gtz8Z9yKip/2WnjDES4cZcGj2hmWdXVwvxMybL3BaE1ityyHsfs4OiZ6SlligDi3HkJgmvkyv1jsFeAHLDjryiFyZN3Em8vGgcVzeJg62VOr3WqmUW39YdBy9T6YVrm4JQYDxMJIBKRUfa0MyCL7hmw4SZjLBrY4LP0YglE5sLiLwKHYhJFiEjkhQ8ZZHsyOfVN1dr6nFkymEOqybE5eJOBq744p4xxNU5dNbrwgMqCfatdBYbHtHCevQqINsnkxNoqmqix5hyK08WBODrVjpqZwUWlQ2cHzkOKgGJbQvFtbQ6MoUvHRrVTa7RJP8eFzCUXvuoDh+hsd8iOccLo3WIVP741Ig/hJgIBdg1FOmFAS4cZiZYwxVOomIQQ== X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0768; 6:+CZnveBI+uAtaZ1N0iKbr+aK3VIr2PBjra2C/nyGpZmWYcn+yvmypr4NLJ+dJpyhJGxS3/lY6BvJxsWCQH+es75Xfc1FgLxoSvVgPEh+LWuOP5FBRDmHIENm4hsW9UgIeY3JnbwHRgNodXtZSm8gNIEdX3VMHInvw3QITUBRT6hp+ov96q7h77VSXaQ0FQJoakz2JsODa2uw1sIxYmnGYHMoqcK7RhaXQyZPEnF4o2sL7Lgw+e1+4uEHdEevzrkcvd4gx69gHwUMehUulpbc55R3PSsfWoVLWhgkW+IvNyn9vD6L/AXCDXhMilqqrSDbO+0A1U8gomoeTHcHUjrtH1yJLe8r/irOPi63nVmYHcU=; 5:Jsn0b4bp3GVgVgsZgK33xrl0z2ETg0ESGcofrJDGyqxjGG2ad41EYJQ0QqO6EpF7zxqscsnbVRpqSz5UKs6LJmAIv6Hb679MDLB8+LGQ8/flFqoroxr7HwrHebw7rJSifYnag14QpC93/AOIOIafS7beyeC20nDVBAnSXCV3X9A=; 24:9ByM5Wzwp+x90GhvAlzmuz9HhTjrmnH7oZzZF49e/5XYHFYg4u4l6hOYs06UWFjoub3I/bWTwwbnS5dahnRRGxvxeCG2TCweCsdU/2MyAbA=; 7:f9kWaZ8WCS8ytTuONKGmJ7N/EHc8DLe7/Y9hFagwiv1YqHZ5kAxu8vn04bWm3PUUTOHeU/2KwD50bva1MGU1TzOw3fXtRprbuZwtZR5zIPgwOP7TRJCDtow1Nu/GHu5czZ//Fu6WDk9wlcn3lxuYtcxC9/qbga2+diXSsagYCUAH0fzaAmH1ivmFtYoXWwRLSao047rtH3GCO07QU5mZNd51fwIqIzaHIQMXsKDqXOnyrmgJDr6klJxneVeA1pfh SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2018 08:04:41.2305 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2dbcb2c2-ca9b-40e1-5f47-08d56a139e8b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0768 Subject: [dpdk-dev] [PATCH FIX-OPTION-2 2/2] mbuf: fix user mempool ops get to use only named memzone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The eal default mempool ops API can also return the compile time default mempool ops name, which can break the best mempool ops name logic. Fixes: a3acc3144a76 ("mbuf: add pool ops selection functions") Signed-off-by: Hemant Agrawal --- lib/librte_mbuf/rte_mbuf_pool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf/rte_mbuf_pool_ops.c index 385fc43..a636c28 100644 --- a/lib/librte_mbuf/rte_mbuf_pool_ops.c +++ b/lib/librte_mbuf/rte_mbuf_pool_ops.c @@ -74,7 +74,7 @@ rte_mbuf_user_mempool_ops(void) mz = rte_memzone_lookup("mbuf_user_pool_ops"); if (mz == NULL) - return rte_eal_mbuf_default_mempool_ops(); + return NULL; return mz->addr; }