From patchwork Sun Feb 11 20:39:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 127909 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp2610145ljc; Sun, 11 Feb 2018 12:41:32 -0800 (PST) X-Google-Smtp-Source: AH8x22541+nT4wX9pB4DP8nu0oPXPTuKmo+eQFBvVtUEZ5uUNHp8cz/zQeBqTHb4JAE7lRdfddKC X-Received: by 10.129.172.103 with SMTP id z39mr6410983ywj.345.1518381692722; Sun, 11 Feb 2018 12:41:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518381692; cv=none; d=google.com; s=arc-20160816; b=iCullQmg/wT863v/9Iu3hjxtNNp2LQRo5tZ0QaS9BG3siZRq2s23P3R8hcjLRCnLFY fd82SL4py5MQlchPa3XxnCz+Ponwp6xyO7XK4z7qUEKjdlFhU8cd2nPwA5EO/agjyJV5 Nzujs6ugAq2442D4JylHjb4rBJVKKOSav+LjujNZHCvWBgrW4kU0QofYMHUqa68TtyBs QRyfQMBIfjW1ipRhNAPgqx6CsWC5J0BeyiYSdFqa9gGrajEZZhmyQnZtIqBBbLYnxIlV bpwEUxod8bqszuQwIBEkMZSb4XZB/Wgo7sUon//QAlsrxzgvLtR1xxtIepcIwfMsxa4I fiqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=ycZUtBp55BeNhkkhqyH7cl+WKldgPD+nTd1Yis4qdpg=; b=Fv2YJ5r4G0KjnhNCw2ADVEullPGYmSLTTMgNtVaxycXwOGPTHYUd0EIf1mt0oixJ3J NfWUH7j4Pi1YhOU7r7d/QNucZvxXcDhTMymlm39LtykYhgdMrOOW7XGtArRY3PNzwhmQ tHzd7s+Z0N75bzOb0VJ4xP6vfT6GlPE8zeM6NFGFK+2XKv2kKtRb+DyKbEL3nJVisUzY 3JcwDLAtMZjQXrhjoQFXohYR/Ho5Yo8W56SLgNvVH4iPdS6MaXQuaQkufU6g5HKG3ufw IJOYXPseExl1OG5wEJm3WUEuAVFzq6fyvx42crTBukkdJxAT4EWtEizqPNlbaq0F41OI x7rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=azRV4byy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id k123si1288097yba.50.2018.02.11.12.41.32 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 11 Feb 2018 12:41:32 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=azRV4byy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53253 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekyRI-0005mr-4W for patch@linaro.org; Sun, 11 Feb 2018 15:41:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekyPY-00058u-29 for qemu-devel@nongnu.org; Sun, 11 Feb 2018 15:39:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekyPS-0006YA-Mi for qemu-devel@nongnu.org; Sun, 11 Feb 2018 15:39:44 -0500 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:41461) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekyPS-0006XH-Hd for qemu-devel@nongnu.org; Sun, 11 Feb 2018 15:39:38 -0500 Received: by mail-pl0-x242.google.com with SMTP id k8so4044676pli.8 for ; Sun, 11 Feb 2018 12:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=ycZUtBp55BeNhkkhqyH7cl+WKldgPD+nTd1Yis4qdpg=; b=azRV4byyjMxqR0fV+WHkEIuAq3w9FrGvBHokU3sb4nvAcRwdYBDYk6f8HxRVB86rld I82k00bRiPqk6y2bFHYlf58KiSL2qM9jajN8J5rAPreKzH3JGuFMx9ich4nh7L9XFOzg A/8V/pvElNUZvA08z1B10uFeR8aV5OPbCfi5M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=ycZUtBp55BeNhkkhqyH7cl+WKldgPD+nTd1Yis4qdpg=; b=d1DGV8Z+hFH63tr7G2nUQQ/mIZiYGz+xNJelOxODjoF6ZTWW1pak1zyD9V80DXc5Xx I1lBtbsNWnn/PE9V7g/oYIweo2m8drxdVIqtMJk5MudTbjpJSz3kqT2Lh03asY6OfLnp DnspHSitInVCxJ6krgqu1uM02VRSg34YsqDW4LRE2tVuHkVyQiX5rqWZM7hJD/db9roK SJ/N4ipYxiLq2P5txlRMGUEB6JOuWhLg4u/mCzVu/j76TMtYLCZA+OKcLPwEJqE8xpZr UcDwKr8AnrDfidszEU+5ikzEgAgWdDSrqYVFDEw5sa45ATY9KLlu/MRk3EwXYnvNQ9H2 KiFA== X-Gm-Message-State: APf1xPDq5pR/vLUfdctrNhrG8M6/glPc0aa3Vz+cqM2aKtB5b6NNecyZ TynG4G4nFE+OCsswgLXSX+UDOCUs72M= X-Received: by 2002:a17:902:595d:: with SMTP id e29-v6mr4370934plj.189.1518381577043; Sun, 11 Feb 2018 12:39:37 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id 10sm2327640pfo.69.2018.02.11.12.39.35 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Feb 2018 12:39:36 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 11 Feb 2018 12:39:34 -0800 Message-Id: <20180211203934.15546-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PATCH] tcg: Improve tcg_gen_muli_i32/i64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Convert multiplication by power of two to left shift. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) -- 2.14.3 Reviewed-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 3467787323..34b96d68f3 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -277,9 +277,15 @@ void tcg_gen_setcondi_i32(TCGCond cond, TCGv_i32 ret, void tcg_gen_muli_i32(TCGv_i32 ret, TCGv_i32 arg1, int32_t arg2) { - TCGv_i32 t0 = tcg_const_i32(arg2); - tcg_gen_mul_i32(ret, arg1, t0); - tcg_temp_free_i32(t0); + if (arg2 == 0) { + tcg_gen_movi_i32(ret, 0); + } else if (is_power_of_2(arg2)) { + tcg_gen_shli_i32(ret, arg1, ctz32(arg2)); + } else { + TCGv_i32 t0 = tcg_const_i32(arg2); + tcg_gen_mul_i32(ret, arg1, t0); + tcg_temp_free_i32(t0); + } } void tcg_gen_div_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2) @@ -1430,9 +1436,15 @@ void tcg_gen_setcondi_i64(TCGCond cond, TCGv_i64 ret, void tcg_gen_muli_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2) { - TCGv_i64 t0 = tcg_const_i64(arg2); - tcg_gen_mul_i64(ret, arg1, t0); - tcg_temp_free_i64(t0); + if (arg2 == 0) { + tcg_gen_movi_i64(ret, 0); + } else if (is_power_of_2(arg2)) { + tcg_gen_shli_i64(ret, arg1, ctz64(arg2)); + } else { + TCGv_i64 t0 = tcg_const_i64(arg2); + tcg_gen_mul_i64(ret, arg1, t0); + tcg_temp_free_i64(t0); + } } void tcg_gen_div_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2)