From patchwork Thu Feb 22 11:47:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 129221 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp1906480edc; Thu, 22 Feb 2018 03:48:19 -0800 (PST) X-Google-Smtp-Source: AH8x224uudggOb3XZDRmDUtb7kn6kvl7xn+CauWERr1nfyCaCTYZCpB/qDjrJVkQ+WprZq+XODvL X-Received: by 10.101.98.201 with SMTP id m9mr5431803pgv.100.1519300099344; Thu, 22 Feb 2018 03:48:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519300099; cv=none; d=google.com; s=arc-20160816; b=BavFLJjHXGjAkxfrXs7VbZcihqvxBhR3EkAnv2XSrPEmmK6vxTyFxWUUgWWnAZ9u/1 hmUBGlxxMdeMtS+3Pyd+xwcp5CTfHK+mBTGW1YX9tlcah8qt1rKZphX72YEXejFYcc77 1/SbdCbzjSWPiXn+L55eb81oFb36BEDXcToR1Q9SSY7JUzD2bu8UQwsowIxDMIi+6kvB IOwlw7PjzaNa6G7/wc318a+UPapCDtbdIvBboUbHL4d3WZ/ijVTvhHD7CiiyBPU+rQLK M0nsF6S+dt3ijMbGSRV9ZjfjmYQRVygyfIGhxaSd3FGzc24hoXBivN+HPOJ1OIZxf49Y qk9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:delivered-to :arc-authentication-results; bh=HeCU0xHdSzFHI2PWiJmyLelnanqoxesZbAY72V7DOEo=; b=R/T2RKAacLeiYueRGCPTHx5gKSRHYidE5zS5fypfI3HO3oVl2rw/+K4ZfqRQ28HdL/ 4igNgHlD1gbVFrYzr5d5mSr9IP2pxPup0f+EXsz7b8SaT8LZQNQdvLMflPnPg4w3ykO0 0byPZ6RP1R4mKIWxWihAN3lK5rKxFu2C1A0SkaIDMAV7TsV88KP+7vqyyakwkC/WOXlD TBv8CUkJlnKyqhY4UYjff0v5V5MKoznoXN2fxmGHd5RIr3f5OsL+cn3yx6DnlTDo3jtr lpYqep7SGXYY0PL0VSjdyTDE8kqXfJX7/Cr7LQ2bPbGO9d3BailHyFsNeF7y0xS0EYN/ z+QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id g3-v6si2679429plo.266.2018.02.22.03.48.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Feb 2018 03:48:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C0AC6ED59; Thu, 22 Feb 2018 11:48:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA25D6ED59 for ; Thu, 22 Feb 2018 11:48:15 +0000 (UTC) Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0MPKwG-1etFCQ2U2i-004UoO; Thu, 22 Feb 2018 12:48:06 +0100 From: Arnd Bergmann To: Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie Subject: [PATCH] drm: fix drm_get_max_iomem type mismatch Date: Thu, 22 Feb 2018 12:47:51 +0100 Message-Id: <20180222114804.1394300-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:dQbMdoy6l01x5BYi/1a3Eg9r5f5pXaHyIKXwxQLBzmGEO1OgDDg jgafhRtHgknWg9gUKahTxay6u5a+wi737Z08YdO9Zo2CpDSzBJZwW+GE8bOw7zJMQQKsigH DKg/1YO2aH9FGCAU3FF4+5b8KK+NEc4G8jKbpfAIdai0QKCrOe8jx1fBmf+W55cSZuHds95 ZBxJX6tcN7IwHuFqbxefQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:kthamrG6Y4s=:6Tq3+lk+2HikqJJmthMYf6 KLxc5PAoa2Bq6SKAq5wzUp1DHuy4EogIUAtU28ouUpnZkMFM7lOQZeP+Jj+bdiAy1G4gOALCD BCiI/fXbffgwmZfnWmJb/L6udfYJHfH5PdphZ+a86/mTNWA3G3+chzkKGbG5Ue+hzx/PjGQuE /Zn3WIFjD++yOzubw9nj/95D6lZg/kxAWDqDKkmuubb+Vd98Ezk8+WdH8uBo4T4/Mmeo+O/FH Tldm6LaOysMAC7qLEWHzZYUaNm2XHqV1C8ygnht/exgRmrNYRAWNvBvvsoRg6pUgHKlU35apL YtEV7nHZHcRf8QKWn3ubKbOljgd/TvYw3kVjsF4++Xb+UqzC5U2Nz5SjgH+wJJtAhnQ0N48Zc tAmBDqaXmBKq4dobj5E9GVPDINgEbLkh6+SHSQcjlxzONvkV3cnV1mFUghvRMnPsOJwmJEhLM 6P01Bm4HoSBkZZWe67tckM9S0xzsPv7V7lNW7UwswKk8vuCu6IrNqkeiNsdTeSuHqz7DSKd9m QOfoTJZrrXfCrfIp2IqXEDVjxD0BiDTe2paJ/SGc3c0AqFIu5vMW4VDaVcMZucYGluN3lnvfb nu8z1t5s5c6UqhXlfiu+4PoF9YzpCNAMAJYWqdEjTQXcNppTLo4Xfe5eAjrEFb4tOJpYWbM18 DM2arKb/RDcHDi+9bwhrnWJZ4WNR8rf1v44GMTEI1TZTmw/3rPNCIbSDbTj2owt6IhOD7JqWG OcMsIxnKQW4fEwgzM85xmMecPmrAc2RfZilVwA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , =?utf-8?q?Michel_D=C3=A4nzer?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Monk Liu MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When comparing two variables with min()/max(), they should be the same type: drivers/gpu/drm/drm_memory.c: In function 'drm_get_max_iomem': include/linux/kernel.h:821:16: error: comparison of distinct pointer types lacks a cast [-Werror] (void) (&max1 == &max2); This makes the local variable in drm_get_max_iomem make the type from resource->end. Fixes: 82626363a217 ("drm: add func to get max iomem address v2") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/drm_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 7ca500b8c399..3c54044214db 100644 --- a/drivers/gpu/drm/drm_memory.c +++ b/drivers/gpu/drm/drm_memory.c @@ -153,7 +153,7 @@ EXPORT_SYMBOL(drm_legacy_ioremapfree); u64 drm_get_max_iomem(void) { struct resource *tmp; - u64 max_iomem = 0; + resource_size_t max_iomem = 0; for (tmp = iomem_resource.child; tmp; tmp = tmp->sibling) { max_iomem = max(max_iomem, tmp->end);