From patchwork Tue Jan 12 12:20:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 362485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67162C433E9 for ; Tue, 12 Jan 2021 12:21:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38781206F0 for ; Tue, 12 Jan 2021 12:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733157AbhALMVm (ORCPT ); Tue, 12 Jan 2021 07:21:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733149AbhALMVl (ORCPT ); Tue, 12 Jan 2021 07:21:41 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86B22C0617A4 for ; Tue, 12 Jan 2021 04:21:00 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id n16so1654272wmc.0 for ; Tue, 12 Jan 2021 04:21:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/Rzk+swL9LZYWZko+QtKhi5Rri9B0SSm8XtV+Vf437I=; b=Y9oMiDuzthHTSZ8eAcaT7QuLKRp6GNwiyJzgN9phobZXe46OpbKvgsZnxmxmk5x4SE FCRDjzFrjOWVpRywOjjZJ7AYIJYxM7P6znn8dQkGwRfUMBUXk4aq42RLZI/5SQ/Rky6n UPlGj0MEkXeXn+BrrNgr8tl5H59c82GoYTC/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/Rzk+swL9LZYWZko+QtKhi5Rri9B0SSm8XtV+Vf437I=; b=nb+oF1r2lfqCoWtXBXMxMv4QR0jcVOSnOL8aL95i4ZUQTNEKiWMLPMLH+quK204lMG rFywAF9Lek36nHYIGPN4Kzj4GNSoz3O2UhsnkUOPuKaRMfEzVefv1rU06X4SGSL8Z3n7 E2otPf+n0jqzEsXq6o7QHoaskem0gNLPYD7LKEkdf7AZBmwd6jK0rrXWLkCF/HigP+EG NZF6PNcRUazIpLjS+Di7nuLdPRWXTCQCkoJP8/L0azzWijx0unMlGorx8phvX7YZj2Kv OAfljo6ytpg4UP6c/3NnOoQ+xMethI6AW7pcC7uajASztqH3TYRwbQmOD2lczIlv290u g+eA== X-Gm-Message-State: AOAM530Dgq2xgcW0yu4TjBiHl/AHzoTRw78teYR1Q65fK3Mtnn0zYaNW UKZKXV7KmRfS0pV+n0xkVyOvU8mfygNA2oGPiXo= X-Google-Smtp-Source: ABdhPJyytXSFm1dlMpLHYNOcsyNbhRFHcm0IF1nrOYw1yfZ8jTu/aBFjzggb3JVwdR1HZmVLyJLq1g== X-Received: by 2002:a1c:4e19:: with SMTP id g25mr3313349wmh.93.1610454059206; Tue, 12 Jan 2021 04:20:59 -0800 (PST) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id w189sm3781384wmg.31.2021.01.12.04.20.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 04:20:58 -0800 (PST) From: Ricardo Ribalda To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com, Ezequiel Garcia Cc: Ricardo Ribalda , Matthias Brugger Subject: [PATCH v2 3/9] media: mtk-vcodec: Do not zero reserved fields Date: Tue, 12 Jan 2021 13:20:53 +0100 Message-Id: <20210112122053.10372-2-ribalda@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog In-Reply-To: <20210112122053.10372-1-ribalda@chromium.org> References: <20210112122053.10372-1-ribalda@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Core code already clears reserved fields of struct v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields"). Cc: Matthias Brugger Reviewed-by: Kieran Bingham Signed-off-by: Ricardo Ribalda --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 ----- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 9 --------- 2 files changed, 14 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c index c768a587a944..d746c41ea805 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c @@ -715,12 +715,7 @@ static int vidioc_try_fmt(struct v4l2_format *f, } } - for (i = 0; i < pix_fmt_mp->num_planes; i++) - memset(&(pix_fmt_mp->plane_fmt[i].reserved[0]), 0x0, - sizeof(pix_fmt_mp->plane_fmt[0].reserved)); - pix_fmt_mp->flags = 0; - memset(&pix_fmt_mp->reserved, 0x0, sizeof(pix_fmt_mp->reserved)); return 0; } diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c index 21de1431cfcb..cb31556bcdf7 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c @@ -121,7 +121,6 @@ static int vidioc_enum_fmt(struct v4l2_fmtdesc *f, return -EINVAL; f->pixelformat = formats[f->index].fourcc; - memset(f->reserved, 0, sizeof(f->reserved)); return 0; } @@ -320,13 +319,7 @@ static int vidioc_try_fmt(struct v4l2_format *f, } } - for (i = 0; i < pix_fmt_mp->num_planes; i++) - memset(&(pix_fmt_mp->plane_fmt[i].reserved[0]), 0x0, - sizeof(pix_fmt_mp->plane_fmt[0].reserved)); - pix_fmt_mp->flags = 0; - memset(&pix_fmt_mp->reserved, 0x0, - sizeof(pix_fmt_mp->reserved)); return 0; } @@ -532,8 +525,6 @@ static int vidioc_venc_g_fmt(struct file *file, void *priv, for (i = 0; i < pix->num_planes; i++) { pix->plane_fmt[i].bytesperline = q_data->bytesperline[i]; pix->plane_fmt[i].sizeimage = q_data->sizeimage[i]; - memset(&(pix->plane_fmt[i].reserved[0]), 0x0, - sizeof(pix->plane_fmt[i].reserved)); } pix->flags = 0; From patchwork Tue Jan 12 12:20:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 361494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE338C4332B for ; Tue, 12 Jan 2021 12:21:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CF322311E for ; Tue, 12 Jan 2021 12:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733124AbhALMVk (ORCPT ); Tue, 12 Jan 2021 07:21:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730609AbhALMVk (ORCPT ); Tue, 12 Jan 2021 07:21:40 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9914BC0617A2 for ; Tue, 12 Jan 2021 04:20:59 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id y23so1936397wmi.1 for ; Tue, 12 Jan 2021 04:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MbuUq4P3EHTaRZRZIMbCktw9khedoDm+hM+zJy1KsqI=; b=LhTgig3W3sY07dXxslzsfjFFIfbXnY40C8dWqKXdoxjaCsPK6Sxr2e7t/oPOPZPYHs 1eQoNC/fomQriaKt2PO/gTKRdDmMUUQiU7zqiqNWSzRgRVB7LXj+orqSFahMBEglKJCA NUFevB0PHOengYR/AUjkRLCQ40QEEWx7YblPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MbuUq4P3EHTaRZRZIMbCktw9khedoDm+hM+zJy1KsqI=; b=ZHzakkvPlxKvHefKXxoeSX9rwH3mWuZWoKE9kz2ec4vGx1hYGWzOTAIhYeOLqRX8Pd DdnBQd4BpacRuXA5xwOqZ2/aQQkk3776X6lrKa1FaOKTM11DKDRJKN5aSR7AZ9DiVj8a YHksnQmhkOpIM/preGaDpUZVJPpA8xVsrW9xCjhIQO6FN6oxLoGS0yY0gYPzZmof72aA 8N/I8TaqV8ZJOAeJ7FI6AHiVKXf0XXIZ2gbcz3FuIOdXuuwHlpLwRVPs4TxpkdATR/1S BAzs7eA7KTVVrAQJWexdgOf+j7MYBFfLhXodJP/XNx1u1cUi06VzOI2JfO4ymoBmnfWV nP1w== X-Gm-Message-State: AOAM531r0qXY2PVd83/QNoT0eAWHYZb3aUKxHXkYOZbM0+qAxEF+cd1L eHOCYJvtuM5rJ03YSoy9CP3EJ5i4p1yKQZvH5/o= X-Google-Smtp-Source: ABdhPJyIhFnoExJgUM6FYKub4zkfWO30jYVL5KHqYAuyL6Hn09FJ/56mq3n40ebrt+ImoKxV+BRInQ== X-Received: by 2002:a1c:7217:: with SMTP id n23mr3243366wmc.167.1610454058331; Tue, 12 Jan 2021 04:20:58 -0800 (PST) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id w189sm3781384wmg.31.2021.01.12.04.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 04:20:57 -0800 (PST) From: Ricardo Ribalda To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com, Ezequiel Garcia Cc: Ricardo Ribalda , Maxime Ripard , Chen-Yu Tsai Subject: [PATCH v2 6/9] media: sun4i-csi: Do not zero reserved fields Date: Tue, 12 Jan 2021 13:20:52 +0100 Message-Id: <20210112122053.10372-1-ribalda@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Core code already clears reserved fields of struct v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields"). Cc: Maxime Ripard Cc: Chen-Yu Tsai Reviewed-by: Kieran Bingham Signed-off-by: Ricardo Ribalda --- drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c index 1a2f65d83a6c..4785faddf630 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c @@ -113,8 +113,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi, pix->num_planes = _fmt->num_planes; pix->pixelformat = _fmt->fourcc; - memset(pix->reserved, 0, sizeof(pix->reserved)); - /* Align the width and height on the subsampling */ width = ALIGN(pix->width, _fmt->hsub); height = ALIGN(pix->height, _fmt->vsub); @@ -131,8 +129,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi, bpl = pix->width / hsub * _fmt->bpp[i] / 8; pix->plane_fmt[i].bytesperline = bpl; pix->plane_fmt[i].sizeimage = bpl * pix->height / vsub; - memset(pix->plane_fmt[i].reserved, 0, - sizeof(pix->plane_fmt[i].reserved)); } }