From patchwork Thu Mar 1 19:26:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 130396 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp3189911edc; Thu, 1 Mar 2018 11:26:49 -0800 (PST) X-Google-Smtp-Source: AG47ELtV/fHiaZYuTiviGT8mAxGnaz7rH+9jUX/BcJbXkdrp9dOMeJ9q5zbrIAcUfSA++AYKo84m X-Received: by 10.223.141.150 with SMTP id o22mr2745481wrb.280.1519932409164; Thu, 01 Mar 2018 11:26:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519932409; cv=none; d=google.com; s=arc-20160816; b=YjFObUxajuHvD7CxUe/mkSQ7A5kr4ORxV4iLZ7h7P/5NoJDABanS0SR6lG0Cs0MB9f 3UhglLMvSsETxhYK40Ha5R6FO6NZ3DAiF6yz9WtL9YNJ4h7ReT+yiDrjSDLz7nnMuIAV od2Gf4O2lmSmsSZ5Jbs87VwTwWEr/Fg5T0oeyo8Tx/ltndKJgB2C0nO18+K/EWzwP33Q O7CE29PEkKbX8autlRjg5dDLKZcNPeSo3wiy0oOGQ5ulixv28DWW0PD6IR+xTbfzwUFK GzT1EqXj4qoAxoeWaVvKJBnwbK5lby9Z4Mx22m31FYr/G3syUHMhXnsJQ+YWS+HjKfHU M/oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=9XVVE5M7G/4dS4Osl2DTHQxjyG2XU8UgGXaZBCZxhEE=; b=juJkPwf31Vu7tM7PD4sWENW6l0Zkg9Tp+4b343qTdpPYn/k2QGjw/3yj7Y5nMdjdd4 po0SUCOJTFp67gdqpZIM0q4HidKwucAU3EEgetsoC6328c2KOgABJv2cFn+GYeR2/J+e RVsneQQS41E07RegOeaNqhmKaD8VI+6HEgHFjezAILwsjCHINRaXTjqZTHL/MWBQ2JNn d6T3SVCE1kinCQyBLebMSyJvIn5sbf7PI/8hFF18Iqg8jQCOSQ4+t/FkG/T75kW6B0DZ YEkg+L2vj0gSPqr2tsrhL9WVahAaeNIswjP+PYx2iriDJRQmlUxnTPKjfK3e76jdrMko ukWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Y2e7beYe; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id n14si3385047wra.431.2018.03.01.11.26.48; Thu, 01 Mar 2018 11:26:49 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Y2e7beYe; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A7ACD267BA3; Thu, 1 Mar 2018 20:26:22 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 30C0B267BA4; Thu, 1 Mar 2018 20:26:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 83743267BA3 for ; Thu, 1 Mar 2018 20:26:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=ZuIEDyRxgKn2Jdm0M+3N0NhcrdM68F/Su6M8er4uQPc=; b=Y2e7beYefh0Q 4mQd7iHJ6nYtJec/w043QyOlGdMBrQgV7uyxOv8himaOUDoUb32hNHZ9cxl2ew9mq6hyZ/MrUP27e 5AiFeAOIUHj8VEapmnL3QoC44k1f8zcp4ZxgVDiWklA46din3VmJDSIhSVyUwX9TCb/z56ybRY5HS EuQ18=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1erTqB-0005ix-9E; Thu, 01 Mar 2018 19:26:07 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1erTqA-0001VK-R3; Thu, 01 Mar 2018 19:26:06 +0000 From: Mark Brown To: Hans de Goede In-Reply-To: <20180225104713.4745-13-hdegoede@redhat.com> Message-Id: Date: Thu, 01 Mar 2018 19:26:06 +0000 Cc: Oder Chiou , alsa-devel@alsa-project.org, Pierre-Louis Bossart , Takashi Iwai , Mark Brown , Carlo Caione , Bard Liao Subject: [alsa-devel] Applied "ASoC: rt5651: Only configure LDO voltage once at boot" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rt5651: Only configure LDO voltage once at boot has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 3d7719d3cc8efe88be4c72cb7cbb0d866ed7d1b2 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Sun, 25 Feb 2018 11:46:53 +0100 Subject: [PATCH] ASoC: rt5651: Only configure LDO voltage once at boot Now that rt5651_set_bias_level(BIAS_OFF) no longer modifies the LDO voltage selection bits, there is no need to set them each time we move to standby. Instead configure them once at component-probe() time. Signed-off-by: Hans de Goede Signed-off-by: Mark Brown --- sound/soc/codecs/rt5651.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index 74f83af3b6be..9460bdcad349 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -1540,9 +1540,6 @@ static int rt5651_set_bias_level(struct snd_soc_component *component, snd_soc_component_update_bits(component, RT5651_PWR_ANLG1, RT5651_PWR_FV1 | RT5651_PWR_FV2, RT5651_PWR_FV1 | RT5651_PWR_FV2); - snd_soc_component_update_bits(component, RT5651_PWR_ANLG1, - RT5651_PWR_LDO_DVO_MASK, - RT5651_PWR_LDO_DVO_1_2V); snd_soc_component_update_bits(component, RT5651_D_MISC, 0x1, 0x1); } break; @@ -1662,6 +1659,9 @@ static int rt5651_probe(struct snd_soc_component *component) rt5651->component = component; + snd_soc_component_update_bits(component, RT5651_PWR_ANLG1, + RT5651_PWR_LDO_DVO_MASK, RT5651_PWR_LDO_DVO_1_2V); + snd_soc_component_force_bias_level(component, SND_SOC_BIAS_OFF); rt5651_apply_properties(component);