From patchwork Thu Mar 1 19:42:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 130407 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp451031lja; Thu, 1 Mar 2018 11:42:58 -0800 (PST) X-Google-Smtp-Source: AG47ELs00tkOjHiDrKb0rkmj8OOc9rxHf26rzX38BbPp8M1Lxoos9Z6Fk6OeyKJElrLe1VGs73Ez X-Received: by 10.28.228.131 with SMTP id b125mr2597487wmh.153.1519933378359; Thu, 01 Mar 2018 11:42:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519933378; cv=none; d=google.com; s=arc-20160816; b=lyVYmMPI/QFb+GWfIidBQoYKcI/2ry6OAF7b7REq5ndSRyq3CQDlHOktoUGOl32881 dDV0rZ3eTMos3RFCiLXKKxvD8QYZyX0RbnsPcYSErWXvuwuhyVYmfyR4qzi0yiF8AZEJ 93Xddy2FfWhel+d/VeFlP5KDXzd2zeE8ATScM9F6xjSplDSIj/63A2rqY51yiCQrmFGy d+veRUll91Dz+8MTdtyqyZvUW08kQyktiRYUW6diUnTFEZJobUBrPB8r4MQgn5U8+DyR sjcxVoCKjZZARfdAXIQx5yHBWrwvl74DquuqYVbzP6bHkrUH6keD9yJ5DKHaCtPbOrJg oadw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:mime-version:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:cc:date :message-id:in-reply-to:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=d/zAJGSH3BS9ooKMPOfkE1IuLWfafTNLFcyWr4aXdPY=; b=ixzRgZx2T9Jq9N7nNHSTn+RbOdOiaFyLBWrwdFiNqnyR5C/GoVS0hKkTSnI3aFk3Hx i4AlIXAZbv3jwIpC5tJnZvBoDGXn8mWarx3fpVsbIgnITnD/ReWi2XKWhL/2gsi0pCsj MXfKj9r1sAZBinH5HwXHugjke3AJYTXnz9+zDaaLyxgGObd6quDbWXL0xRB7yKX/CSM5 CUsF2zoKPh+qqEZ6YoOZM9AS0bTrO4Kpobdpa8gRvtWWXnXpoOyH/Z13zTRoJgrPERgo ex5iDEqgxVPTuVNKh4gjavWG1hA2xyLbKSy8rVkNGjgjYrULKrlf2aJFc3SrnsgFS89D jWkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NlhIPOyD; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id f18si2980052wmc.247.2018.03.01.11.42.58; Thu, 01 Mar 2018 11:42:58 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NlhIPOyD; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4F3EA267BF0; Thu, 1 Mar 2018 20:42:34 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1EE77267BDE; Thu, 1 Mar 2018 20:42:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id CF8F2267BD0 for ; Thu, 1 Mar 2018 20:42:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=9B02pccffQ8onETa3oEhZcHccjQHyNFgtzckew+zwp0=; b=NlhIPOyDRcmM ccrxo+FVU0baB+8gn4T6FxVvsQ6Go8492opS4SVX39o9T929z3TatfXN+u+F2ug0eFlZNcCGwDDkc Ehv/xormslpwXQtDBeUSbFxy9nlRcd4tDQu0vfunfTLm5gWAvRtcnMBj+O2qB6C2IXJa98mE7WH26 rj7gw=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1erU5u-0005na-WC; Thu, 01 Mar 2018 19:42:23 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1erU5u-0003SU-HN; Thu, 01 Mar 2018 19:42:22 +0000 From: Mark Brown To: Geert Uytterhoeven In-Reply-To: Message-Id: Date: Thu, 01 Mar 2018 19:42:22 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: rt5514: Fix uninitialized calibration value" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rt5514: Fix uninitialized calibration value has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 890861aa85043cc9d99a01e1bd26883722e95243 Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven Date: Tue, 30 Jan 2018 14:19:43 +0100 Subject: [PATCH] ASoC: rt5514: Fix uninitialized calibration value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With gcc-4.1.2, if CONFIG_SND_SOC_RT5514_SPI is not set: sound/soc/codecs/rt5514.c: In function ‘rt5514_dsp_voice_wake_up_put’: sound/soc/codecs/rt5514.c:363: warning: ‘buf[0]’ is used uninitialized in this function sound/soc/codecs/rt5514.c:363: warning: ‘buf[1]’ is used uninitialized in this function sound/soc/codecs/rt5514.c:363: warning: ‘buf[2]’ is used uninitialized in this function sound/soc/codecs/rt5514.c:363: warning: ‘buf[3]’ is used uninitialized in this function Fix this by initializing the buffer with zeroes, to avoid random bits being written to the calibration register later. Fixes: fc9cab05837639ce ("ASoC: rt5514: The DSP clock can be calibrated by the other clock source") Signed-off-by: Geert Uytterhoeven Signed-off-by: Mark Brown --- sound/soc/codecs/rt5514.c | 1 + 1 file changed, 1 insertion(+) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/rt5514.c b/sound/soc/codecs/rt5514.c index b358704ee19c..e8a66b03faab 100644 --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -357,6 +357,7 @@ static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol, #else dev_err(component->dev, "There is no SPI driver for" " loading the firmware\n"); + memset(buf, 0, sizeof(buf)); #endif rt5514->pll3_cal_value = buf[0] | buf[1] << 8 | buf[2] << 16 | buf[3] << 24;